[jira] [Assigned] (FLINK-10002) WebUI shows logs unfriendly, especially when the amount of logs is large

2018-09-11 Thread Jiayi Liao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiayi Liao reassigned FLINK-10002: -- Assignee: Jiayi Liao (was: zhangxinyu) > WebUI shows logs unfriendly, especially when the

[jira] [Created] (FLINK-10317) Configure Metaspace size by default

2018-09-11 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-10317: Summary: Configure Metaspace size by default Key: FLINK-10317 URL: https://issues.apache.org/jira/browse/FLINK-10317 Project: Flink Issue Type: Bug

[GitHub] azagrebin commented on a change in pull request #5876: [FLINK-9126] New CassandraPojoInputFormat to output data as a custom annotated Cassandra Pojo

2018-09-11 Thread GitBox
azagrebin commented on a change in pull request #5876: [FLINK-9126] New CassandraPojoInputFormat to output data as a custom annotated Cassandra Pojo URL: https://github.com/apache/flink/pull/5876#discussion_r207954696 ## File path:

[jira] [Commented] (FLINK-10301) Allow a custom Configuration in StreamNetworkBenchmarkEnvironment

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610317#comment-16610317 ] ASF GitHub Bot commented on FLINK-10301: NicoK commented on a change in pull request #6670:

[GitHub] NicoK commented on issue #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances

2018-09-11 Thread GitBox
NicoK commented on issue #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances URL: https://github.com/apache/flink/pull/6670#issuecomment-420183855 @zhijiangW I think, I already did by creating the overloaded

[jira] [Commented] (FLINK-10255) Standby Dispatcher locks submitted JobGraphs

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610263#comment-16610263 ] ASF GitHub Bot commented on FLINK-10255: tillrohrmann commented on issue #6678: [FLINK-10255]

[GitHub] tillrohrmann commented on issue #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader

2018-09-11 Thread GitBox
tillrohrmann commented on issue #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader URL: https://github.com/apache/flink/pull/6678#issuecomment-420190020 Thanks for the comments @TisonKun. I've fixed the failing `DispatcherTest#testOnAddedJobGraphWithFinishedJob`.

[jira] [Commented] (FLINK-9126) Creation of the CassandraPojoInputFormat class to output data into a Custom Cassandra Annotated Pojo

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610320#comment-16610320 ] ASF GitHub Bot commented on FLINK-9126: --- azagrebin commented on a change in pull request #5876:

[GitHub] lvhuyen commented on issue #6483: [FLINK-7243][flink-formats] Add parquet input format

2018-09-11 Thread GitBox
lvhuyen commented on issue #6483: [FLINK-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#issuecomment-420210267 Thank you @HuangZhenQiu. I created a [(quick patch),](https://github.com/lvhuyen/flink/tree/parquet_input_format(7243)) for

[jira] [Commented] (FLINK-7243) Add ParquetInputFormat

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610343#comment-16610343 ] ASF GitHub Bot commented on FLINK-7243: --- lvhuyen commented on issue #6483:

[GitHub] Clarkkkkk commented on a change in pull request #6679: [FLINK-10223][LOG]Logging with resourceId during taskmanager startup

2018-09-11 Thread GitBox
Clark commented on a change in pull request #6679: [FLINK-10223][LOG]Logging with resourceId during taskmanager startup URL: https://github.com/apache/flink/pull/6679#discussion_r216607537 ## File path:

[GitHub] Clarkkkkk commented on a change in pull request #6679: [FLINK-10223][LOG]Logging with resourceId during taskmanager startup

2018-09-11 Thread GitBox
Clark commented on a change in pull request #6679: [FLINK-10223][LOG]Logging with resourceId during taskmanager startup URL: https://github.com/apache/flink/pull/6679#discussion_r216607446 ## File path:

[jira] [Commented] (FLINK-10223) TaskManagers should log their ResourceID during startup

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610357#comment-16610357 ] ASF GitHub Bot commented on FLINK-10223: Clark commented on a change in pull request #6679:

[jira] [Commented] (FLINK-10306) Support the display of log file from any position on webUI

2018-09-11 Thread zhangxinyu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610151#comment-16610151 ] zhangxinyu commented on FLINK-10306: Ah, I think we can combine our ideas. For example, as you

[jira] [Commented] (FLINK-10306) Support the display of log file from any position on webUI

2018-09-11 Thread Jiayi Liao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610165#comment-16610165 ] Jiayi Liao commented on FLINK-10306: [~zhangxinyu] It makes sense. I think you can do these

[jira] [Commented] (FLINK-5784) TaskExecutor may register JobManagerLeaderListener in LeaderRetrievalService multiple times

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610227#comment-16610227 ] ASF GitHub Bot commented on FLINK-5784: --- ifndef-SleePy closed pull request #3296: [FLINK-5784] Fix

[jira] [Commented] (FLINK-9523) Add Kafka examples for Flink Table/SQL API

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610225#comment-16610225 ] ASF GitHub Bot commented on FLINK-9523: --- twalthr commented on a change in pull request #6672:

[jira] [Commented] (FLINK-9523) Add Kafka examples for Flink Table/SQL API

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610226#comment-16610226 ] ASF GitHub Bot commented on FLINK-9523: --- twalthr commented on a change in pull request #6672:

[GitHub] twalthr commented on a change in pull request #6672: [FLINK-9523] [table] Add Kafka examples for Flink Table/SQL API

2018-09-11 Thread GitBox
twalthr commented on a change in pull request #6672: [FLINK-9523] [table] Add Kafka examples for Flink Table/SQL API URL: https://github.com/apache/flink/pull/6672#discussion_r216575680 ## File path:

[GitHub] ifndef-SleePy closed pull request #3296: [FLINK-5784] Fix bug about registering JobManagerLeaderListener in LeaderRetrievalService multiple times

2018-09-11 Thread GitBox
ifndef-SleePy closed pull request #3296: [FLINK-5784] Fix bug about registering JobManagerLeaderListener in LeaderRetrievalService multiple times URL: https://github.com/apache/flink/pull/3296 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] NicoK commented on a change in pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances

2018-09-11 Thread GitBox
NicoK commented on a change in pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances URL: https://github.com/apache/flink/pull/6670#discussion_r216595121 ## File path:

[GitHub] NicoK commented on a change in pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances

2018-09-11 Thread GitBox
NicoK commented on a change in pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances URL: https://github.com/apache/flink/pull/6670#discussion_r216595121 ## File path:

[jira] [Commented] (FLINK-10301) Allow a custom Configuration in StreamNetworkBenchmarkEnvironment

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610315#comment-16610315 ] ASF GitHub Bot commented on FLINK-10301: NicoK commented on a change in pull request #6670:

[jira] [Commented] (FLINK-10247) Run MetricQueryService in separate thread pool

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610329#comment-16610329 ] ASF GitHub Bot commented on FLINK-10247: Clark commented on a change in pull request #6676:

[jira] [Commented] (FLINK-10247) Run MetricQueryService in separate thread pool

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610328#comment-16610328 ] ASF GitHub Bot commented on FLINK-10247: Clark commented on a change in pull request #6676:

[GitHub] Clarkkkkk commented on a change in pull request #6676: [FLINK-10247][Metrics] Run MetricQueryService in separate thread pool

2018-09-11 Thread GitBox
Clark commented on a change in pull request #6676: [FLINK-10247][Metrics] Run MetricQueryService in separate thread pool URL: https://github.com/apache/flink/pull/6676#discussion_r216597755 ## File path:

[jira] [Commented] (FLINK-10310) Cassandra Sink - Handling failing requests

2018-09-11 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610162#comment-16610162 ] Till Rohrmann commented on FLINK-10310: --- Having something similar to the

[jira] [Commented] (FLINK-10255) Standby Dispatcher locks submitted JobGraphs

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610223#comment-16610223 ] ASF GitHub Bot commented on FLINK-10255: tillrohrmann commented on a change in pull request

[jira] [Commented] (FLINK-10209) Exclude jdk.tools dependency from hadoop when running with java 9

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610288#comment-16610288 ] ASF GitHub Bot commented on FLINK-10209: StephanEwen commented on issue #6663:

[GitHub] StephanEwen commented on issue #6663: [FLINK-10209][build] Exclude jdk.tools dependency from hadoop

2018-09-11 Thread GitBox
StephanEwen commented on issue #6663: [FLINK-10209][build] Exclude jdk.tools dependency from hadoop URL: https://github.com/apache/flink/pull/6663#issuecomment-420195374 Thanks for the fix! I assume that it does not work to always exclude the dependency from Hadoop, in Java 8 as

[GitHub] Clarkkkkk commented on a change in pull request #6676: [FLINK-10247][Metrics] Run MetricQueryService in separate thread pool

2018-09-11 Thread GitBox
Clark commented on a change in pull request #6676: [FLINK-10247][Metrics] Run MetricQueryService in separate thread pool URL: https://github.com/apache/flink/pull/6676#discussion_r216598221 ## File path:

[jira] [Commented] (FLINK-10247) Run MetricQueryService in separate thread pool

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610331#comment-16610331 ] ASF GitHub Bot commented on FLINK-10247: Clark commented on a change in pull request #6676:

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-09-11 Thread Wei-Che Wei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610365#comment-16610365 ] Wei-Che Wei commented on FLINK-9486: Hi [~srichter] Can time service be migrated from heap-based to

[GitHub] zhijiangW commented on issue #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances

2018-09-11 Thread GitBox
zhijiangW commented on issue #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances URL: https://github.com/apache/flink/pull/6670#issuecomment-420172687 @NicoK Thank you for the changes and it can help for adjusting netty related

[jira] [Commented] (FLINK-10223) TaskManagers should log their ResourceID during startup

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610358#comment-16610358 ] ASF GitHub Bot commented on FLINK-10223: Clark commented on a change in pull request #6679:

[jira] [Commented] (FLINK-10301) Allow a custom Configuration in StreamNetworkBenchmarkEnvironment

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610190#comment-16610190 ] ASF GitHub Bot commented on FLINK-10301: zhijiangW commented on issue #6670:

[jira] [Commented] (FLINK-10301) Allow a custom Configuration in StreamNetworkBenchmarkEnvironment

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610294#comment-16610294 ] ASF GitHub Bot commented on FLINK-10301: zhijiangW commented on a change in pull request #6670:

[GitHub] zhijiangW commented on a change in pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances

2018-09-11 Thread GitBox
zhijiangW commented on a change in pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances URL: https://github.com/apache/flink/pull/6670#discussion_r216565959 ## File path:

[GitHub] StephanEwen commented on issue #6608: [FLINK-10203]Support truncate method for old Hadoop versions in HadoopRecoverableFsDataOutputStream

2018-09-11 Thread GitBox
StephanEwen commented on issue #6608: [FLINK-10203]Support truncate method for old Hadoop versions in HadoopRecoverableFsDataOutputStream URL: https://github.com/apache/flink/pull/6608#issuecomment-420199851 We were of at the Flink Forward conference the last week, so slow progress on

[jira] [Commented] (FLINK-10203) Support truncate method for old Hadoop versions in HadoopRecoverableFsDataOutputStream

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610310#comment-16610310 ] ASF GitHub Bot commented on FLINK-10203: StephanEwen commented on issue #6608:

[jira] [Assigned] (FLINK-10002) WebUI shows logs unfriendly, especially when the amount of logs is large

2018-09-11 Thread Jiayi Liao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiayi Liao reassigned FLINK-10002: -- Assignee: zhangxinyu (was: Jiayi Liao) > WebUI shows logs unfriendly, especially when the

[GitHub] tillrohrmann commented on a change in pull request #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader

2018-09-11 Thread GitBox
tillrohrmann commented on a change in pull request #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader URL: https://github.com/apache/flink/pull/6678#discussion_r216575018 ## File path:

[jira] [Commented] (FLINK-10301) Allow a custom Configuration in StreamNetworkBenchmarkEnvironment

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610235#comment-16610235 ] ASF GitHub Bot commented on FLINK-10301: NicoK commented on issue #6670: [FLINK-10301][network]

[jira] [Commented] (FLINK-10291) Generate JobGraph with fixed/configurable JobID in StandaloneJobClusterEntrypoint

2018-09-11 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610345#comment-16610345 ] vinoyang commented on FLINK-10291: -- [~till.rohrmann] If you are busy, I am going to try to start

[jira] [Created] (FLINK-10318) Add option to build Hadoop-free job image to build.sh

2018-09-11 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-10318: --- Summary: Add option to build Hadoop-free job image to build.sh Key: FLINK-10318 URL: https://issues.apache.org/jira/browse/FLINK-10318 Project: Flink Issue

[GitHub] Clarkkkkk commented on issue #6677: [hotfix] [kubernetes] correct exception typo

2018-09-11 Thread GitBox
Clark commented on issue #6677: [hotfix] [kubernetes] correct exception typo URL: https://github.com/apache/flink/pull/6677#issuecomment-420213455 +1 This is an automated message from the Apache Git Service. To respond to

[jira] [Closed] (FLINK-5784) TaskExecutor may register JobManagerLeaderListener in LeaderRetrievalService multiple times

2018-09-11 Thread Biao Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Liu closed FLINK-5784. --- Resolution: Won't Fix This bug is already fixed by Till in a different way, abandon this > TaskExecutor may

[GitHub] twalthr commented on a change in pull request #6672: [FLINK-9523] [table] Add Kafka examples for Flink Table/SQL API

2018-09-11 Thread GitBox
twalthr commented on a change in pull request #6672: [FLINK-9523] [table] Add Kafka examples for Flink Table/SQL API URL: https://github.com/apache/flink/pull/6672#discussion_r216575925 ## File path:

[GitHub] Clarkkkkk commented on a change in pull request #6676: [FLINK-10247][Metrics] Run MetricQueryService in separate thread pool

2018-09-11 Thread GitBox
Clark commented on a change in pull request #6676: [FLINK-10247][Metrics] Run MetricQueryService in separate thread pool URL: https://github.com/apache/flink/pull/6676#discussion_r216597691 ## File path:

[jira] [Commented] (FLINK-10258) Allow streaming sources to be present for batch executions

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610480#comment-16610480 ] ASF GitHub Bot commented on FLINK-10258: Clark commented on issue #6675: [FLINK-10258]

[jira] [Commented] (FLINK-10258) Allow streaming sources to be present for batch executions

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610481#comment-16610481 ] ASF GitHub Bot commented on FLINK-10258: Clark removed a comment on issue #6675:

[jira] [Commented] (FLINK-10258) Allow streaming sources to be present for batch executions

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610482#comment-16610482 ] ASF GitHub Bot commented on FLINK-10258: Clark commented on issue #6675: [FLINK-10258]

[GitHub] Clarkkkkk commented on issue #6675: [FLINK-10258] [sql-client] Allow streaming sources to be present for batch executions

2018-09-11 Thread GitBox
Clark commented on issue #6675: [FLINK-10258] [sql-client] Allow streaming sources to be present for batch executions URL: https://github.com/apache/flink/pull/6675#issuecomment-420245689 I am not sure if there's any batch source or sink need to validate the update mode, but seems

[jira] [Commented] (FLINK-10267) [State] Fix arbitrary iterator access on RocksDBMapIterator

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610569#comment-16610569 ] ASF GitHub Bot commented on FLINK-10267: StefanRRichter commented on issue #6638:

[jira] [Commented] (FLINK-9523) Add Kafka examples for Flink Table/SQL API

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610502#comment-16610502 ] ASF GitHub Bot commented on FLINK-9523: --- SokolovMS commented on a change in pull request #6672:

[GitHub] SokolovMS commented on a change in pull request #6672: [FLINK-9523] [table] Add Kafka examples for Flink Table/SQL API

2018-09-11 Thread GitBox
SokolovMS commented on a change in pull request #6672: [FLINK-9523] [table] Add Kafka examples for Flink Table/SQL API URL: https://github.com/apache/flink/pull/6672#discussion_r216642798 ## File path:

[GitHub] Clarkkkkk commented on issue #6675: [FLINK-10258] [sql-client] Allow streaming sources to be present for batch executions

2018-09-11 Thread GitBox
Clark commented on issue #6675: [FLINK-10258] [sql-client] Allow streaming sources to be present for batch executions URL: https://github.com/apache/flink/pull/6675#issuecomment-420243230 Hi @yanghua, I think this is the problem of CsvTableSource and Sink factory. We can resolve this

[jira] [Commented] (FLINK-10258) Allow streaming sources to be present for batch executions

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610470#comment-16610470 ] ASF GitHub Bot commented on FLINK-10258: Clark commented on issue #6675: [FLINK-10258]

[GitHub] Clarkkkkk commented on issue #6675: [FLINK-10258] [sql-client] Allow streaming sources to be present for batch executions

2018-09-11 Thread GitBox
Clark commented on issue #6675: [FLINK-10258] [sql-client] Allow streaming sources to be present for batch executions URL: https://github.com/apache/flink/pull/6675#issuecomment-420244750 Hi @yanghua, I think this is the problem of CsvTableSource and Sink factory. We can resolve this

[jira] [Commented] (FLINK-10258) Allow streaming sources to be present for batch executions

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610476#comment-16610476 ] ASF GitHub Bot commented on FLINK-10258: Clark removed a comment on issue #6675:

[GitHub] Clarkkkkk removed a comment on issue #6675: [FLINK-10258] [sql-client] Allow streaming sources to be present for batch executions

2018-09-11 Thread GitBox
Clark removed a comment on issue #6675: [FLINK-10258] [sql-client] Allow streaming sources to be present for batch executions URL: https://github.com/apache/flink/pull/6675#issuecomment-420243230 Hi @yanghua, I think this is the problem of CsvTableSource and Sink factory. We can

[jira] [Commented] (FLINK-10258) Allow streaming sources to be present for batch executions

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610477#comment-16610477 ] ASF GitHub Bot commented on FLINK-10258: Clark commented on issue #6675: [FLINK-10258]

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-09-11 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610497#comment-16610497 ] Stefan Richter commented on FLINK-9486: --- Hi, you can migrate an old savepoint from earlier Flink

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-09-11 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610602#comment-16610602 ] Stefan Richter commented on FLINK-9486: --- Exactly, that's how it is right now. In the future, we are

[GitHub] asfgit closed pull request #6638: [FLINK-10267][State] Fix arbitrary iterator access on RocksDBMapIterator

2018-09-11 Thread GitBox
asfgit closed pull request #6638: [FLINK-10267][State] Fix arbitrary iterator access on RocksDBMapIterator URL: https://github.com/apache/flink/pull/6638 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[jira] [Commented] (FLINK-10267) [State] Fix arbitrary iterator access on RocksDBMapIterator

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610573#comment-16610573 ] ASF GitHub Bot commented on FLINK-10267: asfgit closed pull request #6638: [FLINK-10267][State]

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-09-11 Thread Wei-Che Wei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610597#comment-16610597 ] Wei-Che Wei commented on FLINK-9486: Hi [~srichter], If I didn't misunderstand. The timer has been

[jira] [Closed] (FLINK-10267) [State] Fix arbitrary iterator access on RocksDBMapIterator

2018-09-11 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-10267. -- Resolution: Fixed Merged in: master: 16dc5978c7 release-1.6: a19e1ee3ba release-1.5:

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-09-11 Thread Wei-Che Wei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610615#comment-16610615 ] Wei-Che Wei commented on FLINK-9486: It's clear to me now. Thanks! > Introduce TimerState in keyed

[jira] [Commented] (FLINK-10306) Support the display of log file from any position on webUI

2018-09-11 Thread zhangxinyu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610460#comment-16610460 ] zhangxinyu commented on FLINK-10306: Ok, I will implement your ideas these days. > Support the

[GitHub] StefanRRichter commented on issue #6638: [FLINK-10267][State] Fix arbitrary iterator access on RocksDBMapIterator

2018-09-11 Thread GitBox
StefanRRichter commented on issue #6638: [FLINK-10267][State] Fix arbitrary iterator access on RocksDBMapIterator URL: https://github.com/apache/flink/pull/6638#issuecomment-420272898 Thanks for the contribution! Looks good for me as well  Merging.

[GitHub] Clarkkkkk commented on issue #6675: [FLINK-10258] [sql-client] Allow streaming sources to be present for batch executions

2018-09-11 Thread GitBox
Clark commented on issue #6675: [FLINK-10258] [sql-client] Allow streaming sources to be present for batch executions URL: https://github.com/apache/flink/pull/6675#issuecomment-420245599 I am not sure if there's any source or sink need to validate the update mode, but seems like we

[GitHub] Clarkkkkk removed a comment on issue #6675: [FLINK-10258] [sql-client] Allow streaming sources to be present for batch executions

2018-09-11 Thread GitBox
Clark removed a comment on issue #6675: [FLINK-10258] [sql-client] Allow streaming sources to be present for batch executions URL: https://github.com/apache/flink/pull/6675#issuecomment-420245599 I am not sure if there's any source or sink need to validate the update mode, but seems

[jira] [Commented] (FLINK-10245) Add DataStream HBase Sink

2018-09-11 Thread Shimin Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611491#comment-16611491 ] Shimin Yang commented on FLINK-10245: - [~hequn8128], we may make the deduplication as an

[jira] [Commented] (FLINK-7243) Add ParquetInputFormat

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611563#comment-16611563 ] ASF GitHub Bot commented on FLINK-7243: --- HuangZhenQiu commented on issue #6483:

[jira] [Commented] (FLINK-10245) Add DataStream HBase Sink

2018-09-11 Thread Shimin Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611487#comment-16611487 ] Shimin Yang commented on FLINK-10245: - Hi [~hequn8128],I have been thinking about should we allow

[GitHub] TisonKun opened a new pull request #6680: [FLINK-10319] [runtime] Avoid requestPartitionState from JM but alway…

2018-09-11 Thread GitBox
TisonKun opened a new pull request #6680: [FLINK-10319] [runtime] Avoid requestPartitionState from JM but alway… URL: https://github.com/apache/flink/pull/6680 …s try retrigger ## What is the purpose of the change Do not requestPartitionState from JM on partition request

[jira] [Commented] (FLINK-9913) Improve output serialization only once in RecordWriter

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611470#comment-16611470 ] ASF GitHub Bot commented on FLINK-9913: --- zhijiangW commented on issue #6417: [FLINK-9913][runtime]

[GitHub] walterddr commented on a change in pull request #6622: [FLINK-10222] [table] Table scalar function expression parses error when function name equals the exists keyword suffix

2018-09-11 Thread GitBox
walterddr commented on a change in pull request #6622: [FLINK-10222] [table] Table scalar function expression parses error when function name equals the exists keyword suffix URL: https://github.com/apache/flink/pull/6622#discussion_r216891057 ## File path:

[GitHub] walterddr commented on a change in pull request #6622: [FLINK-10222] [table] Table scalar function expression parses error when function name equals the exists keyword suffix

2018-09-11 Thread GitBox
walterddr commented on a change in pull request #6622: [FLINK-10222] [table] Table scalar function expression parses error when function name equals the exists keyword suffix URL: https://github.com/apache/flink/pull/6622#discussion_r216891199 ## File path:

[jira] [Commented] (FLINK-10222) Table scalar function expression parses error when function name equals the exists keyword suffix

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611559#comment-16611559 ] ASF GitHub Bot commented on FLINK-10222: walterddr commented on a change in pull request #6622:

[jira] [Commented] (FLINK-10222) Table scalar function expression parses error when function name equals the exists keyword suffix

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611560#comment-16611560 ] ASF GitHub Bot commented on FLINK-10222: walterddr commented on a change in pull request #6622:

[jira] [Commented] (FLINK-10247) Run MetricQueryService in separate thread pool

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611496#comment-16611496 ] ASF GitHub Bot commented on FLINK-10247: Clark commented on issue #6676:

[GitHub] Clarkkkkk commented on issue #6676: [FLINK-10247][Metrics] Run MetricQueryService in separate thread pool

2018-09-11 Thread GitBox
Clark commented on issue #6676: [FLINK-10247][Metrics] Run MetricQueryService in separate thread pool URL: https://github.com/apache/flink/pull/6676#issuecomment-420492672 Hi @tillrohrmann , could you please review this PR when you have time?

[jira] [Commented] (FLINK-10319) Avoid requestPartitionState from JM but always try retrigger

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611552#comment-16611552 ] ASF GitHub Bot commented on FLINK-10319: TisonKun opened a new pull request #6680: [FLINK-10319]

[jira] [Updated] (FLINK-10319) Avoid requestPartitionState from JM but always try retrigger

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10319: --- Labels: pull-request-available (was: ) > Avoid requestPartitionState from JM but always

[jira] [Commented] (FLINK-10223) TaskManagers should log their ResourceID during startup

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611364#comment-16611364 ] ASF GitHub Bot commented on FLINK-10223: Aitozi commented on a change in pull request #6679:

[GitHub] Aitozi commented on a change in pull request #6679: [FLINK-10223][LOG]Logging with resourceId during taskmanager startup

2018-09-11 Thread GitBox
Aitozi commented on a change in pull request #6679: [FLINK-10223][LOG]Logging with resourceId during taskmanager startup URL: https://github.com/apache/flink/pull/6679#discussion_r216853295 ## File path:

[GitHub] zhijiangW commented on issue #6417: [FLINK-9913][runtime] Improve output serialization only once in RecordWriter

2018-09-11 Thread GitBox
zhijiangW commented on issue #6417: [FLINK-9913][runtime] Improve output serialization only once in RecordWriter URL: https://github.com/apache/flink/pull/6417#issuecomment-420486898 Thanks for that. I will also try best to monitor the performance changes for these cases later. :)

[jira] [Created] (FLINK-10319) Avoid requestPartitionState from JM but always try retrigger

2018-09-11 Thread JIRA
陈梓立 created FLINK-10319: --- Summary: Avoid requestPartitionState from JM but always try retrigger Key: FLINK-10319 URL: https://issues.apache.org/jira/browse/FLINK-10319 Project: Flink Issue Type:

[GitHub] HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet input format

2018-09-11 Thread GitBox
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#issuecomment-420505649 @lvhuyen Thanks for the quick patch. I think the data conversion should be handled in RowConverter. I will ship a fix

[jira] [Commented] (FLINK-10275) StreamTask support object reuse

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610674#comment-16610674 ] ASF GitHub Bot commented on FLINK-10275: TisonKun commented on issue #6643: [FLINK-10275]

[GitHub] TisonKun commented on issue #6643: [FLINK-10275] StreamTask support object reuse

2018-09-11 Thread GitBox
TisonKun commented on issue #6643: [FLINK-10275] StreamTask support object reuse URL: https://github.com/apache/flink/pull/6643#issuecomment-420289282 @kl0u Thanks for comments! I would clean this PR and emphases the main changes later. Recently working on other threads, ping here once

[GitHub] NicoK commented on issue #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances

2018-09-11 Thread GitBox
NicoK commented on issue #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances URL: https://github.com/apache/flink/pull/6670#issuecomment-420295302 @pnowojski I assume the same thing :) - `BUFFER_SIZE` still uses the default

[jira] [Commented] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610707#comment-16610707 ] ASF GitHub Bot commented on FLINK-10057: StefanRRichter commented on a change in pull request

[jira] [Commented] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

2018-09-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610708#comment-16610708 ] ASF GitHub Bot commented on FLINK-10057: StefanRRichter commented on a change in pull request

[GitHub] StefanRRichter commented on a change in pull request #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-09-11 Thread GitBox
StefanRRichter commented on a change in pull request #6491: [FLINK-10057] Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491#discussion_r216691577 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ## @@

[GitHub] StefanRRichter commented on a change in pull request #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-09-11 Thread GitBox
StefanRRichter commented on a change in pull request #6491: [FLINK-10057] Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491#discussion_r216691558 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ## @@

[GitHub] yanghua commented on issue #6659: [FLINK-10281] [table] Table function parse regular expression contains backslash failed

2018-09-11 Thread GitBox
yanghua commented on issue #6659: [FLINK-10281] [table] Table function parse regular expression contains backslash failed URL: https://github.com/apache/flink/pull/6659#issuecomment-420317010 PR #6671 fixed it more graciously, so closing this PR. thanks @twalthr

[GitHub] yanghua closed pull request #6659: [FLINK-10281] [table] Table function parse regular expression contains backslash failed

2018-09-11 Thread GitBox
yanghua closed pull request #6659: [FLINK-10281] [table] Table function parse regular expression contains backslash failed URL: https://github.com/apache/flink/pull/6659 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

  1   2   >