[GitHub] [flink] kezhuw commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop

2019-05-14 Thread GitBox
kezhuw commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#discussion_r283894577 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8390: [FLINK-12469][table] Clean up catalog API on default/current database

2019-05-14 Thread GitBox
xuefuz commented on a change in pull request #8390: [FLINK-12469][table] Clean up catalog API on default/current database URL: https://github.com/apache/flink/pull/8390#discussion_r283902136 ## File path:

[GitHub] [flink] walterddr commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-14 Thread GitBox
walterddr commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#discussion_r283907768 ## File path: flink-ml/flink-ml-api/src/main/java/org/apache/flink/ml/api/core/Pipeline.java

[GitHub] [flink] bowenli86 commented on issue #8433: [FLINK-12505][hive] Unify database operations to HiveCatalogBase from its subclasses

2019-05-14 Thread GitBox
bowenli86 commented on issue #8433: [FLINK-12505][hive] Unify database operations to HiveCatalogBase from its subclasses URL: https://github.com/apache/flink/pull/8433#issuecomment-492395677 merging... This is an automated

[GitHub] [flink] bowenli86 commented on issue #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog

2019-05-14 Thread GitBox
bowenli86 commented on issue #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8434#issuecomment-492395614 merging... This is an automated message from the

[GitHub] [flink] walterddr commented on a change in pull request #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate

2019-05-14 Thread GitBox
walterddr commented on a change in pull request #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate URL: https://github.com/apache/flink/pull/8389#discussion_r283906054 ## File path:

[GitHub] [flink] StefanRRichter edited a comment on issue #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop

2019-05-14 Thread GitBox
StefanRRichter edited a comment on issue #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#issuecomment-492336130 Maybe to extend the explanation a bit, the `MailboxSender` interface is in function similar to the `Executor`

[GitHub] [flink] dawidwys commented on issue #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs

2019-05-14 Thread GitBox
dawidwys commented on issue #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs URL: https://github.com/apache/flink/pull/8404#issuecomment-492337827 @bowenli86 The goal is to have a common `TableEnvironment` for both blink planner and legacy/flink planner. The

[jira] [Commented] (FLINK-12504) NullPoint here NullPointException there.. It's every where

2019-05-14 Thread Ken Krugler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839718#comment-16839718 ] Ken Krugler commented on FLINK-12504: - If I Google "Flink user mailing list", the first hit is for 

[GitHub] [flink] StefanRRichter commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop

2019-05-14 Thread GitBox
StefanRRichter commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#discussion_r283917456 ## File path:

[GitHub] [flink] yanyan300300 commented on a change in pull request #8215: [FLINK-8801][yarn/s3] Fix jars downloading issues due to inconsistent timestamp in S3 Filesystem

2019-05-14 Thread GitBox
yanyan300300 commented on a change in pull request #8215: [FLINK-8801][yarn/s3] Fix jars downloading issues due to inconsistent timestamp in S3 Filesystem URL: https://github.com/apache/flink/pull/8215#discussion_r283919936 ## File path:

[GitHub] [flink] bowenli86 commented on issue #8390: [FLINK-12469][table] Clean up catalog API on default/current database

2019-05-14 Thread GitBox
bowenli86 commented on issue #8390: [FLINK-12469][table] Clean up catalog API on default/current database URL: https://github.com/apache/flink/pull/8390#issuecomment-492316450 merging... This is an automated message from the

[GitHub] [flink] walterddr commented on issue #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate

2019-05-14 Thread GitBox
walterddr commented on issue #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate URL: https://github.com/apache/flink/pull/8389#issuecomment-492325084 @godfreyhe yeah you are right. this is not exactly "explain source", ideally speaking we need to

[GitHub] [flink] dawidwys commented on a change in pull request #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs

2019-05-14 Thread GitBox
dawidwys commented on a change in pull request #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs URL: https://github.com/apache/flink/pull/8404#discussion_r283915654 ## File path:

[GitHub] [flink] asfgit closed pull request #8390: [FLINK-12469][table] Clean up catalog API on default/current database

2019-05-14 Thread GitBox
asfgit closed pull request #8390: [FLINK-12469][table] Clean up catalog API on default/current database URL: https://github.com/apache/flink/pull/8390 This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] dawidwys commented on a change in pull request #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs

2019-05-14 Thread GitBox
dawidwys commented on a change in pull request #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs URL: https://github.com/apache/flink/pull/8404#discussion_r283916005 ## File path:

[GitHub] [flink] StefanRRichter commented on issue #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop

2019-05-14 Thread GitBox
StefanRRichter commented on issue #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#issuecomment-492336130 Maybe to extend the explanation a bit, the `MailboxSender` interface is in function not unlike the `Executor` interface.

[jira] [Closed] (FLINK-12469) Clean up catalog API on default/current DB

2019-05-14 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12469. Resolution: Fixed Fix Version/s: 1.9.0 merged in 1.9.0: 1c3ac2f82b707ae12556a5883980da8050510244

[GitHub] [flink] xuefuz commented on a change in pull request #8433: [FLINK-12505][hive] Unify database operations to HiveCatalogBase from its subclasses

2019-05-14 Thread GitBox
xuefuz commented on a change in pull request #8433: [FLINK-12505][hive] Unify database operations to HiveCatalogBase from its subclasses URL: https://github.com/apache/flink/pull/8433#discussion_r283934117 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog

2019-05-14 Thread GitBox
bowenli86 commented on a change in pull request #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8434#discussion_r283981020 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop

2019-05-14 Thread GitBox
StefanRRichter commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#discussion_r283897469 ## File path:

[GitHub] [flink] Aitozi commented on issue #8442: [FLINK-12483] Support (legacy) SourceFunction as special case in the mailbox model for stream tasks

2019-05-14 Thread GitBox
Aitozi commented on issue #8442: [FLINK-12483] Support (legacy) SourceFunction as special case in the mailbox model for stream tasks URL: https://github.com/apache/flink/pull/8442#issuecomment-492317014 Thanks for explanation @StefanRRichter , +1 from my side.

[GitHub] [flink] walterddr commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-14 Thread GitBox
walterddr commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#issuecomment-492319100 @flinkbot attention @KurtYoung This is an automated message from the

[GitHub] [flink] flinkbot edited a comment on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-14 Thread GitBox
flinkbot edited a comment on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#issuecomment-488032392 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[GitHub] [flink] kezhuw commented on issue #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop

2019-05-14 Thread GitBox
kezhuw commented on issue #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#issuecomment-492331773 @StefanRRichter After read through https://docs.google.com/document/d/1eDpsUKv2FqwZiS1Pm6gYO5eFHScBHfULKmH1-ZEWB4g, I have some

[GitHub] [flink] dawidwys edited a comment on issue #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs

2019-05-14 Thread GitBox
dawidwys edited a comment on issue #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs URL: https://github.com/apache/flink/pull/8404#issuecomment-492337827 @bowenli86 The goal is to have a common `TableEnvironment` for both blink planner and legacy/flink

[jira] [Comment Edited] (FLINK-7697) Add metrics for Elasticsearch Sink

2019-05-14 Thread Piyush Goyal (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837512#comment-16837512 ] Piyush Goyal edited comment on FLINK-7697 at 5/14/19 7:00 PM: -- +1 on adding

[jira] [Comment Edited] (FLINK-7697) Add metrics for Elasticsearch Sink

2019-05-14 Thread Piyush Goyal (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837512#comment-16837512 ] Piyush Goyal edited comment on FLINK-7697 at 5/14/19 7:01 PM: -- +1 on adding

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283961380 ## File path: docs/dev/stream/testing.md ## @@ -181,85 +430,76 @@ public class ExampleIntegrationTest

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283959368 ## File path: docs/dev/stream/testing.md ## @@ -181,85 +430,76 @@ public class ExampleIntegrationTest

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283957833 ## File path: docs/dev/stream/testing.md ## @@ -23,138 +23,387 @@ specific language governing permissions

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283954443 ## File path: docs/dev/stream/testing.md ## @@ -23,138 +23,387 @@ specific language governing permissions

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283958605 ## File path: docs/dev/stream/testing.md ## @@ -181,85 +430,76 @@ public class ExampleIntegrationTest

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283963231 ## File path: docs/dev/stream/testing.md ## @@ -23,138 +23,387 @@ specific language governing permissions

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283951933 ## File path: docs/dev/stream/testing.md ## @@ -23,138 +23,387 @@ specific language governing permissions

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283954075 ## File path: docs/dev/stream/testing.md ## @@ -23,138 +23,387 @@ specific language governing permissions

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283959906 ## File path: docs/dev/stream/testing.md ## @@ -181,85 +430,76 @@ public class ExampleIntegrationTest

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283962452 ## File path: docs/dev/stream/testing.md ## @@ -181,85 +430,76 @@ public class ExampleIntegrationTest

[GitHub] [flink] bowenli86 commented on a change in pull request #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog

2019-05-14 Thread GitBox
bowenli86 commented on a change in pull request #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8434#discussion_r283981020 ## File path:

[jira] [Created] (FLINK-12511) make variable "comment" in all catalog metadata classes final

2019-05-14 Thread Bowen Li (JIRA)
Bowen Li created FLINK-12511: Summary: make variable "comment" in all catalog metadata classes final Key: FLINK-12511 URL: https://issues.apache.org/jira/browse/FLINK-12511 Project: Flink

[GitHub] [flink] kezhuw commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop

2019-05-14 Thread GitBox
kezhuw commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#discussion_r283916080 ## File path:

[GitHub] [flink] kezhuw commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop

2019-05-14 Thread GitBox
kezhuw commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#discussion_r283892928 ## File path:

[GitHub] [flink] StefanRRichter commented on issue #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop

2019-05-14 Thread GitBox
StefanRRichter commented on issue #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#issuecomment-492334593 @kezhuw the letters will always be just `Runnable`, and right now there are two cases: checkpoint trigger and processing

[GitHub] [flink] dawidwys commented on a change in pull request #8390: [FLINK-12469][table] Clean up catalog API on default/current database

2019-05-14 Thread GitBox
dawidwys commented on a change in pull request #8390: [FLINK-12469][table] Clean up catalog API on default/current database URL: https://github.com/apache/flink/pull/8390#discussion_r283833595 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8390: [FLINK-12469][table] Clean up catalog API on default/current database

2019-05-14 Thread GitBox
dawidwys commented on a change in pull request #8390: [FLINK-12469][table] Clean up catalog API on default/current database URL: https://github.com/apache/flink/pull/8390#discussion_r283833595 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog

2019-05-14 Thread GitBox
xuefuz commented on a change in pull request #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8434#discussion_r283925761 ## File path:

[GitHub] [flink] skidder opened a new pull request #8444: [FLINK-10190] [Kinesis Connector] Allow AWS_REGION to be supplied along with custom Kinesis endpoint

2019-05-14 Thread GitBox
skidder opened a new pull request #8444: [FLINK-10190] [Kinesis Connector] Allow AWS_REGION to be supplied along with custom Kinesis endpoint URL: https://github.com/apache/flink/pull/8444 ## What is the purpose of the change Allow an AWS region (e.g. `us-east-1`) to be supplied

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283958118 ## File path: docs/dev/stream/testing.md ## @@ -23,138 +23,387 @@ specific language governing permissions

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283952634 ## File path: docs/dev/stream/testing.md ## @@ -23,138 +23,387 @@ specific language governing permissions

[GitHub] [flink] flinkbot commented on issue #8444: [FLINK-10190] [Kinesis Connector] Allow AWS_REGION to be supplied along with custom Kinesis endpoint

2019-05-14 Thread GitBox
flinkbot commented on issue #8444: [FLINK-10190] [Kinesis Connector] Allow AWS_REGION to be supplied along with custom Kinesis endpoint URL: https://github.com/apache/flink/pull/8444#issuecomment-492376902 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot.

[jira] [Updated] (FLINK-10190) Unable to use custom endpoint in Kinesis producer

2019-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10190: --- Labels: pull-request-available (was: ) > Unable to use custom endpoint in Kinesis producer

[jira] [Commented] (FLINK-5243) Implement an example for BipartiteGraph

2019-05-14 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839117#comment-16839117 ] Ivan Mushketyk commented on FLINK-5243: --- Sure Jasleen. Go ahead. > Implement an example for

[GitHub] [flink] JingsongLi commented on issue #8397: [FLINK-11421][Table SQL/Runtime]Add compilation options to allow comp…

2019-05-14 Thread GitBox
JingsongLi commented on issue #8397: [FLINK-11421][Table SQL/Runtime]Add compilation options to allow comp… URL: https://github.com/apache/flink/pull/8397#issuecomment-492102837 I think you should add some detailed benchmarks, as we discussed in JIRA.

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283648244 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283653711 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
wuchong commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283657779 ## File path:

[jira] [Commented] (FLINK-12501) AvroTypeSerializer does not work with types generated by avrohugger

2019-05-14 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839191#comment-16839191 ] Tzu-Li (Gordon) Tai commented on FLINK-12501: - +1 to fix this. This was also reported

[GitHub] [flink] Aitozi commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop

2019-05-14 Thread GitBox
Aitozi commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#discussion_r28364 ## File path:

[GitHub] [flink] Aitozi commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop

2019-05-14 Thread GitBox
Aitozi commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#discussion_r283648909 ## File path:

[GitHub] [flink] Aitozi commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop

2019-05-14 Thread GitBox
Aitozi commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#discussion_r283674851 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283684788 ## File path:

[jira] [Commented] (FLINK-12501) AvroTypeSerializer does not work with types generated by avrohugger

2019-05-14 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839211#comment-16839211 ] Tzu-Li (Gordon) Tai commented on FLINK-12501: - This is really a problem with how avrohugger

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283689574 ## File path:

[GitHub] [flink] tillrohrmann closed pull request #8400: [FLINK-12472][yarn] Support setting attemptFailuresValidityInterval o…

2019-05-14 Thread GitBox
tillrohrmann closed pull request #8400: [FLINK-12472][yarn] Support setting attemptFailuresValidityInterval o… URL: https://github.com/apache/flink/pull/8400 This is an automated message from the Apache Git Service. To

[GitHub] [flink] tillrohrmann closed pull request #8396: [FLINK-12468][yarn] Unregister application from the YARN Resource Man…

2019-05-14 Thread GitBox
tillrohrmann closed pull request #8396: [FLINK-12468][yarn] Unregister application from the YARN Resource Man… URL: https://github.com/apache/flink/pull/8396 This is an automated message from the Apache Git Service. To

[GitHub] [flink] tillrohrmann closed pull request #8415: [FLINK-12260] [Runtime/Coordination] Slot allocation failure by taskmanager registration tim…

2019-05-14 Thread GitBox
tillrohrmann closed pull request #8415: [FLINK-12260] [Runtime/Coordination] Slot allocation failure by taskmanager registration tim… URL: https://github.com/apache/flink/pull/8415 This is an automated message from the

[jira] [Resolved] (FLINK-12468) Unregister application from the YARN Resource Manager with a valid appTrackingUrl

2019-05-14 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-12468. --- Resolution: Fixed Fix Version/s: 1.9.0 Merged via

[jira] [Updated] (FLINK-10837) Kafka 2.0 test KafkaITCase.testOneToOneSources dead locked on deleteTestTopic?

2019-05-14 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-10837: --- Affects Version/s: 1.8.0 > Kafka 2.0 test KafkaITCase.testOneToOneSources dead locked on

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283687864 ## File path:

[GitHub] [flink] StefanRRichter commented on issue #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop

2019-05-14 Thread GitBox
StefanRRichter commented on issue #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#issuecomment-492148896 @Aitozi about the travis ci failure, I think it is unrelated to this PR because I can see that it happens for a batch job

[GitHub] [flink] StefanRRichter edited a comment on issue #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop

2019-05-14 Thread GitBox
StefanRRichter edited a comment on issue #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#issuecomment-492148896 @Aitozi about the travis ci failure, I think it is unrelated to this PR because I can see that it happens for a

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283691935 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283645950 ## File path:

[GitHub] [flink] dawidwys commented on issue #8419: [hotfix][examples] Fix the streaming example of TopSpeedWindowing 's increased distance in 100ms

2019-05-14 Thread GitBox
dawidwys commented on issue #8419: [hotfix][examples] Fix the streaming example of TopSpeedWindowing 's increased distance in 100ms URL: https://github.com/apache/flink/pull/8419#issuecomment-492100427 @flinkbot approve description

[GitHub] [flink] flinkbot edited a comment on issue #8419: [hotfix][examples] Fix the streaming example of TopSpeedWindowing 's increased distance in 100ms

2019-05-14 Thread GitBox
flinkbot edited a comment on issue #8419: [hotfix][examples] Fix the streaming example of TopSpeedWindowing 's increased distance in 100ms URL: https://github.com/apache/flink/pull/8419#issuecomment-491564526 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283646821 ## File path:

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283645152 ## File path:

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283643553 ## File path:

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283645513 ## File path:

[GitHub] [flink] YueYeShen commented on issue #8384: [FLINK-11610][docs-zh] Translate the "Examples" page into Chinese

2019-05-14 Thread GitBox
YueYeShen commented on issue #8384: [FLINK-11610][docs-zh] Translate the "Examples" page into Chinese URL: https://github.com/apache/flink/pull/8384#issuecomment-492102056 > Thanks @YueYeShen , the translation looks good to me now. > > Will merge it. Thank you , Jark

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283644316 ## File path:

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283646615 ## File path:

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283644686 ## File path:

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283644935 ## File path:

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283645956 ## File path:

[GitHub] [flink] twalthr commented on a change in pull request #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs

2019-05-14 Thread GitBox
twalthr commented on a change in pull request #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs URL: https://github.com/apache/flink/pull/8404#discussion_r283650634 ## File path:

[jira] [Commented] (FLINK-12384) Rolling the etcd servers causes "Connected to an old server; r-o mode will be unavailable"

2019-05-14 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839189#comment-16839189 ] Gary Yao commented on FLINK-12384: -- [~haf] ping > Rolling the etcd servers causes "Connected to an old

[GitHub] [flink] gyfora commented on issue #8410: [FLINK-11159] Allow configuration whether to fall back to savepoints for restore

2019-05-14 Thread GitBox
gyfora commented on issue #8410: [FLINK-11159] Allow configuration whether to fall back to savepoints for restore URL: https://github.com/apache/flink/pull/8410#issuecomment-492128968 What do you mean it doesnt use it? you can see it here:

[jira] [Commented] (FLINK-12474) UnionInputGate should be notified when closing SingleInputGate by canceler thread

2019-05-14 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839198#comment-16839198 ] Piotr Nowojski commented on FLINK-12474: > But if the `UnionInputGate` is waiting for buffer,

[GitHub] [flink] yanghua edited a comment on issue #8410: [FLINK-11159] Allow configuration whether to fall back to savepoints for restore

2019-05-14 Thread GitBox
yanghua edited a comment on issue #8410: [FLINK-11159] Allow configuration whether to fall back to savepoints for restore URL: https://github.com/apache/flink/pull/8410#issuecomment-492130463 Oh @gyfora Sorry, yes, I have found it after I gave that comment. The reason is that I did not

[GitHub] [flink] yanghua commented on issue #8410: [FLINK-11159] Allow configuration whether to fall back to savepoints for restore

2019-05-14 Thread GitBox
yanghua commented on issue #8410: [FLINK-11159] Allow configuration whether to fall back to savepoints for restore URL: https://github.com/apache/flink/pull/8410#issuecomment-492130463 Oh @gyfora Sorry, yes, I have found it after I gave that comment. The reason is that I did not rebase

[GitHub] [flink] StefanRRichter commented on issue #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop

2019-05-14 Thread GitBox
StefanRRichter commented on issue #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#issuecomment-492139497 @Aitozi thanks for taking a look. As I said in the description, this PR is based on #8409, which is the PR that only

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283689154 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283688763 ## File path:

[GitHub] [flink] yanghua commented on issue #7470: [FLINK-11283] Accessing the key when processing connected keyed stream

2019-05-14 Thread GitBox
yanghua commented on issue #7470: [FLINK-11283] Accessing the key when processing connected keyed stream URL: https://github.com/apache/flink/pull/7470#issuecomment-492149944 @aljoscha This PR holds a long time. Can you review it? thanks.

[GitHub] [flink] dawidwys commented on issue #8418: [FLINK-12491][docs][configuration] Fix incorrect javadoc for path sep…

2019-05-14 Thread GitBox
dawidwys commented on issue #8418: [FLINK-12491][docs][configuration] Fix incorrect javadoc for path sep… URL: https://github.com/apache/flink/pull/8418#issuecomment-492097883 What do you think @aljoscha? Which separators should we support?

[GitHub] [flink] JingsongLi edited a comment on issue #8397: [FLINK-11421][Table SQL/Runtime]Add compilation options to allow comp…

2019-05-14 Thread GitBox
JingsongLi edited a comment on issue #8397: [FLINK-11421][Table SQL/Runtime]Add compilation options to allow comp… URL: https://github.com/apache/flink/pull/8397#issuecomment-492102837 @liyafan82 Thank you for your PR. I think you should add some detailed benchmarks, as we discussed in

[GitHub] [flink] JingsongLi edited a comment on issue #8397: [FLINK-11421][Table SQL/Runtime]Add compilation options to allow comp…

2019-05-14 Thread GitBox
JingsongLi edited a comment on issue #8397: [FLINK-11421][Table SQL/Runtime]Add compilation options to allow comp… URL: https://github.com/apache/flink/pull/8397#issuecomment-492102837 @liyafan82 Thank you for your PR. I think you should add some detailed benchmarks, as we discussed in

[jira] [Assigned] (FLINK-12260) Slot allocation failure by taskmanager registration timeout and race

2019-05-14 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-12260: - Assignee: Hwanju Kim > Slot allocation failure by taskmanager registration timeout and

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283661779 ## File path:

  1   2   3   4   >