[GitHub] [flink] KurtYoung merged pull request #8440: [FLINK-12509] [table-planner-blink] Introduce planner rules about non semi/anti join

2019-05-21 Thread GitBox
KurtYoung merged pull request #8440: [FLINK-12509] [table-planner-blink] Introduce planner rules about non semi/anti join URL: https://github.com/apache/flink/pull/8440 This is an automated message from the Apache Git

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
sunjincheng121 commented on a change in pull request #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#discussion_r286285192 ## File path:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
sunjincheng121 commented on a change in pull request #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#discussion_r286275045 ## File path: flink-python/pyflink/table/table_descriptor.py

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
sunjincheng121 commented on a change in pull request #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#discussion_r286285542 ## File path:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
sunjincheng121 commented on a change in pull request #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#discussion_r286278062 ## File path: flink-python/pyflink/table/table_descriptor.py

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
sunjincheng121 commented on a change in pull request #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#discussion_r286278465 ## File path: flink-python/pyflink/table/table_descriptor.py

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
sunjincheng121 commented on a change in pull request #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#discussion_r286275713 ## File path: flink-python/pyflink/table/table_descriptor.py

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
sunjincheng121 commented on a change in pull request #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#discussion_r286277293 ## File path: flink-python/pyflink/table/table_descriptor.py

[GitHub] [flink] zhijiangW commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-21 Thread GitBox
zhijiangW commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r286297035 ## File path:

[jira] [Comment Edited] (FLINK-8871) Checkpoint cancellation is not propagated to stop checkpointing threads on the task manager

2019-05-21 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845520#comment-16845520 ] vinoyang edited comment on FLINK-8871 at 5/22/19 4:58 AM: -- [~carp84] Ok, I will

[GitHub] [flink] sunjincheng121 edited a comment on issue #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
sunjincheng121 edited a comment on issue #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#issuecomment-494621847 One more comment: Please improve the description of PR, It's better to tell the

[GitHub] [flink] sunjincheng121 edited a comment on issue #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
sunjincheng121 edited a comment on issue #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#issuecomment-494621847 One more comment: Please improve the description of PR, It's better to tell the

[GitHub] [flink] sunjincheng121 commented on issue #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
sunjincheng121 commented on issue #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#issuecomment-494621847 One more comment: Please improve the description of PR, It's better to tell the

[GitHub] [flink] sunjincheng121 commented on issue #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend

2019-05-21 Thread GitBox
sunjincheng121 commented on issue #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend URL: https://github.com/apache/flink/pull/8472#issuecomment-494623534 @flinkbot attention @StephanEwen

[GitHub] [flink] sunjincheng121 edited a comment on issue #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
sunjincheng121 edited a comment on issue #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#issuecomment-494621847 One more comment: Please improve the description of PR, It's better to tell the

[GitHub] [flink] JingsongLi commented on issue #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-21 Thread GitBox
JingsongLi commented on issue #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#issuecomment-494625782 > I try to start reviewing from runtime package, and noticed that the old internal types haven't yet

[GitHub] [flink] shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator

2019-05-21 Thread GitBox
shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator URL: https://github.com/apache/flink/pull/8486#discussion_r286290311 ## File path:

[GitHub] [flink] HuangXingBo commented on issue #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend

2019-05-21 Thread GitBox
HuangXingBo commented on issue #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend URL: https://github.com/apache/flink/pull/8472#issuecomment-494629938 > @HuangXingBo Thanks for the PR! > I am glad to see you had listed the detail change in ``

[jira] [Closed] (FLINK-12558) Yarn application can't stop when flink job finished in normal mode

2019-05-21 Thread lamber-ken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lamber-ken closed FLINK-12558. -- Resolution: Not A Problem Fix Version/s: 1.6.3 Release Note: it needs to add -ace option

[GitHub] [flink] JingsongLi commented on a change in pull request #8278: [FLINK-12335][Table-runtime]Remove useless code in class SegmentsUtil

2019-05-21 Thread GitBox
JingsongLi commented on a change in pull request #8278: [FLINK-12335][Table-runtime]Remove useless code in class SegmentsUtil URL: https://github.com/apache/flink/pull/8278#discussion_r286296038 ## File path:

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
WeiZhong94 commented on a change in pull request #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#discussion_r286307285 ## File path: flink-python/pyflink/table/table_descriptor.py

[GitHub] [flink] KurtYoung merged pull request #8460: [FLINK-12524] [table-planner-blink] Introduce planner rules about rank

2019-05-21 Thread GitBox
KurtYoung merged pull request #8460: [FLINK-12524] [table-planner-blink] Introduce planner rules about rank URL: https://github.com/apache/flink/pull/8460 This is an automated message from the Apache Git Service. To respond

[jira] [Updated] (FLINK-12584) Add Bucket File Syetem Table Sink

2019-05-21 Thread zhangjun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangjun updated FLINK-12584: - Description: 1. *Motivation* In flink, the file system (especially hdfs) is a very common output, but

[GitHub] [flink] asfgit closed pull request #8503: [FLINK-12241][hive] Support Flink functions in catalog function APIs of HiveCatalog

2019-05-21 Thread GitBox
asfgit closed pull request #8503: [FLINK-12241][hive] Support Flink functions in catalog function APIs of HiveCatalog URL: https://github.com/apache/flink/pull/8503 This is an automated message from the Apache Git Service.

[GitHub] [flink] JingsongLi commented on a change in pull request #8278: [FLINK-12335][Table-runtime]Remove useless code in class SegmentsUtil

2019-05-21 Thread GitBox
JingsongLi commented on a change in pull request #8278: [FLINK-12335][Table-runtime]Remove useless code in class SegmentsUtil URL: https://github.com/apache/flink/pull/8278#discussion_r286296038 ## File path:

[GitHub] [flink] lirui-apache commented on a change in pull request #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog

2019-05-21 Thread GitBox
lirui-apache commented on a change in pull request #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8449#discussion_r286297702 ## File path:

[GitHub] [flink] lirui-apache commented on a change in pull request #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog

2019-05-21 Thread GitBox
lirui-apache commented on a change in pull request #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8449#discussion_r286297791 ## File path:

[GitHub] [flink] lirui-apache commented on a change in pull request #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog

2019-05-21 Thread GitBox
lirui-apache commented on a change in pull request #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8449#discussion_r286298510 ## File path:

[jira] [Created] (FLINK-12585) Align Stream/BatchTableEnvironment with JAVA Table API

2019-05-21 Thread sunjincheng (JIRA)
sunjincheng created FLINK-12585: --- Summary: Align Stream/BatchTableEnvironment with JAVA Table API Key: FLINK-12585 URL: https://issues.apache.org/jira/browse/FLINK-12585 Project: Flink Issue

[jira] [Commented] (FLINK-12585) Align Stream/BatchTableEnvironment with JAVA Table API

2019-05-21 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845494#comment-16845494 ] Dian Fu commented on FLINK-12585: - Agree. Having a Python

[jira] [Assigned] (FLINK-12585) Align Stream/BatchTableEnvironment with JAVA Table API

2019-05-21 Thread Wei Zhong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zhong reassigned FLINK-12585: - Assignee: Wei Zhong > Align Stream/BatchTableEnvironment with JAVA Table API >

[jira] [Commented] (FLINK-8871) Checkpoint cancellation is not propagated to stop checkpointing threads on the task manager

2019-05-21 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845507#comment-16845507 ] Yu Li commented on FLINK-8871: -- bq. Yun Tang Your solution sounds good, but it would wait for other things

[jira] [Created] (FLINK-12584) Add Bucket File Syetem Table Sink

2019-05-21 Thread zhangjun (JIRA)
zhangjun created FLINK-12584: Summary: Add Bucket File Syetem Table Sink Key: FLINK-12584 URL: https://issues.apache.org/jira/browse/FLINK-12584 Project: Flink Issue Type: New Feature

[jira] [Closed] (FLINK-12241) Support Flink functions in catalog function APIs of HiveCatalog

2019-05-21 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12241. Resolution: Fixed merged in 1.9.0: 3813bb90ba4fb8bc8637b7c1c5de2e24196c4b3b > Support Flink functions in

[GitHub] [flink] klion26 commented on a change in pull request #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file

2019-05-21 Thread GitBox
klion26 commented on a change in pull request #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file URL: https://github.com/apache/flink/pull/8479#discussion_r286307041 ## File path:

[jira] [Commented] (FLINK-8871) Checkpoint cancellation is not propagated to stop checkpointing threads on the task manager

2019-05-21 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845496#comment-16845496 ] Yun Tang commented on FLINK-8871: - [~yanghua] Yu is my mentor and just want to help me for this assignee

[jira] [Created] (FLINK-12586) Stderr and stdout are reversed in OptimizerPlanEnvironment

2019-05-21 Thread Kazunori Shinhira (JIRA)
Kazunori Shinhira created FLINK-12586: - Summary: Stderr and stdout are reversed in OptimizerPlanEnvironment Key: FLINK-12586 URL: https://issues.apache.org/jira/browse/FLINK-12586 Project: Flink

[GitHub] [flink] flinkbot edited a comment on issue #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend

2019-05-21 Thread GitBox
flinkbot edited a comment on issue #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend URL: https://github.com/apache/flink/pull/8472#issuecomment-493313848 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] sunjincheng121 commented on issue #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend

2019-05-21 Thread GitBox
sunjincheng121 commented on issue #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend URL: https://github.com/apache/flink/pull/8472#issuecomment-494627775 @HuangXingBo Thanks for the PR! I am glad to see you had listed the detail change in `` section

[GitHub] [flink] lirui-apache commented on a change in pull request #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog

2019-05-21 Thread GitBox
lirui-apache commented on a change in pull request #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8449#discussion_r286292141 ## File path:

[GitHub] [flink] sunjincheng121 edited a comment on issue #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend

2019-05-21 Thread GitBox
sunjincheng121 edited a comment on issue #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend URL: https://github.com/apache/flink/pull/8472#issuecomment-494627775 @HuangXingBo Thanks for the PR! I am glad to see you had listed the detail change in

[GitHub] [flink] JingsongLi commented on issue #8278: [FLINK-12335][Table-runtime]Remove useless code in class SegmentsUtil

2019-05-21 Thread GitBox
JingsongLi commented on issue #8278: [FLINK-12335][Table-runtime]Remove useless code in class SegmentsUtil URL: https://github.com/apache/flink/pull/8278#issuecomment-494638754 Thanks @liyafan82 , LGTM +1 This is an

[GitHub] [flink] bowenli86 opened a new pull request #8507: [FLINK-12236][hive] Support Hive function in HiveCatalog

2019-05-21 Thread GitBox
bowenli86 opened a new pull request #8507: [FLINK-12236][hive] Support Hive function in HiveCatalog URL: https://github.com/apache/flink/pull/8507 ## What is the purpose of the change This PR creates `HiveCatalogFunction` class and adds support for Hive function operations in

[GitHub] [flink] flinkbot commented on issue #8507: [FLINK-12236][hive] Support Hive function in HiveCatalog

2019-05-21 Thread GitBox
flinkbot commented on issue #8507: [FLINK-12236][hive] Support Hive function in HiveCatalog URL: https://github.com/apache/flink/pull/8507#issuecomment-494643454 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[jira] [Updated] (FLINK-12236) Support Hive function in HiveCatalog

2019-05-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12236: --- Labels: pull-request-available (was: ) > Support Hive function in HiveCatalog >

[GitHub] [flink] bowenli86 commented on a change in pull request #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog

2019-05-21 Thread GitBox
bowenli86 commented on a change in pull request #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8449#discussion_r286304895 ## File path:

[jira] [Commented] (FLINK-8871) Checkpoint cancellation is not propagated to stop checkpointing threads on the task manager

2019-05-21 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845510#comment-16845510 ] vinoyang commented on FLINK-8871: - [~yunta] OK, I am very happy to hear your own thoughts. Yes, I should

[jira] [Commented] (FLINK-12558) Yarn application can't stop when flink job finished in normal mode

2019-05-21 Thread lamber-ken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845457#comment-16845457 ] lamber-ken commented on FLINK-12558: hi, thanks for assign this issue [~frank wang], maybe the CLI

[jira] [Assigned] (FLINK-12573) ability to add suffix to part file created in Bucket (StreamingFileSink)

2019-05-21 Thread Louis Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Louis Xu reassigned FLINK-12573: Assignee: Louis Xu > ability to add suffix to part file created in Bucket (StreamingFileSink) >

[GitHub] [flink] zhijiangW commented on issue #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-21 Thread GitBox
zhijiangW commented on issue #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#issuecomment-494661586 Thanks for the updates @azagrebin! I left several minor comments, only one concern of new proposed

[GitHub] [flink] liyafan82 commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink

2019-05-21 Thread GitBox
liyafan82 commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink URL: https://github.com/apache/flink/pull/8492#discussion_r285988252 ## File path:

[GitHub] [flink] liyafan82 commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink

2019-05-21 Thread GitBox
liyafan82 commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink URL: https://github.com/apache/flink/pull/8492#discussion_r285992779 ## File path:

[GitHub] [flink] liyafan82 edited a comment on issue #8278: [FLINK-12335][Table-runtime]Remove useless code in class SegmentsUtil

2019-05-21 Thread GitBox
liyafan82 edited a comment on issue #8278: [FLINK-12335][Table-runtime]Remove useless code in class SegmentsUtil URL: https://github.com/apache/flink/pull/8278#issuecomment-494286726 > Thanks @liyafan82 for you code, maybe you can change the title to `remove useless code in SegmentsUtil`,

[jira] [Commented] (FLINK-12573) ability to add suffix to part file created in Bucket (StreamingFileSink)

2019-05-21 Thread Louis Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845482#comment-16845482 ] Louis Xu commented on FLINK-12573: -- Hello,[~yitz589],I am interested in this issue. And like to

[jira] [Assigned] (FLINK-8585) Efficiently handle read-only and non array ByteBuffers in DataInputDeserializer

2019-05-21 Thread Louis Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Louis Xu reassigned FLINK-8585: --- Assignee: (was: Louis Xu) > Efficiently handle read-only and non array ByteBuffers in >

[jira] [Commented] (FLINK-8871) Checkpoint cancellation is not propagated to stop checkpointing threads on the task manager

2019-05-21 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845520#comment-16845520 ] vinoyang commented on FLINK-8871: - [~carp84] Ok, I will reply directly to your question for the following

[GitHub] [flink] Aitozi commented on a change in pull request #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file

2019-05-21 Thread GitBox
Aitozi commented on a change in pull request #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file URL: https://github.com/apache/flink/pull/8479#discussion_r286315022 ## File path:

[jira] [Created] (FLINK-12583) Add all format support align with the Java Table API

2019-05-21 Thread sunjincheng (JIRA)
sunjincheng created FLINK-12583: --- Summary: Add all format support align with the Java Table API Key: FLINK-12583 URL: https://issues.apache.org/jira/browse/FLINK-12583 Project: Flink Issue

[jira] [Closed] (FLINK-12509) Introduce planner rules about non semi/anti join

2019-05-21 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-12509. -- Resolution: Implemented Fix Version/s: 1.9.0 merge in 1.9.0:

[GitHub] [flink] zhijiangW commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-21 Thread GitBox
zhijiangW commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r286299195 ## File path:

[GitHub] [flink] lirui-apache commented on a change in pull request #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog

2019-05-21 Thread GitBox
lirui-apache commented on a change in pull request #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8449#discussion_r286299254 ## File path:

[jira] [Updated] (FLINK-12397) Drop flink-shaded-asm-5

2019-05-21 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-12397: Fix Version/s: (was: shaded-8.0) shaded-7.0 > Drop flink-shaded-asm-5 >

[jira] [Updated] (FLINK-12235) Support Hive partition in HiveCatalog

2019-05-21 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Li updated FLINK-12235: --- Summary: Support Hive partition in HiveCatalog (was: Support partition related operations in HiveCatalog)

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
WeiZhong94 commented on a change in pull request #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#discussion_r285864500 ## File path: flink-python/pyflink/table/table_descriptor.py

[jira] [Created] (FLINK-12567) Rework DescriptorProperties to adapt unified DDL with clause and Descriptor key value pairs

2019-05-21 Thread Danny Chan (JIRA)
Danny Chan created FLINK-12567: -- Summary: Rework DescriptorProperties to adapt unified DDL with clause and Descriptor key value pairs Key: FLINK-12567 URL: https://issues.apache.org/jira/browse/FLINK-12567

[jira] [Updated] (FLINK-12567) Rework DescriptorProperties to adapt unified DDL with clause and Descriptor key value pairs

2019-05-21 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated FLINK-12567: --- Issue Type: Improvement (was: Bug) > Rework DescriptorProperties to adapt unified DDL with clause

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
WeiZhong94 commented on a change in pull request #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#discussion_r285874267 ## File path: flink-python/pyflink/table/table_descriptor.py

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
WeiZhong94 commented on a change in pull request #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#discussion_r285874314 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8278: [FLINK-12335][Table-runtime]Improvement the performance of class SegmentsUtil

2019-05-21 Thread GitBox
JingsongLi commented on a change in pull request #8278: [FLINK-12335][Table-runtime]Improvement the performance of class SegmentsUtil URL: https://github.com/apache/flink/pull/8278#discussion_r285873246 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8278: [FLINK-12335][Table-runtime]Improvement the performance of class SegmentsUtil

2019-05-21 Thread GitBox
JingsongLi commented on a change in pull request #8278: [FLINK-12335][Table-runtime]Improvement the performance of class SegmentsUtil URL: https://github.com/apache/flink/pull/8278#discussion_r285873033 ## File path:

[GitHub] [flink] WeiZhong94 commented on issue #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
WeiZhong94 commented on issue #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#issuecomment-494264591 @dianfu Thanks for you review! I have addressed you comments.

[GitHub] [flink] yanghua commented on a change in pull request #8459: [FLINK-12476] [State TTL] Consider setting a default background cleanup strategy in StateTtlConfig

2019-05-21 Thread GitBox
yanghua commented on a change in pull request #8459: [FLINK-12476] [State TTL] Consider setting a default background cleanup strategy in StateTtlConfig URL: https://github.com/apache/flink/pull/8459#discussion_r285879213 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
dianfu commented on a change in pull request #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#discussion_r285867088 ## File path: flink-python/pyflink/table/table_descriptor.py

[jira] [Created] (FLINK-12565) PythonStreamBinderTest#testProgram test failer

2019-05-21 Thread vinoyang (JIRA)
vinoyang created FLINK-12565: Summary: PythonStreamBinderTest#testProgram test failer Key: FLINK-12565 URL: https://issues.apache.org/jira/browse/FLINK-12565 Project: Flink Issue Type: Bug

[GitHub] [flink] dianfu commented on issue #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend

2019-05-21 Thread GitBox
dianfu commented on issue #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend URL: https://github.com/apache/flink/pull/8472#issuecomment-494256685 @HuangXingBo Thanks a lot for the update. LGTM. +1 from my side.

[GitHub] [flink] KurtYoung commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink

2019-05-21 Thread GitBox
KurtYoung commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink URL: https://github.com/apache/flink/pull/8492#discussion_r285875126 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink

2019-05-21 Thread GitBox
KurtYoung commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink URL: https://github.com/apache/flink/pull/8492#discussion_r28587 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink

2019-05-21 Thread GitBox
KurtYoung commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink URL: https://github.com/apache/flink/pull/8492#discussion_r285878887 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink

2019-05-21 Thread GitBox
KurtYoung commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink URL: https://github.com/apache/flink/pull/8492#discussion_r285870929 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink

2019-05-21 Thread GitBox
KurtYoung commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink URL: https://github.com/apache/flink/pull/8492#discussion_r285871459 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
dianfu commented on a change in pull request #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#discussion_r285859502 ## File path: flink-python/pyflink/table/table_descriptor.py

[GitHub] [flink] dianfu commented on a change in pull request #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
dianfu commented on a change in pull request #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#discussion_r285863199 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API

2019-05-21 Thread GitBox
dianfu commented on a change in pull request #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#discussion_r285858981 ## File path: flink-python/pyflink/table/table_descriptor.py

[jira] [Updated] (FLINK-12557) Unify create table DDL with clause and connector descriptor keys

2019-05-21 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated FLINK-12557: --- Description: The *with* option in table DDL defines the properties needed for specific connector

[GitHub] [flink] hequn8128 commented on issue #8493: [FLINK-12562][table] Improve code in ExpandColumnFunctionsRule

2019-05-21 Thread GitBox
hequn8128 commented on issue #8493: [FLINK-12562][table] Improve code in ExpandColumnFunctionsRule URL: https://github.com/apache/flink/pull/8493#issuecomment-494275523 @flinkbot attention @twalthr @sunjincheng121 This is

[GitHub] [flink] flinkbot edited a comment on issue #8493: [FLINK-12562][table] Improve code in ExpandColumnFunctionsRule

2019-05-21 Thread GitBox
flinkbot edited a comment on issue #8493: [FLINK-12562][table] Improve code in ExpandColumnFunctionsRule URL: https://github.com/apache/flink/pull/8493#issuecomment-494265918 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[jira] [Commented] (FLINK-12413) Implement ExecutionFailureHandler

2019-05-21 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844594#comment-16844594 ] Gary Yao commented on FLINK-12413: -- Adding {{notifyFailure()}} makes sense to me > Implement

[GitHub] [flink] c4emmmm commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-21 Thread GitBox
c4e commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#discussion_r285885881 ## File path:

[GitHub] [flink] HuangXingBo commented on a change in pull request #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend

2019-05-21 Thread GitBox
HuangXingBo commented on a change in pull request #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend URL: https://github.com/apache/flink/pull/8472#discussion_r285862853 ## File path:

[jira] [Commented] (FLINK-12557) Unify create table DDL with clause and connector descriptor keys

2019-05-21 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844560#comment-16844560 ] Danny Chan commented on FLINK-12557: Thanks [~twalthr], the structure you proposed seems more

[jira] [Created] (FLINK-12566) Remove row interval type

2019-05-21 Thread Timo Walther (JIRA)
Timo Walther created FLINK-12566: Summary: Remove row interval type Key: FLINK-12566 URL: https://issues.apache.org/jira/browse/FLINK-12566 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-12568) Implement TableSink and OutputFormat to write Hive tables

2019-05-21 Thread Rui Li (JIRA)
Rui Li created FLINK-12568: -- Summary: Implement TableSink and OutputFormat to write Hive tables Key: FLINK-12568 URL: https://issues.apache.org/jira/browse/FLINK-12568 Project: Flink Issue Type:

[GitHub] [flink] hequn8128 opened a new pull request #8493: [FLINK-12562][table] Improve code in ExpandColumnFunctionsRule

2019-05-21 Thread GitBox
hequn8128 opened a new pull request #8493: [FLINK-12562][table] Improve code in ExpandColumnFunctionsRule URL: https://github.com/apache/flink/pull/8493 ## What is the purpose of the change This pull requests resolve IntelliJ warnings in `ExpandColumnFunctionsRule`. Also,

[GitHub] [flink] KurtYoung commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink

2019-05-21 Thread GitBox
KurtYoung commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink URL: https://github.com/apache/flink/pull/8492#discussion_r285874482 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink

2019-05-21 Thread GitBox
KurtYoung commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink URL: https://github.com/apache/flink/pull/8492#discussion_r285879612 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink

2019-05-21 Thread GitBox
KurtYoung commented on a change in pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink URL: https://github.com/apache/flink/pull/8492#discussion_r285875265 ## File path:

[jira] [Commented] (FLINK-12557) Unify create table DDL with clause and connector descriptor keys

2019-05-21 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844562#comment-16844562 ] Danny Chan commented on FLINK-12557: We are indeed planning to rework the DescriptorProperties class

[GitHub] [flink] flinkbot commented on issue #8493: [FLINK-12562][table] Improve code in ExpandColumnFunctionsRule

2019-05-21 Thread GitBox
flinkbot commented on issue #8493: [FLINK-12562][table] Improve code in ExpandColumnFunctionsRule URL: https://github.com/apache/flink/pull/8493#issuecomment-494265918 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[jira] [Updated] (FLINK-12562) Improve code in ExpandColumnFunctionsRule

2019-05-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12562: --- Labels: pull-request-available (was: ) > Improve code in ExpandColumnFunctionsRule >

[jira] [Closed] (FLINK-12524) Introduce planner rules about rank

2019-05-21 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-12524. -- Resolution: Implemented Fix Version/s: 1.9.0 merge in 1.9.0:

  1   2   3   4   >