liyafan82 opened a new pull request #8821: [FLINK-12922][Table SQL / Planner]
Remove method parameter from OperatorCodeGenerator
URL: https://github.com/apache/flink/pull/8821
## What is the purpose of the change
The TableConfig parameter of
[
https://issues.apache.org/jira/browse/FLINK-12922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-12922:
---
Labels: pull-request-available (was: )
> Remove method parameter from
[
https://issues.apache.org/jira/browse/FLINK-9900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869224#comment-16869224
]
Yun Tang commented on FLINK-9900:
-
Another instance which exceed 300 seconds
Myasuka commented on issue #8820: [FLINK-12916][tests] Retry
cancelWithSavepoint on cancellation barrier in AbstractOperatorRestoreTestBase
URL: https://github.com/apache/flink/pull/8820#issuecomment-504306726
@flinkbot attention @tillrohrmann , due to you first introduce the retry
logic
dianfu commented on issue #8817: [FLINK-12920][python] Drop support of
register_table_sink with parameters field_names and field_types
URL: https://github.com/apache/flink/pull/8817#issuecomment-504306720
@WeiZhong94 Thanks a lot for the review. Updated accordingly.
Liya Fan created FLINK-12922:
Summary: Remove method parameter from OperatorCodeGenerator
Key: FLINK-12922
URL: https://issues.apache.org/jira/browse/FLINK-12922
Project: Flink
Issue Type:
sunjincheng121 commented on issue #8681: [FLINK-12585][python] Align
Stream/BatchTableEnvironment with JAVA Table API
URL: https://github.com/apache/flink/pull/8681#issuecomment-504303956
Thanks for the update@WeiZhong94!
LGTM. +1 to merged.
flinkbot commented on issue #8821: [FLINK-12922][Table SQL / Planner] Remove
method parameter from OperatorCodeGenerator
URL: https://github.com/apache/flink/pull/8821#issuecomment-504308095
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the
WeiZhong94 commented on a change in pull request #8817: [FLINK-12920][python]
Drop support of register_table_sink with parameters field_names and field_types
URL: https://github.com/apache/flink/pull/8817#discussion_r296108555
##
File path: flink-python/pyflink/table/sinks.py
WeiZhong94 commented on a change in pull request #8817: [FLINK-12920][python]
Drop support of register_table_sink with parameters field_names and field_types
URL: https://github.com/apache/flink/pull/8817#discussion_r296108714
##
File path: flink-python/pyflink/table/sinks.py
zhijiangW commented on a change in pull request #8789: [FLINK-12890] Add
partition lifecycle related Shuffle API
URL: https://github.com/apache/flink/pull/8789#discussion_r296115872
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMaster.java
zhijiangW commented on a change in pull request #8789: [FLINK-12890] Add
partition lifecycle related Shuffle API
URL: https://github.com/apache/flink/pull/8789#discussion_r296115872
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMaster.java
sunjincheng121 commented on issue #8681: [FLINK-12585][python] Align
Stream/BatchTableEnvironment with JAVA Table API
URL: https://github.com/apache/flink/pull/8681#issuecomment-504319579
I will fix the test shell issue, but thanks for the update! @WeiZhong94
Chesnay Schepler created FLINK-12923:
Summary: Introduce a Task termination future
Key: FLINK-12923
URL: https://issues.apache.org/jira/browse/FLINK-12923
Project: Flink
Issue Type:
[
https://issues.apache.org/jira/browse/FLINK-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-12899:
---
Labels: pull-request-available (was: )
> Introduce a resolved expression with data type
>
twalthr opened a new pull request #8822: [FLINK-12899][table] Introduce a
resolved expression with data type
URL: https://github.com/apache/flink/pull/8822
## What is the purpose of the change
This separates calls to functions into resolved and unresolved call
expressions.
flinkbot commented on issue #8822: [FLINK-12899][table] Introduce a resolved
expression with data type
URL: https://github.com/apache/flink/pull/8822#issuecomment-504331845
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review
JingsongLi commented on issue #8730: [FLINK-12834][table-planner-blink] Support
CharType and BinaryType
URL: https://github.com/apache/flink/pull/8730#issuecomment-504343105
This PR not resolve https://issues.apache.org/jira/browse/FLINK-10257 ,
Incorrect CHAR type support still remain...
GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime]
Add elaborated partition release logic
URL: https://github.com/apache/flink/pull/8804#discussion_r296176302
##
File path:
StephanEwen commented on issue #8803: [FLINK-12903][py] Remove old Python APIs
URL: https://github.com/apache/flink/pull/8803#issuecomment-504370514
The python test module seems broken, otherwise +1
This is an automated
StephanEwen edited a comment on issue #8803: [FLINK-12903][py] Remove old
Python APIs
URL: https://github.com/apache/flink/pull/8803#issuecomment-504370514
The python test travis profile seems broken, otherwise +1
This is an
StephanEwen commented on issue #8803: [FLINK-12903][py] Remove old Python APIs
URL: https://github.com/apache/flink/pull/8803#issuecomment-504370407
@flinkbot approve-until architecture
This is an automated message from the
zentol commented on issue #8803: [FLINK-12903][py] Remove old Python APIs
URL: https://github.com/apache/flink/pull/8803#issuecomment-504377909
I believe this is due to https://issues.apache.org/jira/browse/FLINK-12910
which is fixed on master. I'll rebase the PR and rerun travis.
[
https://issues.apache.org/jira/browse/FLINK-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869378#comment-16869378
]
Alex commented on FLINK-12752:
--
If a user have to specify --{{jobId-seed}} manually, wouldn't it be
yanghua commented on issue #8823: [FLINK-12514] Refactor the failure checkpoint
counting mechanism with ordered checkpoint id
URL: https://github.com/apache/flink/pull/8823#issuecomment-504377494
This PR is not ready to be reviewed.
sunjincheng121 commented on issue #8771: [FLINK-12778][table] Fix derive row
type bug for table aggregate
URL: https://github.com/apache/flink/pull/8771#issuecomment-504354127
I rebase the code just for the CI test. :) @hequn8128
dawidwys commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296186706
##
File path:
Aitozi commented on issue #8455: [FLINK-12284,FLINK-12637][Network,Metrics]Fix
the incorrect inputBufferUsage metric in credit-based network mode
URL: https://github.com/apache/flink/pull/8455#issuecomment-504385014
ping @zhijiangW @pnowojski , could you take a look again, thanks :)
twalthr commented on a change in pull request #8822: [FLINK-12899][table]
Introduce a resolved expression with data type
URL: https://github.com/apache/flink/pull/8822#discussion_r296197028
##
File path:
tillrohrmann merged pull request #8783: [FLINK-12863][FLINK-12865] Remove
concurrency from HeartbeatManager(Sender)Impl
URL: https://github.com/apache/flink/pull/8783
This is an automated message from the Apache Git
sunjincheng121 commented on issue #8805: [FLINK-12902][hadoop] Remove
flink-shaded-yarn-tests
URL: https://github.com/apache/flink/pull/8805#issuecomment-504357292
The test fails caused by the PR #8786, And It fixed by #8807, So I think
rebase the code can get the success CI test. :)
[
https://issues.apache.org/jira/browse/FLINK-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869347#comment-16869347
]
Alex commented on FLINK-12925:
--
There is a fix embedded in [~knaufk]'s PR:
zentol commented on a change in pull request #8687: [FLINK-12612][coordination]
Track stored partition on the TaskExecutor
URL: https://github.com/apache/flink/pull/8687#discussion_r296135387
##
File path:
Alex created FLINK-12925:
Summary: Docker embedded job end-to-end test fails
Key: FLINK-12925
URL: https://issues.apache.org/jira/browse/FLINK-12925
Project: Flink
Issue Type: Bug
sunjincheng121 commented on issue #8771: [FLINK-12778][table] Fix derive row
type bug for table aggregate
URL: https://github.com/apache/flink/pull/8771#issuecomment-504342679
LGTM +1 to merged after CI change to green.
@flinkbot approve all
[
https://issues.apache.org/jira/browse/FLINK-12778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sunjincheng closed FLINK-12778.
---
Resolution: Fixed
Fix Version/s: 1.9.0
Fixed in master:
asfgit closed pull request #8771: [FLINK-12778][table] Fix derive row type bug
for table aggregate
URL: https://github.com/apache/flink/pull/8771
This is an automated message from the Apache Git Service.
To respond to the
Timo Walther created FLINK-12924:
Summary: Introduce basic type inference interfaces
Key: FLINK-12924
URL: https://issues.apache.org/jira/browse/FLINK-12924
Project: Flink
Issue Type:
[
https://issues.apache.org/jira/browse/FLINK-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann resolved FLINK-12895.
---
Resolution: Fixed
Fix Version/s: 1.9.0
1.8.1
[
https://issues.apache.org/jira/browse/FLINK-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann reassigned FLINK-12895:
-
Assignee: Till Rohrmann
>
becketqin commented on a change in pull request #8535: [FLINK-11693] Add
KafkaSerializationSchema that uses ProducerRecord
URL: https://github.com/apache/flink/pull/8535#discussion_r296131499
##
File path:
becketqin commented on a change in pull request #8535: [FLINK-11693] Add
KafkaSerializationSchema that uses ProducerRecord
URL: https://github.com/apache/flink/pull/8535#discussion_r296125913
##
File path:
becketqin commented on a change in pull request #8535: [FLINK-11693] Add
KafkaSerializationSchema that uses ProducerRecord
URL: https://github.com/apache/flink/pull/8535#discussion_r296119028
##
File path:
becketqin commented on a change in pull request #8535: [FLINK-11693] Add
KafkaSerializationSchema that uses ProducerRecord
URL: https://github.com/apache/flink/pull/8535#discussion_r296130302
##
File path:
becketqin commented on a change in pull request #8535: [FLINK-11693] Add
KafkaSerializationSchema that uses ProducerRecord
URL: https://github.com/apache/flink/pull/8535#discussion_r296119279
##
File path:
becketqin commented on a change in pull request #8535: [FLINK-11693] Add
KafkaSerializationSchema that uses ProducerRecord
URL: https://github.com/apache/flink/pull/8535#discussion_r296118523
##
File path:
JingsongLi commented on a change in pull request #8730:
[FLINK-12834][table-planner-blink] Support CharType and BinaryType
URL: https://github.com/apache/flink/pull/8730#discussion_r296146330
##
File path:
JingsongLi commented on a change in pull request #8730:
[FLINK-12834][table-planner-blink] Support CharType and BinaryType
URL: https://github.com/apache/flink/pull/8730#discussion_r296147174
##
File path:
flinkbot commented on issue #8823: [FLINK-12514] Refactor the failure
checkpoint counting mechanism with ordered checkpoint id
URL: https://github.com/apache/flink/pull/8823#issuecomment-504352457
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help
sunjincheng121 removed a comment on issue #8805: [FLINK-12902][hadoop] Remove
flink-shaded-yarn-tests
URL: https://github.com/apache/flink/pull/8805#issuecomment-504357292
The test fails caused by the PR #8786, And It fixed by #8807, So I think
rebase the code can get the success CI
GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime]
Add elaborated partition release logic
URL: https://github.com/apache/flink/pull/8804#discussion_r296171192
##
File path:
StefanRRichter commented on issue #8692: [FLINK-12804] Introduce mailbox-based
ExecutorService
URL: https://github.com/apache/flink/pull/8692#issuecomment-504379037
Updated the PR in a couple of ways, for example enforcing that some methods
of the executor must be called from
flinkbot commented on issue #8824: [FLINK-12923][runtime] Introduce Task
termination future
URL: https://github.com/apache/flink/pull/8824#issuecomment-504387196
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull
[
https://issues.apache.org/jira/browse/FLINK-12923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-12923:
---
Labels: pull-request-available (was: )
> Introduce a Task termination future
>
[
https://issues.apache.org/jira/browse/FLINK-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869404#comment-16869404
]
Yingjie Cao commented on FLINK-12070:
-
I have appended test results of the new implementation
[
https://issues.apache.org/jira/browse/FLINK-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Nowojski reassigned FLINK-12912:
--
Assignee: (was: Piotr Nowojski)
> Incorrect handling of
[
https://issues.apache.org/jira/browse/FLINK-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869254#comment-16869254
]
Piotr Nowojski edited comment on FLINK-12912 at 6/21/19 7:11 AM:
-
I
tillrohrmann merged pull request #8795: [BP-1.7][FLINK-12863][FLINK-12865]
Remove concurrency from HeartbeatManager(Sender)Impl
URL: https://github.com/apache/flink/pull/8795
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/FLINK-12863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-12863.
-
Resolution: Fixed
Fixed via
1.9.0: a95dac57ef0e1949fd4751ca19350da96c3bf52f
1.8.1:
[
https://issues.apache.org/jira/browse/FLINK-12865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann reassigned FLINK-12865:
-
Assignee: Till Rohrmann (was: Yun Gao)
> State inconsistency between RM and TM on the
[
https://issues.apache.org/jira/browse/FLINK-12865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-12865.
-
Resolution: Fixed
Fix Version/s: 1.9.0
1.8.1
1.7.3
tillrohrmann merged pull request #8794: [BP-1.8][FLINK-12863][FLINK-12865]
Remove concurrency from HeartbeatManager(Sender)Impl
URL: https://github.com/apache/flink/pull/8794
This is an automated message from the Apache Git
becketqin commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source
connector with support for checkpointing (ATLEAST_ONCE)
URL: https://github.com/apache/flink/pull/6594#issuecomment-504332708
@Xeli It is great to hear that you've got the connector working in
production. Thanks
Xeli commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source
connector with support for checkpointing (ATLEAST_ONCE)
URL: https://github.com/apache/flink/pull/6594#issuecomment-504336050
@becketqin It is not too different, I've pushed it here:
[
https://issues.apache.org/jira/browse/FLINK-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex updated FLINK-12925:
-
Description:
The test fails at the one of the Docker image build steps:
{code}
Step 16/22 : ADD
dawidwys commented on a change in pull request #8822: [FLINK-12899][table]
Introduce a resolved expression with data type
URL: https://github.com/apache/flink/pull/8822#discussion_r296138765
##
File path:
dawidwys commented on a change in pull request #8822: [FLINK-12899][table]
Introduce a resolved expression with data type
URL: https://github.com/apache/flink/pull/8822#discussion_r296155213
##
File path:
zentol opened a new pull request #8824: [FLINK-12923][runtime] Introduce Task
termination future
URL: https://github.com/apache/flink/pull/8824
Introduces a termination future into the task, that is completed once
`run()` exits.
Don't be afraid of the diff, I simply wrapped the
GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime]
Add elaborated partition release logic
URL: https://github.com/apache/flink/pull/8804#discussion_r296117701
##
File path:
[
https://issues.apache.org/jira/browse/FLINK-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869254#comment-16869254
]
Piotr Nowojski commented on FLINK-12912:
After implementing
pnowojski commented on issue #8811: [FLINK-12777][network] Support
CheckpointBarrierHandler in StreamTwoInputSelectableProcessor
URL: https://github.com/apache/flink/pull/8811#issuecomment-504322366
@zhijiangW, @sunhaibotb and @Myasuka: you might be interested in this one.
[
https://issues.apache.org/jira/browse/FLINK-12585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sunjincheng closed FLINK-12585.
---
Resolution: Fixed
Fix Version/s: 1.9.0
Fixed in master:
asfgit closed pull request #8681: [FLINK-12585][python] Align
Stream/BatchTableEnvironment with JAVA Table API
URL: https://github.com/apache/flink/pull/8681
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/FLINK-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869298#comment-16869298
]
Haibo Sun commented on FLINK-12895:
---
(y)
>
GJL commented on issue #8804: [FLINK-12883][WIP][runtime] Add elaborated
partition release logic
URL: https://github.com/apache/flink/pull/8804#issuecomment-504348803
Rebased to master
This is an automated message from the
yanghua opened a new pull request #8823: [FLINK-12514] Refactor the failure
checkpoint counting mechanism with ordered checkpoint id
URL: https://github.com/apache/flink/pull/8823
## What is the purpose of the change
*This pull request refactored the failure checkpoint counting
[
https://issues.apache.org/jira/browse/FLINK-12514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-12514:
---
Labels: pull-request-available (was: )
> Refactor the failure checkpoint counting
wuchong commented on issue #8730: [FLINK-12834][table-planner-blink] Support
CharType and BinaryType
URL: https://github.com/apache/flink/pull/8730#issuecomment-504361870
LGTM
wait until travis pass
This is an
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296151182
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296166153
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296168928
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296151771
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296136273
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296145636
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296147825
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296143105
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296143488
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296138234
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296161777
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296137840
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296155164
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296137651
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296146017
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296142802
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296134231
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296158634
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296135783
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296152072
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296143831
##
File path:
twalthr commented on a change in pull request #8764:
[FLINK-12798][table-planner][table-api-java] Port TableEnvironment to
table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r296136960
##
File path:
1 - 100 of 224 matches
Mail list logo