[jira] [Commented] (FLINK-14436) Add getter for ContextEnvironment instance in StreamContextEnvironment

2019-10-17 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954321#comment-16954321 ] Zili Chen commented on FLINK-14436: --- Thanks for your reply [~KevinZwx]. I'll appreciat

[GitHub] [flink] flinkbot edited a comment on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6 URL: https://github.com/apache/flink/pull/9906#issuecomment-542220479 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6

2019-10-17 Thread GitBox
yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6 URL: https://github.com/apache/flink/pull/9906#issuecomment-543551865 This PR go to wrong direction, closing it.

[GitHub] [flink] yanghua closed pull request #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6

2019-10-17 Thread GitBox
yanghua closed pull request #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6 URL: https://github.com/apache/flink/pull/9906 This is an automated message from t

[GitHub] [flink] flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups. URL: https://github.com/apache/flink/pull/9910#issuecomment-542644991 ## CI report: * 8d1696b97872fdd9fd3aca725c8b58ad8227f6f2 : FAI

[jira] [Closed] (FLINK-14436) Add getter for ContextEnvironment instance in StreamContextEnvironment

2019-10-17 Thread Kevin Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Zhang closed FLINK-14436. --- Resolution: Won't Fix > Add getter for ContextEnvironment instance in StreamContextEnvironment > ---

[GitHub] [flink] flinkbot edited a comment on issue #9255: [FLINK-13034] Introduce isEmpty method for MapState

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9255: [FLINK-13034] Introduce isEmpty method for MapState URL: https://github.com/apache/flink/pull/9255#issuecomment-515868641 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[jira] [Assigned] (FLINK-13195) Add create table support for SqlClient

2019-10-17 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-13195: --- Assignee: Zheng Hu (was: Danny Chen) > Add create table support for SqlClient > --

[GitHub] [flink] Myasuka commented on issue #9255: [FLINK-13034] Introduce isEmpty method for MapState

2019-10-17 Thread GitBox
Myasuka commented on issue #9255: [FLINK-13034] Introduce isEmpty method for MapState URL: https://github.com/apache/flink/pull/9255#issuecomment-543547724 Failed due to [FLINK-14445](https://issues.apache.org/jira/browse/FLINK-14445) @flinkbot run travis --

[jira] [Commented] (FLINK-14436) Add getter for ContextEnvironment instance in StreamContextEnvironment

2019-10-17 Thread Kevin Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954317#comment-16954317 ] Kevin Zhang commented on FLINK-14436: - Thanks [~tison] for the information, I'll clo

[jira] [Commented] (FLINK-14434) Dispatcher#createJobManagerRunner should returns on creation succeed, not after startJobManagerRunner

2019-10-17 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954316#comment-16954316 ] Zili Chen commented on FLINK-14434: --- Now I would prefer 2 only because with 1 we possi

[GitHub] [flink] flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#issuecomment-535435111 ## CI report: * 1aad21713df6970025319183b3774aec674fefde : SUCCESS [Bu

[jira] [Commented] (FLINK-13195) Add create table support for SqlClient

2019-10-17 Thread Zheng Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954315#comment-16954315 ] Zheng Hu commented on FLINK-13195: -- Talked with [~danny0405] offline, he is working on

[jira] [Closed] (FLINK-14446) Design a Java end to end test framework for supporting more external system

2019-10-17 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-14446. -- Resolution: Duplicate > Design a Java end to end test framework for supporting more external system >

[jira] [Created] (FLINK-14446) Design a Java end to end test framework for supporting more external system

2019-10-17 Thread Zheng Hu (Jira)
Zheng Hu created FLINK-14446: Summary: Design a Java end to end test framework for supporting more external system Key: FLINK-14446 URL: https://issues.apache.org/jira/browse/FLINK-14446 Project: Flink

[GitHub] [flink] flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#issuecomment-535430586 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot

[GitHub] [flink] flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups. URL: https://github.com/apache/flink/pull/9910#issuecomment-542644991 ## CI report: * 8d1696b97872fdd9fd3aca725c8b58ad8227f6f2 : FAI

[GitHub] [flink] flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups. URL: https://github.com/apache/flink/pull/9910#issuecomment-542638190 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] zhuzhurk commented on a change in pull request #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
zhuzhurk commented on a change in pull request #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#discussion_r336335410 ## File path: flink-runtime/src/test/java/org/apache/flink/run

[GitHub] [flink] flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#issuecomment-535430586 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot

[GitHub] [flink] zhuzhurk commented on a change in pull request #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
zhuzhurk commented on a change in pull request #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#discussion_r336333505 ## File path: flink-runtime/src/main/java/org/apache/flink/run

[GitHub] [flink] zhuzhurk commented on a change in pull request #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
zhuzhurk commented on a change in pull request #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#discussion_r336333479 ## File path: flink-runtime/src/test/java/org/apache/flink/run

[GitHub] [flink] flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#issuecomment-535430586 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot

[GitHub] [flink] flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#issuecomment-535430586 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot

[GitHub] [flink] zhuzhurk commented on a change in pull request #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
zhuzhurk commented on a change in pull request #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#discussion_r336332841 ## File path: flink-runtime/src/test/java/org/apache/flink/run

[GitHub] [flink] flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups. URL: https://github.com/apache/flink/pull/9910#issuecomment-542644991 ## CI report: * 8d1696b97872fdd9fd3aca725c8b58ad8227f6f2 : FAI

[GitHub] [flink] flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups. URL: https://github.com/apache/flink/pull/9910#issuecomment-542644991 ## CI report: * 8d1696b97872fdd9fd3aca725c8b58ad8227f6f2 : FAI

[GitHub] [flink] flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups. URL: https://github.com/apache/flink/pull/9910#issuecomment-542638190 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test

2019-10-17 Thread GitBox
bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test URL: https://github.com/apache/flink/pull/9919#discussion_r336322272 ## File path: flink-end-to-end-tests/flink-hive-test/pom.xml ## @@ -0,0 +1,183 @@ + + +http://maven.a

[GitHub] [flink] bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test

2019-10-17 Thread GitBox
bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test URL: https://github.com/apache/flink/pull/9919#discussion_r336322138 ## File path: flink-end-to-end-tests/flink-hive-test/pom.xml ## @@ -0,0 +1,183 @@ + + +http://maven.a

[GitHub] [flink] bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test

2019-10-17 Thread GitBox
bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test URL: https://github.com/apache/flink/pull/9919#discussion_r336322467 ## File path: flink-end-to-end-tests/flink-hive-test/src/main/java/org/apache/flink/connectors/hive/tests/Hive

[GitHub] [flink] bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test

2019-10-17 Thread GitBox
bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test URL: https://github.com/apache/flink/pull/9919#discussion_r336325463 ## File path: flink-end-to-end-tests/test-scripts/docker-hive-hadoop-cluster/config/mapred-site.xml #

[GitHub] [flink] bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test

2019-10-17 Thread GitBox
bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test URL: https://github.com/apache/flink/pull/9919#discussion_r336325001 ## File path: flink-end-to-end-tests/flink-hive-test/src/main/java/org/apache/flink/connectors/hive/tests/Hive

[GitHub] [flink] bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test

2019-10-17 Thread GitBox
bowenli86 commented on a change in pull request #9919: [FLINK-13303][hive]add hive e2e connector test URL: https://github.com/apache/flink/pull/9919#discussion_r336322335 ## File path: flink-end-to-end-tests/flink-hive-test/pom.xml ## @@ -0,0 +1,183 @@ + + +http://maven.a

[GitHub] [flink] flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#issuecomment-535435111 ## CI report: * 1aad21713df6970025319183b3774aec674fefde : SUCCESS [Bu

[GitHub] [flink] flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups. URL: https://github.com/apache/flink/pull/9910#issuecomment-542638190 Thanks a lot for your contribution to the Apache Flink project. I'm the

[jira] [Comment Edited] (FLINK-14445) Python module build failed when making sdist

2019-10-17 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954253#comment-16954253 ] Dian Fu edited comment on FLINK-14445 at 10/18/19 5:08 AM: --- [~

[GitHub] [flink] flinkbot edited a comment on issue #9927: [FLINK-14397][hive] Failed to run Hive UDTF with array arguments

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9927: [FLINK-14397][hive] Failed to run Hive UDTF with array arguments URL: https://github.com/apache/flink/pull/9927#issuecomment-543172555 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to rev

[GitHub] [flink] flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build URL: https://github.com/apache/flink/pull/9783#issuecomment-535848177 ## CI report: * 5d9e3113e10bbf0220b4f8e080ecd1cddd9c9059 : FAILURE [Build](http

[GitHub] [flink] flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#issuecomment-535435111 ## CI report: * 1aad21713df6970025319183b3774aec674fefde : SUCCESS [Bu

[GitHub] [flink] flinkbot edited a comment on issue #9576: [FLINK-13915][ml] Add several base classes of summarizer.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9576: [FLINK-13915][ml] Add several base classes of summarizer. URL: https://github.com/apache/flink/pull/9576#issuecomment-526645449 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review you

[GitHub] [flink] walterddr commented on a change in pull request #9576: [FLINK-13915][ml] Add several base classes of summarizer.

2019-10-17 Thread GitBox
walterddr commented on a change in pull request #9576: [FLINK-13915][ml] Add several base classes of summarizer. URL: https://github.com/apache/flink/pull/9576#discussion_r336317258 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/statistics/basic

[GitHub] [flink] walterddr commented on a change in pull request #9576: [FLINK-13915][ml] Add several base classes of summarizer.

2019-10-17 Thread GitBox
walterddr commented on a change in pull request #9576: [FLINK-13915][ml] Add several base classes of summarizer. URL: https://github.com/apache/flink/pull/9576#discussion_r336317216 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/statistics/basic

[GitHub] [flink] walterddr commented on a change in pull request #9576: [FLINK-13915][ml] Add several base classes of summarizer.

2019-10-17 Thread GitBox
walterddr commented on a change in pull request #9576: [FLINK-13915][ml] Add several base classes of summarizer. URL: https://github.com/apache/flink/pull/9576#discussion_r336317015 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/statistics/basic

[GitHub] [flink] walterddr commented on a change in pull request #9576: [FLINK-13915][ml] Add several base classes of summarizer.

2019-10-17 Thread GitBox
walterddr commented on a change in pull request #9576: [FLINK-13915][ml] Add several base classes of summarizer. URL: https://github.com/apache/flink/pull/9576#discussion_r336317421 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/statistics/basic

[jira] [Commented] (FLINK-14445) Python module build failed when making sdist

2019-10-17 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954253#comment-16954253 ] Dian Fu commented on FLINK-14445: - [~yunta]  Thanks for reporting this issue. It seems t

[GitHub] [flink] flinkbot edited a comment on issue #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication. URL: https://github.com/apache/flink/pull/9732#issuecomment-533540408 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbo

[GitHub] [flink] walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication.

2019-10-17 Thread GitBox
walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication. URL: https://github.com/apache/flink/pull/9732#discussion_r336316035 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org

[GitHub] [flink] flinkbot edited a comment on issue #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication. URL: https://github.com/apache/flink/pull/9732#issuecomment-533540408 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbo

[GitHub] [flink] walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication.

2019-10-17 Thread GitBox
walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication. URL: https://github.com/apache/flink/pull/9732#discussion_r336315170 ## File path: flink-ml-parent/flink-ml-lib/src/test/java/org

[GitHub] [flink] walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication.

2019-10-17 Thread GitBox
walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication. URL: https://github.com/apache/flink/pull/9732#discussion_r336314745 ## File path: flink-ml-parent/flink-ml-lib/src/test/java/org

[GitHub] [flink] walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication.

2019-10-17 Thread GitBox
walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to BLAS a method that performs DenseMatrix and SparseVector multiplication. URL: https://github.com/apache/flink/pull/9732#discussion_r336313420 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org

[GitHub] [flink] flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build URL: https://github.com/apache/flink/pull/9783#issuecomment-535848177 ## CI report: * 5d9e3113e10bbf0220b4f8e080ecd1cddd9c9059 : FAILURE [Build](http

[GitHub] [flink] flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#issuecomment-535435111 ## CI report: * 1aad21713df6970025319183b3774aec674fefde : SUCCESS [Bu

[GitHub] [flink] flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#issuecomment-535430586 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot

[GitHub] [flink] zhuzhurk commented on a change in pull request #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
zhuzhurk commented on a change in pull request #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#discussion_r336312977 ## File path: flink-runtime/src/main/java/org/apache/flink/run

[GitHub] [flink] flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778#issuecomment-535430586 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot

[GitHub] [flink] flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#issuecomment-541418126 ## CI report: * ec7f1a70fd420d25326e49ac1f4de878d4aae481 : FAILURE [Build](https://trav

[GitHub] [flink] flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering URL: https://github.com/apache/flink/pull/9853#issuecomment-539472188 ## CI report: * b10f5603fc55999adb8d5334a3d142d20322de5b : SUCCESS [Build](https://travis-ci.co

[GitHub] [flink] flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#issuecomment-541416833 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the comm

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r336296251 ## File path: flink-python/pyflink/table/table_environment.py ## @@ -47,

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r336297346 ## File path: flink-python/pyflink/table/udf.py ## @@ -167,13 +166,25 @@

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r336298507 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/fli

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r336297753 ## File path: flink-python/pyflink/testing/test_case_utils.py ## @@ -149

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r336300424 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/fli

[GitHub] [flink] dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
dianfu commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#discussion_r336311539 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/fli

[GitHub] [flink] flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build URL: https://github.com/apache/flink/pull/9783#issuecomment-535848177 ## CI report: * 5d9e3113e10bbf0220b4f8e080ecd1cddd9c9059 : FAILURE [Build](http

[jira] [Commented] (FLINK-14308) Kafka09ProducerITCase>KafkaProducerTestBase.testOneToOneAtLeastOnceCustomOperator fails on Travis

2019-10-17 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954238#comment-16954238 ] Yun Tang commented on FLINK-14308: -- Another instance: https://api.travis-ci.com/v3/job/

[GitHub] [flink] flinkbot edited a comment on issue #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage. URL: https://github.com/apache/flink/pull/9894#issuecomment-541555428 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] wuchong edited a comment on issue #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage.

2019-10-17 Thread GitBox
wuchong edited a comment on issue #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage. URL: https://github.com/apache/flink/pull/9894#issuecomment-543482276 Hi @hequn8128 , the part of blink looks good to me. I only left a comment about the naming of `containsF

[GitHub] [flink] wuchong commented on issue #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage.

2019-10-17 Thread GitBox
wuchong commented on issue #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage. URL: https://github.com/apache/flink/pull/9894#issuecomment-543482276 Hi @hequn8128 , the part of blink looks good to me. I only left a comment about the naming of `containsFunction

[GitHub] [flink] wuchong commented on a change in pull request #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage.

2019-10-17 Thread GitBox
wuchong commented on a change in pull request #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage. URL: https://github.com/apache/flink/pull/9894#discussion_r336310564 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/t

[GitHub] [flink] wuchong commented on a change in pull request #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage.

2019-10-17 Thread GitBox
wuchong commented on a change in pull request #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage. URL: https://github.com/apache/flink/pull/9894#discussion_r336310564 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/t

[GitHub] [flink] flinkbot edited a comment on issue #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage.

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage. URL: https://github.com/apache/flink/pull/9894#issuecomment-541555428 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] wuchong commented on a change in pull request #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage.

2019-10-17 Thread GitBox
wuchong commented on a change in pull request #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage. URL: https://github.com/apache/flink/pull/9894#discussion_r336310564 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/t

[jira] [Comment Edited] (FLINK-14445) Python module build failed when making sdist

2019-10-17 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954232#comment-16954232 ] Yun Tang edited comment on FLINK-14445 at 10/18/19 3:45 AM:

[jira] [Commented] (FLINK-14445) Python module build failed when making sdist

2019-10-17 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954232#comment-16954232 ] Yun Tang commented on FLINK-14445: -- CC [~dianfu] > Python module build failed when mak

[jira] [Closed] (FLINK-14237) No need to rename shipped Flink jar

2019-10-17 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-14237. - Resolution: Fixed master via b022a26b34d7ada92fa459e62f7ec84ce85cfe6f > No need to rename shipped Flink

[GitHub] [flink] flinkbot edited a comment on issue #9861: [FLINK-14237][yarn] No need to rename shipped Flink jar

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9861: [FLINK-14237][yarn] No need to rename shipped Flink jar URL: https://github.com/apache/flink/pull/9861#issuecomment-539888511 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[GitHub] [flink] flinkbot edited a comment on issue #9861: [FLINK-14237][yarn] No need to rename shipped Flink jar

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9861: [FLINK-14237][yarn] No need to rename shipped Flink jar URL: https://github.com/apache/flink/pull/9861#issuecomment-539888511 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[GitHub] [flink] TisonKun closed pull request #9861: [FLINK-14237][yarn] No need to rename shipped Flink jar

2019-10-17 Thread GitBox
TisonKun closed pull request #9861: [FLINK-14237][yarn] No need to rename shipped Flink jar URL: https://github.com/apache/flink/pull/9861 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] TisonKun commented on issue #9861: [FLINK-14237][yarn] No need to rename shipped Flink jar

2019-10-17 Thread GitBox
TisonKun commented on issue #9861: [FLINK-14237][yarn] No need to rename shipped Flink jar URL: https://github.com/apache/flink/pull/9861#issuecomment-543477490 Thanks for your reminder Till. I've verified it locally with `-yj /path/to/flink-dist_2.11-1.10-SNAPSHOT.jar` and check TM log wi

[jira] [Created] (FLINK-14445) Python module build failed when making sdist

2019-10-17 Thread Yun Tang (Jira)
Yun Tang created FLINK-14445: Summary: Python module build failed when making sdist Key: FLINK-14445 URL: https://issues.apache.org/jira/browse/FLINK-14445 Project: Flink Issue Type: Bug

[GitHub] [flink] flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build URL: https://github.com/apache/flink/pull/9783#issuecomment-535844880 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help

[GitHub] [flink] flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#issuecomment-541418126 ## CI report: * ec7f1a70fd420d25326e49ac1f4de878d4aae481 : FAILURE [Build](https://trav

[GitHub] [flink] flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF URL: https://github.com/apache/flink/pull/9890#issuecomment-541418126 ## CI report: * ec7f1a70fd420d25326e49ac1f4de878d4aae481 : FAILURE [Build](https://trav

[GitHub] [flink] flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering URL: https://github.com/apache/flink/pull/9853#issuecomment-539472188 ## CI report: * b10f5603fc55999adb8d5334a3d142d20322de5b : SUCCESS [Build](https://travis-ci.co

[GitHub] [flink] flinkbot edited a comment on issue #9930: [FLINK-12848][table] Fix invalid row type caching

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9930: [FLINK-12848][table] Fix invalid row type caching URL: https://github.com/apache/flink/pull/9930#issuecomment-543227145 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull r

[jira] [Commented] (FLINK-12574) using sink StreamingFileSink files are overwritten when resuming application causing data loss

2019-10-17 Thread lichong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954207#comment-16954207 ] lichong commented on FLINK-12574: - [~yitz589] I think it's all right for the flink desig

[GitHub] [flink] flinkbot edited a comment on issue #8737: [FLINK-12848][core] Consider fieldNames in RowTypeInfo#equals()

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #8737: [FLINK-12848][core] Consider fieldNames in RowTypeInfo#equals() URL: https://github.com/apache/flink/pull/8737#issuecomment-502016582 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

[GitHub] [flink] wuchong commented on issue #8737: [FLINK-12848][core] Consider fieldNames in RowTypeInfo#equals()

2019-10-17 Thread GitBox
wuchong commented on issue #8737: [FLINK-12848][core] Consider fieldNames in RowTypeInfo#equals() URL: https://github.com/apache/flink/pull/8737#issuecomment-543458523 We will quick fix in `FlinkTypeFactory`, see #9930 We will fix `RowTypeInfo.equals` in FLINK-14438 in the future.

[GitHub] [flink] wuchong closed pull request #8737: [FLINK-12848][core] Consider fieldNames in RowTypeInfo#equals()

2019-10-17 Thread GitBox
wuchong closed pull request #8737: [FLINK-12848][core] Consider fieldNames in RowTypeInfo#equals() URL: https://github.com/apache/flink/pull/8737 This is an automated message from the Apache Git Service. To respond to the me

[jira] [Comment Edited] (FLINK-9953) Active Kubernetes integration

2019-10-17 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-9953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954206#comment-16954206 ] Yang Wang edited comment on FLINK-9953 at 10/18/19 2:32 AM: I

[jira] [Commented] (FLINK-9953) Active Kubernetes integration

2019-10-17 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-9953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954206#comment-16954206 ] Yang Wang commented on FLINK-9953: -- I have made an new complete implementation based on

[jira] [Commented] (FLINK-14428) Non-consistency key access in KeyedProcessFunction when use keyed state api in both processElement and onTimer method

2019-10-17 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954205#comment-16954205 ] vinoyang commented on FLINK-14428: -- I read the source code again, you are right. It's n

[jira] [Issue Comment Deleted] (FLINK-14428) Non-consistency key access in KeyedProcessFunction when use keyed state api in both processElement and onTimer method

2019-10-17 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated FLINK-14428: - Comment: was deleted (was: [~aljoscha] It seems after 1.9+ we introduced {{MailboxProcessor}} it is not

[GitHub] [flink] flinkbot edited a comment on issue #9931: [FLINK-14441][Table-Common] Fix ValueLiteralExpression#getValueAs when valueClass is Period.class

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9931: [FLINK-14441][Table-Common] Fix ValueLiteralExpression#getValueAs when valueClass is Period.class URL: https://github.com/apache/flink/pull/9931#issuecomment-543240888 ## CI report: * a91235b01f24114bd0634f15dfaedc04a280b250 : FAILURE [B

[GitHub] [flink] flinkbot edited a comment on issue #9916: [FLINK-14408][Table-Planner]UDF's open method is invoked to initialize when sql is optimized in oldPlanner

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9916: [FLINK-14408][Table-Planner]UDF's open method is invoked to initialize when sql is optimized in oldPlanner URL: https://github.com/apache/flink/pull/9916#issuecomment-542764294 ## CI report: * cd122b399a8dc12c3c604d7db6dea012ee7c0c7f : SU

[GitHub] [flink] flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering

2019-10-17 Thread GitBox
flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering URL: https://github.com/apache/flink/pull/9853#issuecomment-539467530 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] ifndef-SleePy commented on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering

2019-10-17 Thread GitBox
ifndef-SleePy commented on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering URL: https://github.com/apache/flink/pull/9853#issuecomment-543453584 @flinkbot run travis This is an automated m

  1   2   3   4   5   6   7   >