[GitHub] [flink] flinkbot edited a comment on pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11916: URL: https://github.com/apache/flink/pull/11916#issuecomment-619702040 ## CI report: * 6c4876c5e0c19afae95c808429442ad65c2585ca Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162152459) Azure:

[GitHub] [flink] KarmaGYZ commented on a change in pull request #11615: [FLINK-16605] Add max limitation to the total number of slots

2020-04-27 Thread GitBox
KarmaGYZ commented on a change in pull request #11615: URL: https://github.com/apache/flink/pull/11615#discussion_r415641552 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java ## @@ -808,16 +850,31 @@ private

[GitHub] [flink] flinkbot edited a comment on pull request #11917: [FLINK-15591][table] Support create/drop temporary table in Flink SQL

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11917: URL: https://github.com/apache/flink/pull/11917#issuecomment-619827493 ## CI report: * 487163f267a4f86452a7588f58182e534b5d7193 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162180374) Azure:

[GitHub] [flink] HuangXingBo edited a comment on pull request #11860: [FLINK-17311][python][AZP] Add the logic of compressed in tgz before uploading artifacts

2020-04-27 Thread GitBox
HuangXingBo edited a comment on pull request #11860: URL: https://github.com/apache/flink/pull/11860#issuecomment-619840791 Thanks, @rmetzger . I just rebased to current master. The logic will be only tested in cron job. And I have tested related test in my free Azure CI

[GitHub] [flink] flinkbot edited a comment on pull request #11870: [FLINK-17117][SQL-Blink]Remove useless cast class code for processElement method in SourceCon…

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11870: URL: https://github.com/apache/flink/pull/11870#issuecomment-618183162 ## CI report: * dc7d6a747ef944547248143932f3cadb48ec27c8 UNKNOWN * fc2da2c4186376b26c9f06ffc51c1e2c602dfd0c Travis:

[GitHub] [flink] flinkbot edited a comment on pull request #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11877: URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998 ## CI report: * ca6f75c37da358874cc38d7998bce5c4445feff5 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/162162353) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11886: [FLINK-17074] Deprecate key based methods that do not use KeySelector in Datastreams API

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11886: URL: https://github.com/apache/flink/pull/11886#issuecomment-618445341 ## CI report: * 41c07bdb9baa8798c8d61e267822d25b6c45714b Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161827268) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11839: [FLINK-17166][dist] Modify the log4j-console.properties to also output logs into the files for WebUI

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11839: URL: https://github.com/apache/flink/pull/11839#issuecomment-617042256 ## CI report: * ab5e8324f0ace63d1e5b3f292dd6d517b056fd21 UNKNOWN * 2c1df7529825b6a0af7e57d29febeade36a758b1 Travis:

[GitHub] [flink] HuangXingBo commented on pull request #11860: [FLINK-17311][python][AZP] Add the logic of compressed in tgz before uploading artifacts

2020-04-27 Thread GitBox
HuangXingBo commented on pull request #11860: URL: https://github.com/apache/flink/pull/11860#issuecomment-619840791 Thanks, @rmetzger . I just rebased to current master. The logic will be only tested in corn job. And I have tested related test in my free Azure CI

[GitHub] [flink] flinkbot edited a comment on pull request #11897: [FLINK-16104] Translate "Streaming Aggregation" page of "Table API & SQL" into Chinese

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11897: URL: https://github.com/apache/flink/pull/11897#issuecomment-618812841 ## CI report: * 67027fc17a69ef4edc8300e4b82a9e1233b016ee UNKNOWN * da909ac1e2831251bf60375a080cc192e4e4a0c8 Travis:

[GitHub] [flink] flinkbot edited a comment on pull request #11903: [FLINK-16661] Add support for Application Mode to YARN.

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11903: URL: https://github.com/apache/flink/pull/11903#issuecomment-619010246 ## CI report: * 5e674f06f0ba363430a5f9ec4f2badeac7e77302 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161952969) Azure:

[jira] [Commented] (FLINK-17200) Add connectors to ClickHouse

2020-04-27 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093222#comment-17093222 ] Robert Metzger commented on FLINK-17200: Apache Beam has a Clickhouse integration, and I found

[GitHub] [flink] flinkbot edited a comment on pull request #11363: [FLINK-16440][runtime] Extend SlotManager metrics and status for dynamic slot allocation.

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11363: URL: https://github.com/apache/flink/pull/11363#issuecomment-596992287 ## CI report: * eb5236c06e0774a48698e33028466ad3bcbfff3a Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162038576) Azure:

[GitHub] [flink] flinkbot commented on pull request #11918: [FLINK-17405] [sql-client] add test cases for cancel job in SQL client

2020-04-27 Thread GitBox
flinkbot commented on pull request #11918: URL: https://github.com/apache/flink/pull/11918#issuecomment-619840439 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] caozhen1937 opened a new pull request #11919: [hotfix] [docs] fix state_processor_api doc, is spelling mistakes.

2020-04-27 Thread GitBox
caozhen1937 opened a new pull request #11919: URL: https://github.com/apache/flink/pull/11919 ## What is the purpose of the change There is some spelling mistakes in state_processor_api.md, E.g ”getExecutionEnviornment“. ## Brief change log modify

[jira] [Updated] (FLINK-17405) add test cases for cancel job in SQL client

2020-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-17405: --- Labels: pull-request-available (was: ) > add test cases for cancel job in SQL client >

[GitHub] [flink] godfreyhe opened a new pull request #11918: [FLINK-17405] [sql-client] add test cases for cancel job in SQL client

2020-04-27 Thread GitBox
godfreyhe opened a new pull request #11918: URL: https://github.com/apache/flink/pull/11918 ## What is the purpose of the change *some test cases was reverted because them don't work under some race conditions. see

[jira] [Created] (FLINK-17406) add documentation about dynamic table options

2020-04-27 Thread Kurt Young (Jira)
Kurt Young created FLINK-17406: -- Summary: add documentation about dynamic table options Key: FLINK-17406 URL: https://issues.apache.org/jira/browse/FLINK-17406 Project: Flink Issue Type:

[GitHub] [flink] aljoscha commented on pull request #11886: [FLINK-17074] Deprecate key based methods that do not use KeySelector in Datastreams API

2020-04-27 Thread GitBox
aljoscha commented on pull request #11886: URL: https://github.com/apache/flink/pull/11886#issuecomment-619835868 Thanks, I'll take a look! By the way, I prefer shorter commit titles, but it's up to you. Some people like putting the tags, but for example in the github view the

[GitHub] [flink] rmetzger commented on pull request #11860: [FLINK-17311][python][AZP] Add the logic of compressed in tgz before uploading artifacts

2020-04-27 Thread GitBox
rmetzger commented on pull request #11860: URL: https://github.com/apache/flink/pull/11860#issuecomment-619835761 @HuangXingBo was the force push from c94cfb4 to db62ebb just a rebase to current master? Do you think we can merge this PR as is, or should we try to manually trigger a CI

[jira] [Commented] (FLINK-15669) SQL client can't cancel flink job

2020-04-27 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093212#comment-17093212 ] Aljoscha Krettek commented on FLINK-15669: -- Thanks for the fast response, [~godfreyhe]! > SQL

[jira] [Created] (FLINK-17405) add test cases for cancel job in SQL client

2020-04-27 Thread godfrey he (Jira)
godfrey he created FLINK-17405: -- Summary: add test cases for cancel job in SQL client Key: FLINK-17405 URL: https://issues.apache.org/jira/browse/FLINK-17405 Project: Flink Issue Type:

[GitHub] [flink] aljoscha commented on pull request #8871: [FLINK-12976] Bump Kafka client version to 2.3.0 for universal Kafka connector

2020-04-27 Thread GitBox
aljoscha commented on pull request #8871: URL: https://github.com/apache/flink/pull/8871#issuecomment-619832253 I'm closing this for now since there are non-trivial issues with updating Kafka past 2.2.x. See

[jira] [Commented] (FLINK-16638) Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs

2020-04-27 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093203#comment-17093203 ] Roman Khachatryan commented on FLINK-16638: --- Hi [~edu05], Thanks a lot for offering your

[GitHub] [flink] docete commented on a change in pull request #11917: [FLINK-15591][table] Support create/drop temporary table in Flink SQL

2020-04-27 Thread GitBox
docete commented on a change in pull request #11917: URL: https://github.com/apache/flink/pull/11917#discussion_r415627411 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala ## @@ -137,6 +137,28 @@ class

[GitHub] [flink] aljoscha commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12

2020-04-27 Thread GitBox
aljoscha commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-619830497 I'm running the test locally now. This is an automated message from the Apache Git Service. To respond to the

[jira] [Comment Edited] (FLINK-17356) Properly set constraints (PK and UNIQUE)

2020-04-27 Thread Flavio Pompermaier (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093201#comment-17093201 ] Flavio Pompermaier edited comment on FLINK-17356 at 4/27/20, 8:47 AM:

[jira] [Commented] (FLINK-17356) Properly set constraints (PK and UNIQUE)

2020-04-27 Thread Flavio Pompermaier (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093201#comment-17093201 ] Flavio Pompermaier commented on FLINK-17356: I think that it's not bad to have them

[jira] [Commented] (FLINK-15669) SQL client can't cancel flink job

2020-04-27 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093199#comment-17093199 ] godfrey he commented on FLINK-15669: I can create a random source which could be a bounded or

[GitHub] [flink] flinkbot edited a comment on pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11916: URL: https://github.com/apache/flink/pull/11916#issuecomment-619702040 ## CI report: * 6c4876c5e0c19afae95c808429442ad65c2585ca Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162152459) Azure:

[GitHub] [flink] flinkbot commented on pull request #11917: [FLINK-15591][table] Support create/drop temporary table in Flink SQL

2020-04-27 Thread GitBox
flinkbot commented on pull request #11917: URL: https://github.com/apache/flink/pull/11917#issuecomment-619827493 ## CI report: * 487163f267a4f86452a7588f58182e534b5d7193 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] aljoscha commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12

2020-04-27 Thread GitBox
aljoscha commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-619824128 Ah sorry @tillrohrmann! While you were writing your message I was merging the PR. I was assuming that azure and travis run the Scala 2.12 profiles. What should we do?

[jira] [Commented] (FLINK-17359) Entropy key is not resolved if flink-s3-fs-hadoop is added as a plugin

2020-04-27 Thread Yu Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093191#comment-17093191 ] Yu Li commented on FLINK-17359: --- Got it, thanks for the note [~aljoscha]! > Entropy key is not resolved

[GitHub] [flink] echauchot commented on pull request #11886: [FLINK-17074] Deprecate key based methods that do not use KeySelector in Datastreams API

2020-04-27 Thread GitBox
echauchot commented on pull request #11886: URL: https://github.com/apache/flink/pull/11886#issuecomment-619820857 Done, PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] aljoscha commented on pull request #11880: [hotfix] Set kafka-schema-registry-client to 4.1.0 in NOTICE

2020-04-27 Thread GitBox
aljoscha commented on pull request #11880: URL: https://github.com/apache/flink/pull/11880#issuecomment-619819997 I saw you already reported the pubsub instability, so not reporting this instance. This is an automated

[GitHub] [flink] flinkbot edited a comment on pull request #11870: [FLINK-17117][SQL-Blink]Remove useless cast class code for processElement method in SourceCon…

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11870: URL: https://github.com/apache/flink/pull/11870#issuecomment-618183162 ## CI report: * dc7d6a747ef944547248143932f3cadb48ec27c8 UNKNOWN * fc2da2c4186376b26c9f06ffc51c1e2c602dfd0c Travis:

[GitHub] [flink] dawidwys commented on a change in pull request #11902: [FLINK-17370][table-common] Ensure deterministic type inference extraction

2020-04-27 Thread GitBox
dawidwys commented on a change in pull request #11902: URL: https://github.com/apache/flink/pull/11902#discussion_r415587181 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/utils/ExtractionUtils.java ## @@ -415,13 +418,17 @@

[GitHub] [flink] aljoscha commented on pull request #11880: [hotfix] Set kafka-schema-registry-client to 4.1.0 in NOTICE

2020-04-27 Thread GitBox
aljoscha commented on pull request #11880: URL: https://github.com/apache/flink/pull/11880#issuecomment-619819041 Good catch! I'm merging. This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (FLINK-17356) Properly set constraints (PK and UNIQUE)

2020-04-27 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093179#comment-17093179 ] Dawid Wysakowicz commented on FLINK-17356: -- The PKs are used by the planner already. The only

[GitHub] [flink] dawidwys commented on pull request #11848: [FLINK-17313]fix type validation error when sink table ddl exists column with precision of decimal/varchar

2020-04-27 Thread GitBox
dawidwys commented on pull request #11848: URL: https://github.com/apache/flink/pull/11848#issuecomment-619818591 I will review it today. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] aljoscha commented on pull request #11891: [FLINK-17359] [flink-core] Fixing EntropyInjector to resolve entropy for ClassLoaderFixingFileSystem

2020-04-27 Thread GitBox
aljoscha commented on pull request #11891: URL: https://github.com/apache/flink/pull/11891#issuecomment-619818582 @premsantosh Thanks a lot for analyzing and fixing this bug!  I merged. This is an automated message

[jira] [Closed] (FLINK-17359) Entropy key is not resolved if flink-s3-fs-hadoop is added as a plugin

2020-04-27 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-17359. Fix Version/s: 1.10.2 1.11.0 Resolution: Fixed release-1.10:

[GitHub] [flink] KurtYoung commented on a change in pull request #11917: [FLINK-15591][table] Support create/drop temporary table in Flink SQL

2020-04-27 Thread GitBox
KurtYoung commented on a change in pull request #11917: URL: https://github.com/apache/flink/pull/11917#discussion_r415605040 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java ## @@ -649,16 +649,32 @@

[jira] [Commented] (FLINK-17356) Properly set constraints (PK and UNIQUE)

2020-04-27 Thread Flavio Pompermaier (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093166#comment-17093166 ] Flavio Pompermaier commented on FLINK-17356: Yes I know tat they are not used right now, but

[GitHub] [flink] tillrohrmann commented on a change in pull request #11363: [FLINK-16440][runtime] Extend SlotManager metrics and status for dynamic slot allocation.

2020-04-27 Thread GitBox
tillrohrmann commented on a change in pull request #11363: URL: https://github.com/apache/flink/pull/11363#discussion_r415595187 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/StandaloneResourceManagerFactory.java ## @@ -30,32 +30,35 @@

[jira] [Updated] (FLINK-16198) FileUtilsTest fails on Mac OS

2020-04-27 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-16198: - Labels: starter (was: ) > FileUtilsTest fails on Mac OS >

[jira] [Updated] (FLINK-17376) Remove deprecated state access methods

2020-04-27 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-17376: - Labels: starter (was: ) > Remove deprecated state access methods >

[GitHub] [flink] flinkbot edited a comment on pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11916: URL: https://github.com/apache/flink/pull/11916#issuecomment-619702040 ## CI report: * 6c4876c5e0c19afae95c808429442ad65c2585ca Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162152459) Azure:

[jira] [Commented] (FLINK-17356) Properly set constraints (PK and UNIQUE)

2020-04-27 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093159#comment-17093159 ] Dawid Wysakowicz commented on FLINK-17356: -- I really don't have a strong opinion on it. I'll

[jira] [Updated] (FLINK-17376) Remove deprecated state access methods

2020-04-27 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-17376: - Priority: Critical (was: Blocker) > Remove deprecated state access methods >

[GitHub] [flink] flinkbot edited a comment on pull request #11913: [FLINK-17328][rest]Expose network metric for job vertex in rest api

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11913: URL: https://github.com/apache/flink/pull/11913#issuecomment-619511945 ## CI report: * 0c722f3e3cb9e4c5b6e173b46e4c6c53429c7bdc UNKNOWN * 3a504cf4cfb4ac0bc2d71b7a8d37ebe440cc84d5 Travis:

[GitHub] [flink] flinkbot edited a comment on pull request #11876: [FLINK-17334] HIVE UDF BUGFIX

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11876: URL: https://github.com/apache/flink/pull/11876#issuecomment-618262946 ## CI report: * 2a7b13805feb162cf26a374609d6e03af6a58990 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/162145298) Azure:

[GitHub] [flink] flinkbot commented on pull request #11917: [FLINK-15591][table] Support create/drop temporary table in Flink SQL

2020-04-27 Thread GitBox
flinkbot commented on pull request #11917: URL: https://github.com/apache/flink/pull/11917#issuecomment-619810226 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-15591) make up for feature parity by supporting CREATE TEMPORARY TABLE/VIEW in DDL

2020-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-15591: --- Labels: pull-request-available (was: ) > make up for feature parity by supporting CREATE

[GitHub] [flink] docete opened a new pull request #11917: [FLINK-15591][table] Support create/drop temporary table in Flink SQL

2020-04-27 Thread GitBox
docete opened a new pull request #11917: URL: https://github.com/apache/flink/pull/11917 ## What is the purpose of the change This PR supports create/drop temporary table in Flink SQL ## Brief change log - e172a38 support parsing TEMPORARY in table definition in sql

[GitHub] [flink] hejianchao commented on a change in pull request #11913: [FLINK-17328][rest]Expose network metric for job vertex in rest api

2020-04-27 Thread GitBox
hejianchao commented on a change in pull request #11913: URL: https://github.com/apache/flink/pull/11913#discussion_r415595824 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/metrics/JobVertexIOMetricsInfo.java ## @@ -0,0 +1,178 @@ +/* + *

[GitHub] [flink] hejianchao commented on a change in pull request #11913: [FLINK-17328][rest]Expose network metric for job vertex in rest api

2020-04-27 Thread GitBox
hejianchao commented on a change in pull request #11913: URL: https://github.com/apache/flink/pull/11913#discussion_r415593198 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/util/MutableIOMetrics.java ## @@ -96,41 +122,67 @@ public void

[jira] [Commented] (FLINK-17351) CheckpointCoordinator and CheckpointFailureManager ignores checkpoint timeouts

2020-04-27 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093147#comment-17093147 ] Piotr Nowojski commented on FLINK-17351: [~wind_ljy] for not swallowing the original exceptions

[GitHub] [flink] hejianchao commented on a change in pull request #11913: [FLINK-17328][rest]Expose network metric for job vertex in rest api

2020-04-27 Thread GitBox
hejianchao commented on a change in pull request #11913: URL: https://github.com/apache/flink/pull/11913#discussion_r415593198 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/util/MutableIOMetrics.java ## @@ -96,41 +122,67 @@ public void

[jira] [Closed] (FLINK-1890) Add note to docs that ReadFields annotations are currently not evaluated

2020-04-27 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-1890. --- Resolution: Abandoned I'm closing this as "Abandoned", since there is no more activity and

[GitHub] [flink] hejianchao commented on a change in pull request #11913: [FLINK-17328][rest]Expose network metric for job vertex in rest api

2020-04-27 Thread GitBox
hejianchao commented on a change in pull request #11913: URL: https://github.com/apache/flink/pull/11913#discussion_r415593198 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/util/MutableIOMetrics.java ## @@ -96,41 +122,67 @@ public void

[GitHub] [flink] azagrebin commented on a change in pull request #11615: [FLINK-16605] Add max limitation to the total number of slots

2020-04-27 Thread GitBox
azagrebin commented on a change in pull request #11615: URL: https://github.com/apache/flink/pull/11615#discussion_r415579887 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImplTest.java ## @@ -1301,16 +1305,15 @@

[GitHub] [flink] hejianchao commented on a change in pull request #11913: [FLINK-17328][rest]Expose network metric for job vertex in rest api

2020-04-27 Thread GitBox
hejianchao commented on a change in pull request #11913: URL: https://github.com/apache/flink/pull/11913#discussion_r415591255 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricNames.java ## @@ -49,6 +54,27 @@ private MetricNames() {

[GitHub] [flink] hejianchao commented on a change in pull request #11913: [FLINK-17328][rest]Expose network metric for job vertex in rest api

2020-04-27 Thread GitBox
hejianchao commented on a change in pull request #11913: URL: https://github.com/apache/flink/pull/11913#discussion_r415591255 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricNames.java ## @@ -49,6 +54,27 @@ private MetricNames() {

[GitHub] [flink] rmetzger commented on pull request #11831: [FLINK-16423][e2e] Introduce timeouts for HA tests

2020-04-27 Thread GitBox
rmetzger commented on pull request #11831: URL: https://github.com/apache/flink/pull/11831#issuecomment-619801519 Thanks for the review. Let's wait till Azure is green, then I'll merge it. This is an automated message from

[jira] [Commented] (FLINK-17356) Properly set constraints (PK and UNIQUE)

2020-04-27 Thread Flavio Pompermaier (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093140#comment-17093140 ] Flavio Pompermaier commented on FLINK-17356: For me it's not a problem to revert those

[GitHub] [flink] xintongsong commented on pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-27 Thread GitBox
xintongsong commented on pull request #11916: URL: https://github.com/apache/flink/pull/11916#issuecomment-619799675 Thanks for the quick response and review, @tillrohrmann. This is an automated message from the Apache Git

[GitHub] [flink] flinkbot edited a comment on pull request #11876: [FLINK-17334] HIVE UDF BUGFIX

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11876: URL: https://github.com/apache/flink/pull/11876#issuecomment-618262946 ## CI report: * 2a7b13805feb162cf26a374609d6e03af6a58990 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/162145298) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11877: URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998 ## CI report: * ca6f75c37da358874cc38d7998bce5c4445feff5 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162162353) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11901: [FLINK-16971][python][sql-client] Support Python UDF in SQL Client.

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11901: URL: https://github.com/apache/flink/pull/11901#issuecomment-618997437 ## CI report: * f9050771eda446e3b745615362a175f54f6e7f9e Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/162159222) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11831: [FLINK-16423][e2e] Introduce timeouts for HA tests

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11831: URL: https://github.com/apache/flink/pull/11831#issuecomment-616617506 ## CI report: * 963297592d941acfb5ee77e1c495de3efd638a43 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/162165250) Azure:

[GitHub] [flink] godfreyhe commented on a change in pull request #11397: [FLINK-16217] [sql-client] catch all exceptions to avoid SQL client crashed

2020-04-27 Thread GitBox
godfreyhe commented on a change in pull request #11397: URL: https://github.com/apache/flink/pull/11397#discussion_r415584774 ## File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientTest.java ## @@ -190,6 +176,47 @@ public void

[GitHub] [flink] twalthr commented on a change in pull request #11397: [FLINK-16217] [sql-client] catch all exceptions to avoid SQL client crashed

2020-04-27 Thread GitBox
twalthr commented on a change in pull request #11397: URL: https://github.com/apache/flink/pull/11397#discussion_r415582576 ## File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientTest.java ## @@ -190,6 +176,47 @@ public void

[GitHub] [flink] tillrohrmann commented on a change in pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-27 Thread GitBox
tillrohrmann commented on a change in pull request #11916: URL: https://github.com/apache/flink/pull/11916#discussion_r415581488 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/WorkerSpecContainerResourceAdapter.java ## @@ -128,12 +142,61 @@ private int

[GitHub] [flink] ifndef-SleePy commented on a change in pull request #11831: [FLINK-16423][e2e] Introduce timeouts for HA tests

2020-04-27 Thread GitBox
ifndef-SleePy commented on a change in pull request #11831: URL: https://github.com/apache/flink/pull/11831#discussion_r415576635 ## File path: flink-end-to-end-tests/test-scripts/test_ha_per_job_cluster_datastream.sh ## @@ -148,4 +149,23 @@ STATE_BACKEND_TYPE=${1:-file}

[jira] [Commented] (FLINK-16636) TableEnvironmentITCase is crashing on Travis

2020-04-27 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093120#comment-17093120 ] Kurt Young commented on FLINK-16636: So only blink planner module tests will be executed serially?

[GitHub] [flink] echauchot commented on pull request #11886: [FLINK-17074] Deprecate key based methods that do not use KeySelector in Datastreams API

2020-04-27 Thread GitBox
echauchot commented on pull request #11886: URL: https://github.com/apache/flink/pull/11886#issuecomment-619791149 @aljoscha sure ! And I forgot as well :) This is an automated message from the Apache Git Service. To respond

[jira] [Updated] (FLINK-17194) TPC-DS end-to-end test fails due to missing execution attempt

2020-04-27 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-17194: -- Priority: Critical (was: Major) > TPC-DS end-to-end test fails due to missing execution

[jira] [Updated] (FLINK-17404) Running HA per-job cluster (rocks, non-incremental) gets stuck killing a non-existing pid

2020-04-27 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-17404: --- Summary: Running HA per-job cluster (rocks, non-incremental) gets stuck killing a

[jira] [Commented] (FLINK-17404) Running HA per-job cluster (rocks, non-incremental) gets stuck killing a non-existing pid

2020-04-27 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093109#comment-17093109 ] Robert Metzger commented on FLINK-17404: There's been a discussion on this case here:

[jira] [Commented] (FLINK-16770) Resuming Externalized Checkpoint (rocks, incremental, scale up) end-to-end test fails with no such file

2020-04-27 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093108#comment-17093108 ] Robert Metzger commented on FLINK-16770: [~SleePy] thanks again for the analysis of the log

[GitHub] [flink] flinkbot edited a comment on pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11915: URL: https://github.com/apache/flink/pull/11915#issuecomment-619697532 ## CI report: * c64af9f899aa267862f7aabcba240831c8e25cbc Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/162157240) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11916: URL: https://github.com/apache/flink/pull/11916#issuecomment-619702040 ## CI report: * 6c4876c5e0c19afae95c808429442ad65c2585ca Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162152459) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11901: [FLINK-16971][python][sql-client] Support Python UDF in SQL Client.

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11901: URL: https://github.com/apache/flink/pull/11901#issuecomment-618997437 ## CI report: * 3aa5a671f3ffbc8d1729d95700b3b37bc3e15086 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162055839) Azure:

[GitHub] [flink] hequn8128 commented on a change in pull request #11832: [FLINK-17148][python] Support converting pandas DataFrame to Flink Table

2020-04-27 Thread GitBox
hequn8128 commented on a change in pull request #11832: URL: https://github.com/apache/flink/pull/11832#discussion_r415254771 ## File path: flink-python/pyflink/table/tests/test_pandas_conversion.py ## @@ -0,0 +1,147 @@

[GitHub] [flink] azagrebin commented on a change in pull request #11615: [FLINK-16605] Add max limitation to the total number of slots

2020-04-27 Thread GitBox
azagrebin commented on a change in pull request #11615: URL: https://github.com/apache/flink/pull/11615#discussion_r415575281 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java ## @@ -390,6 +392,12 @@ public

[GitHub] [flink] flinkbot edited a comment on pull request #11831: [FLINK-16423][e2e] Introduce timeouts for HA tests

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11831: URL: https://github.com/apache/flink/pull/11831#issuecomment-616617506 ## CI report: * 8c3475f5f7883314d609c4ea126dbf7bd9cc8cc8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161065652) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11839: [FLINK-17166][dist] Modify the log4j-console.properties to also output logs into the files for WebUI

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11839: URL: https://github.com/apache/flink/pull/11839#issuecomment-617042256 ## CI report: * ab5e8324f0ace63d1e5b3f292dd6d517b056fd21 UNKNOWN * 2c1df7529825b6a0af7e57d29febeade36a758b1 Travis:

[GitHub] [flink] flinkbot edited a comment on pull request #11791: [FLINK-17210][sql-parser][hive] Implement database DDLs for Hive dialect

2020-04-27 Thread GitBox
flinkbot edited a comment on pull request #11791: URL: https://github.com/apache/flink/pull/11791#issuecomment-615162346 ## CI report: * 5ce52e3cda62c629df16d95ccb345d830b3a3531 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162145244) Azure:

[jira] [Created] (FLINK-17404) Running HA per-job cluster (rocks, non-incremental) gets stuck

2020-04-27 Thread Robert Metzger (Jira)
Robert Metzger created FLINK-17404: -- Summary: Running HA per-job cluster (rocks, non-incremental) gets stuck Key: FLINK-17404 URL: https://issues.apache.org/jira/browse/FLINK-17404 Project: Flink

[jira] [Commented] (FLINK-17390) Container resource cannot be mapped on Hadoop 2.10+

2020-04-27 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093104#comment-17093104 ] Till Rohrmann commented on FLINK-17390: --- Thanks for creating the PR so quickly. > Container

[GitHub] [flink] azagrebin commented on a change in pull request #11615: [FLINK-16605] Add max limitation to the total number of slots

2020-04-27 Thread GitBox
azagrebin commented on a change in pull request #11615: URL: https://github.com/apache/flink/pull/11615#discussion_r415573487 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java ## @@ -650,14 +658,48 @@ private

[jira] [Commented] (FLINK-17390) Container resource cannot be mapped on Hadoop 2.10+

2020-04-27 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093101#comment-17093101 ] Till Rohrmann commented on FLINK-17390: --- Sounds like a good fix to me. I've assigned you to this

[jira] [Commented] (FLINK-16636) TableEnvironmentITCase is crashing on Travis

2020-04-27 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093099#comment-17093099 ] Robert Metzger commented on FLINK-16636: [~TsReaper]: Yes, you can log the memory usage. Either

[jira] [Assigned] (FLINK-17390) Container resource cannot be mapped on Hadoop 2.10+

2020-04-27 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-17390: - Assignee: Xintong Song > Container resource cannot be mapped on Hadoop 2.10+ >

[jira] [Comment Edited] (FLINK-16636) TableEnvironmentITCase is crashing on Travis

2020-04-27 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093099#comment-17093099 ] Robert Metzger edited comment on FLINK-16636 at 4/27/20, 7:24 AM: --

[GitHub] [flink] Ruan-Xin removed a comment on pull request #11876: [FLINK-17334] HIVE UDF BUGFIX

2020-04-27 Thread GitBox
Ruan-Xin removed a comment on pull request #11876: URL: https://github.com/apache/flink/pull/11876#issuecomment-619694919 @flinkbot run travis re-run the last Travis build @flinkbot run azure re-run the last Azure build

[GitHub] [flink] Ruan-Xin commented on pull request #11876: [FLINK-17334] HIVE UDF BUGFIX

2020-04-27 Thread GitBox
Ruan-Xin commented on pull request #11876: URL: https://github.com/apache/flink/pull/11876#issuecomment-619784563 @flinkbot run travis re-run the last Travis build @flinkbot run azure re-run the last Azure build This is

[jira] [Closed] (FLINK-16746) Deprecate legacy heap memory option for JM and expose the new ones in docs

2020-04-27 Thread Andrey Zagrebin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Zagrebin closed FLINK-16746. --- Resolution: Done merged into master by b020aafb1c6356703bf019d1ec25448a247939ed >

[jira] [Closed] (FLINK-17048) Add memory related JVM args to Mesos JM startup scripts

2020-04-27 Thread Andrey Zagrebin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Zagrebin closed FLINK-17048. --- Resolution: Done merged into master by 47cf0c516de01739a098af897ac71e6c2e7b00c9 > Add

<    1   2   3   4   5   6   >