[GitHub] [flink] flinkbot edited a comment on pull request #11906: [FLINK-17356][jdbc][postgres] Support PK and Unique constraints

2020-05-19 Thread GitBox
flinkbot edited a comment on pull request #11906: URL: https://github.com/apache/flink/pull/11906#issuecomment-619214462 ## CI report: * 2e339ca93fcf4461ddb3502b49ab34083fc96cf6 UNKNOWN * 58f57832797464a1a9646223926eefe3cce2840a Azure:

[jira] [Commented] (FLINK-14982) YARN IT Test Case log config is mistakenly disabled

2020-05-19 Thread Kostas Kloudas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1794#comment-1794 ] Kostas Kloudas commented on FLINK-14982: [~ZhenqiuHuang] are you planning to integrate

[GitHub] [flink] sjwiesman commented on a change in pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

2020-05-19 Thread GitBox
sjwiesman commented on a change in pull request #12245: URL: https://github.com/apache/flink/pull/12245#discussion_r427324527 ## File path: docs/ops/deployment/native_kubernetes.md ## @@ -170,6 +170,34 @@ appender.console.layout.pattern = %d{-MM-dd HH:mm:ss,SSS} %-5p

[GitHub] [flink] pnowojski merged pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-19 Thread GitBox
pnowojski merged pull request #12120: URL: https://github.com/apache/flink/pull/12120 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] flinkbot commented on pull request #12249: [FLINK-17794][tests] Tear down installed software in reverse order

2020-05-19 Thread GitBox
flinkbot commented on pull request #12249: URL: https://github.com/apache/flink/pull/12249#issuecomment-630836787 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #12250: [FLINK-17619] Backport to 1.11

2020-05-19 Thread GitBox
flinkbot commented on pull request #12250: URL: https://github.com/apache/flink/pull/12250#issuecomment-630836675 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Commented] (FLINK-16621) Add support for custom logging configuration in docker-flink

2020-05-19 Thread Michal Lyson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1786#comment-1786 ] Michal Lyson commented on FLINK-16621: -- [~azagrebin] yes that should work for me, thanks > Add

[GitHub] [flink] twalthr edited a comment on pull request #12228: [FLINK-17541][table] Support inline structured types

2020-05-19 Thread GitBox
twalthr edited a comment on pull request #12228: URL: https://github.com/apache/flink/pull/12228#issuecomment-630834686 @dawidwys I updated the PR. I found another shortcoming that I fixed while addressing your comments.

[jira] [Created] (FLINK-17813) Manually test unaligned checkpoints on a cluster

2020-05-19 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-17813: -- Summary: Manually test unaligned checkpoints on a cluster Key: FLINK-17813 URL: https://issues.apache.org/jira/browse/FLINK-17813 Project: Flink Issue

[GitHub] [flink] twalthr commented on pull request #12228: [FLINK-17541][table] Support inline structured types

2020-05-19 Thread GitBox
twalthr commented on pull request #12228: URL: https://github.com/apache/flink/pull/12228#issuecomment-630834686 @dawidwys I updated the PR. This is an automated message from the Apache Git Service. To respond to the

[jira] [Closed] (FLINK-17737) KeyedStateCheckpointingITCase fails in UnalignedCheckpoint mode

2020-05-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-17737. -- Resolution: Fixed > KeyedStateCheckpointingITCase fails in UnalignedCheckpoint mode >

[GitHub] [flink] godfreyhe commented on pull request #12199: [FLINK-17774] [table] supports all kinds of changes for select result

2020-05-19 Thread GitBox
godfreyhe commented on pull request #12199: URL: https://github.com/apache/flink/pull/12199#issuecomment-630833708 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (FLINK-16945) Execute CheckpointFailureManager.FailJobCallback directly in main thread executor

2020-05-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-16945: --- Fix Version/s: (was: 1.11.0) 1.12.0 > Execute

[jira] [Updated] (FLINK-17413) Refactor the usages of ThreadSafeUnaligner#storeNewBuffers

2020-05-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-17413: --- Fix Version/s: 1.12.0 > Refactor the usages of ThreadSafeUnaligner#storeNewBuffers >

[jira] [Assigned] (FLINK-17051) Persist spilled records of SpillingAdaptiveSpanningRecordDeserializer

2020-05-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-17051: -- Assignee: Roman Khachatryan (was: Piotr Nowojski) > Persist spilled records of

[jira] [Updated] (FLINK-17741) Create integration or e2e test for out of order (savepoint) barriers

2020-05-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-17741: --- Fix Version/s: 1.11.0 > Create integration or e2e test for out of order (savepoint)

[jira] [Updated] (FLINK-16012) Reduce the default number of exclusive buffers from 2 to 1 on receiver side

2020-05-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-16012: --- Fix Version/s: (was: 1.11.0) 1.12.0 > Reduce the default number of

[jira] [Updated] (FLINK-17572) Remove checkpoint alignment buffered metric from webui

2020-05-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-17572: --- Fix Version/s: 1.12.0 > Remove checkpoint alignment buffered metric from webui >

[jira] [Updated] (FLINK-16641) Announce sender's backlog to solve the deadlock issue without exclusive buffers

2020-05-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-16641: --- Fix Version/s: (was: 1.11.0) 1.12.0 > Announce sender's backlog to

[jira] [Updated] (FLINK-16428) Fine-grained network buffer management for backpressure

2020-05-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-16428: --- Fix Version/s: (was: 1.11.0) 1.12.0 > Fine-grained network buffer

[jira] [Commented] (FLINK-14982) YARN IT Test Case log config is mistakenly disabled

2020-05-19 Thread Kostas Kloudas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1783#comment-1783 ] Kostas Kloudas commented on FLINK-14982: In all other cases, job submission goes through the

[GitHub] [flink] fpompermaier commented on pull request #11906: [FLINK-17356][jdbc][postgres] Support PK and Unique constraints

2020-05-19 Thread GitBox
fpompermaier commented on pull request #11906: URL: https://github.com/apache/flink/pull/11906#issuecomment-630830688 I addressed your comments, now the PR should be ok This is an automated message from the Apache Git

[GitHub] [flink] gyfora commented on pull request #12250: [FLINK-17619] Backport to 1.11

2020-05-19 Thread GitBox
gyfora commented on pull request #12250: URL: https://github.com/apache/flink/pull/12250#issuecomment-630830243 @leonardBang cc :) This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Comment Edited] (FLINK-17077) FLINK_CONF_DIR environment variable to locate flink-conf.yaml in Docker container

2020-05-19 Thread Andrey Zagrebin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1772#comment-1772 ] Andrey Zagrebin edited comment on FLINK-17077 at 5/19/20, 1:46 PM: --- I

[jira] [Comment Edited] (FLINK-16621) Add support for custom logging configuration in docker-flink

2020-05-19 Thread Andrey Zagrebin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1782#comment-1782 ] Andrey Zagrebin edited comment on FLINK-16621 at 5/19/20, 1:46 PM: ---

[GitHub] [flink] gyfora opened a new pull request #12250: [FLINK-17619] Backport to 1.11

2020-05-19 Thread GitBox
gyfora opened a new pull request #12250: URL: https://github.com/apache/flink/pull/12250 …ied for Kafka table source ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That

[jira] [Commented] (FLINK-16621) Add support for custom logging configuration in docker-flink

2020-05-19 Thread Andrey Zagrebin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1782#comment-1782 ] Andrey Zagrebin commented on FLINK-16621: - [~michallyson] You could also [mount a volume to

[GitHub] [flink] pnowojski commented on pull request #12243: [FLINK-17805][networ] Fix ArrayIndexOutOfBound for rotated input gate indexes

2020-05-19 Thread GitBox
pnowojski commented on pull request #12243: URL: https://github.com/apache/flink/pull/12243#issuecomment-630828142 Test failure is unrelated and fixed on more recent master by some commit (don't know which) This is an

[jira] [Created] (FLINK-17812) Bundled reporters in plugins/ directory

2020-05-19 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-17812: Summary: Bundled reporters in plugins/ directory Key: FLINK-17812 URL: https://issues.apache.org/jira/browse/FLINK-17812 Project: Flink Issue Type:

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427311721 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -142,6 +187,13 @@

[jira] [Comment Edited] (FLINK-17077) FLINK_CONF_DIR environment variable to locate flink-conf.yaml in Docker container

2020-05-19 Thread Andrey Zagrebin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1772#comment-1772 ] Andrey Zagrebin edited comment on FLINK-17077 at 5/19/20, 1:40 PM: --- I

[GitHub] [flink] GJL opened a new pull request #12249: [FLINK-17794][tests] Tear down installed software in reverse order

2020-05-19 Thread GitBox
GJL opened a new pull request #12249: URL: https://github.com/apache/flink/pull/12249 ## What is the purpose of the change *Tear down installed software in reverse order in Jepsen tests. This mitigates the issue that sometimes YARN's NodeManager directories cannot be removed using

[jira] [Updated] (FLINK-17794) Tear down installed software in reverse order in Jepsen Tests

2020-05-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-17794: --- Labels: pull-request-available (was: ) > Tear down installed software in reverse order in

[jira] [Commented] (FLINK-17077) FLINK_CONF_DIR environment variable to locate flink-conf.yaml in Docker container

2020-05-19 Thread Andrey Zagrebin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1772#comment-1772 ] Andrey Zagrebin commented on FLINK-17077: - I see you concern. The reason, the ports are

[jira] [Closed] (FLINK-17634) Reject multiple handler registrations under the same URL

2020-05-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-17634. Resolution: Fixed master: 260ef2cf78970674ca5cad4a9f456b9a93110c69 1.11: > Reject

[jira] [Comment Edited] (FLINK-17077) FLINK_CONF_DIR environment variable to locate flink-conf.yaml in Docker container

2020-05-19 Thread Andrey Zagrebin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1772#comment-1772 ] Andrey Zagrebin edited comment on FLINK-17077 at 5/19/20, 1:37 PM: --- I

[jira] [Comment Edited] (FLINK-17077) FLINK_CONF_DIR environment variable to locate flink-conf.yaml in Docker container

2020-05-19 Thread Andrey Zagrebin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1772#comment-1772 ] Andrey Zagrebin edited comment on FLINK-17077 at 5/19/20, 1:34 PM: --- I

[jira] [Closed] (FLINK-16970) Bundle JMXReporter separately from dist jar

2020-05-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-16970. Resolution: Fixed master: c770f8eaa7241392aa4be4260fc3772f832e5494 1.11:

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427308234 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -126,6 +162,15 @@

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427304005 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncCheckpointRunnables.java ## @@ -0,0 +1,85 @@ +/* + *

[jira] [Comment Edited] (FLINK-17634) Reject multiple handler registrations under the same URL

2020-05-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1775#comment-1775 ] Chesnay Schepler edited comment on FLINK-17634 at 5/19/20, 1:38 PM:

[GitHub] [flink] zentol merged pull request #12100: [FLINK-17634][rest] Reject multiple registration for the same endpoint

2020-05-19 Thread GitBox
zentol merged pull request #12100: URL: https://github.com/apache/flink/pull/12100 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] flinkbot edited a comment on pull request #12234: [FLINK-16986][coordination] Provide exactly-once guaranteed around checkpoints and operator event sending

2020-05-19 Thread GitBox
flinkbot edited a comment on pull request #12234: URL: https://github.com/apache/flink/pull/12234#issuecomment-630433269 ## CI report: * 0ecc60f81b7f196441adf43500df0fdf8933eafa Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12246: [FLINK-17303][python] Return TableResult for Python TableEnvironment

2020-05-19 Thread GitBox
flinkbot edited a comment on pull request #12246: URL: https://github.com/apache/flink/pull/12246#issuecomment-630803193 ## CI report: * 2ce447aa89adaab2738a5235b41c289626877a09 Azure:

[GitHub] [flink] zentol merged pull request #11974: [FLINK-16970][build][metrics]Bundle JMXReporter separately from dist …

2020-05-19 Thread GitBox
zentol merged pull request #11974: URL: https://github.com/apache/flink/pull/11974 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] flinkbot edited a comment on pull request #12241: [FLINK-17474][parquet][hive] Parquet reader should be case insensitive for hive

2020-05-19 Thread GitBox
flinkbot edited a comment on pull request #12241: URL: https://github.com/apache/flink/pull/12241#issuecomment-630692649 ## CI report: * a16df2eb5401a92070e634c13fbc27d445069671 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source

2020-05-19 Thread GitBox
flinkbot edited a comment on pull request #12221: URL: https://github.com/apache/flink/pull/12221#issuecomment-630123655 ## CI report: * c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"

2020-05-19 Thread GitBox
flinkbot edited a comment on pull request #12213: URL: https://github.com/apache/flink/pull/12213#issuecomment-630019128 ## CI report: * f5de677e8b50e1df6c5207efe4bb11367d174207 UNKNOWN * a4a2bc16e03ff3ad12a21f218581f16971804d80 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12199: [FLINK-17774] [table] supports all kinds of changes for select result

2020-05-19 Thread GitBox
flinkbot edited a comment on pull request #12199: URL: https://github.com/apache/flink/pull/12199#issuecomment-629793563 ## CI report: * 45e76bb4ec1dda3576b82ebe4ab9ddd96d7bb244 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12248: [FLINK-17725][tests] Disable OkHttpClient timeouts for FileUploadHandlerTest

2020-05-19 Thread GitBox
flinkbot edited a comment on pull request #12248: URL: https://github.com/apache/flink/pull/12248#issuecomment-630803440 ## CI report: * ae0b32c79fb85e36132f4bd64a6721215781cf8c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12090: [FLINK-17622][connectors / jdbc] Remove useless switch for decimal in PostgresCatalog

2020-05-19 Thread GitBox
flinkbot edited a comment on pull request #12090: URL: https://github.com/apache/flink/pull/12090#issuecomment-626999634 ## CI report: * 571fa7b8465f82b73e1d1b78fb765fda4ec3a338 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11974: [FLINK-16970][build][metrics]Bundle JMXReporter separately from dist …

2020-05-19 Thread GitBox
flinkbot edited a comment on pull request #11974: URL: https://github.com/apache/flink/pull/11974#issuecomment-622652948 ## CI report: * 89c475a6df2dad3d44c4c7a37295adcb4061879f Azure:

[GitHub] [flink] pnowojski commented on pull request #12244: [FLINK-17258][network] Fix couple of ITCases that were failing with enabled unaligned checkpoints

2020-05-19 Thread GitBox
pnowojski commented on pull request #12244: URL: https://github.com/apache/flink/pull/12244#issuecomment-630815992 Test failure is unrelated and fixed on more recent master by some commit (don't know which) This is an

[jira] [Commented] (FLINK-17260) StreamingKafkaITCase failure on Azure

2020-05-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1768#comment-1768 ] Till Rohrmann commented on FLINK-17260: --- Another instance:

[jira] [Commented] (FLINK-14982) YARN IT Test Case log config is mistakenly disabled

2020-05-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1762#comment-1762 ] Till Rohrmann commented on FLINK-14982: --- I don't think that the issue has been fixed. It only

[jira] [Created] (FLINK-17811) Update docker hub Flink page

2020-05-19 Thread Andrey Zagrebin (Jira)
Andrey Zagrebin created FLINK-17811: --- Summary: Update docker hub Flink page Key: FLINK-17811 URL: https://issues.apache.org/jira/browse/FLINK-17811 Project: Flink Issue Type: Task

[jira] [Closed] (FLINK-16383) KafkaProducerExactlyOnceITCase.testExactlyOnceRegularSink fails with "The producer has already been closed"

2020-05-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-16383. -- Assignee: Arvid Heise Resolution: Fixed Fixed on master as cbd9ca0ca3 on release-1.11

[jira] [Commented] (FLINK-16402) Alter table fails on Hive catalog

2020-05-19 Thread Rui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1759#comment-1759 ] Rui Li commented on FLINK-16402: Hey [~gyfora], what's the version of your HMS? I searched Hive code

[GitHub] [flink] pnowojski merged pull request #12186: [FLINK-16383][task] Do not relay notifyCheckpointComplete to closed operators

2020-05-19 Thread GitBox
pnowojski merged pull request #12186: URL: https://github.com/apache/flink/pull/12186 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] wuchong commented on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala

2020-05-19 Thread GitBox
wuchong commented on pull request #12232: URL: https://github.com/apache/flink/pull/12232#issuecomment-630805862 Thanks @dawidwys for the explanation. As I said above, if we decide to change it, and we have to do it, then we should do it in this release. So I'm fine with this.

[GitHub] [flink] rmetzger merged pull request #12247: [hotfix] Disable e2e execution in PRs

2020-05-19 Thread GitBox
rmetzger merged pull request #12247: URL: https://github.com/apache/flink/pull/12247 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] rmetzger commented on pull request #12247: [hotfix] Disable e2e execution in PRs

2020-05-19 Thread GitBox
rmetzger commented on pull request #12247: URL: https://github.com/apache/flink/pull/12247#issuecomment-630804868 It works. Merging: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=1851=results This

[jira] [Commented] (FLINK-15620) State TTL: Remove deprecated enable default background cleanup

2020-05-19 Thread Andrey Zagrebin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1755#comment-1755 ] Andrey Zagrebin commented on FLINK-15620: - Hi [~jamesbondu], do you still want to work on this?

[jira] [Commented] (FLINK-13678) Translate "Code Style - Preamble" page into Chinese

2020-05-19 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1756#comment-1756 ] Jark Wu commented on FLINK-13678: - Hi [~chesnay], I think it's valuable to translate it. Many Chinese

[GitHub] [flink] flinkbot commented on pull request #12247: [hotfix] Disable e2e execution in PRs

2020-05-19 Thread GitBox
flinkbot commented on pull request #12247: URL: https://github.com/apache/flink/pull/12247#issuecomment-630803307 ## CI report: * 2d0b5398285a385ad2c0a7986ebf5dd37ef6d1c7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #12246: [FLINK-17303][python] Return TableResult for Python TableEnvironment

2020-05-19 Thread GitBox
flinkbot commented on pull request #12246: URL: https://github.com/apache/flink/pull/12246#issuecomment-630803193 ## CI report: * 2ce447aa89adaab2738a5235b41c289626877a09 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #12248: [FLINK-17725][tests] Disable OkHttpClient timeouts for FileUploadHandlerTest

2020-05-19 Thread GitBox
flinkbot commented on pull request #12248: URL: https://github.com/apache/flink/pull/12248#issuecomment-630803440 ## CI report: * ae0b32c79fb85e36132f4bd64a6721215781cf8c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #12090: [FLINK-17622][connectors / jdbc] Remove useless switch for decimal in PostgresCatalog

2020-05-19 Thread GitBox
flinkbot edited a comment on pull request #12090: URL: https://github.com/apache/flink/pull/12090#issuecomment-626999634 ## CI report: * 571fa7b8465f82b73e1d1b78fb765fda4ec3a338 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12230: [FLINK-17504][docs] Update Chinese translation of Getting Started / O…

2020-05-19 Thread GitBox
flinkbot edited a comment on pull request #12230: URL: https://github.com/apache/flink/pull/12230#issuecomment-630205457 ## CI report: * de4251b2c2ee31ababe1c82505c15822546a59b1 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

2020-05-19 Thread GitBox
flinkbot edited a comment on pull request #12245: URL: https://github.com/apache/flink/pull/12245#issuecomment-630784890 ## CI report: * e695add3318a20fda1d2d1336ab6ebf68b90a35a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12228: [FLINK-17541][table] Support inline structured types

2020-05-19 Thread GitBox
flinkbot edited a comment on pull request #12228: URL: https://github.com/apache/flink/pull/12228#issuecomment-630171014 ## CI report: * 5c672d3d2f0654b3c5d1a18b20d73804e450382a Azure:

[jira] [Commented] (FLINK-15621) State TTL: Remove deprecated option and method to disable TTL compaction filter

2020-05-19 Thread Andrey Zagrebin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1751#comment-1751 ] Andrey Zagrebin commented on FLINK-15621: - Hi [~jamesbondu], do you have progress here? > State

[jira] [Closed] (FLINK-17527) kubernetes-session.sh uses log4j-console.properties

2020-05-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-17527. - Fix Version/s: (was: 1.10.2) Release Note: The logging properties files

[GitHub] [flink] rmetzger commented on pull request #12247: [hotfix] Disable e2e execution in PRs

2020-05-19 Thread GitBox
rmetzger commented on pull request #12247: URL: https://github.com/apache/flink/pull/12247#issuecomment-630800767 Thx. I will merge once I see it's working as expected. This is an automated message from the Apache Git

[GitHub] [flink] asfgit closed pull request #12117: [FLINK-17619] Disable commit on checkpoints if no group.id was specif…

2020-05-19 Thread GitBox
asfgit closed pull request #12117: URL: https://github.com/apache/flink/pull/12117 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] tillrohrmann closed pull request #12236: [FLINK-17527][flink-dist] Make kubernetes-session.sh use session log4j/logback configuration files

2020-05-19 Thread GitBox
tillrohrmann closed pull request #12236: URL: https://github.com/apache/flink/pull/12236 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] tillrohrmann commented on pull request #12236: [FLINK-17527][flink-dist] Make kubernetes-session.sh use session log4j/logback configuration files

2020-05-19 Thread GitBox
tillrohrmann commented on pull request #12236: URL: https://github.com/apache/flink/pull/12236#issuecomment-630797584 Yes agreed @wangyang0918. It should only go into `1.11` and `1.12`. This is an automated message from the

[jira] [Commented] (FLINK-17745) PackagedProgram' extractedTempLibraries and jarfiles may be duplicate

2020-05-19 Thread lisen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1743#comment-1743 ] lisen commented on FLINK-17745: --- [~kkl0u] Yes, we have cases like this. Our platform will package

[GitHub] [flink] flinkbot commented on pull request #12248: [FLINK-17725][tests] Disable OkHttpClient timeouts for FileUploadHandlerTest

2020-05-19 Thread GitBox
flinkbot commented on pull request #12248: URL: https://github.com/apache/flink/pull/12248#issuecomment-630795516 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #12247: [hotfix] Disable e2e execution in PRs

2020-05-19 Thread GitBox
flinkbot commented on pull request #12247: URL: https://github.com/apache/flink/pull/12247#issuecomment-630795530 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] rkhachatryan commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
rkhachatryan commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427275123 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncCheckpointRunnables.java ## @@ -0,0 +1,85 @@ +/* + *

[jira] [Updated] (FLINK-17725) FileUploadHandlerTest.testUploadCleanupOnFailure fails with "SocketTimeout timeout"

2020-05-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-17725: --- Labels: pull-request-available test-stability (was: test-stability) >

[GitHub] [flink] tillrohrmann opened a new pull request #12248: [FLINK-17725][tests] Disable OkHttpClient timeouts for FileUploadHandlerTest

2020-05-19 Thread GitBox
tillrohrmann opened a new pull request #12248: URL: https://github.com/apache/flink/pull/12248 ## What is the purpose of the change In order to harden the test case FileUploadHandlerTest, this commit disables the timeouts of the used OkHttpClient. cc @rmetzger ##

[GitHub] [flink] flinkbot commented on pull request #12246: [FLINK-17303][python] Return TableResult for Python TableEnvironment

2020-05-19 Thread GitBox
flinkbot commented on pull request #12246: URL: https://github.com/apache/flink/pull/12246#issuecomment-630794628 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] rmetzger opened a new pull request #12247: [hotfix] Disable e2e execution in PRs

2020-05-19 Thread GitBox
rmetzger opened a new pull request #12247: URL: https://github.com/apache/flink/pull/12247 ## What is the purpose of the change Because azure is overloaded, disable e2e test execution for PRs. ## Brief change log - skip e2e execution if the branch name starts with

[GitHub] [flink] leonardBang commented on pull request #12117: [FLINK-17619] Disable commit on checkpoints if no group.id was specif…

2020-05-19 Thread GitBox
leonardBang commented on pull request #12117: URL: https://github.com/apache/flink/pull/12117#issuecomment-630793275 But I'm fine if you want merge it to release-1.11 if there's no conflicts. This is an automated message

[GitHub] [flink] wanglijie95 commented on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.

2020-05-19 Thread GitBox
wanglijie95 commented on pull request #12181: URL: https://github.com/apache/flink/pull/12181#issuecomment-630793220 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] SteNicholas opened a new pull request #12246: [FLINK-17303][python] Return TableResult for Python TableEnvironment

2020-05-19 Thread GitBox
SteNicholas opened a new pull request #12246: URL: https://github.com/apache/flink/pull/12246 ## What is the purpose of the change *This pull request will introduce python `TableResult` class for python tableEnvironment to make sure consistent with Java, which could get `JobClient`

[GitHub] [flink] dawidwys commented on a change in pull request #12228: [FLINK-17541][table] Support inline structured types

2020-05-19 Thread GitBox
dawidwys commented on a change in pull request #12228: URL: https://github.com/apache/flink/pull/12228#discussion_r427268991 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/EqualiserCodeGenerator.scala ## @@ -57,9

[GitHub] [flink] leonardBang commented on pull request #12117: [FLINK-17619] Disable commit on checkpoints if no group.id was specif…

2020-05-19 Thread GitBox
leonardBang commented on pull request #12117: URL: https://github.com/apache/flink/pull/12117#issuecomment-630790056 > Should I merge this for both master and release-1.11? I know your means, but we'd better to open a new PR to avoid conflicts (also this time should not happen),

[GitHub] [flink] dawidwys commented on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala

2020-05-19 Thread GitBox
dawidwys commented on pull request #12232: URL: https://github.com/apache/flink/pull/12232#issuecomment-630789708 To give the discussion some time limit, if there are no objections (meaning people clearly against it) till tomorrow 10 am CEST I will introduce that change (if the release

[GitHub] [flink] dawidwys commented on pull request #12232: [FLINK-15947] Finish moving scala expression DSL to flink-table-api-scala

2020-05-19 Thread GitBox
dawidwys commented on pull request #12232: URL: https://github.com/apache/flink/pull/12232#issuecomment-630787753 @wuchong My take is that it is inevitable at some point. With the current structure there are three issues: 1. users of the unified `TableEnvironment` have to depend on a

[GitHub] [flink] rkhachatryan commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
rkhachatryan commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427248514 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncCheckpointRunnables.java ## @@ -0,0 +1,85 @@ +/* + *

[GitHub] [flink] rkhachatryan commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
rkhachatryan commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427263066 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -142,6 +187,13

[jira] [Updated] (FLINK-17619) Only set offset commit if group id is configured for Kafka Table source

2020-05-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-17619: --- Labels: pull-request-available (was: ) > Only set offset commit if group id is configured

[GitHub] [flink] flinkbot commented on pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

2020-05-19 Thread GitBox
flinkbot commented on pull request #12245: URL: https://github.com/apache/flink/pull/12245#issuecomment-630784890 ## CI report: * e695add3318a20fda1d2d1336ab6ebf68b90a35a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #12230: [FLINK-17504][docs] Update Chinese translation of Getting Started / O…

2020-05-19 Thread GitBox
flinkbot edited a comment on pull request #12230: URL: https://github.com/apache/flink/pull/12230#issuecomment-630205457 ## CI report: * de4251b2c2ee31ababe1c82505c15822546a59b1 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12228: [FLINK-17541][table] Support inline structured types

2020-05-19 Thread GitBox
flinkbot edited a comment on pull request #12228: URL: https://github.com/apache/flink/pull/12228#issuecomment-630171014 ## CI report: * 5c672d3d2f0654b3c5d1a18b20d73804e450382a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12199: [FLINK-17774] [table] supports all kinds of changes for select result

2020-05-19 Thread GitBox
flinkbot edited a comment on pull request #12199: URL: https://github.com/apache/flink/pull/12199#issuecomment-629793563 ## CI report: * 43ce2a929ab65202b2f09d0e4c867b6bfdd97cf1 Azure:

[GitHub] [flink] gyfora commented on pull request #12117: [FLINK-17619] Disable commit on checkpoints if no group.id was specif…

2020-05-19 Thread GitBox
gyfora commented on pull request #12117: URL: https://github.com/apache/flink/pull/12117#issuecomment-630784554 Should I merge this for both master and release-1.11? This is an automated message from the Apache Git Service.

<    1   2   3   4   5   6   7   >