[GitHub] [flink] flinkbot edited a comment on pull request #16989: [FLINK-23611][yarn-tests] Refactors yarn tests and enable hadoop logs

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #16989: URL: https://github.com/apache/flink/pull/16989#issuecomment-905813692 ## CI report: * e31501c3a9118aedfe5e98e4d08e04129ea17940 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16988: [FLINK-23458][docs] Added the network buffer documentation along wit…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #16988: URL: https://github.com/apache/flink/pull/16988#issuecomment-905730008 ## CI report: * 680f8172bea8a9b7396604e8f0c5dcaf4efff5f9 Azure:

[jira] [Commented] (FLINK-13414) Add support for Scala 2.13

2021-08-31 Thread Eric S Meisel (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407507#comment-17407507 ] Eric S Meisel commented on FLINK-13414: --- Seems that the urgency on this one is about to get pretty

[jira] [Commented] (FLINK-23747) Testing Window TVF offset

2021-08-31 Thread liwei li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407505#comment-17407505 ] liwei li commented on FLINK-23747: -- I checked the test code submission records related to Window TVF

[jira] [Commented] (FLINK-24087) Kafka connector StartupMode requires a table dependency

2021-08-31 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-24087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407499#comment-17407499 ] Ingo Bürk commented on FLINK-24087: --- Sorry, I didn't see your comment when I assigned myself. Thanks

[jira] [Assigned] (FLINK-24087) Kafka connector StartupMode requires a table dependency

2021-08-31 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-24087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Bürk reassigned FLINK-24087: - Assignee: Leonard Xu (was: Ingo Bürk) > Kafka connector StartupMode requires a table

[GitHub] [flink] tillrohrmann commented on a change in pull request #17000: [FLINK-23946][clients] Application mode should shutdown gracefully on…

2021-08-31 Thread GitBox
tillrohrmann commented on a change in pull request #17000: URL: https://github.com/apache/flink/pull/17000#discussion_r699438111 ## File path: flink-clients/src/test/java/org/apache/flink/client/deployment/application/ApplicationDispatcherBootstrapITCase.java ## @@ -0,0

[GitHub] [flink] flinkbot commented on pull request #17083: [FLINK-24081][table-planner] Fix StreamExecOverAggregate and StreamExecTemporalSort operator didn't support LocalZonedTimestampType

2021-08-31 Thread GitBox
flinkbot commented on pull request #17083: URL: https://github.com/apache/flink/pull/17083#issuecomment-909372901 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Commented] (FLINK-24051) Make consumer.group-id optional for KafkaSource

2021-08-31 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407497#comment-17407497 ] Arvid Heise commented on FLINK-24051: - Merged into 1.14 as ec378a57d638de9bb08de25d40192c49f94cfc0c.

[GitHub] [flink] AHeise commented on pull request #17071: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
AHeise commented on pull request #17071: URL: https://github.com/apache/flink/pull/17071#issuecomment-909371042 `docs_404_check` failure unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] AHeise merged pull request #17071: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
AHeise merged pull request #17071: URL: https://github.com/apache/flink/pull/17071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] leonardBang opened a new pull request #17083: [FLINK-24081][table-planner] Fix StreamExecOverAggregate and StreamExecTemporalSort operator didn't support LocalZonedTimestampType

2021-08-31 Thread GitBox
leonardBang opened a new pull request #17083: URL: https://github.com/apache/flink/pull/17083 ## What is the purpose of the change * Fix `StreamExecOverAggregate` and `StreamExecTemporalSort` operators didn't support LocalZonedTimestampType ## Brief change log - Use

[GitHub] [flink] akalash commented on a change in pull request #16988: [FLINK-23458][docs] Added the network buffer documentation along wit…

2021-08-31 Thread GitBox
akalash commented on a change in pull request #16988: URL: https://github.com/apache/flink/pull/16988#discussion_r699458165 ## File path: docs/content/docs/deployment/network_buffer.md ## @@ -0,0 +1,125 @@ +--- +title: "Network Tuning" +weight: 100 +type: docs +aliases: + -

[GitHub] [flink] flinkbot commented on pull request #17082: [FLINK-24087][connectors/kafka] Avoid importing table API class in DataStream API package

2021-08-31 Thread GitBox
flinkbot commented on pull request #17082: URL: https://github.com/apache/flink/pull/17082#issuecomment-909359163 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #17081: [FLINK-23797][tests] Wait for all task running before savepoint for a…

2021-08-31 Thread GitBox
flinkbot commented on pull request #17081: URL: https://github.com/apache/flink/pull/17081#issuecomment-909358934 ## CI report: * 7fa67fca4bb48ef5095f66c1d2cc831c12a4946e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17079: [FLINK-24054][table-runtime] Let SinkUpsertMaterializer produce +U's when possible

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17079: URL: https://github.com/apache/flink/pull/17079#issuecomment-909337010 ## CI report: * a413c4c1bd4ae9251c5f5f8085afb66d7ffe2da2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17080: [FLINK-23664][docs] Add docs for KafkaSink [1.14]

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17080: URL: https://github.com/apache/flink/pull/17080#issuecomment-909337168 ## CI report: * 69c40e4d0033af49b04e1f469a6d59461c23172a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17056: [FLINK-23748][tests] Testing window TVF session window

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17056: URL: https://github.com/apache/flink/pull/17056#issuecomment-908449260 ## CI report: * e23989b2d576ae4b4bbb560b38b0028d71331756 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17019: URL: https://github.com/apache/flink/pull/17019#issuecomment-907120059 ## CI report: * fa25b27d642ab7e6af356ca1e9738a006d48 UNKNOWN * ea83c14a8c3f8f974703a12e4d3248026abf3ded Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16989: [FLINK-23611][yarn-tests] Refactors yarn tests and enable hadoop logs

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #16989: URL: https://github.com/apache/flink/pull/16989#issuecomment-905813692 ## CI report: * e31501c3a9118aedfe5e98e4d08e04129ea17940 Azure:

[jira] [Updated] (FLINK-24087) Kafka connector StartupMode requires a table dependency

2021-08-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24087: --- Labels: pull-request-available (was: ) > Kafka connector StartupMode requires a table

[GitHub] [flink] leonardBang opened a new pull request #17082: [FLINK-24087][connectors/kafka] Avoid importing table API class in DataStream API package

2021-08-31 Thread GitBox
leonardBang opened a new pull request #17082: URL: https://github.com/apache/flink/pull/17082 ## What is the purpose of the change * This pull request remove table API class from DataStream API package in Kafka connector ## Brief change log - Remove usage of table

[GitHub] [flink] leonardBang commented on pull request #17074: [FLINK-24081][table-planner] Fix StreamExecOverAggregate and StreamExecTemporalSort operator didn't support LocalZonedTimestampType

2021-08-31 Thread GitBox
leonardBang commented on pull request #17074: URL: https://github.com/apache/flink/pull/17074#issuecomment-909354143 > @leonardBang could you also open pull request for release-1.14 and release-1.13 branches? sure -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] RocMarshal commented on pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-08-31 Thread GitBox
RocMarshal commented on pull request #16723: URL: https://github.com/apache/flink/pull/16723#issuecomment-909339035 @wuchong Sorry. I'll abide by the rule. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] flinkbot commented on pull request #17080: [FLINK-23664][docs] Add docs for KafkaSink

2021-08-31 Thread GitBox
flinkbot commented on pull request #17080: URL: https://github.com/apache/flink/pull/17080#issuecomment-909304955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17022: [FLINK-24020][web] Aggregate HTTP requests before custom netty handers are getting the data

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17022: URL: https://github.com/apache/flink/pull/17022#issuecomment-907158087 ## CI report: * f35088a7f5a8d7a95d8c4ad2b6d0501ffbd84404 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17070: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17070: URL: https://github.com/apache/flink/pull/17070#issuecomment-909190301 ## CI report: * 3700dfa72cd72d384bf6d69376321fb7ef9eaab9 UNKNOWN * 4aac2774925e49df9f75903734eb4a98f7f9f3bc Azure:

[GitHub] [flink] wuchong commented on pull request #17074: [FLINK-24081][table-planner] Fix StreamExecOverAggregate and StreamExecTemporalSort operator didn't support LocalZonedTimestampType

2021-08-31 Thread GitBox
wuchong commented on pull request #17074: URL: https://github.com/apache/flink/pull/17074#issuecomment-909333164 @leonardBang could you also open pull request for release-1.13 and release-1.12 branches? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] tillrohrmann commented on a change in pull request #17059: [FLINK-24005][coordination] Only return fulfilled requirements for reserved slots

2021-08-31 Thread GitBox
tillrohrmann commented on a change in pull request #17059: URL: https://github.com/apache/flink/pull/17059#discussion_r699387325 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultAllocatedSlotPool.java ## @@ -234,4 +241,30 @@ private

[GitHub] [flink] tillrohrmann commented on a change in pull request #17053: [FLINK-24021][HA]Handle curator framework start error by register UnhandledErrorListener before start zk client

2021-08-31 Thread GitBox
tillrohrmann commented on a change in pull request #17053: URL: https://github.com/apache/flink/pull/17053#discussion_r699412949 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/util/ZooKeeperUtilsTest.java ## @@ -44,4 +58,27 @@ private void

[GitHub] [flink] flinkbot edited a comment on pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17019: URL: https://github.com/apache/flink/pull/17019#issuecomment-907120059 ## CI report: * fa25b27d642ab7e6af356ca1e9738a006d48 UNKNOWN * 60655804ce59530d485c1ae939f9b005b1ef5ede Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17024: [FLINK-23457][network] The upstream sends the buffer of the right size for broadcast case

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17024: URL: https://github.com/apache/flink/pull/17024#issuecomment-907189537 ## CI report: * a55891c9402712a818155f1ea798464754243b5a Azure:

[GitHub] [flink] akalash opened a new pull request #17081: [FLINK-23797][tests] Wait for all task running before savepoint for a…

2021-08-31 Thread GitBox
akalash opened a new pull request #17081: URL: https://github.com/apache/flink/pull/17081 …ll tests in SavepointITCase ## What is the purpose of the change *This PR fixes SavepointITCase* ## Brief change log - *Added waitting for all task running

[GitHub] [flink] flinkbot edited a comment on pull request #17077: [FLINK-24085][docs] Add first class subject for page `versioned table` and `Timezone`

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17077: URL: https://github.com/apache/flink/pull/17077#issuecomment-909283338 ## CI report: * 87fe6f2b508bb6923b16345e95204bade06af980 Azure:

[GitHub] [flink] flinkbot commented on pull request #17081: [FLINK-23797][tests] Wait for all task running before savepoint for a…

2021-08-31 Thread GitBox
flinkbot commented on pull request #17081: URL: https://github.com/apache/flink/pull/17081#issuecomment-909337904 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] wuchong commented on pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-08-31 Thread GitBox
wuchong commented on pull request #16723: URL: https://github.com/apache/flink/pull/16723#issuecomment-909334534 Thanks for the updating @RocMarshal , however, please do not squash commits when you addressing review comments. Otherwise, reviewer can't find what is changed since last time

[GitHub] [flink] twalthr commented on a change in pull request #16805: [FLINK-16501][table] Support IS JSON for Table API

2021-08-31 Thread GitBox
twalthr commented on a change in pull request #16805: URL: https://github.com/apache/flink/pull/16805#discussion_r699410061 ## File path: docs/data/sql_functions.yml ## @@ -83,7 +83,7 @@ logical: table: BOOLEAN1 && BOOLEAN2 description: Returns TRUE if BOOLEAN1 and

[GitHub] [flink] flinkbot commented on pull request #17079: [FLINK-24054][table-runtime] Let SinkUpsertMaterializer produce +U's when possible

2021-08-31 Thread GitBox
flinkbot commented on pull request #17079: URL: https://github.com/apache/flink/pull/17079#issuecomment-909337010 ## CI report: * a413c4c1bd4ae9251c5f5f8085afb66d7ffe2da2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17011: [FLINK-23663][table-planner] Reduce state size of ChangelogNormalize

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17011: URL: https://github.com/apache/flink/pull/17011#issuecomment-907015222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] mas-chen commented on a change in pull request #17007: [FLINK-17495][metrics] Add additional variables config for metric reporters

2021-08-31 Thread GitBox
mas-chen commented on a change in pull request #17007: URL: https://github.com/apache/flink/pull/17007#discussion_r699029340 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/FrontMetricGroup.java ## @@ -72,8 +74,15 @@ public MetricGroup

[GitHub] [flink] XComp commented on pull request #16989: [FLINK-23611][yarn-tests] Refactors yarn tests and enable hadoop logs

2021-08-31 Thread GitBox
XComp commented on pull request #16989: URL: https://github.com/apache/flink/pull/16989#issuecomment-909320524 I rebased the branch and added another commit that should fix the `YARNSessionCapacitySchedulerITCase.testDetachedPerJobYarnCluster` flakiness we're experiencing locally. See

[jira] [Updated] (FLINK-23797) SavepointITCase.testStopSavepointWithBoundedInput fails on azure

2021-08-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-23797: --- Labels: pull-request-available test-stability (was: test-stability) >

[GitHub] [flink] flinkbot edited a comment on pull request #17078: [FLINK-23468][test] Do not hide original exception if SSL is not available

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17078: URL: https://github.com/apache/flink/pull/17078#issuecomment-909306199 ## CI report: * 2871b6333b15ffcf00a3a480b8408155668aba0a Azure:

[GitHub] [flink] wuchong edited a comment on pull request #17074: [FLINK-24081][table-planner] Fix StreamExecOverAggregate and StreamExecTemporalSort operator didn't support LocalZonedTimestampType

2021-08-31 Thread GitBox
wuchong edited a comment on pull request #17074: URL: https://github.com/apache/flink/pull/17074#issuecomment-909333164 @leonardBang could you also open pull request for release-1.14 and release-1.13 branches? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-31 Thread GitBox
AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698508026 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/sink/GlobalBatchCommitterHandlerTest.java ## @@ -44,16

[GitHub] [flink-web] xintongsong commented on a change in pull request #464: announcing the rc0 for 1.14. and asking for help

2021-08-31 Thread GitBox
xintongsong commented on a change in pull request #464: URL: https://github.com/apache/flink-web/pull/464#discussion_r699006432 ## File path: _posts/2021-08-31-release-1.14.0-rc0.md ## @@ -0,0 +1,44 @@ +--- +layout: post +title: "Help us harden Apache Flink 1.14.0 RC0" +date:

[GitHub] [flink] Aitozi commented on a change in pull request #17053: [FLINK-24021][HA]Handle curator framework start error by register UnhandledErrorListener before start zk client

2021-08-31 Thread GitBox
Aitozi commented on a change in pull request #17053: URL: https://github.com/apache/flink/pull/17053#discussion_r699104914 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java ## @@ -226,9 +230,21 @@ public static CuratorFramework

[GitHub] [flink] dianfu closed pull request #17046: [FLINK-24049][python] Handle properly for field types need conversion in TupleTypeInfo

2021-08-31 Thread GitBox
dianfu closed pull request #17046: URL: https://github.com/apache/flink/pull/17046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] AHeise merged pull request #16966: [FLINK-23875][connectors/kafka] Snapshot reduceBuffer of ReducingUpse…

2021-08-31 Thread GitBox
AHeise merged pull request #16966: URL: https://github.com/apache/flink/pull/16966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #17058: [FLINK-23664][docs] Add docs for KafkaSink

2021-08-31 Thread GitBox
flinkbot commented on pull request #17058: URL: https://github.com/apache/flink/pull/17058#issuecomment-908433590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17059: [FLINK-24005][coordination] Only return fulfilled requirements for reserved slots

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17059: URL: https://github.com/apache/flink/pull/17059#issuecomment-908449643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] fapaul commented on a change in pull request #17067: [FLINK-23817][docs] Add metric description to Kafka source and File sink.

2021-08-31 Thread GitBox
fapaul commented on a change in pull request #17067: URL: https://github.com/apache/flink/pull/17067#discussion_r699130795 ## File path: docs/content/docs/connectors/datastream/streamfile_sink.md ## @@ -29,6 +29,10 @@ under the License. This connector provides a Sink that

[GitHub] [flink-training] alpinegizmo merged pull request #31: [FLINK-23653] exercise and test rework

2021-08-31 Thread GitBox
alpinegizmo merged pull request #31: URL: https://github.com/apache/flink-training/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17048: [FLINK-24033][table-planner] Propagate unique keys for fromChangelogStream

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17048: URL: https://github.com/apache/flink/pull/17048#issuecomment-908188488 ## CI report: * 44a4c5b89d03c403df73fae28d464a557444323a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16988: [FLINK-23458][docs] Added the network buffer documentation along wit…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #16988: URL: https://github.com/apache/flink/pull/16988#issuecomment-905730008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (FLINK-24021) Potential job unrecoverable due to Network failure

2021-08-31 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407454#comment-17407454 ] Till Rohrmann commented on FLINK-24021: --- Thanks for reporting this problem [~aitozi]. I think you

[GitHub] [flink] AHeise commented on a change in pull request #17050: [FLINK-23351][tests] Harden FileReadingWatermarkITCase by counting wa…

2021-08-31 Thread GitBox
AHeise commented on a change in pull request #17050: URL: https://github.com/apache/flink/pull/17050#discussion_r699178562 ## File path: flink-tests/src/test/java/org/apache/flink/test/streaming/api/FileReadingWatermarkITCase.java ## @@ -17,130 +17,109 @@ package

[GitHub] [flink] fapaul commented on a change in pull request #17050: [FLINK-23351][tests] Harden FileReadingWatermarkITCase by counting wa…

2021-08-31 Thread GitBox
fapaul commented on a change in pull request #17050: URL: https://github.com/apache/flink/pull/17050#discussion_r699229651 ## File path: flink-tests/src/test/java/org/apache/flink/test/streaming/api/FileReadingWatermarkITCase.java ## @@ -17,130 +17,109 @@ package

[GitHub] [flink] flinkbot edited a comment on pull request #17050: [FLINK-23351][tests] Harden FileReadingWatermarkITCase by counting wa…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17050: URL: https://github.com/apache/flink/pull/17050#issuecomment-908295316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17007: [FLINK-17495][metrics] Add additional variables config for metric reporters

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17007: URL: https://github.com/apache/flink/pull/17007#issuecomment-906871869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (FLINK-24021) Potential job unrecoverable due to Network failure

2021-08-31 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-24021: -- Affects Version/s: 1.14.0 1.12.5 1.13.2 >

[GitHub] [flink] tweise merged pull request #17041: [release-1.13][FLINK-24010][connector/common] HybridSourceReader/Enumerator delegate checkpoint notifications

2021-08-31 Thread GitBox
tweise merged pull request #17041: URL: https://github.com/apache/flink/pull/17041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-web] xintongsong commented on a change in pull request #465: announcing the 1.14.0 release candidate

2021-08-31 Thread GitBox
xintongsong commented on a change in pull request #465: URL: https://github.com/apache/flink-web/pull/465#discussion_r699131230 ## File path: _posts/2021-08-31-release-1.14.0-rc0.md ## @@ -0,0 +1,39 @@ +--- +layout: post +title: "Help us stabilize Apache Flink 1.14.0 RC0"

[GitHub] [flink] flinkbot edited a comment on pull request #16773: [FLINK-21090][tests] Add IT case for stop-with-savepoint and final checkpoint

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #16773: URL: https://github.com/apache/flink/pull/16773#issuecomment-896196766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17057: [FLINK-24056][HA]Remove unused ZooKeeperUtilityFactory.java

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17057: URL: https://github.com/apache/flink/pull/17057#issuecomment-908449380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] lometheus commented on a change in pull request #17024: [FLINK-23457][network] The upstream sends the buffer of the right size for broadcast case

2021-08-31 Thread GitBox
lometheus commented on a change in pull request #17024: URL: https://github.com/apache/flink/pull/17024#discussion_r699305515 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BufferWritingResultPartition.java ## @@ -330,9 +330,12 @@

[GitHub] [flink] fapaul commented on pull request #17050: [FLINK-23351][tests] Harden FileReadingWatermarkITCase by counting wa…

2021-08-31 Thread GitBox
fapaul commented on pull request #17050: URL: https://github.com/apache/flink/pull/17050#issuecomment-908556738 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] zentol commented on pull request #17022: [FLINK-24020][web] Aggregate HTTP requests before custom netty handers are getting the data

2021-08-31 Thread GitBox
zentol commented on pull request #17022: URL: https://github.com/apache/flink/pull/17022#issuecomment-909098111 You need to rebase the branch to fix the libssl issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] flinkbot commented on pull request #17070: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
flinkbot commented on pull request #17070: URL: https://github.com/apache/flink/pull/17070#issuecomment-909159673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] lirui-apache closed pull request #16778: [FLINK-23715][parquet] Support for reading fields that do not exist in Parquet files

2021-08-31 Thread GitBox
lirui-apache closed pull request #16778: URL: https://github.com/apache/flink/pull/16778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #17066: FLINK-24066

2021-08-31 Thread GitBox
flinkbot commented on pull request #17066: URL: https://github.com/apache/flink/pull/17066#issuecomment-908955355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] gaborgsomogyi commented on pull request #17022: [FLINK-24020][web] Aggregate HTTP requests before custom netty handers are getting the data

2021-08-31 Thread GitBox
gaborgsomogyi commented on pull request #17022: URL: https://github.com/apache/flink/pull/17022#issuecomment-908934469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] fapaul closed pull request #17072: [FLINK-23875][connectors/kafka] Snapshot reduceBuffer of ReducingUpsertWriter

2021-08-31 Thread GitBox
fapaul closed pull request #17072: URL: https://github.com/apache/flink/pull/17072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #17069: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
flinkbot commented on pull request #17069: URL: https://github.com/apache/flink/pull/17069#issuecomment-909153802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-training] alpinegizmo commented on pull request #31: [FLINK-23653] exercise and test rework

2021-08-31 Thread GitBox
alpinegizmo commented on pull request #31: URL: https://github.com/apache/flink-training/pull/31#issuecomment-909228839 @NicoK The two open points you raised are outdated. Those tests are gone and were replaced by a combination of a revised integration test with more rides and fares, and

[jira] [Updated] (FLINK-24021) Potential job unrecoverable due to Network failure

2021-08-31 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-24021: -- Fix Version/s: 1.13.3 1.12.6 1.14.0 > Potential job

[jira] [Assigned] (FLINK-24021) Potential job unrecoverable due to Network failure

2021-08-31 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-24021: - Assignee: Aitozi > Potential job unrecoverable due to Network failure >

[GitHub] [flink] flinkbot commented on pull request #17062: [FLINK-21090][tests] Add IT case for stop-with-savepoint and final checkpoint (1.14)

2021-08-31 Thread GitBox
flinkbot commented on pull request #17062: URL: https://github.com/apache/flink/pull/17062#issuecomment-908854589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] zentol commented on pull request #17043: [FLINK-23976] [Runtime / Metrics] Add additional availability timing metrics to Job lifecycle events

2021-08-31 Thread GitBox
zentol commented on pull request #17043: URL: https://github.com/apache/flink/pull/17043#issuecomment-908495158 I appreciate you looking into this, but at the moment I'd prefer to delay the implementation of this ticket. There are some issues with the existing availability metrics

[GitHub] [flink] ruanhang1993 commented on pull request #17049: [FLINK-23971][tests] fix connector testing framework error when compare records in different splits

2021-08-31 Thread GitBox
ruanhang1993 commented on pull request #17049: URL: https://github.com/apache/flink/pull/17049#issuecomment-908939038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17052: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
flinkbot commented on pull request #17052: URL: https://github.com/apache/flink/pull/17052#issuecomment-908310855 ## CI report: * 902dc5f07c38c0592dc31e78b2dcdc61fc143290 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #17076: [FLINK-24084][docs] Correct the examples in SQL JOIN docs

2021-08-31 Thread GitBox
flinkbot commented on pull request #17076: URL: https://github.com/apache/flink/pull/17076#issuecomment-909232576 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot edited a comment on pull request #17071: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17071: URL: https://github.com/apache/flink/pull/17071#issuecomment-909190390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17049: [FLINK-23971][tests] fix connector testing framework error when compare records in different splits

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17049: URL: https://github.com/apache/flink/pull/17049#issuecomment-908270735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] RocMarshal commented on pull request #16852: [FLINK-13636][docs-zh]Translate the "Flink DataStream API Programming Guide" page into Chinese

2021-08-31 Thread GitBox
RocMarshal commented on pull request #16852: URL: https://github.com/apache/flink/pull/16852#issuecomment-908878974 @hapihu LGTM now. Hi, @wuchong , Would you please check it next ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] flinkbot commented on pull request #17072: [FLINK-23875][connectors/kafka] Snapshot reduceBuffer of ReducingUpsertWriter

2021-08-31 Thread GitBox
flinkbot commented on pull request #17072: URL: https://github.com/apache/flink/pull/17072#issuecomment-909162735 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] shenzhu commented on pull request #17043: [FLINK-23976] [Runtime / Metrics] Add additional availability timing metrics to Job lifecycle events

2021-08-31 Thread GitBox
shenzhu commented on pull request #17043: URL: https://github.com/apache/flink/pull/17043#issuecomment-908534573 > I appreciate you looking into this, but at the moment I'd prefer to delay the implementation of this ticket. > > There are some issues with the existing availability

[GitHub] [flink-web] tzulitai commented on a change in pull request #463: Statefun release 3.1

2021-08-31 Thread GitBox
tzulitai commented on a change in pull request #463: URL: https://github.com/apache/flink-web/pull/463#discussion_r698939045 ## File path: _posts/2021-08-30-release-statefun-3.1.0.md ## @@ -0,0 +1,228 @@ +--- +layout: post +title: "Stateful Functions 3.1.0 Release

[GitHub] [flink] flinkbot edited a comment on pull request #16852: [FLINK-13636][docs-zh]Translate the "Flink DataStream API Programming Guide" page into Chinese

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #16852: URL: https://github.com/apache/flink/pull/16852#issuecomment-900037795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17073: [FLINK-24058][coordination][tests] Harden TaskSlotTableImplTest#runDeactivateSlotTimeoutTest

2021-08-31 Thread GitBox
flinkbot commented on pull request #17073: URL: https://github.com/apache/flink/pull/17073#issuecomment-909164286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17054: [FLINK-24055][connectors/kafka] Deprecate FlinkKafkaConsumer

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17054: URL: https://github.com/apache/flink/pull/17054#issuecomment-908428073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17057: [FLINK-24056][HA]Remove unused ZooKeeperUtilityFactory.java

2021-08-31 Thread GitBox
flinkbot commented on pull request #17057: URL: https://github.com/apache/flink/pull/17057#issuecomment-908431682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17075: [FLINK-24035][network][refactor] Move the blocking allocation of one floating buffer logic from the constructor of LocalBufferPool to Single

2021-08-31 Thread GitBox
flinkbot commented on pull request #17075: URL: https://github.com/apache/flink/pull/17075#issuecomment-909203226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (FLINK-23850) Test Kafka table connector with new runtime provider

2021-08-31 Thread Matthias (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407438#comment-17407438 ] Matthias commented on FLINK-23850: -- I created

[GitHub] [flink] tweise commented on pull request #17041: [release-1.13][FLINK-24010][connector/common] HybridSourceReader/Enumerator delegate checkpoint notifications

2021-08-31 Thread GitBox
tweise commented on pull request #17041: URL: https://github.com/apache/flink/pull/17041#issuecomment-908397598 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] curcur commented on a change in pull request #16606: [FLINK-21357][runtime/statebackend]Periodic materialization for generalized incremental checkpoints

2021-08-31 Thread GitBox
curcur commented on a change in pull request #16606: URL: https://github.com/apache/flink/pull/16606#discussion_r699097517 ## File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializer.java ## @@ -0,0

[GitHub] [flink] Myasuka edited a comment on pull request #17025: [FLINK-24029][docs] Update doc example sql field in release-1.13.2 to dept_id

2021-08-31 Thread GitBox
Myasuka edited a comment on pull request #17025: URL: https://github.com/apache/flink/pull/17025#issuecomment-908850566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17037: [FLINK-24035][network] Guarantee that the LocalBufferPool is initialized with one buffer

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17037: URL: https://github.com/apache/flink/pull/17037#issuecomment-907731112 ## CI report: * a1fc01a4a4c3373f4f931c688aa587fb0d3dfc01 Azure:

[GitHub] [flink-training] NicoK commented on a change in pull request #31: [FLINK-23653] exercise and test rework

2021-08-31 Thread GitBox
NicoK commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r699187127 ## File path: hourly-tips/src/main/java/org/apache/flink/training/exercises/hourlytips/HourlyTipsExercise.java ## @@ -56,8 +55,8 @@ public

[GitHub] [flink] AHeise merged pull request #17054: [FLINK-24055][connectors/kafka] Deprecate FlinkKafkaConsumer

2021-08-31 Thread GitBox
AHeise merged pull request #17054: URL: https://github.com/apache/flink/pull/17054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

<    1   2   3   4   5   6   7   8   >