[GitHub] [flink] flinkbot commented on pull request #17701: [FLINK-24294][streaming] Register all stream task resources to one cl…

2021-11-05 Thread GitBox
flinkbot commented on pull request #17701: URL: https://github.com/apache/flink/pull/17701#issuecomment-962009686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] curcur commented on pull request #17621: [FLINK-24551][runtime] Read BUFFER_DEBLOAT_SAMPLES from task manager …

2021-11-05 Thread GitBox
curcur commented on pull request #17621: URL: https://github.com/apache/flink/pull/17621#issuecomment-961636235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] JingsongLi merged pull request #17605: [FLINK-24704][table] Fix exception when the input record loses monotonicity on the sort key field of UpdatableTopNFunction

2021-11-05 Thread GitBox
JingsongLi merged pull request #17605: URL: https://github.com/apache/flink/pull/17605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] Zakelly commented on a change in pull request #17650: [FLINK-24475] Remove no longer used NestedMap* classes

2021-11-05 Thread GitBox
Zakelly commented on a change in pull request #17650: URL: https://github.com/apache/flink/pull/17650#discussion_r743359346 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java ## @@ -4376,7 +4373,7 @@ protected void

[GitHub] [flink] AHeise merged pull request #17625: [FLINK-24719][jdbc] Update Postgres test dependencies to 0.13.4

2021-11-05 Thread GitBox
AHeise merged pull request #17625: URL: https://github.com/apache/flink/pull/17625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] twalthr commented on a change in pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-05 Thread GitBox
twalthr commented on a change in pull request #17658: URL: https://github.com/apache/flink/pull/17658#discussion_r743516392 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/casting/CastRulesTest.java ## @@ -60,39 +112,142 @@

[GitHub] [flink] JingGe commented on a change in pull request #17574: [FLINK-24665][s3] Update Presto Hadoop dependency to v2.7.4-9

2021-11-05 Thread GitBox
JingGe commented on a change in pull request #17574: URL: https://github.com/apache/flink/pull/17574#discussion_r743208772 ## File path: flink-filesystems/flink-s3-fs-presto/src/main/resources/META-INF/NOTICE ## @@ -21,7 +21,7 @@ This project bundles the following

[GitHub] [flink] flinkbot edited a comment on pull request #17694: [FLINK-24414][table-planner] Remove example test for left padding of decimals

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17694: URL: https://github.com/apache/flink/pull/17694#issuecomment-961828996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] AHeise commented on pull request #17640: [FLINK-21407][doc][formats] Add formats to DataStream connectors doc

2021-11-05 Thread GitBox
AHeise commented on pull request #17640: URL: https://github.com/apache/flink/pull/17640#issuecomment-961928372 > @AHeise @MartijnVisser 2 general questions: > > 1. the current PR is a port of [this PR](https://github.com/apache/flink/pull/17523/files) for 1.13 that was asked

[GitHub] [flink] ruanhang1993 commented on pull request #17601: [FLINK-24697][flink-connectors-kafka] add auto.offset.reset configuration for group-offsets startup mode

2021-11-05 Thread GitBox
ruanhang1993 commented on pull request #17601: URL: https://github.com/apache/flink/pull/17601#issuecomment-961592246 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot commented on pull request #17689: [FLINK-24704][table] Fix exception when the input record loses monotonicity on the sort key field of UpdatableTopNFunction

2021-11-05 Thread GitBox
flinkbot commented on pull request #17689: URL: https://github.com/apache/flink/pull/17689#issuecomment-961619732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17648: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17648: URL: https://github.com/apache/flink/pull/17648#issuecomment-957889509 ## CI report: * 3a428e7ab40488c56415b3e2ff3d5364d287df9d Azure:

[GitHub] [flink] CrynetLogistics edited a comment on pull request #17687: [FLINK-24227][connectors] Improved AsyncSink base by adding a builder…

2021-11-05 Thread GitBox
CrynetLogistics edited a comment on pull request #17687: URL: https://github.com/apache/flink/pull/17687#issuecomment-961203075 This PR is a subset of changes for #17345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink-benchmarks] dawidwys merged pull request #39: [FLINK-24659] Drop RemoteBenchmarkBase.miniCluster field

2021-11-05 Thread GitBox
dawidwys merged pull request #39: URL: https://github.com/apache/flink-benchmarks/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of

2021-11-05 Thread GitBox
flinkbot commented on pull request #17692: URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] eskabetxe commented on pull request #17676: [FLINK-14100][connectors] Add Oracle dialect

2021-11-05 Thread GitBox
eskabetxe commented on pull request #17676: URL: https://github.com/apache/flink/pull/17676#issuecomment-961794935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17662: [FLINK-24747][table-planner] Add producedDataType to SupportsProjectionPushDown.applyProjection

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17662: URL: https://github.com/apache/flink/pull/17662#issuecomment-959311032 ## CI report: * 304b6add79698d3dd7289d5adae12cc2379e8da4 Azure:

[GitHub] [flink] MartijnVisser commented on a change in pull request #17696: [FLINK-24765][kafka] Bump Kafka version to 2.8

2021-11-05 Thread GitBox
MartijnVisser commented on a change in pull request #17696: URL: https://github.com/apache/flink/pull/17696#discussion_r743651095 ## File path: flink-connectors/flink-connector-kafka/pom.xml ## @@ -111,6 +111,15 @@ under the License. test

[GitHub] [flink] AHeise commented on pull request #17682: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-05 Thread GitBox
AHeise commented on pull request #17682: URL: https://github.com/apache/flink/pull/17682#issuecomment-961925059 I just realized that 1.12 will probably not have a new release, so we can omit this backport. I would have merged it without compilation issue but it seems to require some more

[GitHub] [flink] matriv commented on a change in pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-05 Thread GitBox
matriv commented on a change in pull request #17658: URL: https://github.com/apache/flink/pull/17658#discussion_r743578729 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/rules/BinaryToStringCastRule.java ## @@ -0,0

[GitHub] [flink] cshuo commented on a change in pull request #17634: [FLINK-24691][table-common] Fix precision for sum on decimal types

2021-11-05 Thread GitBox
cshuo commented on a change in pull request #17634: URL: https://github.com/apache/flink/pull/17634#discussion_r743368304 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/aggfunctions/SumAggFunction.java ## @@ -66,7 +66,10

[GitHub] [flink] CrynetLogistics commented on a change in pull request #17687: [FLINK-24227][connectors] Improved AsyncSink base by adding a builder…

2021-11-05 Thread GitBox
CrynetLogistics commented on a change in pull request #17687: URL: https://github.com/apache/flink/pull/17687#discussion_r743047568 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java ## @@ -49,6 +50,28 @@

[GitHub] [flink] dawidwys commented on a change in pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

2021-11-05 Thread GitBox
dawidwys commented on a change in pull request #17663: URL: https://github.com/apache/flink/pull/17663#discussion_r743601715 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java ## @@ -338,10 +338,13 @@ void

[GitHub] [flink] flinkbot commented on pull request #17687: [FLINK-24227][connectors] Improved AsyncSink base by adding a builder…

2021-11-05 Thread GitBox
flinkbot commented on pull request #17687: URL: https://github.com/apache/flink/pull/17687#issuecomment-961205811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17657: [FLINK-24745][format][json] Add support for Oracle OGG JSON format parser

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17657: URL: https://github.com/apache/flink/pull/17657#issuecomment-958746170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] zentol commented on a change in pull request #17671: [FLINK-24749][coordination] Reuse CheckpointStatsTracker

2021-11-05 Thread GitBox
zentol commented on a change in pull request #17671: URL: https://github.com/apache/flink/pull/17671#discussion_r743480869 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultExecutionGraphFactory.java ## @@ -80,6 +85,13 @@ public

[GitHub] [flink] flinkbot edited a comment on pull request #17387: [WIP][FLINK-23486][state] ChangelogUploader metrics

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17387: URL: https://github.com/apache/flink/pull/17387#issuecomment-930245327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] dawidwys commented on a change in pull request #17229: [FLINK-23381][state] Back-pressure on reaching state change to upload limit

2021-11-05 Thread GitBox
dawidwys commented on a change in pull request #17229: URL: https://github.com/apache/flink/pull/17229#discussion_r743688024 ## File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/BatchingStateChangeUploader.java ## @@ -121,18 +127,17 @@ public

[GitHub] [flink] flinkbot commented on pull request #17690: [FLINK-24490][docs] The sample code is wrong in Apache Kafka Connector page

2021-11-05 Thread GitBox
flinkbot commented on pull request #17690: URL: https://github.com/apache/flink/pull/17690#issuecomment-961660965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] echauchot commented on a change in pull request #17640: [FLINK-21407][doc][formats] Add formats to DataStream connectors doc

2021-11-05 Thread GitBox
echauchot commented on a change in pull request #17640: URL: https://github.com/apache/flink/pull/17640#discussion_r743628436 ## File path: docs/content/docs/connectors/datastream/formats/azure_table_storage.md ## @@ -0,0 +1,130 @@ +--- +title: "Microsoft Azure table"

[GitHub] [flink] flinkbot edited a comment on pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17658: URL: https://github.com/apache/flink/pull/17658#issuecomment-958884763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17674: [FLINK-24755][doc]Add guidance to solve the package sun.misc does not exist

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17674: URL: https://github.com/apache/flink/pull/17674#issuecomment-960623713 ## CI report: * f297b14850894166d4395910f68205ebb3e3ce71 Azure:

[GitHub] [flink] flinkbot commented on pull request #17695: [FLINK-24798][cli] Bump commons-cli to v1.5.0

2021-11-05 Thread GitBox
flinkbot commented on pull request #17695: URL: https://github.com/apache/flink/pull/17695#issuecomment-961862399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] echauchot edited a comment on pull request #17640: [FLINK-21407][doc][formats] Add formats to DataStream connectors doc

2021-11-05 Thread GitBox
echauchot edited a comment on pull request #17640: URL: https://github.com/apache/flink/pull/17640#issuecomment-961884112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] AHeise closed pull request #17682: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-05 Thread GitBox
AHeise closed pull request #17682: URL: https://github.com/apache/flink/pull/17682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] dawidwys commented on a change in pull request #17645: [FLINK-24667][runtime] Fix error handling in ChannelStateCheckpointWriter

2021-11-05 Thread GitBox
dawidwys commented on a change in pull request #17645: URL: https://github.com/apache/flink/pull/17645#discussion_r743638339 ## File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointFailureHandlingITCase.java ## @@ -0,0 +1,311 @@ +/* + *

[GitHub] [flink] zentol commented on a change in pull request #17679: [FLINK-24770] Remove error from JobStatusListener

2021-11-05 Thread GitBox
zentol commented on a change in pull request #17679: URL: https://github.com/apache/flink/pull/17679#discussion_r743006301 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java ## @@ -1042,8 +1041,7 @@ private boolean

[GitHub] [flink] flinkbot edited a comment on pull request #17687: [FLINK-24227][connectors] Improved AsyncSink base by adding a builder…

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17687: URL: https://github.com/apache/flink/pull/17687#issuecomment-961206353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17689: [FLINK-24704][table] Fix exception when the input record loses monotonicity on the sort key field of UpdatableTopNFunction

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17689: URL: https://github.com/apache/flink/pull/17689#issuecomment-961619732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17698: [FLINK-24689][runtime-web] Add log's last modify time in log list view

2021-11-05 Thread GitBox
flinkbot commented on pull request #17698: URL: https://github.com/apache/flink/pull/17698#issuecomment-961942723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] rkhachatryan commented on a change in pull request #17645: [FLINK-24667][runtime] Fix error handling in ChannelStateCheckpointWriter

2021-11-05 Thread GitBox
rkhachatryan commented on a change in pull request #17645: URL: https://github.com/apache/flink/pull/17645#discussion_r743646810 ## File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointFailureHandlingITCase.java ## @@ -0,0 +1,311 @@ +/*

[GitHub] [flink] tsreaper commented on a change in pull request #17672: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-05 Thread GitBox
tsreaper commented on a change in pull request #17672: URL: https://github.com/apache/flink/pull/17672#discussion_r743594661 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/PartitionableSourceITCase.scala ## @@

[GitHub] [flink] flinkbot edited a comment on pull request #17574: [FLINK-24665][s3] Update Presto Hadoop dependency to v2.7.4-9

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17574: URL: https://github.com/apache/flink/pull/17574#issuecomment-952625580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] akalash commented on a change in pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

2021-11-05 Thread GitBox
akalash commented on a change in pull request #17663: URL: https://github.com/apache/flink/pull/17663#discussion_r743613444 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java ## @@ -338,10 +338,13 @@ void

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-05 Thread GitBox
slinkydeveloper commented on a change in pull request #17658: URL: https://github.com/apache/flink/pull/17658#discussion_r743568048 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/rules/ArrayToStringCastRule.java ##

[GitHub] [flink] tsreaper commented on pull request #17520: [FLINK-24565][avro] Port avro file format factory to BulkReaderFormatFactory

2021-11-05 Thread GitBox
tsreaper commented on pull request #17520: URL: https://github.com/apache/flink/pull/17520#issuecomment-961764970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (FLINK-24805) Metrics documentation missing numBytes metrics reported by tasks

2021-11-05 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439469#comment-17439469 ] Mason Chen commented on FLINK-24805: I see, thanks! It seems I went too quickly over the doc and I

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17544: [FLINK-24165][table] Add infrastructure to support metadata for filesystem connector

2021-11-05 Thread GitBox
slinkydeveloper commented on a change in pull request #17544: URL: https://github.com/apache/flink/pull/17544#discussion_r743812037 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSource.java ## @@ -340,64 +406,27

[GitHub] [flink] dawidwys commented on a change in pull request #17664: [FLINK-24658][runtime] Added debug logs for BufferDebloater

2021-11-05 Thread GitBox
dawidwys commented on a change in pull request #17664: URL: https://github.com/apache/flink/pull/17664#discussion_r742708823 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/throughput/BufferDebloater.java ## @@ -50,6 +54,14 @@ public BufferDebloater(

[GitHub] [flink] flinkbot edited a comment on pull request #17640: [FLINK-21407][doc][formats] Add formats to DataStream connectors doc

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17640: URL: https://github.com/apache/flink/pull/17640#issuecomment-957264269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17698: [FLINK-24689][runtime-web] Add log's last modify time in log list view

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17698: URL: https://github.com/apache/flink/pull/17698#issuecomment-961944542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] eskabetxe commented on pull request #17676: [FLINK-14100][connectors] Add Oracle dialect

2021-11-05 Thread GitBox
eskabetxe commented on pull request #17676: URL: https://github.com/apache/flink/pull/17676#issuecomment-961794935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] rkhachatryan commented on a change in pull request #17229: [FLINK-23381][state] Back-pressure on reaching state change to upload limit

2021-11-05 Thread GitBox
rkhachatryan commented on a change in pull request #17229: URL: https://github.com/apache/flink/pull/17229#discussion_r743933585 ## File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/BatchingStateChangeUploader.java ## @@ -121,18 +127,17 @@

[GitHub] [flink] flinkbot edited a comment on pull request #17662: [FLINK-24747][table-planner] Add producedDataType to SupportsProjectionPushDown.applyProjection

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17662: URL: https://github.com/apache/flink/pull/17662#issuecomment-959311032 ## CI report: * 304b6add79698d3dd7289d5adae12cc2379e8da4 Azure:

[GitHub] [flink] MartijnVisser commented on a change in pull request #17696: [FLINK-24765][kafka] Bump Kafka version to 2.8

2021-11-05 Thread GitBox
MartijnVisser commented on a change in pull request #17696: URL: https://github.com/apache/flink/pull/17696#discussion_r743651095 ## File path: flink-connectors/flink-connector-kafka/pom.xml ## @@ -111,6 +111,15 @@ under the License. test

[GitHub] [flink] flinkbot edited a comment on pull request #17697: [FLINK-24796][ci] Reduce size of compile build artifact

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17697: URL: https://github.com/apache/flink/pull/17697#issuecomment-961911493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17694: [FLINK-24414][table-planner] Remove example test for left padding of decimals

2021-11-05 Thread GitBox
flinkbot commented on pull request #17694: URL: https://github.com/apache/flink/pull/17694#issuecomment-961828996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] zentol merged pull request #17593: [FLINK-24603][e2e] Add test for Scala-free Flink

2021-11-05 Thread GitBox
zentol merged pull request #17593: URL: https://github.com/apache/flink/pull/17593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17650: [FLINK-24475] Remove no longer used NestedMap* classes

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17650: URL: https://github.com/apache/flink/pull/17650#issuecomment-958638599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] xuyangzhong commented on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-05 Thread GitBox
xuyangzhong commented on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-961639325 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] CrynetLogistics commented on pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-05 Thread GitBox
CrynetLogistics commented on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-961203555 All changes to the base sink are raised in a separate PR here FLINK-17687 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] AHeise merged pull request #17625: [FLINK-24719][jdbc] Update Postgres test dependencies to 0.13.4

2021-11-05 Thread GitBox
AHeise merged pull request #17625: URL: https://github.com/apache/flink/pull/17625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] twalthr closed pull request #17688: [FLINK-24778][table-common] Add DataTypes#ROW(List) to reduce friction when using Stream of fields

2021-11-05 Thread GitBox
twalthr closed pull request #17688: URL: https://github.com/apache/flink/pull/17688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #17699: [FLINK-20370][table] Fix wrong results when sink primary key is not the same with query result's changelog upsert key

2021-11-05 Thread GitBox
flinkbot commented on pull request #17699: URL: https://github.com/apache/flink/pull/17699#issuecomment-961963496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] MartijnVisser commented on pull request #17667: [hotfix][docs]fix kafka datastream connector mistake

2021-11-05 Thread GitBox
MartijnVisser commented on pull request #17667: URL: https://github.com/apache/flink/pull/17667#issuecomment-961882890 @AHeise Please merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot commented on pull request #17697: [FLINK-24796][ci] Reduce size of compile build artifact

2021-11-05 Thread GitBox
flinkbot commented on pull request #17697: URL: https://github.com/apache/flink/pull/17697#issuecomment-961909899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] tillrohrmann commented on a change in pull request #17607: [FLINK-24543][runtime] Avoid possible inconsistencies of ZookeeperSta…

2021-11-05 Thread GitBox
tillrohrmann commented on a change in pull request #17607: URL: https://github.com/apache/flink/pull/17607#discussion_r743521497 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java ## @@ -154,54 +158,75 @@ public

[GitHub] [flink] flinkbot edited a comment on pull request #17670: [FLINK-24760][docs] Update user document for batch window tvf

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17670: URL: https://github.com/apache/flink/pull/17670#issuecomment-960539433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17694: [FLINK-24414][table-planner] Remove example test for left padding of decimals

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17694: URL: https://github.com/apache/flink/pull/17694#issuecomment-961828996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] AHeise commented on pull request #17640: [FLINK-21407][doc][formats] Add formats to DataStream connectors doc

2021-11-05 Thread GitBox
AHeise commented on pull request #17640: URL: https://github.com/apache/flink/pull/17640#issuecomment-961928372 > @AHeise @MartijnVisser 2 general questions: > > 1. the current PR is a port of [this PR](https://github.com/apache/flink/pull/17523/files) for 1.13 that was asked

[GitHub] [flink] ruanhang1993 commented on pull request #17601: [FLINK-24697][flink-connectors-kafka] add auto.offset.reset configuration for group-offsets startup mode

2021-11-05 Thread GitBox
ruanhang1993 commented on pull request #17601: URL: https://github.com/apache/flink/pull/17601#issuecomment-961592246 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot edited a comment on pull request #17527: [hotfix][docs] Add link from README.md to 'Building Flink from Source'

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17527: URL: https://github.com/apache/flink/pull/17527#issuecomment-947535485 ## CI report: * 8d4e6f975a618204ad76907e1a275c3df18c0414 Azure:

[GitHub] [flink] leonardBang commented on pull request #17676: [FLINK-14100][connectors] Add Oracle dialect

2021-11-05 Thread GitBox
leonardBang commented on pull request #17676: URL: https://github.com/apache/flink/pull/17676#issuecomment-961556377 > @leonardBang Would you be able to help with a review? Yes, my pleasure -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] flinkbot edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-904541061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #16582: [FLINK-21504][checkpoint] Introduce notification of subsumed checkpoint

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #16582: URL: https://github.com/apache/flink/pull/16582#issuecomment-885598535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-ml] lindong28 commented on a change in pull request #10: [FLINK-24354][FLIP-174] Improve the WithParams interface

2021-11-05 Thread GitBox
lindong28 commented on a change in pull request #10: URL: https://github.com/apache/flink-ml/pull/10#discussion_r74341 ## File path: flink-ml-api/src/test/java/org/apache/flink/ml/api/core/StageTest.java ## @@ -0,0 +1,345 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] eskabetxe commented on a change in pull request #17676: [FLINK-14100][connectors] Add Oracle dialect

2021-11-05 Thread GitBox
eskabetxe commented on a change in pull request #17676: URL: https://github.com/apache/flink/pull/17676#discussion_r743560497 ## File path: flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/JdbcTestFixture.java ## @@ -149,7 +149,7 @@ private

[GitHub] [flink] flinkbot edited a comment on pull request #17598: [WIP][FLINK-24703][connectors][formats] Add FileSource support for reading CSV files.

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17598: URL: https://github.com/apache/flink/pull/17598#issuecomment-954282485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17680: [FLINK-24771][jdbc][tests] Update JDBC test dependencies to latest version

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17680: URL: https://github.com/apache/flink/pull/17680#issuecomment-960837186 ## CI report: * 59cec47a8768554cce7b8fec01309f0bdd10509a Azure:

[GitHub] [flink] dawidwys commented on pull request #17645: [FLINK-24667][runtime] Fix error handling in ChannelStateCheckpointWriter

2021-11-05 Thread GitBox
dawidwys commented on pull request #17645: URL: https://github.com/apache/flink/pull/17645#issuecomment-961878632 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot edited a comment on pull request #17643: [FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17643: URL: https://github.com/apache/flink/pull/17643#issuecomment-957416596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17681: [FLINK-24543][runtime] Avoid possible inconsistencies of ZookeeperSta…

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17681: URL: https://github.com/apache/flink/pull/17681#issuecomment-960861704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17691: [FLINK-24586][table] SQL functions should return STRING instead of VARCHAR(2000)

2021-11-05 Thread GitBox
flinkbot commented on pull request #17691: URL: https://github.com/apache/flink/pull/17691#issuecomment-961688928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] fapaul commented on a change in pull request #17696: [FLINK-24765][kafka] Bump Kafka version to 2.8

2021-11-05 Thread GitBox
fapaul commented on a change in pull request #17696: URL: https://github.com/apache/flink/pull/17696#discussion_r743698529 ## File path: flink-connectors/flink-connector-kafka/pom.xml ## @@ -111,6 +111,15 @@ under the License. test +

[GitHub] [flink] JingGe commented on pull request #17574: [FLINK-24665][s3] Update Presto Hadoop dependency to v2.7.4-9

2021-11-05 Thread GitBox
JingGe commented on pull request #17574: URL: https://github.com/apache/flink/pull/17574#issuecomment-961425986 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] tsreaper commented on pull request #17672: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-05 Thread GitBox
tsreaper commented on pull request #17672: URL: https://github.com/apache/flink/pull/17672#issuecomment-961729196 Sorry for misleading. As all test classes are in the same class path, if we create a new udf class in test it will still be loaded by the default class loader. One way to work

[GitHub] [flink-web] dawidwys merged pull request #479: Fix typos in Flink 1.14.0 release note

2021-11-05 Thread GitBox
dawidwys merged pull request #479: URL: https://github.com/apache/flink-web/pull/479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17679: [FLINK-24770] Remove error from JobStatusListener

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17679: URL: https://github.com/apache/flink/pull/17679#issuecomment-960792789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] twalthr closed pull request #17683: [hotfix][table-planner][tests] Fix a few links to FLINK jira tickets

2021-11-05 Thread GitBox
twalthr closed pull request #17683: URL: https://github.com/apache/flink/pull/17683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] Tartarus0zm commented on pull request #17672: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-05 Thread GitBox
Tartarus0zm commented on pull request #17672: URL: https://github.com/apache/flink/pull/17672#issuecomment-961817197 @tsreaper thank you for your reply. I have added test cases, please take a look, if you have time, thanks cc @KurtYoung -- This is an automated message from the

[GitHub] [flink] MartijnVisser commented on a change in pull request #17640: [FLINK-21407][doc][formats] Add formats to DataStream connectors doc

2021-11-05 Thread GitBox
MartijnVisser commented on a change in pull request #17640: URL: https://github.com/apache/flink/pull/17640#discussion_r743649235 ## File path: docs/content/docs/connectors/datastream/formats/parquet.md ## @@ -0,0 +1,67 @@ +--- +title: "Parquet" +weight: 4 +type: docs

[GitHub] [flink] zentol merged pull request #17679: [FLINK-24770] Remove error from JobStatusListener

2021-11-05 Thread GitBox
zentol merged pull request #17679: URL: https://github.com/apache/flink/pull/17679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17666: URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] dannycranmer commented on a change in pull request #17687: [FLINK-24227][connectors] Improved AsyncSink base by adding a builder…

2021-11-05 Thread GitBox
dannycranmer commented on a change in pull request #17687: URL: https://github.com/apache/flink/pull/17687#discussion_r743024147 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java ## @@ -49,6 +50,28 @@

[GitHub] [flink] flinkbot edited a comment on pull request #17544: [FLINK-24165][table] Add infrastructure to support metadata for filesystem connector

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17544: URL: https://github.com/apache/flink/pull/17544#issuecomment-949353495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17685: [FLINK-24631][Kubernetes]Use minimal selector to select jobManager and taskManager pod

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17685: URL: https://github.com/apache/flink/pull/17685#issuecomment-961148655 ## CI report: * 079d07698cfd206db55ad55596e7aab73ba44ef9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17683: [hotfix][table-planner][tests] Fix a few links to FLINK jira tickets

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17683: URL: https://github.com/apache/flink/pull/17683#issuecomment-960955131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17695: [FLINK-24798][cli] Bump commons-cli to v1.5.0

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17695: URL: https://github.com/apache/flink/pull/17695#issuecomment-961862399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17693: [FLINK-24789][runtime] Trigger checkpoint disposal prior completing t…

2021-11-05 Thread GitBox
flinkbot edited a comment on pull request #17693: URL: https://github.com/apache/flink/pull/17693#issuecomment-961795148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] AHeise merged pull request #17646: [FLINK-24740][testinfrastructure] Update testcontainers dependency to v1.16.2

2021-11-05 Thread GitBox
AHeise merged pull request #17646: URL: https://github.com/apache/flink/pull/17646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

<    2   3   4   5   6   7   8   9   10   >