[GitHub] [flink] flinkbot edited a comment on pull request #18135: [FLINK-24809][table-common][table-planner] Fix precision for aggs on DECIMAL types

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18135: URL: https://github.com/apache/flink/pull/18135#issuecomment-995929870 ## CI report: * 2aa4b3a902ef55ac429d0be0d08a96d99a62dea1 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18134: [FLINK-25128][table] Reorganize table modules and introduce flink-table-planner-loader

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18134: URL: https://github.com/apache/flink/pull/18134#issuecomment-995882484 ## CI report: * 81ab49c033b1d6739b69a4ca3c0d5433ed50b03f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18023: [FLINK-25032] Allow to create execution vertices and execution edges lazily

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18023: URL: https://github.com/apache/flink/pull/18023#issuecomment-986704278 ## CI report: * cfd2774e395e402ff9838a0f7aeb0a0f2897f50f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17936: [FLINK-24954][network] Reset read buffer request timeout on buffer recycling for sort-shuffle

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #17936: URL: https://github.com/apache/flink/pull/17936#issuecomment-980533423 ## CI report: * ec7627125864b807502b26946f61a59ec027c625 Azure:

[GitHub] [flink] wanglijie95 commented on pull request #18023: [FLINK-25032] Allow to create execution vertices and execution edges lazily

2021-12-22 Thread GitBox
wanglijie95 commented on pull request #18023: URL: https://github.com/apache/flink/pull/18023#issuecomment-999648435 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] twalthr commented on pull request #18135: [FLINK-24809][table-common][table-planner] Fix precision for aggs on DECIMAL types

2021-12-22 Thread GitBox
twalthr commented on pull request #18135: URL: https://github.com/apache/flink/pull/18135#issuecomment-999647686 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot edited a comment on pull request #18135: [FLINK-24809][table-common][table-planner] Fix precision for aggs on DECIMAL types

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18135: URL: https://github.com/apache/flink/pull/18135#issuecomment-995929870 ## CI report: * 2aa4b3a902ef55ac429d0be0d08a96d99a62dea1 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18134: [FLINK-25128][table] Reorganize table modules and introduce flink-table-planner-loader

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18134: URL: https://github.com/apache/flink/pull/18134#issuecomment-995882484 ## CI report: * 81ab49c033b1d6739b69a4ca3c0d5433ed50b03f Azure:

[GitHub] [flink] MartijnVisser commented on pull request #18150: [hotfix][docs] Fix typo in connectors doc

2021-12-22 Thread GitBox
MartijnVisser commented on pull request #18150: URL: https://github.com/apache/flink/pull/18150#issuecomment-999643942 @aihai We can still improve a bit on your commit message. In this case, I would probably use: `[hotfix][docs] Fix incorrect dependency reference from flink-parquet

[GitHub] [flink] flinkbot edited a comment on pull request #18150: [hotfix][docs] Fix typo in connectors doc

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18150: URL: https://github.com/apache/flink/pull/18150#issuecomment-997636068 ## CI report: * 745924f234b25da966421604e4777319ed12d0a6 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18134: [FLINK-25128][table] Reorganize table modules and introduce flink-table-planner-loader

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18134: URL: https://github.com/apache/flink/pull/18134#issuecomment-995882484 ## CI report: * ce0be797136c864db01c58eb9d324c75a0d8 Azure:

[jira] [Commented] (FLINK-25409) Add cache metric to LookupFunction

2021-12-22 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463882#comment-17463882 ] Martijn Visser commented on FLINK-25409: [~wenlong.lwl] Yes, agreed, we're on the same page :)

[GitHub] [flink] aihai edited a comment on pull request #18150: [hotfix][docs] Fix typo in connectors doc

2021-12-22 Thread GitBox
aihai edited a comment on pull request #18150: URL: https://github.com/apache/flink/pull/18150#issuecomment-999638001 Thank you very much. I have changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] aihai commented on pull request #18150: [hotfix][docs] Fix typo in connectors doc

2021-12-22 Thread GitBox
aihai commented on pull request #18150: URL: https://github.com/apache/flink/pull/18150#issuecomment-999638001 Thank you very mush. I have changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] flinkbot edited a comment on pull request #18150: [hotfix][docs] Fix typo in connectors doc

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18150: URL: https://github.com/apache/flink/pull/18150#issuecomment-997636068 ## CI report: * 745924f234b25da966421604e4777319ed12d0a6 Azure:

[GitHub] [flink] pscls commented on pull request #15140: [FLINK-20628][connectors/rabbitmq2] RabbitMQ connector using new connector API

2021-12-22 Thread GitBox
pscls commented on pull request #15140: URL: https://github.com/apache/flink/pull/15140#issuecomment-999637144 > Excuse me, @pscls Are you still working for this PR ? @RocMarshal Not really, we finished it 9 months ago with @fapaul's requested changes. Since then nothing happened on

[GitHub] [flink] flinkbot edited a comment on pull request #18134: [FLINK-25128][table] Reorganize table modules and introduce flink-table-planner-loader

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18134: URL: https://github.com/apache/flink/pull/18134#issuecomment-995882484 ## CI report: * ce0be797136c864db01c58eb9d324c75a0d8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18126: [FLINK-25036][runtime] Add stage wise scheduling strategy

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18126: URL: https://github.com/apache/flink/pull/18126#issuecomment-995489268 ## CI report: * f769f988700610398b4c9d1e6ad0210a28a07a16 Azure:

[GitHub] [flink] wuchong commented on a change in pull request #17988: [FLINK-25010][Connectors/Hive] Speed up hive's createMRSplits by multi thread

2021-12-22 Thread GitBox
wuchong commented on a change in pull request #17988: URL: https://github.com/apache/flink/pull/17988#discussion_r773947555 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveOptions.java ## @@ -51,4 +51,11 @@

[GitHub] [flink] flinkbot edited a comment on pull request #18134: [FLINK-25128][table] Reorganize table modules and introduce flink-table-planner-loader

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18134: URL: https://github.com/apache/flink/pull/18134#issuecomment-995882484 ## CI report: * ce0be797136c864db01c58eb9d324c75a0d8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18126: [FLINK-25036][runtime] Add stage wise scheduling strategy

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18126: URL: https://github.com/apache/flink/pull/18126#issuecomment-995489268 ## CI report: * f769f988700610398b4c9d1e6ad0210a28a07a16 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18119: [FLINK-24947] Support hostNetwork for native K8s integration on session mode

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18119: URL: https://github.com/apache/flink/pull/18119#issuecomment-994734000 ## CI report: * 31e2390d189b7dd08bf1e1099138b81b4524ce70 Azure:

[jira] [Commented] (FLINK-25409) Add cache metric to LookupFunction

2021-12-22 Thread Wenlong Lyu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463861#comment-17463861 ] Wenlong Lyu commented on FLINK-25409: - hi, [~MartijnVisser], you are right about the sharing.

[GitHub] [flink] flinkbot edited a comment on pull request #18134: [FLINK-25128][table] Reorganize table modules and introduce flink-table-planner-loader

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18134: URL: https://github.com/apache/flink/pull/18134#issuecomment-995882484 ## CI report: * ce0be797136c864db01c58eb9d324c75a0d8 Azure:

[jira] [Comment Edited] (FLINK-25261) Changelog not truncated on materialization

2021-12-22 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463808#comment-17463808 ] Roman Khachatryan edited comment on FLINK-25261 at 12/22/21, 2:43 PM:

[GitHub] [flink] flinkbot edited a comment on pull request #18134: [FLINK-25128][table] Reorganize table modules and introduce flink-table-planner-loader

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18134: URL: https://github.com/apache/flink/pull/18134#issuecomment-995882484 ## CI report: * ce0be797136c864db01c58eb9d324c75a0d8 Azure:

[jira] [Created] (FLINK-25421) Port JDBC Sink to new Unified Sink API (FLIP-143)

2021-12-22 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-25421: -- Summary: Port JDBC Sink to new Unified Sink API (FLIP-143) Key: FLINK-25421 URL: https://issues.apache.org/jira/browse/FLINK-25421 Project: Flink Issue

[jira] [Created] (FLINK-25420) Port JDBC Source to new Source API (FLIP-27)

2021-12-22 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-25420: -- Summary: Port JDBC Source to new Source API (FLIP-27) Key: FLINK-25420 URL: https://issues.apache.org/jira/browse/FLINK-25420 Project: Flink Issue Type:

[jira] [Commented] (FLINK-25411) JsonRowSerializationSchema unable to parse TIMESTAMP_LTZ fields

2021-12-22 Thread Wenlong Lyu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463849#comment-17463849 ] Wenlong Lyu commented on FLINK-25411: - [~surendra.lalwani] I think it would be better to post an

[jira] [Commented] (FLINK-25409) Add cache metric to LookupFunction

2021-12-22 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463847#comment-17463847 ] Martijn Visser commented on FLINK-25409: [~wenlong.lwl] I do think it is relevant. A connector

[GitHub] [flink] flinkbot edited a comment on pull request #18134: [FLINK-25128][table] Reorganize table modules and introduce flink-table-planner-loader

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18134: URL: https://github.com/apache/flink/pull/18134#issuecomment-995882484 ## CI report: * ce0be797136c864db01c58eb9d324c75a0d8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18023: [FLINK-25032] Allow to create execution vertices and execution edges lazily

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18023: URL: https://github.com/apache/flink/pull/18023#issuecomment-986704278 ## CI report: * cfd2774e395e402ff9838a0f7aeb0a0f2897f50f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18134: [FLINK-25128][table] Reorganize table modules and introduce flink-table-planner-loader

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18134: URL: https://github.com/apache/flink/pull/18134#issuecomment-995882484 ## CI report: * ce0be797136c864db01c58eb9d324c75a0d8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18134: [FLINK-25128][table] Reorganize table modules and introduce flink-table-planner-loader

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18134: URL: https://github.com/apache/flink/pull/18134#issuecomment-995882484 ## CI report: * ce0be797136c864db01c58eb9d324c75a0d8 Azure:

[GitHub] [flink] pnowojski commented on a change in pull request #18173: [FLINK-25407][network] Fix the deadlock issue caused by LocalBufferPool#reserveSegments

2021-12-22 Thread GitBox
pnowojski commented on a change in pull request #18173: URL: https://github.com/apache/flink/pull/18173#discussion_r773910917 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java ## @@ -158,7 +159,8 @@ public

[GitHub] [flink] flinkbot edited a comment on pull request #18134: [FLINK-25128][table] Reorganize table modules and introduce flink-table-planner-loader

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18134: URL: https://github.com/apache/flink/pull/18134#issuecomment-995882484 ## CI report: * ce0be797136c864db01c58eb9d324c75a0d8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18068: [FLINK-25105][checkpoint] Enables final checkpoint by default

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18068: URL: https://github.com/apache/flink/pull/18068#issuecomment-989975508 ## CI report: * f0b1ef0bd1e2babc2093a57b0b6b619c99cb551e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18172: [hotfix][doc]update doc variable name reference error

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18172: URL: https://github.com/apache/flink/pull/18172#issuecomment-999323746 ## CI report: * 20f4eea5c51af444b31a4535e7751af021a9041c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18068: [FLINK-25105][checkpoint] Enables final checkpoint by default

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18068: URL: https://github.com/apache/flink/pull/18068#issuecomment-989975508 ## CI report: * 6832524d7d78de814cbeadb44fa8037da5c10ca9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17819: [FLINK-15816][k8s] Limit kubernetes.cluster-id to a maximum of 40 characters

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #17819: URL: https://github.com/apache/flink/pull/17819#issuecomment-971446182 ## CI report: * 7f0824c6027e9fdd23acd9c6f742614662e2fba2 Azure:

[jira] [Commented] (FLINK-25409) Add cache metric to LookupFunction

2021-12-22 Thread Wenlong Lyu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463826#comment-17463826 ] Wenlong Lyu commented on FLINK-25409: - hi, [~MartijnVisser] this ticket may be not relevant to the

[GitHub] [flink] alpreu commented on pull request #17819: [FLINK-15816][k8s] Limit kubernetes.cluster-id to a maximum of 40 characters

2021-12-22 Thread GitBox
alpreu commented on pull request #17819: URL: https://github.com/apache/flink/pull/17819#issuecomment-999604274 I just pushed a work in progress commit that illustrates the idea. One thing I really don't like is that `getClusterId()` cannot be hidden/private because: 1) it needs the

[GitHub] [flink] gaoyunhaii commented on pull request #18068: [FLINK-25105][checkpoint] Enables final checkpoint by default

2021-12-22 Thread GitBox
gaoyunhaii commented on pull request #18068: URL: https://github.com/apache/flink/pull/18068#issuecomment-999603158 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot edited a comment on pull request #18167: [FLINK-25375] [BP-1.14] Update log4j2 dependency to 2.17.0 to address

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18167: URL: https://github.com/apache/flink/pull/18167#issuecomment-998921117 ## CI report: * 180b4cabc0b5597de22169305c84b70a7bf0d9be Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18134: [FLINK-25128][table] Reorganize table modules and introduce flink-table-planner-loader

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18134: URL: https://github.com/apache/flink/pull/18134#issuecomment-995882484 ## CI report: * ce0be797136c864db01c58eb9d324c75a0d8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17819: [FLINK-15816][k8s] Limit kubernetes.cluster-id to a maximum of 40 characters

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #17819: URL: https://github.com/apache/flink/pull/17819#issuecomment-971446182 ## CI report: * 7f0824c6027e9fdd23acd9c6f742614662e2fba2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18134: [FLINK-25128][table] Reorganize table modules and introduce flink-table-planner-loader

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18134: URL: https://github.com/apache/flink/pull/18134#issuecomment-995882484 ## CI report: * ce0be797136c864db01c58eb9d324c75a0d8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18181: [FLINK-25414][metrics] Provide metrics to measure how long task has been blocked

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18181: URL: https://github.com/apache/flink/pull/18181#issuecomment-999589676 ## CI report: * a6b0015f7ccd3d1704066d1ae743a6a793ffef8f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18181: [FLINK-25414][metrics] Provide metrics to measure how long task has been blocked

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18181: URL: https://github.com/apache/flink/pull/18181#issuecomment-999589676 ## CI report: * a6b0015f7ccd3d1704066d1ae743a6a793ffef8f UNKNOWN Bot commands The @flinkbot bot supports the following commands: -

[GitHub] [flink] godfreyhe commented on a change in pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-12-22 Thread GitBox
godfreyhe commented on a change in pull request #17845: URL: https://github.com/apache/flink/pull/17845#discussion_r773901184 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -4711,6 +4711,11 @@ private

[jira] [Updated] (FLINK-25414) Provide metrics to measure how long task has been blocked

2021-12-22 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-25414: --- Description: Currently back pressured/busy metrics tell the user whether task is

[GitHub] [flink] flinkbot commented on pull request #18181: [FLINK-25414][metrics] Provide metrics to measure how long task has been blocked

2021-12-22 Thread GitBox
flinkbot commented on pull request #18181: URL: https://github.com/apache/flink/pull/18181#issuecomment-999590596 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #18181: [FLINK-25414][metrics] Provide metrics to measure how long task has been blocked

2021-12-22 Thread GitBox
flinkbot commented on pull request #18181: URL: https://github.com/apache/flink/pull/18181#issuecomment-999589676 ## CI report: * d8459fbf3bbf26d605f0bf857850f09222e7a5a5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #18168: [FLINK-25375] [BP-1.13] Update log4j2 dependency to 2.17.0 to address

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18168: URL: https://github.com/apache/flink/pull/18168#issuecomment-998921246 ## CI report: * a35f85a0b715065ed0ea1ac1674df821a37d307a Azure:

[jira] [Updated] (FLINK-25414) Provide metrics to measure how long task has been blocked

2021-12-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25414: --- Labels: pull-request-available (was: ) > Provide metrics to measure how long task has been

[GitHub] [flink] pnowojski opened a new pull request #18181: [FLINK-25414][metrics] Provide metrics to measure how long task has been blocked

2021-12-22 Thread GitBox
pnowojski opened a new pull request #18181: URL: https://github.com/apache/flink/pull/18181 Currently back pressured/busy metrics tell the user whether task is blocked/busy and how much % of the time it is blocked/busy. But they do not tell how for how long single block event is lasting.

[jira] [Assigned] (FLINK-25414) Provide metrics to measure how long task has been blocked

2021-12-22 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-25414: -- Assignee: Piotr Nowojski > Provide metrics to measure how long task has been blocked

[GitHub] [flink] flinkbot edited a comment on pull request #18180: [hotfix][doc] Fix ambiguous 'Not that' word as 'Note that'

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18180: URL: https://github.com/apache/flink/pull/18180#issuecomment-999581101 ## CI report: * cb47b6316554a82d323b8d15ae74ceaac8e82f77 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18166: [FLINK-25375] [BP-1.12] Update log4j2 dependency to 2.17.0 to address

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18166: URL: https://github.com/apache/flink/pull/18166#issuecomment-998921002 ## CI report: * f1a79f4e4f24d76d7068d482d64866ca28ad9986 Azure:

[jira] [Commented] (FLINK-25261) Changelog not truncated on materialization

2021-12-22 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463808#comment-17463808 ] Roman Khachatryan commented on FLINK-25261: --- # Correct (as I wrote above in context of this

[GitHub] [flink] flinkbot commented on pull request #18180: [hotfix][doc] Fix ambiguous 'Not that' word as 'Note that'

2021-12-22 Thread GitBox
flinkbot commented on pull request #18180: URL: https://github.com/apache/flink/pull/18180#issuecomment-999581327 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #18180: [hotfix][doc] Fix ambiguous 'Not that' word as 'Note that'

2021-12-22 Thread GitBox
flinkbot commented on pull request #18180: URL: https://github.com/apache/flink/pull/18180#issuecomment-999581101 ## CI report: * cb47b6316554a82d323b8d15ae74ceaac8e82f77 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] hackergin commented on pull request #18180: [hotfix][doc] Fix ambiguous 'Not that' word as 'Note that'

2021-12-22 Thread GitBox
hackergin commented on pull request #18180: URL: https://github.com/apache/flink/pull/18180#issuecomment-999577963 @MartijnVisser How do you think about this small fix ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] hackergin opened a new pull request #18180: [hotfix][doc] Fix ambiguous 'Not that' word as 'Note that'

2021-12-22 Thread GitBox
hackergin opened a new pull request #18180: URL: https://github.com/apache/flink/pull/18180 Change some 'Not that' words to 'Note that' . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot edited a comment on pull request #17734: [FLINK-23305][table]Support semi/anti interval joins

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #17734: URL: https://github.com/apache/flink/pull/17734#issuecomment-964006875 ## CI report: * 3b50132a289ee35199fa98b860e65e2b0a02a253 Azure:

[GitHub] [flink] spoon-lz commented on pull request #18119: [FLINK-24947] Support hostNetwork for native K8s integration on session mode

2021-12-22 Thread GitBox
spoon-lz commented on pull request #18119: URL: https://github.com/apache/flink/pull/18119#issuecomment-999558123 @wangyang0918 Thanks for helping review this PR, give me some time to modify them -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] flinkbot edited a comment on pull request #16571: [hotfix][connector/kafka] fix missing nullable annotion

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #16571: URL: https://github.com/apache/flink/pull/16571#issuecomment-884882802 ## CI report: * 83e4441ce01d748577c9527ebad316ec9ec11fd7 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18119: [FLINK-24947] Support hostNetwork for native K8s integration on session mode

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18119: URL: https://github.com/apache/flink/pull/18119#issuecomment-994734000 ## CI report: * 5e44df9d7e58fa94fc7a05bb69c61b0eed7a0fad Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18119: [FLINK-24947] Support hostNetwork for native K8s integration on session mode

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18119: URL: https://github.com/apache/flink/pull/18119#issuecomment-994734000 ## CI report: * 5e44df9d7e58fa94fc7a05bb69c61b0eed7a0fad Azure:

[GitHub] [flink] spoon-lz commented on a change in pull request #18119: [FLINK-24947] Support hostNetwork for native K8s integration on session mode

2021-12-22 Thread GitBox
spoon-lz commented on a change in pull request #18119: URL: https://github.com/apache/flink/pull/18119#discussion_r773858108 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/utils/Constants.java ## @@ -25,6 +25,9 @@ public static final String

[GitHub] [flink] flinkbot edited a comment on pull request #18179: [FLINK-8518][Table SQL / API] Add support for extract Epoch

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18179: URL: https://github.com/apache/flink/pull/18179#issuecomment-999539512 ## CI report: * 180adc2e9c1adb543eb7406ea3b511570d0b5c67 Azure:

[GitHub] [flink] flinkbot commented on pull request #18179: [FLINK-8518][Table SQL / API] Add support for extract Epoch

2021-12-22 Thread GitBox
flinkbot commented on pull request #18179: URL: https://github.com/apache/flink/pull/18179#issuecomment-999540829 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #18179: [FLINK-8518][Table SQL / API] Add support for extract Epoch

2021-12-22 Thread GitBox
flinkbot commented on pull request #18179: URL: https://github.com/apache/flink/pull/18179#issuecomment-999539512 ## CI report: * 180adc2e9c1adb543eb7406ea3b511570d0b5c67 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #18178: [FLINK-5080][connectors/cassandra] Cassandra connector ignores saveAsync result onSuccess.

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18178: URL: https://github.com/apache/flink/pull/18178#issuecomment-999536388 ## CI report: * 2c1a1795ca154126ba06f062fd594cbb5795fafa Azure:

[jira] [Updated] (FLINK-8518) Support DOW, EPOCH, DECADE for EXTRACT

2021-12-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-8518: -- Labels: auto-deprioritized-major auto-unassigned pull-request-available stale-minor (was:

[GitHub] [flink] flinkbot commented on pull request #18178: [FLINK-5080][connectors/cassandra] Cassandra connector ignores saveAsync result onSuccess.

2021-12-22 Thread GitBox
flinkbot commented on pull request #18178: URL: https://github.com/apache/flink/pull/18178#issuecomment-999537487 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] snuyanzin opened a new pull request #18179: [FLINK-8518][Table SQL / API] Add support for extract Epoch

2021-12-22 Thread GitBox
snuyanzin opened a new pull request #18179: URL: https://github.com/apache/flink/pull/18179 ## What is the purpose of the change This is the final part of the ticket https://issues.apache.org/jira/browse/FLINK-8518 which implements support of `EXTRACT` of `EPOCH` e.g. ```sql

[GitHub] [flink] flinkbot commented on pull request #18178: [FLINK-5080][connectors/cassandra] Cassandra connector ignores saveAsync result onSuccess.

2021-12-22 Thread GitBox
flinkbot commented on pull request #18178: URL: https://github.com/apache/flink/pull/18178#issuecomment-999536388 ## CI report: * 2c1a1795ca154126ba06f062fd594cbb5795fafa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] RocMarshal opened a new pull request #18178: [FLINK-5080][connectors/cassandra] Cassandra connector ignores saveAsync result onSuccess.

2021-12-22 Thread GitBox
RocMarshal opened a new pull request #18178: URL: https://github.com/apache/flink/pull/18178 ## What is the purpose of the change Add possibility of passing a custom callback XXXOutputFormat; in this way we could deal with a success or failure in more custom way

[GitHub] [flink] flinkbot edited a comment on pull request #18014: [FLINK-24857][test][Kafka] Upgrade SourceReaderTestBase t…

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18014: URL: https://github.com/apache/flink/pull/18014#issuecomment-986441468 ## CI report: * e632511ff5874b350c838d7bef49e515f7981f47 Azure:

[GitHub] [flink] leonardBang commented on pull request #17676: [FLINK-14100][connectors] Add Oracle dialect

2021-12-22 Thread GitBox
leonardBang commented on pull request #17676: URL: https://github.com/apache/flink/pull/17676#issuecomment-999526598 > Or do you think there are more things that needs to be done? Thanks @MartijnVisser for pushing things forward, my last concern is the Data Types mapping, we do not

[jira] [Commented] (FLINK-25418) The dir_cache is specified in the flick task. When there is no network, you will still download the python third-party library

2021-12-22 Thread Ada Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463766#comment-17463766 ] Ada Wong commented on FLINK-25418: -- cc [~dianfu] I want to fix this.  I will add the '--no-index'

[jira] [Commented] (FLINK-25417) Too many connections for TM

2021-12-22 Thread Zhilong Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463763#comment-17463763 ] Zhilong Hong commented on FLINK-25417: -- I think maybe it's duplicated with FLINK-22643. > Too many

[jira] [Commented] (FLINK-25419) Support the metadata column to generate dynamic index

2021-12-22 Thread jinfeng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463762#comment-17463762 ] jinfeng commented on FLINK-25419: - cc  [~fpaul]  [~matriv]   > Support the metadata column to generate

[jira] [Updated] (FLINK-25418) The dir_cache is specified in the flick task. When there is no network, you will still download the python third-party library

2021-12-22 Thread yangcai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yangcai updated FLINK-25418: Description: Specified in Python code set_python_requirements(requirements_cache_dir=dir_cache) During

[GitHub] [flink] leonardBang edited a comment on pull request #18058: [FLINK-24571][connectors/elasticsearch] Supports a system time function(now() and current_timestamp) in index pattern

2021-12-22 Thread GitBox
leonardBang edited a comment on pull request #18058: URL: https://github.com/apache/flink/pull/18058#issuecomment-999522044 > * Do we need to prohibit all dynamic indexes in non-append-only stream? Slightly -1 for this, it's a fallback for users that doesn't use nondeterministic

[GitHub] [flink] leonardBang commented on pull request #18058: [FLINK-24571][connectors/elasticsearch] Supports a system time function(now() and current_timestamp) in index pattern

2021-12-22 Thread GitBox
leonardBang commented on pull request #18058: URL: https://github.com/apache/flink/pull/18058#issuecomment-999522044 > * Do we need to prohibit all dynamic indexes in non-append-only stream? Slightly -1 for this, it's a fallback for users that doesn't use nondeterministic fields(i.e.

[jira] [Updated] (FLINK-25419) Support the metadata column to generate dynamic index

2021-12-22 Thread jinfeng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jinfeng updated FLINK-25419: Description: As mentioned in [https://github.com/apache/flink/pull/18058]   We can implement metadata

[jira] [Updated] (FLINK-25419) Support the metadata column to generate dynamic index

2021-12-22 Thread jinfeng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jinfeng updated FLINK-25419: Description: As mentioned in [https://github.com/apache/flink/pull/18058

[jira] [Created] (FLINK-25419) Support the metadata column to generate dynamic index

2021-12-22 Thread jinfeng (Jira)
jinfeng created FLINK-25419: --- Summary: Support the metadata column to generate dynamic index Key: FLINK-25419 URL: https://issues.apache.org/jira/browse/FLINK-25419 Project: Flink Issue Type:

[jira] [Commented] (FLINK-25418) flink任务中指定了dir_cache没网的时候还是会去请求下载python第三方库,t_env.set_python_requirements(dir_requirements, dir_cache)

2021-12-22 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463757#comment-17463757 ] Martijn Visser commented on FLINK-25418: [~yang-y] Please change the contents of this ticket to

[GitHub] [flink] flinkbot edited a comment on pull request #18169: add shutdown hook

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 8e1ab77d8bd4880c495a8a7175d4bf8762fdbc22 Azure:

[GitHub] [flink] JingGe commented on a change in pull request #18014: [FLINK-24857][test][Kafka] Upgrade SourceReaderTestBase t…

2021-12-22 Thread GitBox
JingGe commented on a change in pull request #18014: URL: https://github.com/apache/flink/pull/18014#discussion_r773808379 ## File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testutils/source/reader/SourceReaderTestBase.java

[GitHub] [flink] JingGe commented on pull request #18014: [FLINK-24857][test][Kafka] Upgrade SourceReaderTestBase t…

2021-12-22 Thread GitBox
JingGe commented on pull request #18014: URL: https://github.com/apache/flink/pull/18014#issuecomment-999511852 > @PatrickRen Updated ~ @imaffe The text used in the old JUnit4 should be more like an error msg than description before the test. It should be better to use

[GitHub] [flink] flinkbot edited a comment on pull request #18169: add shutdown hook

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 8e1ab77d8bd4880c495a8a7175d4bf8762fdbc22 Azure:

[jira] [Created] (FLINK-25418) flink任务中指定了dir_cache没网的时候还是会去请求下载python第三方库,t_env.set_python_requirements(dir_requirements, dir_cache)

2021-12-22 Thread yangcai (Jira)
yangcai created FLINK-25418: --- Summary: flink任务中指定了dir_cache没网的时候还是会去请求下载python第三方库,t_env.set_python_requirements(dir_requirements, dir_cache) Key: FLINK-25418 URL: https://issues.apache.org/jira/browse/FLINK-25418

[jira] [Assigned] (FLINK-25341) Improve casting structured type to STRING

2021-12-22 Thread Francesco Guardiani (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Guardiani reassigned FLINK-25341: --- Assignee: Francesco Guardiani > Improve casting structured type to STRING

[GitHub] [flink] flinkbot edited a comment on pull request #18177: [hotfix][connector-files][connector-hive] Move Hive specific configs out of FileSystemConnectorOptions

2021-12-22 Thread GitBox
flinkbot edited a comment on pull request #18177: URL: https://github.com/apache/flink/pull/18177#issuecomment-999499826 ## CI report: * 7b8f265abb6cc2f60bad308db82203bdda85ed50 Azure:

[GitHub] [flink] flinkbot commented on pull request #18177: [hotfix][connector-files][connector-hive] Move Hive specific configs out of FileSystemConnectorOptions

2021-12-22 Thread GitBox
flinkbot commented on pull request #18177: URL: https://github.com/apache/flink/pull/18177#issuecomment-999499826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17598: [FLINK-24703][connectors][formats] Add CSV format support for filesystem based on StreamFormat and BulkWriter interfaces.

2021-12-22 Thread GitBox
slinkydeveloper commented on a change in pull request #17598: URL: https://github.com/apache/flink/pull/17598#discussion_r773813519 ## File path: flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvSerDeSchemaFactory.java ## @@ -0,0 +1,192 @@ +/* + *

<    1   2   3   4   5   6   >