[GitHub] [flink] MartijnVisser commented on pull request #20343: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…

2022-12-14 Thread GitBox
MartijnVisser commented on PR #20343: URL: https://github.com/apache/flink/pull/20343#issuecomment-1351540640 @jaumebecks Yes, but let's not create that right now. We're in the process of externalizing Kafka (see https://github.com/apache/flink-connector-kafka/pull/1) and when that's done,

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2022-12-14 Thread GitBox
1996fanrui commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1048554412 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java: ## @@ -252,4 +252,13 @@ public class

[jira] [Updated] (FLINK-30418) Implement synchronous KinesisClient in EFO

2022-12-14 Thread Daren Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daren Wong updated FLINK-30418: --- Description: h2. What? Use synchronous KinesisClient for consumer

[GitHub] [flink] flinkbot commented on pull request #21511: Delegation token framework refactoring

2022-12-14 Thread GitBox
flinkbot commented on PR #21511: URL: https://github.com/apache/flink/pull/21511#issuecomment-1351819679 ## CI report: * 77ed253a77605fe791ff91b1d53970d4048db018 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] Samrat002 opened a new pull request, #21512: [FLINK-30375][hotfix]sql-client leaks flink-table-planner jar in /tmp

2022-12-14 Thread GitBox
Samrat002 opened a new pull request, #21512: URL: https://github.com/apache/flink/pull/21512 ## What is the purpose of the change sql-client leaks flink-table-planner jar in /tmp. Fix the leak by removing on exists ## Brief change log ## Verifying

[GitHub] [flink] flinkbot commented on pull request #21512: [FLINK-30375][hotfix]sql-client leaks flink-table-planner jar in /tmp

2022-12-14 Thread GitBox
flinkbot commented on PR #21512: URL: https://github.com/apache/flink/pull/21512#issuecomment-1351853606 ## CI report: * 9e620de8466ef61d8cec8224615a15cca2f7bd5c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-24999) flink-python doesn't work on Java 17

2022-12-14 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647527#comment-17647527 ] Yufan Sheng commented on FLINK-24999: - What's the state here? > flink-python doesn't work on Java

[GitHub] [flink] mbalassi merged pull request #21505: [FLINK-30402][security][runtime] Separate token framework generic and hadoop specific parts

2022-12-14 Thread GitBox
mbalassi merged PR #21505: URL: https://github.com/apache/flink/pull/21505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-30422) Generalize token framework provider API

2022-12-14 Thread Gabor Somogyi (Jira)
Gabor Somogyi created FLINK-30422: - Summary: Generalize token framework provider API Key: FLINK-30422 URL: https://issues.apache.org/jira/browse/FLINK-30422 Project: Flink Issue Type:

[jira] [Updated] (FLINK-30383) UseLogicalIdentifier makes datadog consider metric as custom

2022-12-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30383: --- Labels: pull-request-available (was: ) > UseLogicalIdentifier makes datadog consider

[jira] [Commented] (FLINK-30420) NPE thrown when using window time in Table API

2022-12-14 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647614#comment-17647614 ] Sergey Nuyanzin commented on FLINK-30420: - Looks like an old issue I was able to reproduce it

[GitHub] [flink] gaborgsomogyi commented on pull request #21511: Delegation token framework refactoring

2022-12-14 Thread GitBox
gaborgsomogyi commented on PR #21511: URL: https://github.com/apache/flink/pull/21511#issuecomment-1351977066 cc @mbalassi @gyfora @morhidi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-30418) Implement synchronous KinesisClient in EFO

2022-12-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30418: --- Labels: pull-request-available (was: ) > Implement synchronous KinesisClient in EFO >

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #481: [FLINK-30361] Cluster deleted and created back while updating replicas

2022-12-14 Thread GitBox
gyfora merged PR #481: URL: https://github.com/apache/flink-kubernetes-operator/pull/481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-30361) Cluster deleted and created back while updating replicas

2022-12-14 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-30361. -- Fix Version/s: kubernetes-operator-1.4.0 Resolution: Fixed merged to main

[jira] [Updated] (FLINK-30361) Cluster deleted and created back while updating replicas

2022-12-14 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-30361: --- Affects Version/s: kubernetes-operator-1.3.0 > Cluster deleted and created back while updating

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #457: [docs] Add controller flow docs

2022-12-14 Thread GitBox
gyfora merged PR #457: URL: https://github.com/apache/flink-kubernetes-operator/pull/457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-24999) flink-python doesn't work on Java 17

2022-12-14 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647536#comment-17647536 ] Martijn Visser commented on FLINK-24999: [~dianfu] [~hxbks2ks] Is the Java 17 support something

[jira] [Updated] (FLINK-30420) NPE thrown when using window time in Table API

2022-12-14 Thread Jiang Xin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiang Xin updated FLINK-30420: -- Description: Run the following unit test. {code:java} import

[jira] [Updated] (FLINK-30420) NPE thrown when using window time in Table API

2022-12-14 Thread Jiang Xin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiang Xin updated FLINK-30420: -- Description: Run the following unit test. {code:java} import

[jira] [Updated] (FLINK-30375) SqlClient leaks flink-table-planner jar under /tmp

2022-12-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30375: --- Labels: pull-request-available (was: ) > SqlClient leaks flink-table-planner jar under

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #476: [FLINK-30315] Add more information about image pull failures to the operator log

2022-12-14 Thread GitBox
gyfora merged PR #476: URL: https://github.com/apache/flink-kubernetes-operator/pull/476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-30315) Add more information about image pull failures to the operator log

2022-12-14 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-30315. -- Fix Version/s: kubernetes-operator-1.4.0 Resolution: Fixed merged to main

[jira] [Created] (FLINK-30420) NPE thrown when using window time in Table API

2022-12-14 Thread Jiang Xin (Jira)
Jiang Xin created FLINK-30420: - Summary: NPE thrown when using window time in Table API Key: FLINK-30420 URL: https://issues.apache.org/jira/browse/FLINK-30420 Project: Flink Issue Type: Bug

[jira] [Assigned] (FLINK-30422) Generalize token framework provider API

2022-12-14 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi reassigned FLINK-30422: - Assignee: Gabor Somogyi > Generalize token framework provider API >

[jira] [Commented] (FLINK-30375) SqlClient leaks flink-table-planner jar under /tmp

2022-12-14 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647626#comment-17647626 ] Samrat Deb commented on FLINK-30375: I will like to work on this issue  > SqlClient leaks

[jira] [Created] (FLINK-30418) Implement synchronous KinesisClient in EFO

2022-12-14 Thread Daren Wong (Jira)
Daren Wong created FLINK-30418: -- Summary: Implement synchronous KinesisClient in EFO Key: FLINK-30418 URL: https://issues.apache.org/jira/browse/FLINK-30418 Project: Flink Issue Type:

[GitHub] [flink-connector-aws] darenwkt opened a new pull request, #39: [FLINK-30418] Implement synchronous KinesisClient in EFO

2022-12-14 Thread GitBox
darenwkt opened a new pull request, #39: URL: https://github.com/apache/flink-connector-aws/pull/39 Implemented synchronous KinesisClient as described in https://issues.apache.org/jira/browse/FLINK-30418. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] MartijnVisser commented on a diff in pull request #21501: [FLINK-30397][Connector/Pulsar] Remove Pulsar connector

2022-12-14 Thread GitBox
MartijnVisser commented on code in PR #21501: URL: https://github.com/apache/flink/pull/21501#discussion_r1048545657 ## flink-docs/src/main/java/org/apache/flink/docs/util/ConfigurationOptionLocator.java: ## @@ -73,15 +73,6 @@ public class ConfigurationOptionLocator {

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #481: [FLINK-30361] Cluster deleted and created back while updating replicas

2022-12-14 Thread GitBox
gyfora commented on PR #481: URL: https://github.com/apache/flink-kubernetes-operator/pull/481#issuecomment-1351679950 Thank you for the work @swathic95 :) Looks great! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] zentol opened a new pull request, #21510: [FLINK-30383][datadog] Add "flink." prefix to logical identifier

2022-12-14 Thread GitBox
zentol opened a new pull request, #21510: URL: https://github.com/apache/flink/pull/21510 DataDog only considers metrics as coming from Flink if the metric name has "flink" prefix. Otherwise they are considered as custom metrics, governed by different billing rules. This was so far

[GitHub] [flink-connector-jdbc] eskabetxe commented on pull request #3: [FLINK-15462][connectors] Add Trino dialect

2022-12-14 Thread GitBox
eskabetxe commented on PR #3: URL: https://github.com/apache/flink-connector-jdbc/pull/3#issuecomment-1351396885 @MartijnVisser done.. would be great that someone could check this.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (FLINK-30419) Allow tuning of transaction timeout

2022-12-14 Thread Vicky Papavasileiou (Jira)
Vicky Papavasileiou created FLINK-30419: --- Summary: Allow tuning of transaction timeout Key: FLINK-30419 URL: https://issues.apache.org/jira/browse/FLINK-30419 Project: Flink Issue

[jira] [Updated] (FLINK-30413) Drop Shared and Key_Shared subscription support in Pulsar connector

2022-12-14 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yufan Sheng updated FLINK-30413: Summary: Drop Shared and Key_Shared subscription support in Pulsar connector (was: Drop Share

[GitHub] [flink] pnowojski commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2022-12-14 Thread GitBox
pnowojski commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1048286114 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateCheckpointWriter.java: ## @@ -18,280 +18,265 @@ package

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #484: FLIP-271: Autoscaling

2022-12-14 Thread GitBox
gyfora opened a new pull request, #484: URL: https://github.com/apache/flink-kubernetes-operator/pull/484 ## What is the purpose of the change This is the initial implementation of the autoscaler module as described in

[jira] [Commented] (FLINK-28185) "Invalid negative offset" when using OffsetsInitializer.timestamp(.)

2022-12-14 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647105#comment-17647105 ] Martijn Visser commented on FLINK-28185: [~Erbureth] Let's see. Especially given that Flink 1.15

[GitHub] [flink-connector-jdbc] eskabetxe commented on pull request #2: [FLINK-28284] Add JdbcSink with new format

2022-12-14 Thread GitBox
eskabetxe commented on PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#issuecomment-1351401591 @MartijnVisser rebased, but this is blocked @wanglijie95 could give more feedback, but basically we are waiting for a new FLIP to expose ExecutionConfig or isObjectReuseEnabled

[GitHub] [flink] MartijnVisser commented on a diff in pull request #21501: [FLINK-30397][Connector/Pulsar] Remove Pulsar connector

2022-12-14 Thread GitBox
MartijnVisser commented on code in PR #21501: URL: https://github.com/apache/flink/pull/21501#discussion_r1047808521 ## flink-docs/src/main/java/org/apache/flink/docs/util/ConfigurationOptionLocator.java: ## @@ -73,15 +73,6 @@ public class ConfigurationOptionLocator {

[jira] [Created] (FLINK-30421) Move TGT renewal to hadoop module

2022-12-14 Thread Gabor Somogyi (Jira)
Gabor Somogyi created FLINK-30421: - Summary: Move TGT renewal to hadoop module Key: FLINK-30421 URL: https://issues.apache.org/jira/browse/FLINK-30421 Project: Flink Issue Type: Sub-task

[GitHub] [flink] flinkbot commented on pull request #21510: [FLINK-30383][datadog] Add "flink." prefix to logical identifier

2022-12-14 Thread GitBox
flinkbot commented on PR #21510: URL: https://github.com/apache/flink/pull/21510#issuecomment-1351746357 ## CI report: * cfa1b6a4e03781412a3185a42f8dfb4886775711 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] gaborgsomogyi opened a new pull request, #21511: Delegation token framework refactoring

2022-12-14 Thread GitBox
gaborgsomogyi opened a new pull request, #21511: URL: https://github.com/apache/flink/pull/21511 ## What is the purpose of the change These are multiple commits to reach generalized delegation token framework described

[jira] [Commented] (FLINK-30314) Unable to read all records from compressed line-delimited JSON files using Table API

2022-12-14 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647659#comment-17647659 ] Etienne Chauchot commented on FLINK-30314: -- [~dyaraev] I tried to reproduce the behavior you

[jira] [Updated] (FLINK-30418) Implement synchronous KinesisClient in EFO

2022-12-14 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-30418: -- Affects Version/s: (was: aws-connector-4.1.0) > Implement synchronous KinesisClient in

[jira] [Assigned] (FLINK-30418) Implement synchronous KinesisClient in EFO

2022-12-14 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-30418: - Assignee: Daren Wong > Implement synchronous KinesisClient in EFO >

[jira] [Commented] (FLINK-30418) Implement synchronous KinesisClient in EFO

2022-12-14 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647106#comment-17647106 ] Danny Cranmer commented on FLINK-30418: --- Thanks Daren, have assigned to you > Implement

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21498: [FLINK-30392] Replace default thread dump depth to 24

2022-12-14 Thread GitBox
1996fanrui commented on code in PR #21498: URL: https://github.com/apache/flink/pull/21498#discussion_r1048482228 ## docs/layouts/shortcodes/generated/cluster_configuration.html: ## @@ -70,7 +70,7 @@ cluster.thread-dump.stacktrace-max-depth -

[GitHub] [flink] jaumebecks commented on pull request #20343: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…

2022-12-14 Thread GitBox
jaumebecks commented on PR #20343: URL: https://github.com/apache/flink/pull/20343#issuecomment-1351525105 @MartijnVisser it seems @paul8263 is not responding to the requested changes, we may create a similar PR in the following days for fixing this, does that sound good to you? -- This

[jira] [Closed] (FLINK-30402) Separate token framework generic and hadoop specific parts

2022-12-14 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-30402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-30402. -- Fix Version/s: 1.17.0 Resolution: Fixed 4ba3366 in main > Separate token framework

[jira] [Assigned] (FLINK-30421) Move TGT renewal to hadoop module

2022-12-14 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi reassigned FLINK-30421: - Assignee: Gabor Somogyi > Move TGT renewal to hadoop module >

[jira] [Created] (FLINK-30417) Rabbit error is not clear

2022-12-14 Thread Yaron Shani (Jira)
Yaron Shani created FLINK-30417: --- Summary: Rabbit error is not clear Key: FLINK-30417 URL: https://issues.apache.org/jira/browse/FLINK-30417 Project: Flink Issue Type: Improvement

[GitHub] [flink-connector-kafka] MartijnVisser commented on a diff in pull request #1: [FLINK-30052][Connectors/Kafka] Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2022-12-14 Thread GitBox
MartijnVisser commented on code in PR #1: URL: https://github.com/apache/flink-connector-kafka/pull/1#discussion_r1048443842 ## .github/workflows/ci.yml: ## @@ -80,7 +80,7 @@ jobs: run: wget -q -c ${{ inputs.flink_url }} -O - | tar -xz - name: Compile and

[GitHub] [flink-connector-jdbc] MartijnVisser commented on pull request #4: [FLINK-29750][Connector/JDBC] Improve PostgresCatalog#listTables() by reusing resources

2022-12-14 Thread GitBox
MartijnVisser commented on PR #4: URL: https://github.com/apache/flink-connector-jdbc/pull/4#issuecomment-1351324792 @liuml07 Could you please rebase? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink-connector-jdbc] MartijnVisser commented on pull request #3: [FLINK-15462][connectors] Add Trino dialect

2022-12-14 Thread GitBox
MartijnVisser commented on PR #3: URL: https://github.com/apache/flink-connector-jdbc/pull/3#issuecomment-1351324229 @eskabetxe It's probably also smart to rebase this one :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink-connector-jdbc] MartijnVisser commented on pull request #2: [FLINK-28284] Add JdbcSink with new format

2022-12-14 Thread GitBox
MartijnVisser commented on PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#issuecomment-1351323750 @eskabetxe Could you rebase? The architecture tests have now been added and it would be good to check that the new sink properly implements these -- This is an automated

[GitHub] [flink] smulikHakipod opened a new pull request, #21509: [FLINK-30417] [Connectors/ RabbitMQ] add "RabbitMQ" to rabbit error while creating the channel

2022-12-14 Thread GitBox
smulikHakipod opened a new pull request, #21509: URL: https://github.com/apache/flink/pull/21509 Jira: https://issues.apache.org/jira/browse/FLINK-30417 ## What is the purpose of the change To better describe the error of RabbitMQ connection failures. ##

[jira] [Updated] (FLINK-30417) Rabbit error is not clear

2022-12-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30417: --- Labels: pull-request-available (was: ) > Rabbit error is not clear >

[jira] [Commented] (FLINK-30417) Rabbit error is not clear

2022-12-14 Thread Yaron Shani (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647096#comment-17647096 ] Yaron Shani commented on FLINK-30417: - https://github.com/apache/flink/pull/21509 > Rabbit error is

[GitHub] [flink] flinkbot commented on pull request #21509: [FLINK-30417] [Connectors/ RabbitMQ] add "RabbitMQ" to rabbit error while creating the channel

2022-12-14 Thread GitBox
flinkbot commented on PR #21509: URL: https://github.com/apache/flink/pull/21509#issuecomment-1351334793 ## CI report: * c3c666f2575ae9912614978d12dd6205a5c4bee6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] MartijnVisser closed pull request #21509: [FLINK-30417] [Connectors/ RabbitMQ] add "RabbitMQ" to rabbit error while creating the channel

2022-12-14 Thread GitBox
MartijnVisser closed pull request #21509: [FLINK-30417] [Connectors/ RabbitMQ] add "RabbitMQ" to rabbit error while creating the channel URL: https://github.com/apache/flink/pull/21509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] MartijnVisser commented on pull request #21509: [FLINK-30417] [Connectors/ RabbitMQ] add "RabbitMQ" to rabbit error while creating the channel

2022-12-14 Thread GitBox
MartijnVisser commented on PR #21509: URL: https://github.com/apache/flink/pull/21509#issuecomment-1351335361 @smulikHakipod Please redirect this PR to https://github.com/apache/flink-connector-rabbitmq as connectors are being externalized -- This is an automated message from the Apache

[jira] [Assigned] (FLINK-30417) RabbitMQ error is not clear

2022-12-14 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-30417: -- Assignee: Yaron Shani > RabbitMQ error is not clear > --- >

[jira] [Updated] (FLINK-30417) RabbitMQ error is not clear

2022-12-14 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30417: --- Summary: RabbitMQ error is not clear (was: Rabbit error is not clear) > RabbitMQ error is

[GitHub] [flink-connector-rabbitmq] smulikHakipod opened a new pull request, #4: Add "RabbitMQ" to the error while creating the channel and failing

2022-12-14 Thread GitBox
smulikHakipod opened a new pull request, #4: URL: https://github.com/apache/flink-connector-rabbitmq/pull/4 Related to https://github.com/apache/flink/pull/21509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink-connector-rabbitmq] boring-cyborg[bot] commented on pull request #4: Add "RabbitMQ" to the error while creating the channel and failing

2022-12-14 Thread GitBox
boring-cyborg[bot] commented on PR #4: URL: https://github.com/apache/flink-connector-rabbitmq/pull/4#issuecomment-1351342984 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[GitHub] [flink-connector-rabbitmq] smulikHakipod closed pull request #4: [FLINK-30417] [Connectors/ RabbitMQ] add "RabbitMQ" to rabbit error while creating the channel

2022-12-14 Thread GitBox
smulikHakipod closed pull request #4: [FLINK-30417] [Connectors/ RabbitMQ] add "RabbitMQ" to rabbit error while creating the channel URL: https://github.com/apache/flink-connector-rabbitmq/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink-kubernetes-operator] pvary commented on a diff in pull request #476: [FLINK-30315] Add more information about image pull failures to the operator log

2022-12-14 Thread GitBox
pvary commented on code in PR #476: URL: https://github.com/apache/flink-kubernetes-operator/pull/476#discussion_r1048461390 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java: ## @@ -297,88 +297,10 @@

[GitHub] [flink] smulikHakipod commented on pull request #21509: [FLINK-30417] [Connectors/ RabbitMQ] add "RabbitMQ" to rabbit error while creating the channel

2022-12-14 Thread GitBox
smulikHakipod commented on PR #21509: URL: https://github.com/apache/flink/pull/21509#issuecomment-1351345317 https://github.com/apache/flink-connector-rabbitmq/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (FLINK-28185) "Invalid negative offset" when using OffsetsInitializer.timestamp(.)

2022-12-14 Thread Jan Kriho (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647100#comment-17647100 ] Jan Kriho commented on FLINK-28185: --- Hi, could you please backport the fix to 1.15 & 1.16 series? As

[GitHub] [flink-table-store] zjureel commented on a diff in pull request #423: [FLINK-27844] Support column type evolution in file meta

2022-12-14 Thread GitBox
zjureel commented on code in PR #423: URL: https://github.com/apache/flink-table-store/pull/423#discussion_r1049126191 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/DataValueConverter.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache

[jira] [Closed] (FLINK-29767) Adaptive batch scheduler supports hybrid shuffle

2022-12-14 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-29767. Fix Version/s: 1.17.0 Resolution: Done master (1.17):

[GitHub] [flink] xintongsong closed pull request #21199: [FLINK-29767] Adaptive batch scheduler supports hybrid shuffle

2022-12-14 Thread GitBox
xintongsong closed pull request #21199: [FLINK-29767] Adaptive batch scheduler supports hybrid shuffle URL: https://github.com/apache/flink/pull/21199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] Myracle commented on pull request #21347: [FLINK-29640][Client/Job Submission]Enhance the function configured by execution.shutdown-on-attached-exi…

2022-12-14 Thread GitBox
Myracle commented on PR #21347: URL: https://github.com/apache/flink/pull/21347#issuecomment-1352472772 @xintongsong Have a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-16024) support filter pushdown in jdbc connector

2022-12-14 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li updated FLINK-16024: --- Fix Version/s: (was: 1.16.1) > support filter pushdown in jdbc connector >

[GitHub] [flink] gyfora commented on pull request #21511: Delegation token framework refactoring

2022-12-14 Thread GitBox
gyfora commented on PR #21511: URL: https://github.com/apache/flink/pull/21511#issuecomment-1352038862 Thanks Gabor, will look at this tomorrow! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink-connector-jdbc] liuml07 commented on pull request #4: [FLINK-29750][Connector/JDBC] Improve PostgresCatalog#listTables() by reusing resources

2022-12-14 Thread GitBox
liuml07 commented on PR #4: URL: https://github.com/apache/flink-connector-jdbc/pull/4#issuecomment-1352374675 I found the `git fetch origin main && git rebase origin/main` has no conflicts. I just rebased and it still builds locally. -- This is an automated message from the Apache Git

[GitHub] [flink] xintongsong commented on pull request #21199: [FLINK-29767] Adaptive batch scheduler supports hybrid shuffle

2022-12-14 Thread GitBox
xintongsong commented on PR #21199: URL: https://github.com/apache/flink/pull/21199#issuecomment-1352467803 @zhuzhurk, thanks for reviewing. Merging this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (FLINK-28185) "Invalid negative offset" when using OffsetsInitializer.timestamp(.)

2022-12-14 Thread Jan Kriho (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647679#comment-17647679 ] Jan Kriho commented on FLINK-28185: --- [~martijnvisser] For what it's worth, I have checked the code,

[jira] [Commented] (FLINK-26088) Add Elasticsearch 8.0 support

2022-12-14 Thread Matheus Felisberto (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647787#comment-17647787 ] Matheus Felisberto commented on FLINK-26088: Hi guys, I have been working on an

[jira] (FLINK-26088) Add Elasticsearch 8.0 support

2022-12-14 Thread Matheus Felisberto (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26088 ] Matheus Felisberto deleted comment on FLINK-26088: was (Author: JIRAUSER298391): Hi guys, I have been working on an implementation that supports Elasticsearch v8 because of a

[jira] [Comment Edited] (FLINK-16024) support filter pushdown in jdbc connector

2022-12-14 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627632#comment-17627632 ] Benchao Li edited comment on FLINK-16024 at 12/15/22 1:56 AM: -- Fixed via

[GitHub] [flink-connector-pulsar] dependabot[bot] opened a new pull request, #6: Bump snakeyaml from 1.31 to 1.32

2022-12-14 Thread GitBox
dependabot[bot] opened a new pull request, #6: URL: https://github.com/apache/flink-connector-pulsar/pull/6 [![Dependabot compatibility

[GitHub] [flink] LadyForest commented on pull request #21507: [FLINK-30386] Fix the issue that column constraint lacks primary key not enforced check

2022-12-14 Thread GitBox
LadyForest commented on PR #21507: URL: https://github.com/apache/flink/pull/21507#issuecomment-1352387719 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-16024) support filter pushdown in jdbc connector

2022-12-14 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647772#comment-17647772 ] Benchao Li commented on FLINK-16024: [~martijnvisser] According to the Jira comment email, 1.16.1

[jira] [Created] (FLINK-30423) Introduce cast executor codegen for column type evolution

2022-12-14 Thread Shammon (Jira)
Shammon created FLINK-30423: --- Summary: Introduce cast executor codegen for column type evolution Key: FLINK-30423 URL: https://issues.apache.org/jira/browse/FLINK-30423 Project: Flink Issue Type:

[jira] [Commented] (FLINK-26088) Add Elasticsearch 8.0 support

2022-12-14 Thread Matheus Felisberto (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647789#comment-17647789 ] Matheus Felisberto commented on FLINK-26088: Hi guys, I have been working on an

[jira] [Comment Edited] (FLINK-26088) Add Elasticsearch 8.0 support

2022-12-14 Thread Matheus Felisberto (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647789#comment-17647789 ] Matheus Felisberto edited comment on FLINK-26088 at 12/15/22 1:39 AM:

[jira] [Created] (FLINK-30424) Add source operator restore readerState log to distinguish split is from newPartitions or split state

2022-12-14 Thread Ran Tao (Jira)
Ran Tao created FLINK-30424: --- Summary: Add source operator restore readerState log to distinguish split is from newPartitions or split state Key: FLINK-30424 URL: https://issues.apache.org/jira/browse/FLINK-30424

[jira] [Updated] (FLINK-30410) Rename 'full' to 'latest-full' and 'compacted' to 'compacted-full' for scan.mode in Table Store

2022-12-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30410: --- Labels: pull-request-available (was: ) > Rename 'full' to 'latest-full' and 'compacted' to

[GitHub] [flink-table-store] tsreaper opened a new pull request, #439: [FLINK-30410] Rename 'full' to 'latest-full' and 'compacted' to 'compacted-full' for scan.mode in Table Store

2022-12-14 Thread GitBox
tsreaper opened a new pull request, #439: URL: https://github.com/apache/flink-table-store/pull/439 As discussed in the [dev mailing list](https://lists.apache.org/thread/t76f0ofl6k7mlvqotp57ot10x8o1x90p), we're going to rename some values for `scan.mode` in Table Store.

[jira] [Updated] (FLINK-30424) Add source operator restore readerState log to distinguish split is from newPartitions or split state

2022-12-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30424: --- Labels: pull-request-available (was: ) > Add source operator restore readerState log to

[GitHub] [flink] carp84 commented on pull request #21508: [FLINK-30128] Introduce Azure Data Lake Gen2 APIs in the Hadoop Recoverable path

2022-12-14 Thread GitBox
carp84 commented on PR #21508: URL: https://github.com/apache/flink/pull/21508#issuecomment-1352600177 Thanks for the contribution @ramkrish86 . @xintongsong could you help review this one since you have experience reviewing similar support for Google storage FS (PR#15599)? Many

[jira] [Commented] (FLINK-30246) Registering the same metric object with different name and group will conflict in metric reporter

2022-12-14 Thread xingbe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647870#comment-17647870 ] xingbe commented on FLINK-30246: I found that the access level of maps in AbstractReporter is protected,

[jira] [Commented] (FLINK-30424) Add source operator restore readerState log to distinguish split is from newPartitions or split state

2022-12-14 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647874#comment-17647874 ] Ran Tao commented on FLINK-30424: - [~becket_qin]  can u help me to review this pr? > Add source

[GitHub] [flink-connector-jdbc] EchoLee5 commented on pull request #5: [FLINK-30371][Connector/JDBC] Fix the problem of JdbcOutputFormat database connection leak

2022-12-14 Thread GitBox
EchoLee5 commented on PR #5: URL: https://github.com/apache/flink-connector-jdbc/pull/5#issuecomment-1352588573 > @EchoLee5 Thanks for the PR, is it possible to add a test for this? I have added test cases, please help me review the code again, thank you. -- This is an automated

[jira] [Commented] (FLINK-28185) "Invalid negative offset" when using OffsetsInitializer.timestamp(.)

2022-12-14 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647864#comment-17647864 ] Mason Chen commented on FLINK-28185: Yup this is easily backported since we decided to defer the

[GitHub] [flink] xintongsong commented on pull request #21508: [FLINK-30128] Introduce Azure Data Lake Gen2 APIs in the Hadoop Recoverable path

2022-12-14 Thread GitBox
xintongsong commented on PR #21508: URL: https://github.com/apache/flink/pull/21508#issuecomment-1352602522 Sure. I'll try to take a look asap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] chucheng92 opened a new pull request, #21513: [FLINK-30424][streaming] Add source operator addSplits log when restore from state

2022-12-14 Thread GitBox
chucheng92 opened a new pull request, #21513: URL: https://github.com/apache/flink/pull/21513 ## What is the purpose of the change If source recover from state, we can not distinguish the newPartitions is from timed discover thread or from reader task state. So add recover log to

[jira] [Updated] (FLINK-30424) Add source operator restore readerState log to distinguish split is from newPartitions or split state

2022-12-14 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ran Tao updated FLINK-30424: Description: When a job start firstly, we can find 'assignPartitions' from log。but if source recover

[GitHub] [flink] flinkbot commented on pull request #21513: [FLINK-30424][streaming] Add source operator addSplits log when restore from state

2022-12-14 Thread GitBox
flinkbot commented on PR #21513: URL: https://github.com/apache/flink/pull/21513#issuecomment-1352576672 ## CI report: * c8d4b98e6581e9c41a7aec3673a6073e40330285 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

  1   2   >