[GitHub] [flink] XComp commented on pull request #22572: [FLINK-29618] Remove Timeout annotation in YARNSessionFIFOSecuredITCase

2023-05-11 Thread via GitHub
XComp commented on PR #22572: URL: https://github.com/apache/flink/pull/22572#issuecomment-1545210878 I guess, we could, at least, remove the `@Timeout` from the related `YarnSessionFIFOITCase` as well. WDYT? And what about touching the other tests in `flink-yarn-tests`? Could you check

[GitHub] [flink] XComp commented on a diff in pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…

2023-05-11 Thread via GitHub
XComp commented on code in PR #21971: URL: https://github.com/apache/flink/pull/21971#discussion_r1191934305 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenTableSource.java: ## @@ -93,4 +93,9 @@ public ChangelogMode

[jira] [Commented] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-05-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722017#comment-17722017 ] Sergey Nuyanzin commented on FLINK-30629: -

[jira] [Closed] (FLINK-32054) ElasticsearchSinkITCase.testElasticsearchSink fails on AZP

2023-05-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-32054. --- Resolution: Won't Fix > ElasticsearchSinkITCase.testElasticsearchSink fails on AZP >

[jira] [Commented] (FLINK-32054) ElasticsearchSinkITCase.testElasticsearchSink fails on AZP

2023-05-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722015#comment-17722015 ] Sergey Nuyanzin commented on FLINK-32054: - yes, probably you're right at least log the issue I

[jira] [Commented] (FLINK-25909) Move HBase token obtain functionality into HBaseDelegationTokenProvider

2023-05-11 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722009#comment-17722009 ] Lijie Wang commented on FLINK-25909: Change log level to DEBUG: master:

[GitHub] [flink] wanglijie95 closed pull request #22559: [hotfix][runtime][security] Change the log level to DEBUG in HBaseDelegationTokenProvider#getHBaseConfiguration

2023-05-11 Thread via GitHub
wanglijie95 closed pull request #22559: [hotfix][runtime][security] Change the log level to DEBUG in HBaseDelegationTokenProvider#getHBaseConfiguration URL: https://github.com/apache/flink/pull/22559 -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Comment Edited] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721999#comment-17721999 ] Lijie Wang edited comment on FLINK-31706 at 5/12/23 3:59 AM: - Thanks for

[jira] [Commented] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721999#comment-17721999 ] Lijie Wang commented on FLINK-31706: Thanks for your attention and effort, but we cannot do it now,

[GitHub] [flink] xintongsong commented on a diff in pull request #22352: [FLINK-31639][network] Introduce tiered store memory manager

2023-05-11 Thread via GitHub
xintongsong commented on code in PR #22352: URL: https://github.com/apache/flink/pull/22352#discussion_r1191854430 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManagerImpl.java: ## @@ -0,0 +1,117 @@ +/* +

[jira] [Commented] (FLINK-32053) Introduce StateMetadata to ExecNode to support configure operator-level state TTL via CompiledPlan

2023-05-11 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721994#comment-17721994 ] Jane Chan commented on FLINK-32053: --- Wait for FLINK-32064 to be merged > Introduce StateMetadata to

[jira] [Assigned] (FLINK-32064) Add subdirectory of test output file for JsonPlanTest to indicate the plan's version

2023-05-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia reassigned FLINK-32064: Assignee: Jane Chan > Add subdirectory of test output file for JsonPlanTest to indicate the

[jira] [Resolved] (FLINK-31876) [JUnit5 Migration] Module: flink-queryable-state

2023-05-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo resolved FLINK-31876. Fix Version/s: 1.18.0 Resolution: Done > [JUnit5 Migration] Module: flink-queryable-state

[jira] [Comment Edited] (FLINK-31876) [JUnit5 Migration] Module: flink-queryable-state

2023-05-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716954#comment-17716954 ] Weijie Guo edited comment on FLINK-31876 at 5/12/23 3:05 AM: - master(1.18)

[jira] [Updated] (FLINK-29618) YARNSessionFIFOSecuredITCase.testDetachedMode timed out in Azure CI

2023-05-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29618: --- Labels: pull-request-available starter test-stability (was: starter test-stability) >

[GitHub] [flink] fredia commented on pull request #22457: [FLINK-31876][QS] Migrate flink-queryable-state-runtime tests to JUnit5

2023-05-11 Thread via GitHub
fredia commented on PR #22457: URL: https://github.com/apache/flink/pull/22457#issuecomment-1545030267 @reswqa CI turns green, but the result is not synchronized to flinkbot, could you help merge it? thanks.

[GitHub] [flink] dianfu commented on pull request #22571: [FLINK-32056][Python][Connector/Pulsar] Upgrade flink-connector-pulsar in flink-python to v4.0.0

2023-05-11 Thread via GitHub
dianfu commented on PR #22571: URL: https://github.com/apache/flink/pull/22571#issuecomment-1545020164 I noticed that the documentation of 1.17 has already been updated to 4.0.0-1.17, see more details on

[GitHub] [flink] xuzhiwen1255 commented on a diff in pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…

2023-05-11 Thread via GitHub
xuzhiwen1255 commented on code in PR #21971: URL: https://github.com/apache/flink/pull/21971#discussion_r1191834141 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenTableSource.java: ## @@ -93,4 +93,9 @@ public

[jira] [Commented] (FLINK-31967) SQL with LAG function NullPointerException

2023-05-11 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721969#comment-17721969 ] Shengkai Fang commented on FLINK-31967: --- [~padavan] Sure. There will be a PR to fix this soon.  >

[jira] [Comment Edited] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957 ] xiaochen zhou edited comment on FLINK-31706 at 5/12/23 12:26 AM: - I am

[jira] [Comment Edited] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957 ] xiaochen zhou edited comment on FLINK-31706 at 5/12/23 12:26 AM: - I am

[jira] [Comment Edited] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957 ] xiaochen zhou edited comment on FLINK-31706 at 5/12/23 12:24 AM: - I am

[jira] [Comment Edited] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957 ] xiaochen zhou edited comment on FLINK-31706 at 5/12/23 12:24 AM: - I am

[jira] [Comment Edited] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957 ] xiaochen zhou edited comment on FLINK-31706 at 5/12/23 12:24 AM: - I am

[jira] [Comment Edited] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957 ] xiaochen zhou edited comment on FLINK-31706 at 5/12/23 12:23 AM: - I am

[jira] [Comment Edited] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957 ] xiaochen zhou edited comment on FLINK-31706 at 5/12/23 12:22 AM: - I am

[jira] [Comment Edited] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957 ] xiaochen zhou edited comment on FLINK-31706 at 5/12/23 12:22 AM: - I am

[jira] [Commented] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957 ] xiaochen zhou commented on FLINK-31706: --- I am currently implementing the use `paralleism.default`

[jira] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31706 ] xiaochen zhou deleted comment on FLINK-31706: --- was (Author: zxcoccer): I am currently implementing the use `paralleism.default` instread of the

[jira] [Commented] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721956#comment-17721956 ] xiaochen zhou commented on FLINK-31706: --- I am currently implementing the use `paralleism.default`

[jira] [Commented] (FLINK-31967) SQL with LAG function NullPointerException

2023-05-11 Thread padavan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721936#comment-17721936 ] padavan commented on FLINK-31967: - [~fsk119] with Integer work.  I think it is at least unexpected

[GitHub] [flink] zentol commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

2023-05-11 Thread via GitHub
zentol commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1191632889 ## tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/optional/ShadeOptionalChecker.java: ## @@ -0,0 +1,266 @@ +/* + * Licensed to the Apache Software

[jira] [Closed] (FLINK-31934) Remove mocking in RocksDB tests

2023-05-11 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-31934. Resolution: Fixed master: 2d873629b43ec7339850b685833e3404d5ae824a > Remove mocking in

[GitHub] [flink] zentol merged pull request #22484: [FLINK-31934][rocksdb][tests] Remove mocking

2023-05-11 Thread via GitHub
zentol merged PR #22484: URL: https://github.com/apache/flink/pull/22484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-31913) sql-client.sh does not respect env.java.opts.all/client

2023-05-11 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-31913. Resolution: Fixed master: 49a5810f0eafad277f81c652435842e65b632169 > sql-client.sh does

[GitHub] [flink] zentol merged pull request #22475: [FLINK-31913][sql] SQL client respects env.java.opts.client

2023-05-11 Thread via GitHub
zentol merged PR #22475: URL: https://github.com/apache/flink/pull/22475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #22571: [FLINK-32056][Python][Connector/Pulsar] Upgrade flink-connector-pulsar in flink-python to v4.0.0

2023-05-11 Thread via GitHub
flinkbot commented on PR #22571: URL: https://github.com/apache/flink/pull/22571#issuecomment-1544498302 ## CI report: * e142db78820c242c71c56fafecedc9e9bdadb7f7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32056) Update the used Pulsar connector in flink-python to 4.0.0

2023-05-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32056: --- Labels: pull-request-available (was: ) > Update the used Pulsar connector in flink-python

[GitHub] [flink] MartijnVisser opened a new pull request, #22571: [FLINK-32056][Python][Connector/Pulsar] Upgrade flink-connector-pulsar in flink-python to v4.0.0

2023-05-11 Thread via GitHub
MartijnVisser opened a new pull request, #22571: URL: https://github.com/apache/flink/pull/22571 ## What is the purpose of the change * Upgrade used `flink-connector-pulsar` in `flink-python` to 4.0.0, since that's compatible with Flink 1.17+. Without this upgrade, we can't upgrade

[GitHub] [flink-connector-mongodb] boring-cyborg[bot] commented on pull request #7: [FLINK-32024][docs] Short code related to externalized connector retr…

2023-05-11 Thread via GitHub
boring-cyborg[bot] commented on PR #7: URL: https://github.com/apache/flink-connector-mongodb/pull/7#issuecomment-1544433289 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[GitHub] [flink-connector-aws] reswqa opened a new pull request, #74: [FLINK-32024][docs] Short code related to externalized connector retrieve version from its own data yaml

2023-05-11 Thread via GitHub
reswqa opened a new pull request, #74: URL: https://github.com/apache/flink-connector-aws/pull/74 Backport FLINK-32024 to `v4.1` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-connector-aws] reswqa opened a new pull request, #73: [FLINK-32024][docs] Short code related to externalized connector retrieve version from its own data yaml

2023-05-11 Thread via GitHub
reswqa opened a new pull request, #73: URL: https://github.com/apache/flink-connector-aws/pull/73 ## Purpose of the change * Short code related to externalized connector retrieve version from its own data yaml.* ## Verifying this change This change is a trivial rework /

[GitHub] [flink-connector-rabbitmq] reswqa opened a new pull request, #13: [BP-3.0][FLINK-32024][docs] Short code related to externalized connector retrieve version from its own data yaml

2023-05-11 Thread via GitHub
reswqa opened a new pull request, #13: URL: https://github.com/apache/flink-connector-rabbitmq/pull/13 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-connector-rabbitmq] reswqa opened a new pull request, #12: [FLINK-32024][docs] Short code related to externalized connector retrieve version from its own data yaml

2023-05-11 Thread via GitHub
reswqa opened a new pull request, #12: URL: https://github.com/apache/flink-connector-rabbitmq/pull/12 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (FLINK-29533) Add proper table style to Flink website

2023-05-11 Thread Sakshi Sharma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721853#comment-17721853 ] Sakshi Sharma commented on FLINK-29533: --- Thank you so much. Will definitely take a look at the

[GitHub] [flink-connector-pulsar] reswqa opened a new pull request, #49: [BP-3.0][FLINK-32024][docs] Short code related to externalized connector retrieve version from its own data yaml

2023-05-11 Thread via GitHub
reswqa opened a new pull request, #49: URL: https://github.com/apache/flink-connector-pulsar/pull/49 Backport FLINK-32024 to `v3.0` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-connector-pulsar] reswqa opened a new pull request, #48: [FLINK-32024][docs] Short code related to externalized connector retrieve version from its own data yaml

2023-05-11 Thread via GitHub
reswqa opened a new pull request, #48: URL: https://github.com/apache/flink-connector-pulsar/pull/48 ## Purpose of the change *As Title* ## Brief change log - *Remove the version parameter from `shortcode`.* - *Add version info to `pulsar.yml`.* ## Verifying

[GitHub] [flink-connector-aws] hlteoh37 commented on a diff in pull request #49: [FLINK-24438] Add Kinesis connector using FLIP-27

2023-05-11 Thread via GitHub
hlteoh37 commented on code in PR #49: URL: https://github.com/apache/flink-connector-aws/pull/49#discussion_r1191432157 ## flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/enumerator/assigner/HashShardAssigner.java: ## @@ -0,0 +1,38

[GitHub] [flink-connector-jdbc] reswqa opened a new pull request, #47: [FLINK-32024][docs] Short code related to externalized connector retr…

2023-05-11 Thread via GitHub
reswqa opened a new pull request, #47: URL: https://github.com/apache/flink-connector-jdbc/pull/47 …ieve version from its own data yaml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-connector-jdbc] reswqa opened a new pull request, #48: [BP-3.0][FLINK-32024][docs] Short code related to externalized connector retr…

2023-05-11 Thread via GitHub
reswqa opened a new pull request, #48: URL: https://github.com/apache/flink-connector-jdbc/pull/48 …ieve version from its own data yaml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (FLINK-32014) Cassandra source documentation is missing and javadoc is out of sync

2023-05-11 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Etienne Chauchot resolved FLINK-32014. -- Fix Version/s: 1.18.0 Resolution: Fixed > Cassandra source documentation is

[GitHub] [flink-connector-hbase] reswqa opened a new pull request, #11: [BP-3.0][FLINK-32024][docs] Short code related to externalized connector retrieve version from its own data yaml

2023-05-11 Thread via GitHub
reswqa opened a new pull request, #11: URL: https://github.com/apache/flink-connector-hbase/pull/11 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-connector-hbase] reswqa opened a new pull request, #10: [FLINK-32024][docs] Short code related to externalized connector retrieve version from its own data yaml

2023-05-11 Thread via GitHub
reswqa opened a new pull request, #10: URL: https://github.com/apache/flink-connector-hbase/pull/10 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (FLINK-32047) Fix args in JobSpec not being passed through to Flink in Standalone mode - 1.4.0

2023-05-11 Thread Usamah Jassat (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721834#comment-17721834 ] Usamah Jassat commented on FLINK-32047: --- I can look into it > Fix args in JobSpec not being

[GitHub] [flink-connector-cassandra] echauchot merged pull request #15: [FLINK-32014][doc][hotfix] Add Cassandra source documentation to website

2023-05-11 Thread via GitHub
echauchot merged PR #15: URL: https://github.com/apache/flink-connector-cassandra/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] RyanSkraba commented on a diff in pull request #22010: [FLINK-31192][connectors/dataGen] Fix dataGen takes too long to initi…

2023-05-11 Thread via GitHub
RyanSkraba commented on code in PR #22010: URL: https://github.com/apache/flink/pull/22010#discussion_r1191359995 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/SequenceGenerator.java: ## @@ -65,33 +72,46 @@ public void open(

[GitHub] [flink-connector-gcp-pubsub] reswqa opened a new pull request, #9: [BP-3.0][FLINK-32024][docs] Short code related to externalized connector retrieve version from its own data yaml

2023-05-11 Thread via GitHub
reswqa opened a new pull request, #9: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/9 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-connector-gcp-pubsub] reswqa opened a new pull request, #8: [FLINK-32024][docs] Short code related to externalized connector retrieve version from its own data yaml

2023-05-11 Thread via GitHub
reswqa opened a new pull request, #8: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/8 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] LadyForest commented on a diff in pull request #22539: [FLINK-31956][table] Extend the CompiledPlan to read from/write to Fl…

2023-05-11 Thread via GitHub
LadyForest commented on code in PR #22539: URL: https://github.com/apache/flink/pull/22539#discussion_r1191301752 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/CompiledPlan.java: ## @@ -109,6 +109,8 @@ default void writeToFile(File file) {

[GitHub] [flink] XComp commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

2023-05-11 Thread via GitHub
XComp commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1191307099 ## tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/optional/ShadeOptionalChecker.java: ## @@ -0,0 +1,266 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] flinkbot commented on pull request #22570: [FLINK-32064][table-planner] Add subdirectory of test output file for JsonPlanTest to indicate the plan's version

2023-05-11 Thread via GitHub
flinkbot commented on PR #22570: URL: https://github.com/apache/flink/pull/22570#issuecomment-1544129227 ## CI report: * dc25ba1c1d35f84b0164615d022e997ca94d1d03 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32064) Add subdirectory of test output file for JsonPlanTest to indicate the plan's version

2023-05-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32064: --- Labels: pull-request-available (was: ) > Add subdirectory of test output file for

[GitHub] [flink] LadyForest opened a new pull request, #22570: [FLINK-32064][table-planner] Add subdirectory of test output file for JsonPlanTest to indicate the plan's version

2023-05-11 Thread via GitHub
LadyForest opened a new pull request, #22570: URL: https://github.com/apache/flink/pull/22570 ## What is the purpose of the change This PR is a refactor for all JsonPlanTest, as preparation for upgrading some ExecNodes to version 2. ## Brief change log - Add a

[jira] [Commented] (FLINK-32038) OffsetCommitMode.Kafka_periodic with checkpointing enabled

2023-05-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721809#comment-17721809 ] Martijn Visser commented on FLINK-32038: Changing default behavior would be a breaking change

[jira] [Updated] (FLINK-32064) Add subdirectory of test output file for JsonPlanTest to indicate the plan's version

2023-05-11 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-32064: -- Summary: Add subdirectory of test output file for JsonPlanTest to indicate the plan's version (was:

[jira] [Updated] (FLINK-32064) Add sub-directory of test output file for JsonPlanTest to indicate the plan's version

2023-05-11 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-32064: -- Description: This is a preparation for upgrading some ExecNodes(which translate to stateful

[jira] [Updated] (FLINK-32064) Add sub-directory of test output file for JsonPlanTest to indicate the plan's version

2023-05-11 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-32064: -- Description: This is a preparation for upgrade ExecNode version to 2 > Add sub-directory of test

[jira] [Created] (FLINK-32064) Add sub-directory of test output file for JsonPlanTest to indicate the plan's version

2023-05-11 Thread Jane Chan (Jira)
Jane Chan created FLINK-32064: - Summary: Add sub-directory of test output file for JsonPlanTest to indicate the plan's version Key: FLINK-32064 URL: https://issues.apache.org/jira/browse/FLINK-32064

[jira] [Reopened] (FLINK-32038) OffsetCommitMode.Kafka_periodic with checkpointing enabled

2023-05-11 Thread Pritam Agarwala (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pritam Agarwala reopened FLINK-32038: - > OffsetCommitMode.Kafka_periodic with checkpointing enabled >

[GitHub] [flink] zentol commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

2023-05-11 Thread via GitHub
zentol commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1191232405 ## tools/ci/flink-ci-tools/src/test/java/org/apache/flink/tools/ci/optional/ShadeOptionalCheckerTest.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-31963) java.lang.ArrayIndexOutOfBoundsException when scaling down with unaligned checkpoints

2023-05-11 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721788#comment-17721788 ] Stefan Richter commented on FLINK-31963: I have a local reproducer as well as a fix, will open a

[GitHub] [flink] MartijnVisser commented on a diff in pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0

2023-05-11 Thread via GitHub
MartijnVisser commented on code in PR #22546: URL: https://github.com/apache/flink/pull/22546#discussion_r1191208612 ## pom.xml: ## @@ -122,8 +122,8 @@ under the License. 4 true -XX:+UseG1GC -Xms256m - 16.1 -

[jira] [Commented] (FLINK-32047) Fix args in JobSpec not being passed through to Flink in Standalone mode - 1.4.0

2023-05-11 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721784#comment-17721784 ] Gyula Fora commented on FLINK-32047: cc[~darenwkt] [~usamj] have you encountered this? > Fix args

[jira] [Commented] (FLINK-32047) Fix args in JobSpec not being passed through to Flink in Standalone mode - 1.4.0

2023-05-11 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721782#comment-17721782 ] Gyula Fora commented on FLINK-32047: If you have time and can work on this, I would be happy to to

[GitHub] [flink-playgrounds] alpinegizmo commented on pull request #42: Create flink_data volume for operations playground.

2023-05-11 Thread via GitHub
alpinegizmo commented on PR #42: URL: https://github.com/apache/flink-playgrounds/pull/42#issuecomment-1544024557 Apologies; I think you're right. I was thinking that the playground docs instruct the user to manipulate the savepoint directly on their computer -- but they don't, and for

[jira] [Commented] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721776#comment-17721776 ] Lijie Wang commented on FLINK-31706: I think it's a good idea to use {{paralleism.default}} instread

[jira] [Commented] (FLINK-31963) java.lang.ArrayIndexOutOfBoundsException when scaling down with unaligned checkpoints

2023-05-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721777#comment-17721777 ] Piotr Nowojski commented on FLINK-31963: We have managed to reproduce and find the bug. Thank

[jira] [Assigned] (FLINK-31963) java.lang.ArrayIndexOutOfBoundsException when scaling down with unaligned checkpoints

2023-05-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-31963: -- Assignee: Stefan Richter > java.lang.ArrayIndexOutOfBoundsException when scaling

[GitHub] [flink] echauchot commented on pull request #22527: [FLINK-31749][hotfix][doc] Update Hadoop formats datastream doc

2023-05-11 Thread via GitHub
echauchot commented on PR #22527: URL: https://github.com/apache/flink/pull/22527#issuecomment-1544020098 @MartijnVisser I recently learned what the criteria for hotfix changes are. This PR definitely complies. As we already discussed the removal of hadoop outputFormat for DataStream in

[GitHub] [flink] echauchot commented on pull request #22527: [FLINK-31749][hotfix][doc] Update Hadoop formats datastream doc

2023-05-11 Thread via GitHub
echauchot commented on PR #22527: URL: https://github.com/apache/flink/pull/22527#issuecomment-1544019874 @MartijnVisser I recently learned what the criteria for hotfix changes are. This PR definitely complies. As we already discussed the removal of hadoop outputFormat for DataStream in

[jira] [Commented] (FLINK-32045) optimize task deployment performance for large-scale jobs

2023-05-11 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721774#comment-17721774 ] Weihua Hu commented on FLINK-32045: --- Thanks [~Thesharing]  for your reply, your comment are very

[GitHub] [flink] echauchot merged pull request #22569: [FLINK-32014][doc][hotfix] Add Cassandra source documentation to website

2023-05-11 Thread via GitHub
echauchot merged PR #22569: URL: https://github.com/apache/flink/pull/22569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-32047) Fix args in JobSpec not being passed through to Flink in Standalone mode - 1.4.0

2023-05-11 Thread Gil Shmaya (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721770#comment-17721770 ] Gil Shmaya commented on FLINK-32047: [~gyfora]  Yes, the results are the same: 

[GitHub] [flink] echauchot commented on pull request #22569: [FLINK-32014][doc][hotfix] Add Cassandra source documentation to website

2023-05-11 Thread via GitHub
echauchot commented on PR #22569: URL: https://github.com/apache/flink/pull/22569#issuecomment-1544003128 > ## CI report: > * [68479de](https://github.com/apache/flink/commit/68479de641f3a0f8979d1c270aad6d829025d720) Azure:

[jira] [Commented] (FLINK-31743) Avoid relocating the RocksDB's log failure when filename exceeds 255 characters

2023-05-11 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721759#comment-17721759 ] Yun Tang commented on FLINK-31743: -- merged in flink release-1.17:

[GitHub] [flink] Myasuka merged pull request #22545: [FLINK-31743][statebackend/rocksdb] disable rocksdb log relocating wh…

2023-05-11 Thread via GitHub
Myasuka merged PR #22545: URL: https://github.com/apache/flink/pull/22545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-31449) Remove DeclarativeSlotManager related logic

2023-05-11 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu updated FLINK-31449: -- Parent: (was: FLINK-31439) Issue Type: Improvement (was: Sub-task) > Remove

[jira] [Updated] (FLINK-31537) Derive a new TaskManagerTrackerConfiguration from the SlotManagerConfiguration.

2023-05-11 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu updated FLINK-31537: -- Parent: (was: FLINK-31439) Issue Type: Improvement (was: Sub-task) > Derive a new

[jira] [Updated] (FLINK-31445) Split resource allocate/release related logic from FineGrainedSlotManager to TaskManagerTracker

2023-05-11 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu updated FLINK-31445: -- Parent: (was: FLINK-31439) Issue Type: Improvement (was: Sub-task) > Split resource

[jira] [Commented] (FLINK-27925) Avoid to create watcher without the resourceVersion

2023-05-11 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721757#comment-17721757 ] Weihua Hu commented on FLINK-27925: --- Thanks [~ouyangwulin] ,  glad to hear that. > Avoid to create

[jira] [Updated] (FLINK-31439) FLIP-298: Unifying the Implementation of SlotManager

2023-05-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31439: --- Affects Version/s: 1.18.0 > FLIP-298: Unifying the Implementation of SlotManager >

[GitHub] [flink-web] gyfora opened a new pull request, #647: Kubernetes Operator 1.5.0

2023-05-11 Thread via GitHub
gyfora opened a new pull request, #647: URL: https://github.com/apache/flink-web/pull/647 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (FLINK-31967) SQL with LAG function NullPointerException

2023-05-11 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721756#comment-17721756 ] Shengkai Fang commented on FLINK-31967: --- [~padavan] after investigation, the type inference is not

[GitHub] [flink] Myasuka commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-05-11 Thread via GitHub
Myasuka commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1191127181 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java: ## @@ -394,18 +394,14 @@ public void confirm(SequenceNumber from,

[GitHub] [flink] Myasuka commented on pull request #22555: [FLINK-31706] [runtime] The default source parallelism should be the same as ex…

2023-05-11 Thread via GitHub
Myasuka commented on PR #22555: URL: https://github.com/apache/flink/pull/22555#issuecomment-1543921566 @clownxc Please move to the original ticket. Any changes to break the previous behavior needs a discussion in the JIRA, that's why we did not assign anyone to take the ticket. BTW, we

[jira] [Closed] (FLINK-31903) Caching records fails in BroadcastUtils#withBroadcastStream

2023-05-11 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhipeng Zhang closed FLINK-31903. - Resolution: Not A Bug > Caching records fails in BroadcastUtils#withBroadcastStream >

[jira] [Commented] (FLINK-31903) Caching records fails in BroadcastUtils#withBroadcastStream

2023-05-11 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721753#comment-17721753 ] Zhipeng Zhang commented on FLINK-31903: --- The root cause is that using memory as statebackend has

[GitHub] [flink] Mrart commented on a diff in pull request #21527: [FLINK-27925] [kubernetes]Performance optimization when watch tm pod and list pod.

2023-05-11 Thread via GitHub
Mrart commented on code in PR #21527: URL: https://github.com/apache/flink/pull/21527#discussion_r1191070958 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesClientTestBase.java: ## @@ -143,6 +147,34 @@ protected void mockGetDeploymentWithError() {

[GitHub] [flink] Mrart commented on a diff in pull request #21527: [FLINK-27925] [kubernetes]Performance optimization when watch tm pod and list pod.

2023-05-11 Thread via GitHub
Mrart commented on code in PR #21527: URL: https://github.com/apache/flink/pull/21527#discussion_r1191067760 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesClientTestBase.java: ## @@ -143,6 +147,34 @@ protected void mockGetDeploymentWithError() {

[jira] [Created] (FLINK-32063) AWS CI mvn compile fails to cast objects to parent type.

2023-05-11 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-32063: --- Summary: AWS CI mvn compile fails to cast objects to parent type. Key: FLINK-32063 URL: https://issues.apache.org/jira/browse/FLINK-32063 Project: Flink Issue

  1   2   3   >