[jira] [Comment Edited] (FLINK-33414) MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot fails due to unexpected TimeoutException

2023-11-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783526#comment-17783526 ] Matthias Pohl edited comment on FLINK-33414 at 11/7/23 8:10 AM: *

[jira] [Commented] (FLINK-33414) MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot fails due to unexpected TimeoutException

2023-11-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783526#comment-17783526 ] Matthias Pohl commented on FLINK-33414: ---

[jira] [Commented] (FLINK-32902) Docs creation and checks in multiple locations

2023-11-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783531#comment-17783531 ] Matthias Pohl commented on FLINK-32902: --- Hi [~tzy_0x], thanks for offering your help. I'm

Re: [PR] [FLINK-33398][runtime] Support switching from batch to stream mode for one input stream operator [flink]

2023-11-07 Thread via GitHub
Sxnan commented on PR #23521: URL: https://github.com/apache/flink/pull/23521#issuecomment-1798020804 @yunfengzhou-hub Thanks for the review! I updated the PR. Can you have another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-33257][connectors/mongodb] Support filter pushdown in MongoDB connector [flink-connector-mongodb]

2023-11-07 Thread via GitHub
xuyangzhong commented on PR #17: URL: https://github.com/apache/flink-connector-mongodb/pull/17#issuecomment-1798132958 Hi, @Jiabao-Sun, sorry for the late reply. What about adding more cases while testing plan such as the following? 1. pushdown some expressions and retain other

[jira] [Resolved] (FLINK-33317) Add cleaning mechanism for StreamConfig#SERIALIZEDUDF

2023-11-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33317. - Fix Version/s: 1.19.0 Resolution: Fixed > Add cleaning mechanism for StreamConfig#SERIALIZEDUDF

[jira] [Commented] (FLINK-33476) join table throw Record is too big Exception

2023-11-07 Thread zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783545#comment-17783545 ] zhu commented on FLINK-33476: - @[~mapohl]  hi what parameter configurations can solve the problem of

Re: [PR] [FLINK-33448][runtime] Introduce a new configuration item 'taskmanager.load-balance.mode' [flink]

2023-11-07 Thread via GitHub
1996fanrui merged PR #23658: URL: https://github.com/apache/flink/pull/23658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-33385) Flink connector redshift Sink Table API implementation

2023-11-07 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated FLINK-33385: --- Summary: Flink connector redshift Sink Table API implementation (was: Flink connector redshift

[jira] [Assigned] (FLINK-33132) Flink Connector Redshift Sink Implementation

2023-11-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-33132: --- Assignee: Samrat Deb > Flink Connector Redshift Sink Implementation >

[jira] [Assigned] (FLINK-31854) FLIP-307: Flink Connector Redshift

2023-11-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-31854: --- Assignee: Samrat Deb > FLIP-307: Flink Connector Redshift > --- >

[jira] [Assigned] (FLINK-33385) Flink connector redshift Sink Table API implementation

2023-11-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-33385: --- Assignee: Samrat Deb > Flink connector redshift Sink Table API implementation >

Re: [PR] [FLINK-33317][runtime] Add cleaning mechanism for initial configs to reduce the memory usage [flink]

2023-11-07 Thread via GitHub
pnowojski commented on PR #23589: URL: https://github.com/apache/flink/pull/23589#issuecomment-1797993243 Hey @1996fanrui , my  still stands :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-33262][table-api] Extend source provider interfaces with the new parallelism provider interface [flink]

2023-11-07 Thread via GitHub
libenchao commented on PR #23663: URL: https://github.com/apache/flink/pull/23663#issuecomment-1798031208 > @libenchao For `SourceFunctionProvider`, since it has already been deprecated now, I think there's no need to extend its interface, WDYT? @X-czh I agree we can leave

Re: [PR] [FLINK-33395][table-planner] fix the join hint doesn't work when appears in subquery [flink]

2023-11-07 Thread via GitHub
xuyangzhong commented on code in PR #23620: URL: https://github.com/apache/flink/pull/23620#discussion_r1384578763 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/hint/FlinkHints.java: ## @@ -234,4 +232,112 @@ private RelNode visitBiRel(BiRel

Re: [PR] [FLINK-33317][runtime] Add cleaning mechanism for initial configs to reduce the memory usage [flink]

2023-11-07 Thread via GitHub
1996fanrui merged PR #23589: URL: https://github.com/apache/flink/pull/23589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-33473) Update Flink client to 1.18.0

2023-11-07 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783548#comment-17783548 ] Prabhu Joseph commented on FLINK-33473: --- Thanks [~fanrui]. Will close this one. > Update Flink

[jira] [Commented] (FLINK-33317) Add cleaning mechanism for StreamConfig#SERIALIZEDUDF

2023-11-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783550#comment-17783550 ] Rui Fan commented on FLINK-33317: - Merged master<1.19> via: c83792b0f3fb6ae18dfabd52a89dc42c074ee73c >

[jira] [Commented] (FLINK-33448) Introduce a new configuration item 'taskmanager.load-balance.mode'

2023-11-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783554#comment-17783554 ] Rui Fan commented on FLINK-33448: - Merged to master<1.19> via : ed07a70e45a753a259287c9fdbdae73e3415cc21

[jira] [Resolved] (FLINK-33448) Introduce a new configuration item 'taskmanager.load-balance.mode'

2023-11-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33448. - Resolution: Fixed > Introduce a new configuration item 'taskmanager.load-balance.mode' >

[jira] [Updated] (FLINK-33448) Introduce a new configuration item 'taskmanager.load-balance.mode'

2023-11-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33448: Fix Version/s: 1.19.0 > Introduce a new configuration item 'taskmanager.load-balance.mode' >

[jira] [Updated] (FLINK-31854) FLIP-307:[Phase 1] [Sink Support] Flink Connector Redshift

2023-11-07 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated FLINK-31854: --- Summary: FLIP-307:[Phase 1] [Sink Support] Flink Connector Redshift (was: FLIP-307: Flink

[jira] [Updated] (FLINK-31854) FLIP-307: Flink Connector Redshift

2023-11-07 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated FLINK-31854: --- Description: This is an umbrella Jira for 

[jira] [Closed] (FLINK-33337) Expose IngestDB and ClipDB in the official RocksDB API

2023-11-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-7. -- Resolution: Fixed > Expose IngestDB and ClipDB in the official RocksDB API >

[jira] [Updated] (FLINK-33337) Expose IngestDB and ClipDB in the official RocksDB API

2023-11-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-7: --- Description: Remaining open PRs: None :) Already merged PRs:

[jira] [Updated] (FLINK-33472) Solve the problem that the temporary file of flink-conf.yaml in S3AFileSystem cannot be uploaded

2023-11-07 Thread zhengzhili (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhengzhili updated FLINK-33472: --- Priority: Critical (was: Major) > Solve the problem that the temporary file of flink-conf.yaml in

[jira] [Commented] (FLINK-33337) Expose IngestDB and ClipDB in the official RocksDB API

2023-11-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783523#comment-17783523 ] Piotr Nowojski commented on FLINK-7: Thanks for the update [~mayuehappy]! Does it mean that

[jira] [Commented] (FLINK-33468) Run Kubernetes IT test fails due to wrong Maven version

2023-11-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783525#comment-17783525 ] Matthias Pohl commented on FLINK-33468: --- Moving to {{./mvnw}} in {{tools/ci/maven-utils.sh}}

Re: [PR] [FLINK-33317][runtime] Add cleaning mechanism for initial configs to reduce the memory usage [flink]

2023-11-07 Thread via GitHub
1996fanrui commented on PR #23589: URL: https://github.com/apache/flink/pull/23589#issuecomment-1798008012 > Hey @1996fanrui , my  still stands :) Thank you, I rebased master just now, let's wait for the CI. and I will merge it after CI is green. -- This is an automated message

Re: [PR] [FLINK-33395][table-planner] fix the join hint doesn't work when appears in subquery [flink]

2023-11-07 Thread via GitHub
xuyangzhong commented on code in PR #23620: URL: https://github.com/apache/flink/pull/23620#discussion_r1384561374 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java: ## @@ -216,18 +213,12 @@ public static RelNode

[jira] [Created] (FLINK-33476) join table throw Record is too big Exception

2023-11-07 Thread zhu (Jira)
zhu created FLINK-33476: --- Summary: join table throw Record is too big Exception Key: FLINK-33476 URL: https://issues.apache.org/jira/browse/FLINK-33476 Project: Flink Issue Type: New Feature

Re: [PR] [FLINK-33262][table-api] Extend source provider interfaces with the new parallelism provider interface [flink]

2023-11-07 Thread via GitHub
X-czh commented on PR #23663: URL: https://github.com/apache/flink/pull/23663#issuecomment-1798122899 @libenchao Got it. Thanks for the detailed clarification! I'll extend the interface for `SourceFunctionProvider` as well. -- This is an automated message from the Apache Git Service. To

[jira] [Resolved] (FLINK-33473) Update Flink client to 1.18.0

2023-11-07 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prabhu Joseph resolved FLINK-33473. --- Resolution: Duplicate > Update Flink client to 1.18.0 > - > >

Re: [PR] [FLINK-32380] Support Java Records with PojoTypeInfo/Serializer [flink]

2023-11-07 Thread via GitHub
XComp commented on code in PR #23490: URL: https://github.com/apache/flink/pull/23490#discussion_r1384615175 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java: ## @@ -473,25 +521,40 @@ public T deserialize(T reuse, DataInputView source)

[jira] [Assigned] (FLINK-33133) Flink Document Update

2023-11-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-33133: --- Assignee: Samrat Deb > Flink Document Update > -- > > Key:

[jira] [Assigned] (FLINK-33134) Flink Connector redshift E2E test

2023-11-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-33134: --- Assignee: Samrat Deb > Flink Connector redshift E2E test > -- > >

[jira] [Commented] (FLINK-33468) Run Kubernetes IT test fails due to wrong Maven version

2023-11-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783524#comment-17783524 ] Matthias Pohl commented on FLINK-33468: ---

Re: [PR] [FLINK-33331] Update netty to 4.1.100 and arrow to 13.0.0 to make flink-python passing on java 21 [flink]

2023-11-07 Thread via GitHub
TanYuxin-tyx commented on code in PR #23664: URL: https://github.com/apache/flink/pull/23664#discussion_r1384533940 ## pom.xml: ## @@ -887,7 +887,7 @@ under the License. io.netty netty-bom

[jira] [Created] (FLINK-33477) Reduce code redundancy in PojoSerializer

2023-11-07 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33477: - Summary: Reduce code redundancy in PojoSerializer Key: FLINK-33477 URL: https://issues.apache.org/jira/browse/FLINK-33477 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-33477) Reduce code redundancy in PojoSerializer

2023-11-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-33477: -- Description: We identified code duplicates in the {{PojoSerializer}} when working on

Re: [PR] [FLINK-33262][table-api] Extend source provider interfaces with the new parallelism provider interface [flink]

2023-11-07 Thread via GitHub
X-czh commented on PR #23663: URL: https://github.com/apache/flink/pull/23663#issuecomment-1798278626 I've pushed two new commits: - one addresses Benchao's comments on extending `SourceFunctionProvider`, `DataStreamScanProvider`, and `TransformationScanProvider` as well as optimizing

[jira] [Created] (FLINK-33478) Fail to call unix_timestamp when it is in filter condition

2023-11-07 Thread yunfan (Jira)
yunfan created FLINK-33478: -- Summary: Fail to call unix_timestamp when it is in filter condition Key: FLINK-33478 URL: https://issues.apache.org/jira/browse/FLINK-33478 Project: Flink Issue Type:

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-07 Thread via GitHub
dawidwys commented on PR #23660: URL: https://github.com/apache/flink/pull/23660#issuecomment-1798343770 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-12302) Fixed the wrong finalStatus of yarn application when application finished

2023-11-07 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin Chen updated FLINK-12302: - Attachment: container_e15_1693914709123_8498_01_01_8042 > Fixed the wrong finalStatus of yarn

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables [flink]

2023-11-07 Thread via GitHub
pvary commented on PR #23555: URL: https://github.com/apache/flink/pull/23555#issuecomment-1798547936 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-32380] Support Java Records with PojoTypeInfo/Serializer [flink]

2023-11-07 Thread via GitHub
gyfora commented on PR #23490: URL: https://github.com/apache/flink/pull/23490#issuecomment-1798603528 Addressed these comments @XComp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-33478) Fail to call unix_timestamp when it is in filter condition

2023-11-07 Thread yunfan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yunfan updated FLINK-33478: --- Description: It can reproduced by following sql. select * from foo where cast(unix_timestamp() as bigint)

Re: [PR] [FLINK-26585][state-processor-api] replace implementation of MultiStateKeyIterator with Stream-free implementation [flink]

2023-11-07 Thread via GitHub
RainerMatthiasS commented on PR #23239: URL: https://github.com/apache/flink/pull/23239#issuecomment-1798418690 > > > > Hi @masteryhx , thank you for the review again, I also synced my fork with the upstream, if that was what you meant by 'Could you also rebase all your commits to the

[PR] [FLINK-32353] [hotfix] build against new Flink version [flink-connector-cassandra]

2023-11-07 Thread via GitHub
echauchot opened a new pull request, #21: URL: https://github.com/apache/flink-connector-cassandra/pull/21 Build against flink 1.18.0 Test against -flink 1.18.0 -flink1.17.1 Update archunit violation store -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-11-07 Thread via GitHub
dalelane commented on PR #23395: URL: https://github.com/apache/flink/pull/23395#issuecomment-1798607054 @afedulov Is there anything else that you think is needed here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (FLINK-12302) Fixed the wrong finalStatus of yarn application when application finished

2023-11-07 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin Chen updated FLINK-12302: - Attachment: (was: container_e15_1693914709123_8498_01_01_8042) > Fixed the wrong finalStatus of

Re: [PR] [FLINK-33471] Make flink kubernetes operator compilable with jdk21 [flink-kubernetes-operator]

2023-11-07 Thread via GitHub
snuyanzin commented on PR #701: URL: https://github.com/apache/flink-kubernetes-operator/pull/701#issuecomment-1798340133 @1996fanrui @gyfora since you've looked at similar PR for java 17 support may I ask you to have a look at java 21 support? -- This is an automated message from the

[jira] [Resolved] (FLINK-33474) ShowPlan throws undefined exception In Flink Web Submit Page

2023-11-07 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-33474. -- Fix Version/s: 1.17.2 1.19.0 1.18.1 Resolution: Fixed

[jira] [Assigned] (FLINK-6755) Allow triggering Checkpoints through command line client

2023-11-07 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-6755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-6755: -- Assignee: Zakelly Lan > Allow triggering Checkpoints through command line client >

[jira] [Updated] (FLINK-6755) Allow triggering Checkpoints through command line client

2023-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-6755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-6755: -- Labels: auto-deprioritized-major auto-unassigned pull-request-available (was:

[PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-07 Thread via GitHub
Zakelly opened a new pull request, #23679: URL: https://github.com/apache/flink/pull/23679 ## What is the purpose of the change Since FLINK-24280, we have supported manual checkpoint triggering from REST API. This PR wire command-line interface and rest endpoint, supporting manual

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-07 Thread via GitHub
flinkbot commented on PR #23679: URL: https://github.com/apache/flink/pull/23679#issuecomment-1798294190 ## CI report: * bd404c8dad2c78dc5106fde39e3f81a689b90c85 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33471] Make flink kubernetes operator compilable with jdk21 [flink-kubernetes-operator]

2023-11-07 Thread via GitHub
snuyanzin commented on code in PR #701: URL: https://github.com/apache/flink-kubernetes-operator/pull/701#discussion_r1384789446 ## pom.xml: ## @@ -259,7 +259,7 @@ under the License. -

Re: [PR] [FLINK-32380] Support Java Records with PojoTypeInfo/Serializer [flink]

2023-11-07 Thread via GitHub
gyfora commented on code in PR #23490: URL: https://github.com/apache/flink/pull/23490#discussion_r1384969989 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java: ## @@ -473,25 +521,40 @@ public T deserialize(T reuse, DataInputView

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-07 Thread via GitHub
dawidwys commented on code in PR #23660: URL: https://github.com/apache/flink/pull/23660#discussion_r1384792074 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/SortTestPrograms.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed

Re: [PR] [FLINK-33023][table-planner][JUnit5 Migration] Module: flink-table-planner (TableTestBase) [flink]

2023-11-07 Thread via GitHub
xuyangzhong commented on code in PR #23349: URL: https://github.com/apache/flink/pull/23349#discussion_r1384671836 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala: ## @@ -126,10 +118,35 @@ abstract class TableTestBase {

[jira] [Assigned] (FLINK-33474) ShowPlan throws undefined exception In Flink Web Submit Page

2023-11-07 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang reassigned FLINK-33474: Assignee: Yu Chen > ShowPlan throws undefined exception In Flink Web Submit Page >

Re: [PR] [FLINK-33474][runtime-web] fix undefined error of show plan in job su… [flink]

2023-11-07 Thread via GitHub
Myasuka merged PR #23677: URL: https://github.com/apache/flink/pull/23677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables [flink]

2023-11-07 Thread via GitHub
pvary commented on PR #23555: URL: https://github.com/apache/flink/pull/23555#issuecomment-1798568920 Handing the `InitContext` -> `WriterInitContext` migration is not viable, because of the diamond inheritance, I went forward with migrating without the deprecation. As a result the

Re: [PR] [FLINK-33439] Implement type inference for IN function [flink]

2023-11-07 Thread via GitHub
dawidwys commented on code in PR #23652: URL: https://github.com/apache/flink/pull/23652#discussion_r1385055760 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SubQueryInputTypeStrategy.java: ## @@ -0,0 +1,115 @@ +/* + *

[jira] [Commented] (FLINK-33466) Bounded Kafka source never finishes after restore from savepoint

2023-11-07 Thread Jonas Weile (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783674#comment-17783674 ] Jonas Weile commented on FLINK-33466: - Hi, would appreciate it if any of the committers could have a

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-07 Thread via GitHub
bvarghese1 commented on code in PR #23660: URL: https://github.com/apache/flink/pull/23660#discussion_r1385277745 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/SortTestPrograms.java: ## @@ -0,0 +1,121 @@ +/* + *

Re: [PR] [FLINK-33331] Update netty to 4.1.100 and arrow to 13.0.0 to make flink-python passing on java 21 [flink]

2023-11-07 Thread via GitHub
snuyanzin commented on code in PR #23664: URL: https://github.com/apache/flink/pull/23664#discussion_r1385248937 ## pom.xml: ## @@ -887,7 +887,7 @@ under the License. io.netty netty-bom -

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-07 Thread via GitHub
dawidwys commented on PR #23660: URL: https://github.com/apache/flink/pull/23660#issuecomment-1798988635 One more thing I just noticed (actually it's also a problem for Calc tests) that we should not put those classes/tests in `org.apache.flink.table.planner.plan.nodes.exec.testutils`.

Re: [PR] [FLINK-33331] Update netty to 4.1.100 and arrow to 13.0.0 to make flink-python passing on java 21 [flink]

2023-11-07 Thread via GitHub
snuyanzin commented on code in PR #23664: URL: https://github.com/apache/flink/pull/23664#discussion_r1385248937 ## pom.xml: ## @@ -887,7 +887,7 @@ under the License. io.netty netty-bom -

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-07 Thread via GitHub
bvarghese1 commented on code in PR #23660: URL: https://github.com/apache/flink/pull/23660#discussion_r1385277745 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/SortTestPrograms.java: ## @@ -0,0 +1,121 @@ +/* + *

Re: [PR] [FLINK-33439] Implement type inference for IN function [flink]

2023-11-07 Thread via GitHub
jnh5y commented on code in PR #23652: URL: https://github.com/apache/flink/pull/23652#discussion_r1385277845 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/strategies/SubQueryInputTypeStrategyTest.java: ## @@ -0,0 +1,83 @@ +/* + *

Re: [PR] [FLINK-33439] Implement type inference for IN function [flink]

2023-11-07 Thread via GitHub
dawidwys commented on code in PR #23652: URL: https://github.com/apache/flink/pull/23652#discussion_r1385029083 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeChecks.java: ## @@ -242,6 +245,139 @@ public static boolean

Re: [PR] [FLINK-33331] Update netty to 4.1.100 and arrow to 13.0.0 to make flink-python passing on java 21 [flink]

2023-11-07 Thread via GitHub
snuyanzin commented on code in PR #23664: URL: https://github.com/apache/flink/pull/23664#discussion_r1385248937 ## pom.xml: ## @@ -887,7 +887,7 @@ under the License. io.netty netty-bom -

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-07 Thread via GitHub
bvarghese1 commented on PR #23660: URL: https://github.com/apache/flink/pull/23660#issuecomment-1799279843 > One more thing I just noticed (actually it's also a problem for Calc tests) that we should not put those classes/tests in `org.apache.flink.table.planner.plan.nodes.exec.testutils`.

Re: [PR] [FLINK-33439] Implement type inference for IN function [flink]

2023-11-07 Thread via GitHub
dawidwys commented on code in PR #23652: URL: https://github.com/apache/flink/pull/23652#discussion_r1385059368 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/expressions/subquery.scala: ## @@ -1,78 +0,0 @@ -/* - * Licensed to the Apache

Re: [PR] [FLINK-33439] Implement type inference for IN function [flink]

2023-11-07 Thread via GitHub
dawidwys commented on code in PR #23652: URL: https://github.com/apache/flink/pull/23652#discussion_r1385224887 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/strategies/SubQueryInputTypeStrategyTest.java: ## @@ -0,0 +1,83 @@ +/* + *

Re: [PR] [FLINK-33331] Update netty to 4.1.100 and arrow to 13.0.0 to make flink-python passing on java 21 [flink]

2023-11-07 Thread via GitHub
snuyanzin commented on code in PR #23664: URL: https://github.com/apache/flink/pull/23664#discussion_r1385293460 ## pom.xml: ## @@ -887,7 +887,7 @@ under the License. io.netty netty-bom -

[jira] [Created] (FLINK-33479) Add Rerouting support to KafkaSink

2023-11-07 Thread Kevin Tseng (Jira)
Kevin Tseng created FLINK-33479: --- Summary: Add Rerouting support to KafkaSink Key: FLINK-33479 URL: https://issues.apache.org/jira/browse/FLINK-33479 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-33479) Add Rerouting support to KafkaSink

2023-11-07 Thread Kevin Tseng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783741#comment-17783741 ] Kevin Tseng commented on FLINK-33479: - can someone assign this to me. we have idea on how this

Re: [PR] [FLINK-32894] Use 3.3.0 for maven-shade-plugin to support Java 17 [flink-connector-shared-utils]

2023-11-07 Thread via GitHub
snuyanzin commented on PR #20: URL: https://github.com/apache/flink-connector-shared-utils/pull/20#issuecomment-1799805561 does it make sense to bump to 3.5.1 since there was added support for jdk20+ ? https://issues.apache.org/jira/browse/MSHADE-454 -- This is an automated message

[jira] [Commented] (FLINK-29288) Can't start a job with a jar in the system classpath

2023-11-07 Thread Yaroslav Tkachenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783773#comment-17783773 ] Yaroslav Tkachenko commented on FLINK-29288: > what is the correct procedure to put job jars

[jira] [Commented] (FLINK-29288) Can't start a job with a jar in the system classpath

2023-11-07 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783755#comment-17783755 ] Trystan commented on FLINK-29288: - With this change, what is the correct procedure to put job jars on

[jira] [Commented] (FLINK-29288) Can't start a job with a jar in the system classpath

2023-11-07 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783806#comment-17783806 ] Trystan commented on FLINK-29288: - Thank you! This is exactly what we are trying to do. I thought we had

[jira] [Updated] (FLINK-33470) Implement restore tests for Join node

2023-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33470: --- Labels: pull-request-available (was: ) > Implement restore tests for Join node >

[PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-11-07 Thread via GitHub
jnh5y opened a new pull request, #23680: URL: https://github.com/apache/flink/pull/23680 ## What is the purpose of the change Implement restore tests for Join node ## Verifying this change This change added tests and can be verified as follows: * Added restore

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-11-07 Thread via GitHub
flinkbot commented on PR #23680: URL: https://github.com/apache/flink/pull/23680#issuecomment-1800285139 ## CI report: * 5da58a4bacbba7cc2547a7c3acb1b12fb662c667 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33260] Allow user to provide a list of recoverable exceptions [flink-connector-aws]

2023-11-07 Thread via GitHub
dannycranmer merged PR #110: URL: https://github.com/apache/flink-connector-aws/pull/110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-33260) Custom Error Handling for Kinesis Consumer

2023-11-07 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783826#comment-17783826 ] Danny Cranmer commented on FLINK-33260: --- Merged commit

[jira] [Commented] (FLINK-29288) Can't start a job with a jar in the system classpath

2023-11-07 Thread Yaroslav Tkachenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783816#comment-17783816 ] Yaroslav Tkachenko commented on FLINK-29288: Yep, it should work out of the box. That page

Re: [PR] [FLINK-33260] Allow user to provide a list of recoverable exceptions [flink-connector-aws]

2023-11-07 Thread via GitHub
dannycranmer commented on code in PR #110: URL: https://github.com/apache/flink-connector-aws/pull/110#discussion_r1385680247 ##

Re: [PR] [FLINK-33260] Allow user to provide a list of recoverable exceptions [flink-connector-aws]

2023-11-07 Thread via GitHub
dannycranmer commented on code in PR #110: URL: https://github.com/apache/flink-connector-aws/pull/110#discussion_r1385669429 ## flink-connector-aws/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/RecoverableErrorsConfig.java: ## @@

[jira] [Commented] (FLINK-33260) Custom Error Handling for Kinesis Consumer

2023-11-07 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783827#comment-17783827 ] Danny Cranmer commented on FLINK-33260: --- [~iemre] I have merged the EFO support. Will you be

[jira] [Created] (FLINK-33480) Implement restore tests for GroupAggregate node

2023-11-07 Thread Bonnie Varghese (Jira)
Bonnie Varghese created FLINK-33480: --- Summary: Implement restore tests for GroupAggregate node Key: FLINK-33480 URL: https://issues.apache.org/jira/browse/FLINK-33480 Project: Flink Issue

[jira] [Updated] (FLINK-33480) Implement restore tests for GroupAggregate node

2023-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33480: --- Labels: pull-request-available (was: ) > Implement restore tests for GroupAggregate node >

[PR] [FLINK-33480] Implement restore tests for GroupAggregate node [flink]

2023-11-07 Thread via GitHub
bvarghese1 opened a new pull request, #23681: URL: https://github.com/apache/flink/pull/23681 ## What is the purpose of the change Implement restore tests for GroupAggregate node ## Verifying this change This change added tests and can be verified as follows:

[jira] [Created] (FLINK-33481) Why were CheckPoints stored on ZooKeeper deleted when use Flink High Availability

2023-11-07 Thread hansonhe (Jira)
hansonhe created FLINK-33481: Summary: Why were CheckPoints stored on ZooKeeper deleted when use Flink High Availability Key: FLINK-33481 URL: https://issues.apache.org/jira/browse/FLINK-33481 Project:

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Attachment: image-2023-11-08-09-40-59-889.png > Why were checkpoints stored on zookeeper deleted when

Re: [PR] FLINK-30893 Replace not specifying a driver in Minikube by something … [flink]

2023-11-07 Thread via GitHub
victor09091 closed pull request #23494: FLINK-30893 Replace not specifying a driver in Minikube by something … URL: https://github.com/apache/flink/pull/23494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (FLINK-33481) Why were checkpoints stored on zookeeper deleted when JobManager failures with Flink High Availability on yarn

2023-11-07 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-33481: - Description: FlinkVersion:  1.13.5 , (1) flink-conf.yaml  high-availability.zookeeper.path.root    

  1   2   >