liuyongvs commented on code in PR #24015:
URL: https://github.com/apache/flink/pull/24015#discussion_r1439140313
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecOverAggregate.java:
##
@@ -231,7 +233,7 @@ private
flinkbot commented on PR #24015:
URL: https://github.com/apache/flink/pull/24015#issuecomment-1873601676
## CI report:
* c729879e94c5c441e661629a62a4b1653a73a045 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-33962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhanghao Chen updated FLINK-33962:
--
Description:
*Background*
Flink restores opeartor state from snapshots based on matching the
lifengchao created FLINK-33963:
--
Summary: There is only one UDF instance after serializing the same
task
Key: FLINK-33963
URL: https://issues.apache.org/jira/browse/FLINK-33963
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-33961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weijie Guo closed FLINK-33961.
--
Resolution: Invalid
> Hybrid Shuffle may hang when exclusive buffers per channel is set to 0
>
[
https://issues.apache.org/jira/browse/FLINK-24939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jark Wu reassigned FLINK-24939:
---
Assignee: Yubin Li
> Support 'SHOW CREATE CATALOG' syntax
>
>
liuyongvs opened a new pull request, #24015:
URL: https://github.com/apache/flink/pull/24015
## What is the purpose of the change
* should use aggCallNeedRetractions instead of needRetraction to check
retract method, orelse throw not implement retract method*
[
https://issues.apache.org/jira/browse/FLINK-33951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-33951:
---
Labels: pull-request-available (was: )
> should use aggCallNeedRetractions instead of
[
https://issues.apache.org/jira/browse/FLINK-33963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lifengchao updated FLINK-33963:
---
Description:
I define this UDF and expect the following SQL to return 'a', 'b', but it
return 'a',
Zhanghao Chen created FLINK-33962:
-
Summary: Chaining-agnostic OperatorID generation for improved
state compatibility on parallelism change
Key: FLINK-33962
URL: https://issues.apache.org/jira/browse/FLINK-33962
[
https://issues.apache.org/jira/browse/FLINK-33962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhanghao Chen updated FLINK-33962:
--
Description:
*Background*
Flink restores opeartor state from snapshots based on matching the
[
https://issues.apache.org/jira/browse/FLINK-33961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801669#comment-17801669
]
Weijie Guo commented on FLINK-33961:
Thanks for reporting this. Unfortunately, this issue can be
[
https://issues.apache.org/jira/browse/FLINK-33961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801669#comment-17801669
]
Weijie Guo edited comment on FLINK-33961 at 1/2/24 6:38 AM:
[~Jiang Xin]
flinkbot commented on PR #24016:
URL: https://github.com/apache/flink/pull/24016#issuecomment-1873663514
## CI report:
* 43b48748389ba8e4812d321371146e8cde30eab3 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
liuyongvs commented on code in PR #24015:
URL: https://github.com/apache/flink/pull/24015#discussion_r1439141361
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecLocalGroupAggregate.java:
##
@@ -147,7 +147,7 @@
[
https://issues.apache.org/jira/browse/FLINK-33816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801662#comment-17801662
]
Jiabao Sun commented on FLINK-33816:
!screenshot-1.png!
Add thread suspended breakpoints at
[
https://issues.apache.org/jira/browse/FLINK-33954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiang Xin updated FLINK-33954:
--
Description:
In some cases, the job may hang when there are not enough buffers in the local
buffer
liuyongvs commented on PR #24015:
URL: https://github.com/apache/flink/pull/24015#issuecomment-1873602881
hi @xuyangzhong @lsyldliu i have add comments for important part, it will
be convenient for review. will you have time to help review?
--
This is an automated message from the
liuyongvs commented on code in PR #24015:
URL: https://github.com/apache/flink/pull/24015#discussion_r1439142391
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/AggsHandlerCodeGenerator.scala:
##
@@ -1230,8 +1232,26 @@ class
[
https://issues.apache.org/jira/browse/FLINK-33816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiabao Sun updated FLINK-33816:
---
Attachment: screenshot-1.png
> SourceStreamTaskTest.testTriggeringStopWithSavepointWithDrain failed
[
https://issues.apache.org/jira/browse/FLINK-33954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiang Xin updated FLINK-33954:
--
Description: In some cases, the job may hang when there are not enough
buffers in the local buffer
Jiabao-Sun opened a new pull request, #24016:
URL: https://github.com/apache/flink/pull/24016
## What is the purpose of the change
[FLINK-33816][streaming] Fix unstable test
SourceStreamTaskTest.testTriggeringStopWithSavepointWithDrain
## Brief change log
[
https://issues.apache.org/jira/browse/FLINK-33961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801669#comment-17801669
]
Weijie Guo edited comment on FLINK-33961 at 1/2/24 6:39 AM:
[~Jiang Xin]
[
https://issues.apache.org/jira/browse/FLINK-33961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801676#comment-17801676
]
Jiang Xin commented on FLINK-33961:
---
[~Weijie Guo] Thanks for the explanation, I have no more
[
https://issues.apache.org/jira/browse/FLINK-33951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801691#comment-17801691
]
Martijn Visser commented on FLINK-33951:
[~jackylau] Still, please add a better Jira
[
https://issues.apache.org/jira/browse/FLINK-33962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhanghao Chen updated FLINK-33962:
--
Description:
*Background*
Flink restores opeartor state from snapshots based on matching the
[
https://issues.apache.org/jira/browse/FLINK-33816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-33816:
---
Labels: github-actions pull-request-available test-stability (was:
github-actions
libenchao commented on code in PR #23984:
URL: https://github.com/apache/flink/pull/23984#discussion_r1439188114
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala:
##
@@ -124,14 +124,27 @@ object CodeGenUtils {
Samrat002 commented on PR #23725:
URL: https://github.com/apache/flink/pull/23725#issuecomment-1873212013
Thank you, @MartijnVisser, for diving into the PR.
Before the merge of https://github.com/apache/flink/pull/21458, this issue
exists from long time.
## How to reproduce
flinkbot commented on PR #24013:
URL: https://github.com/apache/flink/pull/24013#issuecomment-1873260605
## CI report:
* 892a6d8944160dd5e871c5ee7e8cbdf96bea0e8c UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
niliushall opened a new pull request, #24013:
URL: https://github.com/apache/flink/pull/24013
## What is the purpose of the change
The default value of `restart-strategy.fixed-delay.attempts` in
`RestartStrategyOptions.java` is 1， but the value of the parameter in the
1996fanrui commented on PR #23960:
URL: https://github.com/apache/flink/pull/23960#issuecomment-1873234298
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=55925=logs=0da23115-68bb-5dcd-192c-bd4c8adebde1=24c3384f-1bcb-57b3-224f-51bf973bbee8=7264
The CI fails due
[
https://issues.apache.org/jira/browse/FLINK-33949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801520#comment-17801520
]
Chesnay Schepler commented on FLINK-33949:
--
The JLS clearly states that there _may_ be cases
yuchen-ecnu commented on PR #23820:
URL: https://github.com/apache/flink/pull/23820#issuecomment-1873273628
> I think a better understanding of how to write unit tests is important,
you can refer to other existing tests. Please take a look at my comments.
Hi @Myasuka ,
Sorry for
yuchen-ecnu commented on code in PR #23820:
URL: https://github.com/apache/flink/pull/23820#discussion_r1439004722
##
flink-runtime/src/test/java/org/apache/flink/runtime/util/profiler/ProfilingServiceTest.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software
niliushall commented on PR #24013:
URL: https://github.com/apache/flink/pull/24013#issuecomment-1873262601
@roncohen @hadronzoo @is @rehevkor5 Could you please take a look at this pr
in your free time? Thanks~
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-27756:
---
Labels: pull-request-available test-stability (was: test-stability)
> Fix intermittently
[
https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801560#comment-17801560
]
Ahmed Hamdy commented on FLINK-27756:
-
[~Sergey Nuyanzin] I have refactored the test, please take a
[
https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Hamdy updated FLINK-27756:
Fix Version/s: 1.19.0
(was: 1.16.0)
> Fix intermittently failing test in
vahmed-hamdy opened a new pull request, #24014:
URL: https://github.com/apache/flink/pull/24014
## What is the purpose of the change
Refactor `checkLoggedSendTimesAreWithinBounds` for Async Sink, the test
introduced static upper bound that was violated due to mailbox executer
flinkbot commented on PR #24014:
URL: https://github.com/apache/flink/pull/24014#issuecomment-1873378765
## CI report:
* c01ef9458a0893b7646abcccd1314d93b22b0311 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-33951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801631#comment-17801631
]
xuyang commented on FLINK-33951:
I'm also a little curious about the background of this jira. BTW,
WencongLiu commented on code in PR #23992:
URL: https://github.com/apache/flink/pull/23992#discussion_r1439117470
##
flink-runtime-web/README.md:
##
@@ -102,6 +102,8 @@ re-compilation:
### CodeStyle & Lint
+> Tips: Before committing, make sure you've run npm run
[
https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801633#comment-17801633
]
xuyang commented on FLINK-33490:
Hi, [~martijnvisser] . IIRC, the small Flip that we want to introduce
[
https://issues.apache.org/jira/browse/FLINK-33740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801634#comment-17801634
]
xuyang commented on FLINK-33740:
Hi, [~martijnvisser] . Let's talk in FLINK-33490
> Introduce a flip to
[
https://issues.apache.org/jira/browse/FLINK-33951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801639#comment-17801639
]
Jacky Lau commented on FLINK-33951:
---
[~xuyangzhong] yeap, not a bug.However, this might seem strange
Jiang Xin created FLINK-33961:
-
Summary: Hybrid Shuffle may hang when exclusive buffers per
channel is set to 0
Key: FLINK-33961
URL: https://issues.apache.org/jira/browse/FLINK-33961
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-33961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiang Xin updated FLINK-33961:
--
Description:
I found that the Hybrid Shuffle without enabling new mode may hang when
[
https://issues.apache.org/jira/browse/FLINK-33961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiang Xin updated FLINK-33961:
--
Description:
I found that the Hybrid Shuffle without enabling new mode may hang when
[
https://issues.apache.org/jira/browse/FLINK-33961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801642#comment-17801642
]
Jiang Xin commented on FLINK-33961:
---
[~Weijie Guo] Do you have any idea about it?
> Hybrid Shuffle
HuangZhenQiu commented on PR #23511:
URL: https://github.com/apache/flink/pull/23511#issuecomment-1873589993
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/FLINK-33880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801645#comment-17801645
]
Yuan Huang commented on FLINK-33880:
-
Hi [~guoyangze] , How do you think this issue? Is it
[
https://issues.apache.org/jira/browse/FLINK-33880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yangze Guo reassigned FLINK-33880:
--
Assignee: Yuan Huang
> Introducing Retry Mechanism for Listing TaskManager Pods to Prevent
[
https://issues.apache.org/jira/browse/FLINK-33880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801648#comment-17801648
]
Yangze Guo commented on FLINK-33880:
I think it's a valid issue, go ahead.
> Introducing Retry
54 matches
Mail list logo
