[jira] [Commented] (FLINK-34171) Cannot restore from savepoint when increasing parallelism of operator using reinterpretAsKeyedStream and RichAsyncFunction

2024-01-22 Thread Ken Burford (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809586#comment-17809586 ] Ken Burford commented on FLINK-34171: - It's intermittently reproducible in 1.17.0 with both aligned

[jira] [Created] (FLINK-34203) PyFlink `get_field_data_types()` supports only `precision = 3` for `TimestampType`

2024-01-22 Thread Mehmet Aktas (Jira)
Mehmet Aktas created FLINK-34203: Summary: PyFlink `get_field_data_types()` supports only `precision = 3` for `TimestampType` Key: FLINK-34203 URL: https://issues.apache.org/jira/browse/FLINK-34203

[jira] [Updated] (FLINK-34152) Tune memory of autoscaled jobs

2024-01-22 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-34152: --- Description: The current autoscaling algorithm adjusts the parallelism of the job

Re: [PR] [FLINK-34190][FLIP-416][checkpoint] Deprecate RestoreMode#LEGACY [flink]

2024-01-22 Thread via GitHub
flinkbot commented on PR #24169: URL: https://github.com/apache/flink/pull/24169#issuecomment-1904493250 ## CI report: * 9904b58ef64504af0dc286e096be3fc00fbdf303 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-22 Thread via GitHub
davidradl opened a new pull request, #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79 Allow lookup joins to honour supplied filters, where the lookup source is JDBC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-22 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1462392709 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java: ## @@ -116,6 +124,15 @@ public void

[PR] Bump org.apache.derby:derby from 10.10.2.0 to 10.17.1.0 in /flink-connector-hive [flink-connector-hive]

2024-01-22 Thread via GitHub
dependabot[bot] opened a new pull request, #16: URL: https://github.com/apache/flink-connector-hive/pull/16 Bumps org.apache.derby:derby from 10.10.2.0 to 10.17.1.0. [![Dependabot compatibility

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-22 Thread via GitHub
davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1904779201 @libenchao @snuyanzin I have updated the code in line with your feedback - please could you review again. Many thanks -- This is an automated message from the Apache Git

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-22 Thread via GitHub
davidradl closed pull request #79: [FLINK-33365] include filters with Lookup joins URL: https://github.com/apache/flink-connector-jdbc/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-34111][table] Add JSON_QUOTE and JSON_UNQUOTE function [flink]

2024-01-22 Thread via GitHub
jeyhunkarimov commented on PR #24156: URL: https://github.com/apache/flink/pull/24156#issuecomment-1904869427 Hi @MartijnVisser could you please review the PR in your available time? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Resolved] (FLINK-33824) Prepare Flink 1.18.1 Release

2024-01-22 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge resolved FLINK-33824. - Resolution: Fixed > Prepare Flink 1.18.1 Release > > >

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-22 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1462396444 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java: ## @@ -63,6 +64,9 @@ public class

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2024-01-22 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809712#comment-17809712 ] Benchao Li edited comment on FLINK-33365 at 1/23/24 5:18 AM: -

[jira] [Assigned] (FLINK-27331) Support Avro microsecond precision for TIME

2024-01-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-27331: --- Assignee: Peter Huang > Support Avro microsecond precision for TIME >

Re: [PR] [FLINK-34090][core] Introduce SerializerConfig [flink]

2024-01-22 Thread via GitHub
reswqa commented on PR #24127: URL: https://github.com/apache/flink/pull/24127#issuecomment-1905150931 closed in 7336788a9c3495745cb4b3eda7bc00d396a14b18. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-22 Thread via GitHub
libenchao commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1905174734 > @libenchao @snuyanzin I have updated the code in line with your feedback - please could you review again. Many thanks @davidradl One small suggestion, please do not

Re: [PR] [FLINK-23687][table-planner] Introduce partitioned lookup join to enforce input of LookupJoin to hash shuffle by lookup keys [flink]

2024-01-22 Thread via GitHub
yunfan123 commented on code in PR #24104: URL: https://github.com/apache/flink/pull/24104#discussion_r1462659082 ## docs/content/docs/dev/table/sql/queries/joins.md: ## @@ -326,6 +326,17 @@ FROM Orders AS o In the example above, the Orders table is enriched with data from

Re: [PR] [FLINK-34143] Modify the effective strategy of `execution.batch.adaptive.auto-parallelism.default-source-parallelism` [flink]

2024-01-22 Thread via GitHub
flinkbot commented on PR #24170: URL: https://github.com/apache/flink/pull/24170#issuecomment-1905196229 ## CI report: * 183c088f87286b2d0234c42a50e1e694ee5a0119 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34181) Migrate repo from ververica to apache

2024-01-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren updated FLINK-34181: -- Summary: Migrate repo from ververica to apache (was: Migrate repo from ververica to apche)

[jira] [Commented] (FLINK-34183) Add NOTICE files for Flink CDC project

2024-01-22 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809727#comment-17809727 ] Zhongqiang Gong commented on FLINK-34183: - [~leonard]  I'm willing to take this. > Add NOTICE

Re: [PR] [FLINK-33865][runtime] Adding an ITCase to ensure `exponential-delay.attempts-before-reset-backoff` works well [flink]

2024-01-22 Thread via GitHub
1996fanrui commented on code in PR #23942: URL: https://github.com/apache/flink/pull/23942#discussion_r1462744107 ## flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java: ## @@ -55,6 +64,54 @@ public class RestartStrategyOptions { @Internal

Re: [PR] [FLINK-33006] add e2e for Flink operator HA [flink-kubernetes-operator]

2024-01-22 Thread via GitHub
HuangZhenQiu commented on PR #756: URL: https://github.com/apache/flink-kubernetes-operator/pull/756#issuecomment-1905043266 @gyfora After enable HA, there are two operator pods. Takes 2 days to fix the shell scripts step by step. Currently the build is green, please review it at your

Re: [PR] [FLINK-24024][table-planner] support session window tvf in plan [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #23505: URL: https://github.com/apache/flink/pull/23505#discussion_r1462632191 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdWindowProperties.scala: ## @@ -92,13 +93,57 @@ class

[jira] [Assigned] (FLINK-33846) Remove outdated versions (need PMC role)

2024-01-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-33846: - Assignee: Qingsheng Ren > Remove outdated versions (need PMC role) >

Re: [PR] [FLINK-24024][table-planner] support session window tvf in plan [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #23505: URL: https://github.com/apache/flink/pull/23505#discussion_r1462653816 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/WindowUtil.scala: ## @@ -317,11 +352,17 @@ object WindowUtil { /**

[jira] [Updated] (FLINK-34143) Modify the effective strategy of `execution.batch.adaptive.auto-parallelism.default-source-parallelism`

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34143: --- Labels: pull-request-available (was: ) > Modify the effective strategy of >

[PR] [FLINK-34143] Modify the effective strategy of `execution.batch.adaptive.auto-parallelism.default-source-parallelism` [flink]

2024-01-22 Thread via GitHub
SinBex opened a new pull request, #24170: URL: https://github.com/apache/flink/pull/24170 ## What is the purpose of the change Currently, if users do not set the `execution.batch.adaptive.auto-parallelism.default-source-parallelism` configuration option, the AdaptiveBatchScheduler

Re: [PR] [FLINK-33565][Scheduler] ConcurrentExceptions works with exception merging [flink]

2024-01-22 Thread via GitHub
1996fanrui commented on PR #24003: URL: https://github.com/apache/flink/pull/24003#issuecomment-1905208562 > Fair enough. What about squashing the [FLINK-33565](https://issues.apache.org/jira/browse/FLINK-33565)-related commits into a single one? Hi @XComp , it's fine for me. Let me

[jira] [Commented] (FLINK-34187) Setup CI for Flink CDC project

2024-01-22 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809719#comment-17809719 ] Zhongqiang Gong commented on FLINK-34187: - [~leonard] I'm willing to take this, Please assign to

[jira] [Commented] (FLINK-34182) Migrate doc website from ververica to flink

2024-01-22 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809718#comment-17809718 ] Zhongqiang Gong commented on FLINK-34182: - [~leonard] I'm willing to take this, Please assign to

[jira] [Commented] (FLINK-34187) Setup CI for Flink CDC project

2024-01-22 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809725#comment-17809725 ] Zhongqiang Gong commented on FLINK-34187: - [~leonard] Here is the pr

Re: [PR] [FLINK-33728] Do not rewatch when KubernetesResourceManagerDriver wat… [flink]

2024-01-22 Thread via GitHub
xintongsong commented on code in PR #24163: URL: https://github.com/apache/flink/pull/24163#discussion_r1462693554 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java: ## @@ -102,6 +109,14 @@ public Fabric8FlinkKubeClient(

Re: [PR] [FLINK-34090][core] Introduce SerializerConfig [flink]

2024-01-22 Thread via GitHub
reswqa closed pull request #24127: [FLINK-34090][core] Introduce SerializerConfig URL: https://github.com/apache/flink/pull/24127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-34048][table] Support session window agg in table runtime instead of using legacy group window agg op [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #24150: URL: https://github.com/apache/flink/pull/24150#discussion_r1462662596 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/window/processors/UnsliceWindowAggProcessor.java: ## @@ -0,0

[jira] [Created] (FLINK-34204) Dispatch legacy serializer related methods in ExecutionConfig to SerializerConfig

2024-01-22 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-34204: -- Summary: Dispatch legacy serializer related methods in ExecutionConfig to SerializerConfig Key: FLINK-34204 URL: https://issues.apache.org/jira/browse/FLINK-34204

[jira] [Commented] (FLINK-34182) Migrate doc website from ververica to flink

2024-01-22 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809724#comment-17809724 ] Zhongqiang Gong commented on FLINK-34182: - [~leonard] Here is the pr

Re: [PR] [FLINK-25509][connector/kafka] Add RecordEvaluator to dynamically stop source based on de-serialized records [flink-connector-kafka]

2024-01-22 Thread via GitHub
ruanhang1993 commented on PR #76: URL: https://github.com/apache/flink-connector-kafka/pull/76#issuecomment-1905241938 Hi, @MartijnVisser. You are right. As the comments in [FLINK-25509](https://issues.apache.org/jira/browse/FLINK-25509), I need to put this feature to a version which

[jira] [Created] (FLINK-34205) Update flink-docker's Dockerfile and docker-entrypoint.sh to use BashJavaUtils for Flink configuration management

2024-01-22 Thread Junrui Li (Jira)
Junrui Li created FLINK-34205: - Summary: Update flink-docker's Dockerfile and docker-entrypoint.sh to use BashJavaUtils for Flink configuration management Key: FLINK-34205 URL:

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-22 Thread via GitHub
libenchao commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1905255051 @davidradl @snuyanzin I reviewed, and added a few cosmetic changes in

[jira] [Assigned] (FLINK-34196) FLIP-389 Annotate SingleThreadFetcherManager as PublicEvolving.

2024-01-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-34196: - Assignee: Hongshun Wang > FLIP-389 Annotate SingleThreadFetcherManager as

[jira] [Commented] (FLINK-33846) Remove outdated versions (need PMC role)

2024-01-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809701#comment-17809701 ] Qingsheng Ren commented on FLINK-33846: --- Flink 1.18.0 has been removed from SVN. There's no need

[jira] [Resolved] (FLINK-33846) Remove outdated versions (need PMC role)

2024-01-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-33846. --- Fix Version/s: 1.18.1 Resolution: Done > Remove outdated versions (need PMC role) >

[jira] [Updated] (FLINK-34090) Introduce SerializerConfig for serialization

2024-01-22 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-34090: --- Fix Version/s: 1.19.0 > Introduce SerializerConfig for serialization >

[jira] [Updated] (FLINK-34155) Recurring SqlExecutionException

2024-01-22 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-34155: -- Affects Version/s: 1.19.0 (was: 1.8.0) > Recurring

[jira] [Updated] (FLINK-34155) Recurring SqlExecutionException

2024-01-22 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-34155: -- Priority: Major (was: Blocker) > Recurring SqlExecutionException >

Re: [PR] [FLINK-34048][table] Support session window agg in table runtime instead of using legacy group window agg op [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #24150: URL: https://github.com/apache/flink/pull/24150#discussion_r1462680838 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/unslicing/UnslicingWindowProcessor.java: ## @@ -0,0 +1,26 @@

[jira] [Commented] (FLINK-34155) Recurring SqlExecutionException

2024-01-22 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809713#comment-17809713 ] Shengkai Fang commented on FLINK-34155: --- Hi [~jeyhunkarimov].  The exception mentioned in the

Re: [PR] [FLINK-34048][table] Support session window agg in table runtime instead of using legacy group window agg op [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #24150: URL: https://github.com/apache/flink/pull/24150#discussion_r1462661705 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/window/processors/UnsliceWindowAggProcessor.java: ## @@ -0,0

Re: [PR] [FLINK-34048][table] Support session window agg in table runtime instead of using legacy group window agg op [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #24150: URL: https://github.com/apache/flink/pull/24150#discussion_r1462661935 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/unslicing/UnslicingTriggerContextBase.java: ## @@ -0,0 +1,163

Re: [PR] [FLINK-33668] Decoupling Shuffle network memory and job topology [flink]

2024-01-22 Thread via GitHub
xintongsong commented on code in PR #23851: URL: https://github.com/apache/flink/pull/23851#discussion_r1461707655 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/CreditBasedInputBuffersUsageGauge.java: ## @@ -28,27 +31,35 @@ */ public class

Re: [PR] [FLINK-24024][table-planner] support session window tvf in plan [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #23505: URL: https://github.com/apache/flink/pull/23505#discussion_r1462628183 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/WindowUtil.scala: ## @@ -234,11 +235,45 @@ object WindowUtil {

Re: [PR] [FLINK-24024][table-planner] support session window tvf in plan [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #23505: URL: https://github.com/apache/flink/pull/23505#discussion_r1462628799 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/WindowUtil.scala: ## @@ -392,4 +433,54 @@ object WindowUtil { }

[jira] [Closed] (FLINK-34090) Introduce SerializerConfig for serialization

2024-01-22 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-34090. -- Resolution: Fixed master(1.19) via 7336788a9c3495745cb4b3eda7bc00d396a14b18. > Introduce

Re: [PR] [FLINK-24024][table-planner] support session window tvf in plan [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #23505: URL: https://github.com/apache/flink/pull/23505#discussion_r1462653012 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/FlinkConvertletTable.java: ## @@ -88,4 +106,106 @@ private RexNode

Re: [PR] [FLINK-24024][table-planner] support session window tvf in plan [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #23505: URL: https://github.com/apache/flink/pull/23505#discussion_r1462652354 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -5335,6 +5364,11 @@ public RexNode

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2024-01-22 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809712#comment-17809712 ] Benchao Li commented on FLINK-33365: [~martijnvisser]  The PR is very close to merge now, I'll try

Re: [PR] [FLINK-33865][runtime] Adding an ITCase to ensure `exponential-delay.attempts-before-reset-backoff` works well [flink]

2024-01-22 Thread via GitHub
qinf commented on code in PR #23942: URL: https://github.com/apache/flink/pull/23942#discussion_r1462656608 ## flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java: ## @@ -55,6 +64,54 @@ public class RestartStrategyOptions { @Internal

Re: [PR] [FLINK-34048][table] Support session window agg in table runtime instead of using legacy group window agg op [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #24150: URL: https://github.com/apache/flink/pull/24150#discussion_r1462666042 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/window/processors/UnsliceWindowAggProcessor.java: ## @@ -0,0

Re: [PR] [FLINK-34029][runtime-web] Support different profiling mode on Flink WEB [flink]

2024-01-22 Thread via GitHub
Myasuka commented on code in PR #24130: URL: https://github.com/apache/flink/pull/24130#discussion_r1461481473 ## flink-runtime-web/web-dashboard/src/app/pages/job-manager/profiler/job-manager-profiler.component.html: ## @@ -31,6 +31,58 @@ > +

[jira] [Created] (FLINK-34193) Remove usage of Flink-Shaded Jackson and Snakeyaml in flink-connector-kafka

2024-01-22 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-34193: -- Summary: Remove usage of Flink-Shaded Jackson and Snakeyaml in flink-connector-kafka Key: FLINK-34193 URL: https://issues.apache.org/jira/browse/FLINK-34193

[jira] [Updated] (FLINK-33728) Do not rewatch when KubernetesResourceManagerDriver watch fail

2024-01-22 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaogang zhou updated FLINK-33728: -- Summary: Do not rewatch when KubernetesResourceManagerDriver watch fail (was: do not rewatch

[PR] [FLINK-33728] Do not rewatch when KubernetesResourceManagerDriver wat… [flink]

2024-01-22 Thread via GitHub
zhougit86 opened a new pull request, #24163: URL: https://github.com/apache/flink/pull/24163 …ch fail ## What is the purpose of the change prevent jm restart in case kubernetes fails to handle watch request ## Brief change log use

Re: [PR] [FLINK-21949][table] Support ARRAY_AGG aggregate function [flink]

2024-01-22 Thread via GitHub
Jiabao-Sun commented on PR #23411: URL: https://github.com/apache/flink/pull/23411#issuecomment-1903588731 Hi @dawidwys, please help review it again when you have time. Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-34178][autoscaler] Fix the bug that observed scaling restart time is always great than `stabilization.interval` [flink-kubernetes-operator]

2024-01-22 Thread via GitHub
mxm commented on code in PR #759: URL: https://github.com/apache/flink-kubernetes-operator/pull/759#discussion_r1461587441 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -160,14 +160,23 @@ private void runScalingLogic(Context ctx,

Re: [PR] [FLINK-25509][connector/kafka] Add RecordEvaluator to dynamically stop source based on de-serialized records [flink-connector-kafka]

2024-01-22 Thread via GitHub
MartijnVisser commented on PR #76: URL: https://github.com/apache/flink-connector-kafka/pull/76#issuecomment-1903631209 > So we need wait until the Flink 1.17 is dropped in Kafka connector and use the 1.18 Flink to check this PR. @ruanhang1993 I think that means that in this PR,

Re: [PR] [FLINK-33198][Format/Avro] support local timezone timestamp logic type in AVRO [flink]

2024-01-22 Thread via GitHub
HuangZhenQiu commented on code in PR #23511: URL: https://github.com/apache/flink/pull/23511#discussion_r1461602408 ## flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroFormatFactory.java: ## @@ -61,6 +62,7 @@ public DecodingFormat> createDecodingFormat(

Re: [PR] [FLINK-34194][ci] Updates test CI container to be based on Ubuntu 22.04 [flink]

2024-01-22 Thread via GitHub
flinkbot commented on PR #24165: URL: https://github.com/apache/flink/pull/24165#issuecomment-1903676042 ## CI report: * 3422abec3d7a03b3e98bed92d300a630b14b3f86 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] Reference flink-connector-parent new 1.1.0 release [flink-web]

2024-01-22 Thread via GitHub
echauchot opened a new pull request, #717: URL: https://github.com/apache/flink-web/pull/717 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [FLINK-33728] Do not rewatch when KubernetesResourceManagerDriver wat… [flink]

2024-01-22 Thread via GitHub
zhougit86 commented on PR #24163: URL: https://github.com/apache/flink/pull/24163#issuecomment-1903769843 @xintongsong Would you please take a look and let me know your thinking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Closed] (FLINK-33768) Support dynamic source parallelism inference for batch jobs

2024-01-22 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-33768. --- Fix Version/s: 1.19.0 Resolution: Done master/release-1.19: c3c836216eaaaf24c1add3b490c8f425fda01d7c

[jira] [Closed] (FLINK-34179) More than one taskmanager is not coming up in flink (session mode) in aws eks cluster

2024-01-22 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-34179. -- Resolution: Information Provided > More than one taskmanager is not coming up in flink

[jira] [Commented] (FLINK-34135) A number of ci failures with Access to the path '.../_work/_temp/containerHandlerInvoker.js' is denied.

2024-01-22 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809307#comment-17809307 ] Martijn Visser commented on FLINK-34135: It looks to be stable again > A number of ci failures

Re: [PR] [FLINK-33198][Format/Avro] support local timezone timestamp logic type in AVRO [flink]

2024-01-22 Thread via GitHub
leonardBang commented on code in PR #23511: URL: https://github.com/apache/flink/pull/23511#discussion_r1461554379 ## flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDeserializationSchema.java: ## @@ -339,7 +365,7 @@ private Time convertToTime(Object

Re: [PR] [FLINK-33198][Format/Avro] support local timezone timestamp logic type in AVRO [flink]

2024-01-22 Thread via GitHub
HuangZhenQiu commented on code in PR #23511: URL: https://github.com/apache/flink/pull/23511#discussion_r1461558894 ## pom.xml: ## @@ -1840,7 +1840,7 @@ under the License.

Re: [PR] [FLINK-25509][connector/kafka] Add RecordEvaluator to dynamically stop source based on de-serialized records [flink-connector-kafka]

2024-01-22 Thread via GitHub
ruanhang1993 commented on PR #76: URL: https://github.com/apache/flink-connector-kafka/pull/76#issuecomment-1903610004 Thanks, @MartijnVisser . This PR relies on the API changes in FLIP-208, which released in 1.18. So we need wait until the Flink 1.17 is dropped in Kafka connector

Re: [PR] [FLINK-33721][core] Extend BashJavaUtils to support reading and writing standard yaml file. [flink]

2024-01-22 Thread via GitHub
zhuzhurk commented on code in PR #24091: URL: https://github.com/apache/flink/pull/24091#discussion_r1461460681 ## flink-runtime/src/main/java/org/apache/flink/runtime/util/bash/BashJavaUtils.java: ## @@ -175,6 +176,9 @@ public enum Command { GET_TM_RESOURCE_PARAMS,

[PR] [FLINK-34194][ci] Updates test CI container to be based on Ubuntu 22.04 [flink]

2024-01-22 Thread via GitHub
XComp opened a new pull request, #24165: URL: https://github.com/apache/flink/pull/24165 ## What is the purpose of the change The GitHub Actions workflow (FLINK-33901) requires us to upgrade to Ubuntu 22.04 (or 20.04) (see further details in sub-issue FLINK-33923). The Azure

[jira] [Updated] (FLINK-34194) Upgrade Flink CI Docker container to Ubuntu 22.04

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34194: --- Labels: github-actions pull-request-available (was: github-actions) > Upgrade Flink CI

Re: [PR] [FLINK-34029][runtime-web] Support different profiling mode on Flink WEB [flink]

2024-01-22 Thread via GitHub
yuchen-ecnu commented on code in PR #24130: URL: https://github.com/apache/flink/pull/24130#discussion_r1461682660 ## flink-runtime-web/web-dashboard/src/app/pages/job-manager/profiler/job-manager-profiler.component.html: ## @@ -31,6 +31,58 @@ > +

Re: [PR] [FLINK-33565][Scheduler] ConcurrentExceptions works with exception merging [flink]

2024-01-22 Thread via GitHub
1996fanrui commented on PR #24003: URL: https://github.com/apache/flink/pull/24003#issuecomment-1903758592 > LGTM  Thanks for your efforts, @1996fanrui, and for keeping up with my nitty comments. I enjoyed the discussions in this PR. Thanks @XComp for the patient review, I

Re: [PR] [hotfix][table] Avoid KeyedLookupJoinWrapper sending duplicate delete record for left join when state expired [flink]

2024-01-22 Thread via GitHub
flinkbot commented on PR #24164: URL: https://github.com/apache/flink/pull/24164#issuecomment-1903627979 ## CI report: * 3df653a9d45cfe8f65818a6556020042c4429e55 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-34194) Upgrade Flink CI Docker container to Ubuntu 22.04

2024-01-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-34194: - Assignee: Matthias Pohl > Upgrade Flink CI Docker container to Ubuntu 22.04 >

[jira] [Updated] (FLINK-34194) Upgrade Flink CI Docker container to Ubuntu 22.04

2024-01-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34194: -- Description: The current CI Docker image is based on Ubuntu 16.04. We already use 20.04 for

Re: [PR] [FLINK-33768] Support dynamic source parallelism inference for batch jobs [flink]

2024-01-22 Thread via GitHub
zhuzhurk closed pull request #24087: [FLINK-33768] Support dynamic source parallelism inference for batch jobs URL: https://github.com/apache/flink/pull/24087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-23687][table-planner] Introduce partitioned lookup join to enforce input of LookupJoin to hash shuffle by lookup keys [flink]

2024-01-22 Thread via GitHub
LB-Yu commented on code in PR #24104: URL: https://github.com/apache/flink/pull/24104#discussion_r1461708094 ## docs/content/docs/dev/table/sql/queries/joins.md: ## @@ -326,6 +326,17 @@ FROM Orders AS o In the example above, the Orders table is enriched with data from the

Re: [PR] [FLINK-23687][table-planner] Introduce partitioned lookup join to enforce input of LookupJoin to hash shuffle by lookup keys [flink]

2024-01-22 Thread via GitHub
LB-Yu commented on code in PR #24104: URL: https://github.com/apache/flink/pull/24104#discussion_r1461708094 ## docs/content/docs/dev/table/sql/queries/joins.md: ## @@ -326,6 +326,17 @@ FROM Orders AS o In the example above, the Orders table is enriched with data from the

Re: [PR] [FLINK-34143] Modify the effective strategy of `execution.batch.adaptive.auto-parallelism.default-source-parallelism` [flink]

2024-01-22 Thread via GitHub
zhuzhurk commented on code in PR #24170: URL: https://github.com/apache/flink/pull/24170#discussion_r1462747422 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismAndInputInfosDecider.java: ## @@ -559,7 +559,7 @@ static

Re: [PR] [FLINK-34143] Modify the effective strategy of `execution.batch.adaptive.auto-parallelism.default-source-parallelism` [flink]

2024-01-22 Thread via GitHub
zhuzhurk commented on code in PR #24170: URL: https://github.com/apache/flink/pull/24170#discussion_r1462752170 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismAndInputInfosDecider.java: ## @@ -559,7 +559,7 @@ static

[PR] [FLINK-34196][FLIP-389] Annotate SingleThreadFetcherManager as PublicEvolving. [flink]

2024-01-22 Thread via GitHub
loserwang1024 opened a new pull request, #24171: URL: https://github.com/apache/flink/pull/24171 ## What is the purpose of the change As shown in [FLIP-389](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=278465498), this PR has 2 goals: - To expose the

Re: [PR] [FLINK-34165][1.17] update the apache download url for asc [flink-docker]

2024-01-22 Thread via GitHub
JingGe merged PR #171: URL: https://github.com/apache/flink-docker/pull/171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33263][table-planner] Implement ParallelismProvider for sources in the table planner [flink]

2024-01-22 Thread via GitHub
BIOINSu commented on code in PR #24128: URL: https://github.com/apache/flink/pull/24128#discussion_r1462814218 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/SourceTransformationWrapper.java: ## @@ -0,0 +1,70 @@ +/* +Licensed to the Apache

Re: [PR] [FLINK-34165][1.15] update the apache download url for asc [flink-docker]

2024-01-22 Thread via GitHub
JingGe merged PR #173: URL: https://github.com/apache/flink-docker/pull/173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-34205) Update flink-docker's Dockerfile and docker-entrypoint.sh to use BashJavaUtils for Flink configuration management

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34205: --- Labels: pull-request-available (was: ) > Update flink-docker's Dockerfile and

Re: [PR] [FLINK-34165][1.16] update the apache download url for asc [flink-docker]

2024-01-22 Thread via GitHub
JingGe merged PR #172: URL: https://github.com/apache/flink-docker/pull/172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-34115) TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate fails

2024-01-22 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809769#comment-17809769 ] Jane Chan commented on FLINK-34115: --- Sorry for the late update. I attempted to reproduce the failure,

Re: [PR] [FLINK-33263][table-planner] Implement ParallelismProvider for sources in the table planner [flink]

2024-01-22 Thread via GitHub
BIOINSu commented on code in PR #24128: URL: https://github.com/apache/flink/pull/24128#discussion_r1462818847 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java: ## @@ -105,54 +112,92 @@

Re: [PR] [FLINK-33263][table-planner] Implement ParallelismProvider for sources in the table planner [flink]

2024-01-22 Thread via GitHub
BIOINSu commented on PR #24128: URL: https://github.com/apache/flink/pull/24128#issuecomment-1905451090 @libenchao Thanks for the review comments. In fact, the "Deal with changelog messages" is necessary. In the previous version of the code, since consuming the changelog stream

Re: [PR] [FLINK-33403] Bump flink version to 1.18.1 for flink-kubernetes-operator [flink-kubernetes-operator]

2024-01-22 Thread via GitHub
1996fanrui commented on PR #697: URL: https://github.com/apache/flink-kubernetes-operator/pull/697#issuecomment-1905451248 Hi @gyfora , this PR is done for now due to 1.18.1 is released. Please help take a look in your free time, thanks~ -- This is an automated message from the

[jira] [Closed] (FLINK-34141) Bash exited with code '143'

2024-01-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl closed FLINK-34141. - Resolution: Cannot Reproduce Thanks for reporting the issues [~xuyangzhong]. We experienced CI

[jira] [Resolved] (FLINK-34029) Support different profiling mode on Flink WEB

2024-01-22 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-34029. -- Fix Version/s: 1.19.0 Assignee: Yu Chen Resolution: Fixed merged in master:

  1   2   3   >