[jira] [Commented] (FLINK-2523) Make task canceling interrupt interval configurable

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139415#comment-15139415 ] ASF GitHub Bot commented on FLINK-2523: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3382] Improve clarity of object reuse i...

2016-02-09 Thread ggevay
Github user ggevay commented on the pull request: https://github.com/apache/flink/pull/1614#issuecomment-182025617 Shouldn't the current record remain valid if `hasNext()` returned true? I mean the user might be holding on to the object returned in `next`, and expect it to not be

[jira] [Commented] (FLINK-3382) Improve clarity of object reuse in ReusingMutableToRegularIteratorWrapper

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139530#comment-15139530 ] ASF GitHub Bot commented on FLINK-3382: --- Github user ggevay commented on the pull request:

[jira] [Commented] (FLINK-3373) Using a newer library of Apache HttpClient than 4.2.6 will get class loading problems

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139694#comment-15139694 ] ASF GitHub Bot commented on FLINK-3373: --- GitHub user StephanEwen opened a pull request:

[GitHub] flink pull request: [FLINK-3382] Improve clarity of object reuse i...

2016-02-09 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1614#issuecomment-182035391 Ah, yes, now I see. I'll just burn this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-3382) Improve clarity of object reuse in ReusingMutableToRegularIteratorWrapper

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139652#comment-15139652 ] ASF GitHub Bot commented on FLINK-3382: --- Github user greghogan commented on the pull request:

[jira] [Commented] (FLINK-3382) Improve clarity of object reuse in ReusingMutableToRegularIteratorWrapper

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139653#comment-15139653 ] ASF GitHub Bot commented on FLINK-3382: --- Github user greghogan closed the pull request at:

[jira] [Comment Edited] (FLINK-3333) Documentation about object reuse should be improved

2016-02-09 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139151#comment-15139151 ] Greg Hogan edited comment on FLINK- at 2/9/16 8:07 PM: --- Apache Flink

[GitHub] flink pull request: [FLINK-3373] [build] Shade away Hadoop's HTTP ...

2016-02-09 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/1615 [FLINK-3373] [build] Shade away Hadoop's HTTP Components dependency This makes the HTTP Components dependency disappear from the core classpath, allowing users to use their own version of the

[GitHub] flink pull request: [FLINK-3382] Improve clarity of object reuse i...

2016-02-09 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/1614 [FLINK-3382] Improve clarity of object reuse in ReusingMutableToRegularIteratorWrapper You can merge this pull request into a Git repository by running: $ git pull

[GitHub] flink pull request: [FLINK-3260] [runtime] Enforce terminal state ...

2016-02-09 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1613#discussion_r52368138 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java --- @@ -107,7 +108,7 @@ private static final

[jira] [Commented] (FLINK-2380) Allow to configure default FS for file inputs

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139717#comment-15139717 ] ASF GitHub Bot commented on FLINK-2380: --- Github user rmetzger commented on the pull request:

[jira] [Commented] (FLINK-3382) Improve clarity of object reuse in ReusingMutableToRegularIteratorWrapper

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139441#comment-15139441 ] ASF GitHub Bot commented on FLINK-3382: --- GitHub user greghogan opened a pull request:

[jira] [Commented] (FLINK-3260) ExecutionGraph gets stuck in state FAILING

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139699#comment-15139699 ] ASF GitHub Bot commented on FLINK-3260: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-3260) ExecutionGraph gets stuck in state FAILING

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139701#comment-15139701 ] ASF GitHub Bot commented on FLINK-3260: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-3260] [runtime] Enforce terminal state ...

2016-02-09 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1613#issuecomment-182046481 Looks good, with one inline comment. Otherwise, +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1585#discussion_r52281750 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java --- @@ -1377,6 +1377,24 @@ public long count() throws Exception {

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1585#discussion_r52281721 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java --- @@ -1377,6 +1377,24 @@ public long count() throws Exception {

[jira] [Commented] (FLINK-1966) Add support for predictive model markup language (PMML)

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138686#comment-15138686 ] ASF GitHub Bot commented on FLINK-1966: --- Github user chobeat commented on the pull request:

[jira] [Commented] (FLINK-1966) Add support for predictive model markup language (PMML)

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138722#comment-15138722 ] ASF GitHub Bot commented on FLINK-1966: --- Github user sachingoel0101 commented on the pull request:

[jira] [Commented] (FLINK-3373) Using a newer library of Apache HttpClient than 4.2.6 will get class loading problems

2016-02-09 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138787#comment-15138787 ] Stephan Ewen commented on FLINK-3373: - Would it help if Flink simply updated the HTTP Client to the

[jira] [Commented] (FLINK-3226) Translate optimized logical Table API plans into physical plans representing DataSet programs

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138788#comment-15138788 ] ASF GitHub Bot commented on FLINK-3226: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3226] Implement a CodeGenerator for an ...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1595#discussion_r52293343 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138570#comment-15138570 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1585#discussion_r52282118 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/SortPartitionOperator.java --- @@ -36,27 +40,58 @@ */ public class

[jira] [Commented] (FLINK-3355) Allow passing RocksDB Option to RocksDBStateBackend

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138775#comment-15138775 ] ASF GitHub Bot commented on FLINK-3355: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: [FLINK-3371] [api breaking] Move TriggerResult...

2016-02-09 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1603#issuecomment-181813971 Exactly, the `AlignedTrigger` will have an `AlignedTriggerContext` without Key/Value state. --- If your project is set up for it, you can reply to this email and

[GitHub] flink pull request: [FLINK-3355] [rocksdb backend] Allow passing o...

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1608 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3376) Add an illustration of Event Time and Watermarks to the docs

2016-02-09 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138781#comment-15138781 ] Stephan Ewen commented on FLINK-3376: - Some of that information is available, but hidden deep in the

[jira] [Commented] (FLINK-3226) Translate optimized logical Table API plans into physical plans representing DataSet programs

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138784#comment-15138784 ] ASF GitHub Bot commented on FLINK-3226: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3226] Implement a CodeGenerator for an ...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1595#discussion_r52293004 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala --- @@ -0,0 +1,661 @@ +/* + * Licensed

[jira] [Assigned] (FLINK-3359) Make RocksDB file copies asynchronous

2016-02-09 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-3359: --- Assignee: Aljoscha Krettek > Make RocksDB file copies asynchronous >

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1585#discussion_r52282391 --- Diff: flink-tests/src/test/scala/org/apache/flink/api/scala/operators/SortPartitionITCase.scala --- @@ -166,6 +167,58 @@ class SortPartitionITCase(mode:

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138594#comment-15138594 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-1966) Add support for predictive model markup language (PMML)

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138593#comment-15138593 ] ASF GitHub Bot commented on FLINK-1966: --- Github user sachingoel0101 commented on the pull request:

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1585#discussion_r52282336 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/SortPartitionITCase.java --- @@ -197,6 +198,58 @@ public void

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138591#comment-15138591 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181772422 That said, just for a comparison purpose, spark has its own model export and import feature, along with pmml export. Hoping to fully support pmml import in a

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1585#discussion_r52282275 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/DataSet.scala --- @@ -1508,6 +1508,31 @@ class DataSet[T: ClassTag](set: JavaDataSet[T]) {

[GitHub] flink pull request: [FLINK-3243] Fix Interplay of TimeCharacterist...

2016-02-09 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1513#issuecomment-181777122 You're right, I'm changing it. But it was also me who didn't notice when we put it in initially :sweat_smile: --- If your project is set up for it, you can reply to

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread chobeat
Github user chobeat commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181790876 I agree with @sachingoel0101 on the import complexity but, from our point of view, Flink is the perfect platform to evaluate models in streaming and we are using it

[jira] [Commented] (FLINK-3366) Rename @Experimental annotation to @PublicEvolving

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138701#comment-15138701 ] ASF GitHub Bot commented on FLINK-3366: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-3366] Rename @Experimental annotation t...

2016-02-09 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1599#issuecomment-181794025 Can you update the JavaDoc of the `@PublicEvolving` annotation? Otherwise, good to merge... --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: [FLINK-3226] Implement a CodeGenerator for an ...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1595#discussion_r52291201 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala --- @@ -0,0 +1,661 @@ +/* + * Licensed

[jira] [Commented] (FLINK-3243) Fix Interplay of TimeCharacteristic and Time Windows

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138768#comment-15138768 ] ASF GitHub Bot commented on FLINK-3243: --- Github user aljoscha commented on the pull request:

[GitHub] flink pull request: [FLINK-3243] Fix Interplay of TimeCharacterist...

2016-02-09 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1513#issuecomment-181810307 I rebased it to master and updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-3226] Implement a CodeGenerator for an ...

2016-02-09 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1595#issuecomment-181824403 Hi Timo, the PR looks really good :-) I found the following issues / questions: - Accessing of POJO fields might not work. - Can you add method comments

[jira] [Commented] (FLINK-3226) Translate optimized logical Table API plans into physical plans representing DataSet programs

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138805#comment-15138805 ] ASF GitHub Bot commented on FLINK-3226: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1585#discussion_r52282174 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/SortPartitionOperator.java --- @@ -79,58 +119,41 @@ public

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138577#comment-15138577 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138589#comment-15138589 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-1966) Add support for predictive model markup language (PMML)

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138576#comment-15138576 ] ASF GitHub Bot commented on FLINK-1966: --- Github user sachingoel0101 commented on the pull request:

[jira] [Commented] (FLINK-3374) CEPITCase testSimplePatternEventTime fails

2016-02-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138575#comment-15138575 ] Till Rohrmann commented on FLINK-3374: -- Is this reproducible? Looks to me as if the testing file

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181771679 As the original author of this PR, I'd say this: I tried implementing the import features but they aren't worth it. You have to discard most of the valid

[jira] [Commented] (FLINK-2832) Failing test: RandomSamplerTest.testReservoirSamplerWithReplacement

2016-02-09 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138691#comment-15138691 ] Robert Metzger commented on FLINK-2832: --- Another instance:

[jira] [Commented] (FLINK-1966) Add support for predictive model markup language (PMML)

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138728#comment-15138728 ] ASF GitHub Bot commented on FLINK-1966: --- Github user chobeat commented on the pull request:

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread chobeat
Github user chobeat commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181799783 @sachingoel0101 I agree. Nonetheless, an easy way to store and move a model generated in batch to a streaming enviroment would be a really useful feature and we go back

[jira] [Created] (FLINK-3376) Add an illustration of Event Time and Watermarks to the docsq

2016-02-09 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-3376: --- Summary: Add an illustration of Event Time and Watermarks to the docsq Key: FLINK-3376 URL: https://issues.apache.org/jira/browse/FLINK-3376 Project: Flink

[jira] [Updated] (FLINK-3376) Add an illustration of Event Time and Watermarks to the docs

2016-02-09 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen updated FLINK-3376: Summary: Add an illustration of Event Time and Watermarks to the docs (was: Add an illustration of

[jira] [Commented] (FLINK-3286) Remove JDEB Debian Package code from flink-dist

2016-02-09 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138794#comment-15138794 ] Robert Metzger commented on FLINK-3286: --- Removed the files as well:

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1585#discussion_r52281965 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java --- @@ -1377,6 +1377,24 @@ public long count() throws Exception {

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138573#comment-15138573 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138571#comment-15138571 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3243] Fix Interplay of TimeCharacterist...

2016-02-09 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1513#issuecomment-181776065 For new classes, it makes sense. Was a mistake on my end to name them like this in the first place. But users that adopted this draw in my experience more

[jira] [Commented] (FLINK-3374) CEPITCase testSimplePatternEventTime fails

2016-02-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138626#comment-15138626 ] Till Rohrmann commented on FLINK-3374: -- Probably because it uses {{WriteMode.OVERWRITE}}. >

[jira] [Assigned] (FLINK-3374) CEPITCase testSimplePatternEventTime fails

2016-02-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-3374: Assignee: Till Rohrmann > CEPITCase testSimplePatternEventTime fails >

[jira] [Commented] (FLINK-3066) Kafka producer fails on leader change

2016-02-09 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138677#comment-15138677 ] Gyula Fora commented on FLINK-3066: --- Thank you Robert for the help, it is a good catch :) > Kafka

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181798643 That is a good point. In streaming setting, it does indeed make sense for the model to be available. However, in my opinion, then it would make sense to actually

[jira] [Commented] (FLINK-3371) Move TriggerCotext and TriggerResult to their own classes

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138754#comment-15138754 ] ASF GitHub Bot commented on FLINK-3371: --- Github user aljoscha commented on the pull request:

[GitHub] flink pull request: [FLINK-3355] [rocksdb backend] Allow passing o...

2016-02-09 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1608#issuecomment-181807481 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-3371] [api breaking] Move TriggerResult...

2016-02-09 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1603#issuecomment-181807335 You are not moving `TriggerContext` because it is specific to Trigger, correct? Otherwise it looks good to merge. :+1: --- If your project is set up for it,

[jira] [Commented] (FLINK-3355) Allow passing RocksDB Option to RocksDBStateBackend

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138755#comment-15138755 ] ASF GitHub Bot commented on FLINK-3355: --- Github user aljoscha commented on the pull request:

[jira] [Created] (FLINK-3375) Allow Watermark Generation in the Kafka Source

2016-02-09 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-3375: --- Summary: Allow Watermark Generation in the Kafka Source Key: FLINK-3375 URL: https://issues.apache.org/jira/browse/FLINK-3375 Project: Flink Issue Type:

[jira] [Created] (FLINK-3374) CEPITCase testSimplePatternEventTime fails

2016-02-09 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-3374: -- Summary: CEPITCase testSimplePatternEventTime fails Key: FLINK-3374 URL: https://issues.apache.org/jira/browse/FLINK-3374 Project: Flink Issue Type: Test

[jira] [Commented] (FLINK-3243) Fix Interplay of TimeCharacteristic and Time Windows

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138616#comment-15138616 ] ASF GitHub Bot commented on FLINK-3243: --- Github user aljoscha commented on the pull request:

[jira] [Commented] (FLINK-3374) CEPITCase testSimplePatternEventTime fails

2016-02-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138617#comment-15138617 ] Till Rohrmann commented on FLINK-3374: -- Hmm I just saw that the CEPITCase creates a file under the

[GitHub] flink pull request: [FLINK-3226] Translate logical aggregations to...

2016-02-09 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1600#issuecomment-181794348 Thanks for the feedback @tillrohrmann, @twalthr! I've moved the classes to `org.apache.flink.api.table.runtime` and tried to shorten the aggregates code using

[jira] [Commented] (FLINK-3226) Translate optimized logical Table API plans into physical plans representing DataSet programs

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138705#comment-15138705 ] ASF GitHub Bot commented on FLINK-3226: --- Github user vasia commented on the pull request:

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181803637 I'm all for that. Flink's models should be transferable at least across flink. But that should be part of a separate PR, and not block this one as it has been

[jira] [Commented] (FLINK-3371) Move TriggerCotext and TriggerResult to their own classes

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138777#comment-15138777 ] ASF GitHub Bot commented on FLINK-3371: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-1966) Add support for predictive model markup language (PMML)

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138528#comment-15138528 ] ASF GitHub Bot commented on FLINK-1966: --- Github user chobeat commented on the pull request:

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread chobeat
Github user chobeat commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181757426 Well that wouldn't be a problem for the export: you will create and therefore export only models that have `double` as datatype for parameters but that's not an issue.

[jira] [Created] (FLINK-3373) Using a newer library of Apache HttpClient than 4.2.6 will get class loading problems

2016-02-09 Thread Jakob Sultan Ericsson (JIRA)
Jakob Sultan Ericsson created FLINK-3373: Summary: Using a newer library of Apache HttpClient than 4.2.6 will get class loading problems Key: FLINK-3373 URL:

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138598#comment-15138598 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on the pull request:

[jira] [Commented] (FLINK-3374) CEPITCase testSimplePatternEventTime fails

2016-02-09 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138600#comment-15138600 ] Stephan Ewen commented on FLINK-3374: - My guess is that the parent path does not exist. Maybe an issue

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138595#comment-15138595 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1585#issuecomment-181773503 The refactoring looks good, @chiwanpark. I have just a few minor remarks. The PR can be resolved after these have been addressed. --- If your project is set up for

[jira] [Commented] (FLINK-3243) Fix Interplay of TimeCharacteristic and Time Windows

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138610#comment-15138610 ] ASF GitHub Bot commented on FLINK-3243: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-3355] [rocksdb backend] Allow passing o...

2016-02-09 Thread gyfora
Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/1608#issuecomment-181800676 Looks good :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-3355) Allow passing RocksDB Option to RocksDBStateBackend

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138734#comment-15138734 ] ASF GitHub Bot commented on FLINK-3355: --- Github user gyfora commented on the pull request:

[jira] [Commented] (FLINK-1966) Add support for predictive model markup language (PMML)

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138751#comment-15138751 ] ASF GitHub Bot commented on FLINK-1966: --- Github user sachingoel0101 commented on the pull request:

[jira] [Commented] (FLINK-3226) Translate optimized logical Table API plans into physical plans representing DataSet programs

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138764#comment-15138764 ] ASF GitHub Bot commented on FLINK-3226: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3377) Remove final flag from ResultPartitionWriter class

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139016#comment-15139016 ] ASF GitHub Bot commented on FLINK-3377: --- GitHub user zentol opened a pull request:

[jira] [Created] (FLINK-3378) Consolidate TestingCluster and FokableFlinkMiniCluster

2016-02-09 Thread Maximilian Michels (JIRA)
Maximilian Michels created FLINK-3378: - Summary: Consolidate TestingCluster and FokableFlinkMiniCluster Key: FLINK-3378 URL: https://issues.apache.org/jira/browse/FLINK-3378 Project: Flink

[jira] [Updated] (FLINK-3377) Remove final flag from ResultPartitionWriter class

2016-02-09 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-3377: Summary: Remove final flag from ResultPartitionWriter class (was: Remove final flag from

[jira] [Created] (FLINK-3377) Remove final flag from ResultPatitionWriter class

2016-02-09 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-3377: --- Summary: Remove final flag from ResultPatitionWriter class Key: FLINK-3377 URL: https://issues.apache.org/jira/browse/FLINK-3377 Project: Flink Issue

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139041#comment-15139041 ] ASF GitHub Bot commented on FLINK-2237: --- Github user ggevay commented on the pull request:

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-09 Thread ggevay
Github user ggevay commented on the pull request: https://github.com/apache/flink/pull/1517#issuecomment-181907722 What I'm not sure about is the `closeUserCode` call in `ChainedReduceCombineDriver.closeTask`. Those other chained drivers that have a `running` flag for indicating

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-02-09 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139040#comment-15139040 ] Chesnay Schepler commented on FLINK-2055: - What's the status on this one? > Implement Streaming

[GitHub] flink pull request: [FLINK-3107] [runtime] Start checkpoint ID cou...

2016-02-09 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/1610 [FLINK-3107] [runtime] Start checkpoint ID counter with periodic scheduler Problem: The job manager enables checkpoints during submission of streaming programs. This can lead to call to a call to

  1   2   3   >