[jira] [Commented] (FLINK-5266) Eagerly project unused fields when selecting aggregation fields

2016-12-06 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728026#comment-15728026 ] Fabian Hueske commented on FLINK-5266: -- I see. Thanks for the detailed explanation [~ykt836]! I

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728006#comment-15728006 ] ASF GitHub Bot commented on FLINK-2254: --- Github user mushketyk commented on a diff in the pull

[GitHub] flink pull request #2564: [FLINK-2254] Add BipartiateGraph class

2016-12-06 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2564#discussion_r91239047 --- Diff: flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/ProjectionTest.java --- @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-1102) Projection operator for streaming

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728002#comment-15728002 ] ASF GitHub Bot commented on FLINK-1102: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-4391) Provide support for asynchronous operations over streams

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1572#comment-1572 ] ASF GitHub Bot commented on FLINK-4391: --- Github user bjlovegithub commented on the issue:

[GitHub] flink issue #2629: [FLINK-4391] Provide support for asynchronous operations ...

2016-12-06 Thread bjlovegithub
Github user bjlovegithub commented on the issue: https://github.com/apache/flink/pull/2629 Hi @tillrohrmann . I have updated the PR. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-1102) Projection operator for streaming

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727768#comment-15727768 ] ASF GitHub Bot commented on FLINK-1102: --- GitHub user aljoscha opened a pull request:

[jira] [Commented] (FLINK-5247) Setting allowedLateness to a non-zero value should throw exception for processing-time windows

2016-12-06 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727584#comment-15727584 ] Aljoscha Krettek commented on FLINK-5247: - Changing the scope of this issue and then changing the

[jira] [Commented] (FLINK-5035) Don't Write TypeSerializer to Heap State Snapshot

2016-12-06 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727582#comment-15727582 ] Aljoscha Krettek commented on FLINK-5035: - I think [~srichter] is doing work in a different

[jira] [Commented] (FLINK-5266) Eagerly project unused fields when selecting aggregation fields

2016-12-06 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727375#comment-15727375 ] Kurt Young commented on FLINK-5266: --- Hi [~fhueske], i have checked your PR #2926, and it doesn't solve

[GitHub] flink issue #2653: [FLINK-4469] [table] Add support for user defined table f...

2016-12-06 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2653 Thanks @twalthr , I will add the documentation ASAP. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727358#comment-15727358 ] ASF GitHub Bot commented on FLINK-4469: --- Github user wuchong commented on the issue:

[jira] [Commented] (FLINK-5257) Display optimized logical plan when explaining table

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727299#comment-15727299 ] ASF GitHub Bot commented on FLINK-5257: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #2949: [FLINK-5257] [table] display optimized logical pla...

2016-12-06 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/2949#discussion_r91209202 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/BatchTableEnvironment.scala --- @@ -275,17 +278,27 @@ abstract class

[jira] [Commented] (FLINK-3848) Add ProjectableTableSource interface and translation rule

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727295#comment-15727295 ] ASF GitHub Bot commented on FLINK-3848: --- Github user KurtYoung commented on the issue:

[GitHub] flink issue #2810: [FLINK-3848] Add ProjectableTableSource interface and tra...

2016-12-06 Thread KurtYoung
Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/2810 Hi @fhueske, I think this is a fair enough approach, thanks for your effort. We will change our pr ASAP. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-5253) Remove special treatment of "dynamic properties"

2016-12-06 Thread Mariusz Wojakowski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727188#comment-15727188 ] Mariusz Wojakowski commented on FLINK-5253: --- I'd like to implement that (if you don't mind). I'm

[jira] [Commented] (FLINK-3921) StringParser not specifying encoding to use

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726729#comment-15726729 ] ASF GitHub Bot commented on FLINK-3921: --- Github user fhueske commented on the issue:

[GitHub] flink issue #2901: [FLINK-3921] StringParser encoding

2016-12-06 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2901 The byte-level implementation as in `IntParser` was originally used to avoid String object instances. Such an implementation was not possible with Double because it led to very imprecise results.

[GitHub] flink issue #2901: [FLINK-3921] StringParser encoding

2016-12-06 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2901 @fhueske, the `FieldParser`s look to use two methods to parse their fields. `DoubleParser` uses `FieldParser.nextStringEndPos`, recently added by Timo, to create a `String` from the byte array

[jira] [Commented] (FLINK-3921) StringParser not specifying encoding to use

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726679#comment-15726679 ] ASF GitHub Bot commented on FLINK-3921: --- Github user greghogan commented on the issue:

[jira] [Commented] (FLINK-5247) Setting allowedLateness to a non-zero value should throw exception for processing-time windows

2016-12-06 Thread Rohit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726660#comment-15726660 ] Rohit Agarwal commented on FLINK-5247: -- So, do you want me to update the PR to not throw the

[GitHub] flink issue #2737: [FLINK-4983] Web UI: Add favicon

2016-12-06 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2737 I've created a fix: https://github.com/rmetzger/flink/commit/28a3aed8633246717c52599c25ced928436a6f97 and pushed it to my travis account (Github has a service outage, that's why travis builds

[GitHub] flink pull request #2954: [docs] Note that numberOfExecutionRetries and exec...

2016-12-06 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/flink/pull/2954#discussion_r91163739 --- Diff: docs/setup/fault_tolerance.md --- @@ -45,9 +45,6 @@ To enable checkpointing, call `enableCheckpointing(n)` on the `StreamExecutionEn

[GitHub] flink issue #2954: [docs] Note that numberOfExecutionRetries and executionRe...

2016-12-06 Thread mindprince
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2954 cc - @mxm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink pull request #2954: [docs] Note that numberOfExecutionRetries and exec...

2016-12-06 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/flink/pull/2954#discussion_r91163826 --- Diff: docs/setup/fault_tolerance.md --- @@ -345,20 +342,6 @@ env.setRestartStrategy(RestartStrategies.fixedDelayRestart( -

[jira] [Commented] (FLINK-4983) Web UI: Add favicon

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726599#comment-15726599 ] ASF GitHub Bot commented on FLINK-4983: --- Github user rmetzger commented on the issue:

[jira] [Commented] (FLINK-2821) Change Akka configuration to allow accessing actors from different URLs

2016-12-06 Thread Philipp von dem Bussche (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726595#comment-15726595 ] Philipp von dem Bussche commented on FLINK-2821: Thanks [~mxm]. This should then work

[GitHub] flink pull request #2954: [docs] Note that numberOfExecutionRetries and exec...

2016-12-06 Thread mindprince
GitHub user mindprince opened a pull request: https://github.com/apache/flink/pull/2954 [docs] Note that numberOfExecutionRetries and executionRetryDelay are deprecated And some other minor fixes and deduplication. You can merge this pull request into a Git repository by running:

[GitHub] flink pull request #2953: [FLINK-5039] Bump Avro version

2016-12-06 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/2953 [FLINK-5039] Bump Avro version This is a critical issue for some of our users. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink

[jira] [Commented] (FLINK-5039) Avro GenericRecord support is broken

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726553#comment-15726553 ] ASF GitHub Bot commented on FLINK-5039: --- GitHub user rmetzger opened a pull request:

[jira] [Commented] (FLINK-5039) Avro GenericRecord support is broken

2016-12-06 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726541#comment-15726541 ] Robert Metzger commented on FLINK-5039: --- Just using the Avro serializer doesn't solve the problem

[jira] [Commented] (FLINK-5233) Upgrade Jackson version because of class loader leak

2016-12-06 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726521#comment-15726521 ] Robert Metzger commented on FLINK-5233: --- I'll put more effort into reproducing it at the end of this

[jira] [Commented] (FLINK-4936) Operator names for Gelly inputs

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726518#comment-15726518 ] ASF GitHub Bot commented on FLINK-4936: --- Github user vasia commented on the issue:

[jira] [Commented] (FLINK-5035) Don't Write TypeSerializer to Heap State Snapshot

2016-12-06 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726517#comment-15726517 ] Robert Metzger commented on FLINK-5035: --- What's the status here? > Don't Write TypeSerializer to

[GitHub] flink issue #2832: [FLINK-4936] [gelly] Operator names for Gelly inputs

2016-12-06 Thread vasia
Github user vasia commented on the issue: https://github.com/apache/flink/pull/2832 Yes, will do in the following days, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Created] (FLINK-5267) TaskManager logs not scrollable

2016-12-06 Thread JIRA
Mischa Krüger created FLINK-5267: Summary: TaskManager logs not scrollable Key: FLINK-5267 URL: https://issues.apache.org/jira/browse/FLINK-5267 Project: Flink Issue Type: Bug

[GitHub] flink issue #2901: [FLINK-3921] StringParser encoding

2016-12-06 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2901 Thanks for the update @greghogan. PR looks good to merge. Something that came to my mind. Some of the FieldParsers such as `DoubleParser` create a String before converting it into a

[jira] [Commented] (FLINK-3921) StringParser not specifying encoding to use

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726380#comment-15726380 ] ASF GitHub Bot commented on FLINK-3921: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-4936) Operator names for Gelly inputs

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726341#comment-15726341 ] ASF GitHub Bot commented on FLINK-4936: --- Github user greghogan commented on the issue:

[GitHub] flink issue #2832: [FLINK-4936] [gelly] Operator names for Gelly inputs

2016-12-06 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2832 @vasia, would you like to review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #2750: [FLINK-5007] [checkpointing] Retain externalized checkpoi...

2016-12-06 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2750 In HA mode, checkpoints are not deleted on suspension. This PR won't change that behaviour. It only affects non-HA behaviour. Currently, the behaviour is to remove checkpoints on suspension,

[jira] [Commented] (FLINK-5007) Retain externalized checkpoint on suspension

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726235#comment-15726235 ] ASF GitHub Bot commented on FLINK-5007: --- Github user uce commented on the issue:

[jira] [Commented] (FLINK-3921) StringParser not specifying encoding to use

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726224#comment-15726224 ] ASF GitHub Bot commented on FLINK-3921: --- Github user greghogan commented on the issue:

[GitHub] flink issue #2901: [FLINK-3921] StringParser encoding

2016-12-06 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2901 @fhueske, I refactored `DelimitedInputFormat` and `GenericCsvInputFormat` to reinterpret the fields whenever the charset encoding changes, and also updated the test per your review. --- If your

[jira] [Resolved] (FLINK-5091) Formalize the AppMaster environment for docker compability

2016-12-06 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eron Wright resolved FLINK-5091. - Resolution: Fixed > Formalize the AppMaster environment for docker compability >

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726115#comment-15726115 ] ASF GitHub Bot commented on FLINK-4554: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726107#comment-15726107 ] ASF GitHub Bot commented on FLINK-4554: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726110#comment-15726110 ] ASF GitHub Bot commented on FLINK-4554: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726108#comment-15726108 ] ASF GitHub Bot commented on FLINK-4554: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726113#comment-15726113 ] ASF GitHub Bot commented on FLINK-4554: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726114#comment-15726114 ] ASF GitHub Bot commented on FLINK-4554: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726116#comment-15726116 ] ASF GitHub Bot commented on FLINK-4554: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726119#comment-15726119 ] ASF GitHub Bot commented on FLINK-4554: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726112#comment-15726112 ] ASF GitHub Bot commented on FLINK-4554: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726106#comment-15726106 ] ASF GitHub Bot commented on FLINK-4554: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726118#comment-15726118 ] ASF GitHub Bot commented on FLINK-4554: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #2919: [FLINK-4554] [table] Add support for array types

2016-12-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2919#discussion_r91114685 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala --- @@ -189,6 +188,16 @@ object CodeGenUtils {

[GitHub] flink pull request #2919: [FLINK-4554] [table] Add support for array types

2016-12-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2919#discussion_r91124107 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/schema/ArrayRelDataType.scala --- @@ -0,0 +1,53 @@ +/* + *

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726109#comment-15726109 ] ASF GitHub Bot commented on FLINK-4554: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #2919: [FLINK-4554] [table] Add support for array types

2016-12-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2919#discussion_r91126562 --- Diff: tools/maven/scalastyle-config.xml --- @@ -68,11 +68,11 @@ - --- End diff -- Can we use a custom scalastyle

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726117#comment-15726117 ] ASF GitHub Bot commented on FLINK-4554: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-4554) Add support for array types

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726111#comment-15726111 ] ASF GitHub Bot commented on FLINK-4554: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #2919: [FLINK-4554] [table] Add support for array types

2016-12-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2919#discussion_r91123689 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/array.scala --- @@ -0,0 +1,140 @@ +/* + * Licensed to

[GitHub] flink pull request #2919: [FLINK-4554] [table] Add support for array types

2016-12-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2919#discussion_r91124734 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/ArrayTypeTest.scala --- @@ -0,0 +1,342 @@ +/* + *

[GitHub] flink pull request #2919: [FLINK-4554] [table] Add support for array types

2016-12-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2919#discussion_r91110730 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala --- @@ -454,6 +455,29 @@ trait

[GitHub] flink pull request #2919: [FLINK-4554] [table] Add support for array types

2016-12-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2919#discussion_r9043 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala --- @@ -454,6 +455,29 @@ trait

[GitHub] flink pull request #2919: [FLINK-4554] [table] Add support for array types

2016-12-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2919#discussion_r91109035 --- Diff: docs/dev/table_api.md --- @@ -2577,6 +2628,50 @@ COMPOSITE.get(INT) + + +{% highlight

[GitHub] flink pull request #2919: [FLINK-4554] [table] Add support for array types

2016-12-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2919#discussion_r91106487 --- Diff: docs/dev/table_api.md --- @@ -1470,7 +1470,14 @@ The Table API is built on top of Flink's DataSet and DataStream API. Internally, |

[GitHub] flink pull request #2919: [FLINK-4554] [table] Add support for array types

2016-12-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2919#discussion_r91110871 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala --- @@ -454,6 +455,29 @@ trait

[GitHub] flink pull request #2919: [FLINK-4554] [table] Add support for array types

2016-12-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2919#discussion_r91124760 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/ArrayTypeTest.scala --- @@ -0,0 +1,342 @@ +/* + *

[GitHub] flink pull request #2919: [FLINK-4554] [table] Add support for array types

2016-12-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2919#discussion_r91107452 --- Diff: docs/dev/table_api.md --- @@ -2027,6 +2034,50 @@ COMPOSITE.get(INT) + + +{% highlight java

[GitHub] flink pull request #2919: [FLINK-4554] [table] Add support for array types

2016-12-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2919#discussion_r91108867 --- Diff: docs/dev/table_api.md --- @@ -2027,6 +2034,50 @@ COMPOSITE.get(INT) + + +{% highlight java

[GitHub] flink pull request #2919: [FLINK-4554] [table] Add support for array types

2016-12-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2919#discussion_r91109092 --- Diff: docs/dev/table_api.md --- @@ -3378,9 +3472,32 @@ ROW (value [, value]* ) Creates a row from a list of values.

[jira] [Assigned] (FLINK-5051) Backwards compatibility for serializers in backend state

2016-12-06 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter reassigned FLINK-5051: - Assignee: Stefan Richter > Backwards compatibility for serializers in backend state >

[jira] [Updated] (FLINK-5052) Changing the maximum parallelism (number of key groups) of a job

2016-12-06 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter updated FLINK-5052: -- Assignee: (was: Stefan Richter) > Changing the maximum parallelism (number of key groups)

[jira] [Assigned] (FLINK-5052) Changing the maximum parallelism (number of key groups) of a job

2016-12-06 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter reassigned FLINK-5052: - Assignee: Stefan Richter > Changing the maximum parallelism (number of key groups) of a

[jira] [Commented] (FLINK-3551) Sync Scala and Java Streaming Examples

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726026#comment-15726026 ] ASF GitHub Bot commented on FLINK-3551: --- Github user thvasilo commented on a diff in the pull

[jira] [Commented] (FLINK-3551) Sync Scala and Java Streaming Examples

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726027#comment-15726027 ] ASF GitHub Bot commented on FLINK-3551: --- Github user thvasilo commented on a diff in the pull

[jira] [Commented] (FLINK-3551) Sync Scala and Java Streaming Examples

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726028#comment-15726028 ] ASF GitHub Bot commented on FLINK-3551: --- Github user thvasilo commented on a diff in the pull

[jira] [Commented] (FLINK-3551) Sync Scala and Java Streaming Examples

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726025#comment-15726025 ] ASF GitHub Bot commented on FLINK-3551: --- Github user thvasilo commented on a diff in the pull

[GitHub] flink pull request #2761: [FLINK-3551] [examples] Sync Scala Streaiming Exam...

2016-12-06 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/2761#discussion_r91119867 --- Diff: flink-examples/flink-examples-streaming/src/main/scala/org/apache/flink/streaming/scala/examples/windowing/SessionWindowing.scala --- @@ -60,11

[GitHub] flink pull request #2761: [FLINK-3551] [examples] Sync Scala Streaiming Exam...

2016-12-06 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/2761#discussion_r91119955 --- Diff: flink-examples/flink-examples-streaming/src/main/scala/org/apache/flink/streaming/scala/examples/windowing/SessionWindowing.scala --- @@ -77,9

[GitHub] flink pull request #2761: [FLINK-3551] [examples] Sync Scala Streaiming Exam...

2016-12-06 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/2761#discussion_r91119626 --- Diff: flink-examples/flink-examples-streaming/src/main/scala/org/apache/flink/streaming/scala/examples/windowing/GroupedProcessingTimeWindowExample.scala

[GitHub] flink pull request #2761: [FLINK-3551] [examples] Sync Scala Streaiming Exam...

2016-12-06 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/2761#discussion_r91119469 --- Diff: flink-examples/flink-examples-streaming/src/main/scala/org/apache/flink/streaming/scala/examples/ml/IncrementalLearningSkeleton.scala --- @@

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726009#comment-15726009 ] ASF GitHub Bot commented on FLINK-4469: --- Github user twalthr commented on the issue:

[GitHub] flink issue #2653: [FLINK-4469] [table] Add support for user defined table f...

2016-12-06 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2653 @wuchong thanks for updating the PR! It looks good now. I will rebase it, quickly scan over the code again and merge it tomorrow. However, we should fix FLINK-5223 as soon as possible. It

[jira] [Commented] (FLINK-5007) Retain externalized checkpoint on suspension

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725895#comment-15725895 ] ASF GitHub Bot commented on FLINK-5007: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2750: [FLINK-5007] [checkpointing] Retain externalized checkpoi...

2016-12-06 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2750 A suspension is usually a master failure or loss of leadership. Suspending a job does not delete/remove any HA checkpoints. The same should be the case for externalized checkpoints, in

[jira] [Commented] (FLINK-4983) Web UI: Add favicon

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725869#comment-15725869 ] ASF GitHub Bot commented on FLINK-4983: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-4983) Web UI: Add favicon

2016-12-06 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-4983. - Resolution: Implemented Implemented in ba6b08794b22dfc586d32926a6af488e5edac2d6 > Web UI: Add favicon >

[jira] [Updated] (FLINK-4983) Web UI: Add favicon

2016-12-06 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-4983: -- Fix Version/s: 1.2.0 > Web UI: Add favicon > --- > > Key: FLINK-4983 >

[GitHub] flink pull request #2737: [FLINK-4983] Web UI: Add favicon

2016-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2737 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2923: [FLINK-5220] [Table API & SQL] Flink SQL projection pushd...

2016-12-06 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2923 Hi @beyond1920 and @KurtYoung, please see my [comment](https://github.com/apache/flink/pull/2810#issuecomment-265180294) on PR #2810 for how to continue with this PR. Please let me know

[jira] [Commented] (FLINK-5220) Flink SQL projection pushdown

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725829#comment-15725829 ] ASF GitHub Bot commented on FLINK-5220: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-3848) Add ProjectableTableSource interface and translation rule

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725823#comment-15725823 ] ASF GitHub Bot commented on FLINK-3848: --- Github user fhueske commented on the issue:

[GitHub] flink issue #2810: [FLINK-3848] Add ProjectableTableSource interface and tra...

2016-12-06 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2810 Hi @tonycox, @beyond1920, and @KurtYoung, I think I found a good way to split the issue. Let me first summarize what both of your PRs implement: @tonycox (PR #2810) - good test

[jira] [Commented] (FLINK-5002) Lack of synchronization in LocalBufferPool#getNumberOfUsedBuffers

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725804#comment-15725804 ] ASF GitHub Bot commented on FLINK-5002: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2865: [FLINK-5002] Renamed getNumberOfUsedBuffers() method to b...

2016-12-06 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2865 Looks good. The test is almost a bit overkill, I think. A adding a simple `Math.max(0, value)` to ensure the value is non-negative probably does the trick. --- If your project is set up for

[jira] [Commented] (FLINK-3848) Add ProjectableTableSource interface and translation rule

2016-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725765#comment-15725765 ] ASF GitHub Bot commented on FLINK-3848: --- Github user fhueske commented on a diff in the pull

  1   2   3   >