[jira] [Commented] (FLINK-10252) Handle oversized metric messges

[ https://issues.apache.org/jira/browse/FLINK-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656344#comment-16656344 ] ASF GitHub Bot commented on FLINK-10252: yanghua commented on issue #6850: [FLIN

[GitHub] yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges

yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges URL: https://github.com/apache/flink/pull/6850#issuecomment-431261877 Hi @zentol I have not add test for the new implementation, but can you review it firstly so that it can match your requirement? Thanks.

[jira] [Commented] (FLINK-10436) Example config uses deprecated key jobmanager.rpc.address

[ https://issues.apache.org/jira/browse/FLINK-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656323#comment-16656323 ] ASF GitHub Bot commented on FLINK-10436: zentol commented on issue #6872: [FLINK

[GitHub] zentol commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys

zentol commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys URL: https://github.com/apache/flink/pull/6872#issuecomment-431256748 > If we now introduce a RestOption#DISPATCHER_ADDRESS with the fallback to RestOption#ADDRESS and JobManagerOptions#ADDRESS and remove the l

[jira] [Assigned] (FLINK-10603) Reduce kafka test duration

[ https://issues.apache.org/jira/browse/FLINK-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-10603: Assignee: vinoyang > Reduce kafka test duration > -- > >

[jira] [Commented] (FLINK-10552) Provide RichAsyncFunction for scala API

[ https://issues.apache.org/jira/browse/FLINK-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656315#comment-16656315 ] ASF GitHub Bot commented on FLINK-10552: Clark opened a new pull request #68

[GitHub] Clarkkkkk opened a new pull request #6878: [FLINK-10552][DataStream API]Add supports for RichAsyncFunction in Scala API

Clark opened a new pull request #6878: [FLINK-10552][DataStream API]Add supports for RichAsyncFunction in Scala API URL: https://github.com/apache/flink/pull/6878 ## What is the purpose of the change Support RichAsyncFunction in Scala API ## Brief change log - Change

[jira] [Assigned] (FLINK-10531) State TTL RocksDb backend end-to-end test failed on Travis

[ https://issues.apache.org/jira/browse/FLINK-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Renjie Liu reassigned FLINK-10531: -- Assignee: Renjie Liu > State TTL RocksDb backend end-to-end test failed on Travis > -

[jira] [Commented] (FLINK-10491) Deadlock during spilling data in SpillableSubpartition

[ https://issues.apache.org/jira/browse/FLINK-10491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656242#comment-16656242 ] ASF GitHub Bot commented on FLINK-10491: zhijiangW commented on issue #6809: [FL

[GitHub] zhijiangW commented on issue #6809: [FLINK-10491][network] Pass BufferPoolOwner in the constructor of LocalBufferPool

zhijiangW commented on issue #6809: [FLINK-10491][network] Pass BufferPoolOwner in the constructor of LocalBufferPool URL: https://github.com/apache/flink/pull/6809#issuecomment-431236371 @pnowojski , thanks for reviews again! I have mainly two concerns of tests from comments. 1.

[jira] [Commented] (FLINK-10540) Remove legacy FlinkMiniCluster

[ https://issues.apache.org/jira/browse/FLINK-10540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656239#comment-16656239 ] TisonKun commented on FLINK-10540: -- Yes I see. And in testing code its subclasses({{Loc

[jira] [Commented] (FLINK-10527) Cleanup constant isNewMode in YarnTestBase

[ https://issues.apache.org/jira/browse/FLINK-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656237#comment-16656237 ] ASF GitHub Bot commented on FLINK-10527: yanghua commented on a change in pull r

[GitHub] yanghua commented on a change in pull request #6816: [FLINK-10527] Cleanup constant isNewMode in YarnTestBase

yanghua commented on a change in pull request #6816: [FLINK-10527] Cleanup constant isNewMode in YarnTestBase URL: https://github.com/apache/flink/pull/6816#discussion_r226526901 ## File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionCapacitySchedulerITCase.j

[jira] [Comment Edited] (FLINK-10540) Remove legacy FlinkMiniCluster

[ https://issues.apache.org/jira/browse/FLINK-10540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656235#comment-16656235 ] Shimin Yang edited comment on FLINK-10540 at 10/19/18 3:37 AM: ---

[jira] [Commented] (FLINK-8098) LeaseExpiredException when using FsStateBackend for checkpointing due to multiple mappers tries to access the same file.

[ https://issues.apache.org/jira/browse/FLINK-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656236#comment-16656236 ] Paul Lin commented on FLINK-8098: - +1 for this issue. We get the same problem on Flink 1.

[jira] [Commented] (FLINK-10540) Remove legacy FlinkMiniCluster

[ https://issues.apache.org/jira/browse/FLINK-10540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656235#comment-16656235 ] Shimin Yang commented on FLINK-10540: - Look like it's only used by flink-storm examp

[jira] [Commented] (FLINK-9970) Add ASCII/CHR function for table/sql API

[ https://issues.apache.org/jira/browse/FLINK-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656234#comment-16656234 ] ASF GitHub Bot commented on FLINK-9970: --- yanghua commented on a change in pull requ

[GitHub] yanghua commented on a change in pull request #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API

yanghua commented on a change in pull request #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r226526582 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/

[jira] [Commented] (FLINK-10491) Deadlock during spilling data in SpillableSubpartition

[ https://issues.apache.org/jira/browse/FLINK-10491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656231#comment-16656231 ] ASF GitHub Bot commented on FLINK-10491: zhijiangW commented on a change in pull

[GitHub] zhijiangW commented on a change in pull request #6809: [FLINK-10491][network] Pass BufferPoolOwner in the constructor of LocalBufferPool

zhijiangW commented on a change in pull request #6809: [FLINK-10491][network] Pass BufferPoolOwner in the constructor of LocalBufferPool URL: https://github.com/apache/flink/pull/6809#discussion_r226525858 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/networ

[jira] [Commented] (FLINK-8483) Implement and expose outer joins

[ https://issues.apache.org/jira/browse/FLINK-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656229#comment-16656229 ] ASF GitHub Bot commented on FLINK-8483: --- xccui commented on issue #6874: [FLINK-848

[GitHub] xccui commented on issue #6874: [FLINK-8483][DataStream] Implement and expose outer joins

xccui commented on issue #6874: [FLINK-8483][DataStream] Implement and expose outer joins URL: https://github.com/apache/flink/pull/6874#issuecomment-431232789 Hi @florianschmidt1994 , thanks for working on this! Before looking into the code, I'd like to share two thoughts.

[GitHub] sunjincheng121 commented on a change in pull request #6873: [hotfix] Add Review Progress section to PR description template.

sunjincheng121 commented on a change in pull request #6873: [hotfix] Add Review Progress section to PR description template. URL: https://github.com/apache/flink/pull/6873#discussion_r226525062 ## File path: .github/PULL_REQUEST_TEMPLATE.md ## @@ -70,3 +70,17 @@ This chang

[jira] [Commented] (FLINK-10540) Remove legacy FlinkMiniCluster

[ https://issues.apache.org/jira/browse/FLINK-10540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656218#comment-16656218 ] TisonKun commented on FLINK-10540: -- Great take [~dangdangdang]! > Remove legacy FlinkM

[jira] [Commented] (FLINK-10491) Deadlock during spilling data in SpillableSubpartition

[ https://issues.apache.org/jira/browse/FLINK-10491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656215#comment-16656215 ] ASF GitHub Bot commented on FLINK-10491: zhijiangW commented on a change in pull

[GitHub] zhijiangW commented on a change in pull request #6809: [FLINK-10491][network] Pass BufferPoolOwner in the constructor of LocalBufferPool

zhijiangW commented on a change in pull request #6809: [FLINK-10491][network] Pass BufferPoolOwner in the constructor of LocalBufferPool URL: https://github.com/apache/flink/pull/6809#discussion_r226523253 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/networ

[jira] [Assigned] (FLINK-10540) Remove legacy FlinkMiniCluster

[ https://issues.apache.org/jira/browse/FLINK-10540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shimin Yang reassigned FLINK-10540: --- Assignee: Shimin Yang > Remove legacy FlinkMiniCluster > -- > >

[jira] [Commented] (FLINK-10491) Deadlock during spilling data in SpillableSubpartition

[ https://issues.apache.org/jira/browse/FLINK-10491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656201#comment-16656201 ] ASF GitHub Bot commented on FLINK-10491: zhijiangW commented on a change in pull

[GitHub] zhijiangW commented on a change in pull request #6809: [FLINK-10491][network] Pass BufferPoolOwner in the constructor of LocalBufferPool

zhijiangW commented on a change in pull request #6809: [FLINK-10491][network] Pass BufferPoolOwner in the constructor of LocalBufferPool URL: https://github.com/apache/flink/pull/6809#discussion_r226520720 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/networ

[jira] [Commented] (FLINK-9970) Add ASCII/CHR function for table/sql API

[ https://issues.apache.org/jira/browse/FLINK-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656200#comment-16656200 ] ASF GitHub Bot commented on FLINK-9970: --- yanghua commented on a change in pull requ

[GitHub] yanghua commented on a change in pull request #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API

yanghua commented on a change in pull request #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r226520617 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/

[jira] [Commented] (FLINK-10166) Dependency problems when executing SQL query in sql-client

[ https://issues.apache.org/jira/browse/FLINK-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656183#comment-16656183 ] ASF GitHub Bot commented on FLINK-10166: leanken commented on issue #6863: [FLIN

[GitHub] leanken commented on issue #6863: [FLINK-10166][table] Replace commons.codec.binary.Base64 with java.util.Base64

leanken commented on issue #6863: [FLINK-10166][table] Replace commons.codec.binary.Base64 with java.util.Base64 URL: https://github.com/apache/flink/pull/6863#issuecomment-431223615 let me fix TestCase build break first. Thi

[GitHub] XuQianJin-Stars commented on a change in pull request #6823: [FLINK-10134] UTF-16 support for TextInputFormat bug refixed

XuQianJin-Stars commented on a change in pull request #6823: [FLINK-10134] UTF-16 support for TextInputFormat bug refixed URL: https://github.com/apache/flink/pull/6823#discussion_r226516362 ## File path: flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.

[jira] [Commented] (FLINK-10134) UTF-16 support for TextInputFormat

[ https://issues.apache.org/jira/browse/FLINK-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656173#comment-16656173 ] ASF GitHub Bot commented on FLINK-10134: XuQianJin-Stars commented on a change i

[GitHub] XuQianJin-Stars commented on a change in pull request #6823: [FLINK-10134] UTF-16 support for TextInputFormat bug refixed

XuQianJin-Stars commented on a change in pull request #6823: [FLINK-10134] UTF-16 support for TextInputFormat bug refixed URL: https://github.com/apache/flink/pull/6823#discussion_r226516362 ## File path: flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.

[jira] [Commented] (FLINK-10134) UTF-16 support for TextInputFormat

[ https://issues.apache.org/jira/browse/FLINK-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656161#comment-16656161 ] ASF GitHub Bot commented on FLINK-10134: XuQianJin-Stars commented on a change i

[jira] [Commented] (FLINK-9970) Add ASCII/CHR function for table/sql API

[ https://issues.apache.org/jira/browse/FLINK-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656159#comment-16656159 ] ASF GitHub Bot commented on FLINK-9970: --- yanghua commented on a change in pull requ

[GitHub] yanghua commented on a change in pull request #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API

yanghua commented on a change in pull request #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r226515985 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/

[jira] [Commented] (FLINK-9970) Add ASCII/CHR function for table/sql API

[ https://issues.apache.org/jira/browse/FLINK-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656144#comment-16656144 ] ASF GitHub Bot commented on FLINK-9970: --- yanghua commented on a change in pull requ

[GitHub] yanghua commented on a change in pull request #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API

yanghua commented on a change in pull request #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r226513490 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/

[jira] [Commented] (FLINK-9697) Provide connector for modern Kafka

[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656141#comment-16656141 ] ASF GitHub Bot commented on FLINK-9697: --- yanghua edited a comment on issue #6703: [

[jira] [Commented] (FLINK-9697) Provide connector for modern Kafka

[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656140#comment-16656140 ] ASF GitHub Bot commented on FLINK-9697: --- yanghua commented on issue #6703: [FLINK-9

[GitHub] yanghua edited a comment on issue #6703: [FLINK-9697] Provide connector for modern Kafka

yanghua edited a comment on issue #6703: [FLINK-9697] Provide connector for modern Kafka URL: https://github.com/apache/flink/pull/6703#issuecomment-431216581 @alexeyt820 I have moved these two issues into FLINK-10598 as sub issues. -

[GitHub] yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka

yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka URL: https://github.com/apache/flink/pull/6703#issuecomment-431216581 @alexeyt820 I have moved these two issues into FLINK-10598 as a sub issue. ---

[jira] [Commented] (FLINK-8500) Get the timestamp of the Kafka message from kafka consumer(Kafka010Fetcher)

[ https://issues.apache.org/jira/browse/FLINK-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656137#comment-16656137 ] vinoyang commented on FLINK-8500: - Hi,  if the modern kafka connector also has this issue

[jira] [Updated] (FLINK-8500) Get the timestamp of the Kafka message from kafka consumer(Kafka010Fetcher)

[ https://issues.apache.org/jira/browse/FLINK-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated FLINK-8500: Issue Type: Sub-task (was: Improvement) Parent: FLINK-10598 > Get the timestamp of the Kafka messa

[jira] [Updated] (FLINK-8354) Flink Kafka connector ignores Kafka message headers

[ https://issues.apache.org/jira/browse/FLINK-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated FLINK-8354: Issue Type: Sub-task (was: Bug) Parent: FLINK-10598 > Flink Kafka connector ignores Kafka message

[jira] [Commented] (FLINK-9970) Add ASCII/CHR function for table/sql API

[ https://issues.apache.org/jira/browse/FLINK-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656102#comment-16656102 ] ASF GitHub Bot commented on FLINK-9970: --- xccui commented on a change in pull reques

[GitHub] xccui commented on a change in pull request #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API

xccui commented on a change in pull request #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r226506688 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/Sc

[jira] [Commented] (FLINK-9970) Add ASCII/CHR function for table/sql API

[ https://issues.apache.org/jira/browse/FLINK-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656099#comment-16656099 ] ASF GitHub Bot commented on FLINK-9970: --- xccui commented on a change in pull reques

[jira] [Commented] (FLINK-9970) Add ASCII/CHR function for table/sql API

[ https://issues.apache.org/jira/browse/FLINK-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656097#comment-16656097 ] ASF GitHub Bot commented on FLINK-9970: --- xccui commented on a change in pull reques

[GitHub] xccui commented on a change in pull request #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API

xccui commented on a change in pull request #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r226506284 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/Sc

[GitHub] xccui commented on a change in pull request #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API

xccui commented on a change in pull request #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r226506162 ## File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFu

[jira] [Commented] (FLINK-10566) Flink Planning is exponential in the number of stages

[ https://issues.apache.org/jira/browse/FLINK-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655692#comment-16655692 ] Fabian Hueske commented on FLINK-10566: --- This issue only affects DataSet programs.

[jira] [Commented] (FLINK-10566) Flink Planning is exponential in the number of stages

[ https://issues.apache.org/jira/browse/FLINK-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655683#comment-16655683 ] Maximilian Michels commented on FLINK-10566: Just to clarify, this happens d

[jira] [Commented] (FLINK-10566) Flink Planning is exponential in the number of stages

[ https://issues.apache.org/jira/browse/FLINK-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655681#comment-16655681 ] Maximilian Michels commented on FLINK-10566: Here's a thread dump: {noform

[jira] [Commented] (FLINK-9697) Provide connector for modern Kafka

[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655663#comment-16655663 ] ASF GitHub Bot commented on FLINK-9697: --- alexeyt820 commented on issue #6703: [FLIN

[GitHub] alexeyt820 commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka

alexeyt820 commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka URL: https://github.com/apache/flink/pull/6703#issuecomment-431100016 @yanghua, FLINK-8354 (headers) and FLINK-8500 (timestamp), but seems I don't have permissions to change anything in these Jira issues

[GitHub] tillrohrmann commented on a change in pull request #6816: [FLINK-10527] Cleanup constant isNewMode in YarnTestBase

tillrohrmann commented on a change in pull request #6816: [FLINK-10527] Cleanup constant isNewMode in YarnTestBase URL: https://github.com/apache/flink/pull/6816#discussion_r226396417 ## File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionCapacitySchedulerITC

[jira] [Commented] (FLINK-10527) Cleanup constant isNewMode in YarnTestBase

[ https://issues.apache.org/jira/browse/FLINK-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655636#comment-16655636 ] ASF GitHub Bot commented on FLINK-10527: tillrohrmann commented on a change in p

[GitHub] tillrohrmann commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys

tillrohrmann commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys URL: https://github.com/apache/flink/pull/6872#issuecomment-431093823 At the moment `rest.address` is effectively `dispatcher.rest.address`. The problem I see currently is that other components might alr

[jira] [Commented] (FLINK-10436) Example config uses deprecated key jobmanager.rpc.address

[ https://issues.apache.org/jira/browse/FLINK-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655627#comment-16655627 ] ASF GitHub Bot commented on FLINK-10436: tillrohrmann commented on issue #6872:

[jira] [Comment Edited] (FLINK-10569) Clean up uses of Scheduler and Instance in valid tests

[ https://issues.apache.org/jira/browse/FLINK-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655620#comment-16655620 ] TisonKun edited comment on FLINK-10569 at 10/18/18 5:22 PM:

[jira] [Comment Edited] (FLINK-10569) Clean up uses of Scheduler and Instance in valid tests

[ https://issues.apache.org/jira/browse/FLINK-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655620#comment-16655620 ] TisonKun edited comment on FLINK-10569 at 10/18/18 5:22 PM:

[jira] [Commented] (FLINK-10569) Clean up uses of Scheduler and Instance in valid tests

[ https://issues.apache.org/jira/browse/FLINK-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655620#comment-16655620 ] TisonKun commented on FLINK-10569: -- I find this topic is more complex than I ever thoug

[jira] [Commented] (FLINK-10251) Handle oversized response messages in AkkaRpcActor

[ https://issues.apache.org/jira/browse/FLINK-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655615#comment-16655615 ] ASF GitHub Bot commented on FLINK-10251: tillrohrmann commented on a change in p

[GitHub] tillrohrmann commented on a change in pull request #6876: [FLINK-10251] Handle oversized response messages in AkkaRpcActor

tillrohrmann commented on a change in pull request #6876: [FLINK-10251] Handle oversized response messages in AkkaRpcActor URL: https://github.com/apache/flink/pull/6876#discussion_r226393468 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcService

[jira] [Commented] (FLINK-10602) Run MetricFetcher in metrics ActorSystem

[ https://issues.apache.org/jira/browse/FLINK-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655600#comment-16655600 ] ASF GitHub Bot commented on FLINK-10602: tillrohrmann closed pull request #6877:

[jira] [Resolved] (FLINK-10602) Run MetricFetcher in metrics ActorSystem

[ https://issues.apache.org/jira/browse/FLINK-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-10602. --- Resolution: Fixed Fixed via https://github.com/apache/flink/commit/f6a7100507c4d6eda25c1061

[GitHub] tillrohrmann closed pull request #6877: [FLINK-10602] Use metric's ActorSystem in MetricFetcher

tillrohrmann closed pull request #6877: [FLINK-10602] Use metric's ActorSystem in MetricFetcher URL: https://github.com/apache/flink/pull/6877 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[jira] [Commented] (FLINK-10436) Example config uses deprecated key jobmanager.rpc.address

[ https://issues.apache.org/jira/browse/FLINK-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655598#comment-16655598 ] ASF GitHub Bot commented on FLINK-10436: zentol commented on issue #6872: [FLINK

[GitHub] zentol commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys

zentol commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys URL: https://github.com/apache/flink/pull/6872#issuecomment-431087755 I understood what the fallback is supposed to do, but it doesn't make sense that something generic like `rest.address` uses the very specifi

[jira] [Commented] (FLINK-10309) Cancel flink job occurs java.net.ConnectException

[ https://issues.apache.org/jira/browse/FLINK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1663#comment-1663 ] ASF GitHub Bot commented on FLINK-10309: GJL commented on issue #6785: [FLINK-10

[GitHub] GJL commented on issue #6785: [FLINK-10309][rest] Before shutting down cluster, wait for asynchronous operations

GJL commented on issue #6785: [FLINK-10309][rest] Before shutting down cluster, wait for asynchronous operations URL: https://github.com/apache/flink/pull/6785#issuecomment-431078873 @zentol Thanks for reviewing. I will keep the refactoring in a separate commit. --

[jira] [Commented] (FLINK-10555) Port AkkaSslITCase to new code base

[ https://issues.apache.org/jira/browse/FLINK-10555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655539#comment-16655539 ] ASF GitHub Bot commented on FLINK-10555: TisonKun commented on issue #6849: [FLI

[GitHub] TisonKun commented on issue #6849: [FLINK-10555] [test] Port AkkaSslITCase to new code base

TisonKun commented on issue #6849: [FLINK-10555] [test] Port AkkaSslITCase to new code base URL: https://github.com/apache/flink/pull/6849#issuecomment-431075922 @tillrohrmann yes I think those are covered by the mentioned existing tests. Moving negative tests to `BlobServerSslTest` as sug

[jira] [Commented] (FLINK-10563) Expose shaded Presto S3 filesystem under "s3p" scheme

[ https://issues.apache.org/jira/browse/FLINK-10563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655529#comment-16655529 ] ASF GitHub Bot commented on FLINK-10563: aljoscha commented on issue #6855: [FLI

[GitHub] aljoscha commented on issue #6855: [FLINK-10563] Expose shaded Presto S3 filesystem under "s3p" scheme

aljoscha commented on issue #6855: [FLINK-10563] Expose shaded Presto S3 filesystem under "s3p" scheme URL: https://github.com/apache/flink/pull/6855#issuecomment-431074098 will update both, thanks! This is an automated messa

[jira] [Commented] (FLINK-9970) Add ASCII/CHR function for table/sql API

[ https://issues.apache.org/jira/browse/FLINK-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655509#comment-16655509 ] ASF GitHub Bot commented on FLINK-9970: --- yanghua commented on issue #6432: [FLINK-9

[GitHub] yanghua commented on issue #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API

yanghua commented on issue #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#issuecomment-431070571 @xccui Any more review comment? This is an automated messag

[jira] [Commented] (FLINK-10384) Add Sinh math function supported in Table API and SQL

[ https://issues.apache.org/jira/browse/FLINK-10384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655493#comment-16655493 ] ASF GitHub Bot commented on FLINK-10384: pnowojski closed pull request #6730: [F

[jira] [Commented] (FLINK-10384) Add Sinh math function supported in Table API and SQL

[ https://issues.apache.org/jira/browse/FLINK-10384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655492#comment-16655492 ] ASF GitHub Bot commented on FLINK-10384: pnowojski commented on issue #6730: [FL

[GitHub] pnowojski closed pull request #6730: [FLINK-10384][table] Add Sinh math function supported in Table API and SQL

pnowojski closed pull request #6730: [FLINK-10384][table] Add Sinh math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6730 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pr

[GitHub] pnowojski commented on issue #6730: [FLINK-10384][table] Add Sinh math function supported in Table API and SQL

pnowojski commented on issue #6730: [FLINK-10384][table] Add Sinh math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6730#issuecomment-431066934 Thanks @yanghua :) Merging This is an automa

[jira] [Commented] (FLINK-10251) Handle oversized response messages in AkkaRpcActor

[ https://issues.apache.org/jira/browse/FLINK-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655486#comment-16655486 ] ASF GitHub Bot commented on FLINK-10251: yanghua commented on a change in pull r

[GitHub] yanghua commented on a change in pull request #6876: [FLINK-10251] Handle oversized response messages in AkkaRpcActor

yanghua commented on a change in pull request #6876: [FLINK-10251] Handle oversized response messages in AkkaRpcActor URL: https://github.com/apache/flink/pull/6876#discussion_r226366888 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcService.java

[jira] [Commented] (FLINK-10436) Example config uses deprecated key jobmanager.rpc.address

[ https://issues.apache.org/jira/browse/FLINK-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655481#comment-16655481 ] ASF GitHub Bot commented on FLINK-10436: TisonKun commented on a change in pull

[GitHub] TisonKun commented on a change in pull request #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys

TisonKun commented on a change in pull request #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys URL: https://github.com/apache/flink/pull/6872#discussion_r226366382 ## File path: flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ## @@ -701,1

[jira] [Commented] (FLINK-10436) Example config uses deprecated key jobmanager.rpc.address

[ https://issues.apache.org/jira/browse/FLINK-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655473#comment-16655473 ] ASF GitHub Bot commented on FLINK-10436: TisonKun commented on a change in pull

[GitHub] TisonKun commented on a change in pull request #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys

TisonKun commented on a change in pull request #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys URL: https://github.com/apache/flink/pull/6872#discussion_r226364750 ## File path: flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ## @@ -701,1

[jira] [Commented] (FLINK-10436) Example config uses deprecated key jobmanager.rpc.address

[ https://issues.apache.org/jira/browse/FLINK-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655468#comment-16655468 ] ASF GitHub Bot commented on FLINK-10436: TisonKun commented on a change in pull

[jira] [Commented] (FLINK-10436) Example config uses deprecated key jobmanager.rpc.address

[ https://issues.apache.org/jira/browse/FLINK-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655470#comment-16655470 ] ASF GitHub Bot commented on FLINK-10436: TisonKun commented on a change in pull

[GitHub] TisonKun commented on a change in pull request #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys

TisonKun commented on a change in pull request #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys URL: https://github.com/apache/flink/pull/6872#discussion_r226363901 ## File path: flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ## @@ -701,1

[GitHub] TisonKun commented on a change in pull request #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys

TisonKun commented on a change in pull request #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys URL: https://github.com/apache/flink/pull/6872#discussion_r226363659 ## File path: flink-core/src/main/java/org/apache/flink/configuration/FallbackKey.java ## @@ -0,0 +1,

[jira] [Commented] (FLINK-10252) Handle oversized metric messges

[ https://issues.apache.org/jira/browse/FLINK-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655451#comment-16655451 ] ASF GitHub Bot commented on FLINK-10252: yanghua commented on a change in pull r

[jira] [Commented] (FLINK-10436) Example config uses deprecated key jobmanager.rpc.address

[ https://issues.apache.org/jira/browse/FLINK-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655450#comment-16655450 ] ASF GitHub Bot commented on FLINK-10436: TisonKun commented on issue #6872: [FLI

[GitHub] yanghua commented on a change in pull request #6850: [FLINK-10252] Handle oversized metric messges

yanghua commented on a change in pull request #6850: [FLINK-10252] Handle oversized metric messges URL: https://github.com/apache/flink/pull/6850#discussion_r226358701 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java

[GitHub] TisonKun commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys

TisonKun commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys URL: https://github.com/apache/flink/pull/6872#issuecomment-431058218 The idea we need a fallback key is because keyA and keyB(with keyA fallback to keyB) are conceptually not the same thing or keyB succeed

[jira] [Commented] (FLINK-10527) Cleanup constant isNewMode in YarnTestBase

[ https://issues.apache.org/jira/browse/FLINK-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655447#comment-16655447 ] ASF GitHub Bot commented on FLINK-10527: yanghua commented on a change in pull r

  1   2   3   4   5   >