[GitHub] [flink] gaoyunhaii commented on issue #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers

gaoyunhaii commented on issue #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers URL: https://github.com/apache/flink/pull/8925#issuecomment-510341121 Very thanks for the review @pnowojski @StephanEwen ! I have updated the PR.

[GitHub] [flink] flinkbot commented on issue #8877: [FLINK-12984][metrics] only call Histogram#getStatistics() once where possible

flinkbot commented on issue #8877: [FLINK-12984][metrics] only call Histogram#getStatistics() once where possible URL: https://github.com/apache/flink/pull/8877#issuecomment-510337436 CI report for commit f183d69a6ba8fbd3b9bb3c5474b392950811dfa8: FAILURE

[GitHub] [flink] KurtYoung closed pull request #8294: [FLINK-12348][table-planner-blink]Use TableConfig in api module to replace TableConfig in blink-planner module.

KurtYoung closed pull request #8294: [FLINK-12348][table-planner-blink]Use TableConfig in api module to replace TableConfig in blink-planner module. URL: https://github.com/apache/flink/pull/8294 This is an automated

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302370153 ## File path:

[GitHub] [flink] KurtYoung commented on issue #8294: [FLINK-12348][table-planner-blink]Use TableConfig in api module to replace TableConfig in blink-planner module.

KurtYoung commented on issue #8294: [FLINK-12348][table-planner-blink]Use TableConfig in api module to replace TableConfig in blink-planner module. URL: https://github.com/apache/flink/pull/8294#issuecomment-510336618 travis passed here:

[GitHub] [flink] KurtYoung commented on issue #8294: [FLINK-12348][table-planner-blink]Use TableConfig in api module to replace TableConfig in blink-planner module.

KurtYoung commented on issue #8294: [FLINK-12348][table-planner-blink]Use TableConfig in api module to replace TableConfig in blink-planner module. URL: https://github.com/apache/flink/pull/8294#issuecomment-510336673 merging this...

[GitHub] [flink] flinkbot commented on issue #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers

flinkbot commented on issue #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers URL: https://github.com/apache/flink/pull/8925#issuecomment-510335932 CI report for commit 31a51cbe260a78381dc44973e6724c20532b5deb: SUCCESS

[GitHub] [flink] JingsongLi commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

JingsongLi commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302369427 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

JingsongLi commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302368883 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

JingsongLi commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302367751 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

JingsongLi commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302364645 ## File path:

[GitHub] [flink] JingsongLi commented on issue #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager

JingsongLi commented on issue #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager URL: https://github.com/apache/flink/pull/8920#issuecomment-510329508 Hi bowen: > `TableFunctionDefinition` and `AggregateFunctionDefinition` need resultType and accumulateType

[GitHub] [flink] flinkbot commented on issue #8990: [FLINK-13104][metrics] Updated request callback to log warning on failure

flinkbot commented on issue #8990: [FLINK-13104][metrics] Updated request callback to log warning on failure URL: https://github.com/apache/flink/pull/8990#issuecomment-510328396 CI report for commit f3b49c2ad8fd13e880ad5908b69c33bb841d52a5: FAILURE

[GitHub] [flink] flinkbot commented on issue #8962: [FLINK-13076] [table-planner-blink] Bump Calcite dependency to 1.20.0 in blink planner

flinkbot commented on issue #8962: [FLINK-13076] [table-planner-blink] Bump Calcite dependency to 1.20.0 in blink planner URL: https://github.com/apache/flink/pull/8962#issuecomment-510327044 CI report for commit d1f5135c005d7a116c819543feb5ce07c42d8cfc: FAILURE

[GitHub] [flink] flinkbot commented on issue #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager

flinkbot commented on issue #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager URL: https://github.com/apache/flink/pull/8920#issuecomment-510327018 CI report for commit 4afedee15460ac0f1f2945ca657581c538ddfc06: FAILURE

[GitHub] [flink] flinkbot commented on issue #9077: [FLINK-13196][table] Fix Ambiguous column name exception bug for Table API

flinkbot commented on issue #9077: [FLINK-13196][table] Fix Ambiguous column name exception bug for Table API URL: https://github.com/apache/flink/pull/9077#issuecomment-510326720 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[jira] [Updated] (FLINK-13196) Fix Ambiguous column name exception bug for Table API

[ https://issues.apache.org/jira/browse/FLINK-13196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13196: --- Labels: pull-request-available (was: ) > Fix Ambiguous column name exception bug for Table

[GitHub] [flink] hequn8128 opened a new pull request #9077: [FLINK-13196][table] Fix Ambiguous column name exception bug for Table API

hequn8128 opened a new pull request #9077: [FLINK-13196][table] Fix Ambiguous column name exception bug for Table API URL: https://github.com/apache/flink/pull/9077 ## What is the purpose of the change This pull request fixes Ambiguous column name exception bug for Table

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302354841 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302354736 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302359849 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302355917 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302358796 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302358581 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302358649 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302355599 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302357869 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302356136 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302357572 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302359068 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302359017 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302360021 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302360647 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302356473 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302355652 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302358314 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source

wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source URL: https://github.com/apache/flink/pull/9029#discussion_r302355984 ## File path:

[GitHub] [flink] flinkbot commented on issue #9021: [hostfix][runtime] Make checkpoints injection ordered with stop-with-savepoint

flinkbot commented on issue #9021: [hostfix][runtime] Make checkpoints injection ordered with stop-with-savepoint URL: https://github.com/apache/flink/pull/9021#issuecomment-510323564 CI report for commit abed4b5678a2f09b3bb729bd62b5264e56b55b9f: FAILURE

[GitHub] [flink] xuefuz commented on a change in pull request #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager

xuefuz commented on a change in pull request #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager URL: https://github.com/apache/flink/pull/8920#discussion_r302357374 ## File path:

[GitHub] [flink] flinkbot commented on issue #9047: [FLINK-13109][docs-zh]Translate "Restart Strategies" page into Chinese

flinkbot commented on issue #9047: [FLINK-13109][docs-zh]Translate "Restart Strategies" page into Chinese URL: https://github.com/apache/flink/pull/9047#issuecomment-510321288 CI report for commit 4eeb4fcf1480bd43e12be51879bc5b4ce901b5e9: SUCCESS

[GitHub] [flink] gaoyunhaii commented on a change in pull request #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers

gaoyunhaii commented on a change in pull request #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers URL: https://github.com/apache/flink/pull/8925#discussion_r302356552 ## File path:

[GitHub] [flink] gaoyunhaii commented on a change in pull request #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers

gaoyunhaii commented on a change in pull request #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers URL: https://github.com/apache/flink/pull/8925#discussion_r302354310 ## File path:

[GitHub] [flink] gaoyunhaii commented on a change in pull request #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers

gaoyunhaii commented on a change in pull request #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers URL: https://github.com/apache/flink/pull/8925#discussion_r302353092 ## File path:

[GitHub] [flink] gaoyunhaii commented on a change in pull request #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers

gaoyunhaii commented on a change in pull request #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers URL: https://github.com/apache/flink/pull/8925#discussion_r302353455 ## File path:

[GitHub] [flink] flinkbot commented on issue #9056: [FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0 in sql parser & flink planner

flinkbot commented on issue #9056: [FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0 in sql parser & flink planner URL: https://github.com/apache/flink/pull/9056#issuecomment-510317452 CI report for commit e73503e4d0c3a07cc440bff8b0d62eefcb4834ec: FAILURE

[GitHub] [flink] gaoyunhaii commented on a change in pull request #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers

gaoyunhaii commented on a change in pull request #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers URL: https://github.com/apache/flink/pull/8925#discussion_r302353092 ## File path:

[jira] [Created] (FLINK-13201) Unstable sql time udf test

Kurt Young created FLINK-13201: -- Summary: Unstable sql time udf test Key: FLINK-13201 URL: https://issues.apache.org/jira/browse/FLINK-13201 Project: Flink Issue Type: Test

[GitHub] [flink] flinkbot commented on issue #9068: [FLINK-13195] Add create table support for SqlClient

flinkbot commented on issue #9068: [FLINK-13195] Add create table support for SqlClient URL: https://github.com/apache/flink/pull/9068#issuecomment-510314838 CI report for commit 829e8aef5c2ef6c2263998f00cf73448ff4a518c: FAILURE

[GitHub] [flink] lirui-apache commented on issue #9067: [FLINK-13069][hive] HiveTableSink should implement OverwritableTableSink

lirui-apache commented on issue #9067: [FLINK-13069][hive] HiveTableSink should implement OverwritableTableSink URL: https://github.com/apache/flink/pull/9067#issuecomment-510313753 Updated to address comments. @xuefuz @bowenli86 please take a look, thanks.

[GitHub] [flink] flinkbot commented on issue #9057: [FLINK-13121] [table-planner-blink] Set batch properties to runtime in blink batch executor

flinkbot commented on issue #9057: [FLINK-13121] [table-planner-blink] Set batch properties to runtime in blink batch executor URL: https://github.com/apache/flink/pull/9057#issuecomment-510313483 CI report for commit b616282cb875778a7a5af22a2783eaaf48104908: FAILURE

[GitHub] [flink] bowenli86 commented on a change in pull request #9067: [FLINK-13069][hive] HiveTableSink should implement OverwritableTableSink

bowenli86 commented on a change in pull request #9067: [FLINK-13069][hive] HiveTableSink should implement OverwritableTableSink URL: https://github.com/apache/flink/pull/9067#discussion_r302349765 ## File path:

[GitHub] [flink] godfreyhe commented on issue #9039: [FLINK-13170][table-planner] Planner should get table factory from ca…

godfreyhe commented on issue #9039: [FLINK-13170][table-planner] Planner should get table factory from ca… URL: https://github.com/apache/flink/pull/9039#issuecomment-510311997 thanks for this pr @lirui-apache. `StreamPlanner` in flink-table-planner module should also be updated, just as

[GitHub] [flink] lirui-apache commented on a change in pull request #9067: [FLINK-13069][hive] HiveTableSink should implement OverwritableTableSink

lirui-apache commented on a change in pull request #9067: [FLINK-13069][hive] HiveTableSink should implement OverwritableTableSink URL: https://github.com/apache/flink/pull/9067#discussion_r302348621 ## File path:

[GitHub] [flink] lincoln-lil commented on a change in pull request #9075: [FLINK-10245][hbase] Add an upsert table sink factory for HBase

lincoln-lil commented on a change in pull request #9075: [FLINK-10245][hbase] Add an upsert table sink factory for HBase URL: https://github.com/apache/flink/pull/9075#discussion_r302347191 ## File path:

[GitHub] [flink] lincoln-lil commented on a change in pull request #9075: [FLINK-10245][hbase] Add an upsert table sink factory for HBase

lincoln-lil commented on a change in pull request #9075: [FLINK-10245][hbase] Add an upsert table sink factory for HBase URL: https://github.com/apache/flink/pull/9075#discussion_r302347476 ## File path:

[GitHub] [flink] zjuwangg commented on issue #9037: [FLINK-13157]reeanble unit test read complext type of HiveInputFormatTest

zjuwangg commented on issue #9037: [FLINK-13157]reeanble unit test read complext type of HiveInputFormatTest URL: https://github.com/apache/flink/pull/9037#issuecomment-510309575 > > The latest changes look good to me. It would be good if we can revert unnecessary changes to the

[GitHub] [flink] wuchong commented on issue #8294: [FLINK-12348][table-planner-blink]Use TableConfig in api module to replace TableConfig in blink-planner module.

wuchong commented on issue #8294: [FLINK-12348][table-planner-blink]Use TableConfig in api module to replace TableConfig in blink-planner module. URL: https://github.com/apache/flink/pull/8294#issuecomment-510307375 How about changing `addParameters` to `addConfigs` ? Maybe config is more

[GitHub] [flink] danny0405 commented on issue #9068: [FLINK-13195] Add create table support for SqlClient

danny0405 commented on issue #9068: [FLINK-13195] Add create table support for SqlClient URL: https://github.com/apache/flink/pull/9068#issuecomment-510307115 @twalthr How about we cache a `catalogName -> DDLs` mapping in the `SessionContext`, just like we cache the `ViewEntry`, then we

[jira] [Comment Edited] (FLINK-13181) Add a constructor function to CsvTableSink

[ https://issues.apache.org/jira/browse/FLINK-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882608#comment-16882608 ] hehuiyuan edited comment on FLINK-13181 at 7/11/19 2:46 AM: Good idea. Using

[GitHub] [flink] flinkbot commented on issue #9072: [FLINK-11630] Wait for the termination of all running Tasks when shutting down TaskExecutor

flinkbot commented on issue #9072: [FLINK-11630] Wait for the termination of all running Tasks when shutting down TaskExecutor URL: https://github.com/apache/flink/pull/9072#issuecomment-510306664 CI report for commit cd5ad8d23046c1025f7f9865e60fc3d048fd1f85: SUCCESS

[jira] [Commented] (FLINK-13181) Add a constructor function to CsvTableSink

[ https://issues.apache.org/jira/browse/FLINK-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882608#comment-16882608 ] hehuiyuan commented on FLINK-13181: --- Using `Builder`  is more convenient. > Add a constructor

[GitHub] [flink] flinkbot commented on issue #9076: [FLINK-13200][Table SQL / Planner] Improve the generated code for if statements

flinkbot commented on issue #9076: [FLINK-13200][Table SQL / Planner] Improve the generated code for if statements URL: https://github.com/apache/flink/pull/9076#issuecomment-510306052 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[jira] [Updated] (FLINK-13200) Improve the generated code for if statements

[ https://issues.apache.org/jira/browse/FLINK-13200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13200: --- Labels: pull-request-available (was: ) > Improve the generated code for if statements >

[GitHub] [flink] liyafan82 opened a new pull request #9076: [FLINK-13200][Table SQL / Planner] Improve the generated code for if statements

liyafan82 opened a new pull request #9076: [FLINK-13200][Table SQL / Planner] Improve the generated code for if statements URL: https://github.com/apache/flink/pull/9076 ## What is the purpose of the change In the generated code, we often code snippet like this:

[GitHub] [flink] wuchong commented on issue #9074: [FLINK-13198][core] Introduce TimeLength in configuration package

wuchong commented on issue #9074: [FLINK-13198][core] Introduce TimeLength in configuration package URL: https://github.com/apache/flink/pull/9074#issuecomment-510304773 cc @zentol , I think you may also want to have a look at this?

[GitHub] [flink] wuchong commented on a change in pull request #9074: [FLINK-13198][core] Introduce TimeLength in configuration package

wuchong commented on a change in pull request #9074: [FLINK-13198][core] Introduce TimeLength in configuration package URL: https://github.com/apache/flink/pull/9074#discussion_r302340591 ## File path: flink-core/src/test/java/org/apache/flink/configuration/TimeLengthTest.java

[GitHub] [flink] wuchong commented on a change in pull request #9074: [FLINK-13198][core] Introduce TimeLength in configuration package

wuchong commented on a change in pull request #9074: [FLINK-13198][core] Introduce TimeLength in configuration package URL: https://github.com/apache/flink/pull/9074#discussion_r302341272 ## File path: flink-core/src/test/java/org/apache/flink/configuration/TimeLengthTest.java

[GitHub] [flink] wuchong commented on a change in pull request #9074: [FLINK-13198][core] Introduce TimeLength in configuration package

wuchong commented on a change in pull request #9074: [FLINK-13198][core] Introduce TimeLength in configuration package URL: https://github.com/apache/flink/pull/9074#discussion_r302341200 ## File path: flink-core/src/test/java/org/apache/flink/configuration/TimeLengthTest.java

[GitHub] [flink] wuchong commented on a change in pull request #9074: [FLINK-13198][core] Introduce TimeLength in configuration package

wuchong commented on a change in pull request #9074: [FLINK-13198][core] Introduce TimeLength in configuration package URL: https://github.com/apache/flink/pull/9074#discussion_r302341162 ## File path:

[GitHub] [flink] godfreyhe commented on issue #9056: [FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0 in sql parser & flink planner

godfreyhe commented on issue #9056: [FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0 in sql parser & flink planner URL: https://github.com/apache/flink/pull/9056#issuecomment-510304178 > > > Oops.. I only had validated the dependency in flink-table module. I

[GitHub] [flink] flinkbot commented on issue #9030: [FLINK-13123] Align Stop/Cancel Commands in CLI and REST Interface and Improve Documentation

flinkbot commented on issue #9030: [FLINK-13123] Align Stop/Cancel Commands in CLI and REST Interface and Improve Documentation URL: https://github.com/apache/flink/pull/9030#issuecomment-510303704 CI report for commit 9a4bb16fa7220a166c29701e65c90f0b11b6dfc4: SUCCESS

[GitHub] [flink] lirui-apache commented on a change in pull request #9067: [FLINK-13069][hive] HiveTableSink should implement OverwritableTableSink

lirui-apache commented on a change in pull request #9067: [FLINK-13069][hive] HiveTableSink should implement OverwritableTableSink URL: https://github.com/apache/flink/pull/9067#discussion_r302342236 ## File path:

[jira] [Created] (FLINK-13200) Improve the generated code for if statements

Liya Fan created FLINK-13200: Summary: Improve the generated code for if statements Key: FLINK-13200 URL: https://issues.apache.org/jira/browse/FLINK-13200 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-13163) Support execution of batch jobs with fewer slots than requested

[ https://issues.apache.org/jira/browse/FLINK-13163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882597#comment-16882597 ] Zhu Zhu commented on FLINK-13163: - Hi [~kkrugler], the input splits problem discussed above may result

[GitHub] [flink] xintongsong commented on issue #8846: [FLINK-12766][runtime] Dynamically allocate TaskExecutor's managed memory to slots.

xintongsong commented on issue #8846: [FLINK-12766][runtime] Dynamically allocate TaskExecutor's managed memory to slots. URL: https://github.com/apache/flink/pull/8846#issuecomment-510301993 Thank you for the comments, @StephanEwen, @KurtYoung. This truly is an imperfect temporal

[GitHub] [flink] hehuiyuan commented on a change in pull request #9054: [FLINK-13183][Table]Add a PrintTableSink

hehuiyuan commented on a change in pull request #9054: [FLINK-13183][Table]Add a PrintTableSink URL: https://github.com/apache/flink/pull/9054#discussion_r302340288 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sinks/PrintTableSink.java

[jira] [Assigned] (FLINK-12858) Potentially not properly working Flink job in case of stop-with-savepoint failure

[ https://issues.apache.org/jira/browse/FLINK-12858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yelun reassigned FLINK-12858: - Assignee: yelun > Potentially not properly working Flink job in case of stop-with-savepoint > failure

[jira] [Commented] (FLINK-13150) defaultCatalogName and defaultDatabaseName in TableEnvImpl is not updated after they are updated in TableEnvironment

[ https://issues.apache.org/jira/browse/FLINK-13150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882587#comment-16882587 ] Jeff Zhang commented on FLINK-13150: [~xuefuz] It happens when I register table. here's the sample

[GitHub] [flink] godfreyhe commented on issue #9056: [FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0 in sql parser & flink planner

godfreyhe commented on issue #9056: [FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0 in sql parser & flink planner URL: https://github.com/apache/flink/pull/9056#issuecomment-510297306 > > Oops.. I only had validated the dependency in flink-table module. I will

[GitHub] [flink] flinkbot commented on issue #8418: [FLINK-12491][docs][configuration] Fix incorrect javadoc for path sep…

flinkbot commented on issue #8418: [FLINK-12491][docs][configuration] Fix incorrect javadoc for path sep… URL: https://github.com/apache/flink/pull/8418#issuecomment-510296832 CI report for commit df6d3f5acd084931c16fe8564cfd8532d3889111: SUCCESS

[GitHub] [flink] KurtYoung commented on issue #9056: [FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0 in sql parser & flink planner

KurtYoung commented on issue #9056: [FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0 in sql parser & flink planner URL: https://github.com/apache/flink/pull/9056#issuecomment-510295851 > Oops.. I only had validated the dependency in flink-table module. I will

[GitHub] [flink] flinkbot commented on issue #9075: [FLINK-10245][hbase] Add an upsert table sink factory for HBase

flinkbot commented on issue #9075: [FLINK-10245][hbase] Add an upsert table sink factory for HBase URL: https://github.com/apache/flink/pull/9075#issuecomment-510295340 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] wuchong closed pull request #7550: [FLINK-10245] [Streaming Connector] Support UpsertHBaseSink and UpsertHBaseTableSink

wuchong closed pull request #7550: [FLINK-10245] [Streaming Connector] Support UpsertHBaseSink and UpsertHBaseTableSink URL: https://github.com/apache/flink/pull/7550 This is an automated message from the Apache Git

[GitHub] [flink] wuchong commented on issue #7550: [FLINK-10245] [Streaming Connector] Support UpsertHBaseSink and UpsertHBaseTableSink

wuchong commented on issue #7550: [FLINK-10245] [Streaming Connector] Support UpsertHBaseSink and UpsertHBaseTableSink URL: https://github.com/apache/flink/pull/7550#issuecomment-510295366 Thanks @Clark for the great effort on this. As discussed with @Clark offline, we will

[GitHub] [flink] flinkbot commented on issue #9072: [FLINK-11630] Wait for the termination of all running Tasks when shutting down TaskExecutor

flinkbot commented on issue #9072: [FLINK-11630] Wait for the termination of all running Tasks when shutting down TaskExecutor URL: https://github.com/apache/flink/pull/9072#issuecomment-510295107 CI report for commit 29515b7b3492ce0007b3073875ea92ac5880b3c7: SUCCESS

[jira] [Updated] (FLINK-10245) Add an upsert table sink factory for HBase

[ https://issues.apache.org/jira/browse/FLINK-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-10245: Description: Design documentation: 

[jira] [Updated] (FLINK-10245) Add an upsert table sink factory for HBase

[ https://issues.apache.org/jira/browse/FLINK-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-10245: Summary: Add an upsert table sink factory for HBase (was: Add HBase Streaming Sink and TableFactory) >

[GitHub] [flink] wuchong opened a new pull request #9075: [FLINK-10245][hbase] Add an upsert table sink factory for HBase

wuchong opened a new pull request #9075: [FLINK-10245][hbase] Add an upsert table sink factory for HBase URL: https://github.com/apache/flink/pull/9075 ## What is the purpose of the change This commit adds full support for HBase to be used with Table & SQL API as well as

[jira] [Updated] (FLINK-13133) Correct error in PubSub documentation

[ https://issues.apache.org/jira/browse/FLINK-13133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian updated FLINK-13133: Labels: newbie starter (was: ) > Correct error in PubSub documentation >

[GitHub] [flink] flinkbot commented on issue #9074: [FLINK-13198][core] Introduce TimeLength in configuration package

flinkbot commented on issue #9074: [FLINK-13198][core] Introduce TimeLength in configuration package URL: https://github.com/apache/flink/pull/9074#issuecomment-510294340 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[jira] [Updated] (FLINK-13198) Introduce TimeLength in configuration package

[ https://issues.apache.org/jira/browse/FLINK-13198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13198: --- Labels: pull-request-available (was: ) > Introduce TimeLength in configuration package >

[GitHub] [flink] TsReaper opened a new pull request #9074: [FLINK-13198][core] Introduce TimeLength in configuration package

TsReaper opened a new pull request #9074: [FLINK-13198][core] Introduce TimeLength in configuration package URL: https://github.com/apache/flink/pull/9074 ## What is the purpose of the change Similar with MemorySize in the configuration package, we also need to introduce a

[GitHub] [flink] godfreyhe commented on issue #9056: [FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0 in sql parser & flink planner

godfreyhe commented on issue #9056: [FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0 in sql parser & flink planner URL: https://github.com/apache/flink/pull/9056#issuecomment-510293697 Oops.. I only had validated the dependency in flink-table module. I will

[GitHub] [flink] KurtYoung commented on issue #9056: [FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0 in sql parser & flink planner

KurtYoung commented on issue #9056: [FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0 in sql parser & flink planner URL: https://github.com/apache/flink/pull/9056#issuecomment-510292157 python tests are failed with: E Caused by:

[jira] [Created] (FLINK-13199) ARM support for Flink

wangxiyuan created FLINK-13199: -- Summary: ARM support for Flink Key: FLINK-13199 URL: https://issues.apache.org/jira/browse/FLINK-13199 Project: Flink Issue Type: Wish Components:

[GitHub] [flink] KurtYoung edited a comment on issue #9056: [FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0 in sql parser & flink planner

KurtYoung edited a comment on issue #9056: [FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0 in sql parser & flink planner URL: https://github.com/apache/flink/pull/9056#issuecomment-510292629 The reason might be: ```

[GitHub] [flink] KurtYoung commented on issue #9056: [FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0 in sql parser & flink planner

KurtYoung commented on issue #9056: [FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0 in sql parser & flink planner URL: https://github.com/apache/flink/pull/9056#issuecomment-510292629 The reason might be:

[jira] [Created] (FLINK-13198) Introduce TimeLength in configuration package

Caizhi Weng created FLINK-13198: --- Summary: Introduce TimeLength in configuration package Key: FLINK-13198 URL: https://issues.apache.org/jira/browse/FLINK-13198 Project: Flink Issue Type:

[GitHub] [flink] KurtYoung commented on issue #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

KurtYoung commented on issue #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#issuecomment-510290992 > How about supporting DDL & DML both in `sqlUpdate`? This can avoid to introduce a new `sql()` interface right

[GitHub] [flink] mrzhangboss commented on a change in pull request #9064: [FLINK-13188][Runtime / State Backends][Test] Fix annotation type error in MockTtlStateTest

mrzhangboss commented on a change in pull request #9064: [FLINK-13188][Runtime / State Backends][Test] Fix annotation type error in MockTtlStateTest URL: https://github.com/apache/flink/pull/9064#discussion_r302333139 ## File path:

  1   2   3   4   5   6   7   >