[GitHub] [flink-table-store] JingsongLi closed pull request #569: [FLINK-31269] Split hive connector to each module of each version

2023-03-07 Thread via GitHub
JingsongLi closed pull request #569: [FLINK-31269] Split hive connector to each module of each version URL: https://github.com/apache/flink-table-store/pull/569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] gaoyunhaii commented on pull request #21736: [FLINK-27518][tests] Refactor migration tests to support version update automatically

2023-03-07 Thread via GitHub
gaoyunhaii commented on PR #21736: URL: https://github.com/apache/flink/pull/21736#issuecomment-1459669377 Hi @XComp the option of having the information in the resource direction looks good to me, I'll update the PR and also squash the commits. -- This is an automated message from the

[jira] [Commented] (FLINK-31307) RocksDB:java.lang.UnsatisfiedLinkError

2023-03-07 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697765#comment-17697765 ] Yun Tang commented on FLINK-31307: -- What's the meaning of {{2.2.1}} after

[GitHub] [flink] WencongLiu commented on pull request #22128: [FLINK-31298] backport to branch release-1.16

2023-03-07 Thread via GitHub
WencongLiu commented on PR #22128: URL: https://github.com/apache/flink/pull/22128#issuecomment-1459661390 cc @reswqa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] WencongLiu commented on pull request #22129: [FLINK-31298] backport to branch release-1.17

2023-03-07 Thread via GitHub
WencongLiu commented on PR #22129: URL: https://github.com/apache/flink/pull/22129#issuecomment-1459661015 cc @reswqa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] WencongLiu commented on pull request #22129: [FLINK-31298] backport to branch release-1.17

2023-03-07 Thread via GitHub
WencongLiu commented on PR #22129: URL: https://github.com/apache/flink/pull/22129#issuecomment-1459660239 cc @reswqa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #22129: [FLINK-31298] backport to branch release-1.17

2023-03-07 Thread via GitHub
flinkbot commented on PR #22129: URL: https://github.com/apache/flink/pull/22129#issuecomment-1459658319 ## CI report: * 9cb47c24198a1806cffbfd41515500284f92d486 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #22128: [FLINK-31298] backport to branch release-1.16

2023-03-07 Thread via GitHub
flinkbot commented on PR #22128: URL: https://github.com/apache/flink/pull/22128#issuecomment-1459658196 ## CI report: * 6e3d0b7ae2fc6cea17d3822b4fcf6844c927171e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] WencongLiu opened a new pull request, #22129: [FLINK-31298] backport to branch release-1.17

2023-03-07 Thread via GitHub
WencongLiu opened a new pull request, #22129: URL: https://github.com/apache/flink/pull/22129 fix ConnectionUtilsTest.testFindConnectingAddressWhenGetLocalHostThrows swallows IllegalArgumentException -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] WencongLiu opened a new pull request, #22128: [FLINK-31298] backport to branch 1.16

2023-03-07 Thread via GitHub
WencongLiu opened a new pull request, #22128: URL: https://github.com/apache/flink/pull/22128 fix ConnectionUtilsTest.testFindConnectingAddressWhenGetLocalHostThrows swallows IllegalArgumentException -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] lincoln-lil commented on a diff in pull request #22127: [FLINK-31351][sql-gateway] Don't stop the stuck thread by force

2023-03-07 Thread via GitHub
lincoln-lil commented on code in PR #22127: URL: https://github.com/apache/flink/pull/22127#discussion_r1129043195 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationManager.java: ## @@ -183,12 +190,15 @@ public ResultSet

[jira] [Closed] (FLINK-30829) Make the backpressure tab could be sort by the backpressure level

2023-03-07 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-30829. -- Fix Version/s: 1.18.0 Resolution: Fixed master(1.18) via

[jira] [Updated] (FLINK-30829) Make the backpressure tab could be sort by the backpressure level

2023-03-07 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-30829: --- Affects Version/s: 1.18.0 > Make the backpressure tab could be sort by the backpressure level >

[GitHub] [flink] reswqa commented on pull request #22108: [FLINK-30829] Make the backpressure tab could be sort by busy/backpressure/idle seperately

2023-03-07 Thread via GitHub
reswqa commented on PR #22108: URL: https://github.com/apache/flink/pull/22108#issuecomment-1459628828 Thanks @yangjunhan, meged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] reswqa merged pull request #22108: [FLINK-30829] Make the backpressure tab could be sort by busy/backpressure/idle seperately

2023-03-07 Thread via GitHub
reswqa merged PR #22108: URL: https://github.com/apache/flink/pull/22108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-31356) Serialize garbled characters at checkpoint

2023-03-07 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697746#comment-17697746 ] Yanfei Lei commented on FLINK-31356: Did any POJO fields update when restoring? Is it related to

[GitHub] [flink] reswqa commented on pull request #22108: [FLINK-30829] Make the backpressure tab could be sort by busy/backpressure/idle seperately

2023-03-07 Thread via GitHub
reswqa commented on PR #22108: URL: https://github.com/apache/flink/pull/22108#issuecomment-1459620850 @yangjunhan, Would you mind taking a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (FLINK-31298) ConnectionUtilsTest.testFindConnectingAddressWhenGetLocalHostThrows swallows IllegalArgumentException

2023-03-07 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697743#comment-17697743 ] Weijie Guo commented on FLINK-31298: master(1.18) via 7c5b7be5bc165a9799f10b5761a6ff15edee43b6.

[GitHub] [flink] reswqa commented on pull request #22110: [FLINK-31298] fix ConnectionUtilsTest.testFindConnectingAddressWhenGetLocalHostThrows swallows IllegalArgumentException

2023-03-07 Thread via GitHub
reswqa commented on PR #22110: URL: https://github.com/apache/flink/pull/22110#issuecomment-1459617373 @WencongLiu We should backport this to relase-1.16 and release-1.17 also. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Closed] (FLINK-27258) Deployment Chinese document malformed text

2023-03-07 Thread Jia Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jia Fan closed FLINK-27258. --- Resolution: Invalid > Deployment Chinese document malformed text >

[GitHub] [flink] reswqa merged pull request #22110: [FLINK-31298] fix ConnectionUtilsTest.testFindConnectingAddressWhenGetLocalHostThrows swallows IllegalArgumentException

2023-03-07 Thread via GitHub
reswqa merged PR #22110: URL: https://github.com/apache/flink/pull/22110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-table-store] yuzelin commented on pull request #584: [FLINK-31338] support infer parallelism for flink table store

2023-03-07 Thread via GitHub
yuzelin commented on PR #584: URL: https://github.com/apache/flink-table-store/pull/584#issuecomment-1459614486 The same problem I have met before. I've pushed some commits to try to solve the problem. You can rebase master. -- This is an automated message from the Apache Git Service.

[GitHub] [flink] reswqa commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-07 Thread via GitHub
reswqa commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1129022590 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPoolTest.java: ## @@ -242,23 +243,206 @@ public void testRecycleAfterDestroy() {

[GitHub] [flink] reswqa commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-07 Thread via GitHub
reswqa commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1129022590 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPoolTest.java: ## @@ -242,23 +243,206 @@ public void testRecycleAfterDestroy() {

[GitHub] [flink] reswqa commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-07 Thread via GitHub
reswqa commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1129012456 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -503,12 +508,11 @@ private void onGlobalPoolAvailable() {

[GitHub] [flink] reswqa commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-07 Thread via GitHub
reswqa commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1129012456 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -503,12 +508,11 @@ private void onGlobalPoolAvailable() {

[GitHub] [flink] reswqa commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-07 Thread via GitHub
reswqa commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1129012456 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -503,12 +508,11 @@ private void onGlobalPoolAvailable() {

[GitHub] [flink] reswqa commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-07 Thread via GitHub
reswqa commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1129012456 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -503,12 +508,11 @@ private void onGlobalPoolAvailable() {

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-07 Thread via GitHub
1996fanrui commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1128996203 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -503,12 +508,11 @@ private void onGlobalPoolAvailable() {

[jira] [Commented] (FLINK-31351) HiveServer2EndpointITCase.testExecuteStatementInSyncModeWithRuntimeException2 times out on CI

2023-03-07 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697736#comment-17697736 ] Shengkai Fang commented on FLINK-31351: --- I think the main cause is that the Thread#stop is not

[GitHub] [flink-table-store] FangYongs commented on pull request #426: [FLINK-30323] Support table statistics in table store

2023-03-07 Thread via GitHub
FangYongs commented on PR #426: URL: https://github.com/apache/flink-table-store/pull/426#issuecomment-1459593126 Hi @JingsongLi I have updated this PR, please help to review it again, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Closed] (FLINK-31365) Simplify FlinkActionsE2ETest#testMergeInto

2023-03-07 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-31365. Fix Version/s: table-store-0.4.0 Assignee: yuzelin Resolution: Fixed master:

[jira] [Updated] (FLINK-31365) Simplify FlinkActionsE2ETest#testMergeInto

2023-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31365: --- Labels: pull-request-available (was: ) > Simplify FlinkActionsE2ETest#testMergeInto >

[GitHub] [flink-table-store] JingsongLi merged pull request #587: [FLINK-31365] Fix unstable FlinkActionsE2ETest#testMergeInto by simplifying it

2023-03-07 Thread via GitHub
JingsongLi merged PR #587: URL: https://github.com/apache/flink-table-store/pull/587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-07 Thread via GitHub
1996fanrui commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1128996203 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -503,12 +508,11 @@ private void onGlobalPoolAvailable() {

[GitHub] [flink-table-store] FangYongs commented on pull request #569: [FLINK-31269] Split hive connector to each module of each version

2023-03-07 Thread via GitHub
FangYongs commented on PR #569: URL: https://github.com/apache/flink-table-store/pull/569#issuecomment-1459580158 > > > > Have you tried to setup metastore in hive-2.1-cdh-6.3, and use flink-table-store-hive-catalog.jar in Flink side? Hi @JingsongLi I also test for

[GitHub] [flink-table-store] FangYongs commented on pull request #569: [FLINK-31269] Split hive connector to each module of each version

2023-03-07 Thread via GitHub
FangYongs commented on PR #569: URL: https://github.com/apache/flink-table-store/pull/569#issuecomment-1459579297 Thanks @tsreaper DONE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-07 Thread via GitHub
1996fanrui commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1128996203 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -503,12 +508,11 @@ private void onGlobalPoolAvailable() {

[GitHub] [flink] fsk119 commented on pull request #16532: [FLINK-13400]Remove Hive and Hadoop dependencies from SQL Client

2023-03-07 Thread via GitHub
fsk119 commented on PR #16532: URL: https://github.com/apache/flink/pull/16532#issuecomment-1459564895 @snuyanzin Sorry for the late response. I think SqlGatewayE2ECase is a good point to restart the work. We have introduced a hive docker in the test. -- This is an automated message from

[GitHub] [flink] wuchong merged pull request #22104: [hotfix][docs] Fix the wrong configuration key of "table.exec.simplify-operator-name-enabled" in documentation

2023-03-07 Thread via GitHub
wuchong merged PR #22104: URL: https://github.com/apache/flink/pull/22104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-31311) Supports Bounded Watermark streaming read

2023-03-07 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-31311. Resolution: Fixed master: e715ac81a906e8f1b285d3847cc75879bb54d062 > Supports Bounded Watermark

[GitHub] [flink-table-store] JingsongLi merged pull request #576: [FLINK-31311] Supports Bounded Watermark streaming read

2023-03-07 Thread via GitHub
JingsongLi merged PR #576: URL: https://github.com/apache/flink-table-store/pull/576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #22127: [FLINK-31351][sql-gateway] Don't stop the stuck thread by force

2023-03-07 Thread via GitHub
flinkbot commented on PR #22127: URL: https://github.com/apache/flink/pull/22127#issuecomment-1459422574 ## CI report: * 2331a3f92229c2cd6dfd0f2dc418f77fbc83e4c3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-31365) Simplify FlinkActionsE2ETest#testMergeInto

2023-03-07 Thread yuzelin (Jira)
yuzelin created FLINK-31365: --- Summary: Simplify FlinkActionsE2ETest#testMergeInto Key: FLINK-31365 URL: https://issues.apache.org/jira/browse/FLINK-31365 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-31351) HiveServer2EndpointITCase.testExecuteStatementInSyncModeWithRuntimeException2 times out on CI

2023-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31351: --- Labels: pull-request-available test-stability (was: test-stability) >

[GitHub] [flink] fsk119 opened a new pull request, #22127: [FLINK-31351][sql-gateway] Don't stop the stuck thread by force

2023-03-07 Thread via GitHub
fsk119 opened a new pull request, #22127: URL: https://github.com/apache/flink/pull/22127 ## What is the purpose of the change *We should not stop the thread by force because it may cause an inconsistent state. So we just notify the users it has the possibility to cause

[jira] [Assigned] (FLINK-31351) HiveServer2EndpointITCase.testExecuteStatementInSyncModeWithRuntimeException2 times out on CI

2023-03-07 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-31351: - Assignee: Shengkai Fang >

[GitHub] [flink] reswqa closed pull request #22122: [BP-1.17][FLINK-31346][runtime] IO scheduler does not throw TimeoutException if numRequestedBuffers is greater than 0.

2023-03-07 Thread via GitHub
reswqa closed pull request #22122: [BP-1.17][FLINK-31346][runtime] IO scheduler does not throw TimeoutException if numRequestedBuffers is greater than 0. URL: https://github.com/apache/flink/pull/22122 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] reswqa commented on pull request #22122: [BP-1.17][FLINK-31346][runtime] IO scheduler does not throw TimeoutException if numRequestedBuffers is greater than 0.

2023-03-07 Thread via GitHub
reswqa commented on PR #22122: URL: https://github.com/apache/flink/pull/22122#issuecomment-1459371675 closed via 54c67e5e08c11ef9a538abbf14618f9e27be18f7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] reswqa commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-07 Thread via GitHub
reswqa commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1128947802 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPoolTest.java: ## @@ -242,23 +243,206 @@ public void testRecycleAfterDestroy() {

[GitHub] [flink-table-store] zhangjun0x01 commented on pull request #584: [FLINK-31338] support infer parallelism for flink table store

2023-03-07 Thread via GitHub
zhangjun0x01 commented on PR #584: URL: https://github.com/apache/flink-table-store/pull/584#issuecomment-1459354880 > @zhangjun0x01 Can we consider to use bucket number as streaming default parallelism? And use parallelism inference only for batch source. ok -- This is an

[GitHub] [flink-table-store] zhangjun0x01 commented on pull request #584: [FLINK-31338] support infer parallelism for flink table store

2023-03-07 Thread via GitHub
zhangjun0x01 commented on PR #584: URL: https://github.com/apache/flink-table-store/pull/584#issuecomment-1459353387 > I guess why there are test failures is because too much parallelism has been derived, resulting in scheduling failures. Should we disable parallelism inference in

[GitHub] [flink] masteryhx commented on a diff in pull request #21835: [FLINK-30854][state] Support periodic compaction for RocksdbCompactFilterCleanupStrategy

2023-03-07 Thread via GitHub
masteryhx commented on code in PR #21835: URL: https://github.com/apache/flink/pull/21835#discussion_r1128942248 ## flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java: ## @@ -437,18 +465,43 @@ public boolean runCleanupForEveryRecord() {

[jira] [Updated] (FLINK-30983) the security.ssl.algorithms configuration does not take effect in rest ssl

2023-03-07 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-30983: - Fix Version/s: 1.17.0 1.18.0 > the security.ssl.algorithms configuration does not

[GitHub] [flink] masteryhx commented on a diff in pull request #21835: [FLINK-30854][state] Support periodic compaction for RocksdbCompactFilterCleanupStrategy

2023-03-07 Thread via GitHub
masteryhx commented on code in PR #21835: URL: https://github.com/apache/flink/pull/21835#discussion_r1128940896 ## flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java: ## @@ -298,12 +298,40 @@ public Builder cleanupInRocksdbCompactFilter(long

[GitHub] [flink-table-store] JingsongLi commented on pull request #584: [FLINK-31338] support infer parallelism for flink table store

2023-03-07 Thread via GitHub
JingsongLi commented on PR #584: URL: https://github.com/apache/flink-table-store/pull/584#issuecomment-1459327789 @zhangjun0x01 Can we consider to use bucket number as default parallelism? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] JunRuiLee commented on a diff in pull request #22098: [FLINK-31144][coordination] Modify the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the

2023-03-07 Thread via GitHub
JunRuiLee commented on code in PR #22098: URL: https://github.com/apache/flink/pull/22098#discussion_r1128940538 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetriever.java: ## @@ -95,8 +95,7 @@ private CompletableFuture>

[GitHub] [flink] huwh commented on a diff in pull request #22098: [FLINK-31144][coordination] Modify the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the corre

2023-03-07 Thread via GitHub
huwh commented on code in PR #22098: URL: https://github.com/apache/flink/pull/22098#discussion_r1128938614 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetriever.java: ## @@ -95,8 +95,7 @@ private CompletableFuture>

[GitHub] [flink] reswqa commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-07 Thread via GitHub
reswqa commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1128937275 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -503,12 +508,11 @@ private void onGlobalPoolAvailable() {

[GitHub] [flink] reswqa commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-07 Thread via GitHub
reswqa commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1128937275 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -503,12 +508,11 @@ private void onGlobalPoolAvailable() {

[GitHub] [flink] reswqa commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-07 Thread via GitHub
reswqa commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1128937275 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -503,12 +508,11 @@ private void onGlobalPoolAvailable() {

[GitHub] [flink] flinkbot commented on pull request #22126: [Bug][FLINK-31363]KafkaSink failed to commit transactions under EXACTLY_ONCE semantics.

2023-03-07 Thread via GitHub
flinkbot commented on PR #22126: URL: https://github.com/apache/flink/pull/22126#issuecomment-1459297877 ## CI report: * 79c14fdf6cfa1d56740e66d78e7b737b803e7591 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31363) KafkaSink failed to commit transactions under EXACTLY_ONCE semantics

2023-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31363: --- Labels: pull-request-available (was: ) > KafkaSink failed to commit transactions under

[GitHub] [flink] lightzhao opened a new pull request, #22126: [Bug][FLINK-31363]KafkaSink failed to commit transactions under EXACTLY_ONCE semantics.

2023-03-07 Thread via GitHub
lightzhao opened a new pull request, #22126: URL: https://github.com/apache/flink/pull/22126 ## What is the purpose of the change [FLINK-31363](https://issues.apache.org/jira/projects/FLINK/issues/FLINK-31363) When KafkaSink starts Exactly once and no data is

[jira] [Created] (FLINK-31364) [Flink] add metrics for TableStore

2023-03-07 Thread Ming Li (Jira)
Ming Li created FLINK-31364: --- Summary: [Flink] add metrics for TableStore Key: FLINK-31364 URL: https://issues.apache.org/jira/browse/FLINK-31364 Project: Flink Issue Type: Improvement

[GitHub] [flink] reswqa commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-07 Thread via GitHub
reswqa commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1128926904 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -669,6 +669,13 @@ public void setNumBuffers(int numBuffers) {

[GitHub] [flink] masteryhx commented on pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

2023-03-07 Thread via GitHub
masteryhx commented on PR #21635: URL: https://github.com/apache/flink/pull/21635#issuecomment-1459246416 > Hey @masteryhx, do you plan to work on that for 1.18? Sure, I'd like to. Thanks a lot for the reminder. Big sorry for the delayed update due to my personal business last

[jira] [Comment Edited] (FLINK-31359) HsResultPartitionTest fails with fatal error

2023-03-07 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697703#comment-17697703 ] Weijie Guo edited comment on FLINK-31359 at 3/8/23 3:00 AM: master(1.18) via

[jira] [Closed] (FLINK-31359) HsResultPartitionTest fails with fatal error

2023-03-07 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-31359. -- Resolution: Fixed master(1.18) via eff9b16799f162f31058be5acac567943a446dea. > HsResultPartitionTest

[jira] [Updated] (FLINK-31359) HsResultPartitionTest fails with fatal error

2023-03-07 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31359: --- Fix Version/s: 1.18.0 > HsResultPartitionTest fails with fatal error >

[GitHub] [flink] JunRuiLee commented on pull request #22098: [FLINK-31144][coordination] Modify the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the correspond

2023-03-07 Thread via GitHub
JunRuiLee commented on PR #22098: URL: https://github.com/apache/flink/pull/22098#issuecomment-1459238292 @huwh @zhuzhurk Thanks for review this pr and I've addressed comments, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] reswqa merged pull request #22125: [FLINK-31360][test] Using an executor service which ignore rejectException as shutdown for HsResultPartitionTest.

2023-03-07 Thread via GitHub
reswqa merged PR #22125: URL: https://github.com/apache/flink/pull/22125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-31363) KafkaSink failed to commit transactions under EXACTLY_ONCE semantics

2023-03-07 Thread lightzhao (Jira)
lightzhao created FLINK-31363: - Summary: KafkaSink failed to commit transactions under EXACTLY_ONCE semantics Key: FLINK-31363 URL: https://issues.apache.org/jira/browse/FLINK-31363 Project: Flink

[jira] [Commented] (FLINK-31298) ConnectionUtilsTest.testFindConnectingAddressWhenGetLocalHostThrows swallows IllegalArgumentException

2023-03-07 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697698#comment-17697698 ] Wencong Liu commented on FLINK-31298: - cc [~mapohl]  >

[GitHub] [flink] WencongLiu commented on pull request #22121: [FLINK-27051] fix CompletedCheckpoint.DiscardObject.discard is not idempotent

2023-03-07 Thread via GitHub
WencongLiu commented on PR #22121: URL: https://github.com/apache/flink/pull/22121#issuecomment-1459222793 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-07 Thread via GitHub
1996fanrui commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1128900085 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -503,12 +508,11 @@ private void onGlobalPoolAvailable() {

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #210: [FLINK-31010] Add Transformer and Estimator for GBTClassifier and GBTRegressor

2023-03-07 Thread via GitHub
Fanoid commented on code in PR #210: URL: https://github.com/apache/flink-ml/pull/210#discussion_r1128905027 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/sharedstorage/SharedStorage.java: ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #210: [FLINK-31010] Add Transformer and Estimator for GBTClassifier and GBTRegressor

2023-03-07 Thread via GitHub
Fanoid commented on code in PR #210: URL: https://github.com/apache/flink-ml/pull/210#discussion_r1128889422 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/sharedstorage/SharedStorage.java: ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink] TanYuxin-tyx commented on pull request #22125: [FLINK-31360][test] Using an executor service which ignore rejectException as shutdown for HsResultPartitionTest.

2023-03-07 Thread via GitHub
TanYuxin-tyx commented on PR #22125: URL: https://github.com/apache/flink/pull/22125#issuecomment-1459208813 This change LGTM. I found similar solutions to the issue, e.g., in SchedulerFactory, KubernetesLeaderElector, etc. -- This is an automated message from the Apache Git Service.

[jira] [Comment Edited] (FLINK-31346) Batch shuffle IO scheduler does not throw TimeoutException if numRequestedBuffers is greater than 0

2023-03-07 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697402#comment-17697402 ] Weijie Guo edited comment on FLINK-31346 at 3/8/23 2:34 AM: master(1.18) via

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #210: [FLINK-31010] Add Transformer and Estimator for GBTClassifier and GBTRegressor

2023-03-07 Thread via GitHub
Fanoid commented on code in PR #210: URL: https://github.com/apache/flink-ml/pull/210#discussion_r1128889422 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/sharedstorage/SharedStorage.java: ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #210: [FLINK-31010] Add Transformer and Estimator for GBTClassifier and GBTRegressor

2023-03-07 Thread via GitHub
Fanoid commented on code in PR #210: URL: https://github.com/apache/flink-ml/pull/210#discussion_r1128873310 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/sharedstorage/SharedStorageContextImpl.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software

[jira] [Closed] (FLINK-31343) Remove JMH dependency in flink-table-store-micro-benchmark

2023-03-07 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-31343. Resolution: Fixed master: d1c224890dad80c1d7664dc3011534b3ae1679f9 > Remove JMH dependency in

[GitHub] [flink-table-store] JingsongLi merged pull request #585: [FLINK-31343] Remove JMH dependency in flink-table-store-micro-benchmark

2023-03-07 Thread via GitHub
JingsongLi merged PR #585: URL: https://github.com/apache/flink-table-store/pull/585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-table-store] FangYongs commented on pull request #585: [FLINK-31343] Remove JMH dependency in flink-table-store-micro-benchmark

2023-03-07 Thread via GitHub
FangYongs commented on PR #585: URL: https://github.com/apache/flink-table-store/pull/585#issuecomment-1459150128 Thanks @JingsongLi LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] LadyForest commented on pull request #21452: [FLINK-30282] Fix Logical type ROW lost inner field's nullability after converting to RelDataType

2023-03-07 Thread via GitHub
LadyForest commented on PR #21452: URL: https://github.com/apache/flink/pull/21452#issuecomment-1459148347 > @LadyForest this change looks reasonable however now there are some conflicts... Do you mind if I ask you to rebase? Sure. I'll do the rebase. -- This is an automated

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #210: [FLINK-31010] Add Transformer and Estimator for GBTClassifier and GBTRegressor

2023-03-07 Thread via GitHub
Fanoid commented on code in PR #210: URL: https://github.com/apache/flink-ml/pull/210#discussion_r1128853646 ## flink-ml-lib/src/main/java/org/apache/flink/ml/common/gbt/operators/CalcLocalSplitsOperator.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #210: [FLINK-31010] Add Transformer and Estimator for GBTClassifier and GBTRegressor

2023-03-07 Thread via GitHub
Fanoid commented on code in PR #210: URL: https://github.com/apache/flink-ml/pull/210#discussion_r1128853646 ## flink-ml-lib/src/main/java/org/apache/flink/ml/common/gbt/operators/CalcLocalSplitsOperator.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] fsk119 closed pull request #21638: [FLINK-29948][rest] Add rootCause in the ErrorResponseBody

2023-03-07 Thread via GitHub
fsk119 closed pull request #21638: [FLINK-29948][rest] Add rootCause in the ErrorResponseBody URL: https://github.com/apache/flink/pull/21638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] weifonghsia commented on pull request #22085: PubSubSink should be using "withTopicName"

2023-03-07 Thread via GitHub
weifonghsia commented on PR #22085: URL: https://github.com/apache/flink/pull/22085#issuecomment-1459075862 @MartijnVisser - Would you be able to review this PR? Fairly small doc change -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Updated] (FLINK-31362) Upgrade to Calcite version to 1.33.0

2023-03-07 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aitozi updated FLINK-31362: --- Description: In Calcite 1.33.0, C-style escape strings have been supported. We could leverage it to

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #546: [FLINK-31326] Consolidate source scaling logic

2023-03-07 Thread via GitHub
gyfora commented on code in PR #546: URL: https://github.com/apache/flink-kubernetes-operator/pull/546#discussion_r1128753730 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/metrics/MetricAggregator.java: ## @@ -34,7 +33,11

[jira] [Updated] (FLINK-31362) Upgrade to Calcite version to 1.33.0

2023-03-07 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aitozi updated FLINK-31362: --- Component/s: Table SQL / API (was: Documentation) > Upgrade to Calcite version to

[jira] [Updated] (FLINK-31362) Upgrade to Calcite version to 1.33.0

2023-03-07 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aitozi updated FLINK-31362: --- Summary: Upgrade to Calcite version to 1.33.0 (was: Add document about how to use C-style escape strings)

[jira] [Updated] (FLINK-31362) Add document about how to use C-style escape strings

2023-03-07 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aitozi updated FLINK-31362: --- Description: In Calcite 1.33.0, C-style escape strings have been supported. We should outline its usage in

[jira] [Created] (FLINK-31362) Add document about how to use C-style escape strings

2023-03-07 Thread Aitozi (Jira)
Aitozi created FLINK-31362: -- Summary: Add document about how to use C-style escape strings Key: FLINK-31362 URL: https://issues.apache.org/jira/browse/FLINK-31362 Project: Flink Issue Type:

[jira] [Commented] (FLINK-31361) job created by sql-client can't authenticate to kafka, can't find org.apache.kafka.common.security.plain.PlainLoginModule

2023-03-07 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697645#comment-17697645 ] David Anderson commented on FLINK-31361: I'm using the sql-client to create the job. > job

[jira] [Created] (FLINK-31361) job created by sql-client can't authenticate to kafka, can't find org.apache.kafka.common.security.plain.PlainLoginModule

2023-03-07 Thread David Anderson (Jira)
David Anderson created FLINK-31361: -- Summary: job created by sql-client can't authenticate to kafka, can't find org.apache.kafka.common.security.plain.PlainLoginModule Key: FLINK-31361 URL:

[jira] [Assigned] (FLINK-30609) Add ephemeral storage to CRD

2023-03-07 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-30609: -- Assignee: Prabcs (was: Matyas Orhidi) > Add ephemeral storage to CRD >

[jira] [Commented] (FLINK-30609) Add ephemeral storage to CRD

2023-03-07 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697635#comment-17697635 ] Gyula Fora commented on FLINK-30609: [~morhidi] do you mind if [~pbharaj] takes over this ticket? >

  1   2   3   >