[GitHub] [flink-connector-jdbc] boring-cyborg[bot] commented on pull request #26: [Improve]Increase the valid of judging connection.

2023-03-09 Thread via GitHub
boring-cyborg[bot] commented on PR #26: URL: https://github.com/apache/flink-connector-jdbc/pull/26#issuecomment-1463414908 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[GitHub] [flink] X-czh commented on pull request #21673: [FLINK-30513] Cleanup HA storage path on cluster termination

2023-03-09 Thread via GitHub
X-czh commented on PR #21673: URL: https://github.com/apache/flink/pull/21673#issuecomment-1463414646 Sorry for that. I'll make sure that each individual commit conforms to the code format standard in the future. Thank you again for your hard work! -- This is an automated message from

[jira] [Commented] (FLINK-31377) BinaryArrayData getArray/getMap should Handle null correctly AssertionError: valueArraySize (-6) should >= 0

2023-03-09 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698792#comment-17698792 ] Sergey Nuyanzin commented on FLINK-31377: - yes i saw the unittest from the description, that's

[jira] [Commented] (FLINK-30996) Sync Kafka 1.17 commits from apache/flink repo to flink-connector-kafka

2023-03-09 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698790#comment-17698790 ] Mason Chen commented on FLINK-30996: Let's save you some time ;). I'll help do that–I have some

[jira] [Updated] (FLINK-31393) HsFileDataManager use an incorrect default timeout

2023-03-09 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31393: --- Priority: Critical (was: Blocker) > HsFileDataManager use an incorrect default timeout >

[jira] [Commented] (FLINK-31305) KafkaWriter doesn't wait for errors for in-flight records before completing flush

2023-03-09 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698789#comment-17698789 ] Mason Chen commented on FLINK-31305: Opened a PR! cc: [~stevenz3wu] [~martijnvisser] [~tzulitai]  >

[jira] [Updated] (FLINK-31305) KafkaWriter doesn't wait for errors for in-flight records before completing flush

2023-03-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31305: --- Labels: pull-request-available (was: ) > KafkaWriter doesn't wait for errors for in-flight

[GitHub] [flink-connector-kafka] mas-chen opened a new pull request, #6: [FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-09 Thread via GitHub
mas-chen opened a new pull request, #6: URL: https://github.com/apache/flink-connector-kafka/pull/6 …or so that checkpoints can correctly fail --> ## What is the purpose of the change Fixes a regression when the checkpoint completes although there is an error. The

[GitHub] [flink] snuyanzin commented on a diff in pull request #22146: [FLINK-31157][release] Add release note for version 1.17

2023-03-09 Thread via GitHub
snuyanzin commented on code in PR #22146: URL: https://github.com/apache/flink/pull/22146#discussion_r1132040358 ## docs/content.zh/release-notes/flink-1.17.md: ## @@ -0,0 +1,201 @@ +--- +title: "Release Notes - Flink 1.17" +--- + + +# Release notes - Flink 1.17 + +These

[GitHub] [flink] snuyanzin commented on a diff in pull request #22146: [FLINK-31157][release] Add release note for version 1.17

2023-03-09 Thread via GitHub
snuyanzin commented on code in PR #22146: URL: https://github.com/apache/flink/pull/22146#discussion_r1132039260 ## docs/content/release-notes/flink-1.17.md: ## @@ -0,0 +1,201 @@ +--- +title: "Release Notes - Flink 1.17" +--- + + +# Release notes - Flink 1.17 + +These release

[jira] [Commented] (FLINK-26603) [Umbrella] Decouple Hive with Flink planner

2023-03-09 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698786#comment-17698786 ] Martijn Visser commented on FLINK-26603: [~luoyuxia] Given that this wasn't possible to achieve

[GitHub] [flink-connector-kafka] MartijnVisser closed pull request #2: [FLINK-30880] Update flink version to 1.16.1

2023-03-09 Thread via GitHub
MartijnVisser closed pull request #2: [FLINK-30880] Update flink version to 1.16.1 URL: https://github.com/apache/flink-connector-kafka/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-connector-kafka] MartijnVisser commented on pull request #2: [FLINK-30880] Update flink version to 1.16.1

2023-03-09 Thread via GitHub
MartijnVisser commented on PR #2: URL: https://github.com/apache/flink-connector-kafka/pull/2#issuecomment-1463395015 Superseded by https://github.com/apache/flink-connector-kafka/pull/4/commits/0c1b2e5309c29425437dbad557bdcf2643a28039 -- This is an automated message from the Apache Git

[jira] [Closed] (FLINK-30052) Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2023-03-09 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-30052. -- Fix Version/s: kafka-3.0.0 Resolution: Fixed Fixed via

[GitHub] [flink-connector-hbase] MartijnVisser commented on pull request #5: [FLINK-30349] Sync missing HBase e2e tests to external repo

2023-03-09 Thread via GitHub
MartijnVisser commented on PR #5: URL: https://github.com/apache/flink-connector-hbase/pull/5#issuecomment-1463393988 @ferenc-csaky With @zentol his comments, do you think you could continue working on this? -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (FLINK-29825) Improve benchmark stability

2023-03-09 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved FLINK-29825. -- Resolution: Fixed > Improve benchmark stability > --- > >

[GitHub] [flink] reswqa commented on pull request #21673: [FLINK-30513] Cleanup HA storage path on cluster termination

2023-03-09 Thread via GitHub
reswqa commented on PR #21673: URL: https://github.com/apache/flink/pull/21673#issuecomment-1463394127 @XComp Very sorry for this. This PR has two commits, the first is a `hotfix` that only migrates test to junit5. I take it for granted that it will not have code format problems, so it is

[jira] [Commented] (FLINK-29825) Improve benchmark stability

2023-03-09 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698784#comment-17698784 ] Dong Lin commented on FLINK-29825: -- Merged to apache/flink-benchmarks master branch

[jira] [Closed] (FLINK-30996) Sync Kafka 1.17 commits from apache/flink repo to flink-connector-kafka

2023-03-09 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-30996. -- Fix Version/s: kafka-4.0.0 Resolution: Fixed Fixed via

[jira] [Commented] (FLINK-30996) Sync Kafka 1.17 commits from apache/flink repo to flink-connector-kafka

2023-03-09 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698782#comment-17698782 ] Martijn Visser commented on FLINK-30996: [~mason6345] Oh duh, I forgot to close this. Yes, let's

[GitHub] [flink-ml] jiangxin369 commented on pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-09 Thread via GitHub
jiangxin369 commented on PR #218: URL: https://github.com/apache/flink-ml/pull/218#issuecomment-1463393272 @lindong28 Thanks for the review, I've updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink-benchmarks] lindong28 merged pull request #66: [FLINK-29825] Replace median-based regression detect algorithm with max/min-based

2023-03-09 Thread via GitHub
lindong28 merged PR #66: URL: https://github.com/apache/flink-benchmarks/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #22146: [FLINK-31157][release] Add release note for version 1.17

2023-03-09 Thread via GitHub
flinkbot commented on PR #22146: URL: https://github.com/apache/flink/pull/22146#issuecomment-1463391299 ## CI report: * 5eb387243eb4e0d2cbdf73556444f38c9dd365fe UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-30640) Unstable test in CliClientITCase

2023-03-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698778#comment-17698778 ] Matthias Pohl commented on FLINK-30640: --- I'm increasing the priority of this issue to Blocker

[jira] [Commented] (FLINK-30996) Sync Kafka 1.17 commits from apache/flink repo to flink-connector-kafka

2023-03-09 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698779#comment-17698779 ] Mason Chen commented on FLINK-30996: [~martijnvisser] Looks like this is done. Should we work on

[jira] [Commented] (FLINK-31377) BinaryArrayData getArray/getMap should Handle null correctly AssertionError: valueArraySize (-6) should >= 0

2023-03-09 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698780#comment-17698780 ] jackylau commented on FLINK-31377: -- this https://issues.apache.org/jira/browse/FLINK-27438 just a pure

[jira] [Commented] (FLINK-31377) BinaryArrayData getArray/getMap should Handle null correctly AssertionError: valueArraySize (-6) should >= 0

2023-03-09 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698777#comment-17698777 ] jackylau commented on FLINK-31377: -- [~Sergey Nuyanzin] this unit test code can reproduce it 

[jira] [Updated] (FLINK-31157) Propose a pull request for website updates

2023-03-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31157: --- Labels: pull-request-available (was: ) > Propose a pull request for website updates >

[GitHub] [flink] PatrickRen opened a new pull request, #22146: [FLINK-31157][release] Add release note for version 1.17

2023-03-09 Thread via GitHub
PatrickRen opened a new pull request, #22146: URL: https://github.com/apache/flink/pull/22146 ## What is the purpose of the change This pull request adds release note for version 1.17. ## Brief change log - Add release note for 1.17 ## Verifying this

[GitHub] [flink-benchmarks] fredia commented on pull request #66: [FLINK-29825] Replace median-based regression detect algorithm with max/min-based

2023-03-09 Thread via GitHub
fredia commented on PR #66: URL: https://github.com/apache/flink-benchmarks/pull/66#issuecomment-1463387085 @lindong28 Thanks for the review and suggestions. > do you have numbers showing how this algorithm performs in production? For example, is there false positive and false

[jira] [Updated] (FLINK-30640) Unstable test in CliClientITCase

2023-03-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30640: -- Priority: Blocker (was: Critical) > Unstable test in CliClientITCase >

[jira] [Closed] (FLINK-31381) UnsupportedOperationException: Unsupported type when convertTypeToSpec: MAP

2023-03-09 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-31381. --- Resolution: Duplicate > UnsupportedOperationException: Unsupported type when

[GitHub] [flink-ml] zhipeng93 opened a new pull request, #223: [hotfix] Discard watermarks when feed a datastream into iteration body

2023-03-09 Thread via GitHub
zhipeng93 opened a new pull request, #223: URL: https://github.com/apache/flink-ml/pull/223 ## What is the purpose of the change This PR proposes to discard watermarks when feed a datastream into iteration body since watermarks are not correctly processed in iteration module. To

[jira] [Reopened] (FLINK-30640) Unstable test in CliClientITCase

2023-03-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reopened FLINK-30640: --- We have this issue happening again on 1.17:

[jira] [Commented] (FLINK-31377) BinaryArrayData getArray/getMap should Handle null correctly AssertionError: valueArraySize (-6) should >= 0

2023-03-09 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698773#comment-17698773 ] Sergey Nuyanzin commented on FLINK-31377: - is there a way to reproduce it with sql or any other

[jira] [Comment Edited] (FLINK-31210) Azure Pipelines report warning on "no space left on device" in Restore Docker images step

2023-03-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694932#comment-17694932 ] Matthias Pohl edited comment on FLINK-31210 at 3/10/23 7:24 AM: *

[jira] [Created] (FLINK-31395) AbstractPartitionDiscoverer.discoverPartitions calls remove on immutable collection

2023-03-09 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-31395: - Summary: AbstractPartitionDiscoverer.discoverPartitions calls remove on immutable collection Key: FLINK-31395 URL: https://issues.apache.org/jira/browse/FLINK-31395

[jira] [Updated] (FLINK-31381) UnsupportedOperationException: Unsupported type when convertTypeToSpec: MAP

2023-03-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31381: -- Fix Version/s: (was: 1.18.0) > UnsupportedOperationException: Unsupported type when

[GitHub] [flink] XComp commented on pull request #21673: [FLINK-30513] Cleanup HA storage path on cluster termination

2023-03-09 Thread via GitHub
XComp commented on PR #21673: URL: https://github.com/apache/flink/pull/21673#issuecomment-1463376405 As a reminder for next time: Please be careful with reverting changes without a commit. The revert broke `master` for some builds (see

[jira] [Resolved] (FLINK-31383) Add support for documenting additionProperties of the REST API payloads.

2023-03-09 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Morávek resolved FLINK-31383. --- Fix Version/s: 1.18.0 Resolution: Fixed > Add support for documenting

[jira] [Commented] (FLINK-31383) Add support for documenting additionProperties of the REST API payloads.

2023-03-09 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698767#comment-17698767 ] David Morávek commented on FLINK-31383: --- master: 84d000cf47b833625fbd5b5f72e48963b3156103 > Add

[GitHub] [flink] dmvk merged pull request #22139: [FLINK-31383] Add support for documenting additionProperties of the R…

2023-03-09 Thread via GitHub
dmvk merged PR #22139: URL: https://github.com/apache/flink/pull/22139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-31373) PerRoundWrapperOperator should carry epoch information in watermark

2023-03-09 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698766#comment-17698766 ] Zhipeng Zhang commented on FLINK-31373: --- As discussed with [~gaoyunhaii] offline, we agree that

[jira] (FLINK-31394) Fix spark jar name in the create release script for table store

2023-03-09 Thread zhuangchong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31394 ] zhuangchong deleted comment on FLINK-31394: - was (Author: zhuangchong): https://github.com/apache/flink-table-store/pull/591 > Fix spark jar name in the create release script for table

[GitHub] [flink-benchmarks] fredia commented on a diff in pull request #66: [FLINK-29825] Replace median-based regression detect algorithm with max/min-based

2023-03-09 Thread via GitHub
fredia commented on code in PR #66: URL: https://github.com/apache/flink-benchmarks/pull/66#discussion_r1132016069 ## regression_report_v2.py: ## @@ -0,0 +1,105 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*-

[jira] [Updated] (FLINK-31394) Fix spark jar name in the create release script for table store

2023-03-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31394: --- Labels: pull-request-available (was: ) > Fix spark jar name in the create release script

[jira] [Commented] (FLINK-31394) Fix spark jar name in the create release script for table store

2023-03-09 Thread zhuangchong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698762#comment-17698762 ] zhuangchong commented on FLINK-31394: - https://github.com/apache/flink-table-store/pull/591 > Fix

[GitHub] [flink-table-store] zhuangchong opened a new pull request, #591: [FLINK-31394] Fix spark jar name in the create release script for table store

2023-03-09 Thread via GitHub
zhuangchong opened a new pull request, #591: URL: https://github.com/apache/flink-table-store/pull/591 Fix spark jar name in the create release script for table store -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Created] (FLINK-31394) Fix spark jar name in the create release script for table store

2023-03-09 Thread zhuangchong (Jira)
zhuangchong created FLINK-31394: --- Summary: Fix spark jar name in the create release script for table store Key: FLINK-31394 URL: https://issues.apache.org/jira/browse/FLINK-31394 Project: Flink

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #584: [FLINK-31338] support infer parallelism for flink table store

2023-03-09 Thread via GitHub
JingsongLi commented on code in PR #584: URL: https://github.com/apache/flink-table-store/pull/584#discussion_r1132003909 ## flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/source/TableStoreSource.java: ## @@ -162,15

[jira] [Created] (FLINK-31393) HsFileDataManager use an incorrect default timeout

2023-03-09 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-31393: -- Summary: HsFileDataManager use an incorrect default timeout Key: FLINK-31393 URL: https://issues.apache.org/jira/browse/FLINK-31393 Project: Flink Issue Type:

[GitHub] [flink] xuzhiwen1255 commented on pull request #22010: [FLINK-31192][connectors/dataGen] Fix dataGen takes too long to initi…

2023-03-09 Thread via GitHub
xuzhiwen1255 commented on PR #22010: URL: https://github.com/apache/flink/pull/22010#issuecomment-1463322542 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread xzw0223 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698746#comment-17698746 ] xzw0223 commented on FLINK-31378: - [~Weijie Guo] No problem. > Documentation fails to build due to lack

[jira] [Assigned] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-31378: -- Assignee: Wencong Liu > Documentation fails to build due to lack of package >

[jira] [Commented] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698744#comment-17698744 ] Weijie Guo commented on FLINK-31378: [~xzw0223] Never mind. If you like, you can participate in the

[jira] [Commented] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread xzw0223 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698743#comment-17698743 ] xzw0223 commented on FLINK-31378: - [~Weijie Guo] Sorry, I made a mistake,the test introduces the clients

[GitHub] [flink] ZhendongBai closed pull request #17599: [FLINK-24688][yarn] update yarn.application-attempt-failures-validity-interval with a available link

2023-03-09 Thread via GitHub
ZhendongBai closed pull request #17599: [FLINK-24688][yarn] update yarn.application-attempt-failures-validity-interval with a available link URL: https://github.com/apache/flink/pull/17599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698741#comment-17698741 ] Weijie Guo commented on FLINK-31378: [~xzw0223] What version of Flink do you use? I think

[GitHub] [flink-benchmarks] lindong28 commented on a diff in pull request #66: [FLINK-29825] Replace median-based regression detect algorithm with max/min-based

2023-03-09 Thread via GitHub
lindong28 commented on code in PR #66: URL: https://github.com/apache/flink-benchmarks/pull/66#discussion_r1131966898 ## regression_report_v2.py: ## @@ -0,0 +1,108 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*-

[GitHub] [flink-benchmarks] lindong28 commented on a diff in pull request #66: [FLINK-29825] Replace median-based regression detect algorithm with max/min-based

2023-03-09 Thread via GitHub
lindong28 commented on code in PR #66: URL: https://github.com/apache/flink-benchmarks/pull/66#discussion_r1131955641 ## regression_report_v2.py: ## @@ -0,0 +1,105 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*-

[GitHub] [flink-benchmarks] lindong28 commented on a diff in pull request #66: [FLINK-29825] Replace median-based regression detect algorithm with max/min-based

2023-03-09 Thread via GitHub
lindong28 commented on code in PR #66: URL: https://github.com/apache/flink-benchmarks/pull/66#discussion_r1131954846 ## regression_report_v2.py: ## @@ -0,0 +1,108 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*-

[jira] [Closed] (FLINK-31389) Fix spark jar name in docs for table store

2023-03-09 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-31389. Assignee: zhuangchong Resolution: Fixed master: 0ffa6654b2d64fc65c430e453e656fa68ce74632 >

[jira] [Updated] (FLINK-31389) Fix spark jar name in docs for table store

2023-03-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31389: --- Labels: pull-request-available (was: ) > Fix spark jar name in docs for table store >

[GitHub] [flink-table-store] JingsongLi merged pull request #588: [FLINK-31389] Fix spark jar name in docs for table store

2023-03-09 Thread via GitHub
JingsongLi merged PR #588: URL: https://github.com/apache/flink-table-store/pull/588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-31391) Introduce lookup changelog producer

2023-03-09 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-31391: - Description: Currently, only full-compaction can produce changelog, some merge-engine must

[jira] [Updated] (FLINK-31392) Refactor classes code of full-compaction

2023-03-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31392: --- Labels: pull-request-available (was: ) > Refactor classes code of full-compaction >

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #589: [FLINK-31392] Refactor classes code of full-compaction

2023-03-09 Thread via GitHub
JingsongLi opened a new pull request, #589: URL: https://github.com/apache/flink-table-store/pull/589 Refactor classes code of full-compaction, this is to prepare some shared codes for lookup changelog producer. -- This is an automated message from the Apache Git Service. To

[jira] [Created] (FLINK-31392) Refactor classes code of full-compaction

2023-03-09 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-31392: Summary: Refactor classes code of full-compaction Key: FLINK-31392 URL: https://issues.apache.org/jira/browse/FLINK-31392 Project: Flink Issue Type:

[jira] [Created] (FLINK-31391) Introduce lookup changelog producer

2023-03-09 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-31391: Summary: Introduce lookup changelog producer Key: FLINK-31391 URL: https://issues.apache.org/jira/browse/FLINK-31391 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698727#comment-17698727 ] Hongshun Wang commented on FLINK-31378: --- [~Wencong Liu] , Of course, I’d like to participate in

[jira] [Commented] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698726#comment-17698726 ] Wencong Liu commented on FLINK-31378: - [~loserwang1024] | have a fix for this document. If you like,

[jira] [Commented] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698725#comment-17698725 ] Weijie Guo commented on FLINK-31378: [~loserwang1024] Yes, add document for beginners sounds good to

[jira] [Commented] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698722#comment-17698722 ] Hongshun Wang commented on FLINK-31378: --- [~Weijie Guo] ,if add this in corresponding

[GitHub] [flink] flinkbot commented on pull request #22145: [FLINK-31390][table-planner] use scala view to avoid unnecessary trav…

2023-03-09 Thread via GitHub
flinkbot commented on PR #22145: URL: https://github.com/apache/flink/pull/22145#issuecomment-1463217141 ## CI report: * 32b4fa1f4d563a407dc36d1d7e6b2e26bb889f61 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread xzw0223 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698721#comment-17698721 ] xzw0223 commented on FLINK-31378: - I think there is no problem with the documentation, and I can execute

[GitHub] [flink] liuyongvs commented on pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

2023-03-09 Thread via GitHub
liuyongvs commented on PR #22144: URL: https://github.com/apache/flink/pull/22144#issuecomment-1463213377 hi @snuyanzin @twalthr after talking in https://github.com/apache/flink/pull/21947 1) do not support array_size, which can be replaced by CARDINALITY 2) the select

[jira] [Comment Edited] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698720#comment-17698720 ] Weijie Guo edited comment on FLINK-31378 at 3/10/23 3:52 AM: - If you want to

[jira] [Updated] (FLINK-31390) Optimize the FlinkChangelogModeInferenceProgram by avoiding unnecessary traversals.

2023-03-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31390: --- Labels: pull-request-available (was: ) > Optimize the FlinkChangelogModeInferenceProgram

[GitHub] [flink] Aitozi opened a new pull request, #22145: [FLINK-31390][table-planner] use scala view to avoid unnecessary trav…

2023-03-09 Thread via GitHub
Aitozi opened a new pull request, #22145: URL: https://github.com/apache/flink/pull/22145 …ersal of RelNode tree ## What is the purpose of the change Use lazy view to avoid traverse the RelNode tree twice in some case. ## Verifying this change This change is a

[jira] [Comment Edited] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698720#comment-17698720 ] Weijie Guo edited comment on FLINK-31378 at 3/10/23 3:49 AM: - If you want to

[jira] [Comment Edited] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698720#comment-17698720 ] Weijie Guo edited comment on FLINK-31378 at 3/10/23 3:49 AM: - If you want to

[jira] [Commented] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698720#comment-17698720 ] Weijie Guo commented on FLINK-31378: If you want to run flink job in the IDE, the dependency of

[GitHub] [flink] flinkbot commented on pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

2023-03-09 Thread via GitHub
flinkbot commented on PR #22144: URL: https://github.com/apache/flink/pull/22144#issuecomment-1463210357 ## CI report: * 603c5f92ab0c367e0ccc0ea753fa810a8da06b8f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698718#comment-17698718 ] Hongshun Wang commented on FLINK-31378: --- Ok, [~xzw0223] , you just write any table api programs or

[jira] [Updated] (FLINK-31102) Add ARRAY_REMOVE supported in SQL & Table API

2023-03-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31102: --- Labels: pull-request-available (was: ) > Add ARRAY_REMOVE supported in SQL & Table API >

[GitHub] [flink] liuyongvs opened a new pull request, #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

2023-03-09 Thread via GitHub
liuyongvs opened a new pull request, #22144: URL: https://github.com/apache/flink/pull/22144 - What is the purpose of the change This is an implementation of ARRAY_REMOVE - Brief change log ARRAY_SIZE for Table API and SQL ``` Syntax: array_remove(array)

[jira] [Commented] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread xzw0223 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698716#comment-17698716 ] xzw0223 commented on FLINK-31378: - I think you can upload your pom and describe more details, it will be

[jira] [Commented] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698713#comment-17698713 ] Hongshun Wang commented on FLINK-31378: --- [~xzw0223] , I have already tried table api without

[jira] [Updated] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-09 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-31378: -- Attachment: image-2023-03-10-11-19-35-773.png > Documentation fails to build due to lack of

[GitHub] [flink] flinkbot commented on pull request #22143: [FLINK-31377][table] Fix array_contains ArrayData.ElementGetter shoul…

2023-03-09 Thread via GitHub
flinkbot commented on PR #22143: URL: https://github.com/apache/flink/pull/22143#issuecomment-1463191208 ## CI report: * 2a2f0a9392c16f8d52dea8afcad66e5b13015ffd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-31377) BinaryArrayData getArray/getMap should Handle null correctly AssertionError: valueArraySize (-6) should >= 0

2023-03-09 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698710#comment-17698710 ] jackylau commented on FLINK-31377: -- hi [~snuyanzin] , array_contains have another bug, could you also

[jira] [Comment Edited] (FLINK-31155) Build and stage Java and Python artifacts

2023-03-09 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698708#comment-17698708 ] Qingsheng Ren edited comment on FLINK-31155 at 3/10/23 3:09 AM: *

[jira] [Resolved] (FLINK-31156) Stage source and binary releases on dist.apache.org

2023-03-09 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-31156. --- Resolution: Done > Stage source and binary releases on dist.apache.org >

[jira] [Commented] (FLINK-31156) Stage source and binary releases on dist.apache.org

2023-03-09 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698709#comment-17698709 ] Qingsheng Ren commented on FLINK-31156: --- * Source and binary: 

[jira] [Assigned] (FLINK-31156) Stage source and binary releases on dist.apache.org

2023-03-09 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-31156: - Assignee: Qingsheng Ren > Stage source and binary releases on dist.apache.org >

[jira] [Updated] (FLINK-31377) BinaryArrayData getArray/getMap should Handle null correctly AssertionError: valueArraySize (-6) should >= 0

2023-03-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31377: --- Labels: pull-request-available (was: ) > BinaryArrayData getArray/getMap should Handle

[GitHub] [flink] liuyongvs opened a new pull request, #22143: [FLINK-31377][table] Fix array_contains ArrayData.ElementGetter shoul…

2023-03-09 Thread via GitHub
liuyongvs opened a new pull request, #22143: URL: https://github.com/apache/flink/pull/22143 ## What is the purpose of the change *Fix array_contains ArrayData.ElementGetter should use element type instead of needle type.* - needle and element type are identical. because " a

[jira] [Commented] (FLINK-31155) Build and stage Java and Python artifacts

2023-03-09 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698708#comment-17698708 ] Qingsheng Ren commented on FLINK-31155: --- * Source and binary: 

[jira] [Resolved] (FLINK-31155) Build and stage Java and Python artifacts

2023-03-09 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-31155. --- Resolution: Done > Build and stage Java and Python artifacts >

[jira] [Assigned] (FLINK-31155) Build and stage Java and Python artifacts

2023-03-09 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-31155: - Assignee: Qingsheng Ren > Build and stage Java and Python artifacts >

  1   2   3   >