Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74966906
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java
---
@@ -0,0 +1,755
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74967737
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java
---
@@ -0,0 +1,755
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74967974
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -0,0 +1,618
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74968309
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -0,0 +1,618
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74968719
--- Diff: flink-dist/pom.xml ---
@@ -113,8 +113,13 @@ under the License.
flink-metrics-jmx
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2315
A high-level comment to reviewers, I strove to follow the YARN
implementation closely, in anticipation of a future refactoring. The runner
and RM are prime examples where consistency was
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75138892
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/ZooKeeperMesosWorkerStore.java
---
@@ -0,0 +1,290
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75139611
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/util/ZooKeeperUtils.java ---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75139688
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/util/ZooKeeperUtils.java ---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75139941
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/ConnectionMonitor.scala
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75140675
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/LaunchCoordinator.scala
---
@@ -0,0 +1,349 @@
+/*
+ * Licensed to the
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75153237
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/LaunchCoordinator.scala
---
@@ -0,0 +1,349 @@
+/*
+ * Licensed to the
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75154390
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/runtime/clusterframework/ContaineredJobManager.scala
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75318417
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/cli/FlinkMesosSessionCli.java
---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75319776
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java
---
@@ -0,0 +1,755
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75323135
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/scheduler/SchedulerProxy.java
---
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75325271
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosConfigKeys.java
---
@@ -0,0 +1,44 @@
+/*
+ * Licensed to
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75325649
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java
---
@@ -0,0 +1,755
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75331224
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/ConnectionMonitor.scala
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75332580
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/TaskMonitor.scala
---
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75333536
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/Tasks.scala ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75335049
--- Diff:
flink-mesos/src/test/scala/org/apache/flink/mesos/scheduler/LaunchCoordinatorTest.scala
---
@@ -0,0 +1,439 @@
+/*
+ * Licensed to the
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2315
Thanks for the review @tillrohrmann @mxm and @StephanEwen.I'm
addressing the feedback with a follow-up commit to be completed ASAP.
---
If your project is set up for it, you can rep
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75395325
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/util/MesosArtifactServer.java
---
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75587011
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -0,0 +1,205
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2315
@mxm ready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r105825035
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -259,9 +262,11 @@ public String
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r105826378
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
---
@@ -162,11 +182,65 @@ public
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2425
@StephanEwen keep in mind that Flink's current SSL support in Flink doesn't
achieve _mutual authentication_ - there's no client certificate there.With
SSL enabled, an untru
Github user EronWright commented on the pull request:
https://github.com/apache/flink/commit/601a94802ceb81eb17aa6977eb7a35baef929c02#commitcomment-21361863
In
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java:
In
flink-core/src/main/java/org/apache
Github user EronWright commented on the pull request:
https://github.com/apache/flink/commit/e2f01b81e801a5ae6610d06fb9e2e3f54bbf34d9#commitcomment-21361837
In
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java:
In
flink-mesos
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3600
To recap, when the ZK server is configured to use SASL, the client is
challenged accordingly. The client checks for a login entry in the JAAS config
to obtain a kerberos credential, and issues a
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3600
The thread is becoming confused as to what the default behavior should be.
In brief I think the code should say:
```
public static final ConfigOption ZOOKEEPER_SASL_DISABLE
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3632
With respect to making this change for Mesos, look to `mesos-appmaster.sh`
and `mesos-taskmanager.sh` which produce the classpath. Those scripts do
import `config.sh` but don'
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3632
I believe the `yarn-session.sh` applies to the client-side only (which
launches the AM into the cluster). To adjust the classpath for the AM/TM, I
believe some adjust is needed here
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2703#discussion_r87673973
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -489,6 +489,29 @@
*/
public static final
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2703#discussion_r87674266
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -601,6 +601,54 @@ else if
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2703#discussion_r87674387
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -601,6 +601,54 @@ else if
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2703#discussion_r88522783
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -601,6 +601,54 @@ else if
GitHub user EronWright opened a pull request:
https://github.com/apache/flink/pull/2827
[FLINK-4921] Upgrade to Mesos 1.0.1
Updated the Mesos dependency, to unlock some new features (notably the
ability to fetch into sandbox sub-directories).
Shaded the protobuf
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2766
@tillrohrmann would you mind taking a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2703
@mxm LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2827
We do lose back-compat but gain an important feature, the ability to ship
files to sub-directories within the container. I've used this ability for
FLINK-5091.
---
If your project is s
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2766
@uce happy to further discuss this PR, why it helps with making the Netty
client/server code more reusable. Also provides some REST foundation code to
be used later for FLINK-4897.
---
If
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2766
@mxm some duplication remains, yes - the KvState server/client still use a
separate implementation (that was clearly cut/pasted).
---
If your project is set up for it, you can reply to this
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2827
@mxm Yes, DCOS 1.8 is the stable release and is based on Mesos 1.0.x.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user EronWright opened a pull request:
https://github.com/apache/flink/pull/2904
[FLINK-5091] Formalize the Mesos AppMaster environment for docker
compatibility
Fixes FLINK-5091 and FLINK-4826.
- introduced ContainerSpecification.
- reworked how the TM container
Github user EronWright closed the pull request at:
https://github.com/apache/flink/pull/2904
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user EronWright opened a pull request:
https://github.com/apache/flink/pull/2915
[FLINK-5091] Formalize the Mesos AppMaster environment for docker
compatibility
Fixes FLINK-5091.
- introduced ContainerSpecification.
- reworked how the TM container environment is
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2915#discussion_r90498149
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -1372,6 +1381,12 @@
/** The environment variable
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2766
@uce it would be nice to get this PR in, to counteract the growing
duplication of Netty code in the codebase.
---
If your project is set up for it, you can reply to this email and have your
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2974
@zentol what is the new behavior? Does the webui show the IOException?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2974
This doesn't really address the 'root cause' here, that the .out file is
missing (for Mesos deployments). While we could change `mesos-taskmanager.sh`
to redirect the output, I ho
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2974
@zentol I am fine with the 'error' behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user EronWright opened a pull request:
https://github.com/apache/flink/pull/3023
[FLINK-5030] Support hostname verification
- updated SSL documentation
- use canonical hostname for (netty/blob) client-to-server connections
- ensure that a valid address is
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3023
@mxm please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3017
@mxm please consider adding me as a reviewer for changes to the security
subsystem in the near term.I believe this PR introduces a regression where
it fails to install a Hadoop security
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2864
@mxm I think the root cause was incorrectly diagnosed here, and as a result
this PR did the wrong thing. It is incorrect to bypass the UGI login methods
when in 'SIMPLE' auth mode.
GitHub user EronWright opened a pull request:
https://github.com/apache/flink/pull/3025
[FLINK-5365] Mesos AppMaster/TaskManager should obey sigterm
Adjust bash script to propagate signals to the java process. This will
allow Marathon to properly stop the JobManager.
You can
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2257
@tillrohrmann @mxm I'll try to incorporate these changes into the
[MesosFlinkResourceManager](https://github.com/EronWright/flink/blob/feature-MESOS-1984-T1/flink-mesos/src/main/java/org/a
GitHub user EronWright opened a pull request:
https://github.com/apache/flink/pull/2315
[FLINK-1984] Integrate Flink with Apache Mesos (T1)
Part one ("T1") of Flink on Mesos.
Implemented Mesos AppMaster including:
- runners for AppMaster and T
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2315
@mxm I think this is ready for your review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3481
@zentol are you able to get this across the finish line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/3586#discussion_r112036914
--- Diff:
flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParametersTest.java
---
@@ -0,0 +1,95
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/3586#discussion_r112036109
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
---
@@ -166,7 +191,36 @@ public
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3586
Thanks for this contribution, I'm glad to see Flink take advantage of
Fenzo's considerable power.
Please open a new bug for this, since FLINK-1984 is closed, assign it to
you
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/3744#discussion_r112486557
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -487,6 +487,11 @@
public static final String
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/3744#discussion_r112487388
--- Diff: docs/setup/mesos.md ---
@@ -222,6 +222,8 @@ When running Flink with Marathon, the whole Flink
cluster including the job mana
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3692
@StephanEwen in this case, the
[MesosTaskManagerParameters](https://github.com/vijikarthi/flink/blob/aeb432dc7fe8bcdd5faa49b8ad5dfb5630ea0747/flink-mesos/src/main/java/org/apache/flink/mesos
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3388
Just a note: For Mesos, inevitably we'll add support for arbitrary URLs to
be downloaded by the container. The Mesos fetcher deals with HTTP URLs
primarily but actually supports HDFS URL
Github user EronWright closed the pull request at:
https://github.com/apache/flink/pull/3061
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3061
@tillrohrmann I'm closing this PR because it is quite old, in favor of a
successor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user EronWright closed the pull request at:
https://github.com/apache/flink/pull/2766
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/2766
@uce thanks for the feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user EronWright opened a pull request:
https://github.com/apache/flink/pull/3784
FLINK-6391
FLINK-6391
Improve change-scala-version.sh to correctly deal with references to
flink-gelly-examples.
You can merge this pull request into a Git repository by running
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3784
@greghogan that might be a good idea but I don't know much about it. I'm
merely focused on fixing the build break.
---
If your project is set up for it, you can reply to this emai
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3784
Fixed by 03afbca5d047988e7fd8aff5d8b83ddee19570c9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user EronWright closed the pull request at:
https://github.com/apache/flink/pull/3784
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3692
@tillrohrmann Mesos DNS is not the only DNS solution for Mesos, it is
merely the DCOS solution. By using an interpolated string, the name is fully
configurable.
---
If your project is set up
GitHub user EronWright opened a pull request:
https://github.com/apache/flink/pull/3867
[FLINK-6531] Deserialize checkpoint hooks with user classloader
- enhance MasterTriggerRestoreHook.Factory::create to take user-code
classloader
- deserialize WithMasterCheckpointHook
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3868
The title should refer to FLINK-6531
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user EronWright closed the pull request at:
https://github.com/apache/flink/pull/3867
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user EronWright opened a pull request:
https://github.com/apache/flink/pull/2766
[FLINK-4898] Refactor HTTP handlers and Netty server/client
- added support classes for REST and WebSocket-based protocols
- generalized NettyClient/NettyServer: makes no assumptions
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3356
Consider using an instance of `Configuration` in place of
`Map` to store configuration data. `Configuration` provides
handy methods for dealing with typed properties and for merging with other
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3356
Would you mind having a look at `GlobalConfiguration.dynamicProperties`,
which is set by the main method of various Flink processes based on CLI
arguments. The
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3356
@StephanEwen I agree that the YARN AM/TM has no need for dynamic properties
since the entire config file is generated per container. But there's a case
to be made that dynamic properties o
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/3335#discussion_r103593926
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStreamFactory.java
---
@@ -104,6 +104,7 @@ public
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3335
@WangTaoTheTonic can you elaborate on the multi-user scenario that you have
in mind? Keep in mind that a given Flink cluster doesn't provide any isolation
between jobs in that cluster.
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3335
When working on FLINK-3932, I came to the conclusion that the state backend
data should probably be written into the Hadoop user's home directory, since
most Hadoop setups protect the
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104838231
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +264,61 @@ public String
GitHub user EronWright opened a pull request:
https://github.com/apache/flink/pull/3057
[FLINK-5364] Rework JAAS configuration to support user-supplied entries
Fixes FLINK-5364, FLINK-5361, FLINK-5350, FLINK-5055
CC @tillrohrmann
You can merge this pull request into a Git
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3023
I've rebased this on release-1.2 and will open a new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user EronWright closed the pull request at:
https://github.com/apache/flink/pull/3023
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user EronWright opened a pull request:
https://github.com/apache/flink/pull/3061
[FLINK-5030] Support hostname verification
Fixes FLINK-5030
- updated SSL documentation
- use canonical hostname for (netty/blob) client-to-server connections
- ensure that a
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3057
@StephanEwen yes, this PR does the following:
1. isolate the configuration of kerberos credentials from how those
credentials are used
2. modularize the security code to reflect the
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3057
Thanks for the review, I'll address these comments ASAP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3061
@tillrohrmann @StephanEwen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/3057#discussion_r95265401
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityUtils.java
---
@@ -71,163 +64,93 @@
*/
public static
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/3057#discussion_r95283348
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/modules/JaasModule.java
---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3057
@StephanEwen updated based on feedback, thanks again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
1 - 100 of 209 matches
Mail list logo
