fhueske commented on issue #6521: [FLINK-5315][table] Adding support for
distinct operation for table API on DataStream
URL: https://github.com/apache/flink/pull/6521#issuecomment-411683146
Thanks for the PR @walterddr!
I did not have a detailed look, but we would also need to add
dawidwys opened a new pull request #6529: [FLINK-10106][e2e] Included test name
in temp directory of e2e test
URL: https://github.com/apache/flink/pull/6529
Simple improvement for e2e tests debuggability.
This is an
zentol commented on a change in pull request #6529: [FLINK-10106][e2e] Included
test name in temp directory of e2e test
URL: https://github.com/apache/flink/pull/6529#discussion_r208858966
##
File path: flink-end-to-end-tests/test-scripts/test-runner-common.sh
##
@@
tragicjun commented on issue #6508: [Flink-10079] [table] Automatically
register sink table from external catalogs
URL: https://github.com/apache/flink/pull/6508#issuecomment-411685212
@twalthr @suez1224 could you please review?
dawidwys commented on issue #6529: [FLINK-10106][e2e] Included test name in
temp directory of e2e test
URL: https://github.com/apache/flink/pull/6529#issuecomment-411696699
It does not work well when one of the parameters is url/uri. Fixing.
pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql]
Support processing time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r208830206
##
File path:
pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql]
Support processing time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r208831842
##
File path:
pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql]
Support processing time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r208833159
##
File path:
pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql]
Support processing time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r208833101
##
File path:
pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql]
Support processing time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r208835846
##
File path:
pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql]
Support processing time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r208835295
##
File path:
pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql]
Support processing time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r208829502
##
File path:
twalthr opened a new pull request #6528: [FLINK-10107] [e2e] Exclude
conflicting SQL JARs from test
URL: https://github.com/apache/flink/pull/6528
## What is the purpose of the change
This is a temporary solution for fixing the SQL Client end-to-end test for
releases.
##
dawidwys commented on a change in pull request #6529: [FLINK-10106][e2e]
Included test name in temp directory of e2e test
URL: https://github.com/apache/flink/pull/6529#discussion_r208860682
##
File path: flink-end-to-end-tests/test-scripts/test-runner-common.sh
##
@@
tillrohrmann opened a new pull request #6531: [FLINK-10110][tests] Harden Kafka
component shut down for E2E tests
URL: https://github.com/apache/flink/pull/6531
## What is the purpose of the change
Instead of only calling kafka-server-stop.sh and zookeeper-server-stop.sh
which can
rickhofstede commented on issue #6503: [FLINK-10072] [docs] Syntax and
consistency issues in "The Broadcast State Pattern"
URL: https://github.com/apache/flink/pull/6503#issuecomment-411703560
@yanghua
Since you've reviewed my commits, let me please ask you the following. It
fhueske opened a new pull request #6527: [hotfix] [docs] Fix
ProcessWindowFunction code snippets.
URL: https://github.com/apache/flink/pull/6527
## What is the purpose of the change
- Fix the code snippets for the `ProcessWindowFunction` in the documentation
## Brief change
dawidwys commented on a change in pull request #6529: [FLINK-10106][e2e]
Included test name in temp directory of e2e test
URL: https://github.com/apache/flink/pull/6529#discussion_r208860682
##
File path: flink-end-to-end-tests/test-scripts/test-runner-common.sh
##
@@
tillrohrmann opened a new pull request #6530: [FLINK-10110][tests] Harden Kafka
component shut down for E2E tests
URL: https://github.com/apache/flink/pull/6530
## What is the purpose of the change
Instead of only calling kafka-server-stop.sh and zookeeper-server-stop.sh
which can
tweise commented on issue #6482: [FLINK-10020] [kinesis] Support recoverable
exceptions in listShards.
URL: https://github.com/apache/flink/pull/6482#issuecomment-411622174
@tzulitai PTAL
This is an automated message from
yanghua commented on a change in pull request #6522: [FLINK-10101][mesos] Add
web ui url for mesos.
URL: https://github.com/apache/flink/pull/6522#discussion_r208818211
##
File path:
maqingxiang commented on a change in pull request #5304: [FLINK-8290]Modify
clientId to groupId in flink-connector-kafka-0.8
URL: https://github.com/apache/flink/pull/5304#discussion_r208790526
##
File path:
TisonKun commented on issue #6490: [FLINK-10056] [test] Add
JobMasterTest#testRequestNextInputSplit
URL: https://github.com/apache/flink/pull/6490#issuecomment-411627844
cc @aljoscha @zentol
This is an automated message
TisonKun commented on issue #6345: [FLINK-9869][runtime] Send PartitionInfo in
batch to Improve perfornance
URL: https://github.com/apache/flink/pull/6345#issuecomment-411627672
cc @GJL @twalthr
This is an automated message
yanghua edited a comment on issue #6503: [FLINK-10072] [docs] Syntax and
consistency issues in "The Broadcast State Pattern"
URL: https://github.com/apache/flink/pull/6503#issuecomment-411724977
hi @rickhofstede , Travis build error is not caused by your code. So, take
it easy. The next
azagrebin commented on a change in pull request #5996: [FLINK-9343] [Example]
Add Async Example with External Rest API call
URL: https://github.com/apache/flink/pull/5996#discussion_r208905291
##
File path:
azagrebin commented on a change in pull request #5996: [FLINK-9343] [Example]
Add Async Example with External Rest API call
URL: https://github.com/apache/flink/pull/5996#discussion_r208906401
##
File path:
azagrebin commented on a change in pull request #5996: [FLINK-9343] [Example]
Add Async Example with External Rest API call
URL: https://github.com/apache/flink/pull/5996#discussion_r208905065
##
File path:
azagrebin commented on a change in pull request #5996: [FLINK-9343] [Example]
Add Async Example with External Rest API call
URL: https://github.com/apache/flink/pull/5996#discussion_r208904205
##
File path:
yanghua commented on issue #6503: [FLINK-10072] [docs] Syntax and consistency
issues in "The Broadcast State Pattern"
URL: https://github.com/apache/flink/pull/6503#issuecomment-411724977
hi @rickhofstede , Travis build error is not caused by your code. So, take
it easy. The next time
dawidwys commented on issue #6511: [FLINK-10085][tests] Update
AbstractOperatorRestoreTestBase for 1.5
URL: https://github.com/apache/flink/pull/6511#issuecomment-411749740
Do we have any reasonable way to verify those kinds of PRs? Or shall we just
look for typos while reviewing it?
tillrohrmann closed pull request #5920: [FLINK-9231] [web] Enable SO_REUSEADDR
on listen sockets for WebFront…
URL: https://github.com/apache/flink/pull/5920
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
tillrohrmann commented on issue #5920: [FLINK-9231] [web] Enable SO_REUSEADDR
on listen sockets for WebFront…
URL: https://github.com/apache/flink/pull/5920#issuecomment-411731732
I will close this PR since it seems to be inactive. If you still want to
work on it @trionesadam please
twalthr commented on issue #6379: [FLINK-9637] Add public user documentation
for state TTL feature
URL: https://github.com/apache/flink/pull/6379#issuecomment-411756912
Thank you @azagrebin. I will go through the text a last time and merge
this...
asfgit closed pull request #6528: [FLINK-10107] [e2e] Exclude conflicting SQL
JARs from test
URL: https://github.com/apache/flink/pull/6528
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this
medcv commented on issue #5996: [FLINK-9343] [Example] Add Async Example with
External Rest API call
URL: https://github.com/apache/flink/pull/5996#issuecomment-411780022
@azagrebin Thanks for the review. I will go through them and update the PR
accordingly
twalthr commented on a change in pull request #6504: [FLINK-10068][docs] Add
documentation for RocksDB-based timers and st…
URL: https://github.com/apache/flink/pull/6504#discussion_r208952554
##
File path: docs/ops/state/large_state_tuning.md
##
@@ -142,6 +142,17 @@ by
twalthr commented on a change in pull request #6504: [FLINK-10068][docs] Add
documentation for RocksDB-based timers and st…
URL: https://github.com/apache/flink/pull/6504#discussion_r208951393
##
File path: docs/ops/state/large_state_tuning.md
##
@@ -142,6 +142,17 @@ by
twalthr commented on a change in pull request #6504: [FLINK-10068][docs] Add
documentation for RocksDB-based timers and st…
URL: https://github.com/apache/flink/pull/6504#discussion_r208950482
##
File path: docs/dev/stream/operators/process_function.md
##
@@ -333,3
azagrebin commented on a change in pull request #5304: [FLINK-8290]Modify
clientId to groupId in flink-connector-kafka-0.8
URL: https://github.com/apache/flink/pull/5304#discussion_r208965558
##
File path:
yanghua commented on issue #6266: [FLINK-9682] Add setDescription to execution
environment and provide description field for the rest api
URL: https://github.com/apache/flink/pull/6266#issuecomment-411806613
cc @tillrohrmann
NicoK commented on a change in pull request #6294: [FLINK-9013][docs] Document
yarn.containers.vcores only being effective whe…
URL: https://github.com/apache/flink/pull/6294#discussion_r208962025
##
File path:
dawidwys commented on a change in pull request #6294: [FLINK-9013][docs]
Document yarn.containers.vcores only being effective whe…
URL: https://github.com/apache/flink/pull/6294#discussion_r208969123
##
File path:
GJL commented on a change in pull request #6294: [FLINK-9013][docs] Document
yarn.containers.vcores only being effective whe…
URL: https://github.com/apache/flink/pull/6294#discussion_r208976465
##
File path:
asfgit closed pull request #6379: [FLINK-9637] Add public user documentation
for state TTL feature
URL: https://github.com/apache/flink/pull/6379
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
dawidwys commented on issue #6205: [FLINK-9642]Reduce the count to deal with
state during a CEP process
URL: https://github.com/apache/flink/pull/6205#issuecomment-411788642
Hi @Aitozi
I found the dependencies between accessor and shared buffer a bit too much
both sided. Please have a
GJL commented on a change in pull request #6294: [FLINK-9013][docs] Document
yarn.containers.vcores only being effective whe…
URL: https://github.com/apache/flink/pull/6294#discussion_r208986466
##
File path:
twalthr commented on a change in pull request #6532: [FLINK-10109] Add
documentation for StreamingFileSink
URL: https://github.com/apache/flink/pull/6532#discussion_r208986029
##
File path: docs/dev/connectors/streamfile_sink.md
##
@@ -0,0 +1,95 @@
+---
+title: "Streaming
twalthr commented on a change in pull request #6532: [FLINK-10109] Add
documentation for StreamingFileSink
URL: https://github.com/apache/flink/pull/6532#discussion_r208985527
##
File path: docs/dev/connectors/streamfile_sink.md
##
@@ -0,0 +1,95 @@
+---
+title: "Streaming
twalthr commented on a change in pull request #6504: [FLINK-10068][docs] Add
documentation for RocksDB-based timers and st…
URL: https://github.com/apache/flink/pull/6504#discussion_r208952984
##
File path: docs/ops/state/large_state_tuning.md
##
@@ -142,6 +142,17 @@ by
twalthr commented on a change in pull request #6504: [FLINK-10068][docs] Add
documentation for RocksDB-based timers and st…
URL: https://github.com/apache/flink/pull/6504#discussion_r208950851
##
File path: docs/dev/stream/operators/process_function.md
##
@@ -333,3
twalthr commented on a change in pull request #6504: [FLINK-10068][docs] Add
documentation for RocksDB-based timers and st…
URL: https://github.com/apache/flink/pull/6504#discussion_r208950079
##
File path: docs/dev/stream/operators/process_function.md
##
@@ -277,19
twalthr commented on a change in pull request #6504: [FLINK-10068][docs] Add
documentation for RocksDB-based timers and st…
URL: https://github.com/apache/flink/pull/6504#discussion_r208949265
##
File path: docs/dev/stream/operators/process_function.md
##
@@ -277,19
aljoscha commented on a change in pull request #5304: [FLINK-8290]Modify
clientId to groupId in flink-connector-kafka-0.8
URL: https://github.com/apache/flink/pull/5304#discussion_r208955188
##
File path:
GJL opened a new pull request #6533: [FLINK-9795][mesos, docs] Update Mesos
documentation for FLIP-6
URL: https://github.com/apache/flink/pull/6533
## What is the purpose of the change
*Update Mesos documentation to reflect changes that were introduced with
FLIP-6.*
cc:
yanghua commented on issue #6367: [FLINK-9850] Add a string to the print method
to identify output for DataStream
URL: https://github.com/apache/flink/pull/6367#issuecomment-411806291
cc @tillrohrmann
This is an automated
tillrohrmann commented on issue #6499: [FLINK-10099] [test] Rework
YarnResourceManagerTest
URL: https://github.com/apache/flink/pull/6499#issuecomment-411775562
Thanks for addressing our comments @TisonKun. Merging this PR.
xueyumusic commented on a change in pull request #6282:
[FLINK-6847][FLINK-6813] [table] TimestampDiff table api and sql support
URL: https://github.com/apache/flink/pull/6282#discussion_r208985576
##
File path:
yanghua commented on issue #6539: [FLINK-10123] Use ExecutorThreadFactory
instead of DefaultThreadFactory in RestServer/Client
URL: https://github.com/apache/flink/pull/6539#issuecomment-412244963
Till, scala checkstyle error :
```
error
hequn8128 commented on a change in pull request #6521: [FLINK-5315][table]
Adding support for distinct operation for table API on DataStream
URL: https://github.com/apache/flink/pull/6521#discussion_r209413346
##
File path:
Aitozi commented on a change in pull request #6205: [FLINK-9642]Reduce the
count to deal with state during a CEP process
URL: https://github.com/apache/flink/pull/6205#discussion_r209419821
##
File path:
Aitozi commented on a change in pull request #6205: [FLINK-9642]Reduce the
count to deal with state during a CEP process
URL: https://github.com/apache/flink/pull/6205#discussion_r209419821
##
File path:
packet23 opened a new pull request #6540: [FLINK-9891] Added hook to shutdown
cluster if a session was created in per-job mode.
URL: https://github.com/apache/flink/pull/6540
## What is the purpose of the change
Change minimizes probability of a per-job yarn session cluster
fhueske commented on issue #6003: [FLINK-9289][Dataset] Parallelism of
generated operators should have max parallelism of input
URL: https://github.com/apache/flink/pull/6003#issuecomment-410872065
Thanks for the reminder @xccui!
I'll try to have a look this week.
StephanEwen opened a new pull request #6507: [FLINK-10069] [docs] Update SSL
docs to reflect internal vs. external communication
URL: https://github.com/apache/flink/pull/6507
This pull requests adds the documentation for the updated SSL setup. It
explains internal and external
suez1224 commented on issue #6484: [FLINK-9134] [table] upgrade Calcite
dependency to 1.17
URL: https://github.com/apache/flink/pull/6484#issuecomment-410878018
merged
This is an automated message from the Apache Git
klion26 commented on issue #6430: [FLINK-8058][Queryable State]Queryable state
should check types
URL: https://github.com/apache/flink/pull/6430#issuecomment-410893513
hi, @kl0u @twalthr Could you please help reviewing this?
walterddr commented on a change in pull request #6301: [FLINK-9794] [jdbc]
JDBCOutputFormat does not consider idle connection and multithreads
synchronization
URL: https://github.com/apache/flink/pull/6301#discussion_r207659233
##
File path:
walterddr commented on a change in pull request #6448: [FLINK-9990] [table] Add
regex_extract supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6448#discussion_r207694473
##
File path: docs/dev/table/sql.md
##
@@ -1842,6 +1842,16 @@ RPAD(text string,
walterddr commented on a change in pull request #6448: [FLINK-9990] [table] Add
regex_extract supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6448#discussion_r207694127
##
File path: docs/dev/table/sql.md
##
@@ -1842,6 +1842,16 @@ RPAD(text string,
zentol commented on issue #6476: [FLINK-10025] Add getCheckpointConfig API for
PythonStreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/6476#issuecomment-410428229
This still needs a _python_ test to verify that all properties can be
properly set from the python side.
zentol edited a comment on issue #6476: [FLINK-10025] Add getCheckpointConfig
API for PythonStreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/6476#issuecomment-410428229
This still needs a _python_ test to verify that all properties can be
properly set and retrieved
yanghua commented on issue #6488: [FLINK-10055] incorrect in-progress file
suffix in BucketingSink's java doc
URL: https://github.com/apache/flink/pull/6488#issuecomment-410428669
+1
This is an automated message from the
yanghua commented on issue #6486: [FLINK-10051][tests][sql] Add missing
depenendeices for sql client E2E test
URL: https://github.com/apache/flink/pull/6486#issuecomment-410428717
+1
This is an automated message from the
suez1224 commented on issue #6484: [FLINK-9134] [table] upgrade Calcite
dependency to 1.17
URL: https://github.com/apache/flink/pull/6484#issuecomment-410430674
@twalthr addressed the comments. Let me know what you think.
yanghua commented on a change in pull request #6448: [FLINK-9990] [table] Add
regex_extract supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6448#discussion_r207699091
##
File path:
yanghua commented on a change in pull request #6448: [FLINK-9990] [table] Add
regex_extract supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6448#discussion_r207699117
##
File path:
yanghua commented on a change in pull request #6448: [FLINK-9990] [table] Add
regex_extract supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6448#discussion_r207699091
##
File path:
bowenli86 opened a new pull request #6488: [FLINK-10055] incorrect in-progress
file suffix in BucketingSink's java doc
URL: https://github.com/apache/flink/pull/6488
## What is the purpose of the change
## Brief change log
Similar to the java doc of `setPendingSuffix()`
walterddr commented on a change in pull request #6448: [FLINK-9990] [table] Add
regex_extract supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6448#discussion_r207700798
##
File path: docs/dev/table/sql.md
##
@@ -1842,6 +1842,16 @@ RPAD(text string,
suez1224 commented on a change in pull request #6484: [FLINK-9134] [table]
upgrade Calcite dependency to 1.17
URL: https://github.com/apache/flink/pull/6484#discussion_r207701607
##
File path:
suez1224 commented on a change in pull request #6484: [FLINK-9134] [table]
upgrade Calcite dependency to 1.17
URL: https://github.com/apache/flink/pull/6484#discussion_r207701618
##
File path:
suez1224 commented on a change in pull request #6484: [FLINK-9134] [table]
upgrade Calcite dependency to 1.17
URL: https://github.com/apache/flink/pull/6484#discussion_r207701611
##
File path:
walterddr commented on a change in pull request #6448: [FLINK-9990] [table] Add
regex_extract supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6448#discussion_r207699504
##
File path: docs/dev/table/sql.md
##
@@ -1842,6 +1842,16 @@ RPAD(text string,
yanghua commented on a change in pull request #6448: [FLINK-9990] [table] Add
regex_extract supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6448#discussion_r207699629
##
File path: docs/dev/table/sql.md
##
@@ -1842,6 +1842,16 @@ RPAD(text string,
yanghua commented on issue #6476: [FLINK-10025] Add getCheckpointConfig API for
PythonStreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/6476#issuecomment-410428408
OK, Can you review PR #6475 so that I can write a test with Java?
hequn8128 commented on issue #6484: [FLINK-9134] [table] upgrade Calcite
dependency to 1.17
URL: https://github.com/apache/flink/pull/6484#issuecomment-410431477
@suez1224 Hi, thanks for your PR. Only one question from my side: do we have
any good ideas or plans about how to remove
yanghua edited a comment on issue #6487: [FLINK-10053] Add getParallelism API
for PythonStreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/6487#issuecomment-410422509
@zentol the test will be added after the PR : #6475 been merged
yanghua commented on a change in pull request #6448: [FLINK-9990] [table] Add
regex_extract supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6448#discussion_r207699091
##
File path:
yanghua opened a new pull request #6487: [FLINK-10053] Add getParallelism API
for PythonStreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/6487
## What is the purpose of the change
*This pull request adds getParallelism API for
PythonStreamExecutionEnvironment*
yanghua commented on issue #6487: [FLINK-10053] Add getParallelism API for
PythonStreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/6487#issuecomment-410422509
@zentol the test will be added after the PR : #6475
Xpray commented on issue #6465: [FLINK-10008] [table] Improve the LOG function
in Table to support bases less than 1
URL: https://github.com/apache/flink/pull/6465#issuecomment-410423217
@xccui, I've updated the PR.
Best.
yanghua commented on a change in pull request #6448: [FLINK-9990] [table] Add
regex_extract supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6448#discussion_r207701539
##
File path: docs/dev/table/sql.md
##
@@ -1842,6 +1842,16 @@ RPAD(text string,
suez1224 commented on a change in pull request #6484: [FLINK-9134] [table]
upgrade Calcite dependency to 1.17
URL: https://github.com/apache/flink/pull/6484#discussion_r207702177
##
File path:
yanghua commented on a change in pull request #6448: [FLINK-9990] [table] Add
regex_extract supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6448#discussion_r207698953
##
File path: docs/dev/table/sql.md
##
@@ -1842,6 +1842,16 @@ RPAD(text string,
yanghua commented on a change in pull request #6448: [FLINK-9990] [table] Add
regex_extract supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6448#discussion_r207699091
##
File path:
Xpray commented on a change in pull request #6465: [FLINK-10008] [table]
Improve the LOG function in Table to support bases less than 1
URL: https://github.com/apache/flink/pull/6465#discussion_r207699770
##
File path:
tzulitai commented on issue #6078: [FLINK-9438] Add documentation for
AvroDeserializationSchema
URL: https://github.com/apache/flink/pull/6078#issuecomment-411288894
+1, LGTM
This is an automated message from the Apache Git
asfgit closed pull request #6506: [FLINK-10073] [sql-client] Allow setting a
restart strategy in SQL Client
URL: https://github.com/apache/flink/pull/6506
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
GJL commented on a change in pull request #6496: [FLINK-10063][tests] Use runit
to supervise mesos processes.
URL: https://github.com/apache/flink/pull/6496#discussion_r208471471
##
File path: flink-jepsen/src/jepsen/flink/mesos.clj
##
@@ -24,11 +24,35 @@
801 - 900 of 295798 matches
Mail list logo
