Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4342#discussion_r127988555
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/CoGroupRawOperator.java
---
@@ -95,9 +96,8 @@ public CoGroupRawOperator(DataSet input1
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4255
you're right - wasn't looking thoroughly enough (and only recently learned
about `ExpectedException`).
Additionally, I found out that this ignored exception was actually required
to be thrown
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4158#discussion_r126398901
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobClient.java ---
@@ -551,33 +425,17 @@ else if (response == RETURN_ERROR
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4110
@zentol then +1 after addressing @greghogan's comments (adding a warning +
using a constant for the `80`)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126413188
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -278,6 +518,26 @@ public void testUnrequestedRequired
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126413856
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -174,9 +210,38 @@ public void testUnrequestedByte
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126401183
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -34,8 +36,7 @@
@Test(expected
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/3742
I'll rebase it on top of FLIP-19 once ready - or should I open a new PR for
this then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4293
that's actually hard to know in advance - I had only 3 builds that went
under the limit by chance so I was able to use the cache henceforth in those
three which constantly were below the 49min
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4246#discussion_r126437776
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/async/AsyncStoppableTaskWithCallback.java
---
@@ -21,6 +21,7 @@
import
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4110#discussion_r126443486
--- Diff:
flink-metrics/flink-metrics-statsd/src/test/java/org/apache/flink/metrics/statsd/StatsDReporterTest.java
---
@@ -60,6 +60,20 @@
public class
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4110#discussion_r126442516
--- Diff:
flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java
---
@@ -184,7 +188,10 @@ public
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4358#discussion_r128296027
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/PermanentBlobCache.java
---
@@ -0,0 +1,391 @@
+/*
+ * Licensed to the Apache
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4309
That would make sense and I was going that way at first. It is spread over
some of the project files though and there was something about eclipse having
problems with it (although the last time, we
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4359#discussion_r128165494
--- Diff: flink-core/src/main/java/org/apache/flink/util/AbstractID.java ---
@@ -46,7 +46,7 @@
/** The lower part of the actual ID */
protected
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4378
[FLINK-7233][tests] fix instable TaskManagerHeapSizeCalculationJavaBashTest
This fixes `getRandomConfig()` being prone to integer overflows and creating
invalid configuration values.
- [X
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4330
+1
I wouldn't say, `return`is uncommon inside a bash function!
`exit` in these methods would immediately exit the bash script while
`return` does what is expected here which still allows
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4255
...that's how wrong the original implementation was - let me add this to
the description of the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user NicoK closed the pull request at:
https://github.com/apache/flink/pull/3742
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4381
[FLINK-7196][blob] add a TTL to all transient BLOBs
## What is the purpose of the change
Transient BLOB files are currently only deleted manually and may thus
linger around if not cleaned up
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4385
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4390
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4374
Although this totally makes sense and would be nice to change, we cannot
merge it until Java 7 has been dropped (as you see from the TravisCI runs).
---
If your project is set up for it, you can
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4346#discussion_r129295166
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/parameter/Simplify.java
---
@@ -109,21 +109,23 @@ public Ordering
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4346#discussion_r129296867
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/linkanalysis/HITS.java
---
@@ -168,7 +168,6 @@ protected void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4346#discussion_r129295984
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/input/InputBase.java
---
@@ -32,6 +35,9 @@
extends
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4409
[FLINK-7283][python] fix PythonPlanBinderTest issues with python paths
## What is the purpose of the change
Fix Python 2/3 path issues in `PythonPlanBinderTest`.
## Brief change log
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4412
[FLINK-6046][jobmanager] add support for oversized messages during
deployment
## What is the purpose of the change
This pull request makes big parts of the task deployment descriptor (TDD
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4414
[FLINK-7287][tests] fix test instabilities in KafkaConsumerTestBase
## What is the purpose of the change
fix test instabilities in KafkaConsumerTestBase
## Brief change log
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4414
Yes, both your observations are correct. The pattern in most tests inside
`KafkaConsumerTestBase` is to
1) start a job,
2) do some processing, e.g. until some offset or another finish
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4416
[FLINK-7279][minicluster] fix a deadlock between TM and cluster shutdown
## What is the purpose of the change
The `MiniCluster` can deadlock if the fatal error handler is called while
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4401
[hotfix][tests] minor test improvements in TaskManagerConfigurationTest
* use a proper JUnit temporary folder that ensures uniqueness
* do not catch an exception just to fail with its message
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4403
[FLINK-7262][blob] remove the unused FallbackLibraryCacheManager
## What is the purpose of the change
Remove `FallbackLibraryCacheManager` which was basically only used in unit
tests
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4402
[FLINK-7261][blob] extend BlobStore#get/put with boolean return values
## What is the purpose of the change
We'd like the `PermanentBlobCache` to be able to distinguish between HA and
non-HA
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4346#discussion_r129230954
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/input/InputBase.java
---
@@ -32,6 +35,9 @@
extends
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4346#discussion_r129231293
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/parameter/Simplify.java
---
@@ -109,21 +109,23 @@ public Ordering
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4346#discussion_r129231234
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/parameter/Simplify.java
---
@@ -109,21 +109,23 @@ public Ordering
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4346#discussion_r129231269
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/parameter/Simplify.java
---
@@ -109,21 +109,23 @@ public Ordering
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4346#discussion_r129231080
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/linkanalysis/HITS.java
---
@@ -168,7 +168,6 @@ protected void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4346#discussion_r129231099
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/linkanalysis/HITS.java
---
@@ -192,7 +191,6 @@ protected void
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4236
[FLINK-7055][blob] refactor BlobService#getURL() methods to return a File
object
As a relic from its use by the `URLClassLoader`, `BlobService#getURL()`
methods always returned URL objects although
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4238
[FLINK-7057][blob] move BLOB ref-counting from LibraryCacheManager to
BlobCache
Currently, the `LibraryCacheManager` is doing some ref-counting for JAR
files managed by it. Instead, we want
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4235
[FLINK-7054] [blob] remove LibraryCacheManager#getFile()
`LibraryCacheManager#getFile()` was only used in tests where it is
avoidable but if used anywhere else, it may have caused cleanup issues
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4237
[FLINK-7056][blob] add API to allow job-related BLOBs to be stored
To ease cleanup, we will make job-related BLOBs be reflected in the blob
storage so that they may be removed along with the job
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4234
[FLINK-7053] improve code quality in some tests
* `BlobClientTest` and `BlobClientSslTest` share a lot of common code
* the received buffers there are currently not verified for being equal
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4176
superseeded by #4237
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user NicoK closed the pull request at:
https://github.com/apache/flink/pull/4176
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user NicoK closed the pull request at:
https://github.com/apache/flink/pull/4174
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4174
let's split this up into two parts...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4238#discussion_r125430786
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServerConnection.java
---
@@ -477,97 +406,96 @@ else if (contentAddressable
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4238#discussion_r125404358
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobCache.java ---
@@ -107,146 +133,268 @@ public BlobCache
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4238#discussion_r125430028
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
@@ -162,105 +164,116 @@ static File initStorageDirectory(String
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4238#discussion_r125406639
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/execution/librarycache/BlobServerLibraryManager.java
---
@@ -0,0 +1,55
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4255
[FLINK-7102] improve ClassLoaderITCase
* ClassLoaderITCase unnecessarily runs multiple tests in a single test case
* ClassLoaderITCase#testDisposeSavepointWithCustomKvState() does not cancel
its
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4146#discussion_r125243142
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServerConnection.java
---
@@ -540,7 +526,7 @@ else if (type == NAME_ADDRESSABLE
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4146#discussion_r125244675
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobServerDeleteTest.java
---
@@ -92,6 +99,69 @@ public void testDeleteSingle
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4245
[FLINK-7012] remove user-JAR upload when disposing a savepoint the old way
Inside `CliFrontend#disposeSavepoint()`, user JAR files are being uploaded
to the `BlobServer` but they are actually
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4238
I wonder how that slipped throughanyway, should be fixed now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4238#discussion_r125827511
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServerConnection.java
---
@@ -477,97 +406,96 @@ else if (contentAddressable
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911613
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125912201
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911760
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911804
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911011
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -78,18 +79,12 @@ public void testMultipleNoValMixed
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911852
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911839
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911637
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125910930
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -78,18 +79,12 @@ public void testMultipleNoValMixed
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125914354
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125910462
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java ---
@@ -548,6 +565,7 @@ protected Object clone() throws
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911549
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911372
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125910799
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -34,8 +36,7 @@
@Test(expected
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125911520
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125912602
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void testFromGenericOptionsParser
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4110
just for clarification, `a.b..c.d` would then be stored
in `a/b//c/d` so that each component/file/directory is not
larger than 80?
---
If your project is set up for it, you can reply to this email
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4146#discussion_r124734798
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobServerPutTest.java
---
@@ -59,6 +60,110 @@
private final Random rnd
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4146#discussion_r124586418
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobServerPutTest.java
---
@@ -59,6 +60,110 @@
private final Random rnd
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4146#discussion_r124587248
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServerConnection.java
---
@@ -509,21 +509,7 @@ private void delete(InputStream
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4146#discussion_r124585333
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
@@ -227,7 +227,7 @@ static File getStorageLocation(File storageDir
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4146#discussion_r124584383
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobClient.java ---
@@ -593,9 +594,7 @@ private void sendPutHeader(OutputStream
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/3512
After investigating a bit further, I noticed that this problem is actually
a bit bigger:
Even in `FileSystemBlobStore`, there is no guarantee that a directory will
not be deleted concurrently
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4416
ok, I think, I understood the intention of `TaskExecutor#onFatalErrorAsync`
wrong - it is meant for outside `TaskExecutor` thread calls to run the error
handler inside the `TaskExecutor` thread
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4481
actually, I need to fix the test failures in
`ContaineredTaskManagerParametersTest` and some failure in the
`flink-yarn-tests` first...
---
If your project is set up for it, you can reply
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4447
FYI: the `final` keyword on methods in `final` classes is something that is
actually forbidden by the checkstyle, hence the change
Regarding the try-catch in tests (actually part of #4446
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4451
[hotfix][tests] increase timeout in ExecutionGraphRestartTest
## What is the purpose of the change
On rare occasions, TravisCI hit the default timeout waiting for job status
changes
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4464
[FLINK-7354][tests] ignore "initialSeedUniquifierGenerator" thread in
thread list
## What is the purpose of the change
Netty may spawn a thread in its `ThreadLocalRandom` becau
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4481
ok, one test fixed, the other is not so simple but maybe @tillrohrmann can
help with it:
Inside `ContaineredTaskManagerParameters#create()`, we calculate the amount
of off-heap space that we
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4506
[FLINK-7400][cluster] fix off-heap limits set to conservatively in cluster
environments
## What is the purpose of the change
Inside `ContaineredTaskManagerParameters`, since #3648
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4481#discussion_r131672655
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java
---
@@ -274,7 +260,7 @@ private void
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4367
looks like the build times increase by 5-10 minutes but I'd say this is
worth it
+1 from my side
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4445
in a non-exhaustive mini benchmark, I ran `HashVsSortMiniBenchmark` and got
the following results:
# Best out of 5 (in ms)
Test | `master` | `Flink-7310
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4481
[FLINK-7316][network] always use off-heap network buffers
## What is the purpose of the change
For now, network buffers may be on-heap or off-heap along with Flink memory
settings. As a step
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/3085
no, this is not part of FLIP-19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user NicoK closed the pull request at:
https://github.com/apache/flink/pull/3085
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4234#discussion_r131431720
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobCacheSuccessTest.java
---
@@ -92,15 +100,15 @@ private void uploadFileGetTest(final
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4234#discussion_r131431976
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java
---
@@ -107,195 +96,89 @@ public static void stopServers() throws
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4234#discussion_r131431731
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java
---
@@ -107,195 +96,89 @@ public static void stopServers() throws
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4562#discussion_r134699645
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -220,9 +220,7 @@ void releaseBuffer
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4562#discussion_r134711249
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -18,6 +18,12 @@
package
201 - 300 of 1005 matches
Mail list logo
