Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3207#discussion_r97774934
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AllWindowedStream.java
---
@@ -279,6 +286,202 @@ public
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3207#discussion_r97776155
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
---
@@ -515,12 +515,16 @@ public WindowedStream
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3207#discussion_r97775252
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AllWindowedStream.java
---
@@ -279,6 +286,202 @@ public
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3216
Looks good, though we don't really test whether it silently ignores the
empty lines, do we?
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3191#discussion_r97833288
--- Diff: docs/dev/windows.md ---
@@ -758,8 +831,33 @@ input
val input: DataStream[T] = ...
input
-.windowAll()
+.keyBy
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3191#discussion_r97828763
--- Diff: docs/dev/windows.md ---
@@ -622,133 +690,138 @@ input
-## Dealing with Late Data
+## Triggers
-When working
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3191#discussion_r97827610
--- Diff: docs/dev/windows.md ---
@@ -622,133 +690,138 @@ input
-## Dealing with Late Data
+## Triggers
-When working
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3191#discussion_r97827894
--- Diff: docs/dev/windows.md ---
@@ -622,133 +690,138 @@ input
-## Dealing with Late Data
+## Triggers
-When working
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3191#discussion_r97828958
--- Diff: docs/dev/windows.md ---
@@ -622,133 +690,138 @@ input
-## Dealing with Late Data
+## Triggers
-When working
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3191#discussion_r97827094
--- Diff: docs/dev/windows.md ---
@@ -204,72 +221,120 @@ input
{% highlight scala %}
val input: DataStream[T] = ...
-// tumbling event
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3191#discussion_r97832573
--- Diff: docs/dev/windows.md ---
@@ -622,133 +690,138 @@ input
-## Dealing with Late Data
+## Triggers
-When working
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3191#discussion_r97832399
--- Diff: docs/dev/windows.md ---
@@ -622,133 +690,138 @@ input
-## Dealing with Late Data
+## Triggers
-When working
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3191#discussion_r97823809
--- Diff: docs/dev/windows.md ---
@@ -204,72 +221,120 @@ input
{% highlight scala %}
val input: DataStream[T] = ...
-// tumbling event
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3191#discussion_r97828488
--- Diff: docs/dev/windows.md ---
@@ -622,133 +690,138 @@ input
-## Dealing with Late Data
+## Triggers
-When working
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3191#discussion_r97833002
--- Diff: docs/dev/windows.md ---
@@ -758,8 +831,33 @@ input
val input: DataStream[T] = ...
input
-.windowAll()
+.keyBy
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3191#discussion_r97824676
--- Diff: docs/dev/windows.md ---
@@ -23,133 +23,96 @@ specific language governing permissions and limitations
under the License
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3191#discussion_r97822798
--- Diff: docs/dev/windows.md ---
@@ -278,38 +343,39 @@ input
{% highlight scala %}
val input: DataStream[T] = ...
-// tumbling event
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3191#discussion_r97826641
--- Diff: docs/dev/windows.md ---
@@ -204,72 +221,120 @@ input
{% highlight scala %}
val input: DataStream[T] = ...
-// tumbling event
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3191#discussion_r97829270
--- Diff: docs/dev/windows.md ---
@@ -622,133 +690,138 @@ input
-## Dealing with Late Data
+## Triggers
-When working
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/commit/6342d6db1de5f38a921732e35abd83e6c5b9305a#commitcomment-20626829
In
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AllWindowedStream.java:
In
flink-streaming
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3191
This looks very good now! @kl0u and @fhueske, could you please figure out
how to squash the commits into one or two commits? Once that's done I'll update
the Figures from the Source Ma
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3225
[FLINK-5670] Properly clean up local RocksDB directories
We have to change the instance path to not include too many nested
directories, otherwise the Keyed backend cannot properly clean up the
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3225
@uce, @StefanRRichter Could you please have a look, I think it would be
good to have that in Flink 1.2.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3224
Thanks. ð I Pushed this both to master and release-1.2 with my changes
on top.
Could you please close this PR and the two Jira Issues?
---
If your project is set up for it, you can
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3225
@uce are you checking this with the Job where you initially discovered it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3184#discussion_r98240527
--- Diff: docs/dev/stream/state.md ---
@@ -39,40 +39,247 @@ if necessary) to allow applications to hold very large
state.
This document explains how to
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3184#discussion_r98240690
--- Diff: docs/dev/stream/state.md ---
@@ -39,40 +39,247 @@ if necessary) to allow applications to hold very large
state.
This document explains how to
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3225
Thanks ð ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/3225
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3184
@alpinegizmo Could you please check out these changes:
https://github.com/aljoscha/flink/tree/pr-3184-state-documentation? I took your
PR, reshuffled the sections (keyed state is now mentioned
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3184
Thanks for your work, @alpinegizmo. ð
Could you please close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3130
@kl0u I reviewed and like your additions ð
However, could you please have a look here:
https://github.com/aljoscha/flink/tree/pr-3130-migration-documentation I'm
suggesting a
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2992#discussion_r98638456
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/SafetyNetCloseableRegistry.java
---
@@ -41,7 +41,7 @@
* Phantom references are used to
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2992
@StefanRRichter If you also agree, could you please rebase on the latest
master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2992
Thanks ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3243#discussion_r98710331
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/state/StateDescriptor.java
---
@@ -20,34 +20,29 @@
import
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3130
Thanks! ð I merged your changes, could you please close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2992#discussion_r99317280
--- Diff:
flink-core/src/main/java/org/apache/flink/util/AbstractConcurrentClosingRegistry.java
---
@@ -18,37 +18,42 @@
package
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3262
[FLINK-5709] Add Max Parallelism to Parallel Execution Doc
R: @rmetzger and @alpinegizmo (as the original writer of the parallelism
doc).
You can merge this pull request into a Git repository by
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3262#discussion_r99354689
--- Diff: docs/dev/parallel.md ---
@@ -166,10 +177,19 @@ try {
-## System Level
+### System Level
A system-wide default
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3262#discussion_r99372586
--- Diff: docs/dev/parallel.md ---
@@ -166,10 +177,19 @@ try {
-## System Level
+### System Level
A system-wide default
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2768
In fact, my original suggestion was to add a new interface `ReadableState`:
```
interface ReadableState {
T get();
}
```
and leave all the existing interfaces as they
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3262
Merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/3262
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3272
[FLINK-5721] Add FoldingState to State Documentation
R: @NicoK
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink add-fold-state
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3272
Thanks @uce and @NicoK. I incorporated your suggestions and will merge now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/3272
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3285
[FLINK-4997] [streaming] Introduce ProcessWindowFunction
This is an updated/enhanced version of #2756.
I did roughly these changes:
- Add support for the `AggregatingFunction
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4665
These are not actually the places where you can count dropped data. I would
suggest to add this at the very end of `processElement()` where we also check
whether we should side-output late data
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4655
You can try and run the build locally to have a look at the file generated
by the compatibility plugin. Then we can figure out why it's complaining.
---
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4659#discussion_r138918167
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/functions/KeySelector.java
---
@@ -36,7 +37,7 @@
public interface KeySelector extends
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4665
@Aitozi I meant that the place where you're currently counting dropped
elements will not yield a correct count because one element might be in several
windows. The place were we side-output
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4655
A local build of `mvn clean verify` fails for me because the japicmp plugin
is complaining. The relevant section of the diff output from japicmp is
```
***! MODIFIED CLASS: PUBLIC
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4655
Thanks! This doesn't help us with our situation, though.
---
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4636#discussion_r139651625
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/util/HadoopUtils.java ---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4636
I pushed a rebased version of this.
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4616
@pnowojski and @EronWright I changed the name of the `Context`, I added a
test in `StreamSinkOperatorTest`, I added methods or querying current
processing time/watermark to the context. I changed
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4665#discussion_r139702816
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -405,6 +411,8 @@ public
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4678
The changes look good! ð I especially like the added tests and
documentation.
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4678
I merged, could you please close this PR?
And thanks for working on this! ð
---
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4665#discussion_r139911220
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -405,6 +411,8 @@ public
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/4616
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4616
Thanks for the reviews, everyone! ð
---
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/4564
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4665
This looks good to merge now. ð
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4655
Perfect! Thanks for working on this. ð
I merged, could you please close this PR?
---
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4639#discussion_r140449401
--- Diff:
flink-core/src/main/java/org/apache/flink/util/WrappingProxyUtil.java ---
@@ -27,10 +27,16 @@ private WrappingProxyUtil() {
throw
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4639#discussion_r140448606
--- Diff:
flink-core/src/main/java/org/apache/flink/util/AbstractCloseableRegistry.java
---
@@ -61,13 +75,14 @@ public final void registerClosable(C
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4639#discussion_r140452104
--- Diff:
flink-core/src/test/java/org/apache/flink/core/fs/AbstractCloseableRegistryTest.java
---
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4671#discussion_r140456968
--- Diff:
flink-core/src/main/java/org/apache/flink/util/AbstractCloseableRegistry.java
---
@@ -90,14 +90,14 @@ public final void registerClosable(C
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4671#discussion_r140458159
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/async/AbstractAsyncCallableWithResources.java
---
@@ -0,0 +1,194
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4671#discussion_r140458424
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/async/AbstractAsyncCallableWithResources.java
---
@@ -0,0 +1,194
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4671#discussion_r140458205
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/async/AbstractAsyncCallableWithResources.java
---
@@ -0,0 +1,194
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4690#discussion_r140515705
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/JobTaskVertexTest.java
---
@@ -84,10 +88,10 @@ public void
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4639#discussion_r140516796
--- Diff:
flink-core/src/main/java/org/apache/flink/util/AbstractCloseableRegistry.java
---
@@ -61,13 +75,14 @@ public final void registerClosable(C
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4702#discussion_r140528890
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/AccumulatingKeyedTimePanes.java
---
@@ -212,6 +213,11
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4702#discussion_r140529325
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -774,6 +774,14 @@ public
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4707
Thanks for pulling this apart to quickly! I merged. ð
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4707
Could you please close if it doesn't auto-close?
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4702
I merged this, excellent work! ð
The Scala API has its own `OutputTag` because it allows us to use a Scala
feature called context bounds. The signature of the Scala `OutputTag` is
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4722#discussion_r141034332
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java
---
@@ -442,6
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4636#discussion_r141084730
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/codegen/TypeInformationGen.scala
---
@@ -320,14 +315,6 @@ private[flink] trait
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4722#discussion_r141272559
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackend.java
---
@@ -37,6 +39,12 @@
void setCurrentKey(K newKey
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4683#discussion_r141312154
--- Diff: flink-core/pom.xml ---
@@ -52,6 +52,12 @@ under the License.
flink-shaded-asm
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/4731
[FLINK-7700] Fix RocksDB state merging
## What is the purpose of the change
See title
## Brief change log
This fixes state merging in the respective classes and also
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4731#discussion_r141639769
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -1978,4
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4731
I think it would be good to have an abstraction for that, yes.
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4614
Thanks a lot @yew1eb for fixing this! I merged. ð
Could you please close this PR if it doesn't close automatically?
---
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/4752
[FLINK-7700] Fix RocksDB state merging on release-1.3
This is only for running the tests, which I can't do on my own Travis since
tests time out.
You can merge this pull request into
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/4752
---
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/4731
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4731
Merged, Thanks for the reviews!
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4738
@tzulitai Thanks a lot for this fix! ð Could you please close the PR?
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4747
This looks very good, the test is also much cleaner and understandable now.
ð
One thing, in the refactoring the bit of testing code that verifies the fix
for FLINK-7721 was dropped (I
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4747
Merged. ð Could you please also close this PR?
---
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4776#discussion_r142880460
--- Diff: flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java
---
@@ -328,116 +360,54 @@ public static FileSystem getUnguardedFileSystem(URI
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4776#discussion_r142880553
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/FileSystemFactory.java ---
@@ -15,18 +15,19 @@
* See the License for the specific
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3703
@DieBauer Do you still wan't to work on this? I also started trying to make
Flink ready for 2.12 before I noticed this older branch. I'd be very happy to
stop, though, if you'r
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4780
This LGTM! ð I looked at the last two commits here and also the
predecessor commits from #4776
---
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4781#discussion_r143171918
--- Diff:
flink-filesystems/flink-mapr-fs/src/test/java/org/apache/flink/runtime/fs/maprfs/FileSystemAccessTest.java
---
@@ -0,0 +1,42
701 - 800 of 3908 matches
Mail list logo
