[GitHub] flink issue #4522: [FLINK-7366][kinesis connector] Upgrade kinesis producer ...

2017-08-15 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4522 yeah, we ran our job with this change on Flink 1.3.0 on EMR and didn't have issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request #4547: [FLINK-7454][docs] update 'Monitoring Current Even...

2017-08-16 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4547 [FLINK-7454][docs] update 'Monitoring Current Event Time' section of Flink doc **(The sections below can be removed for hotfixes of typos)** ## What is the purpose of

[GitHub] flink issue #4473: [FLINK-7367][kinesis connector] Parameterize more configs...

2017-08-16 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4473 @tzulitai done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] flink issue #4547: [FLINK-7454][docs] update 'Monitoring Current Event Time'...

2017-08-21 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4547 any feedback? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] flink issue #4522: [FLINK-7366][kinesis connector] Upgrade kinesis producer ...

2017-08-21 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4522 @tzulitai any more feedbacks? We have a ticket on my company for this task, and I'd like to mark it as finished if possible :) --- If your project is set up for it, you can reply to this

[GitHub] flink pull request #4522: [FLINK-7366][kinesis connector] Upgrade kinesis pr...

2017-08-21 Thread bowenli86
Github user bowenli86 closed the pull request at: https://github.com/apache/flink/pull/4522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4522: [FLINK-7366][kinesis connector] Upgrade kinesis pr...

2017-08-21 Thread bowenli86
GitHub user bowenli86 reopened a pull request: https://github.com/apache/flink/pull/4522 [FLINK-7366][kinesis connector] Upgrade kinesis producer library in flink-connector-kinesis ## What is the purpose of the change We need to upgrade KPL and KCL to pick up the enhanced

[GitHub] flink issue #4473: [FLINK-7367][kinesis connector] Parameterize more configs...

2017-08-21 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4473 @tzulitai any more feedbacks? We have a ticket on my company for this task, and I'd like to mark it as finished if possible :) --- If your project is set up for it, you can reply to this

[GitHub] flink issue #4522: [FLINK-7366][kinesis connector] Upgrade kinesis producer ...

2017-08-28 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4522 can anyone from data artisan take a look at this PR please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #4473: [FLINK-7367][kinesis connector] Parameterize more configs...

2017-08-28 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4473 can anyone from data artisan take a look at this PR please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #4547: [FLINK-7454][docs] update 'Monitoring Current Event Time'...

2017-08-28 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4547 @zentol does it look good to you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #4522: [FLINK-7366][kinesis connector] Upgrade kinesis producer ...

2017-08-29 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4522 Great! I can start FLINK-7508 then --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #4522: [FLINK-7366][kinesis connector] Upgrade kinesis producer ...

2017-08-30 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4522 @aljoscha No worries. Dropping compatibility with Flink 1.2 Kinesis consumer is great news! I reopened (Flink-7422)[https://issues.apache.org/jira/browse/FLINK-7422] to upgrade KCL --- If your

[GitHub] flink pull request #4627: [FLINK-7422][kinesis] Upgrade Kinesis Client Libra...

2017-08-30 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4627 [FLINK-7422][kinesis] Upgrade Kinesis Client Library (KCL) and AWS SDK in flink-connector-kinesis ## What is the purpose of the change Upgrade KCL from 1.6.2 to 1.8.1 (https

[GitHub] flink pull request #4627: [FLINK-7422][kinesis] Upgrade Kinesis Client Libra...

2017-09-01 Thread bowenli86
Github user bowenli86 closed the pull request at: https://github.com/apache/flink/pull/4627 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4639: [FLINK-7524] Remove potentially blocking behaviour...

2017-09-04 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4639#discussion_r136877433 --- Diff: flink-core/src/main/java/org/apache/flink/util/AbstractCloseableRegistry.java --- @@ -61,13 +75,14 @@ public final void registerClosable(C

[GitHub] flink pull request #4639: [FLINK-7524] Remove potentially blocking behaviour...

2017-09-04 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4639#discussion_r136879648 --- Diff: flink-core/src/main/java/org/apache/flink/util/AbstractCloseableRegistry.java --- @@ -61,13 +75,14 @@ public final void registerClosable(C

[GitHub] flink issue #4473: [FLINK-7367][kinesis connector] Parameterize more configs...

2017-09-06 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4473 @tzulitai or other Flink committers, can you please merge this so I can submit more PRs depend on this? Thanks! ---

[GitHub] flink issue #4473: [FLINK-7367][kinesis connector] Parameterize more configs...

2017-09-06 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4473 @tzulitai Thank you, Gordon! ---

[GitHub] flink pull request #4656: [FLINK-7508][kinesis] switch FlinkKinesisProducer ...

2017-09-07 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4656 [FLINK-7508][kinesis] switch FlinkKinesisProducer to use KPL's ThreadingMode to ThreadedPool mode rather than Per_Request mode ## What is the purpose of the change KinesisProducerLi

[GitHub] flink pull request #4657: [FLINK-7600][kinesis] shorten delay of KinesisProd...

2017-09-07 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4657 [FLINK-7600][kinesis] shorten delay of KinesisProducerConfiguration.setCredentialsRefreshDelay() to avoid updateCredentials Exception ## What is the purpose of the change we saw the

[GitHub] flink pull request #4662: [FLINK-7609][examples] WindowWordCount example doe...

2017-09-08 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4662 [FLINK-7609][examples] WindowWordCount example doesn't print countWindow output with default configs ## What is the purpose of the change When running WindowWordCount example wi

[GitHub] flink pull request #4663: [FLINK-6549] [DataStream API] Improve error messag...

2017-09-09 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4663 [FLINK-6549] [DataStream API] Improve error message for type mismatches with side outputs ## What is the purpose of the change A type mismatch when using side outputs causes a

[GitHub] flink issue #4662: [FLINK-7609][examples] WindowWordCount example doesn't pr...

2017-09-11 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4662 There's no output with 100/50 either, because the default text we use at WordCountData.WORDS is not very long and cannot satisfy the count window size. There's only 11 window ouputs even

[GitHub] flink pull request #4881: Flink 7864

2017-10-22 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4881 Flink 7864 ## What is the purpose of the change Support side-outputs in CoProcessFunction ## Brief change log - Support side-outputs in CoProcessFunction - Added

[GitHub] flink issue #4757: [Flink 7694][REST][Webfrontend]Port JobMetricsHandler to ...

2017-10-22 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4757 Hi @tillrohrmann , I'm spending time on issues of 1.4.0. This handler is not on my top priority right now. Please feel free to continue working on this if you'd like to :) ---

[GitHub] flink issue #4786: [FLINK-7388][DataStream API] ProcessFunction.onTimer() se...

2017-10-22 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4786 Hi @aljoscha @fhueske , please let me know if you have any more comments ---

[GitHub] flink pull request #4881: [FLINK-7864] [DataStream API] Support side-outputs...

2017-10-22 Thread bowenli86
GitHub user bowenli86 reopened a pull request: https://github.com/apache/flink/pull/4881 [FLINK-7864] [DataStream API] Support side-outputs in CoProcessFunction ## What is the purpose of the change Support side-outputs in CoProcessFunction ## Brief change log

[GitHub] flink pull request #4881: [FLINK-7864] [DataStream API] Support side-outputs...

2017-10-22 Thread bowenli86
Github user bowenli86 closed the pull request at: https://github.com/apache/flink/pull/4881 ---

[GitHub] flink pull request #4833: [FLINK-5968] Add documentation for WindowedStream....

2017-10-22 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4833#discussion_r146134235 --- Diff: docs/dev/stream/operators/windows.md --- @@ -427,6 +427,93 @@ input The above example sums up the second fields of the tuples for all

[GitHub] flink pull request #4833: [FLINK-5968] Add documentation for WindowedStream....

2017-10-22 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4833#discussion_r146134312 --- Diff: docs/dev/stream/operators/windows.md --- @@ -721,6 +808,111 @@ input + Incremental Window Aggregation with

[GitHub] flink pull request #4833: [FLINK-5968] Add documentation for WindowedStream....

2017-10-22 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4833#discussion_r146134311 --- Diff: docs/dev/stream/operators/windows.md --- @@ -721,6 +808,111 @@ input + Incremental Window Aggregation with

[GitHub] flink pull request #4833: [FLINK-5968] Add documentation for WindowedStream....

2017-10-22 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4833#discussion_r146134163 --- Diff: docs/dev/stream/operators/windows.md --- @@ -427,6 +427,93 @@ input The above example sums up the second fields of the tuples for all

[GitHub] flink pull request #4833: [FLINK-5968] Add documentation for WindowedStream....

2017-10-22 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4833#discussion_r146134241 --- Diff: docs/dev/stream/operators/windows.md --- @@ -427,6 +427,93 @@ input The above example sums up the second fields of the tuples for all

[GitHub] flink issue #4833: [FLINK-5968] Add documentation for WindowedStream.aggrega...

2017-10-22 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4833 I just saw this PR, and sorry for submitting my feedbacks late... ---

[GitHub] flink issue #4798: [FLINK-6505] Proactively cleanup local FS for RocksDBKeye...

2017-10-22 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4798 Hi @StephanEwen @StefanRRichter , please let me know if you have any more feedbacks ---

[GitHub] flink pull request #4882: [FLINK-6245] Fix late side output documentation in...

2017-10-22 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4882 [FLINK-6245] Fix late side output documentation in Window documents. ## What is the purpose of the change There are two things that need to be done: 1) in the syntax description

[GitHub] flink pull request #4798: [FLINK-6505] Proactively cleanup local FS for Rock...

2017-10-22 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4798#discussion_r146165655 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -313,10

[GitHub] flink pull request #4798: [FLINK-6505] Proactively cleanup local FS for Rock...

2017-10-22 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4798#discussion_r146165645 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -235,6

[GitHub] flink pull request #4798: [FLINK-6505] Proactively cleanup local FS for Rock...

2017-10-22 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4798#discussion_r146167573 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -235,26

[GitHub] flink pull request #4882: [FLINK-6245] [doc] Fix late side output documentat...

2017-10-23 Thread bowenli86
Github user bowenli86 closed the pull request at: https://github.com/apache/flink/pull/4882 ---

[GitHub] flink pull request #4871: [FLINK-7637] [kinesis] Fix at-least-once guarantee...

2017-10-23 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4871#discussion_r146440154 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java --- @@ -265,19

[GitHub] flink pull request #4786: [FLINK-7388][DataStream API] ProcessFunction.onTim...

2017-10-24 Thread bowenli86
Github user bowenli86 closed the pull request at: https://github.com/apache/flink/pull/4786 ---

[GitHub] flink pull request #4881: [FLINK-7864] [DataStream API] Support side-outputs...

2017-10-24 Thread bowenli86
Github user bowenli86 closed the pull request at: https://github.com/apache/flink/pull/4881 ---

[GitHub] flink issue #4881: [FLINK-7864] [DataStream API] Support side-outputs in CoP...

2017-10-24 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4881 Those are actually intentional to reorder the methods so they conform to the order in the interface. Well, it's fine to not merge those ---

[GitHub] flink issue #4871: [FLINK-7637] [kinesis] Fix at-least-once guarantee in Fli...

2017-10-24 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4871 LGTM :+1: ---

[GitHub] flink pull request #4899: [FLINK-5967][DataStream API][Doc] Add RuntimeConte...

2017-10-24 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4899 [FLINK-5967][DataStream API][Doc] Add RuntimeContext#getAggregatingState() and document AggregatingState ## What is the purpose of the change Add `RuntimeContext#getAggregatingState

[GitHub] flink issue #4881: [FLINK-7864] [DataStream API] Support side-outputs in CoP...

2017-10-25 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4881 Sounds good. Thanks! ---

[GitHub] flink pull request #4904: [hotfix] reorder the methods so they conform to th...

2017-10-25 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4904 [hotfix] reorder the methods so they conform to their order in the interface ## What is the purpose of the change As discussed with @aljoscha in https://github.com/apache/flink/pull/4881

[GitHub] flink pull request #4907: [FLINK-5823] [checkpoints] State Backends also han...

2017-10-25 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4907#discussion_r147031787 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -243,11 +245,19 @@ else if (directory.exists()) { * @throws

[GitHub] flink issue #4899: [FLINK-5967][DataStream API][Doc] Add RuntimeContext#getA...

2017-10-26 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4899 @StephanEwen @aljoscha Hi guys, I'm not sure if this is counted as a feature or not (I guess so, because this PR adds a few new public APIs). If so, it would be necessary to get this into m

[GitHub] flink pull request #4907: [FLINK-5823] [checkpoints] State Backends also han...

2017-10-26 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4907#discussion_r147121427 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -243,11 +245,19 @@ else if (directory.exists()) { * @throws

[GitHub] flink pull request #4899: [FLINK-5967][DataStream API][Doc] Add RuntimeConte...

2017-10-27 Thread bowenli86
Github user bowenli86 closed the pull request at: https://github.com/apache/flink/pull/4899 ---

[GitHub] flink pull request #4904: [hotfix] reorder the methods so they conform to th...

2017-10-27 Thread bowenli86
Github user bowenli86 closed the pull request at: https://github.com/apache/flink/pull/4904 ---

[GitHub] flink issue #4757: [FLINK-7694][REST][Webfrontend]Port JobMetricsHandler to ...

2017-10-31 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4757 Once this PR is merged, I'll migrate other metrics handlers and abstract the common code away. ---

[GitHub] flink issue #4932: [FLINK-7958][metrics] Allow reporters to define default d...

2017-11-01 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4932 I would suggest another solution - rather than adding another interface 'DelimiterProvider', add `getDelimiter()` which returns '.' as an interface default method to `MetricRep

[GitHub] flink pull request #4944: [hotfix] add space bewteen error message lines

2017-11-03 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4944 [hotfix] add space bewteen error message lines ## What is the purpose of the change add space bewteen error message lines ## Brief change log add space bewteen error

[GitHub] flink pull request #4945: [FLINK-7977][build] bump version of compatibility ...

2017-11-03 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4945 [FLINK-7977][build] bump version of compatibility check for Flink 1.4 ## What is the purpose of the change Since Flink maintains backward compatibility check for 2 versions, Flink 1.4

[GitHub] flink issue #4960: Update version to 1.5-SNAPSHOT

2017-11-06 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4960 👍 ---

[GitHub] flink pull request #4963: [FLINK-7475] [core][state backend] support update(...

2017-11-06 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4963 [FLINK-7475] [core][state backend] support update() in ListState ## What is the purpose of the change If users want to update the list, they have to do two steps: ```java

[GitHub] flink issue #4798: [FLINK-6505] Proactively cleanup local FS for RocksDBKeye...

2017-11-09 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4798 Hi @StefanRRichter , do you have more feedbacks? ---

[GitHub] flink issue #4963: [FLINK-7475] [core][DataStream API] support update() in L...

2017-11-11 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4963 Hi @yunfan123 Thanks for the feedback, and I agree with you. Well, here's the problem: Flink seems to be using the StringAppendTestOperator as merge operator from RocksDB, which ad

[GitHub] flink issue #4963: [FLINK-7475] [core][DataStream API] support update() in L...

2017-11-12 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4963 @yunfan123 sorry I can't find where `PredefinedOptions` defines it. Isn't Flink using RocksDB's `StringAppendTESTOperator` in `RocksDBKeyedStateBackend`? Hi @aljosch

[GitHub] flink issue #4963: [FLINK-7475] [core][DataStream API] support update() in L...

2017-11-14 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4963 @yunfan123 @aljoscha @StefanRRichter I chose the "shallow" simulation. What do you guys think? The build failure seems to be because one build profile timed out. ---

[GitHub] flink pull request #5017: [FLINK-8076] Upgrade KinesisProducer to 0.10.6 to ...

2017-11-14 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/5017 [FLINK-8076] Upgrade KinesisProducer to 0.10.6 to set properties approperiately ## What is the purpose of the change https://github.com/awslabs/amazon-kinesis-producer/issues/124 has

[GitHub] flink issue #4921: [FLINK-7943] Make ParameterTool thread safe

2017-11-14 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4921 LGTM +1 ---

[GitHub] flink issue #4945: [FLINK-7977][build] bump version of compatibility check f...

2017-11-15 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4945 Sounds good. Thanks @zentol ! 👍 ---

[GitHub] flink issue #5017: [FLINK-8076] Upgrade KinesisProducer to 0.10.6 to set pro...

2017-11-15 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5017 cc @tzulitai ---

[GitHub] flink issue #5032: [FLINK-8090] [DataStream] Improve the error message for d...

2017-11-17 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5032 Can you please add a unit test for this? ---

[GitHub] flink issue #5032: [FLINK-8090] [DataStream] Improve the error message for d...

2017-11-18 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5032 sounds good ---

[GitHub] flink issue #4945: [FLINK-7977][build] bump version of compatibility check f...

2017-11-20 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4945 Sounds good. Thanks, @zentol ! ---

[GitHub] flink pull request #4945: [FLINK-7977][build] bump version of compatibility ...

2017-11-20 Thread bowenli86
Github user bowenli86 closed the pull request at: https://github.com/apache/flink/pull/4945 ---

[GitHub] flink issue #4798: [FLINK-6505] Proactively cleanup local FS for RocksDBKeye...

2017-11-20 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4798 @StefanRRichter @aljoscha is it still possible to get this into 1.4? ---

[GitHub] flink pull request #5032: [FLINK-8090] [DataStream] Improve the error messag...

2017-11-21 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5032#discussion_r152348905 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/StreamingRuntimeContextTest.java --- @@ -270,6 +271,20 @@ public

[GitHub] flink pull request #5032: [FLINK-8090] [DataStream] Improve the error messag...

2017-11-21 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5032#discussion_r152475532 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/StreamingRuntimeContextTest.java --- @@ -270,6 +271,20 @@ public

[GitHub] flink pull request #4798: [FLINK-6505] Proactively cleanup local FS for Rock...

2017-11-23 Thread bowenli86
Github user bowenli86 closed the pull request at: https://github.com/apache/flink/pull/4798 ---

[GitHub] flink issue #4757: [FLINK-7694][REST][Webfrontend]Port JobMetricsHandler to ...

2017-11-23 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4757 Hi @GJL , you can take over this PR ---

[GitHub] flink pull request #5112: [FLINK-8175] remove flink-streaming-contrib and mi...

2017-12-02 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/5112 [FLINK-8175] remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala ## What is the purpose of the change This is the first step to clean up flink-contrib

[GitHub] flink pull request #4757: [FLINK-7694][REST][Webfrontend]Port JobMetricsHand...

2017-12-02 Thread bowenli86
Github user bowenli86 closed the pull request at: https://github.com/apache/flink/pull/4757 ---

[GitHub] flink pull request #6319: [FLINK-9822] Add Dockerfile for StandaloneJobClust...

2018-07-12 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/6319#discussion_r202197686 --- Diff: flink-container/docker/README.md --- @@ -0,0 +1,44 @@ +# Apache Flink cluster deployment on docker using docker-compose

[GitHub] flink pull request #6319: [FLINK-9822] Add Dockerfile for StandaloneJobClust...

2018-07-12 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/6319#discussion_r202198679 --- Diff: flink-container/docker/README.md --- @@ -0,0 +1,44 @@ +# Apache Flink cluster deployment on docker using docker-compose --- End diff

[GitHub] flink pull request #6300: [FLINK-9692][Kinesis Connector] Adaptive reads fro...

2018-07-12 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/6300#discussion_r202201507 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java --- @@ -330,4

[GitHub] flink pull request #6300: [FLINK-9692][Kinesis Connector] Adaptive reads fro...

2018-07-12 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/6300#discussion_r202199865 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java

[GitHub] flink issue #6373: [FLINK-9838][logging] Don't log slot request failures on ...

2018-07-23 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/6373 Ran into this bug too. +1 for the fix ---

[GitHub] flink pull request #4136: [FLINK-6940][docs] Clarify the effect of configuri...

2017-07-07 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4136#discussion_r126240877 --- Diff: docs/ops/state_backends.md --- @@ -124,7 +124,7 @@ RocksDBStateBackend is currently the only backend that offers incremental checkp

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2017-07-07 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4150 @tzulitai I shaded httpcomponents. Does it look good? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #4136: [FLINK-6940][docs] Clarify the effect of configuri...

2017-07-10 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4136#discussion_r126503269 --- Diff: docs/ops/state_backends.md --- @@ -123,8 +123,7 @@ RocksDBStateBackend is currently the only backend that offers incremental checkp

[GitHub] flink pull request #4150: [FLINK-6951] Incompatible versions of httpcomponen...

2017-07-10 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4150#discussion_r126509865 --- Diff: docs/setup/aws.md --- @@ -224,8 +224,6 @@ Depending on which file system you use, please add the following dependencies. Y - `S3AFileSystem

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2017-07-10 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4150 @tzulitai @tedyu Hi guys, I'm also wondering how much percentage of Flink users are using Flink with Kinesis? Kinesis has so many limitations that we are considering to move from Ki

[GitHub] flink pull request #4150: [FLINK-6951] Incompatible versions of httpcomponen...

2017-07-10 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4150#discussion_r126511039 --- Diff: flink-connectors/flink-connector-kinesis/pom.xml --- @@ -36,6 +36,8 @@ under the License. 1.10.71 1.6.2

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2017-07-12 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4150 I added http components to dependencies because Hadoop-aws 2.7 depends on http components 4.2. ``` $ jar -tf flink-connector-kinesis_2.11-1.4-SNAPSHOT.jar | grep apache/http org

[GitHub] flink pull request #4150: [FLINK-6951] Incompatible versions of httpcomponen...

2017-07-12 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4150#discussion_r127138994 --- Diff: flink-connectors/flink-connector-kinesis/pom.xml --- @@ -56,6 +58,18 @@ under the License

[GitHub] flink pull request #4150: [FLINK-6951] Incompatible versions of httpcomponen...

2017-07-12 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4150#discussion_r127139879 --- Diff: flink-connectors/flink-connector-kinesis/pom.xml --- @@ -56,6 +58,18 @@ under the License

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2017-07-12 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4150 ok, I kind of figured out what `promoteTransitiveDependencies` means. I removed explicit dependencies of httpclient and httpcore from `pom.xml`, and made sure http-components are shaded

[GitHub] flink issue #4309: [FLINK-7166][avro] cleanup generated test classes in the ...

2017-07-13 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4309 I ran into this too. Thanks for the PR! Shall we also create a ticket to move generated files out of `src`? --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2017-07-13 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4150 During testing, I saw the following exception: ```java java.lang.IllegalStateException: Socket not created by this factory at

[GitHub] flink issue #4136: [FLINK-6940][docs] Clarify the effect of configuring per-...

2017-07-17 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4136 @zentol @alpinegizmo Let me know your thoughts on it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #4375: [Flink 6365][kinesis-connector] Adapt default valu...

2017-07-19 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4375 [Flink 6365][kinesis-connector] Adapt default values of the Kinesis connector Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2017-07-24 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4150 My Flink job checkpoints to S3, I'm configuring S3AFileSystem shown in https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/aws.html#flink-for-hadoop-27. I doubt if this

[GitHub] flink issue #4136: [FLINK-6940][docs] Clarify the effect of configuring per-...

2017-07-24 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4136 @zentol @alpinegizmo Guys, please let me know your thoughts :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

<    1   2   3   4   5   >