Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49655529
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/NonReusingBuildFirstHashJoinIterator.java
---
@@ -144,13 +148,20 @@ public
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49657465
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49657379
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49655245
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/DriverStrategy.java
---
@@ -73,6 +73,8 @@
LEFT_OUTER_MERGE
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49655692
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -57,7 +58,7
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49657059
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49654923
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/HashFullOuterJoinBuildSecondDescriptor.java
---
@@ -0,0 +1,65
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49655995
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -420,15 +440,23 @@ public MutableHashTable
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49656801
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49656918
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49656863
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49726468
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTableITCase.java
---
@@ -1534,6 +1534,106 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49726803
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTableITCase.java
---
@@ -1534,6 +1534,106 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49728566
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/util/HashVsSortMiniBenchmark.java
---
@@ -184,7 +184,7 @@ public void
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1429#issuecomment-172460239
Yes, sounds good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1509#issuecomment-172501737
Will merge this PR tomorrow, unless somebody objects.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/1509
[Refactor] [DataSet] Refactor key selector translation in DataSet API.
This PR refactors the translation of `SelectorFunctionKey`s in the DataSet
API.
It removes a lot of duplicate code
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1509#issuecomment-172786687
Will merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68473031
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetIntersect.scala
---
@@ -0,0 +1,153
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68473636
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -446,6 +446,31 @@ class Table
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68474570
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -260,10 +260,14 @@ class CodeGenerator
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68473826
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -446,6 +446,31 @@ class Table
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68474420
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/sql/IntersectITCase.scala
---
@@ -0,0 +1,108
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2150#discussion_r68476229
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/typeutils/TypeCoercion.scala
---
@@ -85,6 +85,9 @@ object TypeCoercion
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2150
Hi @twalthr, thanks for the PR. I skimmed the changes and everything looked
fine. I have two suggestions though.
1. Can we add a casts from `Long` to `Timestamp` and back?
2. Can you
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68471662
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetIntersect.scala
---
@@ -0,0 +1,153
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68473250
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetIntersect.scala
---
@@ -0,0 +1,153
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2159
Hi @wuchong, thanks for the PR. I think it is better to use a CoGroup
instead of a Join for `INTERSECT` (even though, I said "Join" in the original
JIRA). For `INTERSECT ALL`, CoGroup i
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68473118
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetIntersect.scala
---
@@ -0,0 +1,153
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68474131
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/batch/table/IntersectITCase.java
---
@@ -0,0 +1,101
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/1856
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2104
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2107
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1856#discussion_r67297138
--- Diff:
flink-scala/src/test/scala/org/apache/flink/api/operator/MaxByOperatorTest.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1989#discussion_r67298280
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/api/java/io/RowCsvInputFormat.java
---
@@ -0,0 +1,152 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1989#discussion_r67299243
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java
---
@@ -0,0 +1,1075 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1989#discussion_r67299477
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/api/java/io/RowCsvInputFormat.java
---
@@ -0,0 +1,152 @@
+/*
+ * Licensed
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2118
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2088
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2119
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52461048
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/MemoryHashTableTest.java
---
@@ -100,340 +101,371 @@
@Test
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52470915
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTablePerformanceComparison.java
---
@@ -102,7 +102,7 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52461236
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReduceHashTableTest.java
---
@@ -0,0 +1,501 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52461306
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/manual/ReducePerformance.java
---
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52461281
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/manual/ReducePerformance.java
---
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-182398031
Hi @ggevay, sorry it took me very long to review your PR.
As I said before, this is a very desirable feature and a solid
implementation.
I think a few
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52471114
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/MemoryHashTableTest.java
---
@@ -100,340 +101,371 @@
@Test
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52460829
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java
---
@@ -0,0 +1,1014 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52460943
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTablePerformanceComparison.java
---
@@ -102,7 +102,7 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52469979
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java
---
@@ -0,0 +1,1014 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52459151
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/resettable/AbstractBlockResettableIterator.java
---
@@ -83,6 +83,7 @@ protected
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52470557
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java
---
@@ -0,0 +1,1014 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52460226
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java
---
@@ -0,0 +1,1014 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52473636
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/manual/ReducePerformance.java
---
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52458969
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/base/ReduceOperatorBase.java
---
@@ -52,6 +52,30 @@
*/
public class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52459830
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java
---
@@ -0,0 +1,1014 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52460590
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java
---
@@ -0,0 +1,1014 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52471392
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/manual/ReducePerformance.java
---
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52459053
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/RandomAccessInputView.java
---
@@ -45,9 +45,12 @@ public RandomAccessInputView
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52460049
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java
---
@@ -0,0 +1,1014 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52460672
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java
---
@@ -0,0 +1,1014 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52471181
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReduceHashTableTest.java
---
@@ -0,0 +1,501 @@
+/*
+ * Licensed
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-182483003
The benefit of having multiple partitions is that you do not need to go
over the complete RecordArea but only over a partition. After the partition is
compacted
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52489247
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/MemoryHashTableTest.java
---
@@ -100,340 +101,371 @@
@Test
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1581#discussion_r52495987
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java
---
@@ -61,42 +62,46 @@
* Cluster
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1581#discussion_r52496167
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java
---
@@ -61,42 +62,46 @@
* Cluster
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1581#discussion_r52496326
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java
---
@@ -105,119 +110,127 @@ public static
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-182555170
Thanks a lot for updating the PR @stefanobaghino!
It's up to you if you want to squash the commits. We can also do it before
we merge the PR.
---
If your project
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1579#issuecomment-179777395
I'll merge this PR to the `tableOnCalcite` branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user fhueske closed the pull request at:
https://github.com/apache/flink/pull/1579
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1585#discussion_r52099909
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/SortPartitionOperator.java
---
@@ -79,16 +112,33 @@ public SortPartitionOperator
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/1599
[FLINK-3366] Rename @Experimental annotation to @PublicEvolving
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink rnExperimental
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1585#discussion_r52281750
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1377,6 +1377,24 @@ public long count() throws Exception
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1585#discussion_r52281721
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1377,6 +1377,24 @@ public long count() throws Exception
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52293343
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1585#discussion_r52282118
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/SortPartitionOperator.java
---
@@ -36,27 +40,58 @@
*/
public class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52293004
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -0,0 +1,661 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1585#discussion_r52282391
--- Diff:
flink-tests/src/test/scala/org/apache/flink/api/scala/operators/SortPartitionITCase.scala
---
@@ -166,6 +167,58 @@ class SortPartitionITCase(mode
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1585#discussion_r52282336
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/SortPartitionITCase.java
---
@@ -197,6 +198,58 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1585#discussion_r52282275
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/DataSet.scala ---
@@ -1508,6 +1508,31 @@ class DataSet[T: ClassTag](set: JavaDataSet[T
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52291201
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -0,0 +1,661 @@
+/*
+ * Licensed
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1595#issuecomment-181824403
Hi Timo, the PR looks really good :-)
I found the following issues / questions:
- Accessing of POJO fields might not work.
- Can you add method comments
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1585#discussion_r52282174
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/SortPartitionOperator.java
---
@@ -79,58 +119,41 @@ public SortPartitionOperator
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1585#discussion_r52281965
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1377,6 +1377,24 @@ public long count() throws Exception
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1585#issuecomment-181773503
The refactoring looks good, @chiwanpark.
I have just a few minor remarks. The PR can be resolved after these have
been addressed.
---
If your project is set up
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52305236
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataset/DataSetJoinRule.scala
---
@@ -39,6 +46,10 @@ class
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1585#issuecomment-181845299
Thanks for the fast update!
Good to merge :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52303126
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52306203
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/MinAggregate.scala
---
@@ -0,0 +1,86
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1599#issuecomment-181829201
Thanks for catching that @StephanEwen.
JavaDocs are updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52304432
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/logical/FlinkAggregate.scala
---
@@ -58,19 +58,23 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52304994
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataset/DataSetAggregateRule.scala
---
@@ -37,14 +39,24 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52306088
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AvgAggregate.scala
---
@@ -0,0 +1,145
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52305988
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/MinAggregate.scala
---
@@ -0,0 +1,86
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52306136
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/MaxAggregate.scala
---
@@ -0,0 +1,84
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/1606
[FLINK-3367] Add PublicEvolving and Internal annotations to classes in API
modules
This PR includes the commit from #1599.
It adds annotations to all classes in the following modules
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1585#issuecomment-181917425
Will merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1599#issuecomment-181917327
Will merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1585#discussion_r51869883
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1377,6 +1377,20 @@ public long count() throws Exception
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1585#discussion_r51870870
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/operator/SortPartitionTest.java
---
@@ -169,6 +169,38 @@ public void
1101 - 1200 of 6115 matches
Mail list logo
