GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3252
[FLINK-5624] Support tumbling window on streaming tables in the SQL API.
This is a POC to add tumbling window support for streaming tables in SQL.
Essentially it recognizes
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3202
Thanks for the reviews.
It's more about readability of the code itself instead of testing and
visibility. The two functions are fairly long and basically identical.
Therefore I refactor
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3252
Updated the PR to recognize the `GROUP BY` clause instead of the `OVER`
clause.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3252
Adding `ROWTIME()` as an expression to enable users to specify event time
windows.
After trying multiple approaches at the end I settled down with translating
`LogicalAggregate` directly
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3202
[FLINK-5631] [yarn] Support downloading additional jars from non-HDFSâ¦
This PR enables Flink to support downloading additional jars from non-HDFS
paths (e.g., S3, viewfs). More details
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3302
FYI: #3370 is the commit we use internally for this feature. Please feel
free to take it if it helps implementing this PR.
---
If your project is set up for it, you can reply to this email and have
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3370
[FLINK-5710] Add ProcTime() function to indicate StreamSQL.
This is the commit we used internally -- There is no unit tests associated
with this PR. It simply serves as a reference point for #3302
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3338#discussion_r102117236
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/ExpressionReductionTest.scala
---
@@ -155,15 +155,15 @@ class
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3338#discussion_r102125031
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/ExpressionReductionTest.scala
---
@@ -155,15 +155,15 @@ class
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3338
Looks good to me overall. One question -- I wonder, does it mean that all
array types become nullable after this change?
---
If your project is set up for it, you can reply to this email and have
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3314#discussion_r102830609
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SimpleConsumerThread.java
Github user haohui closed the pull request at:
https://github.com/apache/flink/pull/3370
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3314#discussion_r102881264
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SimpleConsumerThread.java
GitHub user haohui reopened a pull request:
https://github.com/apache/flink/pull/3370
[FLINK-5710] Add ProcTime() function to indicate StreamSQL.
This is the commit we used internally -- There is no unit tests associated
with this PR. It simply serves as a reference point for #3302
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3314#discussion_r102299038
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SimpleConsumerThread.java
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3252#discussion_r100917108
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala
---
@@ -290,6 +291,15 @@ object
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3252
The v3 PR gets the best from both of the worlds -- the code generator will
throw exceptions if the queries actually execute the `rowtime()`.
Essentially it rewrites the project
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3252
Discussed with @fhueske offline. Thanks a lot for the comments. The V4 PR
implements the following:
* Rebased on top of #3101
* `LogicalWindowAggregateRule` implements `RelOptRule
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3314
[FLINK-3679] DeserializationSchema should handle zero or more outputs
This PR adds a new interface, `RichKeyedDeserializationSchema`, to enable
the deserializer to produce zero or more outputs
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3426
Sorry stuck with something. Will update the PR in a day or two.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3314
Thanks for the comments. Allowing `DeserializationSchema` to return `null`
sounds good to me. I'll update the PR accordingly.
---
If your project is set up for it, you can reply to this email
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3314
@rmetzger ping...
just wondering what do you think about all the approaches we have discussed
here? Your comments are appreciated.
---
If your project is set up for it, you can reply
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3426
[FLINK-5414] [table] Bump up Calcite version to 1.11
This PR resembles #3338 except that it canonizes the nullable types.
@wuchong can you please take a look?
You can merge this pull
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3314#discussion_r103339489
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/RichKeyedDeserializationSchema.java
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3123
[FLINK-5489] maven release:prepare fails due to invalid JDOM commentsâ¦
When I was trying to publish Flink to our internal artifactory, I found out
that maven release:prepare has failed because
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3604
[FLINK-5998] Un-fat Hadoop from Flink fat jar
This PR implements FLINK-5998.
It marks all Hadoop dependency in the dist jar as `provided` so that users
can plug in the jars from their own
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3604
@rmetzger -- thanks for the clarification. Do you think that it is
sufficient to mark the dependency of `flink-shaded-hadoop2` as provided and
produces a dedicated jar for it?
---
If your project
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3613
[FLINK-5829] Bump Calcite version to 1.12 once available.
This PR bumps the Calcite version from 1.11 to 1.12.
The main issue is that it conflicts with FLINK-4288, as the `tableMap`
field
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3648
[FLINK-6217] ContaineredTaskManagerParameters sets off-heap memory size
incorrectly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haohui
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3655
Looks good to me overall. Instead of changing in the normal code path,
maybe it is a little bit less intrusive to use Mockito to change the field? For
example:
```
JobArchiveFetcherTask
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3665#discussion_r109810006
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/LogicalWindowAggregateRule.scala
---
@@ -117,46 +119,86
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3665#discussion_r109857875
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/LogicalWindowAggregateRule.scala
---
@@ -117,46 +119,86
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3648
The test failure seems unrelated. Cannot reproduce locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3665
[FLINK-6011] Support TUMBLE, HOP, SESSION window in streaming SQL.
This PR adds supports for the `TUMBLE`, `HOP`, and `SESSION` windows in
Flink.
The work of supporting WindowStart
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3648
The failed tests are being addressed in FLINK-6175.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3613
The failed test is unrelated to the changes. @twalthr @fhueske can you
please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3712
[FLINK-6281] Create TableSink for JDBC.
This PR implements the `StreamTableSink` interface for the JDBC connectors
so that the streaming SQL APIs can directly interact with them.
You can merge
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3604
@rmetzger ping...would you mind taking a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3675
The PR looks pretty good. Thanks @fhueske for improving the documentation.
+1 (non-binding)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3675
Yes. I agree with you that `FLOOR` / `CEIL` are quite fragile and it is
much clearer to use the `TUMBLING` / `HOP` / `SESSION` constructs.
---
If your project is set up for it, you can reply
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3693
[FLINK-6012] [table] Support WindowStart / WindowEnd functions in streaming
SQL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haohui/flink
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3720
I hit the same problem on my Mac. Let me try it out later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user haohui reopened a pull request:
https://github.com/apache/flink/pull/3461
[FLINK-5954] Always assign names to the window in the Stream SQL API.
Please see jira for more details.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user haohui closed the pull request at:
https://github.com/apache/flink/pull/3461
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3461
Sorry for the late response. This is a prerequisite step for FLINK-6012 --
translating the group auxiliary functions (e.g., `TUMBLE_START`) to the
corresponding Flink expressions (e.g., `WindowStart
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3314
Yes totally agree. Thanks very much for taking the time to review the PRs.
Will do it next time.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3461
[FLINK-5954] Always assign names to the window in the Stream SQL API.
Please see jira for more details.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3426
Fix the unit tests.
There are two additional changes:
1. There are precision differences when converting `double` to
`BigDecimal`. Fix the unit tests.
2. When registering UDFs
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3314
CI failed in one of the group as the group was timed out. The specific
group was not timed out in the last run.
@tzulitai can you please take another look? Thanks
---
If your project is set
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3426
@twalthr can you please take another look? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3675
Thanks for the PR! It looks good to me overall. One problem is that
`dataSet.LogicalWindowAggregateRule` has duplicated quite a bit of code in the
`dataStream.LogicalWindowAggregateRule
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4373#discussion_r130789743
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/sql/CorrelateTest.scala
---
@@ -43,7 +43,7 @@ class CorrelateTest
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4373#discussion_r130794757
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala
---
@@ -355,26 +355,36 @@ case class TemporalOverlaps
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/4373
@dianfu thanks for the investigation! It turns out that it no longer
requires copying {{PushProjector}} after rebasing to the latest tip. Updated
the PR to address the issue.
---
If your project
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4373#discussion_r130789546
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java
---
@@ -1039,7 +1039,7 @@ public boolean
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r126870195
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -110,6 +110,11 @@ under the License.
compile
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r126870280
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -2008,6 +2008,33 @@ class CodeGenerator
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/4078
@fhueske @twalthr please take another look. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/4373
[FLINK-6429] [table] Bump up Calcite version to 1.13.
This PR bumps upgrades Calcite from 1.12 to 1.13. It includes fixes for
CALCITE-1884 and FLINK-7159. We can probably separate it to smaller PR
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3712
Thanks for your pointer of the prototype!
> Do you intend to provide exactly-once guarantees for arbitrary updates?
As I think about it a little bit more, I think it might make se
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3648
Totally Agree :-) @StephanEwen please take another look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3712
Thanks for the review. I'm not aware of the fact that OutputFormats are not
integrated with Flink's checkpointing mechanism.
To address this problem, maybe we can do something similar
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3765
Note that this PR contains minimal amount of tests. Would love the
feedbacks on what kinds of tests are required here.
---
If your project is set up for it, you can reply to this email and have your
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3764
[FLINK-6335] Parse DISTINCT over grouped windows in stream SQL.
This PR only supports parsing distinct aggregations over grouped windows.
It essentially allows the `DataStreamAggregateRule
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3765
[FLINK-6373] Add runtime support for distinct aggregation over grouped
windows
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haohui/flink
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3712
Correct me if I'm wrong -- will something like the following work?
```
+ @Override
+ public void snapshotState(FunctionSnapshotContext context) throws
Exception
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3767
[FLINK-6377] [table] Support map types in the Table / SQL API
This PR adds the supports of the map types in the Table / SQL API. It
covers both the parsing and the runtime.
One caveat
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3720
+1 (non-binding)
Tested on OSX Sierra. The documentation builds successfully.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3765
Updated the PR to codegen the parts used by distinct accumulator. Each
column is calculated independently.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3712#discussion_r132022891
--- Diff:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCAppendTableSink.java
---
@@ -0,0 +1,85 @@
+/*
+ * Licensed
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3712
Thanks @fhueske ! Updated the PR to address the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3879
[FLINK-6562] Support implicit table references for nested fields in SQL.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haohui/flink FLINK-6562
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3890
[FLINK-6569] flink-table KafkaJsonTableSource example doesn't work.
This PR makes the proposed changes on the document and changes the Java
unit tests to reflect the suggested usages of the API
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3748#discussion_r115927398
--- Diff: flink-connectors/flink-connector-cassandra/pom.xml ---
@@ -176,5 +176,23 @@ under the License
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3748#discussion_r115935549
--- Diff:
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3746
Any updates on this? Would love to try this out :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3748
@zentol can you please take another look? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3890
My understanding is that the snippet should only depend on the Java version
of the API (`ROW_NAMED` in flink-core) instead of the one written in Scala that
resides in `flink-table`. Correct
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3913
[FLINK-6574] Support nested catalogs in ExternalCatalog.
This PR extends the APIs of the `ExternalCatalog` to support arbitrary
nesting within external catalogs.
You can merge this pull request
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3748#discussion_r116092436
--- Diff:
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3748#discussion_r115861002
--- Diff: flink-connectors/flink-connector-cassandra/pom.xml ---
@@ -176,5 +176,23 @@ under the License
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3712
It is important to have some flexibility on the query as different SQL
engines have slightly different syntax on DML.
For example, SQLite supports INSERT OVERWRITE where MySQL supports
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3913#discussion_r117325036
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -37,25 +36,10 @@ import
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3746
@tzulitai we are interested in putting this feature in production soon. Do
you think whether it is possible for us to get a workaround for 1.3? Thanks.
---
If your project is set up for it, you can
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/4023
[FLINK-6780] [table] ExternalTableSource should add time attributes in the
row type
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haohui
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/4046
[FLINK-6749] [table] Table API / SQL Docs: SQL Page
This first iteration of the documentation. Comments are appreciated.
You can merge this pull request into a Git repository by running:
$ git
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3712#discussion_r120765156
--- Diff:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
---
@@ -202,14 +202,20 @@ public void
Github user haohui closed the pull request at:
https://github.com/apache/flink/pull/4046
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/4078
[FLINK-6693] [table] Support DATE_FORMAT function in the Table / SQL API.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haohui/flink FLINK
Github user haohui closed the pull request at:
https://github.com/apache/flink/pull/3890
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3712
@fhueske @zentol can you please take another look? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4638#discussion_r139532226
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
---
@@ -106,8 +240,191
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4638#discussion_r139553991
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
---
@@ -106,8 +240,191
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4638#discussion_r139625581
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
---
@@ -106,8 +240,191
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4638#discussion_r139629938
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
---
@@ -106,8 +240,191
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/4748
+1
It's very rare to see people using SerialGC in production environment.
Running the tests using SerialGC seems bringing in little values.
---
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4784#discussion_r143363766
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/GroupReduceNode.java
---
@@ -97,7 +97,7 @@ else
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4784#discussion_r143363777
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java
---
@@ -448,7 +448,7 @@ public boolean addTask(Task task
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4784#discussion_r143363797
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/history/ArchivedJson.java
---
@@ -55,6 +57,13 @@ public boolean equals(Object obj
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4784#discussion_r143363755
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/Utils.java ---
@@ -53,7 +53,7 @@ public static String getCallLocationName() {
public
1 - 100 of 287 matches
Mail list logo
