Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/616#issuecomment-96570629
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/616#issuecomment-96617964
@aljoscha Alright, will merge in a bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/642#discussion_r29447805
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -420,6 +428,60 @@ public JobSubmissionResult run(JobGraph jobGraph
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/642#discussion_r29447781
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -420,6 +428,60 @@ public JobSubmissionResult run(JobGraph jobGraph
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/642#issuecomment-97882155
Thank you for your pull request @rainiraj. I have made some comments. If
you addressed these we would be happy to merge your changes. Feel free to ask
if anything is unclear
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r29431402
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Backtracking.java
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r29431391
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Backtracking.java
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/640#discussion_r29431413
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -475,11 +479,21 @@ class JobManager(val flinkConfiguration
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/662#issuecomment-100805034
+1 links work again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/664#issuecomment-100891261
Very helpful utility. I think it's worth adapting all the examples if we
merge this. Removes a lot of unnecessary code and makes the examples more
readable.
May I
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/664#issuecomment-100897320
Thanks for clarifying. I agree that the parser in Apache Commons is not the
nicest...
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/664#issuecomment-101579496
Do you want to allow empty keys like in `-- value` or even `--`? I think
the parser should throw an exception in this case.
---
If your project is set up for it, you can
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/670
[QA] store messages in file instead of in the environment
Bash can run out of environment memory if environment variables store
too much data. When the memory is exceeded, bash can't run system
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/681
implement a simple session management
This pull request implements a rudimentary session management. Together
with the backtracking #640, this will enable users to successively submit jobs
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/686#issuecomment-103117477
- Yes, we can rename the variable to `wasExecuted`.
- I already added `print()` to the message because I anticipated it to
become eager :)
- I like your error message
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/685#issuecomment-103122448
IMHO the current behavior is well-defined. As you said, it's a question of
making a choice and sticking to it. I would add a case-insensitive check for
`true` but swallowing
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/685#issuecomment-103116663
Not sure if the users expects our parser to parse like
`Boolean.fromString(str)`. Because then, everything except `true` or `True`
would be false by default. For example
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/685#discussion_r30592154
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/BooleanParser.java ---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/685#discussion_r30592160
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/BooleanValueParser.java
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/685#issuecomment-103461860
- Rebased to current master.
- Now comparing on byte array instead of creating a String object.
- All checks are performed case-insensitive.
---
If your project
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/686#issuecomment-103463683
Pull request updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/685
[FLINK-2025] add support for booleans in csv parser
The following values are parsed as booleans:
true or 1 - true
false or 0 - false
You can merge this pull request into a Git repository
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/686
[FLINK-2026] add a flag to indicate previous executions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink count-collect-execute
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/606#issuecomment-93763019
:+1: Looks much much better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/595#discussion_r28579554
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -851,6 +862,7 @@ private void sendUpdateTaskRpcCall(final
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/595#discussion_r28579522
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -412,28 +436,141 @@ public ScheduleMode getScheduleMode
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/595#issuecomment-93948227
@hsaputra You're welcome. Thanks for the additional feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/604#issuecomment-93950872
That's a very nice graphical explanation of parallelism. :+1:
You could add another row with a job which changes parallelism in the
middle of the job. For example
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/608#issuecomment-93951094
Good catch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/606#issuecomment-93984370
Very difficult to visualize all the changes with screenshots but it takes a
few seconds to build the website. From your Flink source directory:
`git fetch https
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r28610554
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/FloatParser.java ---
@@ -48,7 +52,7 @@ public int parseField(byte[] bytes, int startPos, int
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r28610548
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/DoubleParser.java ---
@@ -49,7 +53,7 @@ public int parseField(byte[] bytes, int startPos, int
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r28610571
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/IntParser.java ---
@@ -37,7 +37,20 @@ public int parseField(byte[] bytes, int startPos, int
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r28610575
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/LongParser.java ---
@@ -33,6 +33,19 @@ public int parseField(byte[] bytes, int startPos, int
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r28610577
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/ShortParser.java ---
@@ -36,7 +36,20 @@ public int parseField(byte[] bytes, int startPos, int
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/571#issuecomment-90475934
Is the Hadoop configuration specified in the flink-conf.yaml loaded? If we
set `mapred.output.dir` then we should check for an existing config entry
beforehand. Otherwise, we
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/572#issuecomment-90863864
Looks good @chiwanpark. Could you add some documentation besides the java
doc? For example, here:
http://ci.apache.org/projects/flink/flink-docs-master/programming_guide.html
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/681#discussion_r30686981
--- Diff:
flink-runtime/src/test/scala/org/apache/flink/runtime/jobmanager/JobManagerITCase.scala
---
@@ -609,6 +612,98 @@ WordSpecLike with Matchers
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/681#issuecomment-103833918
Thanks for your feedback.
You introduce a separate session ID here. Why not use the JobID as the
session ID? This is how the logic in the JobManager (that attaches
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/681#discussion_r30686986
--- Diff:
flink-runtime/src/test/scala/org/apache/flink/runtime/jobmanager/JobManagerITCase.scala
---
@@ -609,6 +612,98 @@ WordSpecLike with Matchers
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-110076740
Thank you! Sorry for giving you a hard time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/794#issuecomment-109355690
I also added the necessary Maven configuration for the examples.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/762#issuecomment-109912571
Thank you for your contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/762#issuecomment-109907044
Thanks for the documentation. Could you open a JIRA to account for the
necessary changes in terms of extensibility?
---
If your project is set up for it, you can reply
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-110005201
No need for a vote. I agree with you that it is better to have only one
comment character. The cut command is also ok.
---
If your project is set up for it, you can reply
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-110002485
It can be a backwards-compatibility problem if users used some custom
comment character. Probably negligible. Concerning the second if statement:
Apparently, there was some
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-109998768
My bad. Sorry for bothering. I had slightly modified the example. We could,
however, just remove the if statement and it would work without creating an
external process
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-109988749
Are you sure? For me, it works in bash. Just tested under MacOS, Debian
Stable, and Ubuntu. It doesn't work in other shells which implement regexp
matching differently
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-109994289
mjsax@T420s-dbis-mjsax:~$ SLAVE=#comment; if [[ $SLAVE =~
^([0-9a-zA-Z/.-]+).$ ]] ; then echo ${BASH_REMATCH[1]}; else echo
missmatch; fi
missmatch
Exactly. So
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/811
[scripts] cleanup release script and make it more robust
- fail on command error
- make Mac OS X compatible
- fix uberjar file limit detection
- cleanup
You can merge this pull request
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/811#discussion_r32099679
--- Diff: tools/create_release_files.sh ---
@@ -36,57 +58,59 @@ if [[ `basename $CURR_DIR` != tools ]] ; then
exit 1
fi
+##
+## Variables
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/811#issuecomment-110643230
Thanks for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/811#discussion_r32095648
--- Diff: tools/create_release_files.sh ---
@@ -36,57 +58,59 @@ if [[ `basename $CURR_DIR` != tools ]] ; then
exit 1
fi
+##
+## Variables
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/811#discussion_r32095640
--- Diff: tools/create_release_files.sh ---
@@ -36,57 +58,59 @@ if [[ `basename $CURR_DIR` != tools ]] ; then
exit 1
fi
+##
+## Variables
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/762#issuecomment-108812916
:+1: This has been requested multiple times now. I would merge your pull
request. Can you add some documentation?
---
If your project is set up for it, you can reply
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/762#issuecomment-108845535
You can modify the documentation in the `docs/apis/programming_guide.md`
file.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/762#issuecomment-108845395
I'm talking about the user documentation. You could mention support for
gzip and add an example here:
http://ci.apache.org/projects/flink/flink-docs-master/apis
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/811#issuecomment-114153093
Thanks, merging then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/859
[FLINK-2235] fix calculation of free memory for local execution
The Java runtime may return Long.MAX_VALUE for a call to the maxMemory()
method of the Runtime class. In these cases, we simply use
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/859#discussion_r33036711
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/util/EnvironmentInformation.java
---
@@ -137,7 +137,13 @@ public static long
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/681#issuecomment-114517003
Closing this in favor of the new pull request #858.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mxm closed the pull request at:
https://github.com/apache/flink/pull/681
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/852#issuecomment-114058851
I would prefer deprecating it first and removing it in the next major
release. If we would do so we should create a JIRA issue to keep track of
removing it for the future
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/865#issuecomment-115167456
Thanks for adding tests. The changes look good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/852
[FLINK-2242] deprecate RemoteCollector interface and implementation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-2242
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/859#discussion_r33019549
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/util/EnvironmentInformation.java
---
@@ -137,7 +137,13 @@ public static long
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/858
[FLINK-2097] Implement job session management
This is a joint effort by @StephanEwen and me to introduce a session
management in Flink. Session are used to keep a copy of the ExecutionGraph in
the job
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/868#discussion_r33340726
--- Diff: tools/create_release_files.sh ---
@@ -138,7 +146,7 @@ make_binary_release() {
echo Files in uberjar: $NUM_FILES_IN_UBERJAR. Uberjar: $UBERJAR
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/868#issuecomment-115601791
@hsaputra This is just refactoring. I think your changes improve the
readability of the code. Like Ufuk mentioned, it does not necessarily make the
script more flexible. Due
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/868#discussion_r33340734
--- Diff: tools/create_release_files.sh ---
@@ -85,37 +87,43 @@ else
fi
+prepare() {
+ # prepare
+ git clone http://git-wip
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/824
[FLINK-2183][runtime] fix deadlock for concurrent slot release
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-2183
Alternatively
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/834#issuecomment-112114140
For instance, users could wonder that a DataSet containing null values
returns a different result for a count aggregation than for a call to the
`count()` method
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/834#issuecomment-112104910
I have a funny feeling that this might backfire. Is the null value policy
now to simply ignore them? :)
---
If your project is set up for it, you can reply to this email
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/819#issuecomment-111396844
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/829#issuecomment-111476805
Ah thanks for clarifying.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/829#issuecomment-111467471
Looks good but I found more old references in `table.md`:
```ack
54:val expr = input.toTable
70:val input1 = env.fromElements(...).toTable('a, 'b)
71:val
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/822#issuecomment-111852542
Right you are. I have pushed a fix to the release-0.8 branch. Like in the
current master, the script will always point to the website's script.
---
If your project is set
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/838#issuecomment-112130543
I think this is by chance. Here it passes:
https://travis-ci.org/mxm/flink/builds/66877782
---
If your project is set up for it, you can reply to this email and have your
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/838#issuecomment-112134703
And here as well: https://travis-ci.org/mxm/flink/builds/66881439
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/838#issuecomment-112129153
Agreed, a bit misleading name. Changed it to `failAppllication`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/732
[core] cleanup tests for FileInputFormat
followup of f2891ab857e00bc70eb025bb430f46f4f58355a5
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/876#discussion_r33657185
--- Diff:
flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
---
@@ -121,6 +121,7 @@ public void testDetachedMode
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/876#discussion_r33657128
--- Diff: docs/setup/yarn_setup.md ---
@@ -100,11 +100,13 @@ Usage:
-D argDynamic properties
-d,--detached
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/876#issuecomment-117663964
:+1: Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/876#discussion_r33662529
--- Diff: docs/setup/yarn_setup.md ---
@@ -100,11 +100,13 @@ Usage:
-D argDynamic properties
-d,--detached
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/876#issuecomment-117630964
Looks good except for the test case comment I made.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/876#discussion_r33671148
--- Diff:
flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
---
@@ -121,6 +121,7 @@ public void testDetachedMode
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/699#issuecomment-104561157
Congratulations on your first contribution @nikste!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/712#issuecomment-105453281
+1 looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/689#issuecomment-105458254
+1 to merge f125e16ab3b3bf677ace6d9fec4dfec2c3a1a5a3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/718#discussion_r31016976
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/memory/MemoryManagerLazyAllocationTest.java
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/718#issuecomment-105462206
+1 looks solid.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/681#issuecomment-104707707
I've updated the pull request.
- The `JobID` is now propagated from the `ExecutionEnvironment` to the
`JobGraph`. That's why a setter for setting the `JobID
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/966#issuecomment-130324770
Rich does not refer to the number of methods but the fact that it has the
RuntimeContext available. All non-rich variants do not get state inserted. This
follows a naming
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/992#discussion_r36955259
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/992#discussion_r36955189
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/992#discussion_r36955316
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/992#discussion_r36955334
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/992#discussion_r36955221
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/992#issuecomment-130644950
`StringBuilder` is only for single-threaded while `StringBuffer` enables
multi-thread access. If you use `StringBuffer` in a single-threaded scenario it
has worse
101 - 200 of 1762 matches
Mail list logo
