Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45966621
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkOutputFieldsDeclarer.java
---
@@ -20,11 +20,9 @@
import
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45967336
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/FlinkTopologyContext.java
---
@@ -27,13 +27,12 @@
import
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1409#discussion_r45970372
--- Diff:
flink-yarn-tests/src/main/java/org/apache/flink/yarn/UtilsTest.java ---
@@ -97,6 +98,18 @@ public void tooMuchCutoff
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1409#discussion_r45970591
--- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java ---
@@ -221,4 +210,22 @@ public static void addToEnvironment(Map<String,
String> envir
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1409#issuecomment-159893248
Looks good except for some minor issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45971476
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java
---
@@ -44,16 +45,30 @@
/** The schema (ie, ordered
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45971856
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/print/PrintSampleStream.java
---
@@ -0,0 +1,61 @@
+/**
+ * Licensed
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r46040790
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-160141917
This currently only works when checkpointing is turned on. If checkpointing
is turned off, not only the number of queued messages will grow unbounded, but
also the messages
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r46048074
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-160146335
I'm creating a unit test for the source which mocks the RabbitMQ classes. I
would like to merge your pull request with a few changes for both the
fault-tolerant and the non
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r46054711
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/1404
[github] change tab size to 4 spaces
The default tab size on GitHub is 8 spaces. This change decreases the
tab size to 4. I think this will make reviewing of code on GitHub easier.
Left
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45854121
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -150,7 +153,7 @@ static synchronized
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-160988124
Thank for your contribution @HilmiYildirim. I've merged your commit and put
some changes on top of it in 9215b72422d3e638fe950b61fa01f2e4e04981a0.
---
If your project
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46277213
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/BoltWrapperTest.java
---
@@ -265,12 +264,12 @@ public void testOpen() throws
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46278994
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -193,24 +189,22 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46279370
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/exclamation/ExclamationWithBolt.java
---
@@ -72,7 +71,7 @@ public static void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46276898
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -224,7 +224,7 @@ static synchronized
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1398#issuecomment-160982088
I've addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1344#issuecomment-157711251
I'm assuming everyone is ok with this workaround for now. If not please
speak up. I'll merge this in time for 0.10.1.
---
If your project is set up for it, you can reply
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1375#issuecomment-157736688
From what I've seen so far, users are very puzzled about execute() after
collect(). This was even more of a problem because we once had this in our
quickstart examples
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1360#issuecomment-158009498
True. That's how it is handled on the batch side. Not sure about this
behavior though. If a user sets a default parallelism but uses operators with
`parallelism
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1360#issuecomment-158334929
I think we agree that we want to set the number of task slots to the
maximum parallelism instead of the default one. I'll merge this later on.
---
If your project is set
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1360#issuecomment-158024467
Alright. I will push the original pull request version again which uses the
max parallelism of all operators. Further, I will open a separate JIRA for the
batch side change
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1360#issuecomment-158032582
Just checked. The batch side always uses the maximum parallelism as the
number of task slots (if they are not set explicitly). Till and me actually
thought differently. So
Github user mxm commented on the pull request:
https://github.com/apache/flink/commit/bf29de981c2bcd5cb5d33c68b158c95c8820f43d#commitcomment-14559720
You can now get the latest nightly binaries here:
http://flink.apache.org/contribute-code.html#snapshots-nightly-builds
---
If your
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1337#issuecomment-158763006
@chiwanpark +1 for merging!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1387#discussion_r45559955
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -118,6 +119,11 @@ static synchronized
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1387#issuecomment-158765658
Maybe a stupid question but why don't you send the operator name along with
the BoltWrapper? Then there is no need to extract it from the Flink task name.
---
If your
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1387#discussion_r45559371
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -209,12 +209,8 @@ public void open() throws Exception
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/1398
[FLINK-2837][storm] various improvements for Storm compatibility
This pull request contains various fixes. Most prominently, the parsing
logic for Storm topologies has been changed to support multiple
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45740238
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/join/SingleJoinExample.java
---
@@ -0,0 +1,86 @@
+/**
+ * Licensed
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45741402
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/join/SingleJoinExample.java
---
@@ -0,0 +1,86 @@
+/**
+ * Licensed
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45741186
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45743505
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1354#issuecomment-159292623
Would make sense to merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45747566
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728796
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -40,16 +43,17 @@ public BoltFileSink(final
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45722053
--- Diff: docs/apis/storm_compatibility.md ---
@@ -57,20 +57,22 @@ See *WordCount Storm* within
`flink-storm-examples/pom.xml` for an example how t
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728386
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -150,7 +153,7 @@ static synchronized
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728418
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -187,14 +190,15 @@ static synchronized
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728523
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728889
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FileSpout.java
---
@@ -38,6 +38,8 @@
protected String path = null
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45729000
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FiniteFileSpout.java
---
@@ -32,46 +23,17 @@
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728165
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkClient.java
---
@@ -183,10 +183,10 @@ public void submitTopologyWithOpts(final
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728214
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkLocalCluster.java
---
@@ -48,12 +49,10 @@
private static final Logger
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728168
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkClient.java
---
@@ -183,10 +183,10 @@ public void submitTopologyWithOpts(final
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45729369
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -75,11 +78,13 @@
*
* @param bolt
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728317
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,468 @@
* See the License
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728366
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java
---
@@ -44,6 +45,21 @@
/** The schema (ie, ordered
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728576
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/StormTupleTest.java
---
@@ -595,7 +593,7 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728678
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -18,20 +18,23 @@
package
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45733449
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/StormTupleTest.java
---
@@ -595,7 +593,7 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45734220
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FileSpout.java
---
@@ -38,6 +38,8 @@
protected String path = null
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45733689
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,468 @@
* See the License
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45734177
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FiniteFileSpout.java
---
@@ -32,46 +23,17 @@
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45734441
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -18,20 +18,23 @@
package
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45733403
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -187,14 +190,15 @@ static synchronized
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45733816
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -75,11 +78,13 @@
*
* @param bolt
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45733908
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,468 @@
* See the License
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45734323
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -40,16 +43,17 @@ public BoltFileSink(final
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1360#issuecomment-158049463
Exactly. But that makes sense, right? If the users explicitly sets the
number of task slots, we shouldn't change the number of task slots
automatically.
---
If your
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2085
[FLINK-3937] programmatic resuming of clusters
These changes are based on #1978 and #2034. More specifically, they port
resuming of running Yarn clusters from #2034 to the refactoring of #1978
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2082
[FLINK-4031] include sources in Maven snapshot deployment
As per user request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-4031
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2034
Thanks for the update!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66628410
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -980,110 +845,41 @@ protected ActorGateway
getJobManagerGateway
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66626078
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -1275,33 +1071,16 @@ else if (new
File(CONFIG_DIRECTORY_FALLBACK_2).exists
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66626302
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -980,110 +845,41 @@ protected ActorGateway
getJobManagerGateway
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805492
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -300,18 +309,82 @@ public static boolean allocateResource(int
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805479
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClient.java ---
@@ -211,18 +185,45 @@ public void run() {
Runtime.getRuntime
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805499
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -300,18 +309,82 @@ public static boolean allocateResource(int
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805417
--- Diff: docs/apis/cli.md ---
@@ -105,6 +105,10 @@ The command line can be used to
./bin/flink list -r
+- List running Flink jobs
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805455
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -415,62 +513,83 @@ public int run(String[] args
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805382
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClient.java ---
@@ -211,18 +185,45 @@ public void run() {
Runtime.getRuntime
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805953
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CustomCommandLine.java
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2085
Thanks for the review! I've addressed almost all your comments and will
ping you once the PR get updated. Some more comments:
> (1) When listing the yarn-session.sh cli options, I could not
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66806299
--- Diff: docs/apis/cli.md ---
@@ -252,6 +256,12 @@ Action "list" lists running and scheduled programs.
con
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805706
--- Diff: docs/setup/yarn_setup.md ---
@@ -143,6 +143,34 @@ Note that in this case its not possible to stop the
YARN session using Flink.
Use the YARN
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805960
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java
---
@@ -181,11 +198,30 @@ public boolean getPrintStatusDuringExecution
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2085
I've addressed your comments in another commit. I'd be delighted if you
could try out the changes again!
- remove legacy code from CliFrontend
- change activation code of CustomCommandLine
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r67003363
--- Diff: docs/apis/cli.md ---
@@ -252,6 +256,12 @@ Action "list" lists running and scheduled programs.
con
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2101
[FLINK-4030] Revert Surefire version to 2.18.1
The ScalaShellITCase sometimes gets stuck before test execution with no
output
in the logs. We ran about a hundred builds against Surefire 2.18.1
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2101
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2085
Rebased to the latest master and refined the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1978#issuecomment-222480544
Thanks for your comments @EronWright. This the the first refactoring of the
client code of both cluster related and job submission related matters. It is a
very good
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2033#issuecomment-222634611
Thanks for reviewing. Merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2042#issuecomment-222138890
+1 Looks good to me.
Only wondering, how much will it affect our build time? We might want to
run this in a dedicated profile.
---
If your project is set up
Github user mxm commented on the pull request:
https://github.com/apache/flink/commit/5a7f4e3395bfb06da496584be88501c328f6ac1d#commitcomment-17643795
@StephanEwen I think this has been left there on purpose because the
ExecutionConfig is declared Public and this would break
Github user mxm commented on the pull request:
https://github.com/apache/flink/commit/bf256c7fbe05accdadc8470013879f567341d1aa#commitcomment-17643841
In
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceID.java:
In
flink-runtime/src/main/java
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2037#issuecomment-222113016
Rebased to the latest master. Will merge once the tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2042#issuecomment-222132940
Thanks for the pull request! Could you elaborate on how and where this will
be integrated with our CI or release process?
---
If your project is set up for it, you can
Github user mxm commented on the pull request:
https://github.com/apache/flink/commit/bf256c7fbe05accdadc8470013879f567341d1aa#commitcomment-17643812
In
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceID.java:
In
flink-runtime/src/main/java
Github user mxm commented on the pull request:
https://github.com/apache/flink/commit/bf256c7fbe05accdadc8470013879f567341d1aa#commitcomment-17644775
In
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceID.java:
In
flink-runtime/src/main/java
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2045
[FLINK-3981] don't log duplicate TaskManager registrations
Duplicate TaskManager registrations shouldn't be logged with Exceptions
in the ResourceManager. Duplicate registrations can happen
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2046
[FLINK-3982] let only ResourceManager of leading JobManager register
In HA mode, multiple ResourceManagers may register at the leading
JobManager. They register one after another at the JobManager
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2037
[FLINK-3972] subclasses of ResourceID may not to be serializable
WorkerTypes are currently subclasses of ResourceID. ResourceID implements
Serializable but not necessarily its subclasses. This may lead
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2056
Thanks for fixing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1978
@rmetzger I've updated the pull request and would like to get your opinion
on it again. I've addressed all your comments. Specifically, I've removed all
Yarn code from the CliFrontend. I've
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r65349622
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClient.java ---
@@ -211,14 +191,41 @@ public void run() {
Runtime.getRuntime
701 - 800 of 1762 matches
Mail list logo
