Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200666957
--- Diff:
flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/JsonSchemaConverterTest.java
---
@@ -31,7 +31,7 @@
import static
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200597649
--- Diff:
flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka010AvroTableSource.java
---
@@ -46,7
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200670109
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/formats/TableFormatFactoryService.scala
---
@@ -0,0 +1,245
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200662577
--- Diff:
flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroRowFormatFactoryTest.java
---
@@ -0,0 +1,91
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200662272
--- Diff:
flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroRowFormatFactoryTest.java
---
@@ -0,0 +1,91
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200653352
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceFactoryTestBase.java
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200983274
--- Diff:
flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka010JsonTableSource.java
---
@@ -32,7
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201016561
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/formats/TableFormatFactoryServiceTest.scala
---
@@ -0,0 +1,122
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200999523
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/TableSourceDescriptorTest.scala
---
@@ -0,0 +1,133
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201001341
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/TableSourceDescriptorTest.scala
---
@@ -0,0 +1,133
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200999721
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/TableSourceDescriptorTest.scala
---
@@ -0,0 +1,133
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200998068
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/formats/TableFormatFactoryService.scala
---
@@ -0,0 +1,245
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201017476
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/formats/TableFormatFactoryServiceTest.scala
---
@@ -0,0 +1,122
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201019023
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/formats/TableFormatFactoryServiceTest.scala
---
@@ -0,0 +1,122
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201025967
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/formats/TableFormatFactoryService.scala
---
@@ -0,0 +1,245
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201028445
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/formats/TableFormatFactory.scala
---
@@ -0,0 +1,85
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201003278
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/formats/TableFormatFactoryServiceTest.scala
---
@@ -0,0 +1,122
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200999798
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/TableSourceDescriptorTest.scala
---
@@ -0,0 +1,133
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201026925
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/formats/TableFormatFactoryServiceTest.scala
---
@@ -0,0 +1,122
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201002716
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/formats/TableFormatFactoryService.scala
---
@@ -0,0 +1,245
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200982725
--- Diff:
flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka010AvroTableSource.java
---
@@ -46,7
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200990785
--- Diff:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowFormatFactory.java
---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201030536
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/sources/TableSourceFactoryServiceTest.scala
---
@@ -52,21 +57,33 @@ class
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201026527
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/formats/TableFormatFactoryServiceTest.scala
---
@@ -0,0 +1,122
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200991456
--- Diff:
flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroRowFormatFactoryTest.java
---
@@ -0,0 +1,91
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200989972
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceFactoryTestBase.java
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201008748
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/formats/TableFormatFactoryService.scala
---
@@ -0,0 +1,245
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201027539
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/formats/TableFormatFactoryServiceTest.scala
---
@@ -0,0 +1,122
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200997560
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/formats/TableFormatFactoryService.scala
---
@@ -0,0 +1,245
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200999836
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/TableSourceDescriptorTest.scala
---
@@ -0,0 +1,133
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200993332
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
---
@@ -110,16 +111,44 @@ abstract class
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201003919
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/formats/TableFormatFactoryServiceTest.scala
---
@@ -0,0 +1,122
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201029821
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/formats/utils/TestTableFormatFactory.scala
---
@@ -0,0 +1,60
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201017796
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/formats/TableFormatFactoryServiceTest.scala
---
@@ -0,0 +1,122
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201019886
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/formats/TableFormatFactoryServiceTest.scala
---
@@ -0,0 +1,122
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201030190
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/sources/TestWildcardFormatTableFactory.scala
---
@@ -0,0 +1,56
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200992037
--- Diff:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowFormatFactory.java
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200987026
--- Diff:
flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka010TableSource.java
---
@@ -18,48
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200998882
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSourceFactoryService.scala
---
@@ -139,9 +139,14 @@ object
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200988428
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
---
@@ -55,50
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201020483
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/formats/utils/TestAmbiguousTableFormatFactory.scala
---
@@ -16,22 +16,32
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201021369
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/formats/utils/TestAmbiguousTableFormatFactory.scala
---
@@ -16,22 +16,32
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r200998167
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/DefinedFieldMapping.scala
---
@@ -50,7 +50,8 @@ trait
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/6299
[FLINK-9713][table][sql] Support versioned join in planning phase
## What is the purpose of the change
This PR introduces provides a way to define Table Version Functions in
Table API
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/5952
[FLINK-9287][kafka] Properly clean up resources in non EXACTLY_ONCE
FlinkKafkaProducer011
Previously FlinkKafkaProducer was not being closed for AT_LEAST_ONCE and
NONE Semantics when closing
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5923#discussion_r185819830
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
---
@@ -228,20 +228,19 @@ public void setupPartition
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5923#discussion_r185817506
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
---
@@ -228,20 +228,19 @@ public void setupPartition
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/5977
[FLINK-9295][kafka] Fix transactional.id collisions for
FlinkKafkaProducer011
Previously if there were two completely independent FlinkKafkaProducer011
data sinks in the job graph, their
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5977#discussion_r187592761
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/util/MockStreamConfig.java
---
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5977#discussion_r187645022
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
---
@@ -837,7
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5977#discussion_r187646041
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/functions/RuntimeContext.java
---
@@ -71,6 +71,17 @@
@PublicEvolving
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/6031
[FLINK-9386] Embed netty router
This replaces netty-router dependency with our own version of it, which is
simplified and adds guarantees about order of matching router patterns.
This is
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/5977
I have removed `getOperatorUniqueID()` from `RuntimeContext` and our
`FlinkKafkaProducer011` is now casting `RuntimeContext` to
`StreamingRuntimeContext`.
---
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5983#discussion_r189244151
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/async/TimeoutAwareAsyncFunction.java
---
@@ -0,0 +1,41
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6031#discussion_r190272895
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/MethodlessRouter.java
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6031#discussion_r190273990
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/RouterHandler.java
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6031
Thanks for the review and manual checks! I either addressed your comments
in fixup commit and left comment responses otherwise.
> Do we file a follow up ticket to remove netty-router f
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6031
Thanks :) I have squashed commits and rebased the PR on latest master.
---
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/6071
[FLINK-3952][runtine] Upgrade to Netty 4.1
This PR adjusts our code to work with Netty 4.1. It also includes possible
bug fix to file uploading cleanup in FileUploadHandler and HttpRequestHandler
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5983#discussion_r190553816
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/async/TimeoutAwareAsyncFunction.java
---
@@ -0,0 +1,41
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r190554721
--- Diff: pom.xml ---
@@ -308,7 +308,7 @@ under the License.
errors.
[1] https
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5983#discussion_r190567872
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/async/TimeoutAwareAsyncFunction.java
---
@@ -0,0 +1,41
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/6072
[hotfix][doc] Mention AggregationEnabled setting in kinesis docs
This change only clarifies the documentation for `FlinkKinesisProducer`
(clarification suggested by a user via mailing list).
You
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6073
Does this fix or just improves dependency convergence? I'm asking because
dependencies of `flink-table` (like `flink-runtime`) still have convergence
errors.
---
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6073
Ok, I see it now. This pull request's title is just a tad misleading (it
doesn't fix all of the convergence for this module, just some selection of them)
---
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/6076
[hotfix][docs] Specify operators behaviour on processing watermarks
This PR is a simple documentation improvement
You can merge this pull request into a Git repository by running:
$ git pull
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6073
Converging dependencies by enforcing their versions in root's pom
`dependencyManagement` section is the way that we have chosen previously, so it
would be more consistent.
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6076#discussion_r190858003
--- Diff: docs/dev/event_time.md ---
@@ -219,4 +219,17 @@ with late elements in event time windows.
Please refer to the [Debugging Windows & E
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r190884312
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java ---
@@ -247,7 +249,15 @@ public void shutdown(Time timeout
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6071
Dead lock visible in failed travis is unrelated to this change
(https://issues.apache.org/jira/browse/FLINK-9439)
---
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6071
@zentol I have also fixed added a test to cover
https://github.com/apache/flink-shaded/issues/30 in the second commit
---
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6076
Thanks for the feedback @eliaslevy. Pushed one extra commit about idling
sources.
---
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r191683459
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/runtime/NettyEpollITCase.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r191684561
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/runtime/NettyEpollITCase.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r191685731
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBuffer.java
---
@@ -215,16 +242,33 @@ protected void _setMedium
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r191700895
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/ReadOnlySlicedNetworkBuffer.java
---
@@ -75,12 +75,12 @@ private
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r191700141
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBuffer.java
---
@@ -424,6 +480,19 @@ public int setBytes(int
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r191685431
--- Diff: pom.xml ---
@@ -300,15 +300,7 @@ under the License.
org.apache.flink
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r191757079
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorTest.java
---
@@ -212,6 +212,20 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r191768672
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/async/AsyncFunction.scala
---
@@ -46,4 +48,16 @@ trait AsyncFunction
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r191767070
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorTest.java
---
@@ -648,6 +662,52 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r191760364
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorTest.java
---
@@ -212,6 +212,20 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r191768245
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/AsyncDataStream.scala
---
@@ -71,6 +71,9 @@ object AsyncDataStream
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/5500
If this security concern is an issue, maybe in that case `getCurrentKey()`
should take `object-reuse` into account, and if `object-reuse` is set to false,
make a defensive copy of the key on
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5583#discussion_r171174932
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java
---
@@ -189,11 +189,11 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5581#discussion_r171181261
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SubpartitionTestBase.java
---
@@ -182,7 +182,7 @@ private static void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5588#discussion_r171214062
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/serialization/EventSerializerTest.java
---
@@ -117,49 +116,55 @@ public
Github user pnowojski closed the pull request at:
https://github.com/apache/flink/pull/5557
---
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/5572
Rebased. Lets merge with green travis.
---
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/5572
Thanks for merging :)
---
Github user pnowojski closed the pull request at:
https://github.com/apache/flink/pull/5572
---
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/5607
[hotfix][docs] Drop the incorrect parallel remark in windowAll
This is a simple documentation fix. Parallel remark for windowAll is not
true according to @aljoscha .
You can merge this pull
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5607#discussion_r171523085
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java
---
@@ -718,8 +718,7 @@ public ExecutionConfig
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5317#discussion_r171525131
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -269,15 +269,21 @@
public static final
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5317#discussion_r166921740
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/SequenceNumberingViewReader.java
---
@@ -77,14 +78,35 @@ void
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/5607
Thanks :)
---
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/5708
[FLINK-8984][network] Drop taskmanager.exactly-once.blocking.data.enabled
config option
Previously there were twe options:
taskmanager.network.credit-based-flow-control.enabled
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/5710
[FLINK-8948][runtime] Fix IllegalStateException when closing StreamTask
All methods in
org.apache.flink.streaming.runtime.tasks.OperatorChain#releaseOutputs shouldn't
throw any exception
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/5710
@NicoK I have updated PR
---
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5710#discussion_r175398935
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferBuilder.java
---
@@ -99,10 +99,11 @@ public void commit
601 - 700 of 902 matches
Mail list logo
