Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2054#discussion_r65250708
--- Diff:
flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2057
[hotfix] Fix JSONDeserializationSchema for Kafka; ParameterTool usability
The JSONDeserializationSchema was implementing the
KeyedDeserializationSchema. However, it was not using the key or any
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-55208
Okay, I've filed https://issues.apache.org/jira/browse/FLINK-3983. However,
before you jump onto it: While I wrote the JIRA, I was actually wondering
whether it makes
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-52000
I have to admit that these changes were not necessary:
https://github.com/apache/flink/commit/23d1cba72859339bd3ee8f877b031353380c87fb#diff
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2042#issuecomment-48940
Okay, let me explain:
I decided to remove the field, even though its public, and strictly
speaking a breaking API change. However, it was a mistake to mark
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2042#issuecomment-222185242
@zentol I think your concern was addressed here:
https://github.com/apache/flink/pull/2042/commits/c20efc6cda6ff705c72924213c90f618f7f40e51
Thanks all
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2042#issuecomment-222139308
Thank you for the review.
Its very low overhead since the 1.0.0 jar's are cached in the local .m2
directory and the tool is doing the check really fast
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-222136775
Thanks a lot for addressing the comments.
I'll push the changes to travis, once its green I'll merge them.
---
If your project is set up for it, you can reply
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2042#issuecomment-222134657
The plugin runs with every mvn verify call.
For each maven module, it will download the last stable release (in this
case 1.0.0) and check it against the build
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2042
[FLINK-3129] Add tooling to ensure interface stability
This pull request adds a maven module for ensuring interface stability
(japicmp).
I needed to revert some of the changes since 1.0
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1791#issuecomment-222113705
Closing this PR in favor of a new one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rmetzger closed the pull request at:
https://github.com/apache/flink/pull/1791
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1813#issuecomment-221913785
Actually, its quite easy to implement a redis sink yourself.
Check out the `RedisResultSink` in this example:
https://github.com/dataArtisans/yahoo-streaming
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2016#discussion_r64767022
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2031#issuecomment-221886697
Hi @mans2singh,
thanks a lot for this contribution. I wonder what's your motivation to
implement a flink --> rethinkdb connector? I'm asking because the Fl
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-221885858
Sure, no problem at all. Its just for my own time allocation. Thanks for
the quick response.
---
If your project is set up for it, you can reply to this email
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-221882616
Just for my planning, when do you think you'll find time to address the
remaining issues?
---
If your project is set up for it, you can reply to this email and have
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2031#discussion_r64709407
--- Diff: flink-streaming-connectors/flink-connector-rethinkdb/pom.xml ---
@@ -0,0 +1,100 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2026#issuecomment-221247552
The fix looks okay.
However, can you add a rule to the checkstyle config in
"tools/maven/checkstyle.xml" to ensure that the build will fail if people
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2016#discussion_r64257599
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-220997800
The change looks good overall. I think we can soon merge it.
Please let me know once you've addressed my comments.
---
If your project is set up for it, you
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2016#discussion_r64231495
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2016#discussion_r64230633
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2016#discussion_r64227104
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-220986366
I noticed that you didn't update the documentation of the Kinesis Producer.
Can you update the page to reflect the changed usage.
The file is located here: docs
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2013#issuecomment-220944377
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-220782124
Thanks a lot for your contribution. I quickly scrolled over the changes and
I like them at first sight.
I assigned the JIRA issue to you. I hope I can review
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1978#issuecomment-219992759
Thank you for working on this!
The flink-client is pretty complicated and I like this pull request as it
is reducing the complexity.
Maybe (depending
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63682705
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -65,31 +73,25 @@
/**
* Encapsulates the functionality
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63681528
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClient.java ---
@@ -211,14 +191,41 @@ public void run
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63680404
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -830,53 +797,30 @@ else if (result instanceof DisposeSavepointFailure
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1978#issuecomment-219987643
Forgetting an argument leads to a NPE
```
robert@cdh544-master:~/flink/build-target$ ./bin/flink run -m yarn-cluster
./examples/batch/WordCount.jar
YARN
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1978#issuecomment-219987024
After the shutdown, I got the following exception
```
2016-05-18 10:26:07,076 INFO org.apache.flink.yarn.ApplicationClient
- Disconnect
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63679526
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -100,6 +102,9 @@
*/
private JobID lastJobID
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63678293
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -65,31 +73,25 @@
/**
* Encapsulates the functionality
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63677456
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -20,8 +20,6 @@
--- End diff --
The CliFrontend
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1992#issuecomment-219792375
Thanks a lot for fixing these spelling mistakes!
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1982#issuecomment-219713912
I like the pull request! (You updated the docs, the PR describes the
changes).
+1 to merge
---
If your project is set up for it, you can reply to this email
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1993#issuecomment-219698527
Thank you for opening a pull request.
@gyfora can you validate if this is the exception you'd expected?
---
If your project is set up for it, you can reply
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1995#issuecomment-219639748
The change looks good. +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-219043000
As discussed in the JIRA, I'm going to follow the "relocation approach" for
fixing the protobuf issue. But we won't release the kinesis connector to mv
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1972#issuecomment-218087373
Hi,
thank you for opening a pull request about this. I think the change is good
to merge. One thing I'm wondering is: why do you only include on class (or a
set
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1947#issuecomment-217389510
Okay. I think we need to support multiple instances of the same job on a
TaskManager.
---
If your project is set up for it, you can reply to this email and have your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1962#issuecomment-217373539
How did you test the code you've implemented in this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1947#issuecomment-217214295
I'm just assuming its the missing "close()" call's I've commented already
causing this issue.
I just tried adding some custom metrics:
```ja
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1947#issuecomment-217213101
Is it possible that submitting the same job two times doesn't work?
```
./bin/flink run ./examples/streaming/SocketWindowWordCount.jar --port 54323
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-217202359
Yep, that's the right branch.
I tried working on different approaches, but its just an annoying problem
with protobuf.
I'll probably work on it tomorrow again
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1771#issuecomment-217171304
I just tried the PR, but the recovery after a failure doesn't seem to work:
```
java.lang.RuntimeException: Error triggering a checkpoint as the result
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1771#issuecomment-217160848
I'll test the PR again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1962#discussion_r62174087
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1954#issuecomment-217126222
Thanks a lot for opening a pull request!
I'm sorry that nobody from the community responded to it yet. Its just that
we are a bit overloaded currently
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1962#issuecomment-217126041
The change is missing documentation updates & test cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1962#issuecomment-217125875
Thank you for opening the pull request.
I made some inline comments.
I don't think the proposed changes fix the issue described in the JIRA.
I would
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1962#discussion_r62173382
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1962#discussion_r62173042
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1962#discussion_r62172954
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1962#discussion_r62172911
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1962#discussion_r62172611
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1962#discussion_r62172571
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-216512837
I'm currently working on a custom branch based on this pull request.
It seems that we are running into some dependency issues when using the
kinesis-connector
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1953#issuecomment-216251703
Overall, the code looks good. I forgot that we have the avro dependency in
by default ;)
I had one minor commit regarding early input validation, other than
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1953#discussion_r61745619
--- Diff:
flink-streaming-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/AvroKeyValueSinkWriter.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1920#issuecomment-215717429
Sorry for the delay. The Flink community is receiving many contributions,
that causes sometimes long review times.
I think we can merge the change once @greghogan
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1947#discussion_r61443660
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
@@ -683,6 +688,9 @@ else if (STATE_UPDATER.compareAndSet
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1947#discussion_r61440312
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
@@ -683,6 +688,9 @@ else if (STATE_UPDATER.compareAndSet
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1947#discussion_r61439797
--- Diff: flink-metrics/flink-metrics-ganglia/pom.xml ---
@@ -0,0 +1,84 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1920#discussion_r61437731
--- Diff:
flink-batch-connectors/flink-avro/src/main/java/org/apache/flink/api/java/io/AvroInputFormat.java
---
@@ -119,12 +138,14 @@ public E nextRecord(E
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-215402825
I'm currently busy with some other ongoing tasks. I hope to get back to
this PR soon.
---
If your project is set up for it, you can reply to this email and have your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1764#issuecomment-215399436
One minor remark for the future (I'll fix it when merging): Please include
the JIRA ID into the commit message.
I'm going to merge this change once travis
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1764#discussion_r61411342
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/AscendingTimestampExtractor.java
---
@@ -20,123 +20,18
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60908159
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1837#issuecomment-214246110
I'll merge it into 1.0.3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-213913449
The build failure is unrelated to your changes. Its just an instability of
the testing infrastructure.
---
If your project is set up for it, you can reply
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60825706
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60825677
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-213581650
Regarding the Jackson / dependency issue: You don't need to worry about it
know. I'll take another look at the problem and make sure it'll work once we
merge
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60799474
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60799388
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60799066
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60797751
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-213530765
Hi,
Cool, if you have time to adress them, go ahead :)
Thanks a lot for doing this by the way! I really like the work you did so
far on the connector
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-213425285
Overall, I really like the work you did for the Kinesis Consumer! As you
can see I've added some comments on the PR.
Please let me know what's you opinion on my
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60733759
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60733595
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60733038
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60732384
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60732321
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60732133
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-213407614
I could not get the example to work with the current jackson version. Only
after upgrading it to `2.7.3` it was working.
Did you test the kinesis consumer using
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60731207
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/KinesisConfigConstants.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60731184
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60731025
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60730891
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/KinesisConfigConstants.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60730773
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60726049
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1923#issuecomment-213342621
Code looks good.
It seems that the test is still a bit unstable:
```
Tests in error:
LeaderChangeJobRecoveryTest.before:73 û Timeout Futures timed
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60443897
--- Diff: flink-streaming-connectors/pom.xml ---
@@ -45,6 +45,7 @@ under the License.
flink-connector-rabbitmq
flink
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-212504465
Great, thank you. I'll review the PR soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-212341465
The problem was that the github mirror needed some time to sync with the
commit. But now its there.
---
If your project is set up for it, you can reply to this email
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60364261
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
801 - 900 of 2231 matches
Mail list logo
