Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2374
I will look at this in more detail later today; but i couldn't find any
mistakes skimming over it. However, a small update to the Metrics documentation
would be neat (which i forgot to list on my
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2374#discussion_r75017658
--- Diff:
flink-metrics/flink-metrics-jmx/src/test/java/org/apache/flink/metrics/jmx/JMXReporterTest.java
---
@@ -245,6 +246,50 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2374#discussion_r75018225
--- Diff:
flink-metrics/flink-metrics-statsd/src/test/java/org/apache/flink/metrics/statsd/StatsDReporterTest.java
---
@@ -261,6 +327,40 @@ public long
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2374#discussion_r75018180
--- Diff:
flink-metrics/flink-metrics-jmx/src/test/java/org/apache/flink/metrics/jmx/JMXReporterTest.java
---
@@ -297,4 +342,42 @@ public long getMin
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/2349
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2349
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2302
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2216
It would work but is more work for the user and is less prone to version
mismatches. Not using a fat-jar means that the users have to provide the
dependencies and put them in the `/libs` folder
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2374
Good work! Only found a minor issue in regards to the TestingMeter class.
There is one thing I would like to start a discussion on however. Right now
the Meter interface is essentially a copy
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2300#discussion_r75115976
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -54,13 +53,19 @@
* return Counters
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2300
We can easily expose the tags in the JMXReporter as shown here:
https://github.com/zentol/flink/commit/395bb82eccd78c8b065a10ec129abc91cc6ffc05
Essentially, i added a new method to all JMX
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2300#discussion_r75119021
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -83,9 +88,25
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2300
I've rebased the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2300#discussion_r75117479
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/JobManagerMetricGroup.java
---
@@ -95,6 +96,15 @@ public int
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3232#discussion_r98628798
--- Diff:
flink-libraries/flink-python/src/main/python/org/apache/flink/python/api/flink/plan/Environment.py
---
@@ -163,10 +197,14 @@ def execute(self
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3232#discussion_r98630794
--- Diff:
flink-libraries/flink-python/src/main/python/org/apache/flink/python/api/flink/plan/Environment.py
---
@@ -163,10 +197,14 @@ def execute(self
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3232#discussion_r98631554
--- Diff:
flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonPlanBinder.java
---
@@ -94,6 +95,7 @@
private HashMap
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3232#discussion_r98631632
--- Diff:
flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/streaming/data/PythonStreamer.java
---
@@ -93,8 +95,8 @@ public void open
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3232#discussion_r98628345
--- Diff:
flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/streaming/data/PythonStreamer.java
---
@@ -93,8 +95,8 @@ public void open
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3232#discussion_r98628019
--- Diff:
flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonPlanBinder.java
---
@@ -139,15 +139,28 @@ private void runPlan(String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3232#discussion_r98629326
--- Diff:
flink-libraries/flink-python/src/main/python/org/apache/flink/python/api/flink/plan/Environment.py
---
@@ -46,6 +77,9 @@ def __init__(self
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3232#discussion_r98629271
--- Diff:
flink-libraries/flink-python/src/main/python/org/apache/flink/python/api/flink/plan/Environment.py
---
@@ -46,6 +77,9 @@ def __init__(self
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3232#discussion_r98630616
--- Diff:
flink-libraries/flink-python/src/main/python/org/apache/flink/python/api/flink/plan/Environment.py
---
@@ -27,17 +27,48 @@
import sys
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3217#discussion_r98645798
--- Diff: docs/ops/upgrading.md ---
@@ -25,13 +25,87 @@ under the License.
* ToC
{:toc}
-## Upgrading Flink Streaming Applications
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3217#discussion_r98645060
--- Diff: docs/ops/upgrading.md ---
@@ -25,13 +25,87 @@ under the License.
* ToC
{:toc}
-## Upgrading Flink Streaming Applications
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3270
It would be neat if the example were more similar. Looking at the diff
between the 0.8 and 0.9 examples there should only be 4-5 different lines
(basically replace 08 by 09), but there are quite
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3219#discussion_r99568502
--- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java ---
@@ -116,6 +118,14 @@ else if (file.exists
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3219#discussion_r99576850
--- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java ---
@@ -148,14 +158,49 @@ public static void deleteDirectory(File directory)
throws
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2866#discussion_r99562651
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBase.java
---
@@ -40,26
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3232
Yes, please continue to comment after pushing changes :)
I'll have to try this out on a cluster to be certain, but from the looks of
it this is good to merge.
---
If your project is set up
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3274
you have to modify the corresponding jade files; modifications to the html
files will be overridden the next time someone builds the web-ui.
---
If your project is set up for it, you can reply
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3286
[FLINK-1579] [WIP] Implement Standalone HistoryServer
This PR is a work-in-progress view over a standalone History Server (HS).
JobManagers may send completed jobs to the HistoryServer
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3190
Yes that makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3190
I don't see how this could solve the issue in the JIRA; it describes 2
tests from the same module failing since they use the same directory. This PR
doesn't change that.
---
If your project is set
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3190
Travis failed on flink-core:
```
Failed tests:
GenericCsvInputFormatTest.readWithEmptyField:639 Test failed due to a
IOException: No such file or directory
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3128#discussion_r97327512
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java
---
@@ -191,62 +233,65 @@ private static void
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2974
@tillrohrmann I've addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3128#discussion_r97327675
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java
---
@@ -191,62 +233,65 @@ private static void
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3128
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2974#discussion_r97354396
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerTest.java
---
@@ -1074,6 +1080,79 @@ protected void run
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2974
@tillrohrmann I've addressed your comments. Will merge this once travis
passes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3128
@uce I've addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/3128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/2974
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3189
How come the state of tasks is no longer shown?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/1890
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3219
[FLINK-5659] Harden FileBaseUtils#deleteFileOrDirectory on WIndows
This PR hardens `FileBaseUtils#deleteFileOrDirectory` when the method is
called concurrently on Windows
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3219
That could work. Are you worried about the added sleep in case of an
`DirectoryNotEmptyException`?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3232#discussion_r98445731
--- Diff:
flink-libraries/flink-python/src/main/python/org/apache/flink/python/api/flink/plan/Environment.py
---
@@ -27,17 +27,24 @@
import sys
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3232#discussion_r98443058
--- Diff:
flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonOperationInfo.java
---
@@ -92,6 +96,11 @@ public PythonOperationInfo
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3232#discussion_r98443208
--- Diff:
flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/functions/PythonMapPartition.java
---
@@ -32,7 +32,7 @@
private
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3215
@uce +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3206
@mushketyk The changes have been merged, could you close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3232#discussion_r98441018
--- Diff:
flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonPlanBinder.java
---
@@ -139,15 +139,28 @@ private void runPlan(String
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3219
@StephanEwen I've update the PR. The `deleteDirectory()` method now has
separate paths for windows and unix.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3219#discussion_r98486443
--- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java ---
@@ -148,14 +158,49 @@ public static void deleteDirectory(File directory)
throws
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2836#discussion_r97788511
--- Diff: flink-contrib/flink-storm-examples/pom.xml ---
@@ -364,6 +363,18 @@ under the License
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3215#discussion_r97799769
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ArchivedExecutionGraph.java
---
@@ -105,10 +110,12 @@ public
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3214
Everything that the `CheckpointStatsTracker` tracks is also exposed as a
metric on the JM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3206#discussion_r97746438
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java
---
@@ -52,8 +53,13 @@
private static final long
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3206#discussion_r97746573
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java
---
@@ -106,12 +112,27 @@ public boolean filterPath(Path filePath
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3215#discussion_r97799282
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java
---
@@ -85,6 +79,9 @@
/** History
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3214
[FLINK-5644] Remove metric: Task#lastCheckpointSize
This PR removes the lastCheckpointSize metric that was broken when the
key-groups were introduced. I couldn't find an easy way to fix it instead
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3208
[hotfix] [rat] Add exclusion for rolling-sink snapshot
Adds a RAT exclusion for the rolling sink snapshot used for testing
backwards compatibility. Note that the RAT plugin only complains about
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3206#discussion_r97746636
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java
---
@@ -69,8 +75,8 @@ public GlobFilePathFilter
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3215
as well as the and the `AbstractCheckpointStats` class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3215
I think the `CompletedCheckpointStats` class must also implement
`Serializable`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3215
add `SubtaskStateStats` to the list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3206#discussion_r97969620
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java
---
@@ -52,8 +53,13 @@
private static final long
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3206
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2866
@StephanEwen I've addressed your comments and Travis is passing :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3190
I agree that we should simply fix the tests; if we do that the proposed
change here is redundant anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3376
[FLINK-5870] Handlers define REST URLs
This PR allows ```RequestHandler```s to define the REST URLs under which
they should be registered.
For this purpose the following method was added
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3348#discussion_r102227821
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -227,6 +227,14 @@
public static final String
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3377
[FLINK-5645] Store accumulators/metrics for canceled/failed tasks
This PR modified the Execution/ExecutionGraph to store transmitted
io-metrics/accumulators for canceled/failed tasks. Previously
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3328
@StephanEwen Can this PR be closed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3348#discussion_r102210056
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -227,6 +227,14 @@
public static final String
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3348
The metrics documentation must be update to contain the new metrics.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3348#discussion_r102427382
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateMetrics.java
---
@@ -0,0 +1,167
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3384#discussion_r102427597
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClientConnectionTest.java
---
@@ -115,13 +115,13 @@ public void run
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2866
@StephanEwen I've addressed your comments and rebased the branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3348#discussion_r101993111
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateMetrics.java
---
@@ -0,0 +1,167
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3348#discussion_r101993135
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionMetrics.java
---
@@ -0,0 +1,136
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3348#discussion_r101993298
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -227,6 +227,12 @@
public static final String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3348#discussion_r101992784
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
@@ -385,6 +388,20 @@ public Task(
++counter
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3348#discussion_r101991021
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -227,6 +227,12 @@
public static final String
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3365
[FLINK-5852] Move handler JSON generation code into static methods
This PR is part of the History Server implementation. It is opened
separately to make the review easier.
The primary
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3361
Could you add a screenshot how it would look like after the changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3361
How well does this handle long metric names? (100+ characters)
(You can emulate this by running the SocketWindowWordCount example)
---
If your project is set up for it, you can reply
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3361
ah, ignore my previous comment; that's not relevant to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3368#discussion_r102072659
--- Diff:
flink-core/src/main/java/org/apache/flink/util/FlinkRuntimeException.java ---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3368
Could you name 1 or 2 examples for situations where you think it is
appropriate to throw a ```FlinkException```? Would invalid arguments (like a
String being null) be a reason to do so?
---
If your
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3368#discussion_r102071979
--- Diff:
flink-core/src/main/java/org/apache/flink/util/DynamicCodeLoadingException.java
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3368#discussion_r102072425
--- Diff:
flink-core/src/main/java/org/apache/flink/util/DynamicCodeLoadingException.java
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3323#discussion_r102227190
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/Archiveable.java ---
@@ -17,8 +17,11 @@
*/
package org.apache.flink.api.common
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3377
@tillrohrmann I've addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3377#discussion_r102471279
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IOMetrics.java
---
@@ -53,6 +53,22 @@ public IOMetrics(Meter recordsIn, Meter
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3297#discussion_r101052582
--- Diff: docs/setup/config.md ---
@@ -151,6 +151,8 @@ one of the values specified in
`security.kerberos.login.contexts`.
### Other
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3274
+1 from my side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/3286
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
901 - 1000 of 5225 matches
Mail list logo
