[GitHub] flink pull request: [FLINK-2634] [gelly] [WIP] Vertex Centric Tria...

2016-01-18 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1291#issuecomment-172458727 Hi @vasia, This PR contained a bugfix that could have been validated, but I don't mind closing it! --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-2634] [gelly] [WIP] Vertex Centric Tria...

2016-01-18 Thread andralungu
Github user andralungu closed the pull request at: https://github.com/apache/flink/pull/1291 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2879] [docs] Fixed broken links on the ...

2015-11-11 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/1348 [FLINK-2879] [docs] Fixed broken links on the architecture page Fixed the links on the general architecture page. They were pointing to non-existing htmls. You can merge this pull request

[GitHub] flink pull request: [FLINK-2634] [gelly] [WIP] Vertex Centric Tria...

2015-10-22 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/1291 [FLINK-2634] [gelly] [WIP] Vertex Centric Triangle Count This PR builds on the code presented in #1105. Basically, the reduceOn* calls are replaced with groupReduceOn* calls

[GitHub] flink pull request: [FLINK-2634] [gelly] Added a vertex-centric Tr...

2015-09-23 Thread andralungu
Github user andralungu closed the pull request at: https://github.com/apache/flink/pull/1105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1520] [gelly] Create a Graph from CSV f...

2015-09-21 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/1149#discussion_r39947900 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,486 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520] [gelly] Create a Graph from CSV f...

2015-09-21 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/1149#discussion_r39948297 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/IncrementalSSSP.java --- @@ -110,24 +105,20 @@ public static void main

[GitHub] flink pull request: [FLINK-1520] [gelly] Create a Graph from CSV f...

2015-09-21 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1149#issuecomment-141905104 Hi @vasia, As you said, I already reviewed this :P. I left a couple of comments inline. Please reverify the forwarded fields annotations. If you put them

[GitHub] flink pull request: [FLINK-2634] [gelly] Added a vertex-centric Tr...

2015-09-20 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1105#issuecomment-141756735 I've created the two JIRA issues: FLINK-2714 and FLINK-2715. @vasia, if no other objections, can you have another look at this and merge it? --- If your

[GitHub] flink pull request: [FLINK-2634] [gelly] Added a vertex-centric Tr...

2015-09-14 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1105#issuecomment-140133538 Hey you two :) I suggest that we add this one. Let the JIRA that @vasia opened handle the keys. Then add the DataSet example (another JIRA

[GitHub] flink pull request: [FLINK-2661] Added Node Splitting Methods

2015-09-14 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1124#issuecomment-140131099 Hi @vasia , There was no clear rejection in the discussion, so I thought I'd try my luck :) This technique could be enabled by using a flag only

[GitHub] flink pull request: [FLINK-2661] Added Node Splitting Methods

2015-09-14 Thread andralungu
Github user andralungu closed the pull request at: https://github.com/apache/flink/pull/1124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2661] Added Node Splitting Methods

2015-09-12 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/1124 [FLINK-2661] Added Node Splitting Methods Social media graphs, citation networks or even protein networks have a common property: their degree distribution follows a power-law curve

[GitHub] flink pull request: [FLINK-2634] [gelly] Added a vertex-centric Tr...

2015-09-12 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1105#issuecomment-139820404 If it's okay with you, I'd like to see what @vasia has to say about adding the Triangle Count example from the DataSet API + a reduce as a library method. IMO, it's

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-09-12 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/892#issuecomment-139822550 I think it's safe to open a fresh PR... fixing this one would be overkill. You can also update and rebase #923 so that we can review them. --- If your project

[GitHub] flink pull request: [FLINK-2634] [gelly] Added a vertex-centric Tr...

2015-09-11 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/1105#discussion_r39276971 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/library/TriangleCount.java --- @@ -0,0 +1,208 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2634] [gelly] Added a vertex-centric Tr...

2015-09-11 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1105#issuecomment-139564327 The only argument I have for this particular code (as opposed to the one in the DataSet API) is that his one simulates what Pregel is doing... But since it's

[GitHub] flink pull request: [FLINK-2570] [gelly] Added a Triangle Count Li...

2015-09-08 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1054#issuecomment-138497145 Since the bugfix version was released days ago, I guess this is safe to merge... --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-2634] [gelly] Added a vertex-centric Tr...

2015-09-08 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/1105 [FLINK-2634] [gelly] Added a vertex-centric Triangle Count Lib Method This PR adds a vertex centric version of the TriangleCount algorithm as discussed in #1054. The main difference

[GitHub] flink pull request: [FLINK-2152] [bugfix] Used a concurrent list i...

2015-09-08 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1058#issuecomment-138692441 It seems the issue was already fixed via #1075 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-2152] [bugfix] Used a concurrent list i...

2015-09-08 Thread andralungu
Github user andralungu closed the pull request at: https://github.com/apache/flink/pull/1058 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2152] [bugfix] Used a concurrent list i...

2015-08-27 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1058#issuecomment-135407258 so you mean something like `ListTuple2Integer, Long offsets = getRuntimeContext().getBroadcastVariableWithInitializer(counts, new ArrayList

[GitHub] flink pull request: [FLINK-2152] [bugfix] Used a concurrent list i...

2015-08-27 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1058#issuecomment-135396805 Yup that's what I thought as well. However, I only tested `zipWithUniqueId` on a cluster. A student came to me and said that `zipWithIndex` did not work

[GitHub] flink pull request: [FLINK-2570] [gelly] Added a Triangle Count Li...

2015-08-26 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1054#issuecomment-134847386 okay... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2512] [bugfix] Used a concurrent list i...

2015-08-26 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/1058 [FLINK-2512] [bugfix] Used a concurrent list in the open method This PR fixes the concurrency issue raised by the elements in the broadcast set. I instantiated the list

[GitHub] flink pull request: [FLINK-2152] [bugfix] Used a concurrent list i...

2015-08-26 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1058#issuecomment-135042510 I guess because more parallel instances are trying to access that broadcast variable. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-2512] [bugfix] Used a concurrent list i...

2015-08-26 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1058#issuecomment-135027923 excerpt from the JIRA This can be fixed by wrapping a concurrent list around the counts variable e.g. CopyOnWriteArrayList from java.util.concurrrent

[GitHub] flink pull request: [FLINK-2152] [bugfix] Used a concurrent list i...

2015-08-26 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1058#issuecomment-135035150 Yes, I am sorry about that. It was a propagated typo. Problem solved! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-2570] [gelly] Added a Triangle Count Li...

2015-08-25 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1054#issuecomment-134590137 You're right @tillrohrmann. I updated the JIRA to also contain a small description :) --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-2563] [gelly] changed Graph's run() to ...

2015-08-25 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1042#issuecomment-134516708 Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2570] [gelly] Added a Triangle Count Li...

2015-08-25 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1054#issuecomment-134702560 Hi @vasia, I clarified the type of input expected. The graph should be undirected. Without the distinct, you get duplicate edges there(and an erroneous

[GitHub] flink pull request: [FLINK-2570] [gelly] Added a Triangle Count Li...

2015-08-25 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/1054 [FLINK-2570] [gelly] Added a Triangle Count Library Method This PR adds a Triangle Count Library Method to Gelly. I decided to add the GAS version because it is faster than vertex

[GitHub] flink pull request: [FLINK-2563] [gelly] changed Graph's run() to ...

2015-08-23 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1042#issuecomment-133881425 Exactly what I had in mind. +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2451] [gelly] examples and library clea...

2015-08-11 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1000#issuecomment-130002982 Apart from the minor comment, this looks good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-2451] [gelly] examples and library clea...

2015-08-11 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/1000#discussion_r36779494 --- Diff: flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/GatherSumApplyITCase.java --- @@ -86,26 +72,35 @@ public void

[GitHub] flink pull request: [Flink-Gelly] [example] added missing assumpti...

2015-08-11 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/883#issuecomment-130003492 I guess the only request that was not fulfilled for this PR was to squash the commits. Then it should be fine. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-08-11 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-130014300 Saw this I will also update the documentation afterwards... Sorry! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-08-11 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-130013958 Hi @vasia, Not sure whether this comment was issued for me... Nevertheless I left some suggestions inline. All in all, it covers the problems discussed

[GitHub] flink pull request: Hits

2015-08-11 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/765#issuecomment-130016029 @vasia , I guess the guys already finished the IMPRO3 course. What is the status of this PR @mfahimazizi? Do you have time to address the comments? Are you

[GitHub] flink pull request: [FLINK-2452] [Gelly] adds a playcount threshol...

2015-08-06 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/968#issuecomment-128456801 Nope, no comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2375] Add Approximate Adamic Adar Simil...

2015-07-20 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/923#issuecomment-122868758 Could you also do a git ammend to reference the correct jira issue in the commit? --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-07-20 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/892#issuecomment-123153943 Hi @shghatge , Did you also run the two examples on the cluster to make sure that the approximate version is faster? Then you could also add some numbers

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-14 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-121215203 Hmmm :-? but can you pass NullValue to tyes... it expects Something.class. Can it be overwritten without type erasure getting in the way? Anyway... I

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-13 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-120856171 Hi, I just had a closer look at this PR and it made me seriously question the utility of a `Graph.fromCSV` method. Why? First of all because it's more

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-13 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-121032514 Hi @vasia, I also saw the types issue, but I had a feeling that this is the way it was decided in the previous comment. I would rather have different names

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-13 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-121039562 Yes, but then you would have the following methods: `types`, `typesNoEdgeValue`, `typesNoVertexValue` and again `types`. So, even if it's not 100% needed I'd try

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-13 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r34504887 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,462 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-13 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r34504919 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,462 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

2015-07-11 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/877#issuecomment-120654787 Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-07-08 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/892#discussion_r34189267 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/AdamicAdarSimilarityMeasure.java --- @@ -0,0 +1,243

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-07-08 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/892#discussion_r34189351 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/AdamicAdarSimilarityMeasure.java --- @@ -0,0 +1,243

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-07-08 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/892#issuecomment-119708667 Code-style freak says everything else is fine --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-07-08 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/892#discussion_r34189005 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/AdamicAdarSimilarityMeasure.java --- @@ -0,0 +1,243

[GitHub] flink pull request: [FLINK-1745] [ml] [WIP] Add exact k-nearest-ne...

2015-07-06 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/696#discussion_r33924163 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/KNN.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

2015-07-06 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/877#issuecomment-118891421 I see the requirements have been fulfilled here. If no objections, I'd like to merge this by the end of the week :) --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-2150] Added zipWithUniqueIds

2015-07-02 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/801#issuecomment-118171270 Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: My branch

2015-07-02 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/881#issuecomment-118177927 I am a bit out of context here, but I believe this PR should be deleted :) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

2015-07-02 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/877#issuecomment-118179979 Hihi! Shivani is updating the PR on the fly :) Reminds me of myself back in the day ;) If I may tease: If these GSA parameters did not have an example, I

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

2015-07-01 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/877#issuecomment-117540482 Hi @shghatge , This PR looks very nice; I added some minor inline comments to make it look even nicer :) One major problem: you have an example

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

2015-07-01 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/877#discussion_r33657016 --- Diff: docs/libs/gelly_guide.md --- @@ -693,6 +693,9 @@ Currently, the following parameters can be specified: * strongNumber of Vertices/strong

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

2015-07-01 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/877#discussion_r33657118 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSAExistenceOfPaths.java --- @@ -0,0 +1,193 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

2015-07-01 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/877#discussion_r33657394 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSAExistenceOfPaths.java --- @@ -0,0 +1,193 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

2015-07-01 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/877#issuecomment-117785914 LGTM :) @vasia ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-01 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-117787551 Nice and rebased. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2150] Added zipWithUniqueIds

2015-06-30 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/801#issuecomment-117112526 Okay, can I get some +1s to merge this :)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2152] Added zipWithIndex

2015-06-28 Thread andralungu
Github user andralungu closed the pull request at: https://github.com/apache/flink/pull/832 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2150] Added zipWithUniqueIds

2015-06-28 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/801#issuecomment-116287334 Hi @thvasilo , Sorry for the late reply... I stated in the `zipWithIndex` PR that I am waiting for that to be merged before I update this one :). So, here

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-26 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33354071 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -282,6 +282,54 @@ public void flatMap(EdgeK, EV edge

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-26 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33354597 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,502 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-26 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33354535 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,502 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-26 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33353966 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -282,6 +282,54 @@ public void flatMap(EdgeK, EV edge

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-26 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33354571 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,502 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-26 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33354654 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,502 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-26 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33355251 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GraphMetrics.java --- @@ -150,20 +149,15 @@ private static boolean

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-26 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-115689621 Hi @shghatge , I left my set of comments inline. They are mostly related to coding style issues. I guess you should revisit the previous comments here

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-26 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33354695 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,502 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-26 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33354136 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -282,6 +282,54 @@ public void flatMap(EdgeK, EV edge

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-26 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33355373 --- Diff: flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphCreationWithMapperITCase.java --- @@ -156,4 +181,17

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-26 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33354309 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,502 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-26 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33355180 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/ConnectedComponents.java --- @@ -119,23 +113,32 @@ private static boolean

[GitHub] flink pull request: [FLINK-2152] Added zipWithIndex

2015-06-25 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/832#issuecomment-115134406 Hey Theo, Thanks a lot for finding my bug there ^^ PR updated to address the Java issues and to contain a pimped Scala version of `zipWithIndex

[GitHub] flink pull request: [FLINK-2152] Added zipWithIndex

2015-06-24 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/832#issuecomment-114883882 Uhmmm... flink.api.scala is imported. That's not the issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-2152] Added zipWithIndex

2015-06-24 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/832#issuecomment-114878728 Actually, I get a weird compile error: it says missing Type parameter for the map in DataSet.scala... I think this is because the map is overriden... and I haven't

[GitHub] flink pull request: [FLINK-2152] Added zipWithIndex

2015-06-23 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/832#issuecomment-114481973 Hey @tillrohrmann , Sorry for the incredibly late reply. The last weeks have been very hectic. Nevertheless, I'd like to properly finish and polish

[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API

2015-06-23 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-114420568 Thanks @aljoscha for reminding me... This slipped my mind for a sec. I agree that the methods should have Scaladoc (this should be straightforward to add

[GitHub] flink pull request: [FLINK-2149][gelly] Simplified Jaccard Example

2015-06-20 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/770#issuecomment-113752297 Meging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-19 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-113483077 Mea culpa. No the mapper test is fine; For the examples comment, I meant to go through the classes in the example folder and to modify the way the graph

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-18 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/818#issuecomment-113149078 Hi @shghatge , Don't forget to remove the definition for the public removeVertices(DataSet) from the documentation. Up for discussion: should we

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-18 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-113213190 This looks very nice! Someone deserves a virtual :ice_cream: ! There are some tests missing: - test `fromCSV` with a Mapper - you just test `types

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-18 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-113217602 Ah! And I just remembered! Maybe it makes sense to update the examples to use `fromCSV` when creating the Graph instead of `getEdgesDataSet`. --- If your project

[GitHub] flink pull request: [FLINK-1520] Read edges and vertices from CSV ...

2015-06-17 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/846#issuecomment-112783592 Hi @shghatge , It seems we have a bit of a mess in this PR. Nothing that cannot be fixed. Let's take it offline. --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-16 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-112373119 PR updated to test the same issue in ApplyCoGroupFunctionOnAllEdges and ApplyCoGroupFunction. Also added tests. --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-2152] Added zipWithIndex

2015-06-15 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/832#discussion_r32410253 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java --- @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-15 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/818#discussion_r32415140 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -1151,6 +1151,23 @@ public void coGroup(IterableVertexK, VV

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-15 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/818#discussion_r32415176 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -1151,6 +1151,23 @@ public void coGroup(IterableVertexK, VV

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-15 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/818#discussion_r32414981 --- Diff: docs/libs/gelly_guide.md --- @@ -240,6 +240,7 @@ GraphLong, Double, Double networkWithWeights = network.joinWithEdgesOnSource(v img alt

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-15 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/818#issuecomment-112099290 Hi @vasia , In essence the `difference` method is just a fancy way of removing vertices, right? When you remove a vertex, you also remove the edge

[GitHub] flink pull request: [FLINK-2149][gelly] Simplified Jaccard Example

2015-06-14 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/770#issuecomment-111807874 PR updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-13 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-111761198 Yup, exactly! The use case was: I modified something in the edge data set, called groupReduceOnNeighbors on the result and got NPE, exception that could have been

[GitHub] flink pull request: [FLINK-2152] Added zipWithIndex

2015-06-13 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/832 [FLINK-2152] Added zipWithIndex This PR adds the zipWithIndex utility method to Flink's DataSetUtils as described in the mailing list discussion: http://apache-flink-mailing-list-archive

  1   2   >