[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1302585103 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -513,36 +514,39 @@ private void stopDispatcherServices() throws Exception

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1302368927 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -513,36 +514,39 @@ private void stopDispatcherServices() throws Exception

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1301133436 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## @@ -338,32 +356,24 @@ private void confirmLeadership(

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1300892311 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -515,7 +516,7 @@ public CompletableFuture submitJob(JobGraph jobGraph,

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1300891908 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## Review Comment: Sorry for the mistake. Fixed.

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1297932131 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## @@ -262,34 +262,67 @@ public void grantLeadership(UUID

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1297931816 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## @@ -489,19 +522,29 @@ private boolean isRunning() {

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1297920993 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## @@ -392,7 +392,7 @@ private void forwardResultFuture(

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1297920162 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## @@ -376,7 +376,7 @@ private void confirmLeadership(

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1296743085 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## @@ -262,36 +261,92 @@ public void grantLeadership(UUID

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1296742543 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## @@ -262,36 +261,92 @@ public void grantLeadership(UUID

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1295337708 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## @@ -261,34 +261,69 @@ public void grantLeadership(UUID

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1295337708 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## @@ -261,34 +261,69 @@ public void grantLeadership(UUID

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1295337613 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## @@ -488,18 +523,21 @@ private boolean isRunning() {

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1295337443 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## @@ -261,34 +261,69 @@ public void grantLeadership(UUID

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1295337267 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## @@ -261,34 +261,69 @@ public void grantLeadership(UUID

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1289452304 ## flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStoreFileOperationsTest.java: ## @@ -116,46 +123,80 @@ public void

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1288238489 ## flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStoreFileOperationsTest.java: ## @@ -116,46 +123,74 @@ public void

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1288206790 ## flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStoreFileOperationsTest.java: ## @@ -116,46 +123,74 @@ public void

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1288206790 ## flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStoreFileOperationsTest.java: ## @@ -116,46 +123,74 @@ public void

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1288206790 ## flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStoreFileOperationsTest.java: ## @@ -116,46 +123,74 @@ public void

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1288185269 ## flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStoreFileOperationsTest.java: ## @@ -54,11 +57,15 @@ public class

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1288179888 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStore.java: ## @@ -43,62 +44,62 @@ public interface JobResultStore { *

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1288176936 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractThreadsafeJobResultStore.java: ## @@ -43,66 +46,92 @@ public abstract class

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1288141874 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractThreadsafeJobResultStore.java: ## @@ -43,66 +46,92 @@ public abstract class

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1288110488 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -561,21 +563,28 @@ public CompletableFuture submitFailedJob(

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1288107381 ## flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/JobResultStoreContractTest.java: ## @@ -46,72 +47,97 @@ public interface

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1288102574 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedJobResultStore.java: ## Review Comment: The commit message and

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1288094128 ## flink-core/src/main/java/org/apache/flink/util/ExceptionUtils.java: ## @@ -381,9 +381,12 @@ public static void rethrowException(Throwable t) throws Exception {

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1284129028 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -516,7 +517,7 @@ public CompletableFuture submitJob(JobGraph jobGraph,

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1284121890 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractThreadsafeJobResultStore.java: ## Review Comment: I've followed the code of

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1284120242 ## flink-runtime/src/test/java/org/apache/flink/runtime/testutils/TestingJobResultStore.java: ## @@ -116,58 +111,53 @@ public static TestingJobResultStore.Builder

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283948678 ## flink-runtime/src/test/java/org/apache/flink/runtime/testutils/TestingJobResultStore.java: ## @@ -116,58 +111,53 @@ public static TestingJobResultStore.Builder

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283947288 ## flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/JobResultStoreContractTest.java: ## @@ -46,72 +47,97 @@ public interface

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283946578 ## flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStoreFileOperationsTest.java: ## @@ -116,46 +123,74 @@ public void

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283945744 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java: ## @@ -579,10 +587,15 @@ public void

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283944785 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## @@ -277,18 +277,11 @@ private void

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283937477 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedJobResultStore.java: ## Review Comment: Done. -- This is an

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283935357 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedJobResultStore.java: ## @@ -57,17 +61,17 @@ public void

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283935250 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedJobResultStore.java: ## @@ -57,17 +61,17 @@ public void

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283934746 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStore.java: ## @@ -43,69 +44,70 @@ public interface JobResultStore { *

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283928788 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStore.java: ## @@ -43,69 +44,70 @@ public interface JobResultStore { *

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283927882 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStore.java: ## @@ -43,69 +44,70 @@ public interface JobResultStore { *

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283926936 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStore.java: ## @@ -43,69 +44,70 @@ public interface JobResultStore { *

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283926122 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStore.java: ## @@ -43,69 +44,70 @@ public interface JobResultStore { *

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283925581 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java: ## @@ -181,21 +185,19 @@ public void

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283925443 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java: ## @@ -181,21 +185,19 @@ public void

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283100724 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -1390,29 +1392,71 @@ private CompletableFuture

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283923614 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java: ## @@ -332,11 +332,16 @@ public void

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283102037 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractThreadsafeJobResultStore.java: ## @@ -43,61 +47,126 @@ public abstract class

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283100724 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -1390,29 +1392,71 @@ private CompletableFuture

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283019274 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractThreadsafeJobResultStore.java: ## @@ -43,61 +47,126 @@ public abstract class

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283018521 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -1390,29 +1392,71 @@ private CompletableFuture

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283010789 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -580,17 +581,13 @@ private boolean isDuplicateJob(JobID jobId) throws

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283010571 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -1273,7 +1270,22 @@ private CompletableFuture removeJob(JobID jobId,

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1282979301 ## flink-core/src/main/java/org/apache/flink/util/ExceptionUtils.java: ## @@ -381,9 +381,12 @@ public static void rethrowException(Throwable t) throws Exception {

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1282978842 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -516,7 +517,7 @@ public CompletableFuture submitJob(JobGraph jobGraph,