[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2023-01-03 Thread GitBox
rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1060998267 ## flink-core/src/main/java/org/apache/flink/configuration/HeartbeatManagerOptions.java: ## @@ -50,6 +50,8 @@ public class HeartbeatManagerOptions { private

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2023-01-03 Thread GitBox
rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1060981282 ## flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/DefaultHeartbeatMonitor.java: ## @@ -35,9 +36,9 @@ * * @param Type of the payload being

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2022-12-25 Thread GitBox
rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1057006570 ## flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/NoOpHeartbeatServices.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2022-12-25 Thread GitBox
rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1057005130 ## flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatMonitorImpl.java: ## @@ -39,6 +39,8 @@ private static final Logger LOG =

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2022-12-25 Thread GitBox
rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1057006287 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterTest.java: ## @@ -202,8 +203,8 @@ static void setupAll() { rpcService = new

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2022-12-25 Thread GitBox
rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1057006257 ## flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java: ## @@ -2896,7 +2899,9 @@ private TaskExecutorTestingContext

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2022-12-25 Thread GitBox
rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1057005130 ## flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatMonitorImpl.java: ## @@ -39,6 +39,8 @@ private static final Logger LOG =

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2022-12-21 Thread GitBox
rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1054964645 ## flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatManagerSenderImpl.java: ## @@ -37,7 +37,7 @@ private final long heartbeatPeriod;

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2022-12-21 Thread GitBox
rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1054957881 ## flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/NoOpHeartbeatServices.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2022-12-21 Thread GitBox
rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1054946222 ## flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatServices.java: ## @@ -100,37 +62,31 @@ public HeartbeatManager

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2022-12-13 Thread GitBox
rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1047831221 ## flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java: ## @@ -2896,7 +2896,8 @@ private TaskExecutorTestingContext