yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the
StreamingFileSink Builder interface to allow for easier subclassing of
StreamingFileSink
URL: https://github.com/apache/flink/pull/9581#issuecomment-533778901
@tweise Did rebase and squash
@kl0u Done
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the
StreamingFileSink Builder interface to allow for easier subclassing of
StreamingFileSink
URL: https://github.com/apache/flink/pull/9581#issuecomment-533666729
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the
StreamingFileSink Builder interface to allow for easier subclassing of
StreamingFileSink
URL: https://github.com/apache/flink/pull/9581#issuecomment-533666702
> @yxu-valleytider I think we can merge this PR as
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the
StreamingFileSink Builder interface to allow for easier subclassing of
StreamingFileSink
URL: https://github.com/apache/flink/pull/9581#issuecomment-533209039
> Hi @yxu-valleytider , I still have the following
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the
StreamingFileSink Builder interface to allow for easier subclassing of
StreamingFileSink
URL: https://github.com/apache/flink/pull/9581#issuecomment-533203569
@aljoscha The metrics collection needs be done
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the
StreamingFileSink Builder interface to allow for easier subclassing of
StreamingFileSink
URL: https://github.com/apache/flink/pull/9581#issuecomment-532995742
PTAL @kl0u
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the
StreamingFileSink Builder interface to allow for easier subclassing of
StreamingFileSink
URL: https://github.com/apache/flink/pull/9581#issuecomment-532348389
@kl0u Agree with most of the review comments. Just
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the
StreamingFileSink Builder interface to allow for easier subclassing of
StreamingFileSink
URL: https://github.com/apache/flink/pull/9581#issuecomment-531038789
sorry for the delay @kl0u . Was side tracked by
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the
StreamingFileSink Builder interface to allow for easier subclassing of
StreamingFileSink
URL: https://github.com/apache/flink/pull/9581#issuecomment-528763841
Hi @kl0u thanks a lot for the suggestions.
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the
StreamingFileSink Builder interface to allow for easier subclassing of
StreamingFileSink
URL: https://github.com/apache/flink/pull/9581#issuecomment-527681585
PTAL @kl0u
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the
StreamingFileSink Builder interface to allow for easier subclassing of
StreamingFileSink
URL: https://github.com/apache/flink/pull/9581#issuecomment-527534328
> If you simply want to extend the
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the
StreamingFileSink Builder interface to allow for easier subclassing of
StreamingFileSink
URL: https://github.com/apache/flink/pull/9581#issuecomment-526760217
PTAL @kl0u
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the
StreamingFileSink Builder interface to allow for easier subclassing of
StreamingFileSink
URL: https://github.com/apache/flink/pull/9581#issuecomment-526759603
PTAL @kailashhd @tweise
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the
StreamingFileSink Builder interface to allow for easier subclassing of
StreamingFileSink
URL: https://github.com/apache/flink/pull/9581#issuecomment-526712227
**Example subclass interface**
```
14 matches
Mail list logo