[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-184254082 Thanks for merging! Very happy about it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/750 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-184171212 Thanks for the review @StephanEwen. I will take care of your comments and then merge the PR :-) --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-184165224 This looks pretty good by now. I have a few remaining comments, otherwise this looks good to go: 1. There is a duplicate and incorrect test dependency in

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r52883504 --- Diff: flink-tests/pom.xml --- @@ -141,6 +149,14 @@ under the License. org.apache.flink +

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-183389629 Let us squash them, once we merge the PR. Otherwise changes are hard to track. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-183390556 Alright, will do. On Fri, Feb 12, 2016 at 5:10 PM, Matthias J. Sax wrote: > About vendor.css etc (I guess I did not

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-183382789 I will merge your PR and take care of the other issues you mentioned. Should I squash afterwards to get a potential final state of this PR that we might merge? --- If

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-183389977 About vendor.css etc (I guess I did not commit after the last run of gulp), so the committed version are dirty... It worked for me -- I guess it would be required that you

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-183400616 Updated. I did not take your last two comments about `@SuppressWarnings` and `@SuppressWarnings("serial")` because this commit should not touch those files (not unrelated

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r52597099 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/functions/StoppableFunction.java --- @@ -0,0 +1,33 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-182915371 It seems that reverting `vendor.css` and `vendor.js` to the latest master version does the trick :-) I've tested the stop functionality locally and on yarn

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r52598306 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -464,6 +464,33 @@ class JobManager( )

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r52598713 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -464,6 +464,33 @@ class JobManager( )

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r52598725 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -464,6 +464,33 @@ class JobManager( )

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r52598719 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -464,6 +464,33 @@ class JobManager( )

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r52598649 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -464,6 +464,33 @@ class JobManager( )

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r52598106 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/tasks/StoppableTask.java --- @@ -0,0 +1,25 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r52598636 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -464,6 +464,33 @@ class JobManager( )

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r52598511 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -417,6 +417,28 @@ class TaskManager(

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r52597604 --- Diff: docs/apis/cli.md --- @@ -248,6 +252,16 @@ Action "cancel" cancels a running program. configuration.

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r52601121 --- Diff: flink-runtime-web/web-dashboard/web/css/vendor.css --- @@ -7704,6 +7704,7 @@ button.close { .modal-header { padding: 15px;

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-182859453 Really good work @mjsax. I had a couple of minor inline comments with respect to the latest commit and some with respect to the overall changes (especially

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-182884939 The WebUI is not shown when I build the PR and start a local cluster. Does it work for you? --- If your project is set up for it, you can reply to this email and

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-182917968 I've opened a PR against your branch which makes the `StoppableSourceStreamTask` and the `StoppableStreamSource` type safe. Furthermore, it fixes the problem with

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-182393013 @tillrohrmann just updated this. Let's see if you think it is ready now... ;) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-181402377 Ok. Your arguments are very strong. I will update this PR accordingly. About `FlinkKafkaConsumer08` (and actually all other available sources). IMHO, we need a new

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-181419327 Yes exactly. Let us tackle the next steps (adding stopping functionality to more sources, consistent behaviour, drawing savepoint, etc.) once we have a first

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-181040537 I don't see much of a difference here. (1) Of course, we can have a stoppable flag instead of the `JobType`; but I don't see any advantage. Why should it be bad to add

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-181072411 We have managed to far to not make a distinction between batch and streaming jobs, which was very good. Given that the future plan is that streaming jobs subsume

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-180617867 Ok let us include as a first version a stop implementation where you don't have the strong consistency guarantees. But before I think we should still change three

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-179261307 I think we can get this done today or tomorrow and then finally merge the PR. Looking forward having this code in the master branch :-) --- If your project is set

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-179260525 Good work @mjsax. I had one last comment. It concerns stopping a job when it's in the state `RESTARTING`. I think we have to allow the state transition `RESTARTING`

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-178836268 > I had some more comments concerning the failure case handling of stop calls. The first problem is still the handling of exceptions when calling stop on the Invokable in

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-172791340 Are we gonna get this in for the 1.0 release? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-172805169 Great to hear :-) I guess in the next couple weeks but it of course depends on the community. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-172792701 That is my plan. Is there already a planed date to release 1.0 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r49442110 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/tasks/Stoppable.java --- @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r49441547 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java --- @@ -402,21 +405,52 @@ public void onComplete(Throwable

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r49455037 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskStopTest.java --- @@ -0,0 +1,113 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r49454567 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexStopTest.java --- @@ -0,0 +1,131 @@ +/* + *

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r49455315 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/testutils/StoppableInvokable.java --- @@ -0,0 +1,35 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r49441422 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/StoppingException.java --- @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r49451808 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSignalsTest.java --- @@ -0,0 +1,223 @@ +/* + *

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-170947333 Once we've resolved these problems, I'll test the code on the cluster and YARN. If they pass, then we should merge this PR. --- If your project is set up for it,

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r49461844 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -417,6 +417,28 @@ class TaskManager(

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r49462409 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -742,10 +743,38 @@ private void notifyFatalError(String

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r49463485 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java --- @@ -402,21 +405,52 @@ public void onComplete(Throwable

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r49463254 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -427,6 +427,28 @@ class JobManager( )

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r49463705 --- Diff: flink-runtime-web/web-dashboard/web/partials/jobs/job.html --- @@ -33,6 +33,7 @@ {{ job['end-time'] | amDateFormat:'-MM-DD,

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-169267260 Just updated this. I did not add an additional YARN test, because I test `GET` and `DELETE` in the REST test. About your last comment regarding `Execution`: behavior of

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-169344534 Travis failed with weird compilation error. I guess this is an caching issue. It builds locally and on my personal Travis:

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-168673112 Just curious what the current state of this PR is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-168746132 Addressing your comments is WIP... Hope to get it done this week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-168749820 Great to hear :-) On Mon, Jan 4, 2016 at 6:33 PM, Matthias J. Sax wrote: > Addressing your comments is WIP... Hope to

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46670585 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java --- @@ -732,6 +758,18 @@ else if (current ==

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46667227 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java --- @@ -732,6 +758,18 @@ else if (current ==

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46670412 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java --- @@ -227,4 +235,121 @@ public void

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-161943293 When I use the stop button of the web interface, then my jobs get cancelled. Using the cli, the stop terminates the job gracefully. Thus, there seems to be still an

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-161939523 Have you added the tests for the REST interface? I couldn't find them. For the future it might be helpful, if you simply push commits to your PR branch without

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-161949525 When fixing the `JobManagerTest` I noticed the following. When the job was stopped when it was still in the state `SCHEDULED` or `DEPLOYING`, then one received a

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-161982097 Thanks. I will take care of it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46465735 --- Diff: flink-runtime-web/web-dashboard/package.json --- @@ -7,27 +7,27 @@ "devDependencies": { "browserify": "^9.0.3", "coffeeify":

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-161460588 Updated this PR. The test that should be extended is the last open question if I did not miss anything else. --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46399687 --- Diff: flink-runtime-web/web-dashboard/package.json --- @@ -7,27 +7,27 @@ "devDependencies": { "browserify": "^9.0.3",

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46414197 --- Diff: flink-runtime-web/web-dashboard/package.json --- @@ -7,27 +7,27 @@ "devDependencies": { "browserify": "^9.0.3", "coffeeify":

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46414370 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java --- @@ -227,4 +235,121 @@ public void testRequestPartitionState()

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46415616 --- Diff: flink-runtime-web/web-dashboard/package.json --- @@ -7,27 +7,27 @@ "devDependencies": { "browserify": "^9.0.3",

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46418046 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java --- @@ -227,4 +235,121 @@ public void

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46307098 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java --- @@ -227,4 +235,121 @@ public void testRequestPartitionState()

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46305433 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java --- @@ -732,6 +758,18 @@ else if (current ==

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46308707 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java --- @@ -732,6 +758,18 @@ else if (current ==

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-161044122 Do I have to build the web resources as well? Because I don't see the stop button. Thanks for your contribution @mjsax. The PR is in a good shape.

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-161045939 Actually all changes after running `gulp` in `flink-runtime-web/web-dashboard` are committed. There should be no need. I had similar problems as the WebUI caches stuff in

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46259453 --- Diff: docs/apis/cli.md --- @@ -185,6 +189,18 @@ Action "list" lists running and scheduled programs. -s,--scheduledShow only

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46290038 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java --- @@ -112,19 +114,24 @@ /** The log

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46290433 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertex.java --- @@ -227,6 +229,10 @@ public ExecutionState

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46290465 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java --- @@ -227,4 +235,121 @@ public void testRequestPartitionState()

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46291411 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskStopTest.java --- @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46290688 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -420,6 +420,23 @@ class JobManager( )

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46292645 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java --- @@ -112,19 +114,24 @@ /** The log object

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46293301 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertex.java --- @@ -227,6 +229,10 @@ public ExecutionState

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46295358 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertexTest.java --- @@ -0,0 +1,41 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46294804 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSignalsTest.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46284702 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -569,6 +571,69 @@ public int compare(JobStatusMessage o1,

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46285044 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendStopTest.java --- @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46285844 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSignalsTest.java --- @@ -0,0 +1,221 @@ +/* + *

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46286009 --- Diff: flink-runtime-web/web-dashboard/package.json --- @@ -7,27 +7,27 @@ "devDependencies": { "browserify": "^9.0.3", "coffeeify":

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46286695 --- Diff: docs/apis/cli.md --- @@ -185,6 +189,18 @@ Action "list" lists running and scheduled programs. -s,--scheduledShow only

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46285228 --- Diff: flink-runtime-web/web-dashboard/package.json --- @@ -7,27 +7,27 @@ "devDependencies": { "browserify": "^9.0.3",

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46285468 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java --- @@ -402,21 +405,53 @@ public void onComplete(Throwable

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46287079 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexStopTest.java --- @@ -0,0 +1,138 @@ +/* + *

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46287242 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSignalsTest.java --- @@ -0,0 +1,221 @@ +/* + *

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46287141 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -569,6 +571,69 @@ public int compare(JobStatusMessage o1,

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46277994 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSignalsTest.java --- @@ -0,0 +1,221 @@ +/* + *

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46280916 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java --- @@ -227,4 +235,121 @@ public void

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46283446 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexStopTest.java --- @@ -0,0 +1,138 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46277659 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSignalsTest.java --- @@ -0,0 +1,221 @@ +/* + *

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46278142 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertexTest.java --- @@ -0,0 +1,41 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46279382 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexStopTest.java --- @@ -0,0 +1,138 @@ +/* + *

  1   2   3   >