Github user sbcd90 closed the pull request at:
https://github.com/apache/flink/pull/1566
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1566#discussion_r51997240
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/ObjectArrayTypeInfo.java
---
@@ -72,15 +77,59 @@ public int getTotalFields() {
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1566#issuecomment-180284317
I think the PR is still not in a good shape. I pointed out the problematic
code sections.
Also please bear in mind that people will always try to review
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1566#discussion_r51997124
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/ObjectArrayTypeInfo.java
---
@@ -72,15 +77,59 @@ public int getTotalFields() {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1566#discussion_r51997602
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/runtime/ObjectArrayComparatorCompositeTypeTest.java
---
@@ -0,0 +1,106 @@
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1566#discussion_r51997409
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/ObjectArrayComparator.java
---
@@ -0,0 +1,199 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1566#discussion_r51997479
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/ObjectArrayComparator.java
---
@@ -0,0 +1,199 @@
+/*
+ *
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1566#issuecomment-180152337
Hello @tillrohrmann please review the commit as the work to be done is
nearly complete I believe. Please comment.
---
If your project is set up for it, you can reply to
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1566#issuecomment-179599473
Hello @tillrohrmann ..I have made all the changes you have mentioned.
- support for CompositeType.
- added test cases for both primitive type & composite
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1566#discussion_r51551151
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/GenericArrayComparator.java
---
@@ -0,0 +1,205 @@
+/*
+ *
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1566#issuecomment-178174969
@tillrohrmann Thanks for the review. I had a few questions based on your
comments. Kindly help me in getting the questions answered so that I can
proceed.
---
If your
Github user sbcd90 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1566#discussion_r51476173
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/GenericArrayComparator.java
---
@@ -0,0 +1,205 @@
+/*
+ * Licensed to
Github user sbcd90 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1566#discussion_r51476344
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/typeutils/base/GenericArrayComparatorTest.java
---
@@ -0,0 +1,82 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1566#discussion_r51453634
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/GenericArrayComparator.java
---
@@ -0,0 +1,205 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1566#discussion_r51453680
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/typeutils/base/GenericArrayComparatorTest.java
---
@@ -0,0 +1,82 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1566#discussion_r51453735
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/GenericArrayComparator.java
---
@@ -0,0 +1,205 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1566#discussion_r51453894
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/operator/DataSinkTest.java
---
@@ -311,7 +311,7 @@ public void testPojoSingleOrderFull() {
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1566#issuecomment-178097783
Thanks for your contribution @sbcd90. I think the PR needs still a bit of
work before it can be merged. The implementation of `GenericArrayComparator`
only works
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1566#discussion_r51453182
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/GenericArrayComparator.java
---
@@ -0,0 +1,205 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1566#discussion_r51448517
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/GenericArrayComparator.java
---
@@ -0,0 +1,205 @@
+/*
+ *
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1566#issuecomment-178034715
@StephanEwen could you also help reviewing the code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user sbcd90 opened a pull request:
https://github.com/apache/flink/pull/1566
[FLINK-2678]DataSet API does not support multi-dimensional arrays as keys
Hello,
@tillrohrmann I have added support for multi-dimensional arrays as keys in
Dataset api. Please review &
22 matches
Mail list logo
