Github user twalthr closed the pull request at:
https://github.com/apache/flink/pull/1624
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1624#issuecomment-184278657
You can close the PR @twalthr. It's merged (but doesn't automatically
close).
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1624#issuecomment-184170079
Thanks @twalthr. I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1624#issuecomment-183640190
Thanks for reviewing @fhueske!
I updated my PR and rebased it.
Feel free to merge ;-)
---
If your project is set up for it, you can reply to this email and have
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1624#issuecomment-183251312
Hi, I thought about using POJOs as native types within Table/SQL operators.
IMO, the gains are very little compared to the added code complexity. Given a
POJO input, we
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1624#issuecomment-183287252
Ah, OK :-)
I have to admit that I didn't look at the changes in detail but noticed
that they go into several places of the code gen. Hence, I was wondering if it
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1624#discussion_r52731697
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/java/table/TableEnvironment.scala
---
@@ -75,5 +75,15 @@ class TableEnvironment {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1624#discussion_r52740335
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -231,29 +252,40 @@ class CodeGenerator(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1624#discussion_r52739425
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -42,13 +42,30 @@ import
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1624#issuecomment-183268426
Hi @fhueske,
I completely share your opinion. This PR does exactly what you described.
As you can read in `DataSetSource`: "It ensures that types without
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1624#discussion_r52739054
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala
---
@@ -150,7 +151,11 @@ object CodeGenUtils {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1624#discussion_r52739359
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -42,13 +42,30 @@ import
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1624#discussion_r52731336
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/java/table/TableEnvironment.scala
---
@@ -75,5 +75,15 @@ class TableEnvironment {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1624#discussion_r52744266
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -749,4 +867,23 @@ class CodeGenerator(
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1624#issuecomment-183349741
Thanks @twalthr, the PR looks pretty good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1624#discussion_r52741150
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala
---
@@ -150,7 +151,11 @@ object CodeGenUtils {
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/1624
[FLINK-3226] Translation from and to POJOs for CodeGenerator
This PR implements full POJO support as input and output type of the Table
API. It is now possible to convert from an arbitrary type to
17 matches
Mail list logo
