[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3348 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-04-03 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r109387705 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java --- @@ -67,6 +67,14 @@ key("taskmanager.net.memory.

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-04-03 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r109387164 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -391,9 +395,26 @@ public Task( // finally, create

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-04-03 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r109386391 --- Diff: docs/monitoring/metrics.md --- @@ -657,6 +657,24 @@ Thus, in order to infer the metric identifier: outPoolUsage An estimate of

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-03-14 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r105898097 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -389,11 +389,20 @@ public Task( ++counter;

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-03-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r105895733 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -389,11 +389,20 @@ public Task( ++counter;

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-03-14 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r105891947 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateMetrics.java --- @@ -0,0 +1,168 @@ +/* + * Licen

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-03-14 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r105891279 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -389,11 +389,20 @@ public Task( ++counter;

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-03-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r105753418 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateMetrics.java --- @@ -0,0 +1,168 @@ +/* + * Lice

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-03-13 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r105742696 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateMetrics.java --- @@ -0,0 +1,168 @@ +/* + * Licen

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-03-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r104388593 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateMetrics.java --- @@ -0,0 +1,168 @@ +/* + * Lice

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-03-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r103948091 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateMetrics.java --- @@ -0,0 +1,168 @@ +/* + * Lice

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-03-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r103936964 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -389,11 +389,20 @@ public Task( ++counter;

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-02-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r102427382 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateMetrics.java --- @@ -0,0 +1,167 @@ +/* + * Lice

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-02-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r102227821 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -227,6 +227,14 @@ public static final String TASK_MANAGE

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-02-21 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r102223763 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -227,6 +227,14 @@ public static final String TASK_MANAGER

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-02-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r102210056 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -227,6 +227,14 @@ public static final String TASK_MANAGE

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-02-21 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r102207017 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionMetrics.java --- @@ -0,0 +1,136 @@ +/* + * Licensed

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-02-21 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r102206831 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateMetrics.java --- @@ -0,0 +1,167 @@ +/* + * Licen

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-02-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r101992784 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -385,6 +388,20 @@ public Task( ++counter;

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-02-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r101993135 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionMetrics.java --- @@ -0,0 +1,136 @@ +/* + * License

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-02-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r101993111 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateMetrics.java --- @@ -0,0 +1,167 @@ +/* + * Lice

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-02-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r101993298 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -227,6 +227,12 @@ public static final String TASK_MANAGE

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-02-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r101991021 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -227,6 +227,12 @@ public static final String TASK_MANAGE

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-02-17 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3348 [FLINK-5090] [network] Add metrics for details about inbound/outbound network queues These metrics are optimised go go through the channels only once in order to gather all metrics, i.e. min, max,