Github user StephanEwen closed the pull request at:
https://github.com/apache/flink/pull/4907
---
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r147121427
--- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java ---
@@ -243,11 +245,19 @@ else if (directory.exists()) {
* @throws
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r147093502
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r147092074
--- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java ---
@@ -243,11 +245,19 @@ else if (directory.exists()) {
* @throws
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r147091056
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsStateBackendFactory.java
---
@@ -18,45 +18,41 @@
package
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r147090655
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsStateBackend.java
---
@@ -18,54 +18,92 @@
package
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r147090207
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/AbstractFileStateBackend.java
---
@@ -0,0 +1,206 @@
+/*
+ *
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r147089435
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ConfigurableStateBackend.java
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r147089325
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraphBuilder.java
---
@@ -229,29 +229,31 @@ public static
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r147089150
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -116,6 +117,10 @@
* accessing this
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r147088900
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r147088825
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r147031787
--- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java ---
@@ -243,11 +245,19 @@ else if (directory.exists()) {
* @throws
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r146993120
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendLoadingTest.java
---
@@ -48,75 +53,249 @@
private final
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r146990927
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/AbstractFileStateBackend.java
---
@@ -0,0 +1,206 @@
+/*
+ *
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r146991686
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsStateBackend.java
---
@@ -18,54 +18,92 @@
package
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r146992430
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsStateBackendFactory.java
---
@@ -18,45 +18,41 @@
package
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r146985691
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r146987131
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraphBuilder.java
---
@@ -229,29 +229,31 @@ public static
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r146984727
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r146987476
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -116,6 +117,10 @@
* accessing this
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r146988381
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ConfigurableStateBackend.java
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r146985767
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/4907
[FLINK-5823] [checkpoints] State Backends also handle Checkpoint Metadata
(part 1)
This is an incremental (first part) rebuild of #3522 on the latest master.
For ease of review, broken
24 matches
Mail list logo
