[GitHub] flink pull request #5726: [FLINK-9028][flip6] perform parameters checking be...

2018-03-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5726 ---

[GitHub] flink pull request #5726: [FLINK-9028][flip6] perform parameters checking be...

2018-03-20 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5726#discussion_r175772251 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -409,6 +411,12 @@ public void

[GitHub] flink pull request #5726: [FLINK-9028][flip6] perform parameters checking be...

2018-03-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5726#discussion_r175752794 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -409,6 +411,12 @@ public void

[GitHub] flink pull request #5726: [FLINK-9028][flip6] perform parameters checking be...

2018-03-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5726#discussion_r175750636 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/ResourceManagerRuntimeServicesTest.java --- @@ -0,0 +1,58 @@ +/*

[GitHub] flink pull request #5726: [FLINK-9028][flip6] perform parameters checking be...

2018-03-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5726#discussion_r175750782 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -423,6 +431,9 @@ public void

[GitHub] flink pull request #5726: [FLINK-9028][flip6] perform parameters checking be...

2018-03-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5726#discussion_r175752251 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -409,6 +411,12 @@ public void

[GitHub] flink pull request #5726: [FLINK-9028][flip6] perform parameters checking be...

2018-03-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5726#discussion_r175753301 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/ContaineredTaskManagerParameters.java --- @@ -112,35 +113,11 @@ public

[GitHub] flink pull request #5726: [FLINK-9028][flip6] perform parameters checking be...

2018-03-20 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5726#discussion_r175715354 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -476,6 +477,11 @@ public ApplicationId

[GitHub] flink pull request #5726: [FLINK-9028][flip6] perform parameters checking be...

2018-03-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5726#discussion_r175701852 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -476,6 +477,11 @@ public ApplicationId