[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863750#comment-15863750 ] ASF GitHub Bot commented on FLINK-3002: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863729#comment-15863729 ] ASF GitHub Bot commented on FLINK-3002: --- Github user helfper commented on a diff in the pull

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013228#comment-15013228 ] ASF GitHub Bot commented on FLINK-3002: --- Github user vasia commented on the pull request:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013380#comment-15013380 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013480#comment-15013480 ] ASF GitHub Bot commented on FLINK-3002: --- Github user twalthr commented on the pull request:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013429#comment-15013429 ] ASF GitHub Bot commented on FLINK-3002: --- Github user vasia commented on the pull request:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013492#comment-15013492 ] ASF GitHub Bot commented on FLINK-3002: --- Github user vasia commented on the pull request:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013523#comment-15013523 ] ASF GitHub Bot commented on FLINK-3002: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011428#comment-15011428 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011315#comment-15011315 ] ASF GitHub Bot commented on FLINK-3002: --- Github user vasia commented on the pull request:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011782#comment-15011782 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011787#comment-15011787 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011810#comment-15011810 ] ASF GitHub Bot commented on FLINK-3002: --- Github user vasia commented on a diff in the pull request:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011815#comment-15011815 ] ASF GitHub Bot commented on FLINK-3002: --- Github user vasia commented on a diff in the pull request:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011838#comment-15011838 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011790#comment-15011790 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011780#comment-15011780 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011778#comment-15011778 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011796#comment-15011796 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011843#comment-15011843 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010663#comment-15010663 ] ASF GitHub Bot commented on FLINK-3002: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010660#comment-15010660 ] ASF GitHub Bot commented on FLINK-3002: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010963#comment-15010963 ] ASF GitHub Bot commented on FLINK-3002: --- Github user gyfora commented on the pull request:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010961#comment-15010961 ] ASF GitHub Bot commented on FLINK-3002: --- Github user gyfora commented on the pull request:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010971#comment-15010971 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010972#comment-15010972 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010981#comment-15010981 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010988#comment-15010988 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010983#comment-15010983 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010976#comment-15010976 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010978#comment-15010978 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010975#comment-15010975 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010987#comment-15010987 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010986#comment-15010986 ] ASF GitHub Bot commented on FLINK-3002: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008883#comment-15008883 ] Vasia Kalavri commented on FLINK-3002: -- Alright, specifically creating a {{Left}} means I can reuse

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008784#comment-15008784 ] Vasia Kalavri commented on FLINK-3002: -- No, in fact, I didn't go with the abstract version :-) I do

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008831#comment-15008831 ] Stephan Ewen commented on FLINK-3002: - The thing about {{Either}} is that you never create an

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008853#comment-15008853 ] Vasia Kalavri commented on FLINK-3002: -- I agree [~StephanEwen], that was my reasoning as well. What

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008861#comment-15008861 ] Stephan Ewen commented on FLINK-3002: - All object reuse is optional to be done where possible. If you

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008836#comment-15008836 ] Aljoscha Krettek commented on FLINK-3002: - Hi, you can remove the {{isLeft}}/{{isRight}} fields,

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008740#comment-15008740 ] Stephan Ewen commented on FLINK-3002: - You went with the abstract class version, that is good, IMHO.

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009354#comment-15009354 ] ASF GitHub Bot commented on FLINK-3002: --- GitHub user vasia opened a pull request:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005360#comment-15005360 ] Vasia Kalavri commented on FLINK-3002: -- Here's my first take on this:

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003872#comment-15003872 ] Fabian Hueske commented on FLINK-3002: -- I am not exactly sure what you mean. Type inference should

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004298#comment-15004298 ] Nick Dimiduk commented on FLINK-3002: - Is the desire for a general {{Maybe}}, or a slightly more

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003844#comment-15003844 ] Vasia Kalavri commented on FLINK-3002: -- I took a look at Scala's Either and at existing types in the

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003866#comment-15003866 ] Vasia Kalavri commented on FLINK-3002: -- Thanks Fabian! A problem with this is that I cannot define

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003853#comment-15003853 ] Fabian Hueske commented on FLINK-3002: -- I would not implement Either as an abstract class, but as a

[jira] [Commented] (FLINK-3002) Add an EitherType to the Java API

[ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003921#comment-15003921 ] Vasia Kalavri commented on FLINK-3002: -- Maybe I misunderstood you. What I mean is that I cannot do