[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-03-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902941#comment-15902941 ] ASF GitHub Bot commented on FLINK-5824: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901388#comment-15901388 ] ASF GitHub Bot commented on FLINK-5824: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-03-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899839#comment-15899839 ] ASF GitHub Bot commented on FLINK-5824: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-03-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899543#comment-15899543 ] ASF GitHub Bot commented on FLINK-5824: --- Github user dawidwys commented on the issue:

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-03-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899233#comment-15899233 ] ASF GitHub Bot commented on FLINK-5824: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897189#comment-15897189 ] ASF GitHub Bot commented on FLINK-5824: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897179#comment-15897179 ] ASF GitHub Bot commented on FLINK-5824: --- Github user shijinkui commented on the issue:

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897062#comment-15897062 ] ASF GitHub Bot commented on FLINK-5824: --- Github user dawidwys commented on the issue:

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895624#comment-15895624 ] ASF GitHub Bot commented on FLINK-5824: --- Github user shijinkui commented on the issue:

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894244#comment-15894244 ] ASF GitHub Bot commented on FLINK-5824: --- GitHub user dawidwys opened a pull request:

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-02-21 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876695#comment-15876695 ] Dawid Wysakowicz commented on FLINK-5824: - I've fixed all direct String <> bytes conversions as

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-02-21 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876215#comment-15876215 ] Dawid Wysakowicz commented on FLINK-5824: - Right now such a regex will match also for

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-02-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875987#comment-15875987 ] Stephan Ewen commented on FLINK-5824: - Will a regex pattern for {{getBytes()}} currently match methods

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-02-21 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875649#comment-15875649 ] Dawid Wysakowicz commented on FLINK-5824: - Just two more questions. First I tried to investigate

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-02-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874735#comment-15874735 ] Stephan Ewen commented on FLINK-5824: - I don't think we need it to be configurable at the moment.

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-02-17 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871737#comment-15871737 ] Dawid Wysakowicz commented on FLINK-5824: - [~StephanEwen] Sure, will do it. We don't want it to be

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-02-17 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871722#comment-15871722 ] Stephan Ewen commented on FLINK-5824: - I think some names in checkpoints are serialized in the default

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-02-17 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871455#comment-15871455 ] Ufuk Celebi commented on FLINK-5824: [~dawidwys] I've just assigned it to you. [~StephanEwen]

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-02-17 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871428#comment-15871428 ] Dawid Wysakowicz commented on FLINK-5824: - I would be glad to help with this issue, if it is ok

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-02-16 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869989#comment-15869989 ] Stephan Ewen commented on FLINK-5824: - We should add a checkstyle rule that forbids