[jira] [Commented] (FLINK-9152) Harmonize BroadcastProcessFunction Context names

[Aljoscha Krettek (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436419#comment-16436419
 ] 

Aljoscha Krettek commented on FLINK-9152:
-

Fixed on release-1.5 in
833b83b3c2
179b9bce2f
24a8f5186c
51beea6e23

> Harmonize BroadcastProcessFunction Context names
> 
>
> Key: FLINK-9152
> URL: https://issues.apache.org/jira/browse/FLINK-9152
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Affects Versions: 1.5.0
>Reporter: Aljoscha Krettek
>Assignee: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.5.0
>
>
> Currently, the {{Context}} on {{KeyedBroadcastProcessFunction}} is called 
> {{KeyedContext}}, which is different from the name of the context on 
> {{BroadcastProcessFunction}}. This leads to the strange combination of
> {code:java}
> public abstract void processBroadcastElement(final IN2 value, final 
> KeyedContext ctx, final Collector out) throws Exception;
> {code}
> i.e. you're processing a broadcast element but the context is called a 
> "keyed" context.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9152) Harmonize BroadcastProcessFunction Context names

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435818#comment-16435818
 ] 

ASF GitHub Bot commented on FLINK-9152:
---

Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/5830
  
Thanks for the review! I merged


> Harmonize BroadcastProcessFunction Context names
> 
>
> Key: FLINK-9152
> URL: https://issues.apache.org/jira/browse/FLINK-9152
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Affects Versions: 1.5.0
>Reporter: Aljoscha Krettek
>Assignee: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.5.0
>
>
> Currently, the {{Context}} on {{KeyedBroadcastProcessFunction}} is called 
> {{KeyedContext}}, which is different from the name of the context on 
> {{BroadcastProcessFunction}}. This leads to the strange combination of
> {code:java}
> public abstract void processBroadcastElement(final IN2 value, final 
> KeyedContext ctx, final Collector out) throws Exception;
> {code}
> i.e. you're processing a broadcast element but the context is called a 
> "keyed" context.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9152) Harmonize BroadcastProcessFunction Context names

[Aljoscha Krettek (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435817#comment-16435817
 ] 

Aljoscha Krettek commented on FLINK-9152:
-

Fixed on master in
584229dc00e62a6a8540b059645269bb04d0ba04
0838bbeaafed791d96bfd1e8e1f8a5e486c35325
48d05f12eac28a7f66dee68e0a0bff557e26
f3d4011f80b3d6b25e55a354d1a41928074f02a0

> Harmonize BroadcastProcessFunction Context names
> 
>
> Key: FLINK-9152
> URL: https://issues.apache.org/jira/browse/FLINK-9152
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Affects Versions: 1.5.0
>Reporter: Aljoscha Krettek
>Assignee: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.5.0
>
>
> Currently, the {{Context}} on {{KeyedBroadcastProcessFunction}} is called 
> {{KeyedContext}}, which is different from the name of the context on 
> {{BroadcastProcessFunction}}. This leads to the strange combination of
> {code:java}
> public abstract void processBroadcastElement(final IN2 value, final 
> KeyedContext ctx, final Collector out) throws Exception;
> {code}
> i.e. you're processing a broadcast element but the context is called a 
> "keyed" context.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9152) Harmonize BroadcastProcessFunction Context names

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435819#comment-16435819
 ] 

ASF GitHub Bot commented on FLINK-9152:
---

Github user aljoscha closed the pull request at:

https://github.com/apache/flink/pull/5830


> Harmonize BroadcastProcessFunction Context names
> 
>
> Key: FLINK-9152
> URL: https://issues.apache.org/jira/browse/FLINK-9152
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Affects Versions: 1.5.0
>Reporter: Aljoscha Krettek
>Assignee: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.5.0
>
>
> Currently, the {{Context}} on {{KeyedBroadcastProcessFunction}} is called 
> {{KeyedContext}}, which is different from the name of the context on 
> {{BroadcastProcessFunction}}. This leads to the strange combination of
> {code:java}
> public abstract void processBroadcastElement(final IN2 value, final 
> KeyedContext ctx, final Collector out) throws Exception;
> {code}
> i.e. you're processing a broadcast element but the context is called a 
> "keyed" context.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9152) Harmonize BroadcastProcessFunction Context names

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432864#comment-16432864
 ] 

ASF GitHub Bot commented on FLINK-9152:
---

Github user kl0u commented on a diff in the pull request:

https://github.com/apache/flink/pull/5830#discussion_r180538022
  
--- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/co/CoBroadcastWithKeyedOperator.java
 ---
@@ -33,6 +33,8 @@
 import org.apache.flink.streaming.api.TimeDomain;
 import org.apache.flink.streaming.api.TimerService;
 import 
org.apache.flink.streaming.api.functions.co.KeyedBroadcastProcessFunction;
+import 
org.apache.flink.streaming.api.functions.co.KeyedBroadcastProcessFunction.Context;
--- End diff --

Unused import.


> Harmonize BroadcastProcessFunction Context names
> 
>
> Key: FLINK-9152
> URL: https://issues.apache.org/jira/browse/FLINK-9152
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Affects Versions: 1.5.0
>Reporter: Aljoscha Krettek
>Assignee: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.5.0
>
>
> Currently, the {{Context}} on {{KeyedBroadcastProcessFunction}} is called 
> {{KeyedContext}}, which is different from the name of the context on 
> {{BroadcastProcessFunction}}. This leads to the strange combination of
> {code:java}
> public abstract void processBroadcastElement(final IN2 value, final 
> KeyedContext ctx, final Collector out) throws Exception;
> {code}
> i.e. you're processing a broadcast element but the context is called a 
> "keyed" context.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9152) Harmonize BroadcastProcessFunction Context names

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432865#comment-16432865
 ] 

ASF GitHub Bot commented on FLINK-9152:
---

Github user kl0u commented on a diff in the pull request:

https://github.com/apache/flink/pull/5830#discussion_r180541190
  
--- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/co/KeyedBroadcastProcessFunction.java
 ---
@@ -89,11 +89,11 @@
 * query the current processing/event time, and also query and update 
the internal
 * {@link org.apache.flink.api.common.state.BroadcastState broadcast 
state}. In addition, it
 * can register a {@link KeyedStateFunction function} to be applied to 
all keyed states on
-* the local partition. These can be done through the provided {@link 
Context}.
+* the local partition. These can be done through the provided {@link 
BaseBroadcastProcessFunction.Context}.
 * The context is only valid during the invocation of this method, do 
not store it.
 *
 * @param value The stream element.
-* @param ctx A {@link Context} that allows querying the timestamp of 
the element,
+* @param ctx A {@link BaseBroadcastProcessFunction.Context} that 
allows querying the timestamp of the element,
--- End diff --

Remove the `BaseBroadcastProcessFunction`.


> Harmonize BroadcastProcessFunction Context names
> 
>
> Key: FLINK-9152
> URL: https://issues.apache.org/jira/browse/FLINK-9152
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Affects Versions: 1.5.0
>Reporter: Aljoscha Krettek
>Assignee: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.5.0
>
>
> Currently, the {{Context}} on {{KeyedBroadcastProcessFunction}} is called 
> {{KeyedContext}}, which is different from the name of the context on 
> {{BroadcastProcessFunction}}. This leads to the strange combination of
> {code:java}
> public abstract void processBroadcastElement(final IN2 value, final 
> KeyedContext ctx, final Collector out) throws Exception;
> {code}
> i.e. you're processing a broadcast element but the context is called a 
> "keyed" context.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9152) Harmonize BroadcastProcessFunction Context names

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432863#comment-16432863
 ] 

ASF GitHub Bot commented on FLINK-9152:
---

Github user kl0u commented on a diff in the pull request:

https://github.com/apache/flink/pull/5830#discussion_r180541104
  
--- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/co/KeyedBroadcastProcessFunction.java
 ---
@@ -89,11 +89,11 @@
 * query the current processing/event time, and also query and update 
the internal
 * {@link org.apache.flink.api.common.state.BroadcastState broadcast 
state}. In addition, it
 * can register a {@link KeyedStateFunction function} to be applied to 
all keyed states on
-* the local partition. These can be done through the provided {@link 
Context}.
+* the local partition. These can be done through the provided {@link 
BaseBroadcastProcessFunction.Context}.
--- End diff --

Remove the `BaseBroadcastProcessFunction`.


> Harmonize BroadcastProcessFunction Context names
> 
>
> Key: FLINK-9152
> URL: https://issues.apache.org/jira/browse/FLINK-9152
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Affects Versions: 1.5.0
>Reporter: Aljoscha Krettek
>Assignee: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.5.0
>
>
> Currently, the {{Context}} on {{KeyedBroadcastProcessFunction}} is called 
> {{KeyedContext}}, which is different from the name of the context on 
> {{BroadcastProcessFunction}}. This leads to the strange combination of
> {code:java}
> public abstract void processBroadcastElement(final IN2 value, final 
> KeyedContext ctx, final Collector out) throws Exception;
> {code}
> i.e. you're processing a broadcast element but the context is called a 
> "keyed" context.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9152) Harmonize BroadcastProcessFunction Context names

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431481#comment-16431481
 ] 

ASF GitHub Bot commented on FLINK-9152:
---

GitHub user aljoscha opened a pull request:

https://github.com/apache/flink/pull/5830

[FLINK-9152] Harmonize BroadcastProcessFunction Context names

R: @kl0u 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aljoscha/flink 
jira-9152-harmonize-broadcast-connect

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5830.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5830


commit 8866c314e79c09c2093b2863d56787435f5d0fb5
Author: Aljoscha Krettek 
Date:   2018-04-09T23:08:58Z

[FLINK-9152] Harmonize BroadcastProcessFunction Context names

commit 6af7b661ddf41022d7fa25a36c8fa5c21096ef1e
Author: Aljoscha Krettek 
Date:   2018-04-09T23:12:43Z

[FLINK-9252] Use in-class Context objects in BroadcastProcessFunction

This brings it in line with KeyedBroadcastProcessFunction, which uses
context objects defined in KeyedBroadcastProcessFunction. The context
objects here have no added functionality but we still define them here
so that the methods don't refer to the base class implementations for
consistency.




> Harmonize BroadcastProcessFunction Context names
> 
>
> Key: FLINK-9152
> URL: https://issues.apache.org/jira/browse/FLINK-9152
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API
>Affects Versions: 1.5.0
>Reporter: Aljoscha Krettek
>Assignee: Aljoscha Krettek
>Priority: Blocker
> Fix For: 1.5.0
>
>
> Currently, the {{Context}} on {{KeyedBroadcastProcessFunction}} is called 
> {{KeyedContext}}, which is different from the name of the context on 
> {{BroadcastProcessFunction}}. This leads to the strange combination of
> {code:java}
> public abstract void processBroadcastElement(final IN2 value, final 
> KeyedContext ctx, final Collector out) throws Exception;
> {code}
> i.e. you're processing a broadcast element but the context is called a 
> "keyed" context.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)