[jira] [Commented] (GEODE-7496) Decouple management API from Gfsh RebalanceCommand

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984035#comment-16984035
 ] 

ASF subversion and git services commented on GEODE-7496:


Commit 94ec51b35e7c7a14b73397426753410567ba1d91 in geode's branch 
refs/heads/develop from Patrick Johnson
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=94ec51b ]

GEODE-7496 - Decouple management API from Gfsh RebalanceCommand (#4370)




> Decouple management API from Gfsh RebalanceCommand
> --
>
> Key: GEODE-7496
> URL: https://issues.apache.org/jira/browse/GEODE-7496
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Johnsn
>Priority: Major
>  Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-4187) PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery hangs

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984027#comment-16984027
 ] 

ASF subversion and git services commented on GEODE-4187:


Commit e938d66a735a8668e93f256bcc8acbd6da31bc1e in geode's branch 
refs/heads/feature/GEODE-7507 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e938d66 ]

GEODE-4187: Use AtomicReference for missingColocatedRegionLogger

* Use AtomicReference for PartitionedRegion missingColocatedRegionLogger
* Make PR methods that use missingColocatedRegionLogger more thread-safe
* Add no-arg flavor of CancelCriterion.checkCancelInProgress()


> PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery 
> hangs
> ---
>
> Key: GEODE-4187
> URL: https://issues.apache.org/jira/browse/GEODE-4187
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Lynn Gallinat
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Analysis from Dan Smith:
> The hang in distributedTests was in 
> PersistentColocatedPartitionedRegionDUnitTest testRebalanceDuringRecovery. I 
> don’t know if there is any more info we have other than that this test hung, 
> but it was stuck for at least an hour and a half before concourse killed the 
> job:
> ~/Downloads/progress.darwin hang distributedTest-progress.txt 
> Started @ 2017-12-28 18:30:31.703 +
> 2017-12-28 19:14:15.760 +  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  testRebalanceDuringRecovery
> Ended @ 2017-12-28 20:50:53.673 +
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/51



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7507) remove GMSMembership's dependency on DistributionMessage

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984029#comment-16984029
 ] 

ASF subversion and git services commented on GEODE-7507:


Commit 8c42458f71a6ab4853be3971bae5fed756cd009a in geode's branch 
refs/heads/feature/GEODE-7507 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=8c42458 ]

GEODE-7507 remove GMSMembership's dependency on DistributionMessage

Prior to this change-set the membership module wrapped all messages in a
GMSMessageAdapter.  This is no longer necessary and I've deleted that
class.  Instead, our messages now implement GMSMessage (now renamed
DistributionMessage) and the geode-core abstract DistributionMessage
class (now renamed ClusterMessage) implements the membership module's
API.

Most of the files in the diff are only affected by the renaming of
GMSMessage and DistributionMessage.  The primary changes are in GMSManager
and DistributionMessage (now named ClusterMessage).


> remove GMSMembership's dependency on DistributionMessage
> 
>
> Key: GEODE-7507
> URL: https://issues.apache.org/jira/browse/GEODE-7507
> Project: Geode
>  Issue Type: Improvement
>  Components: membership
>Reporter: Bruce J Schuchardt
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> GMSMembership should not refer to DistributionMessage, a geode-core class.  
> This is preventing membership from being moved to a separate sub-project.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7436) Ability: can recognize version part when deploy function jar in GFSH

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984028#comment-16984028
 ] 

ASF subversion and git services commented on GEODE-7436:


Commit 3b85e5cb88ff62b0e0a3ac3c35c70e15fad292a2 in geode's branch 
refs/heads/feature/GEODE-7507 from Jinmei Liao
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=3b85e5c ]

GEODE-7436: Deploy jar using semantic versioning scheme  (#4382)

Co-authored-by: Dale Emery 
Co-authored-by: Jinmei Liao 
Co-authored-by: Darrel Schneider 
Co-authored-by: Joris Melchior 

* Deploy jar using semantic versioning scheme
* always add sequence number at the end of the filename no matter what version 
scheme the deployed file uses.

* fix window's tests


> Ability: can recognize version part when deploy function jar in GFSH
> 
>
> Key: GEODE-7436
> URL: https://issues.apache.org/jira/browse/GEODE-7436
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh, management
>Reporter: Gang Yan
>Priority: Major
>  Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> # WHAT
>  1. recognize version part of file name,  for the file to be deployed
>  1. can recognize version pattern. "filename-version[label].jar" .
>   filename=[a-zA-Z/-]+,  not single "-",  not end with "-"
>   version=[0-9/.]*,  not single ".",  not end with "."
>   label=[-/.]{1}[a-zA-Z0-9]*
> such as:
>  -is a later version of 
> , will deploy.
>  -is a same version of 
> ,  the later wins
>  -is a same version of 
> ,  the later wins



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7082) PersistentColocatedPartitionedRegionDUnitTest.testReplaceOfflineMemberAndRestartCreateColocatedPRLate hung or took too long

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984026#comment-16984026
 ] 

ASF subversion and git services commented on GEODE-7082:


Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch 
refs/heads/feature/GEODE-7507 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]

GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest

Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
  hang

Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently

Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest

Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService

Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances

Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender


> PersistentColocatedPartitionedRegionDUnitTest.testReplaceOfflineMemberAndRestartCreateColocatedPRLate
>  hung or took too long 
> 
>
> Key: GEODE-7082
> URL: https://issues.apache.org/jira/browse/GEODE-7082
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Mark Hanson
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
> Attachments: callstacks-2019-08-12-19-22-55.txt, 
> callstacks-2019-08-12-19-23-06.txt, callstacks-2019-08-12-19-23-16.txt, 
> dunit-hangs.txt
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/981]
> The run of the distributed test for java 8 failed because a timeout was 
> exceeded.
> I've attached the dunit-hangs.txt and callstack files from dunit #981. It 
> looks like 
> PersistentColocatedPartitionedRegionDUnitTest.testReplaceOfflineMemberAndRestartCreateColocatedPRLate
>  hung. Several threads are trying to create buckets while another is trying 
> to shutdown the cluster. Thread stacks are below.
> There are several threads creating buckets and stuck waiting for replies to 
> PrepareNewPersistentMemberMessage:
> {noformat}
> "Pooled Waiting Message Processor 6" #2393 daemon prio=5 os_prio=0 
> tid=0x7f29a0005800 nid=0x1a84 waiting on condition [0x7f2bd28c5000]
>java.lang.Thread.State: TIMED_WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for  <0xe1fb4410> (a 
> java.util.concurrent.CountDownLatch$Sync)
> at 
> java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedNanos(AbstractQueuedSynchronizer.java:1037)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1328)
> at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:277)
> at 
> org.apache.geode.internal.util.concurrent.StoppableCountDownLatch.await(StoppableCountDownLatch.java:72)
> at 
> org.apache.geode.distributed.internal.ReplyProcessor21.basicWait(ReplyProcessor21.java:732)
> at 
> org.apache.geode.distributed.internal.ReplyProcessor21.waitForRepliesUninterruptibly(ReplyProcessor21.java:803)
> at 
> org.apache.geode.distributed.internal.ReplyProcessor21.waitForRepliesUninterruptibly(ReplyProcessor21.java:780)
> at 
> org.apache.geode.distributed.internal.ReplyProcessor21.waitForRepliesUninterruptibly(ReplyProcessor21.java:866)
> at 
> org.apache.geode.internal.cache.persistence.PrepareNewPersistentMemberMessage.send(PrepareNewPersistentMemberMessage.java:79)
> at 
> 

[jira] [Commented] (GEODE-7436) Ability: can recognize version part when deploy function jar in GFSH

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984013#comment-16984013
 ] 

ASF subversion and git services commented on GEODE-7436:


Commit 3b85e5cb88ff62b0e0a3ac3c35c70e15fad292a2 in geode's branch 
refs/heads/feature/GEODE-7507 from Jinmei Liao
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=3b85e5c ]

GEODE-7436: Deploy jar using semantic versioning scheme  (#4382)

Co-authored-by: Dale Emery 
Co-authored-by: Jinmei Liao 
Co-authored-by: Darrel Schneider 
Co-authored-by: Joris Melchior 

* Deploy jar using semantic versioning scheme
* always add sequence number at the end of the filename no matter what version 
scheme the deployed file uses.

* fix window's tests


> Ability: can recognize version part when deploy function jar in GFSH
> 
>
> Key: GEODE-7436
> URL: https://issues.apache.org/jira/browse/GEODE-7436
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh, management
>Reporter: Gang Yan
>Priority: Major
>  Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> # WHAT
>  1. recognize version part of file name,  for the file to be deployed
>  1. can recognize version pattern. "filename-version[label].jar" .
>   filename=[a-zA-Z/-]+,  not single "-",  not end with "-"
>   version=[0-9/.]*,  not single ".",  not end with "."
>   label=[-/.]{1}[a-zA-Z0-9]*
> such as:
>  -is a later version of 
> , will deploy.
>  -is a same version of 
> ,  the later wins
>  -is a same version of 
> ,  the later wins



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7082) PersistentColocatedPartitionedRegionDUnitTest.testReplaceOfflineMemberAndRestartCreateColocatedPRLate hung or took too long

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984011#comment-16984011
 ] 

ASF subversion and git services commented on GEODE-7082:


Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch 
refs/heads/feature/GEODE-7507 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]

GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest

Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
  hang

Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently

Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest

Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService

Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances

Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender


> PersistentColocatedPartitionedRegionDUnitTest.testReplaceOfflineMemberAndRestartCreateColocatedPRLate
>  hung or took too long 
> 
>
> Key: GEODE-7082
> URL: https://issues.apache.org/jira/browse/GEODE-7082
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Mark Hanson
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
> Attachments: callstacks-2019-08-12-19-22-55.txt, 
> callstacks-2019-08-12-19-23-06.txt, callstacks-2019-08-12-19-23-16.txt, 
> dunit-hangs.txt
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/981]
> The run of the distributed test for java 8 failed because a timeout was 
> exceeded.
> I've attached the dunit-hangs.txt and callstack files from dunit #981. It 
> looks like 
> PersistentColocatedPartitionedRegionDUnitTest.testReplaceOfflineMemberAndRestartCreateColocatedPRLate
>  hung. Several threads are trying to create buckets while another is trying 
> to shutdown the cluster. Thread stacks are below.
> There are several threads creating buckets and stuck waiting for replies to 
> PrepareNewPersistentMemberMessage:
> {noformat}
> "Pooled Waiting Message Processor 6" #2393 daemon prio=5 os_prio=0 
> tid=0x7f29a0005800 nid=0x1a84 waiting on condition [0x7f2bd28c5000]
>java.lang.Thread.State: TIMED_WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for  <0xe1fb4410> (a 
> java.util.concurrent.CountDownLatch$Sync)
> at 
> java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedNanos(AbstractQueuedSynchronizer.java:1037)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1328)
> at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:277)
> at 
> org.apache.geode.internal.util.concurrent.StoppableCountDownLatch.await(StoppableCountDownLatch.java:72)
> at 
> org.apache.geode.distributed.internal.ReplyProcessor21.basicWait(ReplyProcessor21.java:732)
> at 
> org.apache.geode.distributed.internal.ReplyProcessor21.waitForRepliesUninterruptibly(ReplyProcessor21.java:803)
> at 
> org.apache.geode.distributed.internal.ReplyProcessor21.waitForRepliesUninterruptibly(ReplyProcessor21.java:780)
> at 
> org.apache.geode.distributed.internal.ReplyProcessor21.waitForRepliesUninterruptibly(ReplyProcessor21.java:866)
> at 
> org.apache.geode.internal.cache.persistence.PrepareNewPersistentMemberMessage.send(PrepareNewPersistentMemberMessage.java:79)
> at 
> 

[jira] [Commented] (GEODE-4187) PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery hangs

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984022#comment-16984022
 ] 

ASF subversion and git services commented on GEODE-4187:


Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch 
refs/heads/feature/GEODE-7507 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]

GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest

Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
  hang

Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently

Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest

Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService

Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances

Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender


> PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery 
> hangs
> ---
>
> Key: GEODE-4187
> URL: https://issues.apache.org/jira/browse/GEODE-4187
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Lynn Gallinat
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Analysis from Dan Smith:
> The hang in distributedTests was in 
> PersistentColocatedPartitionedRegionDUnitTest testRebalanceDuringRecovery. I 
> don’t know if there is any more info we have other than that this test hung, 
> but it was stuck for at least an hour and a half before concourse killed the 
> job:
> ~/Downloads/progress.darwin hang distributedTest-progress.txt 
> Started @ 2017-12-28 18:30:31.703 +
> 2017-12-28 19:14:15.760 +  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  testRebalanceDuringRecovery
> Ended @ 2017-12-28 20:50:53.673 +
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/51



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7405) Documentation for describe query-service command

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984020#comment-16984020
 ] 

ASF subversion and git services commented on GEODE-7405:


Commit bdd20a288f39c4b71d7ea23806155a422e9ea409 in geode's branch 
refs/heads/feature/GEODE-7507 from Owen Nichols
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=bdd20a2 ]

GEODE-7405: Documentation for describe query-service command (#4378)

Co-authored-by: Donal Evans 
Co-authored-by: Benjamin Ross 

> Documentation for describe query-service command
> 
>
> Key: GEODE-7405
> URL: https://issues.apache.org/jira/browse/GEODE-7405
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
>  Labels: GeodeCommons
> Fix For: 1.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-4187) PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery hangs

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984023#comment-16984023
 ] 

ASF subversion and git services commented on GEODE-4187:


Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch 
refs/heads/feature/GEODE-7507 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]

GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest

Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
  hang

Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently

Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest

Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService

Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances

Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender


> PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery 
> hangs
> ---
>
> Key: GEODE-4187
> URL: https://issues.apache.org/jira/browse/GEODE-4187
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Lynn Gallinat
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Analysis from Dan Smith:
> The hang in distributedTests was in 
> PersistentColocatedPartitionedRegionDUnitTest testRebalanceDuringRecovery. I 
> don’t know if there is any more info we have other than that this test hung, 
> but it was stuck for at least an hour and a half before concourse killed the 
> job:
> ~/Downloads/progress.darwin hang distributedTest-progress.txt 
> Started @ 2017-12-28 18:30:31.703 +
> 2017-12-28 19:14:15.760 +  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  testRebalanceDuringRecovery
> Ended @ 2017-12-28 20:50:53.673 +
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/51



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-4187) PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery hangs

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984012#comment-16984012
 ] 

ASF subversion and git services commented on GEODE-4187:


Commit e938d66a735a8668e93f256bcc8acbd6da31bc1e in geode's branch 
refs/heads/feature/GEODE-7507 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e938d66 ]

GEODE-4187: Use AtomicReference for missingColocatedRegionLogger

* Use AtomicReference for PartitionedRegion missingColocatedRegionLogger
* Make PR methods that use missingColocatedRegionLogger more thread-safe
* Add no-arg flavor of CancelCriterion.checkCancelInProgress()


> PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery 
> hangs
> ---
>
> Key: GEODE-4187
> URL: https://issues.apache.org/jira/browse/GEODE-4187
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Lynn Gallinat
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Analysis from Dan Smith:
> The hang in distributedTests was in 
> PersistentColocatedPartitionedRegionDUnitTest testRebalanceDuringRecovery. I 
> don’t know if there is any more info we have other than that this test hung, 
> but it was stuck for at least an hour and a half before concourse killed the 
> job:
> ~/Downloads/progress.darwin hang distributedTest-progress.txt 
> Started @ 2017-12-28 18:30:31.703 +
> 2017-12-28 19:14:15.760 +  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  testRebalanceDuringRecovery
> Ended @ 2017-12-28 20:50:53.673 +
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/51



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7405) Documentation for describe query-service command

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984017#comment-16984017
 ] 

ASF subversion and git services commented on GEODE-7405:


Commit cc169e1f219055568483ad665375af46309ba325 in geode's branch 
refs/heads/feature/GEODE-7507 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=cc169e1 ]

GEODE-7405: Documentation for describe query-service command

Co-authored-by: Donal Evans 
Co-authored-by: Benjamin Ross 


> Documentation for describe query-service command
> 
>
> Key: GEODE-7405
> URL: https://issues.apache.org/jira/browse/GEODE-7405
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
>  Labels: GeodeCommons
> Fix For: 1.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-5175) Remove PersistentPartitionedRegionTestBase

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984024#comment-16984024
 ] 

ASF subversion and git services commented on GEODE-5175:


Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch 
refs/heads/feature/GEODE-7507 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]

GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest

Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
  hang

Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently

Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest

Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService

Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances

Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender


> Remove PersistentPartitionedRegionTestBase
> --
>
> Key: GEODE-5175
> URL: https://issues.apache.org/jira/browse/GEODE-5175
> Project: Geode
>  Issue Type: Improvement
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Minor
>
> Remove PersistentPartitionedRegionTestBase and overhaul the tests that extend 
> it:
> {noformat}
> JUnit4DistributedTestCase (org.apache.geode.test.dunit.internal)
> JUnit4CacheTestCase (org.apache.geode.test.dunit.cache.internal)
> PersistentPartitionedRegionTestBase 
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionWithTransactionDUnitTest 
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionWithDistTXDUnitTest 
> (org.apache.geode.disttx)
> PersistentColocatedPartitionedRegionDUnitTest 
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionDUnitTest 
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionOldConfigDUnitTest 
> (org.apache.geode.internal.cache.partitioned)
> BackupDistributedTest (org.apache.geode.internal.cache.backup)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-5175) Remove PersistentPartitionedRegionTestBase

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984008#comment-16984008
 ] 

ASF subversion and git services commented on GEODE-5175:


Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch 
refs/heads/feature/GEODE-7507 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]

GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest

Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
  hang

Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently

Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest

Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService

Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances

Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender


> Remove PersistentPartitionedRegionTestBase
> --
>
> Key: GEODE-5175
> URL: https://issues.apache.org/jira/browse/GEODE-5175
> Project: Geode
>  Issue Type: Improvement
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Minor
>
> Remove PersistentPartitionedRegionTestBase and overhaul the tests that extend 
> it:
> {noformat}
> JUnit4DistributedTestCase (org.apache.geode.test.dunit.internal)
> JUnit4CacheTestCase (org.apache.geode.test.dunit.cache.internal)
> PersistentPartitionedRegionTestBase 
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionWithTransactionDUnitTest 
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionWithDistTXDUnitTest 
> (org.apache.geode.disttx)
> PersistentColocatedPartitionedRegionDUnitTest 
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionDUnitTest 
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionOldConfigDUnitTest 
> (org.apache.geode.internal.cache.partitioned)
> BackupDistributedTest (org.apache.geode.internal.cache.backup)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7212) User Guide - Authorization - update security permissions

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984019#comment-16984019
 ] 

ASF subversion and git services commented on GEODE-7212:


Commit 1beaa32c128c2d30ede9b55bf3bc81d9116c1420 in geode's branch 
refs/heads/feature/GEODE-7507 from Karen Miller
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1beaa32 ]

GEODE-7212: update docs permission for CqQuery.stop() (#4371)



> User Guide - Authorization - update security permissions
> 
>
> Key: GEODE-7212
> URL: https://issues.apache.org/jira/browse/GEODE-7212
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Karen Smoler Miller
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> "Fine-grained security" changes were implemented in v1.3, but docs & Wiki 
> were only recently updated. Pick up these changes in the user guide. See 
> [https://cwiki.apache.org/confluence/display/GEODE/Finer+grained+security].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-4187) PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery hangs

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984021#comment-16984021
 ] 

ASF subversion and git services commented on GEODE-4187:


Commit a2c978c1bcc308d1a8a9f0e4b2cebdadbbedf3da in geode's branch 
refs/heads/feature/GEODE-7507 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a2c978c ]

GEODE-4187: Rename PersistentColocatedPartitionedRegionDistributedTest

Rename PersistentColocatedPartitionedRegionDUnitTest.


> PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery 
> hangs
> ---
>
> Key: GEODE-4187
> URL: https://issues.apache.org/jira/browse/GEODE-4187
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Lynn Gallinat
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Analysis from Dan Smith:
> The hang in distributedTests was in 
> PersistentColocatedPartitionedRegionDUnitTest testRebalanceDuringRecovery. I 
> don’t know if there is any more info we have other than that this test hung, 
> but it was stuck for at least an hour and a half before concourse killed the 
> job:
> ~/Downloads/progress.darwin hang distributedTest-progress.txt 
> Started @ 2017-12-28 18:30:31.703 +
> 2017-12-28 19:14:15.760 +  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  testRebalanceDuringRecovery
> Ended @ 2017-12-28 20:50:53.673 +
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/51



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-6499) PersistentColocatedPartitionedRegionDUnitTest: Timed out waiting 60000 milliseconds for AsyncInvocation to complete.

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984025#comment-16984025
 ] 

ASF subversion and git services commented on GEODE-6499:


Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch 
refs/heads/feature/GEODE-7507 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]

GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest

Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
  hang

Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently

Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest

Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService

Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances

Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender


> PersistentColocatedPartitionedRegionDUnitTest: Timed out waiting 6 
> milliseconds for AsyncInvocation to complete.
> 
>
> Key: GEODE-6499
> URL: https://issues.apache.org/jira/browse/GEODE-6499
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Mark Hanson
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
> Attachments: PersistentColocatedPartitionedRegionDUnitTest.tgz
>
>
> {noformat}
>  
> Task :geode-core:distributedTest
>  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  > testHierarchyOfColocatedChildPRsMissingGrandchild FAILED
>  java.util.concurrent.TimeoutException: Timed out waiting 6 milliseconds 
> for AsyncInvocation to complete.
>  at 
> org.apache.geode.test.dunit.AsyncInvocation.timeoutIfAlive(AsyncInvocation.java:462)
>  at org.apache.geode.test.dunit.AsyncInvocation.get(AsyncInvocation.java:412)
>  at 
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testHierarchyOfColocatedChildPRsMissingGrandchild(PersistentColocatedPartitionedRegionDUnitTest.java:979)
>  
>  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  > testMultipleColocatedChildPRsMissingWithSequencedStart FAILED
>  java.util.concurrent.TimeoutException: Timed out waiting 6 milliseconds 
> for AsyncInvocation to complete.
>  at 
> org.apache.geode.test.dunit.AsyncInvocation.timeoutIfAlive(AsyncInvocation.java:462)
>  at org.apache.geode.test.dunit.AsyncInvocation.get(AsyncInvocation.java:412)
>  at 
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testMultipleColocatedChildPRsMissingWithSequencedStart(PersistentColocatedPartitionedRegionDUnitTest.java:865)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7507) remove GMSMembership's dependency on DistributionMessage

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984014#comment-16984014
 ] 

ASF subversion and git services commented on GEODE-7507:


Commit 8c42458f71a6ab4853be3971bae5fed756cd009a in geode's branch 
refs/heads/feature/GEODE-7507 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=8c42458 ]

GEODE-7507 remove GMSMembership's dependency on DistributionMessage

Prior to this change-set the membership module wrapped all messages in a
GMSMessageAdapter.  This is no longer necessary and I've deleted that
class.  Instead, our messages now implement GMSMessage (now renamed
DistributionMessage) and the geode-core abstract DistributionMessage
class (now renamed ClusterMessage) implements the membership module's
API.

Most of the files in the diff are only affected by the renaming of
GMSMessage and DistributionMessage.  The primary changes are in GMSManager
and DistributionMessage (now named ClusterMessage).


> remove GMSMembership's dependency on DistributionMessage
> 
>
> Key: GEODE-7507
> URL: https://issues.apache.org/jira/browse/GEODE-7507
> Project: Geode
>  Issue Type: Improvement
>  Components: membership
>Reporter: Bruce J Schuchardt
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> GMSMembership should not refer to DistributionMessage, a geode-core class.  
> This is preventing membership from being moved to a separate sub-project.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-6499) PersistentColocatedPartitionedRegionDUnitTest: Timed out waiting 60000 milliseconds for AsyncInvocation to complete.

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984009#comment-16984009
 ] 

ASF subversion and git services commented on GEODE-6499:


Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch 
refs/heads/feature/GEODE-7507 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]

GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest

Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
  hang

Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently

Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest

Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService

Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances

Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender


> PersistentColocatedPartitionedRegionDUnitTest: Timed out waiting 6 
> milliseconds for AsyncInvocation to complete.
> 
>
> Key: GEODE-6499
> URL: https://issues.apache.org/jira/browse/GEODE-6499
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Mark Hanson
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
> Attachments: PersistentColocatedPartitionedRegionDUnitTest.tgz
>
>
> {noformat}
>  
> Task :geode-core:distributedTest
>  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  > testHierarchyOfColocatedChildPRsMissingGrandchild FAILED
>  java.util.concurrent.TimeoutException: Timed out waiting 6 milliseconds 
> for AsyncInvocation to complete.
>  at 
> org.apache.geode.test.dunit.AsyncInvocation.timeoutIfAlive(AsyncInvocation.java:462)
>  at org.apache.geode.test.dunit.AsyncInvocation.get(AsyncInvocation.java:412)
>  at 
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testHierarchyOfColocatedChildPRsMissingGrandchild(PersistentColocatedPartitionedRegionDUnitTest.java:979)
>  
>  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  > testMultipleColocatedChildPRsMissingWithSequencedStart FAILED
>  java.util.concurrent.TimeoutException: Timed out waiting 6 milliseconds 
> for AsyncInvocation to complete.
>  at 
> org.apache.geode.test.dunit.AsyncInvocation.timeoutIfAlive(AsyncInvocation.java:462)
>  at org.apache.geode.test.dunit.AsyncInvocation.get(AsyncInvocation.java:412)
>  at 
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testMultipleColocatedChildPRsMissingWithSequencedStart(PersistentColocatedPartitionedRegionDUnitTest.java:865)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7410) Add private pipeline and team support to metrics pipeline

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984018#comment-16984018
 ] 

ASF subversion and git services commented on GEODE-7410:


Commit c80b232d98399bcf2123cbf1bd4e88dd17c82340 in geode's branch 
refs/heads/feature/GEODE-7507 from Robert Houghton
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c80b232 ]

GEODE-7410: metrics fix for jinja-variable expansion (#4383)



> Add private pipeline and team support to metrics pipeline
> -
>
> Key: GEODE-7410
> URL: https://issues.apache.org/jira/browse/GEODE-7410
> Project: Geode
>  Issue Type: Bug
>Reporter: Scott Jewell
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Private pipelines require authentication when accessing Concourse API
> When authenticating, the concourse team to authenticate against should be 
> specified.
> Fix minor bugs in concourse_job_performance.py that fails when no historical
> jobs within concourse to report on.
> Fix minor bug in metrics deployment script when fly command is tee'd



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7410) Add private pipeline and team support to metrics pipeline

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984002#comment-16984002
 ] 

ASF subversion and git services commented on GEODE-7410:


Commit c80b232d98399bcf2123cbf1bd4e88dd17c82340 in geode's branch 
refs/heads/feature/GEODE-7507 from Robert Houghton
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c80b232 ]

GEODE-7410: metrics fix for jinja-variable expansion (#4383)



> Add private pipeline and team support to metrics pipeline
> -
>
> Key: GEODE-7410
> URL: https://issues.apache.org/jira/browse/GEODE-7410
> Project: Geode
>  Issue Type: Bug
>Reporter: Scott Jewell
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Private pipelines require authentication when accessing Concourse API
> When authenticating, the concourse team to authenticate against should be 
> specified.
> Fix minor bugs in concourse_job_performance.py that fails when no historical
> jobs within concourse to report on.
> Fix minor bug in metrics deployment script when fly command is tee'd



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7212) User Guide - Authorization - update security permissions

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984003#comment-16984003
 ] 

ASF subversion and git services commented on GEODE-7212:


Commit 1beaa32c128c2d30ede9b55bf3bc81d9116c1420 in geode's branch 
refs/heads/feature/GEODE-7507 from Karen Miller
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1beaa32 ]

GEODE-7212: update docs permission for CqQuery.stop() (#4371)



> User Guide - Authorization - update security permissions
> 
>
> Key: GEODE-7212
> URL: https://issues.apache.org/jira/browse/GEODE-7212
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Karen Smoler Miller
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> "Fine-grained security" changes were implemented in v1.3, but docs & Wiki 
> were only recently updated. Pick up these changes in the user guide. See 
> [https://cwiki.apache.org/confluence/display/GEODE/Finer+grained+security].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-4187) PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery hangs

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984005#comment-16984005
 ] 

ASF subversion and git services commented on GEODE-4187:


Commit a2c978c1bcc308d1a8a9f0e4b2cebdadbbedf3da in geode's branch 
refs/heads/feature/GEODE-7507 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a2c978c ]

GEODE-4187: Rename PersistentColocatedPartitionedRegionDistributedTest

Rename PersistentColocatedPartitionedRegionDUnitTest.


> PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery 
> hangs
> ---
>
> Key: GEODE-4187
> URL: https://issues.apache.org/jira/browse/GEODE-4187
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Lynn Gallinat
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Analysis from Dan Smith:
> The hang in distributedTests was in 
> PersistentColocatedPartitionedRegionDUnitTest testRebalanceDuringRecovery. I 
> don’t know if there is any more info we have other than that this test hung, 
> but it was stuck for at least an hour and a half before concourse killed the 
> job:
> ~/Downloads/progress.darwin hang distributedTest-progress.txt 
> Started @ 2017-12-28 18:30:31.703 +
> 2017-12-28 19:14:15.760 +  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  testRebalanceDuringRecovery
> Ended @ 2017-12-28 20:50:53.673 +
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/51



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7405) Documentation for describe query-service command

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984001#comment-16984001
 ] 

ASF subversion and git services commented on GEODE-7405:


Commit cc169e1f219055568483ad665375af46309ba325 in geode's branch 
refs/heads/feature/GEODE-7507 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=cc169e1 ]

GEODE-7405: Documentation for describe query-service command

Co-authored-by: Donal Evans 
Co-authored-by: Benjamin Ross 


> Documentation for describe query-service command
> 
>
> Key: GEODE-7405
> URL: https://issues.apache.org/jira/browse/GEODE-7405
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
>  Labels: GeodeCommons
> Fix For: 1.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-4187) PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery hangs

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984007#comment-16984007
 ] 

ASF subversion and git services commented on GEODE-4187:


Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch 
refs/heads/feature/GEODE-7507 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]

GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest

Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
  hang

Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently

Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest

Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService

Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances

Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender


> PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery 
> hangs
> ---
>
> Key: GEODE-4187
> URL: https://issues.apache.org/jira/browse/GEODE-4187
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Lynn Gallinat
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Analysis from Dan Smith:
> The hang in distributedTests was in 
> PersistentColocatedPartitionedRegionDUnitTest testRebalanceDuringRecovery. I 
> don’t know if there is any more info we have other than that this test hung, 
> but it was stuck for at least an hour and a half before concourse killed the 
> job:
> ~/Downloads/progress.darwin hang distributedTest-progress.txt 
> Started @ 2017-12-28 18:30:31.703 +
> 2017-12-28 19:14:15.760 +  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  testRebalanceDuringRecovery
> Ended @ 2017-12-28 20:50:53.673 +
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/51



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7405) Documentation for describe query-service command

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984004#comment-16984004
 ] 

ASF subversion and git services commented on GEODE-7405:


Commit bdd20a288f39c4b71d7ea23806155a422e9ea409 in geode's branch 
refs/heads/feature/GEODE-7507 from Owen Nichols
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=bdd20a2 ]

GEODE-7405: Documentation for describe query-service command (#4378)

Co-authored-by: Donal Evans 
Co-authored-by: Benjamin Ross 

> Documentation for describe query-service command
> 
>
> Key: GEODE-7405
> URL: https://issues.apache.org/jira/browse/GEODE-7405
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
>  Labels: GeodeCommons
> Fix For: 1.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-4187) PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery hangs

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984006#comment-16984006
 ] 

ASF subversion and git services commented on GEODE-4187:


Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch 
refs/heads/feature/GEODE-7507 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]

GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest

Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
  hang

Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently

Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest

Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService

Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances

Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender


> PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery 
> hangs
> ---
>
> Key: GEODE-4187
> URL: https://issues.apache.org/jira/browse/GEODE-4187
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Lynn Gallinat
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Analysis from Dan Smith:
> The hang in distributedTests was in 
> PersistentColocatedPartitionedRegionDUnitTest testRebalanceDuringRecovery. I 
> don’t know if there is any more info we have other than that this test hung, 
> but it was stuck for at least an hour and a half before concourse killed the 
> job:
> ~/Downloads/progress.darwin hang distributedTest-progress.txt 
> Started @ 2017-12-28 18:30:31.703 +
> 2017-12-28 19:14:15.760 +  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  testRebalanceDuringRecovery
> Ended @ 2017-12-28 20:50:53.673 +
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/51



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7507) remove GMSMembership's dependency on DistributionMessage

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983986#comment-16983986
 ] 

ASF subversion and git services commented on GEODE-7507:


Commit 9e65bd9bc4d5945acfbc0028eac8c43a0c0a32d5 in geode's branch 
refs/heads/feature/GEODE-7507 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9e65bd9 ]

GEODE-7507 remove GMSMembership's dependency on DistributionMessage

Prior to this change-set the membership module wrapped all messages in a
GMSMessageAdapter.  This is no longer necessary and I've deleted that
class.  Instead, our messages now implement GMSMessage (now renamed
DistributionMessage) and the geode-core abstract DistributionMessage
class (now renamed ClusterMessage) implements the membership module's
API.

Most of the files in the diff are only affected by the renaming of
GMSMessage and DistributionMessage.  The primary changes are in GMSManager
and DistributionMessage (now named ClusterMessage).


> remove GMSMembership's dependency on DistributionMessage
> 
>
> Key: GEODE-7507
> URL: https://issues.apache.org/jira/browse/GEODE-7507
> Project: Geode
>  Issue Type: Improvement
>  Components: membership
>Reporter: Bruce J Schuchardt
>Assignee: Bruce J Schuchardt
>Priority: Major
>
> GMSMembership should not refer to DistributionMessage, a geode-core class.  
> This is preventing membership from being moved to a separate sub-project.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7436) Ability: can recognize version part when deploy function jar in GFSH

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983970#comment-16983970
 ] 

ASF subversion and git services commented on GEODE-7436:


Commit 3b85e5cb88ff62b0e0a3ac3c35c70e15fad292a2 in geode's branch 
refs/heads/develop from Jinmei Liao
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=3b85e5c ]

GEODE-7436: Deploy jar using semantic versioning scheme  (#4382)

Co-authored-by: Dale Emery 
Co-authored-by: Jinmei Liao 
Co-authored-by: Darrel Schneider 
Co-authored-by: Joris Melchior 

* Deploy jar using semantic versioning scheme
* always add sequence number at the end of the filename no matter what version 
scheme the deployed file uses.

* fix window's tests


> Ability: can recognize version part when deploy function jar in GFSH
> 
>
> Key: GEODE-7436
> URL: https://issues.apache.org/jira/browse/GEODE-7436
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh, management
>Reporter: Gang Yan
>Priority: Major
>  Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> # WHAT
>  1. recognize version part of file name,  for the file to be deployed
>  1. can recognize version pattern. "filename-version[label].jar" .
>   filename=[a-zA-Z/-]+,  not single "-",  not end with "-"
>   version=[0-9/.]*,  not single ".",  not end with "."
>   label=[-/.]{1}[a-zA-Z0-9]*
> such as:
>  -is a later version of 
> , will deploy.
>  -is a same version of 
> ,  the later wins
>  -is a same version of 
> ,  the later wins



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-4187) PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery hangs

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983945#comment-16983945
 ] 

ASF subversion and git services commented on GEODE-4187:


Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch 
refs/heads/develop from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]

GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest

Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
  hang

Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently

Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest

Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService

Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances

Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender


> PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery 
> hangs
> ---
>
> Key: GEODE-4187
> URL: https://issues.apache.org/jira/browse/GEODE-4187
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Lynn Gallinat
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Analysis from Dan Smith:
> The hang in distributedTests was in 
> PersistentColocatedPartitionedRegionDUnitTest testRebalanceDuringRecovery. I 
> don’t know if there is any more info we have other than that this test hung, 
> but it was stuck for at least an hour and a half before concourse killed the 
> job:
> ~/Downloads/progress.darwin hang distributedTest-progress.txt 
> Started @ 2017-12-28 18:30:31.703 +
> 2017-12-28 19:14:15.760 +  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  testRebalanceDuringRecovery
> Ended @ 2017-12-28 20:50:53.673 +
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/51



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-6499) PersistentColocatedPartitionedRegionDUnitTest: Timed out waiting 60000 milliseconds for AsyncInvocation to complete.

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983947#comment-16983947
 ] 

ASF subversion and git services commented on GEODE-6499:


Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch 
refs/heads/develop from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]

GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest

Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
  hang

Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently

Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest

Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService

Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances

Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender


> PersistentColocatedPartitionedRegionDUnitTest: Timed out waiting 6 
> milliseconds for AsyncInvocation to complete.
> 
>
> Key: GEODE-6499
> URL: https://issues.apache.org/jira/browse/GEODE-6499
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Mark Hanson
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
> Attachments: PersistentColocatedPartitionedRegionDUnitTest.tgz
>
>
> {noformat}
>  
> Task :geode-core:distributedTest
>  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  > testHierarchyOfColocatedChildPRsMissingGrandchild FAILED
>  java.util.concurrent.TimeoutException: Timed out waiting 6 milliseconds 
> for AsyncInvocation to complete.
>  at 
> org.apache.geode.test.dunit.AsyncInvocation.timeoutIfAlive(AsyncInvocation.java:462)
>  at org.apache.geode.test.dunit.AsyncInvocation.get(AsyncInvocation.java:412)
>  at 
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testHierarchyOfColocatedChildPRsMissingGrandchild(PersistentColocatedPartitionedRegionDUnitTest.java:979)
>  
>  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  > testMultipleColocatedChildPRsMissingWithSequencedStart FAILED
>  java.util.concurrent.TimeoutException: Timed out waiting 6 milliseconds 
> for AsyncInvocation to complete.
>  at 
> org.apache.geode.test.dunit.AsyncInvocation.timeoutIfAlive(AsyncInvocation.java:462)
>  at org.apache.geode.test.dunit.AsyncInvocation.get(AsyncInvocation.java:412)
>  at 
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testMultipleColocatedChildPRsMissingWithSequencedStart(PersistentColocatedPartitionedRegionDUnitTest.java:865)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-5175) Remove PersistentPartitionedRegionTestBase

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983946#comment-16983946
 ] 

ASF subversion and git services commented on GEODE-5175:


Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch 
refs/heads/develop from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]

GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest

Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
  hang

Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently

Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest

Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService

Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances

Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender


> Remove PersistentPartitionedRegionTestBase
> --
>
> Key: GEODE-5175
> URL: https://issues.apache.org/jira/browse/GEODE-5175
> Project: Geode
>  Issue Type: Improvement
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Minor
>
> Remove PersistentPartitionedRegionTestBase and overhaul the tests that extend 
> it:
> {noformat}
> JUnit4DistributedTestCase (org.apache.geode.test.dunit.internal)
> JUnit4CacheTestCase (org.apache.geode.test.dunit.cache.internal)
> PersistentPartitionedRegionTestBase 
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionWithTransactionDUnitTest 
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionWithDistTXDUnitTest 
> (org.apache.geode.disttx)
> PersistentColocatedPartitionedRegionDUnitTest 
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionDUnitTest 
> (org.apache.geode.internal.cache.partitioned)
> PersistentPartitionedRegionOldConfigDUnitTest 
> (org.apache.geode.internal.cache.partitioned)
> BackupDistributedTest (org.apache.geode.internal.cache.backup)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-4187) PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery hangs

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983944#comment-16983944
 ] 

ASF subversion and git services commented on GEODE-4187:


Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch 
refs/heads/develop from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]

GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest

Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
  hang

Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently

Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest

Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService

Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances

Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender


> PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery 
> hangs
> ---
>
> Key: GEODE-4187
> URL: https://issues.apache.org/jira/browse/GEODE-4187
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Lynn Gallinat
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Analysis from Dan Smith:
> The hang in distributedTests was in 
> PersistentColocatedPartitionedRegionDUnitTest testRebalanceDuringRecovery. I 
> don’t know if there is any more info we have other than that this test hung, 
> but it was stuck for at least an hour and a half before concourse killed the 
> job:
> ~/Downloads/progress.darwin hang distributedTest-progress.txt 
> Started @ 2017-12-28 18:30:31.703 +
> 2017-12-28 19:14:15.760 +  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  testRebalanceDuringRecovery
> Ended @ 2017-12-28 20:50:53.673 +
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/51



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-4187) PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery hangs

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983949#comment-16983949
 ] 

ASF subversion and git services commented on GEODE-4187:


Commit e938d66a735a8668e93f256bcc8acbd6da31bc1e in geode's branch 
refs/heads/develop from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e938d66 ]

GEODE-4187: Use AtomicReference for missingColocatedRegionLogger

* Use AtomicReference for PartitionedRegion missingColocatedRegionLogger
* Make PR methods that use missingColocatedRegionLogger more thread-safe
* Add no-arg flavor of CancelCriterion.checkCancelInProgress()


> PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery 
> hangs
> ---
>
> Key: GEODE-4187
> URL: https://issues.apache.org/jira/browse/GEODE-4187
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Lynn Gallinat
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Analysis from Dan Smith:
> The hang in distributedTests was in 
> PersistentColocatedPartitionedRegionDUnitTest testRebalanceDuringRecovery. I 
> don’t know if there is any more info we have other than that this test hung, 
> but it was stuck for at least an hour and a half before concourse killed the 
> job:
> ~/Downloads/progress.darwin hang distributedTest-progress.txt 
> Started @ 2017-12-28 18:30:31.703 +
> 2017-12-28 19:14:15.760 +  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  testRebalanceDuringRecovery
> Ended @ 2017-12-28 20:50:53.673 +
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/51



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7082) PersistentColocatedPartitionedRegionDUnitTest.testReplaceOfflineMemberAndRestartCreateColocatedPRLate hung or took too long

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983948#comment-16983948
 ] 

ASF subversion and git services commented on GEODE-7082:


Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch 
refs/heads/develop from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]

GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest

Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
  hang

Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently

Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest

Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService

Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances

Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender


> PersistentColocatedPartitionedRegionDUnitTest.testReplaceOfflineMemberAndRestartCreateColocatedPRLate
>  hung or took too long 
> 
>
> Key: GEODE-7082
> URL: https://issues.apache.org/jira/browse/GEODE-7082
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Mark Hanson
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
> Attachments: callstacks-2019-08-12-19-22-55.txt, 
> callstacks-2019-08-12-19-23-06.txt, callstacks-2019-08-12-19-23-16.txt, 
> dunit-hangs.txt
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/981]
> The run of the distributed test for java 8 failed because a timeout was 
> exceeded.
> I've attached the dunit-hangs.txt and callstack files from dunit #981. It 
> looks like 
> PersistentColocatedPartitionedRegionDUnitTest.testReplaceOfflineMemberAndRestartCreateColocatedPRLate
>  hung. Several threads are trying to create buckets while another is trying 
> to shutdown the cluster. Thread stacks are below.
> There are several threads creating buckets and stuck waiting for replies to 
> PrepareNewPersistentMemberMessage:
> {noformat}
> "Pooled Waiting Message Processor 6" #2393 daemon prio=5 os_prio=0 
> tid=0x7f29a0005800 nid=0x1a84 waiting on condition [0x7f2bd28c5000]
>java.lang.Thread.State: TIMED_WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for  <0xe1fb4410> (a 
> java.util.concurrent.CountDownLatch$Sync)
> at 
> java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedNanos(AbstractQueuedSynchronizer.java:1037)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1328)
> at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:277)
> at 
> org.apache.geode.internal.util.concurrent.StoppableCountDownLatch.await(StoppableCountDownLatch.java:72)
> at 
> org.apache.geode.distributed.internal.ReplyProcessor21.basicWait(ReplyProcessor21.java:732)
> at 
> org.apache.geode.distributed.internal.ReplyProcessor21.waitForRepliesUninterruptibly(ReplyProcessor21.java:803)
> at 
> org.apache.geode.distributed.internal.ReplyProcessor21.waitForRepliesUninterruptibly(ReplyProcessor21.java:780)
> at 
> org.apache.geode.distributed.internal.ReplyProcessor21.waitForRepliesUninterruptibly(ReplyProcessor21.java:866)
> at 
> org.apache.geode.internal.cache.persistence.PrepareNewPersistentMemberMessage.send(PrepareNewPersistentMemberMessage.java:79)
> at 
> 

[jira] [Commented] (GEODE-4187) PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery hangs

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983943#comment-16983943
 ] 

ASF subversion and git services commented on GEODE-4187:


Commit a2c978c1bcc308d1a8a9f0e4b2cebdadbbedf3da in geode's branch 
refs/heads/develop from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a2c978c ]

GEODE-4187: Rename PersistentColocatedPartitionedRegionDistributedTest

Rename PersistentColocatedPartitionedRegionDUnitTest.


> PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery 
> hangs
> ---
>
> Key: GEODE-4187
> URL: https://issues.apache.org/jira/browse/GEODE-4187
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Lynn Gallinat
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Analysis from Dan Smith:
> The hang in distributedTests was in 
> PersistentColocatedPartitionedRegionDUnitTest testRebalanceDuringRecovery. I 
> don’t know if there is any more info we have other than that this test hung, 
> but it was stuck for at least an hour and a half before concourse killed the 
> job:
> ~/Downloads/progress.darwin hang distributedTest-progress.txt 
> Started @ 2017-12-28 18:30:31.703 +
> 2017-12-28 19:14:15.760 +  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  testRebalanceDuringRecovery
> Ended @ 2017-12-28 20:50:53.673 +
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/51



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7438) Session cookie set does not reflect the context's SessionCookieConfig

2019-11-27 Thread Charles Smith (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983935#comment-16983935
 ] 

Charles Smith commented on GEODE-7438:
--

All done. Should be good for merging now.

> Session cookie set does not reflect the context's SessionCookieConfig
> -
>
> Key: GEODE-7438
> URL: https://issues.apache.org/jira/browse/GEODE-7438
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Charles Smith
>Priority: Major
>  Labels: docs
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The session cookie set and used by the HTTP Session module for AppServers 
> should honor the httponly and secure settings of the ServetContext's 
> SessionCookieConfig.
> Currently the cookie created in the SessionCachingFilter.addSessionCookie 
> method does not use any settings from the SessionCookieConfig but it could 
> easily do so.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-7508) Clean up usage of keystore, truststore files

2019-11-27 Thread Blake Bender (Jira)
Blake Bender created GEODE-7508:
---

 Summary: Clean up usage of keystore, truststore files
 Key: GEODE-7508
 URL: https://issues.apache.org/jira/browse/GEODE-7508
 Project: Geode
  Issue Type: Improvement
  Components: native client
Reporter: Blake Bender


As a developer, I want to know where to find resource files I need for 
writing/running a test.  I would also prefer not to have multiple copies of 
these files in my source tree.  This is not the case for our SSL keys, and it 
really needs to be cleaned up.

 

Acceptance criteria:

 

i. If I run `find . -name *.pem` or `find . -name *.jks` (or the Windows 
equivalent) from the root of the native client source tree, I should only find 
one copy of any particular file.  Ideally, I should only find each type of file 
in a single directory, as well.  

ii. After a clean build of the native client, there should be _no_ .pem or .jks 
files in the build directory.  Several of the SSL tests were found to have 
dependencies on these files in the build location, rather than the source tree.

iii. All code that refers to one of these files should refer to it via a named 
constant/property in the Config class.  These are created by modifying 
/clicache/integration-test2/Config.cs.in for C#, and 
/cppcache/integration/framework/TestConfig.h & 
/cppcache/integration/framework/TestConfig.cpp.in for C++.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GEODE-7405) Documentation for describe query-service command

2019-11-27 Thread Donal Evans (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donal Evans resolved GEODE-7405.

Fix Version/s: 1.12.0
   Resolution: Done

> Documentation for describe query-service command
> 
>
> Key: GEODE-7405
> URL: https://issues.apache.org/jira/browse/GEODE-7405
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
>  Labels: GeodeCommons
> Fix For: 1.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7405) Documentation for describe query-service command

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983917#comment-16983917
 ] 

ASF subversion and git services commented on GEODE-7405:


Commit cc169e1f219055568483ad665375af46309ba325 in geode's branch 
refs/heads/develop from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=cc169e1 ]

GEODE-7405: Documentation for describe query-service command

Co-authored-by: Donal Evans 
Co-authored-by: Benjamin Ross 


> Documentation for describe query-service command
> 
>
> Key: GEODE-7405
> URL: https://issues.apache.org/jira/browse/GEODE-7405
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
>  Labels: GeodeCommons
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7212) User Guide - Authorization - update security permissions

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983914#comment-16983914
 ] 

ASF subversion and git services commented on GEODE-7212:


Commit 1beaa32c128c2d30ede9b55bf3bc81d9116c1420 in geode's branch 
refs/heads/develop from Karen Miller
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1beaa32 ]

GEODE-7212: update docs permission for CqQuery.stop() (#4371)



> User Guide - Authorization - update security permissions
> 
>
> Key: GEODE-7212
> URL: https://issues.apache.org/jira/browse/GEODE-7212
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Karen Smoler Miller
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> "Fine-grained security" changes were implemented in v1.3, but docs & Wiki 
> were only recently updated. Pick up these changes in the user guide. See 
> [https://cwiki.apache.org/confluence/display/GEODE/Finer+grained+security].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7405) Documentation for describe query-service command

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983918#comment-16983918
 ] 

ASF subversion and git services commented on GEODE-7405:


Commit bdd20a288f39c4b71d7ea23806155a422e9ea409 in geode's branch 
refs/heads/develop from Owen Nichols
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=bdd20a2 ]

GEODE-7405: Documentation for describe query-service command (#4378)

Co-authored-by: Donal Evans 
Co-authored-by: Benjamin Ross 

> Documentation for describe query-service command
> 
>
> Key: GEODE-7405
> URL: https://issues.apache.org/jira/browse/GEODE-7405
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
>  Labels: GeodeCommons
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7410) Add private pipeline and team support to metrics pipeline

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983848#comment-16983848
 ] 

ASF subversion and git services commented on GEODE-7410:


Commit c80b232d98399bcf2123cbf1bd4e88dd17c82340 in geode's branch 
refs/heads/develop from Robert Houghton
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c80b232 ]

GEODE-7410: metrics fix for jinja-variable expansion (#4383)



> Add private pipeline and team support to metrics pipeline
> -
>
> Key: GEODE-7410
> URL: https://issues.apache.org/jira/browse/GEODE-7410
> Project: Geode
>  Issue Type: Bug
>Reporter: Scott Jewell
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Private pipelines require authentication when accessing Concourse API
> When authenticating, the concourse team to authenticate against should be 
> specified.
> Fix minor bugs in concourse_job_performance.py that fails when no historical
> jobs within concourse to report on.
> Fix minor bug in metrics deployment script when fly command is tee'd



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7505) CI Failure: DistributedTestOpenJDK11 Timed Out (Hang/Hung)

2019-11-27 Thread Bill Burcham (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983718#comment-16983718
 ] 

Bill Burcham commented on GEODE-7505:
-

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=  Test Results URI 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

http://files.apachegeode-ci.info/builds/apache-develop-main/1.12.0-SNAPSHOT.0053/test-results/distributedTest/1574806317/

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=


Test report artifacts from this job are available at:


http://files.apachegeode-ci.info/builds/apache-develop-main/1.12.0-SNAPSHOT.0053/test-artifacts/1574806317/distributedtestfiles-OpenJDK11-1.12.0-SNAPSHOT.0053.tgz


> CI Failure: DistributedTestOpenJDK11 Timed Out (Hang/Hung)
> --
>
> Key: GEODE-7505
> URL: https://issues.apache.org/jira/browse/GEODE-7505
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Bill Burcham
>Priority: Major
>
> This build timed out while running DUnit tests:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/1319
> From the artifacts ({{dunit-hangs.txt}}) it appears it was running 
> {{org.apache.geode.test.dunit.examples.InvokeRunnableExampleTest 
> invokeHelloWorldForEachVMInGetAllVMs}} when it timed out
> The previous build passed all DUnit tests: 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/1318
>  but we don't have artifacts for that one because we were having Concourse 
> infrastructure problems
> But the only commit between those two builds is this one:
> {noformat}
> Author: Alberto Bustamante Reyes 
> Date:   Wed Oct 9 17:32:16 2019 +0200
> GEODE-2184: Genericize Java version numbers in docs
> commit 883a4211b6189448482737d858c4ed9ce875f3e2
> {noformat}
> I see no reason why documentation changes would cause a regression that would 
> cause a new hang. My theory is that this is either an infrastructure issue 
> e.g. transient networking problem, or it's caused by an old test or product 
> fault.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GEODE-5626) Segfault in Region::registerAllKeys when getInitialValues set to true

2019-11-27 Thread Blake Bender (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender resolved GEODE-5626.
-
Fix Version/s: 1.12.0
   Resolution: Fixed

> Segfault in Region::registerAllKeys when getInitialValues set to true
> -
>
> Key: GEODE-5626
> URL: https://issues.apache.org/jira/browse/GEODE-5626
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> getInitialValues has a default value of false.  If you attempt to set it to 
> true, and the region isn't initially empty, it will segfault attempting to 
> insert a value in an internal map which is null.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (GEODE-5626) Segfault in Region::registerAllKeys when getInitialValues set to true

2019-11-27 Thread Blake Bender (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender closed GEODE-5626.
---

> Segfault in Region::registerAllKeys when getInitialValues set to true
> -
>
> Key: GEODE-5626
> URL: https://issues.apache.org/jira/browse/GEODE-5626
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> getInitialValues has a default value of false.  If you attempt to set it to 
> true, and the region isn't initially empty, it will segfault attempting to 
> insert a value in an internal map which is null.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GEODE-7040) Fix checked assertion and connection parameters to 'FunctionReturnsObjectWhichCantBeDeserializedOnServer' test

2019-11-27 Thread Blake Bender (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender resolved GEODE-7040.
-
Fix Version/s: 1.12.0
   Resolution: Fixed

> Fix checked assertion and connection parameters to 
> 'FunctionReturnsObjectWhichCantBeDeserializedOnServer' test
> --
>
> Key: GEODE-7040
> URL: https://issues.apache.org/jira/browse/GEODE-7040
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
> Fix For: 1.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> We found, in the course of developing another function execution test, that 
> this one was attempting to connect to the locator on the wrong port, and was 
> thus checking for the wrong exception at the end.  Fix is pretty trivial, but 
> it should go in on its own, hence the separate Jira ticket.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GEODE-7299) Memory leak in PdxInstanceImpl::updatePdxStream

2019-11-27 Thread Blake Bender (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender resolved GEODE-7299.
-
Fix Version/s: 1.12.0
   Resolution: Fixed

> Memory leak in PdxInstanceImpl::updatePdxStream
> ---
>
> Key: GEODE-7299
> URL: https://issues.apache.org/jira/browse/GEODE-7299
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
> Fix For: 1.12.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> The `PdxInstanceImpl::updatePdxStream` method assigns the result of 
> `DataInput::getBufferCopy` to its `m_buffer` member variable, but `m_buffer` 
> is deleted by `PdxInstanceImpl` in its destructor, implying that 
> `PdxInstanceImpl` owns the pointer, which means, in this case, that the 
> existing `m_buffer`, if there is one, is leaked in this call.  We discovered 
> that `updatePdxStream` is called on every put of a Pdx type, so in a tight 
> loop with a lot of puts we are potentially leaking _a lot_ of memory.
>  
> Repro steps:
> Run the soon-to-be-implemented `LeakPdxMemory` test in the NC integration 
> test suite.  Test will attempt to do a large number of puts of a large Pdx 
> object, and look for an out of memory exception.
>  
> Expected result:
> Test passes
>  
> Actual result:
> Test fails.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (GEODE-7299) Memory leak in PdxInstanceImpl::updatePdxStream

2019-11-27 Thread Blake Bender (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender closed GEODE-7299.
---

> Memory leak in PdxInstanceImpl::updatePdxStream
> ---
>
> Key: GEODE-7299
> URL: https://issues.apache.org/jira/browse/GEODE-7299
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
> Fix For: 1.12.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> The `PdxInstanceImpl::updatePdxStream` method assigns the result of 
> `DataInput::getBufferCopy` to its `m_buffer` member variable, but `m_buffer` 
> is deleted by `PdxInstanceImpl` in its destructor, implying that 
> `PdxInstanceImpl` owns the pointer, which means, in this case, that the 
> existing `m_buffer`, if there is one, is leaked in this call.  We discovered 
> that `updatePdxStream` is called on every put of a Pdx type, so in a tight 
> loop with a lot of puts we are potentially leaking _a lot_ of memory.
>  
> Repro steps:
> Run the soon-to-be-implemented `LeakPdxMemory` test in the NC integration 
> test suite.  Test will attempt to do a large number of puts of a large Pdx 
> object, and look for an out of memory exception.
>  
> Expected result:
> Test passes
>  
> Actual result:
> Test fails.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GEODE-7316) Race condition results in crash at shutdown

2019-11-27 Thread Blake Bender (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender resolved GEODE-7316.
-
Fix Version/s: 1.12.0
   Resolution: Fixed

> Race condition results in crash at shutdown
> ---
>
> Key: GEODE-7316
> URL: https://issues.apache.org/jira/browse/GEODE-7316
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
> Fix For: 1.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
>  
> A race condition between the CacheImpl::close and the ThinClientPRMetadata 
> object that causes the crash because the CacheImpl pointer 
> ThinClientPRMetadata is trying to use has been deleted.
>  
> We need a C++ test written to verify this.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (GEODE-7418) Crash in deserialization of JSON Pdx value when PdxReadSerialized=false

2019-11-27 Thread Blake Bender (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender closed GEODE-7418.
---

> Crash in deserialization of JSON Pdx value when PdxReadSerialized=false
> ---
>
> Key: GEODE-7418
> URL: https://issues.apache.org/jira/browse/GEODE-7418
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
> Fix For: 1.12.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> As a developer, I should be able to put and get JSON Pdx values in a region 
> without any "extra effort" such as registering types or setting 
> PdxReadSerialized to true when creating my cache.  Currently if I do this, 
> put a JSON value into a region, and attempt a get, NC will segfault 
> attempting to create a PdxInstanceImpl.
>  
> Steps to repro:
>  * Build NC from the 
> `*[pdxinstance_json_crash_repro|https://github.com/pdxcodemonkey/geode-native/tree/pdxinstance_json_crash_repro]`*
>  branch of my (pdxcodemonkey) fork
>  * Run NC integration test `PdxInstanceTest.testCreateJsonInstance`
> Expected result:
>  * test passes
> Actual result:
>  * test fails with a segfault in NC
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (GEODE-7316) Race condition results in crash at shutdown

2019-11-27 Thread Blake Bender (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender closed GEODE-7316.
---

> Race condition results in crash at shutdown
> ---
>
> Key: GEODE-7316
> URL: https://issues.apache.org/jira/browse/GEODE-7316
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
> Fix For: 1.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
>  
> A race condition between the CacheImpl::close and the ThinClientPRMetadata 
> object that causes the crash because the CacheImpl pointer 
> ThinClientPRMetadata is trying to use has been deleted.
>  
> We need a C++ test written to verify this.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GEODE-7418) Crash in deserialization of JSON Pdx value when PdxReadSerialized=false

2019-11-27 Thread Blake Bender (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender resolved GEODE-7418.
-
Fix Version/s: 1.12.0
   Resolution: Fixed

> Crash in deserialization of JSON Pdx value when PdxReadSerialized=false
> ---
>
> Key: GEODE-7418
> URL: https://issues.apache.org/jira/browse/GEODE-7418
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
> Fix For: 1.12.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> As a developer, I should be able to put and get JSON Pdx values in a region 
> without any "extra effort" such as registering types or setting 
> PdxReadSerialized to true when creating my cache.  Currently if I do this, 
> put a JSON value into a region, and attempt a get, NC will segfault 
> attempting to create a PdxInstanceImpl.
>  
> Steps to repro:
>  * Build NC from the 
> `*[pdxinstance_json_crash_repro|https://github.com/pdxcodemonkey/geode-native/tree/pdxinstance_json_crash_repro]`*
>  branch of my (pdxcodemonkey) fork
>  * Run NC integration test `PdxInstanceTest.testCreateJsonInstance`
> Expected result:
>  * test passes
> Actual result:
>  * test fails with a segfault in NC
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (GEODE-7447) Fix remaining log message formatting errors with std::chrono 'Rep' type

2019-11-27 Thread Blake Bender (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender closed GEODE-7447.
---

> Fix remaining log message formatting errors with std::chrono 'Rep' type
> ---
>
> Key: GEODE-7447
> URL: https://issues.apache.org/jira/browse/GEODE-7447
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
> Fix For: 1.12.0
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> As a developer (or customer), I would very much like to be able to collect 
> debug-level logs from the native client, when necessary, without fear of 
> either:
>  * hitting a segfault in the logging code, or
>  * emitting invalid UTF-8 text due to a mismatched variable size & format 
> specifier
>  
> GEODE-7426 fixed a specific instance of this bug, but there are a number of 
> these remaining in the codebase, any of which could bite us at any time.  The 
> std::chrono 'Rep' type is numeric, but its size can vary depending on 
> platform, and combined with the %z format specifier in a log message, will 
> produce a segfault when Rep is a different size than expected.  
> A survey of the source tree at the current `develop` branch SHA (
> 1bb8cf4b296bc09b3fb4ae098be6fb73ff90c61d)
> shows 17 instances of the problem, at the following locations:
> EntryExpiryHandler.cpp: 59
> LocalRegion.cpp: 699, 720, 2799, 2804
> Log.cpp: 527 (maybe?  Not sure on this one)
> RegionExpiryHandler.cpp: 58, 69
> TcpConn.cpp: 212
> TcpSslConn.cpp: 94
> TcrConnection.cpp: 619, 647
> TcrEndpoint.cpp: 187, 924, 1053
> ThinClientRegion.cpp: 3019, 3028
>  
> When fixing these, refer to the original fix for GEODE-7426.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-7507) remove GMSMembership's dependency on DistributionMessage

2019-11-27 Thread Bruce J Schuchardt (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce J Schuchardt reassigned GEODE-7507:
-

Assignee: Bruce J Schuchardt

> remove GMSMembership's dependency on DistributionMessage
> 
>
> Key: GEODE-7507
> URL: https://issues.apache.org/jira/browse/GEODE-7507
> Project: Geode
>  Issue Type: Improvement
>  Components: membership
>Reporter: Bruce J Schuchardt
>Assignee: Bruce J Schuchardt
>Priority: Major
>
> GMSMembership should not refer to DistributionMessage, a geode-core class.  
> This is preventing membership from being moved to a separate sub-project.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-7507) remove GMSMembership's dependency on DistributionMessage

2019-11-27 Thread Bruce J Schuchardt (Jira)
Bruce J Schuchardt created GEODE-7507:
-

 Summary: remove GMSMembership's dependency on DistributionMessage
 Key: GEODE-7507
 URL: https://issues.apache.org/jira/browse/GEODE-7507
 Project: Geode
  Issue Type: Improvement
  Components: membership
Reporter: Bruce J Schuchardt


GMSMembership should not refer to DistributionMessage, a geode-core class.  
This is preventing membership from being moved to a separate sub-project.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-7489) DistributionArchUnitTest is running out of memory for some users

2019-11-27 Thread Bruce J Schuchardt (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce J Schuchardt updated GEODE-7489:
--
Fix Version/s: 1.12.0

> DistributionArchUnitTest is running out of memory for some users
> 
>
> Key: GEODE-7489
> URL: https://issues.apache.org/jira/browse/GEODE-7489
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Dan Smith
>Assignee: Bruce J Schuchardt
>Priority: Major
> Fix For: 1.12.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> This test ran out of memory when running ./gradlew build for some users. From 
> the mailing list:
> {noformat}
> Any ideas why DistributionArchUnitTest would run OutOfMemoryError when
> doing a "./gradlew build"?
> I think we should move any unit tests that run OutOfMemoryError out of unit
> tests (to integration tests maybe?).
> > Task :geode:geode-core:test
> Heap dump file created [957877145 bytes in 17.227 secs]
> org.apache.geode.distributed.internal.DistributionArchUnitTest >
> classMethod FAILED
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> 6991 tests completed, 1 failed, 12 skipped
> {noformat}
> This is a relatively new test that is scanning a lot of classes for 
> dependencies, so it may have memory issues.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GEODE-7434) Unnecessary object allocation and locking in GMSHealthMonitor.contactedBy

2019-11-27 Thread Bruce J Schuchardt (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce J Schuchardt resolved GEODE-7434.
---
Fix Version/s: 1.12.0
   Resolution: Fixed

> Unnecessary object allocation and locking in GMSHealthMonitor.contactedBy
> -
>
> Key: GEODE-7434
> URL: https://issues.apache.org/jira/browse/GEODE-7434
> Project: Geode
>  Issue Type: Bug
>  Components: benchmarks, membership
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
>  Labels: performance
> Fix For: 1.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> GMSHealthMonitor.contactedBy allocates a {{TimeStamp}} for every call but 
> throws it away almost all of the time in the call to {{putIfAbsent}}. 
> Additionally, {{putIfAbsent}} always brags a monitor on the hash segment 
> resulting in unnecessary synchronization. 
> All with use of {{JavaWorkarounds.computeIfAbsent}} to avoid the locking and 
> object allocation for the hot path where the entry already exists.
> Benchmark profiling shows 77% of P2P reader threads spent waiting for this 
> lock.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GEODE-7489) DistributionArchUnitTest is running out of memory for some users

2019-11-27 Thread Bruce J Schuchardt (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce J Schuchardt resolved GEODE-7489.
---
Resolution: Fixed

> DistributionArchUnitTest is running out of memory for some users
> 
>
> Key: GEODE-7489
> URL: https://issues.apache.org/jira/browse/GEODE-7489
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Dan Smith
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> This test ran out of memory when running ./gradlew build for some users. From 
> the mailing list:
> {noformat}
> Any ideas why DistributionArchUnitTest would run OutOfMemoryError when
> doing a "./gradlew build"?
> I think we should move any unit tests that run OutOfMemoryError out of unit
> tests (to integration tests maybe?).
> > Task :geode:geode-core:test
> Heap dump file created [957877145 bytes in 17.227 secs]
> org.apache.geode.distributed.internal.DistributionArchUnitTest >
> classMethod FAILED
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> 6991 tests completed, 1 failed, 12 skipped
> {noformat}
> This is a relatively new test that is scanning a lot of classes for 
> dependencies, so it may have memory issues.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7436) Ability: can recognize version part when deploy function jar in GFSH

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983696#comment-16983696
 ] 

ASF subversion and git services commented on GEODE-7436:


Commit 6ad41d315a3e3a5394e6b0cc33f26ca621f53546 in geode's branch 
refs/heads/develop from Jinmei Liao
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6ad41d3 ]

Revert "GEODE-7436: Deploy jar using semantic versioning scheme (#4343)" (#4380)

This reverts commit 0d4c1912



> Ability: can recognize version part when deploy function jar in GFSH
> 
>
> Key: GEODE-7436
> URL: https://issues.apache.org/jira/browse/GEODE-7436
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh, management
>Reporter: Gang Yan
>Priority: Major
>  Time Spent: 4h
>  Remaining Estimate: 0h
>
> # WHAT
>  1. recognize version part of file name,  for the file to be deployed
>  1. can recognize version pattern. "filename-version[label].jar" .
>   filename=[a-zA-Z/-]+,  not single "-",  not end with "-"
>   version=[0-9/.]*,  not single ".",  not end with "."
>   label=[-/.]{1}[a-zA-Z0-9]*
> such as:
>  -is a later version of 
> , will deploy.
>  -is a same version of 
> ,  the later wins
>  -is a same version of 
> ,  the later wins



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7489) DistributionArchUnitTest is running out of memory for some users

2019-11-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983695#comment-16983695
 ] 

ASF subversion and git services commented on GEODE-7489:


Commit 6bc6e59300c65a2f7f1ce669e8f3f186fb03250a in geode's branch 
refs/heads/develop from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6bc6e59 ]

GEODE-7489 DistributionArchUnitTest is running out of memory for some users 
(#4377)

Added archive excludes to all membership arch unit tests.  Moved
DistributionArchUnitTest to integrationTests and added an exclude
for another integration test to it.

> DistributionArchUnitTest is running out of memory for some users
> 
>
> Key: GEODE-7489
> URL: https://issues.apache.org/jira/browse/GEODE-7489
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Dan Smith
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> This test ran out of memory when running ./gradlew build for some users. From 
> the mailing list:
> {noformat}
> Any ideas why DistributionArchUnitTest would run OutOfMemoryError when
> doing a "./gradlew build"?
> I think we should move any unit tests that run OutOfMemoryError out of unit
> tests (to integration tests maybe?).
> > Task :geode:geode-core:test
> Heap dump file created [957877145 bytes in 17.227 secs]
> org.apache.geode.distributed.internal.DistributionArchUnitTest >
> classMethod FAILED
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> 6991 tests completed, 1 failed, 12 skipped
> {noformat}
> This is a relatively new test that is scanning a lot of classes for 
> dependencies, so it may have memory issues.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-7504) support creating regions with eviction

2019-11-27 Thread Joris Melchior (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joris Melchior reassigned GEODE-7504:
-

Assignee: Joris Melchior  (was: Darrel Schneider)

> support creating regions with eviction
> --
>
> Key: GEODE-7504
> URL: https://issues.apache.org/jira/browse/GEODE-7504
> Project: Geode
>  Issue Type: Improvement
>  Components: management
>Reporter: Darrel Schneider
>Assignee: Joris Melchior
>Priority: Major
>
> The new rest api supports creating regions but they can not be configured for 
> eviction.
> Support for eviction should be added.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-7504) support creating regions with eviction

2019-11-27 Thread Joris Melchior (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joris Melchior reassigned GEODE-7504:
-

Assignee: Darrel Schneider

> support creating regions with eviction
> --
>
> Key: GEODE-7504
> URL: https://issues.apache.org/jira/browse/GEODE-7504
> Project: Geode
>  Issue Type: Improvement
>  Components: management
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>
> The new rest api supports creating regions but they can not be configured for 
> eviction.
> Support for eviction should be added.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-7506) Native client for .net Core error

2019-11-27 Thread Edgaras (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edgaras updated GEODE-7506:
---
Priority: Trivial  (was: Major)

> Native client for .net Core error
> -
>
> Key: GEODE-7506
> URL: https://issues.apache.org/jira/browse/GEODE-7506
> Project: Geode
>  Issue Type: Bug
>Reporter: Edgaras
>Priority: Trivial
> Fix For: 1.10.0
>
>
> Hi,
> After building .net native client using visual studio 2017, I am getting an 
> error when creating regions:
> {"Method implementation on an interface 'Apache.Geode.Client.IRegion`2' from 
> assembly 'Apache.Geode, Version=0.0.42.0, Culture=neutral, 
> PublicKeyToken=null' must be a final method.":"Apache.Geode.Client.IRegion`2"}
> at: regionFactory.Create(region);
> This only happens in .net Core and not in .net Framework.
> Not sure where the problem lays, with .net Core, with Geode, or with me, not 
> building it for .net Core.
> If it's the last one, then could someone point me to right direction on how 
> to do so?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-7506) Native client for .net Core error

2019-11-27 Thread Edgaras (Jira)
Edgaras created GEODE-7506:
--

 Summary: Native client for .net Core error
 Key: GEODE-7506
 URL: https://issues.apache.org/jira/browse/GEODE-7506
 Project: Geode
  Issue Type: Bug
Reporter: Edgaras
 Fix For: 1.10.0


Hi,

After building .net native client using visual studio 2017, I am getting an 
error when creating regions:

{"Method implementation on an interface 'Apache.Geode.Client.IRegion`2' from 
assembly 'Apache.Geode, Version=0.0.42.0, Culture=neutral, PublicKeyToken=null' 
must be a final method.":"Apache.Geode.Client.IRegion`2"}

at: regionFactory.Create(region);

This only happens in .net Core and not in .net Framework.

Not sure where the problem lays, with .net Core, with Geode, or with me, not 
building it for .net Core.

If it's the last one, then could someone point me to right direction on how to 
do so?

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)