[GitHub] incubator-hawq issue #921: HAWQ-1064. Additional work related to paramiko re...

2016-09-20 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/921
  
BTW, could you help to delete pramiko in .travis.yml.

This can save a little time to get travis result. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #921: HAWQ-1064. Additional work related to para...

2016-09-20 Thread paul-guo-
Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/921#discussion_r79763445
  
--- Diff: tools/bin/lib/.gitignore ---
@@ -2,7 +2,3 @@ netperf
 netserver
 stream
 Crypto
--- End diff --

+1. Good catch for the whole issue.

By the way, tools/Makefile seems to be buggy. See the following patch.
This misleads me also. @ edespino and @radarwave ,
how about the patch below? If yes, Ed you probably could
add this change in you patch?

diff --git a/tools/Makefile b/tools/Makefile
index 172f6f6..3eb49f6 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -27,6 +27,7 @@ include $(top_builddir)/src/Makefile.global

 all:
${MAKE} -C gpnetbench $@
+   ${MAKE} -C bin $@

 install :
${MAKE} -C bin $@



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #922: HAWQ-1065. Document ppport.h license exception.

2016-09-20 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/922
  
LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #921: HAWQ-1064. Additional work related to paramiko re...

2016-09-20 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/921
  
Thanks for fix it.
LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #921: HAWQ-1064. Additional work related to para...

2016-09-20 Thread edespino
Github user edespino commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/921#discussion_r79760929
  
--- Diff: tools/bin/lib/.gitignore ---
@@ -2,7 +2,3 @@ netperf
 netserver
 stream
 Crypto
--- End diff --

The tools/bin/Makefile processes the "stream" target and the executable 
"stream" is copied to tools/bin/lib/stream.  Thus the "stream" entry in the 
.gitignore file is used.

I will remove the other entries and leave the "stream" reference.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #918: HAWQ-1062. Remove ASF incompatible Perl JSON modu...

2016-09-20 Thread edespino
Github user edespino commented on the issue:

https://github.com/apache/incubator-hawq/pull/918
  
You are correct Hong.  I will also be updating it to fix the travis based
builds.

-=e

On Tue, Sep 20, 2016 at 4:48 AM, Hong Wu  wrote:

> Hi @edespino  , I checked out the Travis
> Failure from https://s3.amazonaws.com/archive.travis-ci.org/jobs/
> 161283621/log.txt. I think you should also modify lines around here
> 

> together with this pull request~
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



-- 
*Ed Espino*
*Director, Pivotal Technical Staff*
*Cell: *925.389.4640
*WeChat ID:* EdEspino



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #923: HAWQ-1044. Add some error path test cases ...

2016-09-20 Thread wcl14
GitHub user wcl14 opened a pull request:

https://github.com/apache/incubator-hawq/pull/923

HAWQ-1044. Add some error path test cases for hawq register (TestUsag…

…e2Case1ErrorEncoding, TestUsage2Case1Bucket0, 
TestUsage2Case1IncludeDirectory)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wcl14/incubator-hawq HAWQ-1044

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/923.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #923


commit e5ab81979b7804d0f0946fbb87c13b0add7584d8
Author: Chunling Wang 
Date:   2016-09-21T02:30:47Z

HAWQ-1044. Add some error path test cases for hawq register 
(TestUsage2Case1ErrorEncoding, TestUsage2Case1Bucket0, 
TestUsage2Case1IncludeDirectory)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #912: HAWQ-1044. Remove duplicated testcases for...

2016-09-20 Thread wcl14
Github user wcl14 closed the pull request at:

https://github.com/apache/incubator-hawq/pull/912


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (HAWQ-1055) Fractional part is being dropped for decimal/numeric column with no modifiers in HiveORC profile

2016-09-20 Thread Shivram Mani (JIRA)

[ 
https://issues.apache.org/jira/browse/HAWQ-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508496#comment-15508496
 ] 

Shivram Mani commented on HAWQ-1055:


The following table shows how Hive decimal fields will be handled in HAWQ:

|| HAWQ Type || Hive Type || Behavior |
| numeric(precision, scale) | decimal(precision,scale) | As long as HAWQ has a 
higher scale/precision than defined in Hive, would be fine. If precision/scale 
is lower in HAWQ compared to Hive, will be reported as an error  |
| numeric(precision) | decimal(precision) | Hawq and Hive restricts scale to 0 |
| numeric | decimal | Hive defaults to <38,38> while HAWQ permits upto max 
(131072) for precision and upto 16383 for scale |

> Fractional part is being dropped for decimal/numeric column with no modifiers 
> in HiveORC profile
> 
>
> Key: HAWQ-1055
> URL: https://issues.apache.org/jira/browse/HAWQ-1055
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: PXF
>Reporter: Oleksandr Diachenko
>Assignee: Shivram Mani
>Priority: Critical
> Fix For: 2.0.1.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HAWQ-1055) Fractional part is being dropped for decimal/numeric column with no modifiers in HiveORC profile

2016-09-20 Thread Shivram Mani (JIRA)

[ 
https://issues.apache.org/jira/browse/HAWQ-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508500#comment-15508500
 ] 

Shivram Mani commented on HAWQ-1055:


If HAWQ doesn't define precision,scale info for the column, we will assume 
<38,38> as that is the maximum permitted value in Hive

> Fractional part is being dropped for decimal/numeric column with no modifiers 
> in HiveORC profile
> 
>
> Key: HAWQ-1055
> URL: https://issues.apache.org/jira/browse/HAWQ-1055
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: PXF
>Reporter: Oleksandr Diachenko
>Assignee: Shivram Mani
>Priority: Critical
> Fix For: 2.0.1.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (HAWQ-1055) Fractional part is being dropped for decimal/numeric column with no modifiers in HiveORC profile

2016-09-20 Thread Shivram Mani (JIRA)

 [ 
https://issues.apache.org/jira/browse/HAWQ-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shivram Mani updated HAWQ-1055:
---
Comment: was deleted

(was: The following table shows how Hive decimal fields will be handled in HAWQ:

|| HAWQ Type || Hive Type || Behavior |
| numeric(precision, scale) | decimal(precision,scale) | As long as HAWQ has a 
higher scale/precision than defined in Hive, would be fine. If precision/scale 
is lower in HAWQ compared to Hive, will be reported as an error  |
| numeric(precision) | decimal(precision) | Hawq and Hive restricts scale to 0 |
| numeric | decimal | Hive defaults to <10,0> while HAWQ permits upto max 
(131072) for precision and upto 16383 for scale |)

> Fractional part is being dropped for decimal/numeric column with no modifiers 
> in HiveORC profile
> 
>
> Key: HAWQ-1055
> URL: https://issues.apache.org/jira/browse/HAWQ-1055
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: PXF
>Reporter: Oleksandr Diachenko
>Assignee: Shivram Mani
>Priority: Critical
> Fix For: 2.0.1.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-hawq issue #896: [#126526845] Port recent changes from gpdb for ha...

2016-09-20 Thread hsyuan
Github user hsyuan commented on the issue:

https://github.com/apache/incubator-hawq/pull/896
  
It is not a simple move. It is kind of rewrite sql into cpp test 
classes.
Since this PR is just porting, we can do it in later changes.

@liming01 Can you merge this in?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #921: HAWQ-1064. Additional work related to para...

2016-09-20 Thread paul-guo-
Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/921#discussion_r79745254
  
--- Diff: tools/bin/lib/.gitignore ---
@@ -2,7 +2,3 @@ netperf
 netserver
 stream
 Crypto
--- End diff --

We seem to be able to remove this file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Resolved] (HAWQ-1052) Select from PXF/ORC table fails for boolean datatype

2016-09-20 Thread Oleksandr Diachenko (JIRA)

 [ 
https://issues.apache.org/jira/browse/HAWQ-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleksandr Diachenko resolved HAWQ-1052.
---
Resolution: Fixed

> Select from PXF/ORC table fails for boolean datatype
> 
>
> Key: HAWQ-1052
> URL: https://issues.apache.org/jira/browse/HAWQ-1052
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: PXF
>Reporter: Oleksandr Diachenko
>Assignee: Oleksandr Diachenko
>Priority: Critical
> Fix For: 2.0.1.0-incubating
>
>
> {code}
> \d pxf_hive_orc_types
> External table "public.pxf_hive_orc_types"
>  Column |Type | Modifiers 
> +-+---
>  t1 | text| 
>  t2 | text| 
>  num1   | integer | 
>  dub1   | double precision| 
>  dec1   | numeric | 
>  tm | timestamp without time zone | 
>  r  | real| 
>  bg | bigint  | 
>  b  | boolean | 
>  tn | smallint| 
>  sml| smallint| 
>  dt | date| 
>  vc1| character varying(5)| 
>  c1 | character(3)| 
>  bin| bytea   | 
> Type: readable
> Encoding: UTF8
> Format type: custom
> Format options: formatter 'pxfwritable_import' 
> External location: 
> pxf://localhost:51200/hive_orc_all_types?PROFILE=HiveORC=^A
> {code}
> Query fails if condition applied to boolean column:
> {code}
> SELECT t1, b FROM pxf_hive_orc_types WHERE b is true;
> ERROR:  extractPxfAttributes: unsupported node tag 330, unable to extract 
> attribute from qualifier (pxffilters.c:665)  (seg4 localhost:4 pid=73027)
> DETAIL:  External table pxf_hive_orc_types
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-hawq pull request #915: HAWQ-1052. Fixed extraction logic for bool...

2016-09-20 Thread kavinderd
Github user kavinderd commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/915#discussion_r79740844
  
--- Diff: src/backend/access/external/pxfheaders.c ---
@@ -66,8 +66,13 @@ void build_http_header(PxfInputData *input)
if (proj_info != NULL && proj_info->pi_isVarList)
{
List* qualsAttributes = extractPxfAttributes(input->quals);
-
-   add_projection_desc_httpheader(headers, proj_info, 
qualsAttributes);
+   /* projection information is incomplete if columns from WHERE 
clause wasn't extracted */
+   if (qualsAttributes !=  NIL || list_length(input->quals) == 0)
--- End diff --

Ok, got it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #915: HAWQ-1052. Fixed extraction logic for bool...

2016-09-20 Thread sansanichfb
Github user sansanichfb commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/915#discussion_r79740591
  
--- Diff: src/backend/access/external/pxfheaders.c ---
@@ -66,8 +66,13 @@ void build_http_header(PxfInputData *input)
if (proj_info != NULL && proj_info->pi_isVarList)
{
List* qualsAttributes = extractPxfAttributes(input->quals);
-
-   add_projection_desc_httpheader(headers, proj_info, 
qualsAttributes);
+   /* projection information is incomplete if columns from WHERE 
clause wasn't extracted */
+   if (qualsAttributes !=  NIL || list_length(input->quals) == 0)
--- End diff --

extractPxfAttributes function might return NIL in two cases - when input 
quals are empty or some error occurred during extraction. So this condition 
list_length(input->quals) == 0 means no input quals has been passed thus 
nothing was extracted and it's safe to add projection info.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #915: HAWQ-1052. Fixed extraction logic for boolean dat...

2016-09-20 Thread kavinderd
Github user kavinderd commented on the issue:

https://github.com/apache/incubator-hawq/pull/915
  
Aside from my confusion with my comment, +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #915: HAWQ-1052. Fixed extraction logic for bool...

2016-09-20 Thread kavinderd
Github user kavinderd commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/915#discussion_r79740167
  
--- Diff: src/backend/access/external/pxfheaders.c ---
@@ -66,8 +66,13 @@ void build_http_header(PxfInputData *input)
if (proj_info != NULL && proj_info->pi_isVarList)
{
List* qualsAttributes = extractPxfAttributes(input->quals);
-
-   add_projection_desc_httpheader(headers, proj_info, 
qualsAttributes);
+   /* projection information is incomplete if columns from WHERE 
clause wasn't extracted */
+   if (qualsAttributes !=  NIL || list_length(input->quals) == 0)
--- End diff --

Why is the check for `list_length(input->quals)` with `0`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Assigned] (HAWQ-1054) Real/float4 rounding issues for HiveORC profile

2016-09-20 Thread Oleksandr Diachenko (JIRA)

 [ 
https://issues.apache.org/jira/browse/HAWQ-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleksandr Diachenko reassigned HAWQ-1054:
-

Assignee: Oleksandr Diachenko  (was: Goden Yao)

> Real/float4 rounding issues for HiveORC profile
> ---
>
> Key: HAWQ-1054
> URL: https://issues.apache.org/jira/browse/HAWQ-1054
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: PXF
>Reporter: Oleksandr Diachenko
>Assignee: Oleksandr Diachenko
>Priority: Critical
> Fix For: 2.0.1.0-incubating
>
>
> Looks like real values are being incorrectly rounded:
> {code}
>  SELECT t1, r FROM pxf_hive_orc_types WHERE r = 7.7;
>  t1 | r 
> +---
> (0 rows)
> SELECT t1, r FROM pxf_hive_orc_types WHERE r > 7.6;
>   t1  |  r   
> --+--
>  row1 |  7.7
>  row2 |  8.7
>  row3 |  9.7
>  row4 | 10.7
>  row5 | 11.7
>  row6 | 12.7
>  row7 |  7.7
>  row8 |  7.7
>  row9 |  7.7
>  row10|  7.7
>  row11|  7.7
>  row12_text_null  |  7.7
>  row13_int_null   |  7.7
>  row14_double_null|  7.7
>  row15_decimal_null   |  7.7
>  row16_timestamp_null |  7.7
>  row18_bigint_null|  7.7
>  row19_bool_null  |  7.7
>  row20_tinyint_null   |  7.7
>  row21_smallint_null  |  7.7
>  row22_date_null  |  7.7
>  row23_varchar_null   |  7.7
>  row24_char_null  |  7.7
>  row25_binary_null|  7.7
> (24 rows)
> {code}
> The same query works fine in Hive:
> {code}
> hive> select f from hive_orc_all_types where f = 7.7;
> OK
> 7.7
> 7.7
> 7.7
> 7.7
> 7.7
> 7.7
> 7.7
> 7.7
> 7.7
> 7.7
> 7.7
> 7.7
> 7.7
> 7.7
> 7.7
> 7.7
> 7.7
> 7.7
> 7.7
> Time taken: 0.032 seconds, Fetched: 19 row(s)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HAWQ-1056) "hawq check" help output and documentation updates needed

2016-09-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/HAWQ-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508041#comment-15508041
 ] 

ASF GitHub Bot commented on HAWQ-1056:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-hawq-docs/pull/9


> "hawq check" help output and documentation updates needed
> -
>
> Key: HAWQ-1056
> URL: https://issues.apache.org/jira/browse/HAWQ-1056
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Command Line Tools, Documentation
>Reporter: Lisa Owen
>Assignee: David Yozie
>Priority: Minor
> Fix For: 2.0.1.0-incubating
>
>
> help output and reference documentation for "hawq check" --hadoop option is 
> not clear.  specifically, this option should identify the full path to the 
> hadoop installation.
> additionally, the [-h | --host ] option appears to be missing in 
> both areas.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HAWQ-1065) Declare PL/Perl's ppport.h source file to be an Artistic License exception.

2016-09-20 Thread Ed Espino (JIRA)

[ 
https://issues.apache.org/jira/browse/HAWQ-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507794#comment-15507794
 ] 

Ed Espino commented on HAWQ-1065:
-

PR has been submitted: https://github.com/apache/incubator-hawq/pull/922

> Declare PL/Perl's ppport.h source file to be an Artistic License exception.
> ---
>
> Key: HAWQ-1065
> URL: https://issues.apache.org/jira/browse/HAWQ-1065
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Reporter: Ed Espino
>Assignee: Ed Espino
> Fix For: 2.0.0.0-incubating
>
>
> Pursuant to https://issues.apache.org/jira/browse/LEGAL-79 and PL/Perl's use 
> of generated header file (src/pl/plperl/ppport.h), we will declare it an 
> Artistic License exception in the LICENSE file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-hawq pull request #922: HAWQ-1065. Document ppport.h license excep...

2016-09-20 Thread edespino
GitHub user edespino opened a pull request:

https://github.com/apache/incubator-hawq/pull/922

HAWQ-1065. Document ppport.h license exception.

* Declare PL/Perl's src/pl/plperl/ppport.h source file to be an Perl
  Artistic License exception.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/edespino/incubator-hawq 
2.0.0.0-incubating-HAWQ-1065

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/922.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #922


commit 6e8933e5f2dab5df7259950aa20622b664d7db75
Author: Ed Espino 
Date:   2016-09-20T21:01:55Z

HAWQ-1065. Document ppport.h license exception.

* Declare PL/Perl's src/pl/plperl/ppport.h source file to be an Perl
  Artistic License exception.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Assigned] (HAWQ-1065) Declare PL/Perl's ppport.h source file to be an Artistic License exception.

2016-09-20 Thread Ed Espino (JIRA)

 [ 
https://issues.apache.org/jira/browse/HAWQ-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ed Espino reassigned HAWQ-1065:
---

Assignee: Ed Espino  (was: Lei Chang)

> Declare PL/Perl's ppport.h source file to be an Artistic License exception.
> ---
>
> Key: HAWQ-1065
> URL: https://issues.apache.org/jira/browse/HAWQ-1065
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Reporter: Ed Espino
>Assignee: Ed Espino
> Fix For: 2.0.0.0-incubating
>
>
> Pursuant to https://issues.apache.org/jira/browse/LEGAL-79 and PL/Perl's use 
> of generated header file (src/pl/plperl/ppport.h), we will declare it an 
> Artistic License exception in the LICENSE file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HAWQ-1065) Declare PL/Perl's ppport.h source file to be an Artistic License exception.

2016-09-20 Thread Ed Espino (JIRA)
Ed Espino created HAWQ-1065:
---

 Summary: Declare PL/Perl's ppport.h source file to be an Artistic 
License exception.
 Key: HAWQ-1065
 URL: https://issues.apache.org/jira/browse/HAWQ-1065
 Project: Apache HAWQ
  Issue Type: Bug
  Components: Build
Reporter: Ed Espino
Assignee: Lei Chang
 Fix For: 2.0.0.0-incubating


Pursuant to https://issues.apache.org/jira/browse/LEGAL-79 and PL/Perl's use of 
generated header file (src/pl/plperl/ppport.h), we will declare it an Artistic 
License exception in the LICENSE file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HAWQ-1064) Add LICENSE updates for pexpect-4.2 & ptyprocess-0.5.1

2016-09-20 Thread Ed Espino (JIRA)

[ 
https://issues.apache.org/jira/browse/HAWQ-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507686#comment-15507686
 ] 

Ed Espino commented on HAWQ-1064:
-

PR has been created: https://github.com/apache/incubator-hawq/pull/921

> Add LICENSE updates for pexpect-4.2 & ptyprocess-0.5.1
> --
>
> Key: HAWQ-1064
> URL: https://issues.apache.org/jira/browse/HAWQ-1064
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Reporter: Ed Espino
>Assignee: Ed Espino
> Fix For: 2.0.1.0-incubating
>
>
> The python module paramiko was replaced with pexpect-4.2 & ptyprocess-0.5.1.  
> The following additional changes are needed:
> * LICENSE file needs to be updated
> * The references to paramiko need to be removed from tools/bin/Makefile & 
> tools/bin/lib/.gitignore



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-hawq pull request #921: HAWQ-1064. Additional work related to para...

2016-09-20 Thread edespino
GitHub user edespino opened a pull request:

https://github.com/apache/incubator-hawq/pull/921

HAWQ-1064. Additional work related to paramiko removal.

The python module paramiko was replaced with pexpect-4.2 &
ptyprocess-0.5.1. The following additional changes are needed:

* LICENSE file needs to be updated
* The references to paramiko need to be removed from tools/bin/Makefile & 
tools/bin/lib/.gitignore

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/edespino/incubator-hawq master-HAWQ-1064

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/921.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #921


commit d209fd527c54b9ddc3ff9c9c177340d36a3e8db8
Author: Ed Espino 
Date:   2016-09-20T20:12:00Z

HAWQ-1064. Additional work related to paramiko removal.

The python module paramiko was replaced with pexpect-4.2 &
ptyprocess-0.5.1. The following additional changes are needed:

* LICENSE file needs to be updated
* The references to paramiko need to be removed from tools/bin/Makefile & 
tools/bin/lib/.gitignore




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Updated] (HAWQ-1064) Add LICENSE updates for pexpect-4.2 & ptyprocess-0.5.1

2016-09-20 Thread Ed Espino (JIRA)

 [ 
https://issues.apache.org/jira/browse/HAWQ-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ed Espino updated HAWQ-1064:

Fix Version/s: (was: 2.0.0.0-incubating)
   2.0.1.0-incubating

> Add LICENSE updates for pexpect-4.2 & ptyprocess-0.5.1
> --
>
> Key: HAWQ-1064
> URL: https://issues.apache.org/jira/browse/HAWQ-1064
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Reporter: Ed Espino
>Assignee: Ed Espino
> Fix For: 2.0.1.0-incubating
>
>
> The python module paramiko was replaced with pexpect-4.2 & ptyprocess-0.5.1.  
> The following additional changes are needed:
> * LICENSE file needs to be updated
> * The references to paramiko need to be removed from tools/bin/Makefile & 
> tools/bin/lib/.gitignore



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (HAWQ-1064) Add LICENSE updates for pexpect-4.2 & ptyprocess-0.5.1

2016-09-20 Thread Ed Espino (JIRA)

 [ 
https://issues.apache.org/jira/browse/HAWQ-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ed Espino reassigned HAWQ-1064:
---

Assignee: Ed Espino  (was: Lei Chang)

> Add LICENSE updates for pexpect-4.2 & ptyprocess-0.5.1
> --
>
> Key: HAWQ-1064
> URL: https://issues.apache.org/jira/browse/HAWQ-1064
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Reporter: Ed Espino
>Assignee: Ed Espino
> Fix For: 2.0.0.0-incubating
>
>
> The python module paramiko was replaced with pexpect-4.2 & ptyprocess-0.5.1.  
> The following additional changes are needed:
> * LICENSE file needs to be updated
> * The references to paramiko need to be removed from tools/bin/Makefile & 
> tools/bin/lib/.gitignore



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HAWQ-1064) Add LICENSE updates for pexpect-4.2 & ptyprocess-0.5.1

2016-09-20 Thread Ed Espino (JIRA)

 [ 
https://issues.apache.org/jira/browse/HAWQ-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ed Espino updated HAWQ-1064:

Fix Version/s: 2.0.0.0-incubating

> Add LICENSE updates for pexpect-4.2 & ptyprocess-0.5.1
> --
>
> Key: HAWQ-1064
> URL: https://issues.apache.org/jira/browse/HAWQ-1064
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Reporter: Ed Espino
>Assignee: Lei Chang
> Fix For: 2.0.0.0-incubating
>
>
> The python module paramiko was replaced with pexpect-4.2 & ptyprocess-0.5.1.  
> The following additional changes are needed:
> * LICENSE file needs to be updated
> * The references to paramiko need to be removed from tools/bin/Makefile & 
> tools/bin/lib/.gitignore



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HAWQ-1064) Add LICENSE updates for pexpect-4.2 & ptyprocess-0.5.1

2016-09-20 Thread Ed Espino (JIRA)
Ed Espino created HAWQ-1064:
---

 Summary: Add LICENSE updates for pexpect-4.2 & ptyprocess-0.5.1
 Key: HAWQ-1064
 URL: https://issues.apache.org/jira/browse/HAWQ-1064
 Project: Apache HAWQ
  Issue Type: Bug
  Components: Build
Reporter: Ed Espino
Assignee: Lei Chang


The python module paramiko was replaced with pexpect-4.2 & ptyprocess-0.5.1.  
The following additional changes are needed:
* LICENSE file needs to be updated
* The references to paramiko need to be removed from tools/bin/Makefile & 
tools/bin/lib/.gitignore



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HAWQ-1055) Fractional part is being dropped for decimal/numeric column with no modifiers in HiveORC profile

2016-09-20 Thread Shivram Mani (JIRA)

[ 
https://issues.apache.org/jira/browse/HAWQ-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507301#comment-15507301
 ] 

Shivram Mani commented on HAWQ-1055:


The following table shows how Hive decimal fields will be handled in HAWQ:

|| HAWQ Type || Hive Type || Behavior |
| numeric(precision, scale) | decimal(precision,scale) | As long as HAWQ has a 
higher scale/precision than defined in Hive, would be fine. If precision/scale 
is lower in HAWQ compared to Hive, will be reported as an error  |
| numeric(precision) | decimal(precision) | Hawq and Hive restricts scale to 0 |
| numeric | decimal | Hive defaults to <10,0> while HAWQ permits upto max 
(131072) for precision and upto 16383 for scale |

> Fractional part is being dropped for decimal/numeric column with no modifiers 
> in HiveORC profile
> 
>
> Key: HAWQ-1055
> URL: https://issues.apache.org/jira/browse/HAWQ-1055
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: PXF
>Reporter: Oleksandr Diachenko
>Assignee: Shivram Mani
>Priority: Critical
> Fix For: 2.0.1.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (HAWQ-1055) Fractional part is being dropped for decimal/numeric column with no modifiers in HiveORC profile

2016-09-20 Thread Shivram Mani (JIRA)

 [ 
https://issues.apache.org/jira/browse/HAWQ-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shivram Mani updated HAWQ-1055:
---
Comment: was deleted

(was: If there are no modifier information (precision,scale) specified for the 
numeric type in both hive/hawq, we will default to (10,0) as this is the 
default for Hive since 0.13.
If Hive has a precision specified without any modifier info in HAWQ for the 
same column, Hive's precision should be used.
The following cases will be handled according to the 

|| HAWQ Type || Hive Type || Behavior || Example ||
| numeric(precision, scale) | decimal(precision,scale) | As long as HAWQ has a 
higher scale/precision than defined in Hive, we should be fine | |
| numeric(precision) | decimal(precision) | Hawq and Hive restricts scale to 0 
| 9 |
| numeric | decimal | Hive defaults to <10,0> while HAWQ permits upto max 
(131072) for precision and upto 16383 for scale. | |)

> Fractional part is being dropped for decimal/numeric column with no modifiers 
> in HiveORC profile
> 
>
> Key: HAWQ-1055
> URL: https://issues.apache.org/jira/browse/HAWQ-1055
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: PXF
>Reporter: Oleksandr Diachenko
>Assignee: Shivram Mani
>Priority: Critical
> Fix For: 2.0.1.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (HAWQ-1055) Fractional part is being dropped for decimal/numeric column with no modifiers in HiveORC profile

2016-09-20 Thread Shivram Mani (JIRA)

 [ 
https://issues.apache.org/jira/browse/HAWQ-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shivram Mani reassigned HAWQ-1055:
--

Assignee: Shivram Mani  (was: Goden Yao)

> Fractional part is being dropped for decimal/numeric column with no modifiers 
> in HiveORC profile
> 
>
> Key: HAWQ-1055
> URL: https://issues.apache.org/jira/browse/HAWQ-1055
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: PXF
>Reporter: Oleksandr Diachenko
>Assignee: Shivram Mani
>Priority: Critical
> Fix For: 2.0.1.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-hawq pull request #920: HAWQ-1063 - HAWQ Python library missing im...

2016-09-20 Thread kdunn926
GitHub user kdunn926 opened a pull request:

https://github.com/apache/incubator-hawq/pull/920

HAWQ-1063 - HAWQ Python library missing import.

Fixing missing import for DatabaseError exception.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kdunn926/incubator-hawq bugfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/920.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #920


commit 3ad2faeb15509140e65ab8034d774fcbd46611a9
Author: Kyle Dunn 
Date:   2016-09-19T20:46:32Z

Missing import for DatabaseError exception @ line 556




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (HAWQ-1063) HAWQ Python library missing import

2016-09-20 Thread Kyle R Dunn (JIRA)
Kyle R Dunn created HAWQ-1063:
-

 Summary: HAWQ Python library missing import
 Key: HAWQ-1063
 URL: https://issues.apache.org/jira/browse/HAWQ-1063
 Project: Apache HAWQ
  Issue Type: Bug
  Components: Command Line Tools
Reporter: Kyle R Dunn
Assignee: Lei Chang


The file: `tools/bin/hawqpylib/hawqlib.py` is missing a required import for 
catching a DatabaseError exception. This exception is raised when HAWQ is 
stopped and a tool like `gppkg` is used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-hawq issue #918: HAWQ-1062. Remove ASF incompatible Perl JSON modu...

2016-09-20 Thread xunzhang
Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/918
  
Hi @edespino , I checked out the Travis Failure from 
https://s3.amazonaws.com/archive.travis-ci.org/jobs/161283621/log.txt. I think 
you should also modify lines around 
[here](https://github.com/apache/incubator-hawq/blob/master/src/backend/catalog/caql/Makefile#L175)
 together with this pull request~


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #919: HAWQ-1061. Add check_sizes_valid for all m...

2016-09-20 Thread xunzhang
Github user xunzhang closed the pull request at:

https://github.com/apache/incubator-hawq/pull/919


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #919: HAWQ-1061. Add check_sizes_valid for all mode of ...

2016-09-20 Thread xunzhang
Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/919
  
Merged into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Updated] (HAWQ-1024) Rollback if hawq register failed in process

2016-09-20 Thread hongwu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HAWQ-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

hongwu updated HAWQ-1024:
-
Description: Register multiple files need to be rollback when there is some 
error before done. It’s better to check source/target files exists and 
permissions.

> Rollback if hawq register failed in process
> ---
>
> Key: HAWQ-1024
> URL: https://issues.apache.org/jira/browse/HAWQ-1024
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: Command Line Tools
>Affects Versions: 2.0.1.0-incubating
>Reporter: hongwu
>Assignee: hongwu
> Fix For: 2.0.1.0-incubating
>
>
> Register multiple files need to be rollback when there is some error before 
> done. It’s better to check source/target files exists and permissions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (HAWQ-1024) Rollback if hawq register failed in process

2016-09-20 Thread hongwu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HAWQ-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

hongwu reopened HAWQ-1024:
--

> Rollback if hawq register failed in process
> ---
>
> Key: HAWQ-1024
> URL: https://issues.apache.org/jira/browse/HAWQ-1024
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: Command Line Tools
>Affects Versions: 2.0.1.0-incubating
>Reporter: hongwu
>Assignee: hongwu
> Fix For: 2.0.1.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-hawq issue #919: HAWQ-1061. Add check_sizes_valid for all mode of ...

2016-09-20 Thread ictmalili
Github user ictmalili commented on the issue:

https://github.com/apache/incubator-hawq/pull/919
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Resolved] (HAWQ-1062) Remove ASF Category X incompatible JSON Perl Module (Artistic license)

2016-09-20 Thread Ed Espino (JIRA)

 [ 
https://issues.apache.org/jira/browse/HAWQ-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ed Espino resolved HAWQ-1062.
-
Resolution: Fixed

This has been merged to the master and 2.0.0.0-incubator release branch.

> Remove ASF Category X incompatible JSON Perl Module (Artistic license)
> --
>
> Key: HAWQ-1062
> URL: https://issues.apache.org/jira/browse/HAWQ-1062
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Reporter: Ed Espino
>Assignee: Ed Espino
> Fix For: 2.0.0.0-incubating
>
>
> As part of the initial Apache HAWQ 2.0.0.0-incubator release, the inclusion 
> of the ASF Category X incompatible JSON Perl Module (Artistic license) was 
> observed.  The JSON module is used when the catalog is rebuilt manually from 
> the command line (example: perl tidycat.pl -dd 2.0.json -df json *.h).  The 
> user will need to install the JSON perl module (available in CPAN) into their 
> environment manually to run the tidycat.pl toolchain.  The JSON versions 2.27 
> through 2.90 are known to work properly.
> We will be removing the JSON Perl Modules from the code base.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-hawq pull request #919: HAWQ-1061. Add check_sizes_valid for all m...

2016-09-20 Thread xunzhang
Github user xunzhang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/919#discussion_r79574274
  
--- Diff: tools/bin/hawqregister ---
@@ -397,6 +397,14 @@ class HawqRegister(object):
 logger.info('%s is not a file in hdfs, please check 
the yaml configuration file.' % fn)
 sys.exit(1)
 
+def check_sizes_valid():
+for k, fn in enumerate(self.files):
+hdfscmd = 'hdfs dfs -du %s' % fn
+_, out, _ = local_ssh_output(hdfscmd)
+if self.sizes[k] > int(out.strip().split()[0]):
+logger.error('Incorrect filesize %s in yaml of file 
%s: out of range %s' % (self.sizes[k], fn, out.strip().split()[0]))
--- End diff --

@ictmalili done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #919: HAWQ-1061. Add check_sizes_valid for all mode of ...

2016-09-20 Thread stanlyxiang
Github user stanlyxiang commented on the issue:

https://github.com/apache/incubator-hawq/pull/919
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #918: HAWQ-1062. Remove ASF incompatible Perl JS...

2016-09-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-hawq/pull/918


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #919: HAWQ-1061. Add check_sizes_valid for all mode of ...

2016-09-20 Thread xunzhang
Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/919
  
also cc @stanlyxiang 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #919: HAWQ-1061. Add check_sizes_valid for all mode of ...

2016-09-20 Thread xunzhang
Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/919
  
cc @ictmalili @linwen 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #918: HAWQ-1062. Remove ASF incompatible Perl JSON modu...

2016-09-20 Thread edespino
Github user edespino commented on the issue:

https://github.com/apache/incubator-hawq/pull/918
  
@xunzhang - This is building the 2.0.0.0-incubating branch and this is 
known to not pass.  The changes do not impact the build process.

@paul-guo- - I have added a section *Running catalog tidycat perl modules* 
to the build page 
https://cwiki.apache.org/confluence/display/HAWQ/Build+and+Install


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #919: HAWQ-1061. Add check_sizes_valid for all m...

2016-09-20 Thread xunzhang
GitHub user xunzhang opened a pull request:

https://github.com/apache/incubator-hawq/pull/919

HAWQ-1061. Add check_sizes_valid for all mode of hawq register.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xunzhang/incubator-hawq hotfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/919.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #919


commit 77aa508be1aae3aa8b7eb7b24d11bf9c63aa2f4c
Author: xunzhang 
Date:   2016-09-20T09:25:22Z

HAWQ-1061. Add check_sizes_valid for all mode of hawq register.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #918: HAWQ-1062. Remove ASF incompatible Perl JSON modu...

2016-09-20 Thread xunzhang
Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/918
  
@edespino Cool, I missed the help info, that is enough. Seems Travis-CI 
failed, does this change affect building process?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #918: HAWQ-1062. Remove ASF incompatible Perl JSON modu...

2016-09-20 Thread paul-guo-
Github user paul-guo- commented on the issue:

https://github.com/apache/incubator-hawq/pull/918
  
I think we could add more details  on wiki to save dev's time although dev 
do not call these perl script often. ed, you have had the successful experience 
so you can share on that page.

I just tried to install JSON perl module but failed, following the steps on 
http://www.cpan.org/modules/INSTALL.html

cpan App::cpanminus
cpanm Module::JSON



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #918: HAWQ-1062. Remove ASF incompatible Perl JSON modu...

2016-09-20 Thread edespino
Github user edespino commented on the issue:

https://github.com/apache/incubator-hawq/pull/918
  
@xunzhang - I feel the error message received when using the tools is 
sufficient enough.  It informs the user the require JSON package is not 
installed and where to get it from (www.cpan.org).  That should be sufficient 
for a developer to install the module for use with the Perl utilities.  It is 
what I used when manually updating my system with the JSON module on my system 
in order to run the tidycat.pl utility.  Is that sufficient?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #918: HAWQ-1062. Remove ASF incompatible Perl JSON modu...

2016-09-20 Thread linwen
Github user linwen commented on the issue:

https://github.com/apache/incubator-hawq/pull/918
  
LGTM! +1 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #918: HAWQ-1062. Remove ASF incompatible Perl JSON modu...

2016-09-20 Thread huor
Github user huor commented on the issue:

https://github.com/apache/incubator-hawq/pull/918
  
Good to have this fix. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #911: HAWQ-1061. Fix data loss when file locations incl...

2016-09-20 Thread xunzhang
Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/911
  
Merged into master, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #911: HAWQ-1061. Fix data loss when file locatio...

2016-09-20 Thread xunzhang
Github user xunzhang closed the pull request at:

https://github.com/apache/incubator-hawq/pull/911


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #911: HAWQ-1061. Fix data loss when file locations incl...

2016-09-20 Thread ictmalili
Github user ictmalili commented on the issue:

https://github.com/apache/incubator-hawq/pull/911
  
LGTM. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (HAWQ-1062) Remove ASF Category X incompatible JSON Perl Module (Artistic license)

2016-09-20 Thread Ed Espino (JIRA)

[ 
https://issues.apache.org/jira/browse/HAWQ-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505934#comment-15505934
 ] 

Ed Espino commented on HAWQ-1062:
-

PR #918 (https://github.com/apache/incubator-hawq/pull/918) has been created to 
address this issue.

> Remove ASF Category X incompatible JSON Perl Module (Artistic license)
> --
>
> Key: HAWQ-1062
> URL: https://issues.apache.org/jira/browse/HAWQ-1062
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Reporter: Ed Espino
>Assignee: Lei Chang
> Fix For: 2.0.0.0-incubating
>
>
> As part of the initial Apache HAWQ 2.0.0.0-incubator release, the inclusion 
> of the ASF Category X incompatible JSON Perl Module (Artistic license) was 
> observed.  The JSON module is used when the catalog is rebuilt manually from 
> the command line (example: perl tidycat.pl -dd 2.0.json -df json *.h).  The 
> user will need to install the JSON perl module (available in CPAN) into their 
> environment manually to run the tidycat.pl toolchain.  The JSON versions 2.27 
> through 2.90 are known to work properly.
> We will be removing the JSON Perl Modules from the code base.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (HAWQ-1062) Remove ASF Category X incompatible JSON Perl Module (Artistic license)

2016-09-20 Thread Ed Espino (JIRA)

 [ 
https://issues.apache.org/jira/browse/HAWQ-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ed Espino reassigned HAWQ-1062:
---

Assignee: Ed Espino  (was: Lei Chang)

> Remove ASF Category X incompatible JSON Perl Module (Artistic license)
> --
>
> Key: HAWQ-1062
> URL: https://issues.apache.org/jira/browse/HAWQ-1062
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Reporter: Ed Espino
>Assignee: Ed Espino
> Fix For: 2.0.0.0-incubating
>
>
> As part of the initial Apache HAWQ 2.0.0.0-incubator release, the inclusion 
> of the ASF Category X incompatible JSON Perl Module (Artistic license) was 
> observed.  The JSON module is used when the catalog is rebuilt manually from 
> the command line (example: perl tidycat.pl -dd 2.0.json -df json *.h).  The 
> user will need to install the JSON perl module (available in CPAN) into their 
> environment manually to run the tidycat.pl toolchain.  The JSON versions 2.27 
> through 2.90 are known to work properly.
> We will be removing the JSON Perl Modules from the code base.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-hawq pull request #918: HAWQ-1062. Remove ASF incompatible Perl JS...

2016-09-20 Thread edespino
GitHub user edespino opened a pull request:

https://github.com/apache/incubator-hawq/pull/918

HAWQ-1062. Remove ASF incompatible Perl JSON module

* Remove JSON Perl Module (Artistic license) module (files and
  directory) from source tree.  The user wanting to run these Perl JSON
  module dependent scripts (tidycat.pl, calico.pl, caqluniqdef.pl) are
  instructed to download it from www.cpan.org if it is not found in dev
  environment.  Here is error message received if JSON Perl Module is
  not found:

Fatal Error: The required package JSON is not installed -- please
download it from www.cpan.org

  JSON Perl Module versions 2.27 through 2.90 are known to work.

* Update LICENSE file and remove licenses/LICENSE-json.txtfile.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/edespino/incubator-hawq 
2.0.0.0-incubating-HAWQ-1062

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/918.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #918


commit b7c8717bda7af633573dc464bedac16eebefab1e
Author: Ed Espino 
Date:   2016-09-20T07:33:45Z

HAWQ-1062. Remove ASF incompatible Perl JSON module

* Remove JSON Perl Module (Artistic license) module (files and
  directory) from source tree.  The user wanting to run these Perl JSON
  module dependent scripts (tidycat.pl, calico.pl, caqluniqdef.pl) are
  instructed to download it from www.cpan.org if it is not found in dev
  environment.  Here is error message received if JSON Perl Module is
  not found:

Fatal Error: The required package JSON is not installed -- please
download it from www.cpan.org

  JSON Perl Module versions 2.27 through 2.90 are known to work.

* Update LICENSE file and remove licenses/LICENSE-json.txtfile.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (HAWQ-1062) Remove ASF Category X incompatible JSON Perl Module (Artistic license)

2016-09-20 Thread Ed Espino (JIRA)
Ed Espino created HAWQ-1062:
---

 Summary: Remove ASF Category X incompatible JSON Perl Module 
(Artistic license)
 Key: HAWQ-1062
 URL: https://issues.apache.org/jira/browse/HAWQ-1062
 Project: Apache HAWQ
  Issue Type: Bug
  Components: Build
Reporter: Ed Espino
Assignee: Lei Chang
 Fix For: 2.0.0.0-incubating


As part of the initial Apache HAWQ 2.0.0.0-incubator release, the inclusion of 
the ASF Category X incompatible JSON Perl Module (Artistic license) was 
observed.  The JSON module is used when the catalog is rebuilt manually from 
the command line (example: perl tidycat.pl -dd 2.0.json -df json *.h).  The 
user will need to install the JSON perl module (available in CPAN) into their 
environment manually to run the tidycat.pl toolchain.  The JSON versions 2.27 
through 2.90 are known to work properly.

We will be removing the JSON Perl Modules from the code base.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-hawq issue #917: HAWQ-1035. Add ddl of partition table for hawq re...

2016-09-20 Thread paul-guo-
Github user paul-guo- commented on the issue:

https://github.com/apache/incubator-hawq/pull/917
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---