[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r415518856 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -998,24 +998,6 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r415508930 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -998,24 +998,6 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r415509197 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -998,24 +998,6 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r415508804 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -998,24 +998,6 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r415508804 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -998,24 +998,6 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r415508930 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -998,24 +998,6 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r415497027 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/throttle/TestDynamicConfWithThroughputController.java ## @@ -0,0 +1,233 @@

[GitHub] [hbase] Apache-HBase commented on pull request #1482: HBASE-24152 Add ServerSsdLocalityCostFunction to StochasticLoadBalancer

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1482: URL: https://github.com/apache/hbase/pull/1482#issuecomment-619695732 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1590: HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoC…

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1590: URL: https://github.com/apache/hbase/pull/1590#issuecomment-619692368 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1590: HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoC…

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1590: URL: https://github.com/apache/hbase/pull/1590#issuecomment-619691807 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1590: HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoC…

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1590: URL: https://github.com/apache/hbase/pull/1590#issuecomment-619686599 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-23264) Resolve a TODO of BucketAllocator: "Why we add the extra 1024 bytes? Slop?"

2020-04-26 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092963#comment-17092963 ] Zheng Wang commented on HBASE-23264: Thanks very much. > Resolve a TODO of BucketAllocator: "Why we

[GitHub] [hbase] Apache-HBase commented on pull request #1590: HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoC…

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1590: URL: https://github.com/apache/hbase/pull/1590#issuecomment-619684073 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on pull request #1590: HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoC…

2020-04-26 Thread GitBox
saintstack commented on pull request #1590: URL: https://github.com/apache/hbase/pull/1590#issuecomment-619679866 Fails some async tests with Caused by: java.lang.ClassNotFoundException: com.sun.jersey.spi.container.servlet.ServletContainer ... i.e. looking for jersey1 where shouldn't be.

[jira] [Commented] (HBASE-23264) Resolve a TODO of BucketAllocator: "Why we add the extra 1024 bytes? Slop?"

2020-04-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092933#comment-17092933 ] Hudson commented on HBASE-23264: Results for branch branch-2 [build #2632 on

[jira] [Updated] (HBASE-24265) Rmove hedged rpc call support, implement the logic in MaterRegistry directly

2020-04-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24265: -- Summary: Rmove hedged rpc call support, implement the logic in MaterRegistry directly (was:

[jira] [Work started] (HBASE-24265) Rmove hedged rpc call support, implement the logic in MaterRegistry directly

2020-04-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24265 started by Duo Zhang. - > Rmove hedged rpc call support, implement the logic in MaterRegistry directly >

[jira] [Assigned] (HBASE-24265) Rmove hedged rpc call support, implement the logic in MaterRegistry directly

2020-04-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24265: - Assignee: Duo Zhang > Rmove hedged rpc call support, implement the logic in MaterRegistry

[jira] [Commented] (HBASE-24265) Re-enable TestNettyIPC.testHedgedAsyncEcho

2020-04-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092915#comment-17092915 ] Duo Zhang commented on HBASE-24265: --- Think again, I do not think it is a good idea to implement the

[jira] [Resolved] (HBASE-24264) Disable TestNettyIPC.testHedgedAsyncEcho

2020-04-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24264. --- Resolution: Fixed > Disable TestNettyIPC.testHedgedAsyncEcho >

[jira] [Updated] (HBASE-24264) Disable TestNettyIPC.testHedgedAsyncEcho

2020-04-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24264: -- Fix Version/s: 2.3.0 > Disable TestNettyIPC.testHedgedAsyncEcho >

[jira] [Created] (HBASE-24266) Document of Hbase on Aarch64

2020-04-26 Thread huangtianhua (Jira)
huangtianhua created HBASE-24266: Summary: Document of Hbase on Aarch64 Key: HBASE-24266 URL: https://issues.apache.org/jira/browse/HBASE-24266 Project: HBase Issue Type: Improvement

[jira] [Commented] (HBASE-24264) Disable TestNettyIPC.testHedgedAsyncEcho

2020-04-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092913#comment-17092913 ] Duo Zhang commented on HBASE-24264: --- Seems fine now. Let me cherry-pick to branch-2.x. > Disable

[jira] [Resolved] (HBASE-24263) TestDelegationToken is broken

2020-04-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24263. --- Hadoop Flags: Reviewed Resolution: Fixed PreCommit seems fine now. > TestDelegationToken is

[GitHub] [hbase] Apache-HBase commented on pull request #1590: HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoC…

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1590: URL: https://github.com/apache/hbase/pull/1590#issuecomment-619642501 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1590: HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoC…

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1590: URL: https://github.com/apache/hbase/pull/1590#issuecomment-619638798 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1590: HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoC…

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1590: URL: https://github.com/apache/hbase/pull/1590#issuecomment-619635692 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on pull request #1590: HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoC…

2020-04-26 Thread GitBox
saintstack commented on pull request #1590: URL: https://github.com/apache/hbase/pull/1590#issuecomment-619634510 Some cleanup and fix of whitespace complaints This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #1589: HBASE-24264 Disable TestNettyIPC.testHedgedAsyncEcho

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1589: URL: https://github.com/apache/hbase/pull/1589#issuecomment-619609115 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1590: HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoC…

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1590: URL: https://github.com/apache/hbase/pull/1590#issuecomment-619608215 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-23264) Resolve a TODO of BucketAllocator: "Why we add the extra 1024 bytes? Slop?"

2020-04-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092829#comment-17092829 ] Hudson commented on HBASE-23264: Results for branch branch-2.2 [build #848 on

[GitHub] [hbase] Apache-HBase commented on pull request #1589: HBASE-24264 Disable TestNettyIPC.testHedgedAsyncEcho

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1589: URL: https://github.com/apache/hbase/pull/1589#issuecomment-619607317 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1590: HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoC…

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1590: URL: https://github.com/apache/hbase/pull/1590#issuecomment-619603155 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24215) [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoClassDefFoundError: com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate

2020-04-26 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092811#comment-17092811 ] Michael Stack commented on HBASE-24215: --- Added #PR1590. Still needs some cleanup. {code} Purges

[GitHub] [hbase] saintstack opened a new pull request #1590: HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoC…

2020-04-26 Thread GitBox
saintstack opened a new pull request #1590: URL: https://github.com/apache/hbase/pull/1590 …lassDefFoundError: com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate Test patch to see how it does on hadoopqa. Purges transitive jaxb includes so I can specify jaxb when needed.

[jira] [Commented] (HBASE-24257) Exclude jsr311-api from classpath

2020-04-26 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092804#comment-17092804 ] Michael Stack commented on HBASE-24257: --- Over in HBASE-24215, I ran into issue like this trying to

[jira] [Commented] (HBASE-24215) [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoClassDefFoundError: com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate

2020-04-26 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092798#comment-17092798 ] Michael Stack commented on HBASE-24215: --- JDK11 and JAXB... no longer provided. Was getting this

[GitHub] [hbase] Apache-HBase commented on pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1588: URL: https://github.com/apache/hbase/pull/1588#issuecomment-619592236 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1588: URL: https://github.com/apache/hbase/pull/1588#issuecomment-619577445 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #767: HBASE-22710 Wrong result in one case of scan that use raw and version…

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #767: URL: https://github.com/apache/hbase/pull/767#issuecomment-619576493 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 46s

[GitHub] [hbase] Apache-HBase commented on pull request #767: HBASE-22710 Wrong result in one case of scan that use raw and version…

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #767: URL: https://github.com/apache/hbase/pull/767#issuecomment-619574325 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 59s

[GitHub] [hbase] Apache-HBase commented on pull request #1589: HBASE-24264 Disable TestNettyIPC.testHedgedAsyncEcho

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1589: URL: https://github.com/apache/hbase/pull/1589#issuecomment-619573218 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache9 commented on pull request #1589: HBASE-24264 Disable TestNettyIPC.testHedgedAsyncEcho

2020-04-26 Thread GitBox
Apache9 commented on pull request #1589: URL: https://github.com/apache/hbase/pull/1589#issuecomment-619571322 Let's see if the flaky job can complete without timeout with this. This is an automated message from the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-619568084 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-619567731 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 opened a new pull request #1589: HBASE-24264 Disable TestNettyIPC.testHedgedAsyncEcho

2020-04-26 Thread GitBox
Apache9 opened a new pull request #1589: URL: https://github.com/apache/hbase/pull/1589 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (HBASE-24265) Re-enable TestNettyIPC.testHedgedAsyncEcho

2020-04-26 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-24265: - Summary: Re-enable TestNettyIPC.testHedgedAsyncEcho Key: HBASE-24265 URL: https://issues.apache.org/jira/browse/HBASE-24265 Project: HBase Issue Type: Sub-task

[jira] [Work started] (HBASE-24264) Disable TestNettyIPC.testHedgedAsyncEcho

2020-04-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24264 started by Duo Zhang. - > Disable TestNettyIPC.testHedgedAsyncEcho >

[jira] [Created] (HBASE-24264) Disable TestNettyIPC.testHedgedAsyncEcho

2020-04-26 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-24264: - Summary: Disable TestNettyIPC.testHedgedAsyncEcho Key: HBASE-24264 URL: https://issues.apache.org/jira/browse/HBASE-24264 Project: HBase Issue Type: Task

[GitHub] [hbase] virajjasani commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
virajjasani commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r415322441 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/OffPeakHours.java ## @@ -101,5 +101,13 @@ public boolean

[GitHub] [hbase] virajjasani commented on pull request #767: HBASE-22710 Wrong result in one case of scan that use raw and version…

2020-04-26 Thread GitBox
virajjasani commented on pull request #767: URL: https://github.com/apache/hbase/pull/767#issuecomment-619558793 Please review @yangzhe1991 @Apache9 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] Apache-HBase commented on pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1588: URL: https://github.com/apache/hbase/pull/1588#issuecomment-619558726 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-24262) Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread yaojingyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yaojingyi updated HBASE-24262: -- Attachment: HBASE-24262.master.002.patch > Improvement update_config for

[GitHub] [hbase] Apache-HBase commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-619549148 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1482: HBASE-24152 Add ServerSsdLocalityCostFunction to StochasticLoadBalancer

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1482: URL: https://github.com/apache/hbase/pull/1482#issuecomment-619548372 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1482: HBASE-24152 Add ServerSsdLocalityCostFunction to StochasticLoadBalancer

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1482: URL: https://github.com/apache/hbase/pull/1482#issuecomment-619548259 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1482: HBASE-24152 Add ServerSsdLocalityCostFunction to StochasticLoadBalancer

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1482: URL: https://github.com/apache/hbase/pull/1482#issuecomment-619548015 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bsglz commented on pull request #1482: HBASE-24152 Add ServerSsdLocalityCostFunction to StochasticLoadBalancer

2020-04-26 Thread GitBox
bsglz commented on pull request #1482: URL: https://github.com/apache/hbase/pull/1482#issuecomment-619545228 rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #767: HBASE-22710 Wrong result in one case of scan that use raw and version…

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #767: URL: https://github.com/apache/hbase/pull/767#issuecomment-619544205 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 0s

[GitHub] [hbase] Apache-HBase commented on pull request #1569: HBASE-24221 Support bulkLoadHFile by family

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1569: URL: https://github.com/apache/hbase/pull/1569#issuecomment-619542450 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-04-26 Thread GitBox
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-619542169 rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #801: HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra …

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #801: URL: https://github.com/apache/hbase/pull/801#issuecomment-619540720 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s

[GitHub] [hbase] Apache-HBase commented on pull request #1569: HBASE-24221 Support bulkLoadHFile by family

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1569: URL: https://github.com/apache/hbase/pull/1569#issuecomment-619540469 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #801: HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra …

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #801: URL: https://github.com/apache/hbase/pull/801#issuecomment-619540151 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s

[GitHub] [hbase] bsglz commented on a change in pull request #767: HBASE-22710 Wrong result in one case of scan that use raw and version…

2020-04-26 Thread GitBox
bsglz commented on a change in pull request #767: URL: https://github.com/apache/hbase/pull/767#discussion_r415293749 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java ## @@ -1022,4 +1026,31 @@ public void

[GitHub] [hbase] bsglz commented on a change in pull request #767: HBASE-22710 Wrong result in one case of scan that use raw and version…

2020-04-26 Thread GitBox
bsglz commented on a change in pull request #767: URL: https://github.com/apache/hbase/pull/767#discussion_r415288472 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java ## @@ -372,10 +372,11 @@ protected static

[GitHub] [hbase] bsglz commented on a change in pull request #767: HBASE-22710 Wrong result in one case of scan that use raw and version…

2020-04-26 Thread GitBox
bsglz commented on a change in pull request #767: URL: https://github.com/apache/hbase/pull/767#discussion_r415289682 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java ## @@ -372,10 +372,11 @@ protected static

[GitHub] [hbase] bsglz commented on a change in pull request #767: HBASE-22710 Wrong result in one case of scan that use raw and version…

2020-04-26 Thread GitBox
bsglz commented on a change in pull request #767: URL: https://github.com/apache/hbase/pull/767#discussion_r415288472 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java ## @@ -372,10 +372,11 @@ protected static

[GitHub] [hbase] bsglz commented on a change in pull request #767: HBASE-22710 Wrong result in one case of scan that use raw and version…

2020-04-26 Thread GitBox
bsglz commented on a change in pull request #767: URL: https://github.com/apache/hbase/pull/767#discussion_r415288472 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java ## @@ -372,10 +372,11 @@ protected static

[GitHub] [hbase] bsglz commented on a change in pull request #767: HBASE-22710 Wrong result in one case of scan that use raw and version…

2020-04-26 Thread GitBox
bsglz commented on a change in pull request #767: URL: https://github.com/apache/hbase/pull/767#discussion_r415288472 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java ## @@ -372,10 +372,11 @@ protected static

[GitHub] [hbase] bsglz commented on a change in pull request #767: HBASE-22710 Wrong result in one case of scan that use raw and version…

2020-04-26 Thread GitBox
bsglz commented on a change in pull request #767: URL: https://github.com/apache/hbase/pull/767#discussion_r415288472 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java ## @@ -372,10 +372,11 @@ protected static

[GitHub] [hbase] bsglz commented on a change in pull request #767: HBASE-22710 Wrong result in one case of scan that use raw and version…

2020-04-26 Thread GitBox
bsglz commented on a change in pull request #767: URL: https://github.com/apache/hbase/pull/767#discussion_r415288472 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java ## @@ -372,10 +372,11 @@ protected static

[jira] [Commented] (HBASE-24211) Create table is slow in large cluster when AccessController is enabled.

2020-04-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092671#comment-17092671 ] Hudson commented on HBASE-24211: Results for branch branch-1 [build #1289 on

[jira] [Resolved] (HBASE-23264) Resolve a TODO of BucketAllocator: "Why we add the extra 1024 bytes? Slop?"

2020-04-26 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-23264. -- Fix Version/s: 2.2.5 1.7.0 2.3.0

[GitHub] [hbase] Apache-HBase commented on pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThro…

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1588: URL: https://github.com/apache/hbase/pull/1588#issuecomment-619525697 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThro…

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1588: URL: https://github.com/apache/hbase/pull/1588#issuecomment-619525093 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #801: HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra …

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #801: URL: https://github.com/apache/hbase/pull/801#issuecomment-619523078 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s

[jira] [Updated] (HBASE-24262) Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread yaojingyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yaojingyi updated HBASE-24262: -- Attachment: HBASE-24262.master.001.patch > Improvement update_config for

[GitHub] [hbase] bsglz commented on a change in pull request #801: HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra …

2020-04-26 Thread GitBox
bsglz commented on a change in pull request #801: URL: https://github.com/apache/hbase/pull/801#discussion_r415266260 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java ## @@ -269,8 +269,9 @@ public String toString() {

[jira] [Updated] (HBASE-24262) Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread yaojingyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yaojingyi updated HBASE-24262: -- Priority: Major (was: Minor) > Improvement update_config for

[GitHub] [hbase] virajjasani commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-04-26 Thread GitBox
virajjasani commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-619515566 @bsglz Please resolve the conflicts. I will get back to this for review. This is an automated message from

[jira] [Commented] (HBASE-24262) Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread yaojingyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092603#comment-17092603 ] yaojingyi commented on HBASE-24262: --- Hi,[~zghao] can you help me to review the patch ? Thank you.  

[GitHub] [hbase] virajjasani commented on a change in pull request #801: HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra …

2020-04-26 Thread GitBox
virajjasani commented on a change in pull request #801: URL: https://github.com/apache/hbase/pull/801#discussion_r415261746 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java ## @@ -269,8 +269,9 @@ public String toString() {

[GitHub] [hbase] virajjasani commented on a change in pull request #767: HBASE-22710 Wrong result in one case of scan that use raw and version…

2020-04-26 Thread GitBox
virajjasani commented on a change in pull request #767: URL: https://github.com/apache/hbase/pull/767#discussion_r415257880 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java ## @@ -372,10 +372,11 @@ protected

[jira] [Work started] (HBASE-24262) Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread yaojingyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24262 started by yaojingyi. - > Improvement update_config for PressureAwareCompactionThroughputController >

[GitHub] [hbase] Apache-HBase commented on pull request #1569: HBASE-24221 Support bulkLoadHFile by family

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1569: URL: https://github.com/apache/hbase/pull/1569#issuecomment-619511723 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThro…

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1588: URL: https://github.com/apache/hbase/pull/1588#issuecomment-619510970 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-24262) Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread yaojingyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yaojingyi updated HBASE-24262: -- Description: If we modified compaction limit configuration,and use 'update_config' to update it .

[jira] [Updated] (HBASE-24262) Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread yaojingyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yaojingyi updated HBASE-24262: -- Description: If we modified compaction limit configuration,and use 'update_config' to update it .

[GitHub] [hbase] Apache-HBase commented on pull request #1569: HBASE-24221 Support bulkLoadHFile by family

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1569: URL: https://github.com/apache/hbase/pull/1569#issuecomment-619503672 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ystaticy opened a new pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThro…

2020-04-26 Thread GitBox
ystaticy opened a new pull request #1588: URL: https://github.com/apache/hbase/pull/1588 …ughputController This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hbase] Apache-HBase commented on pull request #1569: HBASE-24221 Support bulkLoadHFile by family

2020-04-26 Thread GitBox
Apache-HBase commented on pull request #1569: URL: https://github.com/apache/hbase/pull/1569#issuecomment-619502272 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m