[GitHub] [hbase] bsglz commented on a change in pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-05-28 Thread GitBox
bsglz commented on a change in pull request #1737: URL: https://github.com/apache/hbase/pull/1737#discussion_r432269012 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java ## @@ -639,26 +641,30 @@ public int getNumLogFiles() {

[GitHub] [hbase] bsglz commented on a change in pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-05-28 Thread GitBox
bsglz commented on a change in pull request #1737: URL: https://github.com/apache/hbase/pull/1737#discussion_r432268692 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java ## @@ -639,26 +641,30 @@ public int getNumLogFiles() {

[GitHub] [hbase] bsglz commented on a change in pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-05-28 Thread GitBox
bsglz commented on a change in pull request #1737: URL: https://github.com/apache/hbase/pull/1737#discussion_r432267965 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java ## @@ -459,13 +459,18 @@ private FlushType

[GitHub] [hbase] bsglz commented on a change in pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-05-28 Thread GitBox
bsglz commented on a change in pull request #1737: URL: https://github.com/apache/hbase/pull/1737#discussion_r432267596 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -2444,8 +2451,16 @@ public FlushResultImpl

[jira] [Updated] (HBASE-24389) Introduce new master rpc methods to locate meta region through root region

2020-05-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24389: -- Summary: Introduce new master rpc methods to locate meta region through root region (was: Introduce

[jira] [Work started] (HBASE-24390) Remove RegionInfoBuilder.FIRST_META_REGIONINFO

2020-05-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24390 started by Duo Zhang. - > Remove RegionInfoBuilder.FIRST_META_REGIONINFO >

[jira] [Assigned] (HBASE-24390) Remove RegionInfoBuilder.FIRST_META_REGIONINFO

2020-05-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24390: - Assignee: Duo Zhang > Remove RegionInfoBuilder.FIRST_META_REGIONINFO >

[GitHub] [hbase] Apache-HBase commented on pull request #1801: [HBASE-24441]CacheConfig details logged at Store open is not really u…

2020-05-28 Thread GitBox
Apache-HBase commented on pull request #1801: URL: https://github.com/apache/hbase/pull/1801#issuecomment-635745648 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-24468) Add region info when log meessages in HStore.

2020-05-28 Thread song XinCun (Jira)
song XinCun created HBASE-24468: --- Summary: Add region info when log meessages in HStore. Key: HBASE-24468 URL: https://issues.apache.org/jira/browse/HBASE-24468 Project: HBase Issue Type:

[jira] [Commented] (HBASE-24453) BackPort HBASE-20220 to branch-1

2020-05-28 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119255#comment-17119255 ] Reid Chan commented on HBASE-24453: --- Thanks for the contribution. > BackPort HBASE-20220 to branch-1

[jira] [Updated] (HBASE-24441) CacheConfig details logged at Store open is not really useful

2020-05-28 Thread song XinCun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] song XinCun updated HBASE-24441: Affects Version/s: (was: 2.2.5) 3.0.0-alpha-1 > CacheConfig details

[jira] [Updated] (HBASE-24441) CacheConfig details logged at Store open is not really useful

2020-05-28 Thread song XinCun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] song XinCun updated HBASE-24441: Affects Version/s: 2.2.5 > CacheConfig details logged at Store open is not really useful >

[jira] [Updated] (HBASE-24441) CacheConfig details logged at Store open is not really useful

2020-05-28 Thread song XinCun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] song XinCun updated HBASE-24441: Component/s: regionserver logging > CacheConfig details logged at Store open is

[jira] [Commented] (HBASE-24441) CacheConfig details logged at Store open is not really useful

2020-05-28 Thread song XinCun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119247#comment-17119247 ] song XinCun commented on HBASE-24441: - Log after patch would look like: {code:java} 2020-05-28

[jira] [Resolved] (HBASE-24453) BackPort HBASE-20220 to branch-1

2020-05-28 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-24453. --- Hadoop Flags: Reviewed Resolution: Fixed > BackPort HBASE-20220 to branch-1 >

[jira] [Updated] (HBASE-24453) BackPort HBASE-20220 to branch-1

2020-05-28 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-24453: -- Component/s: rsgroup > BackPort HBASE-20220 to branch-1 > > >

[jira] [Updated] (HBASE-24453) BackPort HBASE-20220 to branch-1

2020-05-28 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-24453: -- Fix Version/s: 1.7.0 > BackPort HBASE-20220 to branch-1 > > >

[GitHub] [hbase] Reidddddd merged pull request #1798: HBASE-24453 BackPort HBASE-20220 to branch-1

2020-05-28 Thread GitBox
Reidd merged pull request #1798: URL: https://github.com/apache/hbase/pull/1798 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] bsglz commented on a change in pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…

2020-05-28 Thread GitBox
bsglz commented on a change in pull request #1797: URL: https://github.com/apache/hbase/pull/1797#discussion_r432238067 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java ## @@ -1908,9 +1907,9 @@ protected void

[GitHub] [hbase] bsglz commented on a change in pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…

2020-05-28 Thread GitBox
bsglz commented on a change in pull request #1797: URL: https://github.com/apache/hbase/pull/1797#discussion_r432238002 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java ## @@ -122,9 +121,9 @@ public SplitLogManager(MasterServices

[GitHub] [hbase] Apache-HBase commented on pull request #1800: HBASE-22287 inifinite retries on failed server in RSProcedureDispatcher

2020-05-28 Thread GitBox
Apache-HBase commented on pull request #1800: URL: https://github.com/apache/hbase/pull/1800#issuecomment-635735653 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] songxincun opened a new pull request #1801: [HBASE-24441]CacheConfig details logged at Store open is not really u…

2020-05-28 Thread GitBox
songxincun opened a new pull request #1801: URL: https://github.com/apache/hbase/pull/1801 …seful This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Apache-HBase commented on pull request #1800: HBASE-22287 inifinite retries on failed server in RSProcedureDispatcher

2020-05-28 Thread GitBox
Apache-HBase commented on pull request #1800: URL: https://github.com/apache/hbase/pull/1800#issuecomment-635733901 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-23340) hmaster /hbase/replication/rs session expired (hbase replication default value is true, we don't use ) causes logcleaner can not clean oldWALs, which resulits in old

2020-05-28 Thread Chao Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119233#comment-17119233 ] Chao Wang commented on HBASE-23340: --- hello , I find this issue in my environment .I  think you can add

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce a new master rpc service to locate meta region through root region

2020-05-28 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-635731093 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24438) Stale ServerCrashProcedure task in HBase Master UI

2020-05-28 Thread Andrey Elenskiy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119226#comment-17119226 ] Andrey Elenskiy commented on HBASE-24438: - The only way I was able to reproduce this is by

[GitHub] [hbase] bsglz commented on pull request #1799: HBASE-24455 Correct the doc of "On the number of column families"

2020-05-28 Thread GitBox
bsglz commented on pull request #1799: URL: https://github.com/apache/hbase/pull/1799#issuecomment-635723950 > Should we clearly say, then, that, although triggered at table/region level compactions happen per store? IMO, it is unnessary since folks can get it in other chapters,

[GitHub] [hbase] ddupg commented on a change in pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-05-28 Thread GitBox
ddupg commented on a change in pull request #1782: URL: https://github.com/apache/hbase/pull/1782#discussion_r432225834 ## File path: hbase-protocol-shaded/src/main/protobuf/server/rsgroup/RSGroupAdmin.proto ## @@ -183,4 +191,7 @@ service RSGroupAdminService { rpc

[jira] [Commented] (HBASE-24436) The store file open and close thread pool should be shared at the region level

2020-05-28 Thread Junhong Xu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119205#comment-17119205 ] Junhong Xu commented on HBASE-24436: bq. And how much slower open a store which has 20 storefiles VS

[GitHub] [hbase] Apache9 commented on a change in pull request #1753: HBASE-24408 Introduce a general 'local region' to store data on master

2020-05-28 Thread GitBox
Apache9 commented on a change in pull request #1753: URL: https://github.com/apache/hbase/pull/1753#discussion_r432215118 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/store/LocalStore.java ## @@ -0,0 +1,148 @@ +/** + * Licensed to the Apache

[GitHub] [hbase] sguggilam commented on a change in pull request #1755: HBASE-24069 Provide an ExponentialBackOffPolicy sleep between failed …

2020-05-28 Thread GitBox
sguggilam commented on a change in pull request #1755: URL: https://github.com/apache/hbase/pull/1755#discussion_r432207528 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ## @@ -2079,16 +2085,29 @@ private void unassign(final

[GitHub] [hbase] sguggilam commented on a change in pull request #1755: HBASE-24069 Provide an ExponentialBackOffPolicy sleep between failed …

2020-05-28 Thread GitBox
sguggilam commented on a change in pull request #1755: URL: https://github.com/apache/hbase/pull/1755#discussion_r432203290 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ## @@ -2079,16 +2085,29 @@ private void unassign(final

[GitHub] [hbase] Apache-HBase commented on pull request #1800: HBASE-22287 inifinite retries on failed server in RSProcedureDispatcher

2020-05-28 Thread GitBox
Apache-HBase commented on pull request #1800: URL: https://github.com/apache/hbase/pull/1800#issuecomment-635697137 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] sguggilam commented on a change in pull request #1755: HBASE-24069 Provide an ExponentialBackOffPolicy sleep between failed …

2020-05-28 Thread GitBox
sguggilam commented on a change in pull request #1755: URL: https://github.com/apache/hbase/pull/1755#discussion_r432203290 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ## @@ -2079,16 +2085,29 @@ private void unassign(final

[jira] [Commented] (HBASE-24458) release scripts using docker on mac os should specify needed disk consistency

2020-05-28 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119191#comment-17119191 ] Sean Busbey commented on HBASE-24458: - Here's the docs

[jira] [Assigned] (HBASE-24467) Backport HBASE-23963: Split TestFromClientSide; it takes too long to complete timing out

2020-05-28 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-24467: -- Assignee: Guanghao Zhang > Backport HBASE-23963: Split TestFromClientSide; it takes

[jira] [Commented] (HBASE-24389) Introduce a new master rpc service to locate meta region through root region

2020-05-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119187#comment-17119187 ] Duo Zhang commented on HBASE-24389: --- {quote} We already have client-side Interfaces – Registry or

[jira] [Created] (HBASE-24467) Backport HBASE-23963: Split TestFromClientSide; it takes too long to complete timing out

2020-05-28 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24467: -- Summary: Backport HBASE-23963: Split TestFromClientSide; it takes too long to complete timing out Key: HBASE-24467 URL: https://issues.apache.org/jira/browse/HBASE-24467

[jira] [Commented] (HBASE-24436) The store file open and close thread pool should be shared at the region level

2020-05-28 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119183#comment-17119183 ] Guanghao Zhang commented on HBASE-24436: {quote}How long open or close only one storefile take?

[jira] [Commented] (HBASE-24389) Introduce a new master rpc service to locate meta region through root region

2020-05-28 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119182#comment-17119182 ] Michael Stack commented on HBASE-24389: --- I had a few quests above [~zhangduo]? We already have

[GitHub] [hbase] Apache9 commented on pull request #1800: HBASE-22287 inifinite retries on failed server in RSProcedureDispatcher

2020-05-28 Thread GitBox
Apache9 commented on pull request #1800: URL: https://github.com/apache/hbase/pull/1800#issuecomment-635690562 Maybe better to change the title? It does not solve the infinite retries but to make the retry less aggressive.

[GitHub] [hbase] ndimiduk commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-28 Thread GitBox
ndimiduk commented on pull request #1786: URL: https://github.com/apache/hbase/pull/1786#issuecomment-635688358 > Interesting. Wonder why the change was made. Looks like it was slipped in with https://issues.apache.org/jira/browse/HBASE-15065. There's some interesting comments as

[jira] [Commented] (HBASE-22287) inifinite retries on failed server in RSProcedureDispatcher

2020-05-28 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119181#comment-17119181 ] Michael Stack commented on HBASE-22287: --- Put up a patch to add some backoff so we don't fill logs.

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce a new master rpc service to locate meta region through root region

2020-05-28 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r432194231 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java ## @@ -1403,6 +1409,21 @@ private static void

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce a new master rpc service to locate meta region through root region

2020-05-28 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r432194015 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java ## @@ -2185,4 +2206,27 @@ private static Put addSequenceNum(Put p,

[GitHub] [hbase] saintstack opened a new pull request #1800: HBASE-22287 inifinite retries on failed server in RSProcedureDispatcher

2020-05-28 Thread GitBox
saintstack opened a new pull request #1800: URL: https://github.com/apache/hbase/pull/1800 Add some backoff. Does not break off retrying. This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HBASE-24347) Hadoop2 profiles are both active when pre-commit PR builds run

2020-05-28 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119180#comment-17119180 ] Josh Elser commented on HBASE-24347: We don't have {{jenkins_precommit_github_yetus.sh}} in

[GitHub] [hbase] ndimiduk commented on a change in pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-28 Thread GitBox
ndimiduk commented on a change in pull request #1786: URL: https://github.com/apache/hbase/pull/1786#discussion_r432193207 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SplitPlanFirstComparator.java ## @@ -0,0 +1,40 @@ +/* + * Licensed to

[GitHub] [hbase] bharathv commented on a change in pull request #1755: HBASE-24069 Provide an ExponentialBackOffPolicy sleep between failed …

2020-05-28 Thread GitBox
bharathv commented on a change in pull request #1755: URL: https://github.com/apache/hbase/pull/1755#discussion_r432192279 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ## @@ -2079,16 +2085,29 @@ private void unassign(final

[GitHub] [hbase] joshelser commented on pull request #1648: HBASE-8458 Support for batch version of checkAndMutate()

2020-05-28 Thread GitBox
joshelser commented on pull request #1648: URL: https://github.com/apache/hbase/pull/1648#issuecomment-635684687 Sorry Toshi! Rough week :) > It looks like there were no test failures in the last QA but it reported the test failure. It seems like something errors other than test

[GitHub] [hbase] joshelser commented on a change in pull request #1648: HBASE-8458 Support for batch version of checkAndMutate()

2020-05-28 Thread GitBox
joshelser commented on a change in pull request #1648: URL: https://github.com/apache/hbase/pull/1648#discussion_r432189368 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CheckAndMutate.java ## @@ -0,0 +1,384 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce a new master rpc service to locate meta region through root region

2020-05-28 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r432190127 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaTableRegionLocator.java ## @@ -0,0 +1,148 @@ +/** + * Licensed to the

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce a new master rpc service to locate meta region through root region

2020-05-28 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r432188121 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractAsyncTableRegionLocator.java ## @@ -0,0 +1,308 @@ +/** + * Licensed to the

[GitHub] [hbase-native-client] joshelser commented on pull request #2: HBASE-24400: Fixup cmake infrastructure to allow dependencies to be built locally

2020-05-28 Thread GitBox
joshelser commented on pull request #2: URL: https://github.com/apache/hbase-native-client/pull/2#issuecomment-635679333 In addition to the minicluster automation for testing, shout when you're ready just to get a "real" hbase up and running. I imagine you can figure it out, but we should

[jira] [Commented] (HBASE-24389) Introduce a new master rpc service to locate meta region through root region

2020-05-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119170#comment-17119170 ] Duo Zhang commented on HBASE-24389: --- {quote} So I think my rephrased question would be, is there a

[jira] [Commented] (HBASE-24416) RegionNormalizer spliting region should not be limited by hbase.normalizer.min.region.count

2020-05-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119171#comment-17119171 ] Hudson commented on HBASE-24416: Results for branch branch-2.2 [build #879 on

[jira] [Created] (HBASE-24466) Release scripts in docker mode should be able to use a named volume for maven repo

2020-05-28 Thread Sean Busbey (Jira)
Sean Busbey created HBASE-24466: --- Summary: Release scripts in docker mode should be able to use a named volume for maven repo Key: HBASE-24466 URL: https://issues.apache.org/jira/browse/HBASE-24466

[GitHub] [hbase-native-client] joshelser commented on a change in pull request #2: HBASE-24400: Fixup cmake infrastructure to allow dependencies to be built locally

2020-05-28 Thread GitBox
joshelser commented on a change in pull request #2: URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r432186426 ## File path: cmake/DownloadFolly.cmake ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [hbase] joshelser commented on pull request #1794: HBASE-24449: Generate version.h include file during compilation.

2020-05-28 Thread GitBox
joshelser commented on pull request #1794: URL: https://github.com/apache/hbase/pull/1794#issuecomment-635677015 A belated +1 from me. Thanks for your help here, Bharath! This is an automated message from the Apache Git

[GitHub] [hbase-native-client] joshelser commented on a change in pull request #2: HBASE-24400: Fixup cmake infrastructure to allow dependencies to be built locally

2020-05-28 Thread GitBox
joshelser commented on a change in pull request #2: URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r432184681 ## File path: cmake/DownloadFolly.cmake ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [hbase] ndimiduk commented on a change in pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-28 Thread GitBox
ndimiduk commented on a change in pull request #1786: URL: https://github.com/apache/hbase/pull/1786#discussion_r432182388 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -18,126 +17,436 @@ */ package

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce a new master rpc service to locate meta region through root region

2020-05-28 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-635669707 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on a change in pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-28 Thread GitBox
ndimiduk commented on a change in pull request #1786: URL: https://github.com/apache/hbase/pull/1786#discussion_r432176087 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -18,126 +17,436 @@ */ package

[jira] [Created] (HBASE-24465) Normalizer should consider region max file size when planning merges

2020-05-28 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-24465: Summary: Normalizer should consider region max file size when planning merges Key: HBASE-24465 URL: https://issues.apache.org/jira/browse/HBASE-24465 Project: HBase

[jira] [Created] (HBASE-24464) Normalizer should have configuration for minimum region size

2020-05-28 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-24464: Summary: Normalizer should have configuration for minimum region size Key: HBASE-24464 URL: https://issues.apache.org/jira/browse/HBASE-24464 Project: HBase

[GitHub] [hbase] ndimiduk commented on a change in pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-28 Thread GitBox
ndimiduk commented on a change in pull request #1786: URL: https://github.com/apache/hbase/pull/1786#discussion_r432174796 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -18,126 +17,436 @@ */ package

[GitHub] [hbase] joshelser commented on a change in pull request #1761: HBASE-21406 "status 'replication'" should not show SINK if the cluste…

2020-05-28 Thread GitBox
joshelser commented on a change in pull request #1761: URL: https://github.com/apache/hbase/pull/1761#discussion_r432173382 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -835,12 +835,16 @@ def status(format, type) r_source_string = ' SOURCE:'

[jira] [Commented] (HBASE-18095) Provide an option for clients to find the server hosting META that does not involve the ZooKeeper client

2020-05-28 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119153#comment-17119153 ] Bharath Vissapragada commented on HBASE-18095: -- > We have dynamic reloading of

[jira] [Created] (HBASE-24463) Allow operator to limit total normalization work per invocation

2020-05-28 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-24463: Summary: Allow operator to limit total normalization work per invocation Key: HBASE-24463 URL: https://issues.apache.org/jira/browse/HBASE-24463 Project: HBase

[GitHub] [hbase] ndimiduk commented on a change in pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-28 Thread GitBox
ndimiduk commented on a change in pull request #1786: URL: https://github.com/apache/hbase/pull/1786#discussion_r432171658 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1911,43 +1912,51 @@ public boolean normalizeRegions() throws

[jira] [Commented] (HBASE-24422) Remove hbase-native-client code from the master branch

2020-05-28 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119151#comment-17119151 ] Josh Elser commented on HBASE-24422: Sounds good to me to clean up the remaining stuff in the main

[GitHub] [hbase] joshelser closed pull request #1365: HBASE-24066 Let HBase master UI act as a maven repo

2020-05-28 Thread GitBox
joshelser closed pull request #1365: URL: https://github.com/apache/hbase/pull/1365 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (HBASE-24066) Expose shaded clients through WebUI as Maven repository

2020-05-28 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved HBASE-24066. Resolution: Incomplete Resolving this as I don't see a path forward for the change at this time.

[GitHub] [hbase] joshelser commented on pull request #1365: HBASE-24066 Let HBase master UI act as a maven repo

2020-05-28 Thread GitBox
joshelser commented on pull request #1365: URL: https://github.com/apache/hbase/pull/1365#issuecomment-635652513 Not seeing a path forward. Closing until we think this is worth doing. This is an automated message from the

[jira] [Commented] (HBASE-22041) [k8s] The crashed node exists in onlineServer forever, and if it holds the meta data, master will start up hang.

2020-05-28 Thread Andrey Elenskiy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119146#comment-17119146 ] Andrey Elenskiy commented on HBASE-22041: - > When did K8S register in DNS the new pod? Given

[GitHub] [hbase] ndimiduk commented on a change in pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-28 Thread GitBox
ndimiduk commented on a change in pull request #1786: URL: https://github.com/apache/hbase/pull/1786#discussion_r432168513 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -18,126 +17,436 @@ */ package

[jira] [Commented] (HBASE-24462) region_mover.rb NoMethodError: undefined method `tmpdir' for Dir:Class

2020-05-28 Thread Siddhi Mehta (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119139#comment-17119139 ] Siddhi Mehta commented on HBASE-24462: -- Adding the snippet below resolves the issue {code:java}

[jira] [Commented] (HBASE-22287) inifinite retries on failed server in RSProcedureDispatcher

2020-05-28 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119138#comment-17119138 ] Michael Stack commented on HBASE-22287: --- Here are logs showing retry 525 and 526 with 100ms in

[GitHub] [hbase] Apache-HBase commented on pull request #1440: HBASE-23113: Improve and add additional Netty configuration for RPC.

2020-05-28 Thread GitBox
Apache-HBase commented on pull request #1440: URL: https://github.com/apache/hbase/pull/1440#issuecomment-635647202 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-24462) region_mover.rb NoMethodError: undefined method `tmpdir' for Dir:Class

2020-05-28 Thread Siddhi Mehta (Jira)
Siddhi Mehta created HBASE-24462: Summary: region_mover.rb NoMethodError: undefined method `tmpdir' for Dir:Class Key: HBASE-24462 URL: https://issues.apache.org/jira/browse/HBASE-24462 Project:

[GitHub] [hbase] saintstack commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-28 Thread GitBox
saintstack commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-635643398 Can't commit till the -1 from JIRA is raised. This is an automated message from the Apache Git Service. To

[jira] [Commented] (HBASE-22120) Replace HTrace with OpenTracing

2020-05-28 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119128#comment-17119128 ] Siyao Meng commented on HBASE-22120: +1 on using OpenTelemetry instead now that it is [in

[jira] [Resolved] (HBASE-24449) Generate version.h include file during compilation

2020-05-28 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada resolved HBASE-24449. -- Fix Version/s: 3.0.0-alpha-1 Resolution: Fixed Not committing to other

[GitHub] [hbase] saintstack commented on a change in pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-28 Thread GitBox
saintstack commented on a change in pull request #1783: URL: https://github.com/apache/hbase/pull/1783#discussion_r432159021 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -590,7 +588,7 @@ void

[GitHub] [hbase] bharathv merged pull request #1794: HBASE-24449: Generate version.h include file during compilation.

2020-05-28 Thread GitBox
bharathv merged pull request #1794: URL: https://github.com/apache/hbase/pull/1794 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] bharathv commented on pull request #1794: HBASE-24449: Generate version.h include file during compilation.

2020-05-28 Thread GitBox
bharathv commented on pull request #1794: URL: https://github.com/apache/hbase/pull/1794#issuecomment-635640305 I was letting @busbey know since he volunteered to be the RM for 3.0.0 and he wouldn't be surprised by a new directory showing up in the release artifacts. I'll go ahead and

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce a new master rpc service to locate meta region through root region

2020-05-28 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-635639973 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on pull request #1751: HBASE-24409: Exposing a function in HBase WALKey to set the table name

2020-05-28 Thread GitBox
saintstack commented on pull request #1751: URL: https://github.com/apache/hbase/pull/1751#issuecomment-635639491 Please open new PR if good reason for undoing this fairly basic tenet. This is an automated message from the

[GitHub] [hbase] saintstack commented on pull request #1751: HBASE-24409: Exposing a function in HBase WALKey to set the table name

2020-05-28 Thread GitBox
saintstack commented on pull request #1751: URL: https://github.com/apache/hbase/pull/1751#issuecomment-635639242 I'm going to close this PR. System internal depends on WALKeys being immutable. This is an automated message

[GitHub] [hbase] saintstack closed pull request #1751: HBASE-24409: Exposing a function in HBase WALKey to set the table name

2020-05-28 Thread GitBox
saintstack closed pull request #1751: URL: https://github.com/apache/hbase/pull/1751 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on a change in pull request #1751: HBASE-24409: Exposing a function in HBase WALKey to set the table name

2020-05-28 Thread GitBox
saintstack commented on a change in pull request #1751: URL: https://github.com/apache/hbase/pull/1751#discussion_r432153953 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALKey.java ## @@ -57,6 +57,14 @@ default long estimatedSerializedSizeOf() { */

[GitHub] [hbase] ndimiduk commented on a change in pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-28 Thread GitBox
ndimiduk commented on a change in pull request #1786: URL: https://github.com/apache/hbase/pull/1786#discussion_r432148644 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -18,126 +17,436 @@ */ package

[GitHub] [hbase] Apache-HBase commented on pull request #1440: HBASE-23113: Improve and add additional Netty configuration for RPC.

2020-05-28 Thread GitBox
Apache-HBase commented on pull request #1440: URL: https://github.com/apache/hbase/pull/1440#issuecomment-635627861 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24389) Introduce a new master rpc service to locate meta region through root region

2020-05-28 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119096#comment-17119096 ] Bharath Vissapragada commented on HBASE-24389: -- I think I see what you mean. I didn't

[GitHub] [hbase] ndimiduk commented on a change in pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-28 Thread GitBox
ndimiduk commented on a change in pull request #1786: URL: https://github.com/apache/hbase/pull/1786#discussion_r432134487 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -18,126 +17,436 @@ */ package

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce a new master rpc service to locate meta region through root region

2020-05-28 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-635594515 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24454) BucketCache disabled instantly before error duration toleration is reached due to timing issue

2020-05-28 Thread Jacob LeBlanc (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119059#comment-17119059 ] Jacob LeBlanc commented on HBASE-24454: --- Sure, I'll contribute a patch. I was thinking the same

[jira] [Assigned] (HBASE-24454) BucketCache disabled instantly before error duration toleration is reached due to timing issue

2020-05-28 Thread Jacob LeBlanc (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob LeBlanc reassigned HBASE-24454: - Assignee: Jacob LeBlanc > BucketCache disabled instantly before error duration

[GitHub] [hbase] saintstack commented on pull request #1794: HBASE-24449: Generate version.h include file during compilation.

2020-05-28 Thread GitBox
saintstack commented on pull request #1794: URL: https://github.com/apache/hbase/pull/1794#issuecomment-635587079 Shout if you need me to merge. Sounds like you'd like signoff by @busbey This is an automated message from

[GitHub] [hbase] saintstack commented on a change in pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…

2020-05-28 Thread GitBox
saintstack commented on a change in pull request #1797: URL: https://github.com/apache/hbase/pull/1797#discussion_r432095352 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java ## @@ -122,9 +121,9 @@ public

  1   2   >